[google gcc-4_9] fix undefined references in debug_info

2014-10-03 Thread Rong Xu
Hi, This patch fixed a bug exposed in build kernel with fdo. We cannot simply overwrite the bb footer in emit_barrier_after_bb as the bb may already have a footer (in this case, a deleted label stmt). We need to output this label because it's a user label and debug_info has a reference to it.

Re: [google gcc-4_9] fix undefined references in debug_info

2014-10-03 Thread Xinliang David Li
This patch should be targeting trunk gcc? David On Fri, Oct 3, 2014 at 9:23 AM, Rong Xu x...@google.com wrote: Hi, This patch fixed a bug exposed in build kernel with fdo. We cannot simply overwrite the bb footer in emit_barrier_after_bb as the bb may already have a footer (in this case,

Re: [google gcc-4_9] fix undefined references in debug_info

2014-10-03 Thread Teresa Johnson
Yes, this needs to be fixed on trunk too. I looked at the history and it has been this way (overwriting the footer) for years. It must be uncommon to have this confluence of events. Thanks, Teresa On Fri, Oct 3, 2014 at 9:28 AM, Xinliang David Li davi...@google.com wrote: This patch should be