Re: [patch][PCH] Do not write/read asm_out_file, take 2

2012-06-21 Thread Joseph S. Myers
On Wed, 20 Jun 2012, Steven Bosscher wrote: This patch was bootstrappedtested on powerpc64-unknown-linux-gnu. The issues with #ident have already been addressed, and this patch adds a new test case, to make sure... OK for trunk? OK. -- Joseph S. Myers jos...@codesourcery.com

[patch][PCH] Do not write/read asm_out_file, take 2

2012-06-19 Thread Steven Bosscher
Hello, The attached patch removes one more #include output.h, this time from c-family/c-pch.c. Anything written out to asm_out_file between pch_init and c_common_write_pch is read back in by c_common_write_pch and dumped to the PCH that's being written out. In c_common_read_pch this data is

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-07 Thread Steven Bosscher
On Thu, Jun 7, 2012 at 7:52 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Steven Bosscher stevenb@gmail.com writes: On Wed, Jun 6, 2012 at 7:15 PM, Paolo Bonzini bonz...@gnu.org wrote: Il 06/06/2012 09:15, Steven Bosscher ha scritto: +    add_asm_printf (%s\n\t.ascii \%s\\n, +  

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-07 Thread Richard Sandiford
Steven Bosscher stevenb@gmail.com writes: On Thu, Jun 7, 2012 at 7:52 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Steven Bosscher stevenb@gmail.com writes: On Wed, Jun 6, 2012 at 7:15 PM, Paolo Bonzini bonz...@gnu.org wrote: Il 06/06/2012 09:15, Steven Bosscher ha scritto:

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Steven Bosscher
On Tue, Jun 5, 2012 at 10:59 AM, Richard Guenther richard.guent...@gmail.com wrote: On Mon, Jun 4, 2012 at 8:23 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, The attached patch removes one more #include output.h, this time from c-family/c-pch.c. Anything written out to

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Richard Guenther
On Wed, Jun 6, 2012 at 9:15 AM, Steven Bosscher stevenb@gmail.com wrote: On Tue, Jun 5, 2012 at 10:59 AM, Richard Guenther richard.guent...@gmail.com wrote: On Mon, Jun 4, 2012 at 8:23 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, The attached patch removes one more #include

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Michael Eager
On 06/06/2012 12:15 AM, Steven Bosscher wrote: On Tue, Jun 5, 2012 at 10:59 AM, Richard Guenther richard.guent...@gmail.com wrote: On Mon, Jun 4, 2012 at 8:23 PM, Steven Bosscherstevenb@gmail.com wrote: Hello, The attached patch removes one more #include output.h, this time from

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Paolo Bonzini
Il 06/06/2012 09:15, Steven Bosscher ha scritto: +add_asm_printf (%s\n\t.ascii \%s\\n, + READONLY_DATA_SECTION_ASM_OP, string); + else Need to escape the string as in mips_output_ascii, of course. :( Paolo

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Steven Bosscher
On Wed, Jun 6, 2012 at 7:15 PM, Paolo Bonzini bonz...@gnu.org wrote: Il 06/06/2012 09:15, Steven Bosscher ha scritto: +    add_asm_printf (%s\n\t.ascii \%s\\n, +                 READONLY_DATA_SECTION_ASM_OP, string); +  else Need to escape the string as in mips_output_ascii, of course. :(

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Steven Bosscher
On Wed, Jun 6, 2012 at 10:45 AM, Richard Guenther richard.guent...@gmail.com wrote: Please split up the patch into one dealing with #ident exclusively and a followup with the other pieces. Hello, This is the patch to deal with #ident. It removes the ASM_OUTPUT_IDENT and IDENT_ASM_OP target

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Michael Eager
On 06/06/2012 02:22 PM, Steven Bosscher wrote: On Wed, Jun 6, 2012 at 10:45 AM, Richard Guenther richard.guent...@gmail.com wrote: Please split up the patch into one dealing with #ident exclusively and a followup with the other pieces. Hello, This is the patch to deal with #ident. It

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Steven Bosscher
On Thu, Jun 7, 2012 at 12:00 AM, Michael Eager ea...@eagercon.com wrote: Please eliminate the comment before microblaze_asm_output_ident(). Better yet, attach the right patch. I somehow managed to attach the wrong one. Re-submitted with proper $SUBJECT and all that. Sorry for the confusion!

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-05 Thread Richard Guenther
On Mon, Jun 4, 2012 at 8:23 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, The attached patch removes one more #include output.h, this time from c-family/c-pch.c. Anything written out to asm_out_file between pch_init and c_common_write_pch is read back in by c_common_write_pch and

[patch][PCH] Do not write/read asm_out_file

2012-06-04 Thread Steven Bosscher
Hello, The attached patch removes one more #include output.h, this time from c-family/c-pch.c. Anything written out to asm_out_file between pch_init and c_common_write_pch is read back in by c_common_write_pch and dumped to the PCH that's being written out. In c_common_read_pch this data is