Re: [patch] Fix ICE on ACATS test for Aarch64 at -O

2016-10-17 Thread Jeff Law
On 10/03/2016 09:45 AM, Eric Botcazou wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01781.html 2016-09-26 Eric Botcazou * expmed.c (expand_shift_1): Add MAY_FAIL parameter and do not assert that the result is non-zero if it is true.

Re: [patch] Fix ICE on ACATS test for Aarch64 at -O

2016-10-11 Thread Eric Botcazou
> Revised patch attached, tested on x86-64/Linux, OK for the mainline? Also tested on Aarch64/Linux, where it cleans up the ACATS testsuite: --- mail-report.log.0 2016-10-11 04:01:06.020972999 -0700 +++ mail-report.log 2016-10-11 14:27:42.110972999 -0700 @@ -2,12 +2,10 @@ LAST_UPDATED:

Re: [patch] Fix ICE on ACATS test for Aarch64 at -O

2016-10-11 Thread Eric Botcazou
Ping^2: https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01781.html > 2016-09-26 Eric Botcazou > > * expmed.c (expand_shift_1): Add MAY_FAIL parameter and do not assert > that the result is non-zero if it is true. > (maybe_expand_shift): New wrapper

Re: [patch] Fix ICE on ACATS test for Aarch64 at -O

2016-10-03 Thread Eric Botcazou
Ping: https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01781.html > 2016-09-26 Eric Botcazou > > * expmed.c (expand_shift_1): Add MAY_FAIL parameter and do not assert > that the result is non-zero if it is true. > (maybe_expand_shift): New wrapper around

Re: [patch] Fix ICE on ACATS test for Aarch64 at -O

2016-09-26 Thread Eric Botcazou
> So while emit_store_flag_force knows what to do upon NULL return, I'm > not sure the other users of expand_shift/expand_shift_1 do. Revised patch attached, tested on x86-64/Linux, OK for the mainline? 2016-09-26 Eric Botcazou * expmed.c (expand_shift_1):

Re: [patch] Fix ICE on ACATS test for Aarch64 at -O

2016-09-21 Thread Eric Botcazou
> Is this really safe. If I look at where we call > expand_shift/expand_shift_1 I get real worried that we could end up > using that NULL value in a context where it's not expected. > > So while emit_store_flag_force knows what to do upon NULL return, I'm > not sure the other users of

Re: [patch] Fix ICE on ACATS test for Aarch64 at -O

2016-09-19 Thread Jeff Law
On 09/16/2016 04:05 PM, Eric Botcazou wrote: Hi, for the attached reduced testcase, the ICE is: eric@polaris:~/gnat/bugs/P901-028> ~/build/gcc/aarch64-linux/gcc/gnat1 -quiet p.adb -O -I ~/build/gcc/aarch64-linux/gcc/ada/rts +===GNAT BUG

[patch] Fix ICE on ACATS test for Aarch64 at -O

2016-09-16 Thread Eric Botcazou
Hi, for the attached reduced testcase, the ICE is: eric@polaris:~/gnat/bugs/P901-028> ~/build/gcc/aarch64-linux/gcc/gnat1 -quiet p.adb -O -I ~/build/gcc/aarch64-linux/gcc/ada/rts +===GNAT BUG DETECTED==+ | 7.0.0 20160914 (experimental) [trunk