Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-28 Thread Thomas Schwinge
Hi! On Wed, 20 May 2015 14:30:38 -0600, Jeff Law l...@redhat.com wrote: On 05/20/2015 11:04 AM, Andreas Tobler wrote: the attached patch enables some PIE tests on FreeBSD. Wouldn't it be better to remove the target selector and instead add: /* { dg-require-effective-target pie } */ In

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-26 Thread Jeff Law
On 05/25/2015 06:42 AM, Dominique Dhumieres wrote: Wouldn't it be better to remove the target selector and instead add: /* { dg-require-effective-target pie } */ ... This allows the tests to be run on Darwin and fail because the code generated does not match the scan-assembler: FAIL:

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-26 Thread Jeff Law
On 05/25/2015 01:52 PM, Andreas Tobler wrote: On 25.05.15 14:42, Dominique Dhumieres wrote: Wouldn't it be better to remove the target selector and instead add: /* { dg-require-effective-target pie } */ ... This allows the tests to be run on Darwin and fail because the code generated does

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-25 Thread Andreas Tobler
On 22.05.15 23:47, Jeff Law wrote: On 05/21/2015 02:01 PM, Andreas Tobler wrote: On 21.05.15 20:14, Andreas Tobler wrote: On 20.05.15 22:30, Jeff Law wrote: On 05/20/2015 11:04 AM, Andreas Tobler wrote: Hi, the attached patch enables some PIE tests on FreeBSD. Ok for trunk? Thanks,

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-25 Thread Dominique Dhumieres
Wouldn't it be better to remove the target selector and instead add: /* { dg-require-effective-target pie } */ ... This allows the tests to be run on Darwin and fail because the code generated does not match the scan-assembler: FAIL: gcc.target/i386/iinline-attr-2.c scan-assembler p2align

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-25 Thread Andreas Tobler
On 25.05.15 14:42, Dominique Dhumieres wrote: Wouldn't it be better to remove the target selector and instead add: /* { dg-require-effective-target pie } */ ... This allows the tests to be run on Darwin and fail because the code generated does not match the scan-assembler: FAIL:

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-22 Thread Jeff Law
On 05/21/2015 02:01 PM, Andreas Tobler wrote: On 21.05.15 20:14, Andreas Tobler wrote: On 20.05.15 22:30, Jeff Law wrote: On 05/20/2015 11:04 AM, Andreas Tobler wrote: Hi, the attached patch enables some PIE tests on FreeBSD. Ok for trunk? Thanks, Andreas 2015-05-20 Andreas Tobler

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-21 Thread Andreas Tobler
On 20.05.15 22:30, Jeff Law wrote: On 05/20/2015 11:04 AM, Andreas Tobler wrote: Hi, the attached patch enables some PIE tests on FreeBSD. Ok for trunk? Thanks, Andreas 2015-05-20 Andreas Tobler andre...@gcc.gnu.org * gcc.target/i386/pr32219-1.c: Enable test on FreeBSD. *

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-21 Thread Andreas Tobler
On 21.05.15 20:14, Andreas Tobler wrote: On 20.05.15 22:30, Jeff Law wrote: On 05/20/2015 11:04 AM, Andreas Tobler wrote: Hi, the attached patch enables some PIE tests on FreeBSD. Ok for trunk? Thanks, Andreas 2015-05-20 Andreas Tobler andre...@gcc.gnu.org *

[patch] testsuite enable PIE tests on FreeBSD

2015-05-20 Thread Andreas Tobler
Hi, the attached patch enables some PIE tests on FreeBSD. Ok for trunk? Thanks, Andreas 2015-05-20 Andreas Tobler andre...@gcc.gnu.org * gcc.target/i386/pr32219-1.c: Enable test on FreeBSD. * gcc.target/i386/pr32219-2.c: Likewise. * gcc.target/i386/pr32219-3.c:

Re: [patch] testsuite enable PIE tests on FreeBSD

2015-05-20 Thread Jeff Law
On 05/20/2015 11:04 AM, Andreas Tobler wrote: Hi, the attached patch enables some PIE tests on FreeBSD. Ok for trunk? Thanks, Andreas 2015-05-20 Andreas Tobler andre...@gcc.gnu.org * gcc.target/i386/pr32219-1.c: Enable test on FreeBSD. * gcc.target/i386/pr32219-2.c: Likewise.