Re: [pph] Buffer overrun in preprocessor symbol replay

2011-03-10 Thread Diego Novillo
On 11-03-09 09:01 PM, Lawrence Crowl wrote: Index: gcc/cp/ChangeLog.pph 2011-03-09 Lawrence Crowl cr...@google.com * pph.c (pth_dump_identifiers): Split cpp_idents_used::max_length into max_ident_length and max_value_length. (pth_save_identifiers): Likewise.

[pph] Buffer overrun in preprocessor symbol replay

2011-03-09 Thread Lawrence Crowl
In my last PPH change, I eliminated the redundancy in the preprocessor identifier lookaside table by removing the name of the identifier from the head of the macro value. This later led to a buffer overrun in libcpp/symtab.c cpp_lt_replay. The buffer was allocated based on the value string size,