On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab sch...@linux-m68k.org wrote:
gch...@google.com (Gabriel Charette) writes:
+ set expectedSum [exec tr -d \} [exec cut -f 4 -d\
$xdiff_entry]]
$xdiffentry is set to something like {{pph asm diff 123456}}, so i
need tr and cut to
Gabriel Charette gch...@google.com writes:
On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab sch...@linux-m68k.org
wrote:
gch...@google.com (Gabriel Charette) writes:
+ set expectedSum [exec tr -d \} [exec cut -f 4 -d\
$xdiff_entry]]
$xdiffentry is set to something like
On Mon, Jul 18, 2011 at 3:05 PM, Andreas Schwab sch...@linux-m68k.org wrote:
Gabriel Charette gch...@google.com writes:
On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab sch...@linux-m68k.org
wrote:
gch...@google.com (Gabriel Charette) writes:
+ set expectedSum [exec tr -d \}
gch...@google.com (Gabriel Charette) writes:
+ set expectedSum [exec tr -d \} [exec cut -f 4 -d\
$xdiff_entry]]
+ set actualSum [exec cut -f 1 -d\ [exec sum $diff_result]]
You don't need cut and tr if you have tcl.
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
This patch adds an expected checksum for the tests expecting an asm diff.
This way if we were expecting an asm diff, still get one, but a different one,
we know (before this patch we would ignore this, generating an XFAIL as usual,
as the status of having an asm diff itself hadn't changed).
I
Reviewed in person by Lawrence.
Shortened XFAIL message from previous patch.
Also, quick side note, in the first description of this patch I said I used
exec grep, I meant exec diff.
Gab
2011-07-15 Gabriel Charette gch...@google.com
* g++.dg/pph/c1builtin-integral.cc: Add expected
OK with the change below.
Diego.
http://codereview.appspot.com/4744043/diff/3001/gcc/testsuite/lib/dg-pph.exp
File gcc/testsuite/lib/dg-pph.exp (right):
http://codereview.appspot.com/4744043/diff/3001/gcc/testsuite/lib/dg-pph.exp#newcode131
gcc/testsuite/lib/dg-pph.exp:131: set adiff [catch
On 7/15/11, Gabriel Charette gch...@google.com wrote:
This patch adds an expected checksum for the tests expecting an asm diff.
This way if we were expecting an asm diff, still get one, but a different
one, we know (before this patch we would ignore this, generating an XFAIL as
usual, as the
On 7/15/11, Lawrence Crowl cr...@google.com wrote:
On 7/15/11, Gabriel Charette gch...@google.com wrote:
This patch adds an expected checksum for the tests expecting an asm diff.
This way if we were expecting an asm diff, still get one, but a different
one, we know (before this patch we would
See below.
http://codereview.appspot.com/4744043/diff/3001/gcc/testsuite/lib/dg-pph.exp
File gcc/testsuite/lib/dg-pph.exp (right):
http://codereview.appspot.com/4744043/diff/3001/gcc/testsuite/lib/dg-pph.exp#newcode131
gcc/testsuite/lib/dg-pph.exp:131: set adiff [catch {exec diff
$bname.s-pph
On Fri, Jul 15, 2011 at 19:21, gch...@google.com wrote:
It's less affected by merges (in particular the merge timestamp doesn't
show up in the diff, so unless a merge from trunk changes the actual
assembly, the diff is the same as before)
Ah, good point.
Also, the generation of checksums
11 matches
Mail list logo
