Re: [pph] Free buffers used during tree encoding/decoding

2011-08-04 Thread Diego Novillo
On Wed, Aug 3, 2011 at 14:15, Gabriel Charette gch...@google.com wrote: We will probably need the strings in here until the end of the compilation, so we could either just not free it (i.e. memory leak, but allow important when program is over...) Or we could strcpy the strings pph'ed in,

[pph] Free buffers used during tree encoding/decoding

2011-07-28 Thread Diego Novillo
Noticed this while debugging the new tree encoding cache. No functional changes. This frees the memory used by the buffers used during tree streaming. It also moves the reader and writer data into a union to better distinguish them. Tested on x86_64. Diego. * pph-streamer.h

Re: [pph] Free buffers used during tree encoding/decoding

2011-07-28 Thread Lawrence Crowl
I'm getting massive failures after incorporating this change: bytecode stream: trying to read 1735 bytes after the end of the input buffer where the number of bytes changes. Suggestions? On 7/28/11, Diego Novillo dnovi...@google.com wrote: Noticed this while debugging the new tree

Re: [pph] Free buffers used during tree encoding/decoding

2011-07-28 Thread Diego Novillo
On Thu, Jul 28, 2011 at 16:30, Lawrence Crowl cr...@google.com wrote: I'm getting massive failures after incorporating this change:   bytecode stream: trying to read 1735 bytes after the end of the   input buffer where the number of bytes changes.  Suggestions? Odd. I'm getting the usual