Re: [rtl] Harden 'set_noop_p' for non-constant selectors [PR94279]

2020-04-29 Thread Thomas Schwinge
MD GCN offloading, we only care about master >>> branch.) >> >> I don't think it's needed prior to GCC 9, and then only for amdgcn which >> was probably not widely used. > > Based on that, OK for master and GCC 9. Thanks for the quick review. I'll later see about ba

Re: [rtl] Harden 'set_noop_p' for non-constant selectors [PR94279]

2020-04-22 Thread Richard Sandiford
Andrew Stubbs writes: > On 22/04/2020 17:43, Thomas Schwinge wrote: >> In "[amdgcn] internal compiler error: RTL >> check: expected code 'const_int', have 'reg' in rtx_to_poly_int64, at >> rtl.h:2379", we recently found that that it's wrong to expect constant >>

Re: [rtl] Harden 'set_noop_p' for non-constant selectors [PR94279]

2020-04-22 Thread Andrew Stubbs
On 22/04/2020 17:43, Thomas Schwinge wrote: In "[amdgcn] internal compiler error: RTL check: expected code 'const_int', have 'reg' in rtx_to_poly_int64, at rtl.h:2379", we recently found that that it's wrong to expect constant selectors, at least in the current code

[rtl] Harden 'set_noop_p' for non-constant selectors [PR94279] (was: [Patch, RTL] Eliminate redundant vec_select moves)

2020-04-22 Thread Thomas Schwinge
lly buggy already, but it already does contain the pattern that 'INTVAL' is used on something without making sure that we're actually dealing with a constant selector. (Has that maybe have been an impossible scenario back then?) Anyway. Attached is a WIP patch "[rtl] Harden 'set_noop_p' f