Re: C++ PATCH for c++/70449 (ICE when printing a filename of unknown location)

2016-03-31 Thread Jeff Law
On 03/31/2016 08:14 AM, Marek Polacek wrote: On Wed, Mar 30, 2016 at 11:51:26PM +0100, Manuel López-Ibáñez wrote: On 30 March 2016 at 23:42, Manuel López-Ibáñez wrote: On 30/03/16 17:14, Marek Polacek wrote: This test ICEs since the addition of the assert in pp_string

Re: C++ PATCH for c++/70449 (ICE when printing a filename of unknown location)

2016-03-31 Thread Marek Polacek
On Wed, Mar 30, 2016 at 11:51:26PM +0100, Manuel López-Ibáñez wrote: > On 30 March 2016 at 23:42, Manuel López-Ibáñez wrote: > > On 30/03/16 17:14, Marek Polacek wrote: > >> > >> This test ICEs since the addition of the assert in pp_string which ensures > >> that > >> we

Re: C++ PATCH for c++/70449 (ICE when printing a filename of unknown location)

2016-03-30 Thread Manuel López-Ibáñez
On 30 March 2016 at 23:42, Manuel López-Ibáñez wrote: > On 30/03/16 17:14, Marek Polacek wrote: >> >> This test ICEs since the addition of the assert in pp_string which ensures >> that >> we aren't trying to print an empty string. But that's what happens here, >> the >>

Re: C++ PATCH for c++/70449 (ICE when printing a filename of unknown location)

2016-03-30 Thread Manuel López-Ibáñez
On 30/03/16 17:14, Marek Polacek wrote: This test ICEs since the addition of the assert in pp_string which ensures that we aren't trying to print an empty string. But that's what happens here, the location is actually UNKNOWN_LOCATION, so LOCATION_FILE on that yields null. Fixed byt not trying

Re: C++ PATCH for c++/70449 (ICE when printing a filename of unknown location)

2016-03-30 Thread Jason Merrill
OK. Jason

C++ PATCH for c++/70449 (ICE when printing a filename of unknown location)

2016-03-30 Thread Marek Polacek
This test ICEs since the addition of the assert in pp_string which ensures that we aren't trying to print an empty string. But that's what happens here, the location is actually UNKNOWN_LOCATION, so LOCATION_FILE on that yields null. Fixed byt not trying to print the filename of UNKNOWN_LOCATION.