Re: Fix PR 85423 (Re: Fix PRs 80463, 83972, 83480)

2018-04-23 Thread Jakub Jelinek
On Mon, Apr 23, 2018 at 05:03:09PM +0300, Andrey Belevantsev wrote: > I have put the test in gcc.dg though it requires -march=nano. Do you want > me to create an extra machine-dependent test? If it is a compile time test, no need for that. Just add /* { dg-additional-options "-march=nano" {

Re: Fix PR 85423 (Re: Fix PRs 80463, 83972, 83480)

2018-04-23 Thread Alexander Monakov
On Mon, 23 Apr 2018, Andrey Belevantsev wrote: > Hello, > > So this PR shows that I have incorrectly mirrored the conditional from > sched-deps.c that creates the dependence from a debug insn on the previous > insn (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80463#c3 for the > hunk). Thus

Fix PR 85423 (Re: Fix PRs 80463, 83972, 83480)

2018-04-23 Thread Andrey Belevantsev
Hello, So this PR shows that I have incorrectly mirrored the conditional from sched-deps.c that creates the dependence from a debug insn on the previous insn (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80463#c3 for the hunk). Thus we have incorrectly discarded some legitimate debug-debug

Re: Fix PRs 80463, 83972, 83480

2018-04-10 Thread Andrey Belevantsev
On 09.04.2018 21:23, Jakub Jelinek wrote: > On Mon, Apr 09, 2018 at 01:30:12PM +0300, Andrey Belevantsev wrote: >> I think that should be fine, that is, as long as the insn moved up through >> all those debug insns, the copy will do that as well. It's that >> problematic conditional in

Re: Fix PRs 80463, 83972, 83480

2018-04-09 Thread Jakub Jelinek
On Mon, Apr 09, 2018 at 01:30:12PM +0300, Andrey Belevantsev wrote: > I think that should be fine, that is, as long as the insn moved up through > all those debug insns, the copy will do that as well. It's that > problematic conditional in sched-deps.c that we should take care of. > > I've

Re: Fix PRs 80463, 83972, 83480

2018-04-09 Thread Andrey Belevantsev
On 06.04.2018 19:18, Alexander Monakov wrote: > On Tue, 3 Apr 2018, Andrey Belevantsev wrote: > >> Hello, >> >> In these PRs we deal with the dependencies we are forced to make between a >> debug insn and its previous insn (unless bb head). In the latter case, if >> such an insn has been moved,

Re: Fix PRs 80463, 83972, 83480

2018-04-06 Thread Alexander Monakov
On Tue, 3 Apr 2018, Andrey Belevantsev wrote: > Hello, > > In these PRs we deal with the dependencies we are forced to make between a > debug insn and its previous insn (unless bb head). In the latter case, if > such an insn has been moved, we fixup its movement so it aligns with the >

Fix PRs 80463, 83972, 83480

2018-04-03 Thread Andrey Belevantsev
Hello, In these PRs we deal with the dependencies we are forced to make between a debug insn and its previous insn (unless bb head). In the latter case, if such an insn has been moved, we fixup its movement so it aligns with the sel-sched invariants. We also carefully adjust seqnos in the case