Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-02-05 Thread Richard Henderson
On 02/04/2014 09:35 AM, Jan Hubicka wrote: On 02/04/2014 08:48 AM, Jan Hubicka wrote: How things are supposed to work in this case? So perhaps we need scheduler to understand and move around the ARGS_SIZE note? I believe we do need to have the scheduler move the notes around. If we need

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-02-05 Thread Richard Henderson
This time with the patch... On 02/05/2014 07:40 AM, Richard Henderson wrote: On 02/04/2014 09:35 AM, Jan Hubicka wrote: On 02/04/2014 08:48 AM, Jan Hubicka wrote: How things are supposed to work in this case? So perhaps we need scheduler to understand and move around the ARGS_SIZE note? I

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-02-05 Thread Jan Hubicka
I had a brief look at find_modifiable_mems, which seems to be the only kind of schedule-time dependency breaking that we do. I started writing some new code that would handle REG_ARGS_SIZE, but then considered that wasn't terribly appropriate for stage4. So I've left off with

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-02-04 Thread Richard Henderson
On 01/01/2014 06:23 AM, Jan Hubicka wrote: last_sp_adjust = 0; + /* We no longer adjust stack size. Whoever adjusted it earlier + hopefully got the note right. */ + note = find_reg_note (insn, REG_ARGS_SIZE, NULL_RTX); + if (note) +

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-02-04 Thread Jan Hubicka
On 01/01/2014 06:23 AM, Jan Hubicka wrote: last_sp_adjust = 0; + /* We no longer adjust stack size. Whoever adjusted it earlier +hopefully got the note right. */ + note = find_reg_note (insn, REG_ARGS_SIZE, NULL_RTX); + if (note) +

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-02-04 Thread Richard Henderson
On 02/04/2014 08:48 AM, Jan Hubicka wrote: How things are supposed to work in this case? So perhaps we need scheduler to understand and move around the ARGS_SIZE note? I believe we do need to have the scheduler move the notes around. r~

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-02-04 Thread Jan Hubicka
On 02/04/2014 08:48 AM, Jan Hubicka wrote: How things are supposed to work in this case? So perhaps we need scheduler to understand and move around the ARGS_SIZE note? I believe we do need to have the scheduler move the notes around. If we need notes on non-stack adjusting insns as you

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-02-04 Thread Richard Henderson
On 02/04/2014 09:35 AM, Jan Hubicka wrote: I am not terribly familiar with the code, will you look into it or shall I give it a try? I'm looking at it. Was there a PR for the Go bootstrap failure? r~

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-23 Thread Jan Hubicka
FAIL: gcc.dg/guality/pr54693-2.c -O3 -fomit-frame-pointer -funroll-loops line 21 i == v + 1 FAIL: gcc.target/i386/pr35767-5.c scan-assembler-not movups Should we fix FAIL: gcc.target/i386/pr35767-5.c scan-assembler-not movups I will look into this one. It did not failed for me

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-22 Thread H.J. Lu
On Tue, Jan 21, 2014 at 3:55 PM, Jan Hubicka hubi...@ucw.cz wrote: On 01/17/14 14:32, Jan Hubicka wrote: * combine-stack-adj.c (combine_stack_adjustments_for_block): Remove ARG_SIZE note when adjustment was eliminated. Ping... This patch prevents me from switching the

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-21 Thread Jeff Law
On 01/17/14 14:32, Jan Hubicka wrote: * combine-stack-adj.c (combine_stack_adjustments_for_block): Remove ARG_SIZE note when adjustment was eliminated. Ping... This patch prevents me from switching the accumulate-args default for generic and I am waiting for that witht he

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-21 Thread Jan Hubicka
On 01/17/14 14:32, Jan Hubicka wrote: * combine-stack-adj.c (combine_stack_adjustments_for_block): Remove ARG_SIZE note when adjustment was eliminated. Ping... This patch prevents me from switching the accumulate-args default for generic and I am waiting for that witht he inliner

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-17 Thread Jan Hubicka
* combine-stack-adj.c (combine_stack_adjustments_for_block): Remove ARG_SIZE note when adjustment was eliminated. Ping... This patch prevents me from switching the accumulate-args default for generic and I am waiting for that witht he inliner tunning, so there is quite a dependency

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-02 Thread Ryan Mansfield
On 14-01-01 09:23 AM, Jan Hubicka wrote: Here insn 765 gets adjusted for insn766 wihtout updating REG_ARGS_SIZE. This is IMO not bug in scheduler but bug in fact that insn 775 should not have the note on it when it is not adjusting stack pointer. This is because originally it was push

Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-01 Thread Jan Hubicka
Hi, this patch fixes ICE seen with -mno-accumulate-outgoing-args bootstrap building go runtime. The ICE is in dwarf2cfi.c while checking that on all paths into given basic block stack frames are same. It goes away either with disabling crossjumping or sched2 but the problem IMO really