Re: Fix ipa-inline ICE

2018-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2018 at 11:28:26AM +0100, Jan Hubicka wrote: > > On Wed, Jan 31, 2018 at 10:16:10AM +0100, Jan Hubicka wrote: > > > > On Wed, Jan 31, 2018 at 09:51:31AM +0100, Christophe Lyon wrote: > > > > > Even with Rainer's fix, I've noticed that the new test fails on > > > > > arm/aarch64: >

Re: Fix ipa-inline ICE

2018-01-31 Thread Jan Hubicka
> On Wed, Jan 31, 2018 at 10:16:10AM +0100, Jan Hubicka wrote: > > > On Wed, Jan 31, 2018 at 09:51:31AM +0100, Christophe Lyon wrote: > > > > Even with Rainer's fix, I've noticed that the new test fails on > > > > arm/aarch64: > > > > FAIL: g++.dg/torture/pr81360.C -O2 -flto -fuse-linker-plugin

Re: Fix ipa-inline ICE

2018-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2018 at 10:16:10AM +0100, Jan Hubicka wrote: > > On Wed, Jan 31, 2018 at 09:51:31AM +0100, Christophe Lyon wrote: > > > Even with Rainer's fix, I've noticed that the new test fails on > > > arm/aarch64: > > > FAIL: g++.dg/torture/pr81360.C -O2 -flto -fuse-linker-plugin > > >

Re: Fix ipa-inline ICE

2018-01-31 Thread Jan Hubicka
> On Wed, Jan 31, 2018 at 09:51:31AM +0100, Christophe Lyon wrote: > > Even with Rainer's fix, I've noticed that the new test fails on arm/aarch64: > > FAIL: g++.dg/torture/pr81360.C -O2 -flto -fuse-linker-plugin > > -fno-fat-lto-objects scan-ipa-dump icf "Equal symbols: 0" > > With -flto

Re: Fix ipa-inline ICE

2018-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2018 at 09:51:31AM +0100, Christophe Lyon wrote: > Even with Rainer's fix, I've noticed that the new test fails on arm/aarch64: > FAIL: g++.dg/torture/pr81360.C -O2 -flto -fuse-linker-plugin > -fno-fat-lto-objects scan-ipa-dump icf "Equal symbols: 0" With -flto

Re: Fix ipa-inline ICE

2018-01-31 Thread Christophe Lyon
On 30 January 2018 at 23:42, Jakub Jelinek wrote: > On Tue, Jan 30, 2018 at 09:05:31PM +0100, Rainer Orth wrote: >> > this patch fixed ICE that was introduced by Richard Standiford's change to >> > reorder >> > can and want_inline predicates to reduce amount of work done to

Re: Fix ipa-inline ICE

2018-01-30 Thread Jakub Jelinek
On Tue, Jan 30, 2018 at 09:05:31PM +0100, Rainer Orth wrote: > > this patch fixed ICE that was introduced by Richard Standiford's change to > > reorder > > can and want_inline predicates to reduce amount of work done to verify > > inlining limits. > > This bypasses check that the function is

Re: Fix ipa-inline ICE

2018-01-30 Thread Richard Biener
On January 30, 2018 9:05:31 PM GMT+01:00, Rainer Orth wrote: >Hi Jan, > >> this patch fixed ICE that was introduced by Richard Standiford's >change to reorder >> can and want_inline predicates to reduce amount of work done to >verify inlining limits. >> This

Re: Fix ipa-inline ICE

2018-01-30 Thread Rainer Orth
Hi Jan, > this patch fixed ICE that was introduced by Richard Standiford's change to > reorder > can and want_inline predicates to reduce amount of work done to verify > inlining limits. > This bypasses check that the function is optimized that makes inliner to ICE > because > function summary

Fix ipa-inline ICE

2018-01-30 Thread Jan Hubicka
Hi, this patch fixed ICE that was introduced by Richard Standiford's change to reorder can and want_inline predicates to reduce amount of work done to verify inlining limits. This bypasses check that the function is optimized that makes inliner to ICE because function summary is missing. This