Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-12 Thread FX
> Thanks everyone for the comments and review. > Committed as r217366 I cannot push the change to binutils-gdb as I don’t have write access there. Also, Joseph Myers said I needed to commit to newlib/libgloss, but their webpage only mentions read-only CVS. Could someone do it for me? Thanks, FX

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Mike Stump
On Nov 11, 2014, at 11:48 AM, Jack Howarth wrote: > The only problem with this fix for the broken libtool.m4 is that > it will require constant tending as other patches regenerate these > various configure files. For example, > https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00379.html which was jus

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
> Totally agree with Mike here. If you look at the patch it's clear it's just > hitting Darwin and it's absolutely safe. Thanks everyone for the comments and review. Committed as r217366 FX

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
Hi Jack, > The only problem with this fix for the broken libtool.m4 is that > it will require constant tending as other patches regenerate these > various configure files. As I explained in an earlier email today, you are mistaken about the patch. It does fix libtool.m4, which means that all fur

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jack Howarth
Mike, The only problem with this fix for the broken libtool.m4 is that it will require constant tending as other patches regenerate these various configure files. For example, https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00379.html which was just committed would have removed the proposed change h

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jeff Law
On 11/11/14 12:38, Mike Stump wrote: 2014-11-11 Francois-Xavier Coudert PR target/63610 * configure: Missing Regenerate. OK to commit? Ok. This touches so many area it probably needs a build maintainer or global maintainer to approve it. Only darwin is affected, and unlikely anyone e

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Mike Stump
On Nov 11, 2014, at 11:06 AM, FX wrote: > Here’s v2 of the patch > OK to commit? Ok with comments: libvtv: libvtv/ 2014-11-11 Francois-Xavier Coudert PR target/63610 * configure: Missing Regenerate. > OK to commit? Ok. > This touches so many area it probably needs a bu

[patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
Here’s v2 of the patch, including libjava/configure and libjava/classpath/configure, as well as zlib/configure (since it has some adaptations from upstream, documented in zlib/ChangeLog.gcj). OK to commit? Bootstrapped with all supported languages on x86_64-apple-darwin14. FX -- libtool.

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jakub Jelinek
On Tue, Nov 11, 2014 at 03:59:03PM +0100, FX wrote: > > > Since you are simply patching all the configure files, the question > > seems academic unless you switch to properly regenerating all of the > > configure files using a fixed libtool.m4. > > I am actually proposing to fix libtool.m4 and re

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
> Since you are simply patching all the configure files, the question > seems academic unless you switch to properly regenerating all of the > configure files using a fixed libtool.m4. I am actually proposing to fix libtool.m4 and regenerate the configure scripts (which gives the same result as

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jack Howarth
On Tue, Nov 11, 2014 at 9:45 AM, FX wrote: >>It looks like you missed patching a few configure files... >> >> libjava/classpath/configure >> libjava/configure > > Aren’t those under external control? i.e. maintained out of GCC tree? However these are maintained, the libjava configure files st

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
>It looks like you missed patching a few configure files... > > libjava/classpath/configure > libjava/configure Aren’t those under external control? i.e. maintained out of GCC tree? > libgo/configure > zlib/configure Those are maintained upstream, and we import them directly. I’ve filed a

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jack Howarth
FX, It looks like you missed patching a few configure files... libjava/classpath/configure libjava/configure are definitely needed while libgo/configure zlib/configure should be added for completeness. Jack On Tue, Nov 11, 2014 at 4:15 AM, FX wrote: >> Your patch con

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
> Your patch contains lots of other changes, not just the libtool.m4 > change. Please filter those out. Sorry about that. The patch attached should be clean, and the ChangeLog entries formatted as they should. OK to commit? This touches so many area it probably needs a build maintainer or glob

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jakub Jelinek
On Tue, Nov 11, 2014 at 09:58:45AM +0100, FX wrote: > libtool.m4 has a globbing pattern that assumes Mac OS version numbers 10.x > are one digit for x. That’s unfortunate, especially now that Mac OS 10.10 was > released :) > > libtool has released a new version to fix this bug. The attached patc

Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread FX
libtool.m4 has a globbing pattern that assumes Mac OS version numbers 10.x are one digit for x. That’s unfortunate, especially now that Mac OS 10.10 was released :) libtool has released a new version to fix this bug. The attached patch, bootstrapped and regtested on x86_64-apple-darwin14 (Mac O