Re: HELP: Questions on unshare_expr

2024-01-22 Thread Qing Zhao
One update, last Friday, I merged all my patches for counted-by support (including the Patch to workaround the LTO issue) with the latest trunk, bootstrapped and run the testing, everything is good. Today, when I disabled the Patch that workaround the LTO issue, surprisingly, I cannot repeat

Re: HELP: Questions on unshare_expr

2024-01-22 Thread Qing Zhao
> On Jan 22, 2024, at 2:40 AM, Richard Biener > wrote: > > On Fri, Jan 19, 2024 at 5:26 PM Qing Zhao wrote: >> >> >> >>> On Jan 19, 2024, at 4:30 AM, Richard Biener >>> wrote: >>> >>> On Thu, Jan 18, 2024 at 3:46 PM Qing Zhao wrote: > On Jan 17, 2024, at 1:43 AM,

Re: HELP: Questions on unshare_expr

2024-01-21 Thread Richard Biener
On Fri, Jan 19, 2024 at 5:26 PM Qing Zhao wrote: > > > > > On Jan 19, 2024, at 4:30 AM, Richard Biener > > wrote: > > > > On Thu, Jan 18, 2024 at 3:46 PM Qing Zhao wrote: > >> > >> > >> > >>> On Jan 17, 2024, at 1:43 AM, Richard Biener > >>> wrote: > >>> > >>> On Wed, Jan 17, 2024 at 7:42 AM

Re: HELP: Questions on unshare_expr

2024-01-19 Thread Qing Zhao
> On Jan 19, 2024, at 4:30 AM, Richard Biener > wrote: > > On Thu, Jan 18, 2024 at 3:46 PM Qing Zhao wrote: >> >> >> >>> On Jan 17, 2024, at 1:43 AM, Richard Biener >>> wrote: >>> >>> On Wed, Jan 17, 2024 at 7:42 AM Richard Biener >>> wrote: On Tue, Jan 16, 2024 at 9:26 PM

Re: HELP: Questions on unshare_expr

2024-01-19 Thread Richard Biener
On Thu, Jan 18, 2024 at 3:46 PM Qing Zhao wrote: > > > > > On Jan 17, 2024, at 1:43 AM, Richard Biener > > wrote: > > > > On Wed, Jan 17, 2024 at 7:42 AM Richard Biener > > wrote: > >> > >> On Tue, Jan 16, 2024 at 9:26 PM Qing Zhao wrote: > >>> > >>> > >>> > On Jan 15, 2024, at 4:31 AM,

Re: HELP: Questions on unshare_expr

2024-01-18 Thread Qing Zhao
> On Jan 17, 2024, at 1:43 AM, Richard Biener > wrote: > > On Wed, Jan 17, 2024 at 7:42 AM Richard Biener > wrote: >> >> On Tue, Jan 16, 2024 at 9:26 PM Qing Zhao wrote: >>> >>> >>> On Jan 15, 2024, at 4:31 AM, Richard Biener wrote: > All my questions for

Re: HELP: Questions on unshare_expr

2024-01-16 Thread Richard Biener
On Wed, Jan 17, 2024 at 7:42 AM Richard Biener wrote: > > On Tue, Jan 16, 2024 at 9:26 PM Qing Zhao wrote: > > > > > > > > > On Jan 15, 2024, at 4:31 AM, Richard Biener > > > wrote: > > > > > >> All my questions for unshare_expr relate to a LTO bug that I currently > > >> stuck with > > >>

Re: HELP: Questions on unshare_expr

2024-01-16 Thread Richard Biener
On Tue, Jan 16, 2024 at 9:26 PM Qing Zhao wrote: > > > > > On Jan 15, 2024, at 4:31 AM, Richard Biener > > wrote: > > > >> All my questions for unshare_expr relate to a LTO bug that I currently > >> stuck with > >> when using .ACCESS_WITH_SIZE in bound sanitizer (only with -flto, without >

Re: HELP: Questions on unshare_expr

2024-01-16 Thread Qing Zhao
> On Jan 15, 2024, at 4:31 AM, Richard Biener > wrote: > >> All my questions for unshare_expr relate to a LTO bug that I currently >> stuck with >> when using .ACCESS_WITH_SIZE in bound sanitizer (only with -flto, without >> -flto, no issue): >> >> [opc@qinzhao-aarch64-ol8 gcc]$ sh t >>

Re: HELP: Questions on unshare_expr

2024-01-15 Thread Qing Zhao
> On Jan 15, 2024, at 3:13 AM, Eric Botcazou wrote: > >> Okay, so, the "unsharing everything” is done automatically by the compiler >> before gimplification? > > See the blurb at gimplify.cc:835 and below about this. Thanks a lot for the info. (I read this paragraph before sending the

Re: HELP: Questions on unshare_expr

2024-01-15 Thread Qing Zhao
> On Jan 15, 2024, at 10:06 AM, Jakub Jelinek wrote: > > On Mon, Jan 15, 2024 at 02:54:26PM +, Qing Zhao wrote: >> So, before gimplification, when inserting tree node, we don’t need manually >> add unshare_expr since the gimplification will automatically unshare nodes. > > There are

Re: HELP: Questions on unshare_expr

2024-01-15 Thread Jakub Jelinek
On Mon, Jan 15, 2024 at 02:54:26PM +, Qing Zhao wrote: > So, before gimplification, when inserting tree node, we don’t need manually > add unshare_expr since the gimplification will automatically unshare nodes. There are cases where unshare_expr is needed even then, such as the uses in the

Re: HELP: Questions on unshare_expr

2024-01-15 Thread Qing Zhao
> On Jan 15, 2024, at 4:31 AM, Richard Biener > wrote: > > On Fri, Jan 12, 2024 at 6:30 PM Qing Zhao wrote: >> >> Thanks a lot for the reply. >> >>> On Jan 12, 2024, at 11:28 AM, Richard Biener >>> wrote: >>> >>> >>> Am 12.01.2024 um 16:55 schrieb Qing Zhao : Hi,

Re: HELP: Questions on unshare_expr

2024-01-15 Thread Richard Biener
On Fri, Jan 12, 2024 at 6:30 PM Qing Zhao wrote: > > Thanks a lot for the reply. > > > On Jan 12, 2024, at 11:28 AM, Richard Biener > > wrote: > > > > > > > >> Am 12.01.2024 um 16:55 schrieb Qing Zhao : > >> > >> Hi, > >> > >> I have some questions on using the utility routine “unshare_expr”:

Re: HELP: Questions on unshare_expr

2024-01-15 Thread Eric Botcazou
> Okay, so, the "unsharing everything” is done automatically by the compiler > before gimplification? See the blurb at gimplify.cc:835 and below about this. -- Eric Botcazou

Re: HELP: Questions on unshare_expr

2024-01-12 Thread Qing Zhao
Thanks a lot for the reply. > On Jan 12, 2024, at 11:28 AM, Richard Biener > wrote: > > > >> Am 12.01.2024 um 16:55 schrieb Qing Zhao : >> >> Hi, >> >> I have some questions on using the utility routine “unshare_expr”: >> >> From my understanding, there should be NO shared nodes in a

Re: HELP: Questions on unshare_expr

2024-01-12 Thread Richard Biener
> Am 12.01.2024 um 16:55 schrieb Qing Zhao : > > Hi, > > I have some questions on using the utility routine “unshare_expr”: > > From my understanding, there should be NO shared nodes in a GENERIC function. > Otherwise, gimplication might fail. There is sharing and this is why we unshare

HELP: Questions on unshare_expr

2024-01-12 Thread Qing Zhao
Hi, I have some questions on using the utility routine “unshare_expr”: From my understanding, there should be NO shared nodes in a GENERIC function. Otherwise, gimplication might fail. Therefore, when we insert new tree nodes manually into the GENERIC function, we should Make sure there is