Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Bernd Schmidt
On 11/10/2015 10:56 AM, Bernhard Reutner-Fischer wrote: On November 9, 2015 6:35:20 PM GMT+01:00, Bernd Schmidt wrote: I think something that starts with bb->loop_father and iterates outwards would be more efficient. flow_bb_inside_loop_p() ? Ah thanks. I knew there

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Bernhard Reutner-Fischer
On November 9, 2015 6:35:20 PM GMT+01:00, Bernd Schmidt wrote: >On 11/07/2015 03:44 PM, Kelvin Nilsen wrote: >> +bool >> +in_loop_p (basic_block block, struct loop *loop_ptr) >> +{ >> + basic_block *bbs = get_loop_body (loop_ptr); >> + bool result = false; >> + >> + for

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Richard Biener
On Mon, Nov 9, 2015 at 6:35 PM, Bernd Schmidt wrote: > On 11/07/2015 03:44 PM, Kelvin Nilsen wrote: >> >> This is a draft patch to partially address the concerns described in >> bugzilla problem report >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68212). The patch is >>

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Michael Matz
Hi, On Tue, 10 Nov 2015, Richard Biener wrote: > >> +static bool > >> +same_edge_p (edge an_edge, edge another_edge) > >> +{ > >> + return ((an_edge->src == another_edge->src) > >> + && (an_edge->dest == another_edge->dest)); > >> +} > > > > > > Formatting aside (extra parentheses), I

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-09 Thread Bernd Schmidt
On 11/07/2015 03:44 PM, Kelvin Nilsen wrote: This is a draft patch to partially address the concerns described in bugzilla problem report https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68212). The patch is incomplete in the sense that there are some known shortcomings with nested loops which I am

RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-07 Thread Kelvin Nilsen
This is a draft patch to partially address the concerns described in bugzilla problem report https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68212). The patch is incomplete in the sense that there are some known shortcomings with nested loops which I am still working on. I am sending this out