RFC: handle cached local static DIEs

2014-12-11 Thread Aldy Hernandez
Hi Jason. After my last set of dwarf changes for locals, I found some target library building failures which I am now fixing. The problem at hand is that, by design, the caching code in gen_variable_die() refuses to use a previously cached DIE if the current context and the cached context

Re: RFC: handle cached local static DIEs

2014-12-11 Thread Jason Merrill
On 12/11/2014 12:44 PM, Aldy Hernandez wrote: This context then gets changed here: /* For local statics lookup proper context die. */ if (TREE_STATIC (decl) DECL_CONTEXT (decl) TREE_CODE (DECL_CONTEXT (decl)) == FUNCTION_DECL) context_die = lookup_decl_die

Re: RFC: handle cached local static DIEs

2014-12-11 Thread Aldy Hernandez
On 12/11/14 11:23, Jason Merrill wrote: On 12/11/2014 02:19 PM, Jason Merrill wrote: On 12/11/2014 12:44 PM, Aldy Hernandez wrote: This context then gets changed here: /* For local statics lookup proper context die. */ if (TREE_STATIC (decl) DECL_CONTEXT (decl)

Re: RFC: handle cached local static DIEs

2014-12-11 Thread Jason Merrill
On 12/11/2014 02:19 PM, Jason Merrill wrote: On 12/11/2014 12:44 PM, Aldy Hernandez wrote: This context then gets changed here: /* For local statics lookup proper context die. */ if (TREE_STATIC (decl) DECL_CONTEXT (decl) TREE_CODE (DECL_CONTEXT (decl)) ==