On 09/21/12 14:30, Bruce Korb wrote:
From my part, I'm willing to push the patch, but I need confirmation
from Paolo and Nathan
because some of it affects code outside of my authority.
I have no objections to the patch.
nathan
>From my part, I'm willing to push the patch, but I need confirmation
from Paolo and Nathan
because some of it affects code outside of my authority.
On Thu, Sep 20, 2012 at 7:02 PM, rbmj wrote:
> Ping? Just did a full pull and rebuild today and everything still works :)
>
> Robert Mason
Ping? Just did a full pull and rebuild today and everything still works :)
Robert Mason
On 9/10/2012 3:46 PM, Bruce Korb wrote:
Hi,
On Mon, Sep 10, 2012 at 10:48 AM, rbmj wrote:
On the other hand, I've read this on the website:
Don't mix together changes made for different reasons. Send t
Hi,
On Mon, Sep 10, 2012 at 10:48 AM, rbmj wrote:
> On the other hand, I've read this on the website:
>
>> Don't mix together changes made for different reasons. Send them
>> individually. Ideally, each change you send should be impossible to
>> subdivide into
>
> parts that we might want to con
On 9/10/2012 9:35 AM, Bruce Korb wrote:
On 09/09/12 08:54, rbmj wrote:
Just because I *love* bothering everyone with emails...
I don't mind, as long as you don't expect me to do anything
until I'm certain you've stabilized the patch ;)
I'm glad you rolled it up into one patch, because I was
ev
On 09/09/12 08:54, rbmj wrote:
> Just because I *love* bothering everyone with emails...
I don't mind, as long as you don't expect me to do anything
until I'm certain you've stabilized the patch ;)
I'm glad you rolled it up into one patch, because I was
eventually going to ask you to do that. Tha
Just because I *love* bothering everyone with emails...
I've made a few changes and squashed everything into a single patch for
ease of application. The commit message is inside the patch, but here's
the suggested ChangeLog:
configure.ac: add --enable-libstdcxx option
configure: regenerate
Hi all,
I have a new set of patches attached to this email. I've made a few
changes since last time, and a full build works (finally, again).
-The ioctl patch removes superfluous parens (thanks Paolo)
-The mkdir patch has a more precise (or uglier, depending on your point
of view :P) regex,
Hi Robert,
On Thu, Aug 30, 2012 at 6:30 AM, rbmj wrote:
>> Done, and patch is attached.
>>
>
> OK. make install doesn't seem to like it as much as I do. It complains
> because it tries to install macro_list and can't find it. Proposed
> solutions:
>
> 2. Change line to read test -f ${MACRO_LIS
On 8/23/2012 7:54 AM, Paolo Bonzini wrote:
Il 23/08/2012 13:46, rbmj ha scritto:
On 8/23/2012 4:24 AM, Paolo Bonzini wrote:
Subject: [PATCH 10/10] Make open() call more compatible in gcc/gcov-io.c
In gcc/gcov-io.c, the call to open() only has two arguments. This
is fine, as long as the system
On 8/25/2012 11:35 PM, rbmj wrote:
On 8/24/2012 4:59 PM, Bruce Korb wrote:
Hi Robert,
If you are going to defer, then:
On Fri, Aug 24, 2012 at 1:20 PM, rbmj wrote:
diff --git a/fixincludes/fixinc.in b/fixincludes/fixinc.in
index e73aed9..de7be35 100755
--- a/fixincludes/fixinc.in
+++ b/fixin
On 8/24/2012 4:59 PM, Bruce Korb wrote:
Hi Robert,
If you are going to defer, then:
On Fri, Aug 24, 2012 at 1:20 PM, rbmj wrote:
diff --git a/fixincludes/fixinc.in b/fixincludes/fixinc.in
index e73aed9..de7be35 100755
--- a/fixincludes/fixinc.in
+++ b/fixincludes/fixinc.in
@@ -128,6 +128,18 @
Hi Robert,
If you are going to defer, then:
On Fri, Aug 24, 2012 at 1:20 PM, rbmj wrote:
> diff --git a/fixincludes/fixinc.in b/fixincludes/fixinc.in
> index e73aed9..de7be35 100755
> --- a/fixincludes/fixinc.in
> +++ b/fixincludes/fixinc.in
> @@ -128,6 +128,18 @@ fi
>
> # # # # # # # # # # # #
I have two candidate patches. I've tested both and either can supersede
the original 0001-fixincludes-machine_name patch.
The first is the original proposed sed expression:
---
fixincludes/mkfixinc.sh |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fixincludes/mkf
On 08/24/12 11:50, rbmj wrote:
On 8/22/2012 8:52 PM, Bruce Korb wrote:
However I think it might be simpler to tweak mkfixinc.sh to
sed '/if test -s .{MACRO_LIST}/s/$/ && false/' \
${srcdir}/fixinc.in > ${target}
for vxworks rather than all that configury rigmarole.
That would eliminate
On 8/22/2012 8:52 PM, Bruce Korb wrote:
However I think it might be simpler to tweak mkfixinc.sh to
sed '/if test -s .{MACRO_LIST}/s/$/ && false/' \
${srcdir}/fixinc.in > ${target}
for vxworks rather than all that configury rigmarole.
That would eliminate changes to gcc/configure.ac and
Il 23/08/2012 21:37, rbmj ha scritto:
>> In gcc/gcov-io.c, the call to open() only has two arguments. This
>> is fine, as long as the system open() is standards compliant.
So you have to add another fixincludes hack, adding a macro indirection
like the one you have for ioctl:
#d
In gcc/gcov-io.c, the call to open() only has two arguments. This
is fine, as long as the system open() is standards compliant.
So you have to add another fixincludes hack, adding a macro indirection
like the one you have for ioctl:
#define open(a, b, ...) __open(a, b , ##__VA_ARGS__, 0660)
Il 23/08/2012 13:46, rbmj ha scritto:
> On 8/23/2012 4:24 AM, Paolo Bonzini wrote:
>> Some comments on the patches:
>>
>>> +c_fix_arg= "%0\n"
>>> +"#define ioctl(fd, func, arg) ((ioctl)((fd), (func),
>>> ((int)(arg\n";
>> This can be simply
>>
>> #define ioctl(fd, func, arg) ioc
On 8/23/2012 4:24 AM, Paolo Bonzini wrote:
Some comments on the patches:
+ c_fix_arg = "%0\n"
+ "#define ioctl(fd, func, arg) ((ioctl)((fd), (func),
((int)(arg\n";
This can be simply
#define ioctl(fd, func, arg) ioctl(fd, func, (int)arg)
thanks to C and cpp pre
Il 23/08/2012 10:35, Jay Foad ha scritto:
>> > This can be simply
>> >
>> > #define ioctl(fd, func, arg) ioctl(fd, func, (int)arg)
> "(int)(arg)", surely.
Right, only the other parentheses are unnecessary. (Cut-and-paste mistake).
Paolo
On 23 August 2012 09:24, Paolo Bonzini wrote:
> Il 23/08/2012 04:27, rbmj ha scritto:
>> + c_fix_arg = "%0\n"
>> + "#define ioctl(fd, func, arg) ((ioctl)((fd), (func),
>> ((int)(arg\n";
>
> This can be simply
>
> #define ioctl(fd, func, arg) ioctl(fd, func, (int)arg)
"(
Il 23/08/2012 04:27, rbmj ha scritto:
>>
>> sed '/if test -s .{MACRO_LIST}/s/$/ && false/' \
>> ${srcdir}/fixinc.in > ${target}
>>
>> for vxworks rather than all that configury rigmarole.
>> That would eliminate changes to gcc/configure.ac and gcc/Makefile.in.
>
> I didn't even think of tha
On 8/22/2012 8:52 PM, Bruce Korb wrote:
On 08/22/12 17:05, rbmj wrote:
Hello Everyone,
I have ten patches which are approved or obvious but waiting on commit
The include fixing stuff looks fine to me.
However I think it might be simpler to tweak mkfixinc.sh to
sed '/if test -s .{MACRO_LIS
On 08/22/12 17:05, rbmj wrote:
Hello Everyone,
I have ten patches which are approved or obvious but waiting on commit
The include fixing stuff looks fine to me.
However I think it might be simpler to tweak mkfixinc.sh to
sed '/if test -s .{MACRO_LIST}/s/$/ && false/' \
${srcdir}/fixin
Hello Everyone,
I have ten patches which are approved or obvious but waiting on commit,
each of which is attached to this email. Feel free to consider this a
ping, HOWEVER, they are rebased onto the latest trunk so they're no
longer stale. Additionally, I updated the commit messages and with
26 matches
Mail list logo
