Re: cleanups and unification of value_range dumping code

2018-11-13 Thread Richard Biener
On Tue, Nov 13, 2018 at 3:43 PM Aldy Hernandez wrote: > > > > On 11/13/18 3:12 AM, Richard Biener wrote: > > On Mon, Nov 12, 2018 at 10:50 AM Aldy Hernandez wrote: > >> > >> I have rebased my value_range dumping patch after your value_range_base > >> changes. > >> > >> I know you are not a fan

Re: cleanups and unification of value_range dumping code

2018-11-13 Thread Aldy Hernandez
On 11/13/18 3:12 AM, Richard Biener wrote: On Mon, Nov 12, 2018 at 10:50 AM Aldy Hernandez wrote: I have rebased my value_range dumping patch after your value_range_base changes. I know you are not a fan of the gimple-pretty-print.c chunk, but I still think having one set of dumping code

Re: cleanups and unification of value_range dumping code

2018-11-13 Thread Richard Biener
On Mon, Nov 12, 2018 at 10:50 AM Aldy Hernandez wrote: > > I have rebased my value_range dumping patch after your value_range_base > changes. > > I know you are not a fan of the gimple-pretty-print.c chunk, but I still > think having one set of dumping code is preferable to catering to > possible

Re: cleanups and unification of value_range dumping code

2018-11-12 Thread Aldy Hernandez
I have rebased my value_range dumping patch after your value_range_base changes. I know you are not a fan of the gimple-pretty-print.c chunk, but I still think having one set of dumping code is preferable to catering to possible GC corruption while debugging. If you're strongly opposed (as,

Re: cleanups and unification of value_range dumping code

2018-11-09 Thread Aldy Hernandez
On 11/9/18 6:37 AM, Richard Biener wrote: On Thu, Nov 8, 2018 at 5:03 PM Aldy Hernandez wrote: On 11/8/18 9:39 AM, Richard Biener wrote: On Thu, Nov 8, 2018 at 2:32 PM Aldy Hernandez wrote: [Richard, you're right. An overloaded debug() is better than this->dump(). Anyone who thinks

Re: cleanups and unification of value_range dumping code

2018-11-09 Thread Richard Biener
On Thu, Nov 8, 2018 at 5:03 PM Aldy Hernandez wrote: > > > > On 11/8/18 9:39 AM, Richard Biener wrote: > > On Thu, Nov 8, 2018 at 2:32 PM Aldy Hernandez wrote: > >> > >> [Richard, you're right. An overloaded debug() is better than > >> this->dump(). Anyone who thinks different is wrong. End

Re: cleanups and unification of value_range dumping code

2018-11-08 Thread Aldy Hernandez
On 11/8/18 9:39 AM, Richard Biener wrote: On Thu, Nov 8, 2018 at 2:32 PM Aldy Hernandez wrote: [Richard, you're right. An overloaded debug() is better than this->dump(). Anyone who thinks different is wrong. End of discussion.] There's no reason to have multiple ways of dumping a value

Re: cleanups and unification of value_range dumping code

2018-11-08 Thread Richard Biener
On Thu, Nov 8, 2018 at 2:32 PM Aldy Hernandez wrote: > > [Richard, you're right. An overloaded debug() is better than > this->dump(). Anyone who thinks different is wrong. End of discussion.] > > There's no reason to have multiple ways of dumping a value range. And > I'm not even talking

cleanups and unification of value_range dumping code

2018-11-08 Thread Aldy Hernandez
[Richard, you're right. An overloaded debug() is better than this->dump(). Anyone who thinks different is wrong. End of discussion.] There's no reason to have multiple ways of dumping a value range. And I'm not even talking about ipa-prop.* which decided that they should implement their