Re: RFA: make scan-assembler* ignore LTO sections (Was: Re: committed [RISC-V]: Harden test scan patterns)

2023-11-09 Thread Jeff Law
On 11/8/23 09:00, Joern Rennecke wrote: On Fri, 29 Sept 2023 at 14:54, Jeff Law wrote: ... Joern can you post a follow-up manual twiddle so that other ports can follow your example and avoid this problem? THanks, jeff The attached patch makes the scan-assembler* directives ignore the

RFA: make scan-assembler* ignore LTO sections (Was: Re: committed [RISC-V]: Harden test scan patterns)

2023-11-08 Thread Joern Rennecke
On Fri, 29 Sept 2023 at 14:54, Jeff Law wrote: > ... Joern can you post a follow-up manual twiddle so > that other ports can follow your example and avoid this problem? > > THanks, > > jeff The attached patch makes the scan-assembler* directives ignore the LTO sections. Regression tested

Re: committed [RISC-V]: Harden test scan patterns

2023-10-11 Thread Joern Rennecke
On Wed, 11 Oct 2023 at 05:48, Joern Rennecke wrote: > So I propose we look at the first character of the regexp, and if it's neither > ^ nor \ (neither caret nor backslash), we consider the regexp un-anchored, > and prepend ^[^"]* , so it won't allow a match after a double quote. Looking at the

Re: committed [RISC-V]: Harden test scan patterns

2023-10-10 Thread Joern Rennecke
On Sat, 30 Sept 2023 at 22:12, Joern Rennecke wrote: > Also, we might have different directives for not scanning in LTO sections - > or just ignoring .ascii . Or maybe the other way round - you have to do > something special if you want to scan inside strings, and by default we > don't look

Re: committed [RISC-V]: Harden test scan patterns

2023-09-30 Thread Joern Rennecke
On Fri, 29 Sept 2023 at 14:54, Jeff Law wrote: > So I recommend we go forward with Joern's approach (so consider that an > ACK for the trunk). Joern can you post a follow-up manual twiddle so > that other ports can follow your example and avoid this problem? The manual... so not in the

Re: committed [RISC-V]: Harden test scan patterns

2023-09-29 Thread Jeff Law
On 9/27/23 17:21, Vineet Gupta wrote: On 9/27/23 13:14, Jeff Law wrote: It would help to describe how these patterns were under specified so that folks don't continue to make the same mistake as new tests get added. dg-final scan-assembler, scan-assembler-not, and scan-assembler-times

Re: committed [RISC-V]: Harden test scan patterns

2023-09-27 Thread Vineet Gupta
On 9/27/23 13:14, Jeff Law wrote: It would help to describe how these patterns were under specified so that folks don't continue to make the same mistake as new tests get added. dg-final scan-assembler, scan-assembler-not, and scan-assembler-times use a tcl regular expression (often

Re: committed [RISC-V]: Harden test scan patterns

2023-09-27 Thread Andrew Pinski
On Wed, Sep 27, 2023 at 1:14 PM Jeff Law wrote: > > > > On 9/27/23 12:22, Joern Rennecke wrote: > > On Wed, 27 Sept 2023 at 18:22, Jeff Law wrote: > > > >> It would help to describe how these patterns were under specified so > >> that folks don't continue to make the same mistake as new tests

Re: committed [RISC-V]: Harden test scan patterns

2023-09-27 Thread Jeff Law
On 9/27/23 12:22, Joern Rennecke wrote: On Wed, 27 Sept 2023 at 18:22, Jeff Law wrote: It would help to describe how these patterns were under specified so that folks don't continue to make the same mistake as new tests get added. dg-final scan-assembler, scan-assembler-not, and

Re: committed [RISC-V]: Harden test scan patterns

2023-09-27 Thread Joern Rennecke
On Wed, 27 Sept 2023 at 18:22, Jeff Law wrote: > It would help to describe how these patterns were under specified so > that folks don't continue to make the same mistake as new tests get added. dg-final scan-assembler, scan-assembler-not, and scan-assembler-times use a tcl regular expression

Re: committed [RISC-V]: Harden test scan patterns

2023-09-27 Thread Jeff Law
On 9/27/23 03:26, Joern Rennecke wrote: I got tired of scan tests failing when they have an underspecified pattern that matches LTO information, so I did a global replace for the most common form of such scan patterns in the gcc.target/riscv testsuite. regression tested for: riscv-sim

committed [RISC-V]: Harden test scan patterns

2023-09-27 Thread Joern Rennecke
I got tired of scan tests failing when they have an underspecified pattern that matches LTO information, so I did a global replace for the most common form of such scan patterns in the gcc.target/riscv testsuite. regression tested for: riscv-sim