Re: fix gfcov regression

2014-09-07 Thread Dominique d'Humières
As said in PR63182, the attached patch fixes bootstrap without regression. Any reason why it has not yet been committed? Dominique Le 3 sept. 2014 à 15:15, Nathan Sidwell nat...@acm.org a écrit : On 09/03/14 04:06, Dominique Dhumieres wrote: I've committed the patch now. It (r214840)

Re: fix gfcov regression

2014-09-07 Thread Nathan Sidwell
On 09/05/14 03:06, ro...@nextmovesoftware.com wrote: ../../../../gcc/libgcc/libgcov-interface.c:137:1: warning: alias definitions not supported in Mach-O; ignored ALIAS (__gcov_reset_int, __gcov_reset); That doesn't sound like it's going to work then. I've gone with the attached patch.

Re: fix gfcov regression

2014-09-03 Thread Dominique Dhumieres
I've committed the patch now. It (r214840) breaks bootstrap on darwin: ... /opt/gcc/build_w/./gcc/xgcc -B/opt/gcc/build_w/./gcc/ -B/opt/gcc/gcc4.10w/x86_64-apple-darwin13.3.0/bin/ -B/opt/gcc/gcc4.10w/x86_64-apple-darwin13.3.0/lib/ -isystem /opt/gcc/gcc4.10w/x86_64-apple-darwin13.3.0/include

Re: fix gfcov regression

2014-09-03 Thread Nathan Sidwell
On 09/03/14 04:06, Dominique Dhumieres wrote: I've committed the patch now. It (r214840) breaks bootstrap on darwin: does this fix it? nathan 2014-09-03 Nathan sidwell nat...@acm.org * libgcov-interface.c (STRONG_ALIAS): Rename to ... (ALIAS): ... here. Make weak. Adjust

Re: fix gfcov regression

2014-09-03 Thread Dominique Dhumieres
does this fix it? The answer after a quick update is yes, further testing scheduled for tonight. Thanks, Dominique

Re: fix gfcov regression

2014-09-02 Thread Nathan Sidwell
On 08/23/14 10:33, Nathan Sidwell wrote: Hi, this patch fixes a defect Jan found with firefox and its shared objects. We were inadvertently calling an externally visible and overridable symbol, rather than the local shared object's instance. This led to strangely sparse gcov results. I've

fix gfcov regression

2014-08-23 Thread Nathan Sidwell
Hi, this patch fixes a defect Jan found with firefox and its shared objects. We were inadvertently calling an externally visible and overridable symbol, rather than the local shared object's instance. This led to strangely sparse gcov results. I've taken the STRONG_ALIAS #define from glibc.