Re: [fixincludes] Fix iso/math_c99.h signbit on Solaris

2014-06-28 Thread Bruce Korb
On 06/26/14 02:18, Rainer Orth wrote: Ok for mainline? Could you please reformat the c_fix_arg's and test-text to be here strings a la: c_fix_arg = - _EOS_ #undef signbit #define signbit(x) (sizeof(x) == sizeof(float) \ \ ?

Re: [fixincludes] Fix iso/math_c99.h signbit on Solaris

2014-07-01 Thread Bruce Korb
Hi Rainer, On Tue, Jul 1, 2014 at 4:22 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: It's not yet in autogen 5.9: I've diffed the fixincl.x generated with my original patch and the amended one and those backslashes after the leading tab are still there. 5.9 is 7 years old now.

Re: Remove obsolete Solaris 9 support

2014-04-19 Thread Bruce Korb
On 04/16/14 04:16, Rainer Orth wrote: I've already verified that trunk fails to build no sparc-sun-solaris2.9 and i386-pc-solaris2.9. Bootstraps on {i386,sparc}-*-solaris2.{10,11} (and x86_64-unknown-linux-gnu for good measure) are in progress. I'll verify that there are no unexpected

Re: configure check for flex

2014-02-22 Thread Bruce Korb
On 01/27/14 18:20, Hans-Peter Nilsson wrote: You'd need some additional conditions. There might be the additional issue that any lex is expected to work too, not just flex. It isn't committed 'cuz nobody said, Okay. I do wish either someone would say, Okay. or come up with something that

Re: configure check for flex

2014-02-22 Thread Bruce Korb
In retrospect, it occurs to me that a am-i-ready-to-build.sh script in the contrib directory might be useful, too.

Re: [PATCH, fixincludes]: Add pthread.h to glibc_c99_inline_4 fix

2014-10-25 Thread Bruce Korb
On 10/21/14 02:30, Uros Bizjak wrote: 2014-10-21 Uros Bizjak ubiz...@gmail.com * inclhack.def (glibc_c99_inline_4): Add pthread.h to files. * fixincl.x: Regenerate. Bootstrapped and regression tested on CentOS 5.11 x86_64-linux-gnu {,-m32}. OK for mainline?

Re: [PATCH, fixincludes]: Add pthread.h to glibc_c99_inline_4 fix

2014-10-25 Thread Bruce Korb
On 10/25/14 10:40, Bruce Korb wrote: On 10/21/14 02:30, Uros Bizjak wrote: 2014-10-21 Uros Bizjak ubiz...@gmail.com * inclhack.def (glibc_c99_inline_4): Add pthread.h to files. * fixincl.x: Regenerate. Bootstrapped and regression tested on CentOS 5.11 x86_64-linux-gnu {,-m32}. OK

Re: fixincludes for libquadmath build regression

2012-12-30 Thread Bruce Korb
On 12/30/12 01:42, Paolo Bonzini wrote: Not my territory anymore, but it looks much better! CCing Bruce. Hi Alexandre, Long time. It's no wonder you've forgotten this little world! :) Anyway, please make the expressions more readable and strip out the generated text from the review message.

Re: fixincludes for libquadmath build regression

2013-01-06 Thread Bruce Korb
On 01/06/13 12:12, Alexandre Oliva wrote: On Dec 30, 2012, Bruce Korb bk...@gnu.org wrote: On 12/30/12 01:42, Paolo Bonzini wrote: Not my territory anymore, but it looks much better! CCing Bruce. Long time. It's no wonder you've forgotten this little world! :) Indeed! Anyway

Re: [committed] 2011 and 2012 Copyright year updates

2013-01-07 Thread Bruce Korb
On Mon, Jan 7, 2013 at 11:49 AM, Richard Sandiford rdsandif...@googlemail.com wrote: I think a patch for each directory will need posting separately for review of such things as whether any imported / generated files are mistakenly changed. So fixincludes/ separate from gcc/, and every

Re: [PATCH] Fix fixinclude common/non-common mix

2013-01-14 Thread Bruce Korb
Hi, On Mon, Jan 14, 2013 at 12:42 AM, Richard Biener rguent...@suse.de wrote: fixincludes mixes common declarations (in fixlib.h) and non-common decls (where they are defined) for verbose_level and fixinc_mode. XCode on Mountain Lion doesn't like this and its linker (rightfully) complains.

Re: Ping: unreviewed copyright patches

2013-02-03 Thread Bruce Korb
On 02/03/13 02:19, Richard Sandiford wrote: Not exactly the most exciting patches, and certainly not worth more than one ping, but: fixincludes copyright http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00442.html You missed the file header. Why bother with dual update issues? ---

Re: Ping: unreviewed copyright patches

2013-02-03 Thread Bruce Korb
On 02/03/13 09:42, Richard Sandiford wrote: You missed the file header. That was deliberately in patch 2 though. OK. Why bother with dual update issues? Well, the point is that patch 2 is scripted. OK: echo $copyright | sed 's/(C) 2002-/(C) /' and now you print the right date and

Re: Ping: unreviewed copyright patches

2013-02-04 Thread Bruce Korb
On Mon, Feb 4, 2013 at 11:55 AM, Ben Elliston b...@air.net.au wrote: On Mon, Feb 04, 2013 at 06:59:38PM +, Richard Sandiford wrote: These days the guideline encourage updating all files, even ones that haven't changed, so I was hoping we could do that gcc-wide. If that is what the

Interlacing switch labels and compound statements

2011-03-28 Thread Bruce Korb
I stumbled over this code using a source code analyzer. It incorrectly assumed that switch labels cannot be inserted into random places inside of enclosed compound statements. It correctly assumes that you shouldn't be doing that. :) I propose making this change solely for aesthetics: static

Re: [vms] Use fix include on alpha-vms

2011-09-22 Thread Bruce Korb
Hi Tristan, On Thu, Sep 22, 2011 at 6:59 AM, Tristan Gingold ging...@adacore.com wrote: Hi, currently alpha-vms is listed as a particular target in fixincludes/mkfixinc.sh but ia64-vms isn't. As I will submit a patch to add some rules for both alpha and ia64 VMS, first fixincludes must be

Re: [Patch]: New fixincludes fixes for vms

2011-09-22 Thread Bruce Korb
On 09/22/11 08:00, Tristan Gingold wrote: Hi, this patch adds some fixes in fixincludes specific to VMS. Until now we were using a manually modified subset of the VMS headers, but using fix includes is the right way. Ok for mainline ? Looks good to me. Please, thank you.

Re: [Fixinclude]: Fix typo and default to twoprocess on VMS

2012-04-17 Thread Bruce Korb
Hi Tristan, On Tue, Apr 17, 2012 at 5:57 AM, Tristan Gingold ging...@adacore.com wrote: Hi, one-process methodology cannot be used on VMS[...] But, when twoprocess is selected, gcc emits a warning[...] Ok for trunk ? diff --git a/fixincludes/configure.ac b/fixincludes/configure.ac index

Re: [Fixinclude]: Fix typo and default to twoprocess on VMS

2012-04-18 Thread Bruce Korb
Hi, When I approved a patch in 2008, there was a typo. I didn't notice and it was fixed by removing a formatting element. Your patch corrects the error. Please apply your changes to active branches. Thank you! Regards, Bruce

Re: VxWorks Patches Back from the Dead!

2012-08-22 Thread Bruce Korb
On 08/22/12 17:05, rbmj wrote: Hello Everyone, I have ten patches which are approved or obvious but waiting on commit The include fixing stuff looks fine to me. However I think it might be simpler to tweak mkfixinc.sh to sed '/if test -s .{MACRO_LIST}/s/$/ false/' \

Re: VxWorks Patches Back from the Dead!

2012-08-24 Thread Bruce Korb
On 08/24/12 11:50, rbmj wrote: On 8/22/2012 8:52 PM, Bruce Korb wrote: However I think it might be simpler to tweak mkfixinc.sh to sed '/if test -s .{MACRO_LIST}/s/$/ false/' \ ${srcdir}/fixinc.in ${target} for vxworks rather than all that configury rigmarole. That would eliminate

Re: VxWorks Patches Back from the Dead!

2012-08-24 Thread Bruce Korb
Hi Robert, If you are going to defer, then: On Fri, Aug 24, 2012 at 1:20 PM, rbmj r...@verizon.net wrote: diff --git a/fixincludes/fixinc.in b/fixincludes/fixinc.in index e73aed9..de7be35 100755 --- a/fixincludes/fixinc.in +++ b/fixincludes/fixinc.in @@ -128,6 +128,18 @@ fi # # # # # # #

Re: VxWorks Patches Back from the Dead!

2012-08-30 Thread Bruce Korb
Hi Robert, On Thu, Aug 30, 2012 at 6:30 AM, rbmj r...@verizon.net wrote: Done, and patch is attached. OK. make install doesn't seem to like it as much as I do. It complains because it tries to install macro_list and can't find it. Proposed solutions: 2. Change line to read test -f

Re: VxWorks Patches Back from the Dead!

2012-09-10 Thread Bruce Korb
On 09/09/12 08:54, rbmj wrote: Just because I *love* bothering everyone with emails... I don't mind, as long as you don't expect me to do anything until I'm certain you've stabilized the patch ;) I'm glad you rolled it up into one patch, because I was eventually going to ask you to do that.

Re: VxWorks Patches Back from the Dead!

2012-09-10 Thread Bruce Korb
Hi, On Mon, Sep 10, 2012 at 10:48 AM, rbmj r...@verizon.net wrote: On the other hand, I've read this on the website: Don't mix together changes made for different reasons. Send them individually. Ideally, each change you send should be impossible to subdivide into parts that we might want

Re: [fixincludes] Fix posix_spawn* declarations in Solaris spawn.h (PR c++/49347)

2011-07-25 Thread Bruce Korb
On 07/25/11 08:17, Rainer Orth wrote: As discussed in the PR, the Solaris 10+spawn.h header needs a fix to make it work with g++. The following patch implements it. It passed a i386-pc-solaris2.11 bootstrap without regressions and make check in fixincludes works without failures. Ok for

Re: [PATCH] Fixincludes/VxWorks

2012-06-06 Thread Bruce Korb
are appreciated.  Also, I don't have commit access. CC'ing Nathan Sidwell and Bruce Korb, as MAINTAINERS says you're the VxWorks and fixincludes maintainers, respectively. Thanks, Robert Mason [1] http://gcc.gnu.org/ml/gcc-help/2012-05/msg00172.html

Re: [PATCH] Fixincludes/VxWorks

2012-06-06 Thread Bruce Korb
On 06/06/12 09:33, rbmj wrote: Hi everyone, OK, I'm slow. I just woke up from a late night. test -r vxWorks.h is the mechanism to ensure that tests only fire on a vxworks platform. Seems a bit obscure, but if it is easier than other mechanisms, then fine. I do think a mach test would be

Re: Why is fixincludes not doing anything?

2012-06-06 Thread Bruce Korb
RE: http://gcc.gnu.org/ml/gcc-help/2012-05/msg00245.html perhaps it would be useful to echo a warning into the stderr stream when platforms get bypassed?

Re: [PATCH] Fixincludes/VxWorks

2012-06-10 Thread Bruce Korb
On Sun, Jun 10, 2012 at 10:57 AM, Nathan Sidwell nat...@acm.org wrote: On 06/06/12 17:33, rbmj wrote: Hi everyone, This patch series is the result of this [1] thread about fixincludes on VxWorks. It resolves bugs 53457 and 53378, and a few other issues that previously required manual

Re: [PATCH] AIX pthread.h fixincludes

2012-06-19 Thread Bruce Korb
Hi David, On Tue, Jun 19, 2012 at 7:16 AM, David Edelsohn dje@gmail.com wrote: Okay? Okay. Cheers - Bruce

Re: [Ping] Fix gcc/gcov.c and libgcc/libgcov.c to fix build on VxWorks

2012-06-25 Thread Bruce Korb
On 06/24/12 15:54, rbmj wrote: + c_fix_arg = %0\n + #ifdef IN_GCC\n + #define mkdir(dir, mode) ((mode), (mkdir)(dir))\n + #endif\n; + c_fix_arg = extern[\t ]+STATUS[\t ]+mkdir[\t ]* + \\([\t ]*const[\t

Re: [PATCH] AIX fixincludes for pthread.h

2011-11-08 Thread Bruce Korb
On Mon, Nov 7, 2011 at 12:59 PM, David Edelsohn dje@gmail.com wrote: Okay? Well, okay, but I'd prefer one fix something like the following (and I confess I've not had any test time...) because it looks simpler to me: /* * pthread.h on AIX defines PTHREAD_ONCE_INIT without enough braces.

Re: [PATCH] AIX fixincludes for pthread.h

2011-11-08 Thread Bruce Korb
Hi David, On Tue, Nov 8, 2011 at 10:20 AM, David Edelsohn dje@gmail.com wrote: Okay? Well, okay, but Also, there are other fixincludes fixes for missing braces that directly add the braces, not a wrapper.  They are not multi-line macros, but there is a precedent on the style of

Re: [Patch] fixinclude: shell-quote testing file

2011-05-16 Thread Bruce Korb
On Mon, May 16, 2011 at 6:15 AM, Tristan Gingold ging...@adacore.com wrote: Hi, one of the main VMS include files has a dollar in its name (decc$types.h), which is not shell friendly. As a consequence, when the name is reused by check.tpl to create a baseline file, must be quoted. Ok

Re: [Patch] fixinclude: shell-quote testing file

2011-05-16 Thread Bruce Korb
Hi Tristan, On Mon, May 16, 2011 at 6:39 AM, Tristan Gingold ging...@adacore.com wrote: Sure.  [If] The patch below is ok for 'make check', is it also ok for you ? Yes, thank you.

Re: [Patch] fixincludes: fix solaris_complex_cxx rule syntax

2011-05-16 Thread Bruce Korb
Hi Tristan, On Mon, May 16, 2011 at 8:27 AM, Tristan Gingold ging...@adacore.com wrote: Yes, it is ok on GNU/Linux and Solaris. Do I really need to test on HP/UX and AIX ?  Won't be easy for me. Solaris and BSD are usually the most unusual, so I'd say go ahead for mainline and see if you get

Re: [fixincludes] Allow properly defining __cplusplus with Solaris headers (PR libstdc++-v3/1773)

2011-08-09 Thread Bruce Korb
On Tue, Aug 9, 2011 at 2:35 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Ok for mainline (no point in backporting to release branches since this will never be used)? Hi Rainer, never be used? OK. Looks good to me. Cheers - Bruce

Re: Remove obsolete Tru64 UNIX V5.1B fixinclude support

2012-03-05 Thread Bruce Korb
On 03/05/12 09:01, Rainer Orth wrote: This is where I need explicit approval and/or guidance: * There are some fixincludes hacks that from their names seem to be osf-specific, but are not restricted to alpha*-dec-osf*. Bruce, what's the best way to handle those? Disable them e.g. with a

Re: Remove obsolete Tru64 UNIX V5.1B support

2012-03-05 Thread Bruce Korb
CF: fixincludes: * inclhack.def (alpha___extern_prefix): Remove. (alpha___extern_prefix_standards): Remove. (alpha___extern_prefix_sys_stat): Remove. (alpha_bad_lval): Remove. (alpha_pthread): Remove. (alpha_pthread_gcc): Remove.

Re: Remove obsolete Tru64 UNIX V5.1B support

2012-03-05 Thread Bruce Korb
On Mon, Mar 5, 2012 at 3:13 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Mon, 5 Mar 2012, Rainer Orth wrote: * There are some fixincludes hacks that from their names seem to be   osf-specific, but are not restricted to alpha*-dec-osf*.  Bruce,   what's the best way to handle those?  

Re: [Patch]: Add include hacks for VMS headers

2012-03-12 Thread Bruce Korb
On Mon, Mar 12, 2012 at 3:05 AM, Tristan Gingold ging...@adacore.com wrote: Hi, this patch adds a few fix include entries for VMS so that: [things work] Looks good to me.

Re: Remove obsolete IRIX 6.5 support

2012-03-12 Thread Bruce Korb
On Mon, Mar 12, 2012 at 10:03 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: I'm happy with the stuff going away! :)

Re: Remove obsolete Solaris 8 support

2012-03-12 Thread Bruce Korb
On 03/12/12 10:44, Rainer Orth wrote: fixincludes: * inclhack.def (math_exception): Remove duplicate. (solaris_cond_init): Remove. (solaris_sys_va_list): Remove Solaris 8 support. I think I probably hate those COND initializers more than any other thing that

Re: [Patch]: Update fixincludes/README

2012-03-14 Thread Bruce Korb
I suppose after a decade of being gone, it's time to stop referencing it. OK for *ALL* active branches. On Wed, Mar 14, 2012 at 2:36 AM, Tristan Gingold ging...@adacore.com wrote: Hi, fixinc.sh is not anymore in gcc/ directory.  So I propose to adjust fixincludes/README. Ok for trunk ?

Re: [fixincludes] Fix pthread.h failure (PR other/52626)

2012-03-21 Thread Bruce Korb
Hi Rainer, On Wed, Mar 21, 2012 at 9:25 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: As reported in PR other/52626, make check in fixincludes is currently failing since I neglected to adapt the baseline for the Solaris 8 removal ;-(  I always meant to run make check, but forgot. On

Re: [fixincludes] Fix pthread.h failure (PR other/52626)

2012-03-22 Thread Bruce Korb
Rather simple... In a file called fixinclude.sum, put PASS: unique string or FAIL: unique string one per line, Bonus points if you can total passes and failures: I think you just put it into the check template so it creates the result. Since multiple fixes tweak the same file,

Re: [PATCH] AIX malloc.h fixincludes

2012-03-23 Thread Bruce Korb
On Fri, Mar 23, 2012 at 11:47 AM, David Edelsohn dje@gmail.com wrote: Some early releases of AIX 6 include a malloc.h header with an incorrect use of builtin keyword: #ifdef __cplusplus extern C {   extern builtin char *__alloca (size_t); #  define alloca __alloca } #endif /* def

Re: [Bug bootstrap/51705] [4.7 Regression] FreeBSD uses unsupported C++11 features when __cplusplus == 201103L

2012-01-11 Thread Bruce Korb
To eliminate any possible ambiguity, the patch is approved On 01/10/12 23:49, andreast at gcc dot gnu.org wrote: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51705 Andreas Toblerandreast at gcc dot gnu.org changed: What|Removed |Added

Re: [PATCH,fixincldes] AIX assert.h static_assert

2013-08-31 Thread Bruce Korb
Sure. Looks fine. Please apply to all active branches. On Sat, Aug 31, 2013 at 4:40 PM, David Edelsohn dje@gmail.com wrote:

Re: fixincludes patch RFA: Fix fenv.h on Ubuntu Precise

2013-11-07 Thread Bruce Korb
On 11/06/13 15:29, Ian Lance Taylor wrote: When fenv.h is not fixed, libquadmath does not build. This patch works around the problem. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for mainline? Hi Ian, Yes, please. This time, I'm on my dev box and looked at the code. You

Re: fixincludes patch RFA: Fix fenv.h on Ubuntu Precise

2013-11-07 Thread Bruce Korb
So is this the right patch? $ svn diff inclhack.def Index: inclhack.def === --- inclhack.def(revision 204533) +++ inclhack.def(working copy) @@ -1738,7 +1738,7 @@ versions. */ fix = { hackname =

Re: fixincludes patch RFA: Fix fenv.h on Ubuntu Precise

2013-11-07 Thread Bruce Korb
branch. Ian On Thu, Nov 7, 2013 at 10:16 AM, Ian Lance Taylor i...@google.com wrote: On Thu, Nov 7, 2013 at 8:48 AM, Bruce Korb bk...@gnu.org wrote: This time, I'm on my dev box and looked at the code. You remembered correctly that the first file name in the list of file names needs

Re: [PATCH] fixincludes: use $(FI) instead of fixincl@EXEEXT@

2013-11-08 Thread Bruce Korb
Sure. Looks good to me. Thanks On Fri, Nov 8, 2013 at 2:57 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 4 April 2013 22:20, Bruce Korb bk...@gnu.org wrote: Except as noted below, fine by me. On 04/04/13 12:56, Bernhard Reutner-Fischer wrote: Bootstrapped and regtested

Re: How to patch fixincludes/Makefile for Interix?

2011-06-03 Thread Bruce Korb
Hi Doug, On Fri, Jun 3, 2011 at 10:00 AM, Douglas B Rupp r...@gnat.com wrote: I've been working on a resurrection patch for Interix, one remaining problem is fixincludes/fixincl.c must be compiled on native Interix with -D_ALL_SOURCE in order to find the getpagesize prototype. This works

Re: [PATCH] fixincludes/Makefile for Interix

2011-06-05 Thread Bruce Korb
On 06/04/11 13:43, Douglas B Rupp wrote: Here's my proposed patch, along the lines you suggested. Hi Doug, Excellent. Just a couple nits: It is more normal and easier to read when you quote the entire shell script fragment, as below (removing unnecessary eval, too): diff -rupN

Re: AIX net/if_arp.h include fix for struct fc_softc

2011-06-06 Thread Bruce Korb
On 06/05/11 21:16, Peter O'Gorman wrote: Ok for trunk? Peter Index: ChangeLog === --- ChangeLog (revision 174678) 2011-??-?? Peter O'Gorman po...@thewrittenword.com * inclhack.def (aix_net_if_arp): New fix.

cxx-pretty-print.c tSCC removal

2011-06-06 Thread Bruce Korb
This part has been run through testing. I need approval for cp/cxx-pretty-print.c tho 2011-06-07 Bruce Korb bk...@gnu.org * gcc/cp/cxx-pretty-print.c (pp_cxx_decl_specifier_seq): Do not set case label inside an else clause. * fixincludes/fixlib.h (tCC): remove these #defines

Re: [PATCH] Fix bootstrap on OpenBSD, PR48851

2011-07-04 Thread Bruce Korb
Hi Richard, On Mon, Jul 4, 2011 at 4:04 AM, Richard Guenther rguent...@suse.de wrote: It happens that OpenBSD suffers from a bogus fixinclude that changes its perfectly valid NULL define from (void *)0 to 0.  The fix itself appears to be very old and is completely bogus - it replaces (void

../.././gcc/system.h:28:20: fatal error: stdarg.h: No such file or directory

2012-10-28 Thread Bruce Korb
Say, what? Anyone know what this is about? cp ../.././gcc/../fixincludes/README-fixinc include-fixed/README chmod a+r include-fixed/README echo timestamp stmp-int-hdrs TARGET_CPU_DEFAULT= \ HEADERS=auto-host.h ansidecl.h DEFINES=USED_FOR_TARGET \ /bin/sh ../.././gcc/mkconfig.sh tconfig.h

Parts 3 and 4 to the vxworks/fixincludes patches

2012-10-29 Thread Bruce Korb
The first two patches I've applied. The remaining two are needed to fully enable building the VxWorks flavor of GCC, but those bits affect parts outside of fixincludes and there is some breakage somewhere. All evidence seems to me to show fixincludes still doing its thing correctly, but somewhere

Re: Parts 3 and 4 to the vxworks/fixincludes patches

2012-11-01 Thread Bruce Korb
Hi Robert, On Thu, Nov 1, 2012 at 6:35 AM, rbmj r...@verizon.net wrote: and now my patches will build on top of trunk. Bruce, can you give steps on how to reproduce the error you reported? rm -rf gcc-bld gcc-ins cp -l gcc-svn gcc-bld pfx=$PWD/gcc-ins cd gcc-bld ./configure

VxWorks is done

2012-11-03 Thread Bruce Korb
Index: gcc/gcov-io.c === --- gcc/gcov-io.c (revision 193123) +++ gcc/gcov-io.c (working copy) @@ -92,7 +92,8 @@ { /* Read-only mode - acquire a read-lock. */ s_flock.l_type = F_RDLCK; - fd = open (name,

Re: [PING] Re: VxWorks Patches Back from the Dead!

2012-09-21 Thread Bruce Korb
From my part, I'm willing to push the patch, but I need confirmation from Paolo and Nathan because some of it affects code outside of my authority. On Thu, Sep 20, 2012 at 7:02 PM, rbmj r...@verizon.net wrote: Ping? Just did a full pull and rebuild today and everything still works :) Robert

git-svn: Unable to connect to a repository

2012-09-22 Thread Bruce Korb
Huh? Sorry. Don't know what else to say: Per: http://gcc.gnu.org/wiki/GitMirror $ git svn init -Ttrunk --prefix=origin/ svn+ssh://gcc.gnu.org/svn/gcc Network connection closed unexpectedly: Unable to connect to a repository at \ URL 'svn+ssh://gcc.gnu.org/svn/gcc': To better debug SSH

Re: git-svn: Unable to connect to a repository

2012-09-22 Thread Bruce Korb
On 09/22/12 12:49, Bruce Korb wrote: Huh? Sorry. Don't know what else to say: Similar results using straight up svn: $ bash contrib/gcc_update Updating SVN tree svn: E155036: Please see the 'svn upgrade' command svn: E155036: Working copy '/u/gnu/proj/gcc-svn' is too old (format 10, created

Re: git-svn: Unable to connect to a repository

2012-09-22 Thread Bruce Korb
Hi Gaby, On 09/22/12 13:07, Gabriel Dos Reis wrote: SVN is behaving unexpectedly. Help, please? Have you upgraded your system or SVN recently? Not deliberately. :) Switched openSuSE releases (12.2 now). If yes, you need to issue the command $ svn upgrade It's been crunching on

Re: [PATCH,fixincludes] Wrap fcntl.h on AIX

2012-09-29 Thread Bruce Korb
Does make check complain if a replacement/wrap fix doesn't have a test? If so, I'll be fixing it when I have time -- towards the end of October. (The patch I sent a few days ago ought to do it, but I've not fully tested yet.) Anyway, looks pretty reasonable to me... On Sat, Sep 29, 2012 at 9:45

Re: [PATCH, fixincludes] Fix NULL on AIX

2013-04-30 Thread Bruce Korb
Hi David, Looks good to me, but for a small nit: On Tue, Apr 30, 2013 at 7:40 AM, David Edelsohn dje@gmail.com wrote: +c_fix_arg = #ifndef NULL\n + #ifdef __cplusplus\n + #ifdef __GNUG__\n + #define NULL\t__null\n + #else\t /*

Re: [PATCH, fixincludes] Fix NULL on AIX

2013-04-30 Thread Bruce Korb
Hi, On Tue, Apr 30, 2013 at 9:42 AM, David Edelsohn dje@gmail.com wrote: I coped c_fix_arg from openbsd_null_definition fix. I don't know if two different formats for similar fixes would be confusing, but I do not have a problem using the EOF version. I haven't reviewed all patches and I

Re: [fixincludes] solaris_pow_int_overload should use __cplusplus

2013-05-16 Thread Bruce Korb
On 05/16/13 06:41, Rainer Orth wrote: Work is going on to incorporate all applicable fixincludes fixes into the Solaris headers proper. One fix is currently problematic since it uses an G++-internal macro (__GXX_EXPERIMENTAL_CXX0X__) where libstdc++ cmath already switched to testing

Fix Bug 51776 (finally...)

2013-07-06 Thread Bruce Korb
Index: ChangeLog === --- ChangeLog (revision 200737) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2013-07-06 Bruce Korb bk...@gnu.org + + * inclhack.def (cdef_cplusplus): removed, per Bug 51776 + 2013-05-23 Alexander Ivchenko

fixincludes 2013-05-23 Alexander Ivchenko alexander.ivche...@intel.com

2013-07-06 Thread Bruce Korb
, but it is protocol to ask. Also, I prefer that the hacks get inserted alphabetically. So, actually, there are a few small complaints. $ fgrep -i fixincludes ../MAINTAINERS fixincludes Bruce Korb bk...@gnu.org The patch looks pretty reasonable, but I think someone else should verify

Re: fixincludes 2013-05-23

2013-07-08 Thread Bruce Korb
Hi, On Mon, Jul 8, 2013 at 5:05 AM, Alexander Ivchenko aivch...@gmail.com wrote: Hi Bruce, That was my original letter: Hi, Could you please take a look at the attached fixinclude patch that addresses the problem: We have test fail for gcc.dg/cpp/trad/include.c on Android. The reason for

Re: fixincludes 2013-05-23

2013-07-08 Thread Bruce Korb
On Mon, Jul 8, 2013 at 11:42 AM, Alexander Ivchenko aivch...@gmail.com wrote: It sounds like it is better to fix the system headers instead. Via a fixincludes for older headers and have the android folks fix them for newer releases. Would that count for verifing? :) :) Indeed. I confess I

Re: fatal error: gnu/stubs-32.h: No such file

2013-07-29 Thread Bruce Korb
On Mon, Jul 29, 2013 at 6:22 AM, Andrew Haley a...@redhat.com wrote: There should be a better diagnostic. If you remember, the start of this thread was: Why is it that configure worked but stubs-32.h was not found? That is the correct thing to do. The reply, basically, was: It's too

Re: [PATCH] Fixinclude linux/vt.h problem breaking libsanitizer

2013-12-05 Thread Bruce Korb
Looks good to me. On Thu, Dec 5, 2013 at 2:18 AM, Richard Biener rguent...@suse.de wrote: This fixes the issue in linux/vt.h that appears in SUSE SLE11 kernel headers which contain a pre-release variant that is broken and not compatible with C++ (using the 'new' keyword). The following fix

fixinclude patch for fenv.h on Ubuntu

2013-12-07 Thread Bruce Korb
204533) +++ fixincludes/ChangeLog (working copy) @@ -1,3 +1,9 @@ +2013-09-20 Bruce Korb bk...@gnu.org + + * inclhack.def: many of the headers found under bits/ are + often stashed under architecture directories. Apply fixes + to those, too. Also, re-ordered a couple of misordered fixes. + 2013-09

fixinclude patch for fenv.h on Ubuntu

2013-12-08 Thread Bruce Korb
Adjusted for Richard Biener's patch Index: fixincludes/ChangeLog === --- fixincludes/ChangeLog (revision 205790) +++ fixincludes/ChangeLog (working copy) @@ -1,3 +1,14 @@ +2013-12-07 Bruce Korb bk...@gnu.org + + * inclhack.def

Re: configure check for flex

2013-12-08 Thread Bruce Korb
On 12/08/13 13:06, Gerald Pfeifer wrote: Lovely. Thank you very much! $ svn diff Index: configure.ac === --- configure.ac(revision 205790) +++ configure.ac(working copy) @@ -1319,10 +1319,17 @@ # Used for

Re: configure check for flex

2014-01-27 Thread Bruce Korb
On Sun, Jan 26, 2014 at 9:38 PM, Hans-Peter Nilsson h...@bitrange.com wrote: On Sun, 8 Dec 2013, Bruce Korb wrote: On 12/08/13 13:06, Gerald Pfeifer wrote: Lovely. Thank you very much! (Looks like nobody replied to this and it isn't committed.) No, flex isn't required to build GCC

Re: [PATCH] fixincludes: use $(FI) instead of fixincl@EXEEXT@

2013-04-04 Thread Bruce Korb
Except as noted below, fine by me. On 04/04/13 12:56, Bernhard Reutner-Fischer wrote: Bootstrapped and regtested on x86_64-unknown-linux-gnu and x86_64-mine-linux-uclibc without regressions, ok for trunk? fixincludes/ChangeLog: 2013-04-04 Bernhard Reutner-Fischer al...@gcc.gnu.org

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-05 Thread Bruce Korb
Hi, On Tue, Aug 5, 2014 at 4:35 AM, Alexander Ivchenko aivch...@gmail.com wrote: Testing for *android* is less than ideal, because of the possibility of configuring a *-linux* toolchain to have multilibs using various different C libraries (with -mandroid being used to select the Android

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-05 Thread Bruce Korb
Hi, On Tue, Aug 5, 2014 at 10:36 AM, enh e...@google.com wrote: you can see the current version of bionic's stdio.h here: https://android.googlesource.com/platform/bionic/+/master/libc/include/stdio.h i'm happy to add any string to the header file that makes things easier. if you want

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-05 Thread Bruce Korb
, Aug 5, 2014 at 5:09 PM, enh e...@google.com wrote: does https://android-review.googlesource.com/103445 look okay? On Tue, Aug 5, 2014 at 12:01 PM, Bruce Korb bk...@gnu.org wrote: Hi, On Tue, Aug 5, 2014 at 10:36 AM, enh e...@google.com wrote: you can see the current version of bionic's

Re: Remove unnecessary and harmful fixincludes for Android

2014-08-06 Thread Bruce Korb
Hi, On Wed, Aug 6, 2014 at 4:51 AM, Alexander Ivchenko aivch...@gmail.com wrote: We still have to remove fix for compiler.h: Correct. Thank you. Bruce, I think I formally have to ask for your approval again :) I don't think so. You've selected one of the changes we wrote about, so With

Re: [PATCH] PR other/63613: Add fixincludes for dejagnu.h

2014-12-05 Thread Bruce Korb
This is the first time I've touched the fixincludes directory; is this the correct way to make a change here? Well, I'd like to see it -- especially since it's your first. Please send to this gmail account or wait until I get my GNU email this weekend. Thanks! Successfully bootstrapped

Re: [PATCH] PR other/63613: Add fixincludes for dejagnu.h

2014-12-06 Thread Bruce Korb
On 12/05/14 12:32, Jeff Law wrote:1 fixincludes/ChangeLog: PR other/63613 * inclhack.def (dejagnu_h_make_inline_functions_static): New fix. * fixincl.x: Regenerate. * tests/base/dejagnu.h: New. OK. No, actually not. +fix = { +hackname =

Re: [off-list] A fixincludes warning-removal patch

2014-12-14 Thread Bruce Korb
On 12/14/14 14:07, Uros Bizjak wrote: Hello Bruce! I have posted a small fixincludes patch [1] that fixes a warning during the fixincludes build, Please apply. However, I'm sure it is not the last remaining warning since new warnings get invented. :) Thank you - Bruce 2014-12-09 Uros

checksum test for fixincluding

2014-12-20 Thread Bruce Korb
=== --- fixincludes/ChangeLog (revision 218991) +++ fixincludes/ChangeLog (working copy) @@ -1,9 +1,20 @@ +2013-12-07 Bruce Korb bk...@gnu.org + + * fixincludes/fixincl.tpl: add handling for sum selection + criteria and clean up layout

Re: [fixincludes] Fix iso/math_c99.h signbit on Solaris

2015-01-30 Thread Bruce Korb
On 01/29/15 05:38, Rainer Orth wrote: So I saw. If all else fails, we can still commit the (ugly/hard to read) initial version, otherwise libgo won't build on Solaris before some (quite recent) Solaris 11.2 patch, breaking bootstrap. Having it work at all seems like a nice feature. I think

Re: [fixincludes] Fix iso/math_c99.h signbit on Solaris

2015-01-28 Thread Bruce Korb
Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes no difference for the generated fixincl.x, but only with the escaping does make

Re: [fixincludes] Fix iso/math_c99.h signbit on Solaris

2015-01-28 Thread Bruce Korb
On 01/28/15 10:13, Bruce Korb wrote: Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes no difference for the generated fixincl.x

Re: [fixincludes] Fix iso/math_c99.h signbit on Solaris

2015-01-28 Thread Bruce Korb
On 01/28/15 10:15, Bruce Korb wrote: On 01/28/15 10:13, Bruce Korb wrote: Hi Rainer, Sorry for the long delay. Anyway: On 01/28/15 06:12, Rainer Orth wrote: * In test_text, I had to backslash-escape the trailing \, otherwise they were eaten up. Whether or not I do this makes

Re: [fixincludes] Fix iso/math_c99.h signbit on Solaris

2015-02-09 Thread Bruce Korb
On Mon, Feb 9, 2015 at 3:30 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: That worked fine indeed and is considerably more readable than my previous version. Excellent! Thank you. It produced the identical fixincl.x, passed fixincludes make check and Solaris 10 and 11 bootstraps.

Re: [PATCH, fixincludes] Fix PR 48009 53348

2015-02-15 Thread Bruce Korb
Looks good to me. On Sun, Feb 15, 2015 at 12:49 PM, David Edelsohn dje@gmail.com wrote: The stdlib.h header in AIX 4.3 does not correctly declare strtof with a const char* argument. Users are building the latest releases of GCC on AIX 4.3 The appended patch from Richard G Daniel uses

Re: [patch 3/28] fixincludes: Use automake-1.11.6 (across the tree)

2015-05-07 Thread Bruce Korb
On 05/06/15 01:58, Michael Haubenwallner wrote: Trivial patch for fixincludes. A) sufficiently trivial that explicit permission ought not be required B) it is now officially blessed that we can coalesce year lists. Let's do so, okay? Am 2015-05-05 um 18:03 schrieb Michael Haubenwallner:

Re: [PATCH, fixincludes] AIX headers and extern C

2015-05-21 Thread Bruce Korb
OK. You might consider updating autogen. It seems 5.18 doesn't handle the version test quite right. Any 5.18.n should do fine. I guess I didn't test the version test with older versions. :) On Thu, May 21, 2015 at 6:58 AM, David Edelsohn dje@gmail.com wrote: The AIX port of GCC is one of

Re: [PATCHv2] [fixincludes] Ignore .DS_Store junk files when running make check

2015-07-28 Thread Bruce Korb
Definitely much better. I won't apply it until the weekend, so someone else will likely beat me to it. Thank you. On Mon, Jul 27, 2015 at 7:36 PM, Eric Gallager eg...@gwmail.gwu.edu wrote: On 7/27/15, Andreas Schwab sch...@linux-m68k.org wrote: Eric Gallager eg...@gwmail.gwu.edu writes:

Re: [PATCH, FIXINCLUDES] AIX stdio C++ inline fix

2015-08-13 Thread Bruce Korb
Looks good to me... On Thu, Aug 13, 2015 at 10:33 AM, David Edelsohn dje@gmail.com wrote: AIX stdio.h header includes code specific for C++ that looks like: extern C { #ifdef __cplusplus #ifdef ferror #undef ferror inline int ferror(FILE * _p) { return ((_p)-_flag _IOERR);

  1   2   >