Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-11 Thread Yvan Roux
New attempt, with fixes from Richard's comments (discussed in the other thread). Thanks, Yvan 2013-09-09 Yvan Roux Vladimir Makarov * rtlanal.c (strip_address_mutations): Add bitfield operations handling. (shift_code_p): New predicate for shifting operati

Re: [i386, doc] Add documentation for fxsr, xsave, xsaveopt

2013-09-11 Thread Kirill Yukhin
Hello, On 10 Sep 19:42, Uros Bizjak wrote: > The patch is OK for mainline. Checked into main trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-09/msg00353.html -- Thanks, K

Re: RFC: patch to build GCC for arm with LRA

2013-09-11 Thread Richard Sandiford
Yvan Roux writes: > @@ -5454,6 +5454,16 @@ strip_address_mutations (rtx *loc, enum rtx_code > *outer_code) > /* Things like SIGN_EXTEND, ZERO_EXTEND and TRUNCATE can be > used to convert between pointer sizes. */ > loc = &XEXP (*loc, 0); > + else if (GET_RTX_CLASS (code

Re: [PATCH i386 2/8] [AVX512] Add mask registers.

2013-09-11 Thread Kirill Yukhin
Hello, On 10 Sep 11:51, Richard Henderson wrote: > On 09/10/2013 11:25 AM, Kirill Yukhin wrote: > > Is it ok now? > > > Yes. Thanks a lot! Checked into main trunk: http://gcc.gnu.org/ml/gcc-cvs/2013-09/msg00354.html -- Thanks, K

Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-11 Thread Richard Sandiford
James Greenhalgh writes: > On Tue, Sep 10, 2013 at 08:09:42PM +0100, Richard Sandiford wrote: >> Sorry for the breakage. gen_int_mode and GEN_INT really are only for >> scalar integers though. (So is plus_constant.) Vector constants should >> be CONST_VECTORs rather than CONST_INTs. >> >> I th

Re: [PATCH] Fix build_range_check (PR tree-optimization/58385)

2013-09-11 Thread Richard Biener
On Tue, 10 Sep 2013, Jakub Jelinek wrote: > Hi! > > If exp has side effects, for [-,-] ranges we would optimize them away. > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk/4.8? Ok. Thanks, Richard. > 2013-09-10 Jakub Jelinek > > PR tree-optimizati

Re: V4 Lambda templates and implicit function templates.

2013-09-11 Thread Adam Butcher
On 10.09.2013 03:19, Adam Butcher wrote: - Instantiation of generic conversion op ICEs if the call op contains declarations and hasn't already been instantiated. This is not a complete enough description. It only ICEs instantiating the call op through the decltype return of the conversion

Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-11 Thread Eric Botcazou
> Now bootstrapped & regression-tested on x86_64-linux-gnu. OK to install? Sure, modulo... > Thanks, > Richard > > > gcc/ > * simplify-rtx.c (simplify_unary_operation_1): Use simplify_gen_binary > for (not (neg ...)) and (neg (not ...)) casees. 'cases' -- Eric Botcazou

[patch windows i386]: Make sure that really-external functions aren't dllexported

2013-09-11 Thread Kai Tietz
Hi, this patch takes care that for C/C++ inlines aren't dll-exported. ChangeLog 2013-09-11 Kai Tietz * config/i386/winnt-cxx.c (i386_pe_type_dllexport_p): Don't dll-export inline-functions. * config/i386/winnt.c (i386_pe_determine_dllexport_p): Likewise. Tested for x86_64-w64-mi

Re: [PATCH GCC] Tweak gimple-ssa-strength-reduction.c:backtrace_base_for_ref () to cover different cases as seen on AArch64

2013-09-11 Thread Richard Biener
On Tue, Sep 10, 2013 at 5:53 PM, Yufeng Zhang wrote: > Hi, > > Following Bin's patch in > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00695.html, this patch tweaks > backtrace_base_for_ref () to strip of any widening conversion after the > first TREE_CODE check fails. Without this patch, the tes

Re: [patch 1/2] tree-flow.h restructuring

2013-09-11 Thread Richard Biener
On Tue, Sep 10, 2013 at 9:19 PM, Andrew MacLeod wrote: > Here's a start at restructuring the whole tree-flow.h mess that we created > back in the original wild west tree-ssa days. > > First, almost everyone includes tree-flow.h because it became the kitchen > sink of functionality. Really, what w

[patch driver]: Fix relocatable toolchain path-replacement in driver

2013-09-11 Thread Kai Tietz
Hi, This change fixes a quirk happening for relocated toolchains. Driver remembers original-build directory in std_prefix variable for being able later to modify path. Sadly this std_prefix variable gets modified later on, and so update_path can't work any longer as desired. This patch fixes th

Re: [patch 2/2] tree-flow.h restructuring

2013-09-11 Thread Richard Biener
On Tue, Sep 10, 2013 at 9:27 PM, Andrew MacLeod wrote: > This splits out tree-ssaname related things to tree-ssanames.h. This is then > included from tree-ssa.h This patch is ok as-is. > similar treatment can be given to tree-phinodes.c > > I notice a number of the other ssa passes only export

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-11 Thread Richard Biener
On Wed, 11 Sep 2013, Kugan wrote: > Thanks Jakub for the review. > > On 10/09/13 23:10, Jakub Jelinek wrote: > > On Tue, Sep 10, 2013 at 03:17:50PM +0200, Richard Biener wrote: > > > > unsigned short s; > > > > s.1_3 = (short unsigned int) l.0_2; > > > > l.0_2: VARYING > > > > s.1_3: [0, +INF] >

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-11 Thread Jakub Jelinek
On Wed, Sep 11, 2013 at 11:02:30AM +0200, Richard Biener wrote: > Make sure to add a predicate that can tell whether its an anti-range > then. Or perhaps extraction routine, that given an SSA_NAME will give you a triplet, { enum value_range_type vr_type; double_int min, max; } For non-integral SS

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-11 Thread Richard Biener
On Wed, 11 Sep 2013, Jakub Jelinek wrote: > On Wed, Sep 11, 2013 at 11:02:30AM +0200, Richard Biener wrote: > > Make sure to add a predicate that can tell whether its an anti-range > > then. > > Or perhaps extraction routine, that given an SSA_NAME will give you > a triplet, > { enum value_range

[PATCH] Move RDG from tree-data-ref.c to tree-loop-distribution.c

2013-09-11 Thread Richard Biener
This moves the RDG implementation private to its only user, loop distribution, and away from the unrelated data-reference/dependence code. The patch also moves the loops bitmap passed around into the partition struct. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2013-

[PATCH] Split critical edges before late uninit warning pass

2013-09-11 Thread Richard Biener
This patch adds critical edge splitting before the late uninit warning pass in the -Og pipeline (the patch is for the 4.8 branch where the testcase otherwise fails). If I commit this then I'll commit a corresponding change to trunk as well. On trunk we can also split critical edges in the regula

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-11 Thread Alexander Monakov
On Tue, 10 Sep 2013, Wei Mi wrote: > Because deps_analyze_insn only analyzes data deps but no control deps. > Control deps are included by add_branch_dependences. Without the > chain_to_prev_insn in the end of add_branch_dependences, jmp will be > control dependent on every previous insn in the

Re: [PATCH] Split critical edges before late uninit warning pass

2013-09-11 Thread Jakub Jelinek
On Wed, Sep 11, 2013 at 12:00:04PM +0200, Richard Biener wrote: > It should make -Og more usable on the branch and as it is quite > new I suppose the change qualifies for the branch (I lately > moved some passes there for other diagnostic issues). > > Opinions on generally splitting critical edges

Re: folding (vec_)cond_expr in a binary operation

2013-09-11 Thread Marc Glisse
Any other comments on this patch? http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00129.html On Tue, 3 Sep 2013, Marc Glisse wrote: (attaching the latest version. I only added comments since regtesting it) On Tue, 3 Sep 2013, Richard Biener wrote: Btw, as for the patch I don't like that you bas

Re: [RS6000] powerpc64 -mcmodel=medium large symbol offsets

2013-09-11 Thread Alan Modra
On Mon, Sep 09, 2013 at 06:37:03PM +0930, Alan Modra wrote: > gcc/ > * config/rs6000/predicates.md (add_cint_operand): New. > (reg_or_add_cint_operand): Use add_cint_operand. > * config/rs6000/rs6000.md (largetoc_high_plus): Restrict offset > using add_cint_operand. >

Re: [PATCH, PowerPC] Fix PR57949 (ABI alignment issue)

2013-09-11 Thread Alan Modra
On Wed, Aug 14, 2013 at 10:32:01AM -0500, Bill Schmidt wrote: > This fixes a long-standing problem with GCC's implementation of the > PPC64 ELF ABI. If a structure contains a member requiring 128-bit > alignment, and that structure is passed as a parameter, the parameter > currently receives only

[patch config.gcc]: Add a missed 64-bit cygwin case

2013-09-11 Thread Kai Tietz
Hi, One missing nit in config.gcc to choose proper cpu default and split cygwin and mingw targets. ChangeLog 2013-09-11 Kai Tietz * config.gcc: Separate cases for mingw and cygwin targets, and add 64-bit cygwin target case. Tested for x86_64-pc-cygwin, i686-pc-cygwin, i686-w64-mingw

Re: RFC: patch to build GCC for arm with LRA

2013-09-11 Thread Yvan Roux
Yes indeed ! here is a fixed patch. In strip_address_mutations we now have 3 if/else if statements with the same body which could be factorized in: if ((GET_RTX_CLASS (code) == RTX_UNARY) /* Things like SIGN_EXTEND, ZERO_EXTEND and TRUNCATE can be used to convert betw

Re: [PATCH, PowerPC] Fix PR57949 (ABI alignment issue)

2013-09-11 Thread Jakub Jelinek
On Wed, Sep 11, 2013 at 09:08:46PM +0930, Alan Modra wrote: > The following was bootstrapped and regression checked powerpc64-linux. > OK for mainline, and the 4.7 and 4.8 branches when/if Bill's patch > goes in there? IMHO ABI changing patches shouldn't be backported to release branches.

Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-11 Thread Graham Stott
Hi Richard, There is some minor testsuite fallout with these patches on MIPS a couple of tests (see below)ICE ingen_int_mode () in both these ICE the mode is CCmode. Here we arrive at gen_int_mode () via a use of plus_constant () is cse.c with a register with CCmode called fromĀ  find_reg_offset

Re: [PATCH] Split critical edges before late uninit warning pass

2013-09-11 Thread Richard Biener
On Wed, 11 Sep 2013, Jakub Jelinek wrote: > On Wed, Sep 11, 2013 at 12:00:04PM +0200, Richard Biener wrote: > > It should make -Og more usable on the branch and as it is quite > > new I suppose the change qualifies for the branch (I lately > > moved some passes there for other diagnostic issues).

Re: [patch 2/2] tree-flow.h restructuring

2013-09-11 Thread Andrew MacLeod
On 09/11/2013 04:55 AM, Richard Biener wrote: On Tue, Sep 10, 2013 at 9:27 PM, Andrew MacLeod wrote: This splits out tree-ssaname related things to tree-ssanames.h. This is then included from tree-ssa.h This patch is ok as-is. similar treatment can be given to tree-phinodes.c I notice a nu

Re: [PATCH GCC] Tweak gimple-ssa-strength-reduction.c:backtrace_base_for_ref () to cover different cases as seen on AArch64

2013-09-11 Thread Bill Schmidt
On Wed, 2013-09-11 at 10:32 +0200, Richard Biener wrote: > On Tue, Sep 10, 2013 at 5:53 PM, Yufeng Zhang wrote: > > Hi, > > > > Following Bin's patch in > > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00695.html, this patch tweaks > > backtrace_base_for_ref () to strip of any widening conversion

Re: [patch 1/2] tree-flow.h restructuring

2013-09-11 Thread Andrew MacLeod
On 09/11/2013 04:45 AM, Richard Biener wrote: On Tue, Sep 10, 2013 at 9:19 PM, Andrew MacLeod wrote: Here's a start at restructuring the whole tree-flow.h mess that we created back in the original wild west tree-ssa days. First, almost everyone includes tree-flow.h because it became the kitche

Re: C++ demangler fix

2013-09-11 Thread Gary Benson
Jakub Jelinek wrote: > cp-demangle.c isn't used just in libiberty, where using hashtab, > xcalloc, XNEW etc. is fine, but also in libsupc++/libstdc++, where > none of that is fine. That is why cp-demangle.c only uses > e.g. realloc, checks for allocation failures and propagates those to > the call

Re: [PATCH, PowerPC] Fix PR57949 (ABI alignment issue)

2013-09-11 Thread Bill Schmidt
On Wed, 2013-09-11 at 21:08 +0930, Alan Modra wrote: > On Wed, Aug 14, 2013 at 10:32:01AM -0500, Bill Schmidt wrote: > > This fixes a long-standing problem with GCC's implementation of the > > PPC64 ELF ABI. If a structure contains a member requiring 128-bit > > alignment, and that structure is pa

Re: C++ demangler fix

2013-09-11 Thread Jakub Jelinek
On Wed, Sep 11, 2013 at 01:49:46PM +0100, Gary Benson wrote: > Jakub Jelinek wrote: > > cp-demangle.c isn't used just in libiberty, where using hashtab, > > xcalloc, XNEW etc. is fine, but also in libsupc++/libstdc++, where > > none of that is fine. That is why cp-demangle.c only uses > > e.g. rea

[PATCH] Move edge_within_scc to ipa-utils.c

2013-09-11 Thread Martin Jambor
Hi, edge_within_scc should really be a part of API accompanying ipa_reduced_postorder just like ipa_get_nodes_in_cycle and so this patch moves it to ipa-utils.c and gives it the ipa_ prefix. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2013-09-10 Martin Jambor

[PATCH, testsuite] Add testcase from PR 58371

2013-09-11 Thread Martin Jambor
Hi, the bug I have fixed yesterday got reported a day earlier as PR 58371. This patch adds the testcase from that PR to the testsuite. Honza asked for it so I assume it has been pre-approved and so I will commit it later today or early tomorrow if there are no objections. Thanks, Martin 2013-

Re: [patch 1/2] tree-flow.h restructuring

2013-09-11 Thread Richard Biener
On Wed, Sep 11, 2013 at 2:30 PM, Andrew MacLeod wrote: > On 09/11/2013 04:45 AM, Richard Biener wrote: >> >> On Tue, Sep 10, 2013 at 9:19 PM, Andrew MacLeod >> wrote: >>> >>> Here's a start at restructuring the whole tree-flow.h mess that we >>> created >>> back in the original wild west tree-ssa

RE: [PATCH, PR 57748] Check for out of bounds access

2013-09-11 Thread Bernd Edlinger
On Tue, 10 Sep 2013 21:32:29, Martin Jambor wrote: > Hi, > > On Fri, Sep 06, 2013 at 11:19:18AM +0200, Richard Biener wrote: >> On Fri, Sep 6, 2013 at 10:35 AM, Bernd Edlinger >> wrote: >>> Richard, >>> But the movmisalign path skips all this code and with the current code thinks the act

Re: [PATCH, PR 57748] Check for out of bounds access

2013-09-11 Thread Richard Biener
On Wed, Sep 11, 2013 at 3:41 PM, Bernd Edlinger wrote: > On Tue, 10 Sep 2013 21:32:29, Martin Jambor wrote: >> Hi, >> >> On Fri, Sep 06, 2013 at 11:19:18AM +0200, Richard Biener wrote: >>> On Fri, Sep 6, 2013 at 10:35 AM, Bernd Edlinger >>> wrote: Richard, > But the movmisalign path

Re: V4 Lambda templates and implicit function templates.

2013-09-11 Thread Jason Merrill
On 09/11/2013 03:38 AM, Adam Butcher wrote: This is not a complete enough description. It only ICEs instantiating the call op through the decltype return of the conversion op if the return type of the call op is a deduced one (i.e. unspecified or specified explicitly as 'auto'). If the lambda c

[linaro/gcc-4_8-branch] Backports from trunk and merge from gcc-4_8-branch

2013-09-11 Thread Christophe Lyon
Hi, We have recently committed backports from trunk to linaro/gcc-4_8-branch: 201624,201666 (as 202196) 201589 (as 202276) 201599 (as 202277) 201730,201731

Re: [patch driver]: Fix relocatable toolchain path-replacement in driver

2013-09-11 Thread Joseph S. Myers
On Wed, 11 Sep 2013, Kai Tietz wrote: > This change fixes a quirk happening for relocated toolchains. Driver > remembers original-build directory The original *build* directory should never be known to the driver; only the *configured* prefix. This area is complicated and subtle; you need to b

Re: V4 Lambda templates and implicit function templates.

2013-09-11 Thread Jason Merrill
On 09/11/2013 10:42 AM, Jason Merrill wrote: Sounds like the problem is that the compiler is trying to instantiate a function while cp_unevaluated_operand is set. But that shouldn't be an issue because push_to_top_level clears cp_unevaluated_operand. How does it come to be set when instantiatin

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-11 Thread Wei Mi
I tried that and it caused some regressions, so I choosed to do chain_to_prev_insn another time in add_branch_dependences. There could be some dependence between those two functions. On Wed, Sep 11, 2013 at 2:58 AM, Alexander Monakov wrote: > > > On Tue, 10 Sep 2013, Wei Mi wrote: > >> Because de

Re: [PATCH V4 2/2] Support using 'auto' in a function parameter list to introduce an implicit template parameter.

2013-09-11 Thread Jason Merrill
On 09/09/2013 10:19 PM, Adam Butcher wrote: + if (current_class_type && LAMBDA_TYPE_P (current_class_type)) + { + if (cxx_dialect < cxx1y) + pedwarn (location_of (type), 0, +"use of % in lambda parameter declaration " +

Re: [PATCH, PowerPC] Fix PR57949 (ABI alignment issue)

2013-09-11 Thread Jay
Isn't mixing and matching and mismatching somewhat inevitable? Libffi & gcc don't always come along with each other? One must never change the ABI? - Jay On Sep 11, 2013, at 5:55 AM, Bill Schmidt wrote: > On Wed, 2013-09-11 at 21:08 +0930, Alan Modra wrote: >> On Wed, Aug 14, 2013 at 10:32:01

Re: [PATCH, i386, MPX 1/X] Support of Intel MPX ISA

2013-09-11 Thread Uros Bizjak
On Tue, Sep 10, 2013 at 1:38 PM, Ilya Enkovich wrote: > Ping^4 > > Could please someone look at this patch? It is mostly i386 target > specific and is basic for further MPX based features. > > Thanks, > Ilya > > 2013/9/2 Ilya Enkovich : >> Ping^3 >> >> Attached is the same patch but against the cu

Re: [PATCH V4 1/2] Support lambda templates.

2013-09-11 Thread Jason Merrill
OK. Jason

Re: [patch driver]: Fix relocatable toolchain path-replacement in driver

2013-09-11 Thread Kai Tietz
2013/9/11 Joseph S. Myers : > On Wed, 11 Sep 2013, Kai Tietz wrote: > >> This change fixes a quirk happening for relocated toolchains. Driver >> remembers original-build directory > > The original *build* directory should never be known to the driver; only > the *configured* prefix. > > This area

Re: [PATCH] PR tree-optimization/58380

2013-09-11 Thread Dominique Dhumieres
The test g++.dg/torture/pr58380.C fails: FAIL: g++.dg/torture/pr58380.C -O0 (test for excess errors) FAIL: g++.dg/torture/pr58380.C -O1 (test for excess errors) FAIL: g++.dg/torture/pr58380.C -O2 (test for excess errors) FAIL: g++.dg/torture/pr58380.C -O3 -fomit-frame-pointer (test for exc

Re: [PATCH] PR tree-optimization/58380

2013-09-11 Thread Paolo Carlini
Hi, On 09/11/2013 07:40 PM, domi...@lps.ens.fr wrote: The failures are (at least on x86_64-apple-darwin10): /opt/gcc/work/gcc/testsuite/g++.dg/torture/pr58380.C: In static member function 'static iplugin_factory& selection_to_stdout::get_factory()': /opt/gcc/work/gcc/testsuite/g++.dg/torture/p

Re: V4 Lambda templates and implicit function templates.

2013-09-11 Thread Adam Butcher
On 11.09.2013 16:25, Jason Merrill wrote: On 09/11/2013 10:42 AM, Jason Merrill wrote: Sounds like the problem is that the compiler is trying to instantiate a function while cp_unevaluated_operand is set. But that shouldn't be an issue because push_to_top_level clears cp_unevaluated_operand.

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-11 Thread Alexander Monakov
On Wed, 11 Sep 2013, Wei Mi wrote: > I tried that and it caused some regressions, so I choosed to do > chain_to_prev_insn another time in add_branch_dependences. There could > be some dependence between those two functions. (please don't top-post on this list) In that case you can adjust 'last

Re: [patch 1/2] tree-flow.h restructuring

2013-09-11 Thread Andrew MacLeod
OK, here's the patch... virtually the same except I moved useless_type_conversion_p() and types_compatible_p() to gimple.[ch] instead of tree.[ch]. Upon closer examination, the comments for those functions are fine, they say that this is for middle-end types... Bootstrapped and no new regr

Re: RFC: patch to build GCC for arm with LRA

2013-09-11 Thread Richard Sandiford
Yvan Roux writes: > Yes indeed ! here is a fixed patch. > > In strip_address_mutations we now have 3 if/else if statements with > the same body which could be factorized in: > > if ((GET_RTX_CLASS (code) == RTX_UNARY) > /* Things like SIGN_EXTEND, ZERO_EXTEND and TRUNCATE can be >

[PATCH, libvtv] Fix configure/testsuite issues with libvtv

2013-09-11 Thread Caroline Tice
This patch should fix the issues that people were having with the libvtv testsuite being run (and failing) when GCC was not configured with --enable-vtable-verify. I am still in the process of running some tests, but at this point I am fairly confident that this patch works correctly. Even thoug

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-11 Thread Richard Sandiford
Graham Stott writes: > Hi Richard, > > There is some minor testsuite fallout with these patches on MIPS a > couple of tests (see below)ICE ingen_int_mode () in both these ICE the > mode is CCmode. Hmm, interesting. I suppose gen_int_mode should handle CC modes, since there's no other constant rt

Re: crash fix for unhanded operation

2013-09-11 Thread Mike Stump
On Sep 10, 2013, at 3:43 PM, Joseph S. Myers wrote: > For target-specific types with more fine-grained > restrictions on permitted operations, there are several target hooks such > as invalid_unary_op, invalid_binary_op and invalid_parameter_type. That's > how the errors should be given, so th

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-11 Thread Wei Mi
Taking the same issue slot is not enough for x86. The compare and branch need to be consecutive in binary to be macro-fused on x86. Thanks, Wei Mi. On Wed, Sep 11, 2013 at 10:45 AM, Andrew Pinski wrote: > On Wed, Sep 4, 2013 at 12:33 PM, Alexander Monakov wrote: >> On Wed, Sep 4, 2013 at 9:53 P

Re: Using gen_int_mode instead of GEN_INT minot testsuite fallout on MIPS

2013-09-11 Thread Graham Stott
Hi Richard, Thanks I'll give a go tomorrow. Not sure why it has only been seen/reported for MIPS so far I can't see why it can't happen in other backends. Cheers Graham

Re: RFC: patch to build GCC for arm with LRA

2013-09-11 Thread Yvan Roux
> Yeah, good point. TBH I prefer it with separate ifs though, because the > three cases are dealing with three different types of rtl (unary, binary > and ternary). But I don't mind much either way. Ok, it's fine for me too. > The new patch looks good to me, thanks. Just one minor style nit: >

Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv

2013-09-11 Thread Caroline Tice
On Wed, Sep 11, 2013 at 12:07 PM, H.J. Lu wrote: > On Wed, Sep 11, 2013 at 11:22 AM, Caroline Tice wrote: >> This patch should fix the issues that people were having with the >> libvtv testsuite being run (and failing) when GCC was not configured >> with --enable-vtable-verify. I am still in th

Re: [PATCH, libgcc] Disable JCR section when java is not enabled

2013-09-11 Thread Ian Lance Taylor
On Tue, Sep 10, 2013 at 2:01 AM, Joey Ye wrote: > Updated to http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01097.html > > Build passes on arm-none-eabi and bootstrap passes on x86. > > OK to trunk? > > ChangeLog > * libgcc/Makefile.in: Include JAVA_IS_ENABLED in CFLAGS. > * libgcc/confi

Re: [patch driver]: Fix relocatable toolchain path-replacement in driver

2013-09-11 Thread Joseph S. Myers
On Wed, 11 Sep 2013, Kai Tietz wrote: > > update_path should, as I understand it, always be called with PATH being a > > relocated path (one that has had the configured prefix converted to the > > prefix where the toolchain is in fact installed, using > > make_relative_prefix, or that doesn't need

[C++ Patch] Improve finish_pseudo_destructor_expr location

2013-09-11 Thread Paolo Carlini
Hi, when yesterday I analyzed a bit c++/58363 and eventually I committed a pretty printing fix I noticed that the column was wrong for the pseudo destructor expression m.~f, pointing at the end. A fix turns out to be rather simple, because finish_pseudo_destructor_expr was simply not getting

Re: V4 Lambda templates and implicit function templates.

2013-09-11 Thread Jason Merrill
On 09/11/2013 02:22 PM, Adam Butcher wrote: Okay for the attached to go to trunk with suitable changelog? Yes. Jason

Re: [PATCH] PR tree-optimization/58380

2013-09-11 Thread Jeff Law
On 09/11/2013 12:20 PM, Paolo Carlini wrote: Hi, On 09/11/2013 07:40 PM, domi...@lps.ens.fr wrote: The failures are (at least on x86_64-apple-darwin10): /opt/gcc/work/gcc/testsuite/g++.dg/torture/pr58380.C: In static member function 'static iplugin_factory& selection_to_stdout::get_factory()':

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-11 Thread Andrew Pinski
On Wed, Sep 4, 2013 at 12:33 PM, Alexander Monakov wrote: > On Wed, Sep 4, 2013 at 9:53 PM, Steven Bosscher wrote: >> >> On Wed, Sep 4, 2013 at 10:58 AM, Alexander Monakov wrote: >> > Hello, >> > >> > Could you use the existing facilities instead, such as adjust_priority >> > hook, >> > or makin

Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv

2013-09-11 Thread H.J. Lu
On Wed, Sep 11, 2013 at 11:22 AM, Caroline Tice wrote: > This patch should fix the issues that people were having with the > libvtv testsuite being run (and failing) when GCC was not configured > with --enable-vtable-verify. I am still in the process of running > some tests, but at this point I

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-11 Thread Yvan Roux
Here is the new patch discussed in the other thread. Thanks Yvan 2013-09-11 Yvan Roux Vladimir Makarov * rtlanal.c (lsb_bitfield_op_p): New predicate for bitfield operations from the least significant bit. (strip_address_mutations): Add bitfield operation

Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv

2013-09-11 Thread H.J. Lu
On Wed, Sep 11, 2013 at 12:27 PM, Caroline Tice wrote: > >> 2. Why does libvtv/configure.ac have >> >> echo 'MULTISUBDIR =' >> $ac_file >> ml_norecursion=yes >> . ${multi_basedir}/config-ml.in >> >> when AM_ENABLE_MULTILIB is used? I got >> >> make[3]: Entering directory >> `/export/b

Re: [RS6000] powerpc64 -mcmodel=medium large symbol offsets

2013-09-11 Thread David Edelsohn
On Wed, Sep 11, 2013 at 7:12 AM, Alan Modra wrote: > On Mon, Sep 09, 2013 at 06:37:03PM +0930, Alan Modra wrote: >> gcc/ >> * config/rs6000/predicates.md (add_cint_operand): New. >> (reg_or_add_cint_operand): Use add_cint_operand. >> * config/rs6000/rs6000.md (largetoc_high_plus)

gcc_GAS_FLAGS: Add more gcc_cv_as_flags overrides

2013-09-11 Thread Thomas Schwinge
Hi! In a toolchain where GCC has been configured for --target=i686-pc-linux-gnu, and where an x86_64 multilib has also been configured, by default GCC will generate code for 32-bit mode, and for 64-bit mode only when -m64 is passed. Per ASM_SPEC definition, the -m64 option is translated to --64 w

Re: [PATCH][RFC] Move IVOPTs closer to RTL expansion

2013-09-11 Thread Pat Haugen
On 09/04/2013 04:20 AM, Richard Biener wrote: Any help with benchmarking this on targets other than x86_64 is appreciated (I'll re-do x86_64). I ran CPU2000 and CPU2006 on PowerPC comparing the patch. CPU2000 had 3 benchmarks degrade in the 4%-6%range (254.gap, 168.wupwise, 173.applu).CPU2006

[PATCH] [x86] Incorrect naming of FMA Builtins in documentation.

2013-09-11 Thread Cameron McInally
Hey guys, It appears that there are errors in the x86 FMA Builtins documentation. The FMA instruction names should be prefixed with a 'v'. Also the FMA instructions operate on XMM/YMM registers, not MMX registers. Please find a Patch and ChangeLog attached for both issues. I do not have commit ac

Re: [patch] Make cxxfilt demangle internal-linkage templates

2013-09-11 Thread Paul Pluzhnikov
Ping x2? Original message: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00394.html On Fri, Aug 16, 2013 at 6:10 PM, Paul Pluzhnikov wrote: > Ping? -- Paul Pluzhnikov

Re: gcc_GAS_FLAGS: Add more gcc_cv_as_flags overrides

2013-09-11 Thread H.J. Lu
On Wed, Sep 11, 2013 at 2:23 PM, Thomas Schwinge wrote: > Hi! > > In a toolchain where GCC has been configured for > --target=i686-pc-linux-gnu, and where an x86_64 multilib has also been > configured, by default GCC will generate code for 32-bit mode, and for > 64-bit mode only when -m64 is passe

Re: gcc_GAS_FLAGS: Add more gcc_cv_as_flags overrides

2013-09-11 Thread Thomas Schwinge
Hi! On Wed, 11 Sep 2013 14:53:58 -0700, "H.J. Lu" wrote: > On Wed, Sep 11, 2013 at 2:23 PM, Thomas Schwinge > wrote: > > --- gcc/acinclude.m4 > > +++ gcc/acinclude.m4 > > @@ -444,8 +444,16 @@ AC_DEFUN([gcc_GAS_FLAGS], > > [AC_CACHE_CHECK([assembler flags], gcc_cv_as_flags, > > [ case "$target"

[PATCH] disable use_vector_fp_converts for m_CORE_ALL

2013-09-11 Thread Wei Mi
For the following testcase 1.c, on westmere and sandybridge, performance with the option -mtune=^use_vector_fp_converts is better (improves from 3.46s to 2.83s). It means cvtss2sd is often better than unpcklps+cvtps2pd on recent x86 platforms. 1.c: float total = 0.2; int k = 5; int main() { int

[ping**(n+1)] reimplement -fstrict-volatile-bitfields, v3

2013-09-11 Thread Sandra Loosemore
Ping? On 09/02/2013 12:56 PM, Sandra Loosemore wrote: On 09/02/2013 03:10 AM, Richard Biener wrote: Can someone, in a new thread, ping the patches that are still in flight? ISTR having approved bits of some patches before my leave. Here's the current state of the patch set I put together. I

Re: gcc_GAS_FLAGS: Add more gcc_cv_as_flags overrides

2013-09-11 Thread Joseph S. Myers
On Wed, 11 Sep 2013, Thomas Schwinge wrote: > configure:23559: checking assembler for thread-local storage support I don't expect anyone to work on this, but such a configure test is silly - it's a test where a failure is more likely to indicate the test is buggy than that the feature teste

[PATCH] [vectorizer] Fixing a bug in tree-vect-patterns.c in GCC vectorizer.

2013-09-11 Thread Cong Hou
Hi There is a bug in the function vect_recog_dot_prod_pattern() in tree-vect-patterns.c. This function checks if a loop is of dot production pattern. Specifically, according to the comment of this function: /* Try to find the following pattern: type x_t, y_t; TYPE1 prod; TYPE2 su

Re: [PATCH] [vectorizer] Fixing a bug in tree-vect-patterns.c in GCC vectorizer.

2013-09-11 Thread Xinliang David Li
Can you add a test case to the regression suite? When the type of arguments are unsigned short/unsigned int, GCC does not vectorize the loop anymore -- this is worth a separate bug to track. punpcklwd instruction can be used to do zero extension of the short type. David On Wed, Sep 11, 2013 at 6

Re: [PATCH, PowerPC] Fix PR57949 (ABI alignment issue)

2013-09-11 Thread Alan Modra
On Wed, Sep 11, 2013 at 07:55:43AM -0500, Bill Schmidt wrote: > On Wed, 2013-09-11 at 21:08 +0930, Alan Modra wrote: > > On Wed, Aug 14, 2013 at 10:32:01AM -0500, Bill Schmidt wrote: > > > This fixes a long-standing problem with GCC's implementation of the > > > PPC64 ELF ABI. If a structure conta

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-11 Thread Brooks Moses
Ping^3? Joseph, I'd been cc'ing you on this because it's driver-related and I didn't find a more-obvious reviewer. Is there someone else I should be asking to review it? Alternately, is this a change that should be discussed on gcc@ before having the actual patch reviewed? On Tue, Sep 3, 2013 a

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-11 Thread Wei Mi
Thanks! Your method to adjust 'last' is more concise. I try it and it works for small testcases. bootstrap and regression are ok. More performance test is going on. I agree with you that explicit handling in sched-deps.c for this feature looks not good. So I move it to sched_init (Instead of ix86_

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-11 Thread Steve Kargl
On Wed, Sep 11, 2013 at 09:54:57PM -0700, Brooks Moses wrote: > Ping^3? > There is little to no Fortran specific content, which requires a Fortran review. If no one steps up, just commit the change. -- Steve

RE: [PATCH GCC]Catch more MEM_REFs sharing common addressing part in gimple strength reduction

2013-09-11 Thread bin.cheng
On Tue, Sep 10, 2013 at 9:30 PM, Bill Schmidt wrote: > > > On Tue, 2013-09-10 at 15:41 +0800, bin.cheng wrote: >> On Mon, Sep 9, 2013 at 11:35 PM, Bill Schmidt >> wrote: >> > >> >> > I rely on size_binop to convert T2 into sizetype, because T2' may be in >> >> > other kind of type. Otherwise