Re: [patch, libgfortran] Wrong result for UTF-8/UCS-4 list-directed and namelist read and nml write

2014-04-24 Thread Tobias Burnus
Jerry DeLisle wrote: The attached patch fixes namelist read/write and list directed read/write to support UTF-8. I have attached a preliminary test case to use to experiment with this. I will need to set it up for the testsuite still. Regression tested on x86-64-linux-gnu. OK for trunk or

Re: [i386] define __SIZEOF_FLOAT128__

2014-04-24 Thread Uros Bizjak
On Thu, Apr 24, 2014 at 7:35 AM, Marc Glisse marc.gli...@inria.fr wrote: (Adding an i386 maintainer in Cc) http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00620.html On Sun, 13 Apr 2014, Marc Glisse wrote: Hello, some people like having a macro to test if a type is available

[Ping][Patch, GCC/Thumb1] Improve 64bit constant load for Thumb1

2014-04-24 Thread Terry Guo
Ping ... BR, Terry -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Terry Guo Sent: Friday, April 11, 2014 3:36 PM To: gcc-patches@gcc.gnu.org Cc: Richard Earnshaw; Ramana Radhakrishnan Subject: [Patch, GCC/Thumb1] Improve

Re: Add call_fusage_contains_non_callee_clobbers hook

2014-04-24 Thread Tom de Vries
On 23-04-14 17:10, Richard Sandiford wrote: FWIW I think this should be a plain bool rather than a function, like delay_sched2 etc. Vladimir, I've reimplemented the hook using DEFHOOKPOD instead of DEFHOOK, to make it a plain bool. OK for trunk? Thanks, - Tom 2013-04-29 Radovan

[Patch] Fix a typo in Chinese msg

2014-04-24 Thread Jincheng Miao
There is a minor typo in zh_CN.po, should change '-pic' to '-fpic'. Best wishes, Jincheng Miao Index: gcc/po/zh_CN.po === --- gcc/po/zh_CN.po (revision 209734) +++ gcc/po/zh_CN.po (working copy) @@ -24308,7 +24308,7 @@ msgstr

Re: [Patch]Simplify SUBREG with operand whose target bits are cleared by AND operation

2014-04-24 Thread Terry Guo
On Mon, Apr 14, 2014 at 6:13 PM, Terry Guo flame...@gmail.com wrote: On Thu, Apr 3, 2014 at 10:11 PM, Eric Botcazou ebotca...@adacore.com wrote: I find the GCC function simplify_subreg fails to simplify rtx (subreg:SI (and:DI (reg/v:DI 115 [ a ]) (const_int 4294967295 [0x])) 4) to zero

Re: [PATCH][AArch64] Vectorise bswap[16,32,64]

2014-04-24 Thread Marcus Shawcroft
On 16 April 2014 09:12, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: On 15/04/14 18:45, Eric Christopher wrote: Testcase weirdness? for (i 0; i N; ++i) { arr[i] = i; expect[i] = __builtin_bswap64 (i); if (y) /* Avoid vectorisation. */ abort (); } i

[PING][AArch64][4.8,4.9] Wire up TARGET_SIMD and TARGET_FLOAT properly

2014-04-24 Thread Kyrill Tkachov
Hi all, I'd like to ping the two patches at: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00490.html and http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00315.html They fix a bug in aarch64 and I think they should go into the release branches. Thanks, Kyrill

Re: [AArch64/ARM 1/3] Add execution + assembler tests of AArch64 TRN Intrinsics

2014-04-24 Thread Marcus Shawcroft
On 28 March 2014 15:31, Alan Lawrence alan.lawre...@arm.com wrote: This adds DejaGNU tests of the existing AArch64 vuzp_* intrinsics, both checking the assembler output and the runtime results. Test bodies are in separate files ready to reuse for ARM in the third patch. Putting these in a

Re: [AArch64/ARM 2/3] Reimplement AArch64 TRN intrinsics with __builtin_shuffle

2014-04-24 Thread Marcus Shawcroft
On 28 March 2014 15:36, Alan Lawrence alan.lawre...@arm.com wrote: This patch replaces the temporary inline assembler for vtrn[q]_* in arm_neon.h with equivalent calls to __builtin_shuffle. These are matched by existing patterns in aarch64.c (aarch64_expand_vec_perm_const_1), outputting the

Re: [PATCH][AArch64] Wire up TARGET_SIMD and TARGET_FLOAT properly

2014-04-24 Thread Marcus Shawcroft
On 7 April 2014 14:46, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: 2014-04-04 Kyrylo Tkachov kyrylo.tkac...@arm.com * config/aarch64/aarch64.h (TARGET_CPU_CPP_BUILTINS): Check TARGET_SIMD rather than TARGET_GENERAL_REGS_ONLY. (TARGET_SIMD): Take AARCH64_ISA_SIMD

[PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
The GMP people complained that we advertise outdated versions in our install instructions. I tried to address that by not explicitely listing a good version but only mention the version that is the minimum requirement. I also added a reference to contrib/download_prerequesites as the

Re: [PATCH][AArch64][4.8] Wire up TARGET_SIMD and TARGET_FLOAT properly

2014-04-24 Thread Marcus Shawcroft
On 10 April 2014 12:05, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: Hi all, This is the 4.8 version of the patch posted at: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00315.html TARGET_CRYPTO was not defined in 4.8 therefore that hunk is removed. Ok for the 4.8 branch? Thanks, Kyrill

[PING][ARM] Handle simple SImode PLUS and MINUS operations in rtx costs

2014-04-24 Thread Kyrill Tkachov
Hi all, Pinging this: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01276.html Thanks, Kyrill

Re: [PATCH] Fix web/60933

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 10:15:31AM +0200, Richard Biener wrote: We probably should try to bump the versions used by that script to something more recent though (should we do that for the 4.9 branch even?). Any idea what to choose here? I'd say mpc 1.0.2 is fine, so is mpfr 3.1.2, but should

Re: [4.9.1 RFA] [tree-optimization/60902] Invalidate outputs of GIMPLE_ASMs when threading around loops

2014-04-24 Thread Richard Biener
On Wed, Apr 23, 2014 at 8:01 PM, Jeff Law l...@redhat.com wrote: The more aggressive threading across loop backedges requires invalidating equivalences that do not hold across all iterations of a loop. At first glance, invaliding at PHI nodes should be sufficient as any statement which

RE: [patch, testsuite] Fix fragile case nsdmi-union5

2014-04-24 Thread Joey Ye
-Original Message- From: Mike Stump [mailto:mikest...@comcast.net] Sent: Monday, April 21, 2014 11:39 PM To: Joey Ye Cc: gcc-patches@gcc.gnu.org Subject: Re: [patch, testsuite] Fix fragile case nsdmi-union5 On Apr 17, 2014, at 10:28 PM, Joey Ye joey...@arm.com wrote: Resulting

Re: [PATCH] Fix web/60933

2014-04-24 Thread Rainer Orth
Richard Biener rguent...@suse.de writes: The GMP people complained that we advertise outdated versions in our install instructions. I tried to address that by not explicitely listing a good version but only mention the version that is the minimum requirement. I also added a reference to

Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-24 Thread Richard Biener
On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law l...@redhat.com wrote: On 04/23/14 15:13, David Malcolm wrote: On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: On 04/21/14 10:56, David Malcolm wrote: This updates all of the gimple_bind_* accessors in gimple.h from taking a plain gimple to

[build] Fix gcc_cv_as_cfi_directive test for Solaris as

2014-04-24 Thread Rainer Orth
Recent versions of the Solaris/x86 assembler are gaining support for cfi directives. gcc/configure failed to detect this since it used a gas-only option for 64-bit code generation. This patch fixes it. Tested on a wide range of assembler/linker configurations on i386-pc-solaris2.1[01],

Re: GCC's -fsplit-stack disturbing Mach's vm_allocate

2014-04-24 Thread Svante Signell
On Fri, 2014-04-18 at 10:03 +0200, Samuel Thibault wrote: Samuel Thibault, le Thu 17 Apr 2014 00:03:45 +0200, a écrit : Thomas Schwinge, le Wed 09 Apr 2014 09:36:42 +0200, a écrit : Well, the first step is to verify that TARGET_THREAD_SPLIT_STACK_OFFSET and similar configury is correct

RE: [PATCH][2/3] Fix PR54733 Optimize endian independent load/store

2014-04-24 Thread Thomas Preud'homme
Bootstrapped on x86_64-linux-gnu with no testsuite regression. Also did a arm-none-eabi cross build with no regression after running testsuite via qemu Forgot to ask if it's ok for trunk. Same question for part 1 and 3. Best regards, Thomas

Re: [PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
On Thu, 24 Apr 2014, Rainer Orth wrote: Richard Biener rguent...@suse.de writes: The GMP people complained that we advertise outdated versions in our install instructions. I tried to address that by not explicitely listing a good version but only mention the version that is the

Re: [PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
On Thu, 24 Apr 2014, Jakub Jelinek wrote: On Thu, Apr 24, 2014 at 10:15:31AM +0200, Richard Biener wrote: We probably should try to bump the versions used by that script to something more recent though (should we do that for the 4.9 branch even?). Any idea what to choose here? I'd say

Re: [c++] typeinfo for target types

2014-04-24 Thread Kyrill Tkachov
On 23/04/14 21:35, Richard Henderson wrote: On 04/23/2014 12:43 PM, Marc Glisse wrote: Any c++ compilation aborts at That's surprising, the code I touched is only ever supposed to run while compiling one file in libsupc++, if I understand correctly. Ah, well, perhaps it's one of the first

Only redefine ASM_PREFERRED_EH_DATA_FORMAT if necessary on Solaris/x86

2014-04-24 Thread Rainer Orth
Currently, Solaris/x86 uses a private version of ASM_PREFERRED_EH_DATA_FORMAT since older versions of the Solaris assembler couldn't calculate the difference between labels in different sections. This restriction has been lifted in Solaris 10 patch 119961-07 from May 2010. Since the redefinition

Re: [PATCH] Fix web/60933

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 10:38:38AM +0200, Richard Biener wrote: Is there a reason why you have lowered the minimum versions (4.3.2 - 4.2.3, 2.4.2 - 2.4.0, 0.8.1 - 0.8.0)? As I say will not work I checked what we reject at configure time (for the oldest versions that work we'll complain

Re: [PATCH] Fix web/60933

2014-04-24 Thread Rainer Orth
Richard Biener rguent...@suse.de writes: I'd strongly advise against it: in the past we've had serious problems with versions newer than advertised in install.texi on some platforms. Until we have positive evidence that specific newer versions work on a wide range of platforms, we shouldn't

Re: [PATCH] Fix web/60933

2014-04-24 Thread Eric Botcazou
Meanwhile is does the patch look ok? No, the current wording is just fine and yours doesn't bring anything (even the contrary, since you're listing known problematic versions). This will also break http://gcc.gnu.org/install/specific.html#sparc-x-x I don't see why we should special case GMP,

Re: [PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
On Thu, 24 Apr 2014, Eric Botcazou wrote: Meanwhile is does the patch look ok? No, the current wording is just fine and yours doesn't bring anything (even the contrary, since you're listing known problematic versions). This will also break

Re: [PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
On Thu, 24 Apr 2014, Richard Biener wrote: On Thu, 24 Apr 2014, Eric Botcazou wrote: Meanwhile is does the patch look ok? No, the current wording is just fine and yours doesn't bring anything (even the contrary, since you're listing known problematic versions). This will also

Re: [AArch64/ARM 1/3] Add execution + assembler tests of AArch64 REV Neon Intrinsics

2014-04-24 Thread Marcus Shawcroft
On 23 April 2014 20:17, Alan Lawrence alan.lawre...@arm.com wrote: This adds DejaGNU tests of the existing AArch64 vrev_* intrinsics, both checking the assembler output and the runtime results. Test bodies are in separate files ready to reuse for ARM in the third patch. All tests passing on

Re: [AArch64/ARM 2/3] Recognize shuffle patterns for REV instructions on AARch64, rewrite intrinsics.

2014-04-24 Thread Marcus Shawcroft
On 23 April 2014 20:44, Alan Lawrence alan.lawre...@arm.com wrote: This patch (borrowing heavily from the ARM backend) makes aarch64_expand_vec_perm_const output REV instructions when appropriate, and then implements the vrev_XXX intrinsics in terms of __builtin_shuffle (which now produces

Re: [AArch64/ARM 1/3] Add execution + assembler tests of AArch64 EXT intrinsics

2014-04-24 Thread Marcus Shawcroft
On 23 April 2014 21:01, Alan Lawrence alan.lawre...@arm.com wrote: This adds DejaGNU tests of the existing AArch64 vext* intrinsics, both checking the assembler output and the runtime results. Test bodies are in separate files ready to reuse for ARM in the third patch. All passing on

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Dimitris Papavasiliou
Ping! Does anybody know the current record of longest ping? I'd like to at least break it before giving up. On 04/03/2014 06:32 PM, Dimitris Papavasiliou wrote: Still pinging. On 03/28/2014 11:58 AM, Dimitris Papavasiliou wrote: Ping! On 03/23/2014 03:20 AM, Dimitris Papavasiliou wrote:

Re: [c++] typeinfo for target types

2014-04-24 Thread Ramana Radhakrishnan
On Wed, Apr 23, 2014 at 8:43 PM, Marc Glisse marc.gli...@inria.fr wrote: On Wed, 23 Apr 2014, Richard Henderson wrote: On 04/13/2014 01:41 AM, Marc Glisse wrote: Hello, this patch generates typeinfo for target types. On x86_64, it adds these 6 lines to nm -C libsupc++.a. A follow-up patch

[PATCH] Update libstdc++ baseline symbols for ia64

2014-04-24 Thread Andreas Schwab
Tested on ia64-suse-linux and installed as obvious. Andreas. * config/abi/post/ia64-linux-gnu/baseline_symbols.txt: Update for new CXXABI_1.3.9 symbols. diff --git a/libstdc++-v3/config/abi/post/ia64-linux-gnu/baseline_symbols.txt

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Jonathan Wakely
On 24 April 2014 04:47, Tim Shen wrote: Booted and tested with -m32 and -m64. I should give an explanation: When traversing a graph in _M_clone(), it should stop at a node with id _M_end. However, if _M_end has other outgoing edge (_M_alt), the edge should be concerned too. So this patch

[PATCH] Fix PR60912

2014-04-24 Thread Richard Biener
The following fixes PR60912 - a bug with IPA PTA computing the use/clobber sets for direct calls where it optimized walking using the cgraph nodes caller list. But that can be incomplete in the face of aliases. Luckily that optimization is no longer necessary because we now cache the outcome of

[PATCH] Fix PR60911

2014-04-24 Thread Richard Biener
Simple IPA passes are supposed to see function bodies with IPA transforms applied - this is what the code in execute_one_pass tries to ensure. But that doesn't work anymore with on-demand function-body loading. The following addresses this in the least intrusive way - inlining do_per_function

Re: [PATCH 00/89] Compile-time gimple-checking

2014-04-24 Thread Richard Sandiford
Jeff Law l...@redhat.com writes: On 04/22/14 02:03, Richard Sandiford wrote: First of all, thanks a lot for doing this. Maybe one day we'll have the same in rtl :-) Funny you should mention that. I blocked off a hunk of time for David to investigate doing some work on that this year.

Re: [PATCH] Fix PR60896

2014-04-24 Thread Richard Biener
On Wed, 23 Apr 2014, Cong Hou wrote: See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60896 for bug report. The cause of PR60896 is that those statements in PATTERN_DEF_SEQ in pre-recognized widen-mult pattern are not forwarded to later recognized dot-product pattern. Another issue is

Re: [PATCH, AArch64] Enable shuffle on big-endian and turn on the testsuite

2014-04-24 Thread Marcus Shawcroft
gcc/ChangeLog: 2014-04-11 Alan Lawrence alan.lawre...@arm.com * config/aarch64/aarch64.c (aarch64_evpc_tbl): enable for bigendian. gcc/testsuite/ChangeLog: 2014-04-11 Alan Lawrence alan.lawre...@arm.com * lib/target-supports.exp (check_effective_target_vect_perm):

Re: [VRP][PATCH] Improve value range for loop index

2014-04-24 Thread Richard Biener
On Wed, Apr 9, 2014 at 10:07 PM, Kugan kugan.vivekanandara...@linaro.org wrote: Value range propagation simplifies convergence in vrp_visit_phi_node by setting minimum to TYPE_MIN when the computed minimum is smaller than the previous minimum. This can however result in pessimistic value

Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-24 Thread Andrew MacLeod
On 04/24/2014 04:33 AM, Richard Biener wrote: On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law l...@redhat.com wrote: On 04/23/14 15:13, David Malcolm wrote: On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: On 04/21/14 10:56, David Malcolm wrote: This updates all of the gimple_bind_* accessors

Re: [PATCH 00/89] Compile-time gimple-checking

2014-04-24 Thread Andrew MacLeod
On 04/23/2014 10:42 AM, Michael Matz wrote: Hi, On Mon, 21 Apr 2014, David Malcolm wrote: case GIMPLE_SWITCH: dump_gimple_switch (buffer, gs-as_a_gimple_switch (), spc, flags); break; where the -as_a_gimple_switch is a no-op cast from gimple to the more concrete

Re: [c++] typeinfo for target types

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Ramana Radhakrishnan wrote: On Wed, Apr 23, 2014 at 8:43 PM, Marc Glisse marc.gli...@inria.fr wrote: On Wed, 23 Apr 2014, Richard Henderson wrote: On 04/13/2014 01:41 AM, Marc Glisse wrote: Hello, this patch generates typeinfo for target types. On x86_64, it adds

Re: [PATCH 02/89] Introduce gimple_switch and use it in various places

2014-04-24 Thread David Malcolm
On Wed, 2014-04-23 at 13:58 -0600, Jeff Law wrote: On 04/21/14 10:56, David Malcolm wrote: [...] So, generally I like it. It looks pretty much like what I'd expect from this kind of work. So it sounds like Richi really prefers the explicit casting rather than member functions. It seems

Re: [c++] typeinfo for target types

2014-04-24 Thread Ramana Radhakrishnan
Well some of these scalar types are not really user visible which is where I believe the problem is coming from and prima-facie I don't think we should be inventing mangling for some of these internal types. If the types are not user-visible, it is not clear to me why they need to be

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Ryan Mansfield
On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch breaks building arm-eabi with a 32bit host gcc. e.g ../../gcc/config/arm/aarch-common.c

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Kyrill Tkachov
On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch breaks building arm-eabi with a 32bit host gcc. e.g

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Ramana Radhakrishnan
On Thu, Apr 24, 2014 at 2:54 PM, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch

Re: [c++] typeinfo for target types

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Ramana Radhakrishnan wrote: Well some of these scalar types are not really user visible which is where I believe the problem is coming from and prima-facie I don't think we should be inventing mangling for some of these internal types. If the types are not user-visible,

Re: [PATCH, AArch64] Enable shuffle on big-endian and turn on the testsuite

2014-04-24 Thread Tejas Belagod
Marcus Shawcroft wrote: gcc/ChangeLog: 2014-04-11 Alan Lawrence alan.lawre...@arm.com * config/aarch64/aarch64.c (aarch64_evpc_tbl): enable for bigendian. gcc/testsuite/ChangeLog: 2014-04-11 Alan Lawrence alan.lawre...@arm.com * lib/target-supports.exp

[C PATCH] Improve error on attrs after declarator in a fndef (PR c/60915)

2014-04-24 Thread Marek Polacek
This PR is about not very clear error message when one tries to add attributes *after* the declarator in a function definition. cc1plus already handles this well, so I used the same message. Regtested/bootstrapped on x86_64-linux, ok for trunk? 2014-04-24 Marek Polacek pola...@redhat.com

[wide-int] Fix signed min / -1 quotient

2014-04-24 Thread Richard Sandiford
For signed min / -1 we set the overflow flag (good) but also returned a quotient of 0. It should be 0x80...0 instead. Since that's also the value of the original dividend, we can just copy the representation over. The value for division by 0 is probably pretty arbitrary. double-int.c seems to

Re: [PATCH] Fix PR60911

2014-04-24 Thread Jan Hubicka
Simple IPA passes are supposed to see function bodies with IPA transforms applied - this is what the code in execute_one_pass tries to ensure. But that doesn't work anymore with on-demand function-body loading. The following addresses this in the least intrusive way - inlining

Re: [wide-int] Fix signed min / -1 quotient

2014-04-24 Thread Kenneth Zadeck
This is fine with me. kenny On 04/24/2014 10:34 AM, Richard Sandiford wrote: For signed min / -1 we set the overflow flag (good) but also returned a quotient of 0. It should be 0x80...0 instead. Since that's also the value of the original dividend, we can just copy the representation over.

Re: [PATCH 00/89] Compile-time gimple-checking

2014-04-24 Thread Michael Matz
Hi, On Thu, 24 Apr 2014, Andrew MacLeod wrote: Well, we ought to settle on one... either use the is_a, as_a, and dyn_cast paradigm as they exist today, or we use the cast_as_method approach everywhere. I'm not fond of each potential project having a different approach... I'd like to see

Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-24 Thread David Malcolm
On Thu, 2014-04-24 at 09:09 -0400, Andrew MacLeod wrote: On 04/24/2014 04:33 AM, Richard Biener wrote: On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law l...@redhat.com wrote: On 04/23/14 15:13, David Malcolm wrote: On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: On 04/21/14 10:56, David

Re: Add clobber_reg

2014-04-24 Thread Eric Botcazou
Richard Sandiford mentioned here ( http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00870.html ): ... Although we really should have a utility function like use_reg, but for clobbers, so that the above would become: clobber_reg (CALL_INSN_FUNCTION_USAGE (insn), gen_rtx_REG (word_mode,

Re: Add post_expand_call_insn hook

2014-04-24 Thread Eric Botcazou
The hook is called right after expansion of calls, and allows a target to do additional processing, such as f.i. adding clobbers to CALL_INSN_FUNCTION_USAGE. Instead of using the hook, we could add code to the preparation statements operand of the different call expands, but that requires

Re: [c++] typeinfo for target types

2014-04-24 Thread Tejas Belagod
Marc Glisse wrote: On Thu, 24 Apr 2014, Ramana Radhakrishnan wrote: On Wed, Apr 23, 2014 at 8:43 PM, Marc Glisse marc.gli...@inria.fr wrote: On Wed, 23 Apr 2014, Richard Henderson wrote: On 04/13/2014 01:41 AM, Marc Glisse wrote: Hello, this patch generates typeinfo for target types. On

Re: [4.9.1 RFA] [tree-optimization/60902] Invalidate outputs of GIMPLE_ASMs when threading around loops

2014-04-24 Thread Jeff Law
On 04/24/14 02:22, Richard Biener wrote: + + if (backedge_seen) + FOR_EACH_SSA_TREE_OPERAND (op, stmt, iter, SSA_OP_ALL_DEFS) You only need SSA_OP_DEF here, no need to process virtual operands. I went back and forth on this. I couldn't come up with a case where we'd do the

Re: [Patch] Fix a typo in Chinese msg

2014-04-24 Thread Jeff Law
On 04/24/14 01:23, Jincheng Miao wrote: There is a minor typo in zh_CN.po, should change '-pic' to '-fpic'. Best wishes, Jincheng Miao Thanks. Applied to the trunk. jeff

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Tim Shen
On Thu, Apr 24, 2014 at 6:56 AM, Jonathan Wakely jwakely@gmail.com wrote: Unless I'm doing something wrong the new tests you added already give the right results, do you have a testcase that fails with the current code? This testcase fails before the patch. Sorry for that. -- Regards,

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Mike Stump
On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou dpapa...@gmail.com wrote: This is a patch regarding a couple of Objective-C related dialect options and warning switches. Ok. Committed revision 209753. If you could, please add documentation and a test case.

Re: Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-24 Thread Michael Matz
Hi, On Thu, 24 Apr 2014, David Malcolm wrote: Implicit naming === Several people have suggested that the gimple_ prefix is redundant. Not generally though (for instance I find it redundant in the cast-method names, but _not_ in the global types). Andrew MacLeod suggested in:

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Kyrill Tkachov
On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch breaks building arm-eabi with a 32bit host gcc. Hi Ryan, Does this patch fix it

[PATCH] Fix PR60930

2014-04-24 Thread Bill Schmidt
Hi, PR60930 exposes an SLSR problem with a fold. When multiplying two constants to create a new stride, the result must fit in the stride type for the computation or the fold is invalid. Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no regressions. The same patch applies

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Jonathan Wakely
On 24/04/14 11:49 -0400, Tim Shen wrote: This testcase fails before the patch. Sorry for that. Great, thanks - OK for trunk. Assuming no problems on the trunk we might want to backport it for 4.9.1 in a few weeks.

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Ryan Mansfield
On 14-04-24 12:12 PM, Kyrill Tkachov wrote: On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch breaks building arm-eabi with a 32bit

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Kyrill Tkachov
On 24/04/14 17:46, Ryan Mansfield wrote: On 14-04-24 12:12 PM, Kyrill Tkachov wrote: On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This

[PATCH] Step down as a gengtype reviewer

2014-04-24 Thread Laurynas Biveinis
Even though gengtype patches needing review are quite rare, I am unable to review quickly enough those few that do come. Thus stepping down, the patch below is committed. Index: ChangeLog === --- ChangeLog (revision 209731) +++

[Patch] Fix crtstuff.c compilation with mingw build.

2014-04-24 Thread Steve Ellcey
I sent an earlier patch to change how GCC configure was setting default values of caddr_t and ssize_t. That patch fixed a build problem I had when building GCC for Windows using the mingw tools but only because my patch was wrong. Here is a new patch to fix the problem. The problem was that

Re: version typeinfo for 128bit types

2014-04-24 Thread Rainer Orth
Marc Glisse marc.gli...@inria.fr writes: this is a follow-up for this patch: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00618.html once committed, g++ will generate typeinfo for __float128, and it needs versioning. While there, I noticed that __int128 has typeinfo but not typeinfo name,

Re: [Patch] Fix obsolete autoconf macros in configure.ac

2014-04-24 Thread Steve Ellcey
On Thu, 2014-04-24 at 10:23 +0200, Richard Biener wrote: +AC_CHECK_TYPES([ssize_t]) +AC_CHECK_TYPES([caddr_t]) But I am not sure what header file this code would go in. In system.h. Steve Ellcey FYI: I ran into problems defining ssize_t and caddr_t in system.h because it was

RE: [PATCH, ARM] Suppress Redundant Flag Setting for Cortex-A15

2014-04-24 Thread Ian Bolton
Hi, On 28 January 2014 13:10, Ramana Radhakrishnan ramana@googlemail.com wrote: On Fri, Jan 24, 2014 at 5:16 PM, Ian Bolton ian.bol...@arm.com wrote: Hi there! An existing optimisation for Thumb-2 converts t32 encodings to t16 encodings to reduce codesize, at the expense of

[PATCH] Detect a pack-unpack pattern in GCC vectorizer and optimize it.

2014-04-24 Thread Cong Hou
Given the following loop: int a[N]; short b[N*2]; for (int i = 0; i N; ++i) a[i] = b[i*2]; After being vectorized, the access to b[i*2] will be compiled into several packing statements, while the type promotion from short to int will be compiled into several unpacking statements. With this

Re: [Patch] Fix crtstuff.c compilation with mingw build.

2014-04-24 Thread Rainer Orth
Steve Ellcey sell...@mips.com writes: diff --git a/libgcc/crtstuff.c b/libgcc/crtstuff.c index 12bed4b..d09455f 100644 --- a/libgcc/crtstuff.c +++ b/libgcc/crtstuff.c @@ -54,6 +54,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see #include auto-host.h #undef

Re: version typeinfo for 128bit types

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Rainer Orth wrote: Marc Glisse marc.gli...@inria.fr writes: this is a follow-up for this patch: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00618.html once committed, g++ will generate typeinfo for __float128, and it needs versioning. While there, I noticed that

Re: [C PATCH] Improve error on attrs after declarator in a fndef (PR c/60915)

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Marek Polacek wrote: This PR is about not very clear error message when one tries to add attributes *after* the declarator in a function definition. cc1plus already handles this well, so I used the same message. I thought you had an earlier version of the patch where,

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Tim Shen
On Thu, Apr 24, 2014 at 12:38 PM, Jonathan Wakely jwak...@redhat.com wrote: Great, thanks - OK for trunk. Assuming no problems on the trunk we might want to backport it for 4.9.1 in a few weeks. Committed. Thanks. -- Regards, Tim Shen

Re: [PATCH], Add DFP, extended divide, BCD builtins to PowerPC

2014-04-24 Thread David Edelsohn
On Tue, Apr 22, 2014 at 4:21 PM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: This patch adds the last set of instructions in the ISA 2.05 (power6), ISA 2.06 (power7), and ISA 2.07 (power8) specifications as builtins. As far as I know, this completes the set of user space instructions

Re: wide-int, ada

2014-04-24 Thread Mike Stump
On Nov 25, 2013, at 12:46 AM, Eric Botcazou ebotca...@adacore.com wrote: Richi has asked the we break the wide-int patch so that the individual port and front end maintainers can review their parts without have to go through the entire patch.This patch covers the ada front-end. I don't

Re: [C PATCH] Improve error on attrs after declarator in a fndef (PR c/60915)

2014-04-24 Thread Marek Polacek
On Thu, Apr 24, 2014 at 08:25:52PM +0200, Marc Glisse wrote: On Thu, 24 Apr 2014, Marek Polacek wrote: This PR is about not very clear error message when one tries to add attributes *after* the declarator in a function definition. cc1plus already handles this well, so I used the same

Re: wide-int, cfg

2014-04-24 Thread Mike Stump
On Nov 25, 2013, at 2:57 AM, Richard Biener richard.guent...@gmail.com wrote: On Sat, Nov 23, 2013 at 8:21 PM, Mike Stump mikest...@comcast.net wrote: Richi has asked the we break the wide-int patch so that the individual port and front end maintainers can review their parts without have to go

Re: [Patch] Fix a typo in Chinese msg

2014-04-24 Thread Tobias Burnus
Jeff Law wrote: On 04/24/14 01:23, Jincheng Miao wrote: There is a minor typo in zh_CN.po, should change '-pic' to '-fpic'. Thanks for the patch Thanks. Applied to the trunk. Jeff, are you sure that this will not be overridden? I think the translations are always synced from

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 01:12:02PM +0300, Dimitris Papavasiliou wrote: Ping! Does anybody know the current record of longest ping? I'd like to at least break it before giving up. How has this been tested? I'm seeing: +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line

Re: [PATCH] Enable multiple duplicated blocks on threading path

2014-04-24 Thread H.J. Lu
On Wed, Dec 25, 2013 at 6:23 AM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Nov 21, 2013 at 7:59 AM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Nov 19, 2013 at 9:11 PM, Jeff Law l...@redhat.com wrote: On 11/19/13 19:33, David Malcolm wrote: FWIW, it looks like you attached the whitespace

Re: [PATCH] PR60822 (m68k, missing earlyclobber in extendplussidi)

2014-04-24 Thread Jeff Law
On 04/16/14 18:20, seg...@kernel.crashing.org wrote: On Wed, Apr 16, 2014 at 02:45:28PM -0600, Jeff Law wrote: Isn't the problem that operands 1 is a MEM which use the same register as operands 3 in the memory address? Yes, exactly. ISTM either removing the memory constraint entirely, or

Re: [PATCH GCC]Fix pr60363 by adding backtraced value of phi arg along jump threading path

2014-04-24 Thread Jeff Law
On 04/17/14 04:07, Bin.Cheng wrote: On Thu, Apr 17, 2014 at 1:30 PM, Jeff Law l...@redhat.com wrote: On 03/18/14 04:13, bin.cheng wrote: Hi, After control flow graph change made by http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01492.html, case gcc.dg/tree-ssa/ssa-dom-thread-4.c is broken on

Re: [build] PR 43538: Don't overwrite CXXFLAGS_FOR_TARGET in config/mt-gnu

2014-04-24 Thread Jeff Law
On 04/18/14 02:28, Marc Glisse wrote: Ping http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01480.html On Thu, 23 Jan 2014, Marc Glisse wrote: Hello, although setting CFLAGS_FOR_TARGET before compiling gcc works fine, CXXFLAGS_FOR_TARGET is ignored. I don't see any good reason for that. I

Re: Inline functions tweeks 1/n

2014-04-24 Thread Jeff Law
On 01/02/14 10:21, Jan Hubicka wrote: Hi, While looking for -Winline messages I noticed that sched-int.h has self recursive function declared inline. The recursion is tail recursion but we fail to recognize it as such. The problem ist hat there is a local variable link whose address is passed

Re: Inline functions tweeks 2/n: bring some heavy functions offline

2014-04-24 Thread Jeff Law
On 01/02/14 10:30, Jan Hubicka wrote: Hi, those functions are not inlined since they are too large anyway. I do not think it is disaster. get_attr_length_1 takes a callback that may make it more interesting inlining candidate than others, perhaps. Bootstrapped/regtested x86_64-linux, OK? Honza

Re: [C PATCH] Warn about variadic main (PR c/60156)

2014-04-24 Thread Jeff Law
On 02/12/14 02:51, Marek Polacek wrote: I figured it might be a good idea to warn about variadic main decl (well, not in freestanding environment where it's implementation-defined). Regtested/bootstrapped on x86_64-linux, ok for 5.0? 2014-02-12 Marek Polacek pola...@redhat.com PR

[committed] Fix some linear/lastprivate omp issues

2014-04-24 Thread Jakub Jelinek
Hi! As the testcase shows, this patch fixes some issues with lastprivate/linear iteration vars of OpenMP loops (for/simd). One issue was that we were disallowing explicit linear or lastprivate clause for the iteration var, but in the final 4.0 standard while it is predetermined linear (collapse

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-04-24 Thread Jeff Law
On 02/24/14 12:28, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. Looks good now, but I can't approve it. Thanks, Applied to the trunk.

[committed] Fix atomic seq_cst parsing

2014-04-24 Thread Jakub Jelinek
Hi! I've apparently missed a paragraph that made into OpenMP 4.0 on page 131: In all atomic construct forms, the seq_cst clause and the clause that denotes the type of the atomic construct can appear in any order. In addition, an optional comma may be used to separate the clauses. While the

[wide-int, committed] Obvious s390 build fix

2014-04-24 Thread Richard Sandiford
I committed this patch as obvious to fix the s390 build. Thanks, Richard Index: gcc/config/s390/s390.c === --- gcc/config/s390/s390.c 2014-04-24 22:42:21.799411496 +0100 +++ gcc/config/s390/s390.c 2014-04-24

  1   2   >