RE: [Patch, microblaze]: Add optimized lshrsi3

2014-07-08 Thread Nagaraju Mekala
Hi Michael, -Original Message- From: Michael Eager [mailto:ea...@eagerm.com] Sent: Tuesday, July 01, 2014 11:12 AM To: David Holsgrove; gcc-patches@gcc.gnu.org Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala; Ajit Kumar Agarwal Subject: Re: [Patch,

[PATCH] Fix VRP handling of __builtin_ffs* (PR tree-optimization/61725)

2014-07-08 Thread Jakub Jelinek
Hi! When writing this code, I've been assuming __builtin_ffs* argument is unsigned, which is the case of popcount also handled there, and many other builtins (clz, ctz, ...), except that clrsb has signed argument. But in reality for some reason ffs has signed argument and some time ago Marek has

Re: [PATCH ARM] Improve ARM memset inlining

2014-07-08 Thread Bin.Cheng
On Fri, Jul 4, 2014 at 1:17 PM, Bin Cheng bin.ch...@arm.com wrote: Hi Ramana, This is the rebased patch, there is no conflict against latest trunk. I am still doing some tests. Is it OK if tests are fine? Also, it depends on patch at

Re: Optimize type streaming

2014-07-08 Thread Jan Hubicka
We have reverted the patch for now but I note that at least the piece below is a step backward from doing the compare in the on-disk format. Why it is step backward from compare in the on-dist format? All the information is still streamed, just not duplicated. Since we explicitly stream

Re: Proper fix for PR58477

2014-07-08 Thread Richard Biener
On Tue, 8 Jul 2014, Jan Hubicka wrote: Hi, I had to revert change to ipa-prop.c that made stmt_may_be_vtbl_ptr_store to know that clobbers can not be such stores. This triggered byg in detect_type_change_from_memory_writes. This function does two things. First is that it tries to prove

Re: [RFC] Add a .gitattributes file for use with git-merge-changelog

2014-07-08 Thread Pedro Alves
Hi Samuel, This seems like a good idea to me. On 07/08/2014 02:35 AM, Samuel Bronson wrote: Ping? If nobody has anything else to say, I'm going to assume that such a change is unobjectionable, and should not be listed in the ChangeLog. When in doubt, look for precedence. grep will show

Re: [PATCH] Fix VRP handling of __builtin_ffs* (PR tree-optimization/61725)

2014-07-08 Thread Richard Biener
On Tue, 8 Jul 2014, Jakub Jelinek wrote: Hi! When writing this code, I've been assuming __builtin_ffs* argument is unsigned, which is the case of popcount also handled there, and many other builtins (clz, ctz, ...), except that clrsb has signed argument. But in reality for some reason ffs

Re: [PATCH ARM] Improve ARM memset inlining

2014-07-08 Thread Ramana Radhakrishnan
Hi Ramana, This is the rebased patch, there is no conflict against latest trunk. I am still doing some tests. Is it OK if tests are fine? Also, it depends on patch at https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01923.html, I will update that patch two. Thanks, bin Index:

[PATCH] Remove copy propagation restrictions on loops

2014-07-08 Thread Richard Biener
As promised and analyzed in the DOM thread the following patch removes restriction on copy propagating through PHIs on loop exits (when we don't have to preserve loop-closed SSA form). Fallout in out-of-SSA coalescing has been dealt with there. Bootstrapped and tested on

Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

2014-07-08 Thread Tobias Burnus
Cesar Philippidis wrote: Thomas, is this OK for gomp-4_0-branch? ... * gcc/fortran/scanner.c (gfc_next_char_literal): Fix the scan for *$acc. This changes looks good to me. * parse.c (next_fixed): Don't handle openmp pragmas when scanning for openacc pragmas.

[PATCH 4.9][ARM] Backport r211369 PR/61062 Fix arm_neon.h ZIP/UZP/TRN for Bigendian

2014-07-08 Thread Alan Lawrence
No regressions on arm-none-eabi or armeb-none-eabi; also FAIL-PASS on local copies of the execution-result tests in gcc.target/arm/simd tests (taken from mainline, these are not present in 4.9). gcc/ChangeLog: PR target/61062 Backport r211369 from mainline. 2014-06-09

Re: [GSoC][match-and-simplify] add few test-cases

2014-07-08 Thread Richard Biener
On Sun, Jul 6, 2014 at 9:45 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Hi, This patch adds few test-cases for gimple match-and-simplfiy and removes match-2.c [gcc/testsuite/gcc.dg/tree-ssa] * match-2.c: Remove. * match-plusminus.c: New test-case. * match-bitwise.c:

Re: [PATCH] PR bootstrap/61679 playcate old gcc

2014-07-08 Thread Richard Biener
On Tue, Jul 8, 2014 at 4:21 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, I'll admitt I'm not actually sure if the spec requires this, or if gcc 4.5 was too picky, but this fixes the build with gcc 4.5, and it doesn't really hurt anything. bootstrapped

Re: [PATCH] convert some hash_table to hash_map

2014-07-08 Thread Richard Biener
On Tue, Jul 8, 2014 at 5:01 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, just $subject bootstrapped + regtested on x86_64-unknown-linux-gnu, ok? Ok. Thanks, Richard. Trev gcc/ * graphite-htab.h: Use hash_map instead of hash_table.

Re: Fix representation of gcov_info_type

2014-07-08 Thread Richard Biener
On Tue, Jul 8, 2014 at 2:25 AM, Jan Hubicka hubi...@ucw.cz wrote: Index: stor-layout.c === --- stor-layout.c (revision 212098) +++ stor-layout.c (working copy) @@ -2065,7 +2065,7 @@ void finish_builtin_struct

Re: [PATCH] remove useless unused attributes in i386 code

2014-07-08 Thread Richard Biener
On Mon, Jul 7, 2014 at 9:47 PM, Trevor Saunders tsaund...@mozilla.com wrote: On Mon, Jul 07, 2014 at 09:28:55PM +0200, Richard Biener wrote: On July 7, 2014 9:06:17 PM CEST, Trevor Saunders tsaund...@mozilla.com wrote: On Mon, Jul 07, 2014 at 11:46:27AM +0200, Richard Biener wrote: On Mon,

Re: [i386] Replace builtins with vector extensions

2014-07-08 Thread Kirill Yukhin
Hello Marc. On 04 Jul 21:11, Marc Glisse wrote: On Thu, 3 Jul 2014, Kirill Yukhin wrote: like combining 2 shuffles unless the result is the identity. And expanding shuffles that can be done in a single instruction works well. But I am happy not doing them yet. To be very specific, could you

Re: [i386] Replace builtins with vector extensions

2014-07-08 Thread Jakub Jelinek
On Tue, Jul 08, 2014 at 03:14:04PM +0400, Kirill Yukhin wrote: On the over hand, updated in such a way intrinsic may actually generate different instruction then intended (e.g. FMA case). It is the same with scalars, we have -ffp-contract for that. Agreed. I don't think we actually

[PATCH 4.9][AArch64] Backport 211892: PR/60825 Make float64x1_t in arm_neon.h a proper vector type

2014-07-08 Thread Alan Lawrence
This corrects name-mangling of float64x1_t and makes it a distinct type from float64_t, as per ACLE - the error mentioned in the Caveats section at https://gcc.gnu.org/gcc-4.9/changes.html. (Only) Changes from the original patch are to remove references to __builtin_aarch64_im_lane_boundsi

Re: [PATCH 4.9][ARM] Backport r211369 PR/61062 Fix arm_neon.h ZIP/UZP/TRN for Bigendian

2014-07-08 Thread Ramana Radhakrishnan
On Tue, Jul 8, 2014 at 10:59 AM, Alan Lawrence alan.lawre...@arm.com wrote: No regressions on arm-none-eabi or armeb-none-eabi; also FAIL-PASS on local copies of the execution-result tests in gcc.target/arm/simd tests (taken from mainline, these are not present in 4.9). Ok unless an RM

Re: [PATCH 4.9 ARM] Backport r210219: Neon Intrinsics TLC - remove ML

2014-07-08 Thread Ramana Radhakrishnan
On Mon, Jun 23, 2014 at 11:05 AM, Alan Lawrence alan.lawre...@arm.com wrote: As for 4.8, I'm intending to backport the ZIP/UZP/TRN fix for ARM big-endian in r211369 of mainline. That patches arm_neon.h, so again we need to remove the OCAML code by which that file is autogenerated...ok? Ok

Re: [PATCH][ARM/AArch64 Testsuite] Fix vext[us]64_1.c test on ARM by unsharing test body

2014-07-08 Thread Ramana Radhakrishnan
On Thu, Jul 3, 2014 at 4:08 PM, Alan Lawrence alan.lawre...@arm.com wrote: Moving into own thread from https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01895.html This fixes the compilation failures of gcc.target/arm/simd/vexts64_1.c and gcc.target/arm/simd/vextu64_1.c that I introduced in r by

Re: [PATCH 4.9][AArch64] Backport 211892: PR/60825 Make float64x1_t in arm_neon.h a proper vector type

2014-07-08 Thread Jakub Jelinek
On Tue, Jul 08, 2014 at 12:28:54PM +0100, Alan Lawrence wrote: This corrects name-mangling of float64x1_t and makes it a distinct type from float64_t, as per ACLE - the error mentioned in the Caveats section at https://gcc.gnu.org/gcc-4.9/changes.html. (Only) Changes from the original patch

Re: [GOMP4, RFC] OpenMP4 offload support for Intel PHI targets.

2014-07-08 Thread Kirill Yukhin
Hello, We recently checked into gomp4-offload branch fix allowing bootstrap to pass as well as fix for disabling multilib for liboffloadmic (64-bit only). -- Thanks, K

Re: [PATCH 4.9][AArch64] Backport 211892: PR/60825 Make float64x1_t in arm_neon.h a proper vector type

2014-07-08 Thread Marcus Shawcroft
On 8 July 2014 12:39, Jakub Jelinek ja...@redhat.com wrote: On Tue, Jul 08, 2014 at 12:28:54PM +0100, Alan Lawrence wrote: This corrects name-mangling of float64x1_t and makes it a distinct type from float64_t, as per ACLE - the error mentioned in the Caveats section at

Re: [PATCH][AArch64] Implement vfma_f64, vmla_f64, vfms_f64, vmls_f64 intrinsics

2014-07-08 Thread Kyrill Tkachov
Ping^2 https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02399.html Kyrill On 20/06/14 15:17, Kyrill Tkachov wrote: Hi all, Now that Alan fixed the float64x1_t machinery, this patch implements some low-hanging intrinsics in arm_neon.h. Tested aarch64-none-elf and bootstrapped on aarch64-linux.

Re: [PATCH 4.9][AArch64] Backport 211892: PR/60825 Make float64x1_t in arm_neon.h a proper vector type

2014-07-08 Thread Jakub Jelinek
On Tue, Jul 08, 2014 at 01:08:27PM +0100, Marcus Shawcroft wrote: float64_t, as per ACLE - the error mentioned in the Caveats section at https://gcc.gnu.org/gcc-4.9/changes.html. ... along with a statement that this would be fixed Clearly the ABI change between 4.9.0 and 4.9.1 is not

Re: [GSoC] generation of Gimple loops with empty bodies

2014-07-08 Thread Roman Gareev
Surprising. Is the symbol defined in libisl.so? You could use objdump to check? If I am not mistaken, objdump shows that libisl.so contains it. objdump -d libisl.so.10.2.2 | grep isl_ast_expr_get_val 00060380 isl_ast_expr_get_val: 60383: 74 4b je 603d0

[RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294)

2014-07-08 Thread Jakub Jelinek
Hi! This is an attempt to move the warning about transposed memset arguments from the glibc headers to gcc FEs. The problem with the warning in glibc is that it uses __builtin_constant_p and e.g. jump threading very often makes the warning trigger even on code where it is very unlikely a user

Re: [GSoC] Addition of __isl_give to declarations

2014-07-08 Thread Roman Gareev
The ChangeLog should be per-function. Otherwise LGTM. I've fixed this. -- Cheers, Roman Gareev 2014-07-04 Roman Gareev gareevro...@gmail.com gcc/ * graphite-isl-ast-to-gimple.c (generate_isl_context): Add __isl_give to the

Re: [GSoC] Addition of __isl_give to declarations

2014-07-08 Thread Tobias Grosser
On 08/07/2014 14:52, Roman Gareev wrote: The ChangeLog should be per-function. Otherwise LGTM. I've fixed this. OK, LGTM then. Tobias

Re: [PATCH][ARM] Cortex-A5 rtx costs table

2014-07-08 Thread Richard Earnshaw
On 07/07/14 12:01, Kyrill Tkachov wrote: Hi all, This patch adds the rtx costs table for the Cortex-A5 core. Tested arm-none-eabi and looked at the codegen for various codebases to make sure there's no regression in code quality. Ok for trunk? Thanks, Kyrill 2014-07-07 Kyrylo

Re: [GSoC] generation of Gimple loops with empty bodies

2014-07-08 Thread Tobias Grosser
On 08/07/2014 14:47, Roman Gareev wrote: Surprising. Is the symbol defined in libisl.so? You could use objdump to check? If I am not mistaken, objdump shows that libisl.so contains it. objdump -d libisl.so.10.2.2 | grep isl_ast_expr_get_val 00060380 isl_ast_expr_get_val: 60383: 74

[patch] Some small libstdc++ fixes

2014-07-08 Thread Jonathan Wakely
A fix and some minor tweaks. Tested x86_64-linux, committed to trunk. commit 7f2475d59cc4ca4729341021e8b418ca77f7ccb2 Author: Jonathan Wakely jwak...@redhat.com Date: Tue Jul 8 13:33:02 2014 +0100 * include/bits/allocated_ptr.h (__allocated_ptr::operator=): Add missing return.

Re: [Patch AArch64_be] Fix some vec_concat big-endian confusions

2014-07-08 Thread James Greenhalgh
On Mon, Jul 07, 2014 at 05:23:28PM +0100, James Greenhalgh wrote: On Fri, Jul 04, 2014 at 03:45:10PM +0100, Marcus Shawcroft wrote: On 24 June 2014 09:45, James Greenhalgh james.greenha...@arm.com wrote: 2014-06-20 James Greenhalgh james.greenha...@arm.com *

[C++ Patch] PR 57466 (DR 1584)

2014-07-08 Thread Paolo Carlini
Hi, the defect (http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#1584) is Ready and both clang and SolarisStudio already implement it. The below very simple tweak seems enough, testing is fine on x86_64-linux. Thanks! Paolo. / /cp 2014-07-08 Paolo Carlini

Re: update address taken: don't drop clobbers

2014-07-08 Thread Marc Glisse
On Mon, 7 Jul 2014, Jeff Law wrote: On 07/06/14 08:23, Marc Glisse wrote: What is the lifetime of an SSA_NAME with a default definition? The way we handle it now, we start from the uses and go back to all blocks that can reach one of the uses, since there is no defining statement where we

Re: [PATCH] Fix simplify_comparison in the combiner (PR rtl-optimization/61673)

2014-07-08 Thread Jakub Jelinek
On Thu, Jul 03, 2014 at 08:35:14AM +0200, Jakub Jelinek wrote: Bootstrapped/regtested on x86_64-linux, i686-linux and s390{,x}-linux. Ok for trunk/4.9? I'd like to see this in 4.9.1, it is a wrong-code regression from 4.8.x, so I'm pinging this now: 2014-07-03 Jakub Jelinek

Re: Strenghten assumption about dynamic type changes (placement new)

2014-07-08 Thread Jan Hubicka
On 07/02/2014 01:18 PM, Jan Hubicka wrote: We propagate types from places we know instances are created across pointers passed to functions. Once non-POD type is created at a given memory location, one can not change its type by placement_new into something else. Hmm. If the memory

Re: [PATCH 4.9][AArch64] Backport 211892: PR/60825 Make float64x1_t in arm_neon.h a proper vector type

2014-07-08 Thread Marcus Shawcroft
On 8 July 2014 13:31, Jakub Jelinek ja...@redhat.com wrote: Many people are using different patch levels interchangeably and expect them to be compatible. If X1 vectors are relatively rare, the better, fewer people will be affected when switching from 4.9.x to 4.10.x. But IMHO changing ABI

Re: Fix representation of gcov_info_type

2014-07-08 Thread Jan Hubicka
So the issue seems to be: gcov_info_type = lang_hooks.types.make_type (RECORD_TYPE); gcov_fn_info_type = lang_hooks.types.make_type (RECORD_TYPE); gcov_fn_info_ptr_type = build_pointer_type (build_qualified_type (gcov_fn_info_type, TYPE_QUAL_CONST)); build_fn_info_type

Re: [GOMP4, OpenACC] Fixed-form Fortran code failing to parse

2014-07-08 Thread Cesar Philippidis
On 07/08/2014 02:21 AM, Tobias Burnus wrote: Cesar Philippidis wrote: Thomas, is this OK for gomp-4_0-branch? ... * gcc/fortran/scanner.c (gfc_next_char_literal): Fix the scan for *$acc. This changes looks good to me. * parse.c (next_fixed): Don't handle openmp

Re: [patch,gomp-4_0-branch] openacc parallel reduction part 1

2014-07-08 Thread Cesar Philippidis
On 07/07/2014 02:55 AM, Thomas Schwinge wrote: On Sun, 6 Jul 2014 16:10:56 -0700, Cesar Philippidis cesar_philippi...@mentor.com wrote: This patch is the first step to enabling parallel reductions in openacc. Thanks! As mentioned earlier, this patch isn't complete yet. For starters,

Re: Strenghten assumption about dynamic type changes (placement new)

2014-07-08 Thread Bin.Cheng
On Tue, Jul 8, 2014 at 2:50 PM, Jan Hubicka hubi...@ucw.cz wrote: On 07/02/2014 01:18 PM, Jan Hubicka wrote: We propagate types from places we know instances are created across pointers passed to functions. Once non-POD type is created at a given memory location, one can not change its type

Re: Fix representation of gcov_info_type

2014-07-08 Thread Richard Biener
On July 8, 2014 4:03:05 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: So the issue seems to be: gcov_info_type = lang_hooks.types.make_type (RECORD_TYPE); gcov_fn_info_type = lang_hooks.types.make_type (RECORD_TYPE); gcov_fn_info_ptr_type = build_pointer_type (build_qualified_type

Re: [Patch, testsuite] PR61453 gfortran.dg/bind_c_array_params_2.f90 for targets where a call insn isn't call

2014-07-08 Thread Dominique Dhumieres
I just checked. It doesn't work on hppa64-hp-hpux11.11 due to following statement: .type myBindC, @function So can we settle for --- ../_clean/gcc/testsuite/gfortran.dg/bind_c_array_params_2.f90 2014-05-24 16:17:53.0 +0200 +++

Re: [PATCH] Fix simplify_comparison in the combiner (PR rtl-optimization/61673)

2014-07-08 Thread Richard Biener
On Tue, 8 Jul 2014, Jakub Jelinek wrote: On Thu, Jul 03, 2014 at 08:35:14AM +0200, Jakub Jelinek wrote: Bootstrapped/regtested on x86_64-linux, i686-linux and s390{,x}-linux. Ok for trunk/4.9? I'd like to see this in 4.9.1, it is a wrong-code regression from 4.8.x, so I'm pinging this

Re: Strenghten assumption about dynamic type changes (placement new)

2014-07-08 Thread Richard Biener
On Thu, Jul 3, 2014 at 4:20 AM, Jason Merrill ja...@redhat.com wrote: On 07/02/2014 06:30 PM, Jan Hubicka wrote: But this is one of things that was not quite clear to me. I know that polymorphic type A was created at a give memory location. THis means that accesses to that location in one

Re: [Patch, AArch64] Restructure arm_neon.h vector types' implementation.

2014-07-08 Thread James Greenhalgh
I've spotted another couple of issues (inline below) that I see when trying to bootstrap an AArch64 compiler with this patch applied. (sorry for any duplicate mails sent and received, my mailer was upset by some of the characters in the error messages). Thanks, James On Fri, Jun 27, 2014 at

Re: [i386] Replace builtins with vector extensions

2014-07-08 Thread Mike Stump
On Jul 8, 2014, at 4:17 AM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Jul 08, 2014 at 03:14:04PM +0400, Kirill Yukhin wrote: On the over hand, updated in such a way intrinsic may actually generate different instruction then intended (e.g. FMA case). It is the same with scalars, we have

[PATCH 2/2] Emit DW_tag_restrict_type for restrict-qualified pointers.

2014-07-08 Thread Mark Wielaard
gcc/ChangeLog PR debug/59051 * dwarf2out.h (enum dw_mod_flag): Add dw_mod_restrict. * dwarf2out.c (dw_mod_decl_flags): Handle TYPE_RESTRICT. (dw_mod_type_flags): Likewise. (dw_mods_to_quals): New function. (dw_mod_qualified_type): Likewise.

[PATCH 1/2] dwarf2out.c: Pass one cv_quals argument instead of two for const and volatile.

2014-07-08 Thread Mark Wielaard
Hi, In my original patch I introduced a new enum to keep track of the qualifiers that we might want to output. But that seems silly in retrospect. We already have the tree cv_qualifier enum to encode all possible cv-qualifier combinations, so this variant of the patch just reuses those and uses

Re: [patch,gomp-4_0-branch] openacc parallel reduction part 1

2014-07-08 Thread Cesar Philippidis
On 07/08/2014 07:28 AM, Cesar Philippidis wrote: Thanks for catching those problems! I've committed this updated version of the patch. I forgot to remove the support for the collapse clause in from the loop construct in the c frontend. I did so upstream, but not internally. I've checked in

Re: [PATCH] C++ thunk section names

2014-07-08 Thread Sriraman Tallam
On Mon, Jul 7, 2014 at 11:48 AM, Jan Hubicka hubi...@ucw.cz wrote: Hello, I apologize for taking so long to get into this patch. I ad busy time (wedding and teaching), should be back in regular schedule now. Sri, can you provide examples to show why putting thunks into the same section as

Re: [PATCH] C++ thunk section names

2014-07-08 Thread Sriraman Tallam
On Tue, Jul 8, 2014 at 10:38 AM, Sriraman Tallam tmsri...@google.com wrote: On Mon, Jul 7, 2014 at 11:48 AM, Jan Hubicka hubi...@ucw.cz wrote: Hello, I apologize for taking so long to get into this patch. I ad busy time (wedding and teaching), should be back in regular schedule now. Sri,

Re: Fix aliases on AIX

2014-07-08 Thread David Edelsohn
On Mon, Jul 7, 2014 at 4:09 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, AIX as' .set pseudoop has somewhat unexpected behaviour. It seems to be implemented by syntactically replacin all appereances of the alias by its target (that can be an expressoin) but it is still possible to globalize the

Re: [Patch, testsuite] PR61453 gfortran.dg/bind_c_array_params_2.f90 for targets where a call insn isn't call

2014-07-08 Thread John David Anglin
On 7/8/2014 11:36 AM, Dominique Dhumieres wrote: So can we settle for --- ../_clean/gcc/testsuite/gfortran.dg/bind_c_array_params_2.f90 2014-05-24 16:17:53.0 +0200 +++ gcc/testsuite/gfortran.dg/bind_c_array_params_2.f90 2014-07-07 19:15:47.0 +0200 @@ -16,7 +16,7 @@

Re: [PATCH 2/2] Emit DW_tag_restrict_type for restrict-qualified pointers.

2014-07-08 Thread Mark Wielaard
Forgot to rebase my ChangeLog, sorry. Here is the version with the correct one: gcc/ChangeLog PR debug/59051 * dwarf2out.h (modified_type_die): Handle TYPE_QUAL_RESTRICT. gcc/testsuite/ChangeLog PR debug/59051 * gcc.dg/guality/restrict.c: New test. ---

RE: [RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294)

2014-07-08 Thread Jason Merrill
I don't think we want to warn about e.g. 1-1, only about literal 0. Original Message From: Jakub Jelinek ja...@redhat.com Sent: Tue, Jul 8, 2014 05:50 AM To: Joseph S. Myers jos...@codesourcery.com; Jason Merrill ja...@redhat.com; Carlos O'Donell car...@redhat.com; Siddhesh

Re: [RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294)

2014-07-08 Thread Carlos O'Donell
On 07/08/2014 08:50 AM, Jakub Jelinek wrote: Hi! This is an attempt to move the warning about transposed memset arguments from the glibc headers to gcc FEs. The problem with the warning in glibc is that it uses __builtin_constant_p and e.g. jump threading very often makes the warning

Re: [RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294)

2014-07-08 Thread Carlos O'Donell
On 07/08/2014 03:24 PM, Jason Merrill wrote: I don't think we want to warn about e.g. 1-1, only about literal 0. What rationale would you give for not warning on 1-1? Cheers, Carlos.

Re: [PATCH, AArch64, Testsuite] Specify -fno-use-caller-save for func-ret* tests

2014-07-08 Thread Tom de Vries
On 01-07-14 19:26, Jeff Law wrote: On 07/01/14 09:51, Yufeng Zhang wrote: Hi, This patch resolves a conflict between the aapcs64 test framework for func-ret tests and the optimization option -fuse-caller-save, which was enabled by default at -O1 or above recently. Minor detail: it's enabled

[PATCH] java: Use build_qualified_type instead of build_type_variant.

2014-07-08 Thread Mark Wielaard
The java frontend is one of the only places where build_type_variant is still used. New code should use build_qualified_type. See gcc/tree.h. Build and tested on x86_64-unknown-linux-gnu. gcc/java/ChangeLog * builtins.c (putVolatile_builtin): Use build_qualified_type instead of

Re: [RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294)

2014-07-08 Thread Jakub Jelinek
On Tue, Jul 08, 2014 at 03:24:52PM -0400, Jason Merrill wrote: I don't think we want to warn about e.g. 1-1, only about literal 0. Well, at least literal 0 and '\0'. In any case, it seems both the C and C++ FEs fold the arguments too early, already during the parsing of the argument list. In

Re: Fix representation of gcov_info_type

2014-07-08 Thread Jan Hubicka
You probably can't. But check what the C frontend ends up producing with Struct x { const struct x *p; }; Doesn't it use an incomplete copy during the definition of x? I was poking around this last week with the type identification. C frontend seems always make the type complete by

Go patch committed: Fix C-style comment parsing

2014-07-08 Thread Ian Lance Taylor
PR 61746 and gofrontend issue 35 point out a bug in C-style comment parsing in the Go frontend. The sequence /*/ was interpreted as a complete C-style comment. This patch fixes the bug. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Ian

Re: [Patch, testsuite] PR61453 gfortran.dg/bind_c_array_params_2.f90 for targets where a call insn isn't call

2014-07-08 Thread Dominique Dhumieres
As mentioned before, I would prefer that you change hppa*-*-hpux* to hppa*-*-*. Done in my tree so I won't forget. Now someone has to approve the patch! Dominique

Go patch commtited: Convert array start index before bounds check

2014-07-08 Thread Ian Lance Taylor
This patch from Chris Manghane fixes an ICE-on-invalid in the gccgo frontend, reported as PR 61308. The fix is to convert an array start index to int before doing a bounds check on the type. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r

Re: [PATCH] Don't ICE with huge alignment (PR middle-end/60226)

2014-07-08 Thread Dominique Dhumieres
... diff --git gcc/testsuite/c-c++-common/pr60226.c gcc/testsuite/c-c++-common/pr60226.c ... The test fails on x86_64-apple-darwin13 with FAIL: c-c++-common/pr60226.c -std=gnu++98 (test for excess errors) Excess errors: /opt/gcc/work/gcc/testsuite/c-c++-common/pr60226.c:6:7: error:

Re: [C++ Patch] PR 57466 (DR 1584)

2014-07-08 Thread Jason Merrill
I'd rather handle this in check_cv_quals_for_unify. Jason

[wwwdocs,Java] bin/gen-classpath-compare: http - https

2014-07-08 Thread Gerald Pfeifer
Java guys, -- do you still need this script or can it be removed? For now I went ahead and applied the patch below which converts the reference to the style sheet from http to https. Gerald Index: bin/gen-classpath-compare ===

Re: [RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294)

2014-07-08 Thread Jason Merrill
On 07/08/2014 12:38 PM, Carlos O'Donell wrote: What rationale would you give for not warning on 1-1? Because it's not likely to be a case of argument transposition; it's more likely to be an expression that just happens to evaluate to 0, which is fine as a length argument to memset. On

Re: [C++ Patch] PR 60686

2014-07-08 Thread Jason Merrill
On 07/07/2014 11:15 AM, Paolo Carlini wrote: + error (only declarations can be marked %explicit%); That's pretty unclear, since a definition is a declaration. Let's split this into three error messages: If the problem is that we're outside the class, we should say that. If the problem

Re: [C++ Patch] PR 58155 - -Wliteral-suffix warns about tokens which are skipped

2014-07-08 Thread Jason Merrill
On 07/07/2014 07:20 AM, Ed Smith-Rowland wrote: OK? And for 4.9? Yes. Jason

Re: Fix aliases on AIX

2014-07-08 Thread David Edelsohn
The problem with devirt-10 and devirt-15 is the excellent kludge for aliases on AIX can produce multiple symbols. ipa-prop: Discovered a virtual call to a known target (void wxBufferedDC::InitCommon(wxDCBase*)/3 - virtual void wxDCBase::_ZN8wxDCBase18SetLayoutDirectionEi.localalias.6(int)/36),

[wwwdocs] Adjust a reference to an SVN file to https

2014-07-08 Thread Gerald Pfeifer
...and convert one from cvsweb to SVN. Applied. Gerald Index: bugs/reghunt.html === RCS file: /cvs/gcc/wwwdocs/htdocs/bugs/reghunt.html,v retrieving revision 1.19 diff -u -r1.19 reghunt.html --- bugs/reghunt.html 29 Jun 2014

Re: [Patch, testsuite] PR61453 gfortran.dg/bind_c_array_params_2.f90 for targets where a call insn isn't call

2014-07-08 Thread Mike Stump
On Jul 8, 2014, at 2:07 PM, Dominique Dhumieres domi...@lps.ens.fr wrote: As mentioned before, I would prefer that you change hppa*-*-hpux* to hppa*-*-*. Done in my tree so I won't forget. Now someone has to approve the patch! Ok. :-) I usually just expect people to check in such minor

Re: [PATCH] Don't ICE with huge alignment (PR middle-end/60226)

2014-07-08 Thread Mike Stump
On Jul 8, 2014, at 3:12 PM, Dominique Dhumieres domi...@lps.ens.fr wrote: diff --git gcc/testsuite/c-c++-common/pr60226.c gcc/testsuite/c-c++-common/pr60226.c The test fails on x86_64-apple-darwin13 with FAIL: c-c++-common/pr60226.c -std=gnu++98 (test for excess errors) Excess errors:

Re: [C++ Patch] PR 59361

2014-07-08 Thread Jason Merrill
OK. Jason

Re: [Patch, PR 61720] Clear regex BFS match queue after every iteration

2014-07-08 Thread Tim Shen
On Mon, Jul 7, 2014 at 1:24 AM, Paolo Carlini paolo.carl...@oracle.com wrote: Bah... too bad we have to resort to this. Then please summarize the discussion at the beginning of the file: what the file is *exactly* for (an accidental contributor should be able to understand if and what should go

[texi2pod.pl] Handle command @t and embedded form @dfn{@sc{}}

2014-07-08 Thread Mingjie Xing
Hello, As discussed in https://sourceware.org/ml/gdb-patches/2014-07/msg00145.html, I'd like to put the patch for texi2pod.pl here. The patch is necessary to output the gdb man manual correctly for such cases, G@{++} and @dfn{@sc{gdb/mi} interface} contrib/ChangeLog 2014-07-09 Mingjie

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

2014-07-08 Thread Xinliang David Li
Cong, can you ping this patch again? There does not seem to be pending comments left. David On Tue, Dec 17, 2013 at 10:05 AM, Cong Hou co...@google.com wrote: Ping? thanks, Cong On Mon, Dec 2, 2013 at 5:02 PM, Cong Hou co...@google.com wrote: Any comment on this patch? thanks, Cong

[PATCH] Fix bootstrap with ICL

2014-07-08 Thread Andi Kleen
[I couldn't find a patch submission address for ICL, so I'm sending this here] With ICL enabled and an LTO boot strap the ICL build always errors out due to -Werror=maybe-undefined. The following patch fixes the LTO build for me by initializing the variables in question. All warnings were

Re: Fix aliases on AIX

2014-07-08 Thread Jan Hubicka
The problem with devirt-10 and devirt-15 is the excellent kludge for aliases on AIX can produce multiple symbols. ipa-prop: Discovered a virtual call to a known target (void wxBufferedDC::InitCommon(wxDCBase*)/3 - virtual void

Re: Fix aliases on AIX

2014-07-08 Thread Jan Hubicka
With the patch, GCC on AIX now responds that ifunc is supported. The C and C++ attr-ifunc testcases now run and fail. This is unexpected. I am testing version of the patch with if (lookup_attribute (ifunc, DECL_ATTRIBUTES (n-decl))) return false; added to beggining of

FW: [PATCH, aarch64] Add prefetch support

2014-07-08 Thread Gopalasubramanian, Ganesh
PING! -Original Message- From: Gopalasubramanian, Ganesh Sent: Sunday, July 06, 2014 2:12 AM To: gcc-patches@gcc.gnu.org Cc: marcus.shawcr...@arm.com; richard.earns...@arm.com Subject: RE: [PATCH, aarch64] Add prefetch support PING! From: