[PATCH] IPA ICF: memory leak fix

2014-11-22 Thread Martin Liška
Hello. Following patch removes memory leak that was introduced by very first IPA ICF patch. I would like to thank David for hunting the leak. Patch an bootstrap on x86_86-linux-pc and no regression is introduced. Thanks, Martin From f959905e984a84d0353fb1e32ba83db2b6dfe4d2 Mon Sep 17 00:00:00

[PATCH, i386 testsuite]: Add some missing requirements to avx512vl tests

2014-11-22 Thread Uros Bizjak
Hello! 2014-11-22 Uros Bizjak ubiz...@gmail.com * gcc.target/i386/avx512vl-vpermb-2.c: Require avx512vbmi. * gcc.target/i386/avx512vl-vpermi2b-2.c: Ditto. * gcc.target/i386/avx512vl-vpermt2b-2.c: Ditto. * gcc.target/i386/avx512vl-vpmaddhuq-2.c: Require avx512ifma. *

Re: [PATCH] IPA ICF: memory leak fix

2014-11-22 Thread Markus Trippelsdorf
On 2014.11.22 at 09:05 +0100, Martin Liška wrote: Hello. Following patch removes memory leak that was introduced by very first IPA ICF patch. I would like to thank David for hunting the leak. Patch an bootstrap on x86_86-linux-pc and no regression is introduced. I gave the patch a quick

RE: [PATCHv4][MIPS] Implement O32 ABI extensions (GCC)

2014-11-22 Thread Matthew Fortune
Andrew Pinski pins...@gmail.com writes: On Wed, Nov 12, 2014 at 2:56 PM, Matthew Fortune matthew.fort...@imgtec.com wrote: Moore, Catherine catherine_mo...@mentor.com writes: The patch looks good. Please fix up these couple of nits prior to committing. OK, thanks for the

Re: [PATCH x86] Increase PARAM_MAX_COMPLETELY_PEELED_INSNS when branch is costly

2014-11-22 Thread Eric Botcazou
OK. Looks like a good performance vs. codesize tradeoff. Yes, but IMO this should be done in the generic code, unrolling small loops is profitable on most architectures. -- Eric Botcazou

Re: C++ PATCH for c++/63657 (missed unused reference warning)

2014-11-22 Thread Paolo Carlini
On 11/22/2014 03:18 AM, Jason Merrill wrote: The earlier fix for 38958 was too broad; we don't want to suppress the unused warning for all references to type with non-trivial destructor, just references bound to a temporary. Thanks! Paolo.

Re: [PATCH x86] Increase PARAM_MAX_COMPLETELY_PEELED_INSNS when branch is costly

2014-11-22 Thread Uros Bizjak
On Sat, Nov 22, 2014 at 10:49 AM, Eric Botcazou ebotca...@adacore.com wrote: OK. Looks like a good performance vs. codesize tradeoff. Yes, but IMO this should be done in the generic code, unrolling small loops is profitable on most architectures. Yeah, but after a couple of pings for a

Re: [PATCH, combine] Try REG_EQUAL for nonzero_bits

2014-11-22 Thread Eric Botcazou
The patch tries to use REG_EQUAL to get more precise info for nonzero_bits, which helps to remove unnecessary zero_extend. Here is an example when compiling Coremark, we have rtx like, (insn 1244 386 388 47 (set (reg:SI 263 [ D.5767 ]) (reg:SI 384 [ D.5767 ])) 786

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

2014-11-22 Thread Martin Jambor
Hi, On Fri, Nov 21, 2014 at 09:18:03PM +0100, Richard Biener wrote: On November 21, 2014 9:07:50 PM CET, Martin Jambor mjam...@suse.cz wrote: the testcase of PR 63551 passes a union between a signed and an unsigned integer between two functions as a parameter. The caller initializes to an

Re: [PATCH x86] Increase PARAM_MAX_COMPLETELY_PEELED_INSNS when branch is costly

2014-11-22 Thread Eric Botcazou
Yeah, but after a couple of pings for a generic change, we went the target way. That's a bit of a shame, the 400 - 100 change was very likely tested only on x86-64 and nevetheless applied to the generic code, so the fix repairing the damages should also be applied to the generic code. --

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

2014-11-22 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 12:09:46PM +0100, Martin Jambor wrote: 2014-11-21 Martin Jambor mjam...@suse.cz PR ipa/63551 * ipa-inline-analysis.c (evaluate_conditions_for_known_args): Convert value of the argument to the type of the value in the condition. testsuite/

[Ada] Fix ICE on Ordered_Map and No_Streams restriction

2014-11-22 Thread Eric Botcazou
This is an ICE on the use of the pre-defined unit Ordered_Map in conjunction with the No_Streams restriction. In this case, gigi builds a NULL_EXPR wrapping a call to the raise Program_Error routine, but it fails to gimplify it properly in gnat_gimplify_expr. Tested on x86_64-suse-linux,

[Ada] Fix ICE on bounded string subtype in packed record type

2014-11-22 Thread Eric Botcazou
The compiler aborts on an extension of a tagged record type which contains a field whose type is a packed record type which in turn contains a field of a bounded string subtype. Fixed by the attached tweak. Tested on x86_64-suse-linux, applied on the mainline. 2014-11-22 Eric Botcazou

[Patch, option handling] optc-gen.awk - support || in EnabledBy()

2014-11-22 Thread Tobias Burnus
In fortran/*.opt, I'd like to use: Fortran Var(warn_tabs) Warning EnabledBy(Wall || Wpedantic) However, || is not supported by EnabledBy. This patch adds it. I checked that option.c remains the same after the patch. I attached the patch twice: Once with -w -U16 to show the modification

[PATCH] Work around in-tree gmp configure problems

2014-11-22 Thread Bernd Edlinger
Hi, since r217627 we use an updated AutoMake missing script.  However that revealed a hidden bug in gmp-4.3.2's (up to gmp-6.0.0a) configure script.  That is: an in-tree gmp/configure fails now if flex is missing.  The gmp configure uses our missing flex script, and previously that emitted an

Re: [committed] Update config/pa/linux-atomic.c to use new subword and double word atomic support

2014-11-22 Thread John David Anglin
On 22-Nov-14, at 2:25 AM, Richard Henderson wrote: Probably better to use __builtin_trap, now that you've added it. At least then the compiler knows there's no fallthrough from the ABORT_INSTRUCTION path. Good suggestion. Added to my tree for testing. Any chance someone wants to add this

[Patch, Fortran,committed] Re: Cosubscript issue

2014-11-22 Thread Tobias Burnus
On 19 November 2014 at 23:20, Tobias Burnus wrote: Alessandro Fanfarillo wrote: The sum of the three indexes, k, j and i returns a wrong image index. Fixed as confirmed off list by the attached patch. I intent to commit it as obvious once building and regtesting has finally finished.

[PATCH] Check for strtol, strtoul, strtoll and strtoull declarations

2014-11-22 Thread John David Anglin
This patch fixes PR other/63694. Libiberty now contains implementations for strtol, strtoul, strtoll and strtoull. On systems which lack one or more of these functions, we need to check for their declaration in configure. This results in the correct defines being generated in config.h and

Re: [PATCH] Check for strtol, strtoul, strtoll and strtoull declarations

2014-11-22 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 09:40:58AM -0500, John David Anglin wrote: libiberty ChangeLog: 2014-11-22 John David Anglin dang...@gcc.gnu.org PR other/63694 * configure.ac: Check for strtol, strtoul, strtoll and strtoull declarations. * configure: Regenerated. gcc

Re: [PATCH] IPA ICF: memory leak fix

2014-11-22 Thread Martin Liška
On 11/22/2014 10:09 AM, Markus Trippelsdorf wrote: On 2014.11.22 at 09:05 +0100, Martin Liška wrote: Hello. Following patch removes memory leak that was introduced by very first IPA ICF patch. I would like to thank David for hunting the leak. Patch an bootstrap on x86_86-linux-pc and no

[SH][committed] FIx PR 63986

2014-11-22 Thread Oleg Endo
Hi, The attached patch fixes PR 63986. Tested with make -k check RUNTESTFLAGS=--target_board=sh-sim\{-m4/-ml,-m4/-mb} and no new failures. Committed as r217968. Cheers, Oleg gcc/ChangeLog: PR target/63986 PR target/51244 * config/sh/sh.c (sh_is_logical_t_store_expr,

Re: [PATCH] Check for strtol, strtoul, strtoll and strtoull declarations

2014-11-22 Thread John David Anglin
On 22-Nov-14, at 9:50 AM, Jakub Jelinek wrote: On Sat, Nov 22, 2014 at 09:40:58AM -0500, John David Anglin wrote: libiberty ChangeLog: 2014-11-22 John David Anglin dang...@gcc.gnu.org PR other/63694 * configure.ac: Check for strtol, strtoul, strtoll and strtoull

Re: [PATCH] Work around in-tree gmp configure problems

2014-11-22 Thread Jan-Benedict Glaw
Hi! On Sat, 2014-11-22 14:33:29 +0100, Bernd Edlinger bernd.edlin...@hotmail.de wrote: since r217627 we use an updated AutoMake missing script.  However that revealed a hidden bug in gmp-4.3.2's (up to gmp-6.0.0a) configure script.  That is: an in-tree gmp/configure fails now if flex is

[SH][committed] Fix PR 63783

2014-11-22 Thread Oleg Endo
Hi, The attached patch fixes PR 63783. Tested on trunk with make -k check RUNTESTFLAGS=--target_board=sh-sim\{-m4/-ml,-m4/-mb} and no new failures. Tested on 4.9 branch with make all-gcc and verifying that the problematic test case is OK. Committed on trunk as r217969 and on 4.9 branch as

Re: [PATCH] IPA ICF: memory leak fix

2014-11-22 Thread Markus Trippelsdorf
On 2014.11.22 at 16:04 +0100, Martin Liška wrote: On 11/22/2014 10:09 AM, Markus Trippelsdorf wrote: On 2014.11.22 at 09:05 +0100, Martin Liška wrote: Following patch removes memory leak that was introduced by very first IPA ICF patch. I would like to thank David for hunting the leak.

Re: Fix vectorizer conditions on updating alignment

2014-11-22 Thread H.J. Lu
On Thu, Jun 12, 2014 at 3:14 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, while updating vect_can_force_dr_alignment_p for section API I noticed the predicate is bit confused about when it can update the alignment. We need to check that decl_binds_to_current_def_p and in case we compile a

Re: Fix vectorizer conditions on updating alignment

2014-11-22 Thread Richard Biener
On November 22, 2014 6:38:03 PM CET, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Jun 12, 2014 at 3:14 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, while updating vect_can_force_dr_alignment_p for section API I noticed the predicate is bit confused about when it can update the alignment. We need

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

2014-11-22 Thread Richard Biener
On November 22, 2014 12:45:58 PM CET, Jakub Jelinek ja...@redhat.com wrote: On Sat, Nov 22, 2014 at 12:09:46PM +0100, Martin Jambor wrote: 2014-11-21 Martin Jambor mjam...@suse.cz PR ipa/63551 * ipa-inline-analysis.c (evaluate_conditions_for_known_args): Convert value of the

Re: [PATCH x86] Increase PARAM_MAX_COMPLETELY_PEELED_INSNS when branch is costly

2014-11-22 Thread Richard Biener
On November 22, 2014 12:24:22 PM CET, Eric Botcazou ebotca...@adacore.com wrote: Yeah, but after a couple of pings for a generic change, we went the target way. That's a bit of a shame, the 400 - 100 change was very likely tested only on x86-64 and nevetheless applied to the generic code, so

[PATCH, ciklplus]: Use -ffloat-store for 32bit x86 in cilk-plus/AN/builtin_fn_{custom,mutating}.c

2014-11-22 Thread Uros Bizjak
Hello! These two tests fix PR target/63847 [1], where x87 excess precision causes testcase to fail. The problem was triggered by -fpic, please see the PR for analysis. The patch adds -ffloat-store for 32bit x86 target, a standard and well tested solution for this problem. 2014-11-22 Uros

Re: [PATCH x86] Increase PARAM_MAX_COMPLETELY_PEELED_INSNS when branch is costly

2014-11-22 Thread Uros Bizjak
On Sat, Nov 22, 2014 at 7:38 PM, Richard Biener richard.guent...@gmail.com wrote: On November 22, 2014 12:24:22 PM CET, Eric Botcazou ebotca...@adacore.com wrote: Yeah, but after a couple of pings for a generic change, we went the target way. That's a bit of a shame, the 400 - 100 change was

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-22 Thread Jeff Law
On 11/18/14 15:19, Sebastian Pop wrote: The regions that we duplicate start inside a loop and stay inside the same loop, and the jump threading path is not allowed to go in deeper nested loops. The reason why we need to modify the sese duplication function is that the sese region that we need

Re: [PATCH] Check for strtol, strtoul, strtoll and strtoull declarations

2014-11-22 Thread Ian Lance Taylor
Jakub Jelinek ja...@redhat.com writes: On Sat, Nov 22, 2014 at 09:40:58AM -0500, John David Anglin wrote: libiberty ChangeLog: 2014-11-22 John David Anglin dang...@gcc.gnu.org PR other/63694 * configure.ac: Check for strtol, strtoul, strtoll and strtoull declarations.

Re: [Patch, option handling] optc-gen.awk - support || in EnabledBy()

2014-11-22 Thread Manuel López-Ibáñez
For what is worth, the patch looks good to me, except that the form EnabledBy(@var{opt} || @var{opt2} needs documentation in doc/options.texi. Perhaps it could be more condensed as (untested!): Index: optc-gen.awk === ---

[Committed/AARCH64] Fix gcc.target/aarch64/test_frame_*.c testcases after ccmp patches

2014-11-22 Thread Andrew Pinski
Hi, After the conditional compare patches, the some of the gcc.target/aarch64/test_frame_*.c testcases start to fail. This was due to no longer duplicating simple_return and causing the epilogue to be duplicated. This changes the testcases to expect the non duplicated epilogue. Committed as

[PATCH/AARCH64] v2 Add aligning of functions/loops/jumps

2014-11-22 Thread Andrew Pinski
Hi, This is just a rebase of https://gcc.gnu.org/ml/gcc-patches/2014-11/msg01615.html as requested by https://gcc.gnu.org/ml/gcc-patches/2014-11/msg01736.html. Nothing has changed in it. OK? Built and tested on aarch64-elf with no regressions. Thanks, Andrew Pinski ChangeLog: *

[PATCH v2] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-22 Thread Chen Gang
The original length 18 is not enough for HOST_WIDE_INT printing, need use 20 instead of. Also need additional bytes for printing related prefix and suffix, and define the related macro in hwint.h. It passes testsuite under fedora 20 x86_64-unknown-linux-gnu. 2014-11-23 Chen Gang

[PATCH v3] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow

2014-11-22 Thread Chen Gang
According to the next code, 'pretty_name' may need additional bytes more than 16 (may have unlimited length for array type). These is a easy way for it: use 'pretty_print' for 'pretty_name'. And not all integers are fit into tree_to_uhwi(), so also need 'wide_int' for it. Let the code meet 2

[PATCH] Improve shrink wrap for lo_sum

2014-11-22 Thread Andrew Pinski
Hi, As discussed at https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00997.html, this is the one line patch which improves shrink wrapping for lo_sum. OK? Bootstrapped and tested on x86_64 and built and tested for aarch64-elf with no regressions. It fixes shrink_wrap_symbol_ref_1.c which was

[PATCH/TopLevel] Fix compiling libgo with a combined sources

2014-11-22 Thread Andrew Pinski
Hi, The problem here is here is that OBJCOPY is not being set to the newly built objcopy when compiling libgo. This patch adds OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET. I noticed this issue when building an

[Comitted/c++ testsuite] Fix initlist-lifetime*.C on some simulators

2014-11-22 Thread Andrew Pinski
Hi, On some simulators (Octeon simple-exec) argc can be greater than 2. This causes initlist-lifetime1.C and initlist-lifetime2.C to fail. To fix this, I use a volatile variable. Committed as obvious after testing on x86_64. Thanks, Andrew Pinski * g++.dg/cpp0x/initlist-lifetime1.C:

Merging configure bits with Binutils

2014-11-22 Thread Jan-Benedict Glaw
Hi! This is my current patch series for GCC to merge all the config bits from Binutils. It's not yet testet, but I'd like to post it early to get feedback. That way, I hope to not forget something obvious. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481

[PATCH RFC 3/4] Merge the ./config directory between GCC and Binutils

2014-11-22 Thread Jan-Benedict Glaw
This pulls in the missing Binutils pieces into the ./config directory. Contains these missing Binutils changes: 2014-08-14 Alan Modra amo...@gmail.com * plugins.m4: Test for dlfcn.h or windows.h here to set default for --enable-plugins. Report error if someone tries to enable

[PATCH RFC 1/4] Merge ./configure.ac with Binutils

2014-11-22 Thread Jan-Benedict Glaw
GCC and Binutils had a common ./configure.ac after this commit: commit 08d081652f50df83f7e9768f8dbb7a99b0df50a2 Author: sandra sandra@138bc75d-0d04-0410-961f-82ee72b054a4 Date: Wed May 14 23:20:59 2014 + 2014-05-14 Sandra Loosemore san...@codesourcery.com

[PATCH RFC 2/4] Merge ./config/ChangeLog with missing entries from Binutils

2014-11-22 Thread Jan-Benedict Glaw
--- config/ChangeLog | 15 +++ 1 file changed, 15 insertions(+) diff --git a/config/ChangeLog b/config/ChangeLog index ab3a773..2cbc885 100644 --- a/config/ChangeLog +++ b/config/ChangeLog @@ -26,11 +26,22 @@ * isl.m4 (ISL_CHECK_VERSION): Check link of isl library for

[PATCH RFC 4/4] Regenerate ./configure

2014-11-22 Thread Jan-Benedict Glaw
2014-11-22 Jan-Benedict Glaw jbg...@lug-owl.de * configure: Regenerate. --- ChangeLog | 4 configure | 14 -- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 240c8ac..b7392bf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5