[committed] Fix typo in my recent const_with_all_bytes_same fix (PR tree-optimization/72824)

Hi! Martin has reported a typo in my recent const_with_all_bytes_same change, apparently we don't have any test coverage for that, so I've added a test and committed to trunk and 6.2 as obvious. 2016-08-15 Martin Liska Jakub Jelinek PR

[doc] Document GNU make version for libjava on Solaris

It turns out that neither GNU make 3.80 nor 3.81 can build libjava on Solaris with the Solaris linker because of the final "ver-sun" recipe. Probably not worth fixing at this point, so this patch simply documents it instead. Tested with "make doc", applied on all active branches as obvious.

[PATCH, libstdc++] Fixed PR72840: dg-error syntax in 20_util/ratio/cons/cons_overflow_neg.cc as obvious

Libstdc++-v3's test 20_util/ratio/cons/cons_overflow_neg.cc is missing closing curly braces for 2 dg-error directives, making them be ignored by dejagnu. Fixed as obvious. ChangeLog entry is as follows: *** libstdc++-v3/ChangeLog *** 2016-08-15 Thomas Preud'homme

Re: [PATCH 1/4][Ada,DJGPP] Ada support for DJGPP

> Both '/' and '\' must be supported as directory separators. So > DIR_SEPARATOR='/' is not OK in this case. Understood. > Unconditional converting '/' to '\' in case of DJGPP native build causes > gnatmake to break. Retested it today it with gcc-6.1.0. The problem is that > special directory

Patch ping

Hi! I'd like to ping following fix: PR71910 - http://gcc.gnu.org/ml/gcc-patches/2016-08/msg00624.html Jakub

Re: [PATCH] Add mark_spam.py script

On Mon, Aug 15, 2016 at 11:31:22AM +0200, Martin Liška wrote: > diff --git a/contrib/mark_spam.py b/contrib/mark_spam.py > index 569a03d..f206356 100755 > --- a/contrib/mark_spam.py > +++ b/contrib/mark_spam.py > @@ -34,6 +34,10 @@ def mark_as_spam(id, api_key, verbose): > r = requests.get(u)

Re: [PATCH] Extend -falign-FOO=N to N[,M]: the second number is max padding

On Fri, Aug 12, 2016 at 9:00 PM, Denys Vlasenko wrote: > On 08/12/2016 05:20 PM, Denys Vlasenko wrote: >>> >>> Yes, I know all that. Fetching is one thing. Loop cache is for instance >>> another (more important) thing. Not aligning the loop head increases >>> chance of the

Re: [PATCH, libstdc++v3]: Fallback to read/write ops in case sendfile fails with ENOSYS or EINVAL.

On 11/08/16 21:27 +0200, Uros Bizjak wrote: Hello! Attached patch implements note from sendfile manpage: Applications may wish to fall back to read(2)/write(2) in the case where sendfile() fails with EINVAL or ENOSYS. Also, the patch fixes a small inconsistency in how _GLIBCXX_USE_FCHMODAT

Re: [v3 PATCH] Implement C++17 make_from_tuple.

On 14/08/16 21:27 +0300, Ville Voutilainen wrote: Here. Tested on Linux-x64. I made the test for the macro value compare it relatively rather than exactly; I don't think our tests should necessarily break just because a macro value is updated. 2016-08-14 Ville Voutilainen

Re: [patch, OpenACC] Fix reduction lowering segfault in omp-low

On Mon, Aug 15, 2016 at 05:52:29PM +0800, Chung-Lin Tang wrote: > Hi Jakub, > This patch fixes an OpenACC reduction lowering segfault which > triggers when nested acc loop directives are present. > Cesar has reviewed this patch internally (since he mostly wrote > the code originally) > > Patch

Re: [PATCH] gcov: add new option (--hash-names) (PR gcov-profile/36412).

On 08/09/16 10:32, Martin Liška wrote: Hello. Following enhancement for gcov solves issues when we cannot create a file due to a filesystem path length limit. Selected approach utilizes existing md5sum functions. Patch survives make check -k RUNTESTFLAGS="gcov.exp" on x86_64-linux-gnu. Ready

Re: [PATCH] Add mark_spam.py script

This is version of the script I've just installed as r239467. Martin >From 6385fc5c8729dcabd791c5b0cc5ba2ff64e68489 Mon Sep 17 00:00:00 2001 From: marxin Date: Mon, 15 Aug 2016 11:28:35 +0200 Subject: [PATCH] Enhance mark_spam.py script contrib/ChangeLog: 2016-08-15 Martin

Re: [PATCH] Add mark_spam.py script

On 08/15/2016 11:37 AM, Jakub Jelinek wrote: > On Mon, Aug 15, 2016 at 11:31:22AM +0200, Martin Liška wrote: >> diff --git a/contrib/mark_spam.py b/contrib/mark_spam.py >> index 569a03d..f206356 100755 >> --- a/contrib/mark_spam.py >> +++ b/contrib/mark_spam.py >> @@ -34,6 +34,10 @@ def

Re: [PATCH] Add mark_spam.py script

On Mon, Aug 15, 2016 at 11:43:11AM +0200, Martin Liška wrote: > > Is dropping of 'comment": 'spam' intentional? > > Yes, it's not necessary to do a comment about the change for an attachment. > As the name of the attachment is set to spam, it's obvious in a comment > that is made for that. But

[PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

The testcase pr71752.c was failing because the SLP code was generating an SLP vector using arguments from the SLP scalar stmts, but was using the wrong argument number. vect_get_slp_defs() is given a vector of operands. When calling down to vect_get_constant_vectors it uses i as op_num - making

[patch, OpenACC] Fix reduction lowering segfault in omp-low

Hi Jakub, This patch fixes an OpenACC reduction lowering segfault which triggers when nested acc loop directives are present. Cesar has reviewed this patch internally (since he mostly wrote the code originally) Patch has been tested and committed to gomp-4_0-branch, is this also okay for trunk?

Re: [v3 PATCH] Implement LWG 2744 and LWG 2754.

On 09/08/16 18:00 +0300, Ville Voutilainen wrote: _Args&&...> = false> diff --git a/libstdc++-v3/include/std/utility b/libstdc++-v3/include/std/utility index 0c03644..e1a523f 100644 --- a/libstdc++-v3/include/std/utility +++ b/libstdc++-v3/include/std/utility

Re: [PATCH] Fix early debug regression with DW_AT_string_length (PR debug/71906)

On Fri, Aug 12, 2016 at 07:57:42PM +0200, Jakub Jelinek wrote: > On Fri, Aug 12, 2016 at 01:47:14PM -0400, Jason Merrill wrote: > > On 07/21/2016 12:53 PM, Jakub Jelinek wrote: > > > size = int_size_in_bytes (TREE_TYPE (szdecl)); > > ... > > >+ if (size !=

Re: [PATCH] Add mark_spam.py script

On 08/15/2016 11:48 AM, Jakub Jelinek wrote: > But can't the comment added for the attachment contain also some spam text > that should be sanitized? > > Jakub It can, currently we mark as spam just the first comment. If there's a spam PR which contains multiple comments, I'll extend the

Re: [v3 PATCH] Implement C++17 make_from_tuple.

On 11/08/16 03:04 +0300, Ville Voutilainen wrote: + + template +constexpr _Tp +__make_from_tuple_impl(_Tuple&& __t, index_sequence<_Idx...>) +{ return _Tp(get<_Idx>(std::forward<_Tuple>(__t))...); } We need to use std::get here. + + template +constexpr _Tp +

Re: [PATCH 3/4] Add support to run auto-vectorization tests for multiple effective targets

On Tue, Jul 26, 2016 at 01:51:33PM +, Robert Suchanek wrote: > Hi, > > > On May 5, 2016, at 8:14 AM, Robert Suchanek > > wrote: > > > > > > I'm resending this patch as it has been rebased and updated. I reverted a > > change > > > to

Re: [PATCH] Fix invalid memory access in gcc.c (driver/72765)

On Fri, Aug 12, 2016 at 02:22:56PM +0200, Martin Liška wrote: > Simple patch corrects assumption about string length, however the hunk in > save_string is kind of discussable as one can have a string with '\0' chars > which is length enough? > > Thoughts? > > Patch can bootstrap on

[PATCH] Some timevar fixes

I had those in my tree. Committed as obvious. Richard. 2016-08-15 Richard Biener * ree.c (rest_of_handle_ree): Remove redundant timevar push/pop. * config/i386/i386.c (pass_data_insert_vzeroupper): Account to TV_MACH_DEP. (pass_data_stv):

[PATCH] Fix val-prof-7.c on --target_board 'unix/-m32'

Hello. The test-case uses size of memory operations which cannot be handled by core2 in 32-bit mode. Fixed in the patch. Survives: make check -k -j10 RUNTESTFLAGS="tree-prof.exp --target_board 'unix/-m32'" make check -k -j10 RUNTESTFLAGS="tree-prof.exp" on x86_64-linux-gnu. Ready for trunk?

Re: [PATCH] Fix invalid memory access in gcc.c (driver/72765)

On 08/15/2016 01:02 PM, Jakub Jelinek wrote: > On Fri, Aug 12, 2016 at 02:22:56PM +0200, Martin Liška wrote: >> Simple patch corrects assumption about string length, however the hunk in >> save_string is kind of discussable as one can have a string with '\0' chars >> which is length enough? >> >>

Re: [PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

On Mon, Aug 15, 2016 at 11:48 AM, Alan Hayward wrote: > The testcase pr71752.c was failing because the SLP code was generating an > SLP > vector using arguments from the SLP scalar stmts, but was using the wrong > argument number. > > vect_get_slp_defs() is given a vector of

Re: [PATCH] gcov-tool: Do not segfault in merge operation (PR, gcov-profile/67097).

On 08/08/2016 04:16 PM, Martin Liška wrote: > Hi. > > Following simple patch is a fix for $subject. > > Ready for trunk? > Martin > Patch has been approved on IRC, installed as r239478. Martin

[PATCH, PR70895] Add copy mapping for reductions on OpenACC loop directives

Hi Jakub, per the discussion on the bugzilla PR page, reductions on OpenACC loop directives will automatically get a copy clause mapping on an enclosing parallel construct (unless bounded by a local variable or an explicit firstprivate clause). There is also a patch for libgomp testsuite cases.

Re: [PATCH] gcov: add new option (--hash-names) (PR gcov-profile/36412).

On 08/15/2016 12:47 PM, Nathan Sidwell wrote: > On 08/09/16 10:32, Martin Liška wrote: >> Hello. >> >> Following enhancement for gcov solves issues when we cannot create a file >> due to a filesystem >> path length limit. Selected approach utilizes existing md5sum functions. >> >> Patch survives

Re: [PATCH, COMMITTED] Add branch_changer.py script to maintainer-scripts

On 08/14/2016 06:35 PM, Gerald Pfeifer wrote: > The one thing that would be really good to add is documentation on > the usage of the script and/or examples for relevant invocations. > > Thanks, > Gerald Good idea, sending second version of the patch where I added usage samples. Ready to be

Re: [PATCH] Extend -falign-FOO=N to N[,M]: the second number is max padding

On 08/15/2016 11:45 AM, Richard Biener wrote: Thus. For this CPU, alignment of loops to 8 bytes is wrong: it helps if it happens to align a loop to 16 bytes, but it may in fact hurt performance if it happens to align a loop to 16+8 bytes and this pushes loop's body end over the next 16-byte

Re: [v3 PATCH] Implement LWG 2744 and LWG 2754.

On 15 August 2016 at 12:53, Jonathan Wakely wrote: >> + template >> +struct __is_in_place_impl : false_type >> +{ }; >> + >> + template >> + struct __is_in_place_impl> : true_type > Indentation nit. Will fix. > >> +{ }; >> + >> + template

Re: [PATCH] gcov: add new option (--hash-names) (PR gcov-profile/36412).

On 08/15/16 07:43, Martin Liška wrote: All nits are applied in the second version of patch. don't seem to match? Why 'e'? I've renamed it to -x, well, a lot of letters are already occupied. I guess 'x' may be better. If there is no good choice, do we really need a short name? (There

Handle preprocessor constants with -fdump-ada-spec

This makes -fdump-ada-spec dump preprocessor macros defined as integers and strings, in the form of Ada constants without declared type. Tested on x86_64-suse-linux, applied on the mainline. 2016-08-16 Eric Botcazou Arnaud Charlet

[PATCH] Fix PR76490

The following fixes PR76490 which happens because how VRP expects +INF vs. +INF(OVF) to behave wrt comparisons. I fixed all operand_equal_p cases that matter. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2016-08-15 Richard Biener PR

Re: [PATCH] PR71752 - SLP: Maintain operand ordering when creating vec defs

On 15/08/2016 12:17, "Richard Biener" wrote: >On Mon, Aug 15, 2016 at 11:48 AM, Alan Hayward >wrote: >> The testcase pr71752.c was failing because the SLP code was generating >>an >> SLP >> vector using arguments from the SLP scalar stmts, but

Re: [PATCH build/doc] Replacing libiberty with gnulib

On 15 August 2016 at 13:50, ayush goel wrote: > Included gnulib’s config.h header file inside gcc’s config.h itself as > per the discussions. > > Built and tested the system. You need to mention how you build it (languages, bootstrap, etc.) and how you tested it

Re: [PATCH, PR70895] Add copy mapping for reductions on OpenACC loop directives

On Mon, Aug 15, 2016 at 07:25:48PM +0800, Chung-Lin Tang wrote: > per the discussion on the bugzilla PR page, reductions on OpenACC loop > directives will automatically get a copy clause mapping on an enclosing > parallel construct (unless bounded by a local variable or an explicit > firstprivate

Re: [PATCH 4/4] BRIG (HSAIL) frontend: smoke test suite

Updated the test suite by refreshing the test strings to match the new output + added a new regression test case. On Mon, May 16, 2016 at 8:26 PM, Pekka Jääskeläinen wrote: > A smoke test suite. The patch has been tested more thoroughly with the > proprietary HSA PRM

Re: [PATCH build/doc] Replacing libiberty with gnulib

Included gnulib’s config.h header file inside gcc’s config.h itself as per the discussions. Built and tested the system. PFA the patch 2016-08-14 Ayush Goel * Makefile.def: Added gnulib as build & host library and dependency of all-gcc on gnulib * Makefile.in:

Re: [PATCH] Extend -falign-FOO=N to N[,M]: the second number is max padding

On Mon, Aug 15, 2016 at 1:53 PM, Denys Vlasenko wrote: > On 08/15/2016 11:45 AM, Richard Biener wrote: >>> >>> Thus. For this CPU, alignment of loops to 8 bytes is wrong: it helps if >>> it >>> happens >>> to align a loop to 16 bytes, but it may in fact hurt performance if it

Re: [v3 PATCH] Implement LWG 2744 and LWG 2754.

On 15 August 2016 at 14:55, Ville Voutilainen wrote: >>> + template >>> +struct __is_in_place >>> +: public >>> __is_in_place_impl>> >> >> >> Any reason not to use decay_t here? In all the cases where decay is >>

[PATCH] Add verifier for virtual SSA form

This adds a verifier that makes sure no overlapping life-ranges occur for virtuals. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2016-08-15 Richard Biener * tree-ssa.c: Include tree-cfg.h and tree-dfa.h. (verify_vssa): New function

Re: [PATCH 0/4] BRIG (HSAIL) frontend

Hi, I have updated the BRIG FE patches. I addressed Martin Jambor's comments and rebased to the latest gcc trunk. I will reply also to the other respective threads with updated patches. The updated diffstat: .gitignore| 2 +- Makefile.def

Re: [PATCH 1/4] BRIG (HSAIL) frontend: configuration file changes and misc

Updated patch attached. On Wed, May 18, 2016 at 7:58 PM, Pekka Jääskeläinen wrote: > Hi, > > Attached an updated patch (rebased + added .texi docs). > > On Mon, May 16, 2016 at 8:25 PM, Pekka Jääskeläinen > wrote: >> The configuration file changes and

Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.

Thanks a lot for the review Martin, Responses inline: On Mon, Aug 1, 2016 at 7:37 PM, Martin Jambor wrote: > > - I would definitely appreciate more comments. All but the most > trivial functions should have one that describes what the function > does, what are its

[PATCH] Fix PR23855

For GCC 6 unswitching gained the ability to hoist loop guard checks. The following extends this to make sure we can hoist multiple guards (including those that were hoisted from inner loops) - this allows us to hoist all guards in a three-loop nest completely out of the nest (the

Re: [wwwdocs] Improve example at https://gcc.gnu.org/gcc-6/porting_to.html#flifetime-dse

Hi Jonathan, > I think this would be an improvement, although I still can't get the > assertion to fail: Probably because the memory is still initialized to zero, when it is used for the first time. Try this: #include #include #include struct A { A() {} void* operator new(size_t s) {

[hsa-branch] Fix issues with firstbit and popcount source types

Hi, this patch addresses a regression caused by my patch that avoided useless register copies but in a few cases caused us to generate instruction types that did not make the finalizer happy. Fixed thusly. I am going to commit to the branch now and will queue it for trunk for later. Thanks,

Re: divmod transform: add test-cases

On 08/12/2016 01:17 AM, Richard Biener wrote: Note that for the main patch I don't like the current state of the divmod libcall issue. I think we need to solve this in a more reasonable manner and not expose this oddness to a GIMPLE level pass. I haven't looked at the main patch at all.

Re: Early jump threading

On 08/12/2016 12:02 AM, Richard Biener wrote: Hmm, isn't walking backwards from uses doing a lot of redundant stmt walking compared to walking stmts once in forward direction? To me it sounds like a 'local' patterns matching like optimization rather than a global one with proper data flow or a

Re: Implement -Wimplicit-fallthrough: core

On 08/12/2016 09:58 AM, Joseph Myers wrote: On Fri, 12 Aug 2016, Marek Polacek wrote: Not sure if error is appropriate here, or whether I should downgrade the error to a warning and ignore the attribute. I'd say the semantics for uses of attributes that currently parse should remain

Re: [PATCH] lra: A multiple_sets is not a simple_move_p (PR73650)

On 08/12/2016 12:38 PM, Segher Boessenkool wrote: Hi! In the PR we have a PARALLEL of a move and a compare (a "mr." instruction). The compare is dead, so single_set on it returns just the move. Then, simple_move_p returns true; but the instruction does need reloads in this case. This patch

[hsa-branch] Fix ICE in binds_to_current_def_p

Hi, we have found out that when building a shared object file with pure/const HSA functions in them, we hit an assert in binds_to_current_def_p. The reason is that we are creating a clone for the HSA implementation and even though normally clones are private, ours isn't and so we need to set

Re: backward threading heuristics tweek

On 08/11/2016 06:35 AM, Jan Hubicka wrote: This also caused: FAIL: gcc.dg/tree-ssa/pr69270-3.c scan-tree-dump-times uncprop1 ", 1" 4 Failures: gcc.dg/tree-ssa/pr69270-3.c Bisected to: Author: hubicka Date: Sun Aug 7 10:50:16 2016 + *

Re: [PATCH, COMMITTED] Add branch_changer.py script to maintainer-scripts

Hi Martin, On Mon, 15 Aug 2016, Martin Liška wrote: > Ready to be installed? you ignored (or I guess: missed) the updated patch that I included in my previous message. Can you use that instead of your original? As for the examples, I would omit the output of the script, since otherwise we'll

Re: Early jump threading

On 08/12/2016 05:27 AM, Jan Hubicka wrote: * passes.def (pass_early_thread_jumps): Schedule after forwprop. * tree-pass.h (make_pass_early_thread_jumps): Declare. * tree-ssa-threadbackward.c (fsm_find_thread_path, fsm_find_thread_path, profitable_jump_thread_path,

Re: [PATCH] Fix val-prof-7.c on --target_board 'unix/-m32'

On 08/15/2016 05:12 AM, Martin Liška wrote: Hello. The test-case uses size of memory operations which cannot be handled by core2 in 32-bit mode. Fixed in the patch. Survives: make check -k -j10 RUNTESTFLAGS="tree-prof.exp --target_board 'unix/-m32'" make check -k -j10

Re: [PATCH] lra: A multiple_sets is not a simple_move_p (PR73650)

On Mon, Aug 15, 2016 at 09:37:34AM -0600, Jeff Law wrote: > On 08/12/2016 12:38 PM, Segher Boessenkool wrote: > >In the PR we have a PARALLEL of a move and a compare (a "mr." instruction). > >The compare is dead, so single_set on it returns just the move. Then, > >simple_move_p returns true; but

Re: [wwwdocs] Improve example at https://gcc.gnu.org/gcc-6/porting_to.html#flifetime-dse

On 15/08/16 18:31 +0100, Jonathan Wakely wrote: In a later patch I'd also like to simplify the example to remove the build(void) function and just do A* a = new A; in main(), because the build function doesn't seem to serve any purpose. The assertion in the example doesn't fail, so it doesn't

libgo patch committed: fix go test -i with gccgo

https://golang.org/issue/16701 points out that `go test -i` fails when using gccgo. This patch fixes the problem, by recognizing that the go/build package will fail to load a standard import when using gccgo. This is a gccgo-specific patch, because the standard go/build package does not

Re: [PATCH] Extend -falign-FOO=N to N[,M]: the second number is max padding

On 08/15/2016 03:30 PM, Richard Biener wrote: On Mon, Aug 15, 2016 at 1:53 PM, Denys Vlasenko wrote: On 08/15/2016 11:45 AM, Richard Biener wrote: Thus. For this CPU, alignment of loops to 8 bytes is wrong: it helps if it happens to align a loop to 16 bytes, but it may

[PATCH, i386]: Fix PR72867, incorrect optimization of VMINPS/VMAXPS at compile time

Hello! Attached patch applies min/max IEEE rules w.r.t. NaN and signed zeros also to SSE intrinsics. Before the patch, intrinsics were expanded to a generic min/max pattern with commutative operands. Patched compiler expands intrinsics to an UNSPEC or generic min/max, depending on

[wwwdocs] Improve example at https://gcc.gnu.org/gcc-6/porting_to.html#flifetime-dse

I'm committing this patch to improve the wording of the -flifetime-dse docs at https://gcc.gnu.org/gcc-6/porting_to.html#flifetime-dse and to add a new paragraph explaining what the problem is and how to fix it. The current text doesn't actually say where the UB is, and talks about a placement

[patch, fortran, committed] Set deferred flag on typespec for temporary strings

Hello world, I just committed the attached patch as obvious and simple after regression-testing. One source of mysterious errors (and regressions) in the front end was that the deferred flag on the typespec was not set for deffered strings. Because some flags (including the deferred flag) in

Re: backward threading heuristics tweek

> >So the threaded path lives fully inside loop1: 6->8->9->3->4->6 propagating > >that phi_inserted is 0 after the first iteration of the loop. This looks > >like > >useful loop peeling oppurtunity which does not garble loop structure. So > >perhaps threading paths starting and passing loop

Re: Ping! Re: [PATCH, Fortran] New flag -finit-derived to initialize components of derived types

Hi Fritz, Still waiting on a review for this patch. Comments/concerns from all are welcome. The patch looks fine to me. OK for trunk, and thanks for the patch! Regards Thomas @Gerald: Will a gcc-7/changes.html file be generated? If so, we should document this new flag (and

Re: [PATCH] Add mark_spam.py script

On Mon, 15 Aug 2016, Martin Liška wrote: > It can, currently we mark as spam just the first comment. If there's a spam PR > which contains multiple comments, I'll extend the script. There certainly are spam bugs where the spammer pasted their spam in a comment after creating the bug, rather

Ping^3 Re: Implement C _FloatN, _FloatNx types [version 5]

Ping^3. This patch (non-C-front-end parts) is still pending review. (We have approvals for Fortran and rs6000 parts.) -- Joseph S. Myers jos...@codesourcery.com

Re: [WIP] [PR fortran/72741] Rework Fortran OpenACC routine clause handling

On 08/11/2016 09:26 AM, Thomas Schwinge wrote: > As Cesar asked for it, there is now a Git branch > tschwinge/omp/pr72741-wip containing these changes (plus some other > pending changes that I didn't single out at this time), at >