Re: [v3 PATCH] Implement C++17 string searchers.

On 12/09/16 02:48 +0300, Ville Voutilainen wrote: The first patch just transforms the TS version into an std one, the second patch makes it conform by implementing P0253R1. I haven't added any tests for the pair-seconds of the new api, and I noticed that we might want to go through our

Re: [PATCH] Allow FP to be used as a call-saved registe

On Mon, Sep 05, 2016 at 03:59:18PM +0100, Tamar Christina wrote: > Hi All, > > This patch allows the FP register to be used as a call-saved > register when -fomit-frame-pointer is used. > > The change is done in such a way that the defaults do not change. > To use the FP register both

Fix libgo syscall test on Solaris

The libgo syscall test has been failing on Solaris for quite some time: exec_unix_test.go:174:19: error: reference to undefined identifier 'syscall.Ioctl' errno := syscall.Ioctl(tty.Fd(), syscall.TIOCGPGRP, uintptr(unsafe.Pointer())) ^ exec_unix_test.go:209:18: error:

Re: [PATCH v2 0/9] Separate shrink-wrapping

On 09/09/2016 10:56 PM, Segher Boessenkool wrote: On Fri, Sep 09, 2016 at 12:57:32PM -0600, Jeff Law wrote: I think the lack of test coverage is something we'll want to address. Building and running the compiler, the various target libraries, and the testsuite is more than enough coverage for

Re: [DOC] Boolean -> boolean changes

On 09/10/2016 12:56 PM, Marek Polacek wrote: 2016-09-10 Marek Polacek * doc/extend.texi: Use lowercase "boolean". * doc/invoke.texi: Likewise. * doc/md.texi: Likewise. * target.def: Likewise. * doc/tm.texi: Regenerated. Ok.

Re: [v3 PATCH] Implement C++17 string searchers.

On 12 September 2016 at 13:41, Jonathan Wakely wrote: >> + template >> +struct __is_std_equal_to : std::false_type { }; >> + >> + template<> >> +struct __is_std_equal_to : std::true_type { }; > > > Is there a reason I didn't use an alias template or

Re: [PATCH, i386] Spellcheck hints for the i386 backend option handling (PR middle-end/77475, take 2, generic part)

On 09/06/2016 10:36 PM, Jakub Jelinek wrote: +/* Helper function for listing valid choices and hint for misspelled + value. CANDIDATES is a vector containing all valid strings, + STR is set to a heap allocated string that contains all those + strings concatenated, separated by spaces,

Re: [PATCH 0/4] (v2) Generating patches from fix-it hints

On Fri, 2016-09-09 at 16:56 -0600, Jeff Law wrote: > On 08/24/2016 07:13 PM, David Malcolm wrote: > > Here's a much less ambitious version of the patch kit, which > > eliminates any attempt to write to the user's source > > code (getting rid of edit_context::apply_changes and > >

Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

On 11/09/16 21:53, Peter Bergner wrote: On 9/11/16 3:35 PM, Bernd Edlinger wrote: FYI: I have a patch for the aarch64 regression here: https://gcc.gnu.org/bugzilla/attachment.cgi?id=39600 It passes bootstrap and reg-testing on x86_64-linux-gnu. Thanks for debugging and fixing this! Also

[PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

Hi, the attached patch boot-straps and reg-tests cleanly on x86_64-pc-linux-gnu, powerpc and aarch64 targets. Is it OK for trunk? Thanks Bernd. 2016-09-12 Bernd Edlinger PR rtl-optimization/77289 * lra-constraints.c (get_final_hard_regno): Removed.

Re: [v3 PATCH] Implement C++17 string searchers.

On 12 September 2016 at 12:00, Ville Voutilainen wrote: > I didn't change any of those parts in the patch, I intentionally > avoided such changes. OK. I wrote a more detailed reply that will have to wait until I have better network connectivity, but the short version is patch approved for trunk

Re: [PATCH 8/9] shrink-wrap: shrink-wrapping for separate components

On 09/09/2016 03:57 PM, Segher Boessenkool wrote: On Thu, Sep 08, 2016 at 12:34:07PM -0600, Jeff Law wrote: On 07/31/2016 07:42 PM, Segher Boessenkool wrote: Deciding what blocks should run with a certain component active so that the total cost of executing the prologues (and epilogues) is

Re: [RFC] COMDAT Safe Module Level Multi versioning

On Mon, Oct 5, 2015 at 2:58 PM, Sriraman Tallam wrote: > On Wed, Sep 9, 2015 at 4:01 PM, Sriraman Tallam wrote: >> On Wed, Sep 2, 2015 at 4:32 PM, Sriraman Tallam wrote: >>> >>> On Tue, Aug 18, 2015 at 9:46 PM, Cary Coutant

Re: [PATCH] Add a warning for suspicious use of conditional expressions in boolean context

On 09/02/2016 12:53 PM, Bernd Edlinger wrote: Hi! As reported in PR77434 and PR77421 there should be a warning for suspicious uses of conditional expressions with non-boolean arguments. This warning triggers on conditional expressions in boolean context, when both possible results are non-zero

Re: RFA (libstdc++): PATCH to implement C++17 over-aligned new

On 12/09/16 16:13 +0200, Rainer Orth wrote: Jason Merrill writes: On Thu, Sep 8, 2016 at 7:06 AM, Jonathan Wakely wrote: On 08/09/16 09:10 +0200, Marc Glisse wrote: Do we want a generic fallback implementation (similar to

Re: [PATCH v2 0/9] Separate shrink-wrapping

On 09/09/2016 02:56 PM, Segher Boessenkool wrote: On Fri, Sep 09, 2016 at 12:57:32PM -0600, Jeff Law wrote: I think the lack of test coverage is something we'll want to address. Building and running the compiler, the various target libraries, and the testsuite is more than enough coverage for

Re: [PATCHv2] Fix a few simple cases where -Wparentheses does not warn for omitted middle value

On 09/06/2016 04:07 PM, Bernd Edlinger wrote: On 09/05/16 23:50, Bernd Edlinger wrote: > Hi, > > I've noticed that there is already a -Wparentheses warning for code like > > int y = x == 2 ?: 1 > > => warning: the omitted middle operand in ?: will always be 'true', > suggest explicit middle

Re: [PATCH 0/9] RFC: selftests based on RTL dumps

On Mon, 2016-09-12 at 16:10 +0200, Bernd Schmidt wrote: > In general, it's functionality that I would very much like to have > (although maybe it's less useful these days now that the rtl side is > fairly static). I think there's not much sense looking too deeply at > the > individual patches

Re: [PATCH GCC 9/9]Prove no-overflow in computation of LOOP_VINFO_NITERS and improve code generation

On 09/06/2016 12:54 PM, Bin Cheng wrote: Hi, LOOP_VINFO_NITERS is computed as LOOP_VINFO_NITERSM1 + 1, which could overflow in loop niters' type. Vectorizer needs to generate more code computing vectorized niters if overflow does happen. However, For common loops, there is no overflow

Re: [PATCH] Add a warning for suspicious use of conditional expressions in boolean context

On 09/12/16 21:30, Jeff Law wrote: > On 09/02/2016 12:53 PM, Bernd Edlinger wrote: >> Hi! >> >> As reported in PR77434 and PR77421 there should be a warning for >> suspicious uses of conditional expressions with non-boolean arguments. >> >> This warning triggers on conditional expressions in

Re: [v3 PATCH] Implement C++17 string searchers.

On 12/09/16 18:55 +0300, Ville Voutilainen wrote: On 12 September 2016 at 18:49, Jonathan Wakely wrote: Is there a reason I didn't use an alias template or variable template here? template using __is_std_equal_to = is_same; That avoids defining a new

Re: [PATCH 5/9] regrename: Don't run if function was separately shrink-wrapped

On 09/10/2016 12:40 AM, Segher Boessenkool wrote: On Fri, Sep 09, 2016 at 05:01:19PM -0600, Jeff Law wrote: On 09/09/2016 02:41 PM, Segher Boessenkool wrote: On Fri, Sep 09, 2016 at 12:31:31PM -0600, Jeff Law wrote: On 06/08/2016 03:18 AM, Bernd Schmidt wrote: On 06/08/2016 03:47 AM, Segher

Re: [PATCH 1/9] separate shrink-wrap: New command-line flag, status flag, hooks, and doc

On 09/09/2016 02:33 PM, Segher Boessenkool wrote: On Fri, Sep 09, 2016 at 12:28:12PM -0600, Jeff Law wrote: The generic code only does + /* We don't handle "strange" functions. */ + if (cfun->calls_alloca + || cfun->calls_setjmp + || cfun->can_throw_non_call_exceptions + ||

[PATCH] unbreak libsanitizer build on sparc-linux (PR 67899)

PR sanitizer/67899 is a bootstrap failure on sparc-linux, caused by a compilation error in libsanitizer. The root cause is that `struct sigaction' has changed layout in glibc twice recently, first an unintended ABI change in glibc-2.20, and then the correction in glibc-2.22 (backported to the .20

Re: [PATCH 4/9] regrename: Don't rename restores

On 09/09/2016 02:59 PM, Segher Boessenkool wrote: On Thu, Sep 08, 2016 at 11:51:53AM -0600, Jeff Law wrote: On 07/31/2016 07:42 PM, Segher Boessenkool wrote: A restore is supposed to restore some certain register. Restoring it into some other register will not work. Don't. 2016-06-07

Re: [PATCH] df: Keep return address register undefined until epilogue_completed

On 09/10/2016 01:17 AM, Segher Boessenkool wrote: On Fri, Sep 09, 2016 at 04:40:12PM -0600, Jeff Law wrote: Right now the dataflow is conservatively correct WRT the return register. And conservatively incorrect wrt all other callee-saved regs! But prior to prologue/epilogue insertion it

Re: [PATCH] Allow FP to be used as a call-saved registe

On 09/05/2016 08:59 AM, Tamar Christina wrote: Hi All, This patch allows the FP register to be used as a call-saved register when -fomit-frame-pointer is used. The change is done in such a way that the defaults do not change. To use the FP register both -fomit-frame-pointer and -fcall-saved-

Re: [PATCH 6/9] sel-sched: Don't mess with register restores

On 09/09/2016 03:13 PM, Segher Boessenkool wrote: On Thu, Sep 08, 2016 at 11:54:33AM -0600, Jeff Law wrote: On 07/31/2016 07:42 PM, Segher Boessenkool wrote: If selective scheduling copies register restores it confuses dwarf2cfi. 2016-06-07 Segher Boessenkool

Re: RFA (libstdc++): PATCH to implement C++17 over-aligned new

On Mon, Sep 12, 2016 at 12:10 PM, Jonathan Wakely wrote: > On 12/09/16 16:13 +0200, Rainer Orth wrote: >> >> Jason Merrill writes: >> >>> On Thu, Sep 8, 2016 at 7:06 AM, Jonathan Wakely >>> wrote: On 08/09/16 09:10 +0200, Marc

Re: [PATCH 5/9] regrename: Don't run if function was separately shrink-wrapped

On 09/12/2016 10:54 AM, David Edelsohn wrote: On Sep 12, 2016 17:33, "Jeff Law" > wrote: On 09/10/2016 12:40 AM, Segher Boessenkool wrote: On Fri, Sep 09, 2016 at 05:01:19PM -0600, Jeff Law wrote: On 09/09/2016 02:41 PM, Segher Boessenkool wrote:

Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.

On Mon, Sep 12, 2016 at 7:05 AM, Eric Gallager wrote: > On 9/11/16, Manuel López-Ibáñez wrote: >> On 11/09/16 14:02, Mark Wielaard wrote: >>> -Wshadow-local which warns if a local variable shadows another local >>> variable or parameter, >>> >>>

Make max_align_t respect _Float128 [version 3]

[Patch version 3 is updated for Jason's changes to cxx_fundamental_alignment_p.] The _FloatN, _FloatNx, _DecimalN and _DecimalNx types are specified in such a way that they are basic types, meaning that max_align_t must be at least as aligned as those types. On 32-bit x86, max_align_t is

Re: RFA (libstdc++): PATCH to implement C++17 over-aligned new

I'm checking in this patch, which should fix the remaining issues: On Sat, Sep 10, 2016 at 2:14 PM, Andreas Schwab wrote: > FAIL: g++.dg/cpp1z/aligned-new1.C (test for excess errors) > Excess errors: >

Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

On 09/12/2016 07:43 AM, Bernd Edlinger wrote: Hi, the attached patch boot-straps and reg-tests cleanly on x86_64-pc-linux-gnu, powerpc and aarch64 targets. Is it OK for trunk? Unfortunately, there's no explanation for why the original code was wrong. Yes, I can clearly see you're trying to

Re: [PATCH] Detect whether target can use -fprofile-update=atomic

On 09/07/2016 03:34 AM, Martin Liška wrote: On 09/07/2016 09:45 AM, Christophe Lyon wrote: > On 6 September 2016 at 15:45, Martin Liška wrote: >> On 09/06/2016 03:31 PM, Jakub Jelinek wrote: >>> sizeof (gcov_type) talks about the host gcov type, you want instead the >>>

Re: [PATCH, testsuite]: Test compat _Complex varargs passing

On Sep 8, 2016, at 1:53 AM, Uros Bizjak wrote: > > On Mon, Sep 5, 2016 at 1:45 PM, Joseph Myers wrote: >> On Sun, 4 Sep 2016, Uros Bizjak wrote: >> >>> It looks that different handling of _Complex char, _Complex short and >>> _Complex float is there

Re: [PATCH][RFC] Early LTO debug

On 09/06/2016 05:17 AM, Richard Biener wrote: On Fri, 26 Aug 2016, Richard Biener wrote: The patch below is my current development state of Early LTO debug lumped into one big patch (no changelog, sorry). It contains previously posted

Re: [PATCH/AARCH64] Improve ThunderX code generation slightly with load/store pair

On Tue, Aug 9, 2016 at 10:43 AM, Richard Earnshaw (lists) wrote: > On 08/08/16 18:48, Andrew Pinski wrote: >> On Fri, Aug 5, 2016 at 12:18 AM, Andrew Pinski wrote: >>> Hi, >>> On ThunderX, load (and store) pair that does a pair of two word >>>

Re: [Bug target/77570] New: [msp430-elf] Wrong assembly in delay_cycles_32x insn declaration

Patch applied as per bug report... 2016-09-12 Orlando Arias PR target/77570 * config/msp430/msp430.md (delay_cycles_32x): Fix pushm/popm. Index: config/msp430/msp430.md === ---

Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

On 09/12/16 23:45, Jeff Law wrote: > On 09/12/2016 07:43 AM, Bernd Edlinger wrote: >> Hi, >> >> the attached patch boot-straps and reg-tests cleanly >> on x86_64-pc-linux-gnu, powerpc and aarch64 targets. >> >> Is it OK for trunk? > Unfortunately, there's no explanation for why the original code

Re: [PATCH, testsuite]: Test compat _Complex varargs passing

On 09/08/2016 02:53 AM, Uros Bizjak wrote: On Mon, Sep 5, 2016 at 1:45 PM, Joseph Myers wrote: On Sun, 4 Sep 2016, Uros Bizjak wrote: It looks that different handling of _Complex char, _Complex short and _Complex float is there on purpose. Is (was?) there a

Re: [PATCH] Add a warning for suspicious use of conditional expressions in boolean context

On 09/12/16 22:08, Jeff Law wrote: > On 09/12/2016 02:00 PM, Bernd Edlinger wrote: > >> Yes, I will update the patch accordingly. >> >> I agree, a statement like "if (x ? 0 : 2)" can be called suspicious as >> well, even if the result of x is not ignored as in "if (x ? 1 : 2)". >> >> After I

Re: [C PATCH] Tidy build_unary_op

On Sat, 10 Sep 2016, Marek Polacek wrote: > A minor cleanup. First, FLAG is a really bad name for a parameter, and > second, > using two vars for the same thing is redundant (we never modify any of them). > Also some bad formatting. > > Bootstrap/regtest on x86_64-linux running. Ok for trunk?

[v3 PATCH] Implement P0040R3, Extending memory management tools.

Tested on Linux-x64. I didn't even try to be clever about uninitialized_move and uninitialized_move_n, so these don't (yet) try to optimize for trivially_move_constructible types. Similarly, destroy and destroy_n don't (yet) have no-op specializations for trivially destructible types. 2016-09-13

Re: [PATCH] Optimise the fpclassify builtin to perform integer operations when possible

Tamar Christina writes: > Hi All, > > This patch adds an optimized route to the fpclassify builtin > for floating point numbers which are similar to IEEE-754 in format. > > [...] I might be the least competent person on this list to review this patch but nevertheless

RFC: PATCH to consider MAX_OFILE_ALIGNMENT for targetm.absolute_biggest_alignment

TARGET_ABSOLUTE_BIGGEST_ALIGNMENT is documented to be the largest alignment possible for any type or variable, and defaults to BIGGEST_ALIGNMENT. But MAX_OFILE_ALIGNMENT is typically much larger than BIGGEST_ALIGNMENT, and is documented as the limit for __attribute ((aligned)). Shouldn't it be

Re: [patch v2] Get rid of stack trampolines for nested functions (1/4)

On 09/04/2016 02:10 PM, Eric Botcazou wrote: This is the common infrastructure part. As explained in the initial message, nothing is activated unless both the language and the target opt in. 2016-07-04 Eric Botcazou PR ada/37139 PR ada/67205

Re: [patch v2] Get rid of stack trampolines for nested functions (1/4)

On 09/04/2016 02:10 PM, Eric Botcazou wrote: This is the common infrastructure part. As explained in the initial message, nothing is activated unless both the language and the target opt in. 2016-07-04 Eric Botcazou PR ada/37139 PR ada/67205

Re: [patch v2] Get rid of stack trampolines for nested functions (3/4)

On 09/04/2016 02:14 PM, Eric Botcazou wrote: These are the individual back-end changes. Only the architectures for which native platforms are available are changed for now. The changes were tested at AdaCore over the years for every architecture and I'll retest them if they are accepted,

Re: [PATCH] Optimise the fpclassify builtin to perform integer operations when possible

On Mon, Sep 12, 2016 at 6:21 PM, Moritz Klammler wrote: > > Tamar Christina writes: > >> Hi All, >> >> This patch adds an optimized route to the fpclassify builtin >> for floating point numbers which are similar to IEEE-754 in format. >> >> [...] > >

Re: [PATCH] Add a warning for suspicious use of conditional expressions in boolean context

On 09/12/2016 02:00 PM, Bernd Edlinger wrote: Yes, I will update the patch accordingly. I agree, a statement like "if (x ? 0 : 2)" can be called suspicious as well, even if the result of x is not ignored as in "if (x ? 1 : 2)". After I posted this patch, I extended the patch to cover also

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

On Wed, Sep 7, 2016 at 5:22 AM, Richard Biener wrote: > On Mon, Sep 5, 2016 at 6:11 PM, Tom de Vries wrote: >> On 05/09/16 09:49, Richard Biener wrote: >>> >>> On Sun, Sep 4, 2016 at 11:30 PM, Tom de Vries >>> wrote:

Re: [TREE-SSA-CCP] Issue warning when folding condition

On 08/18/2016 08:09 PM, Kugan Vivekanandarajah wrote: The testcase pr33738.C for warning fails with early-vrp patch. The reason is, with early-vrp ccp2 is folding the comparison that used to be folded in simplify_stmt_for_jump_threading. Since early-vrp does not perform jump-threading is not

[PATCH 1/3] Put a TARGET_LRA_P into every target

This patch adds a TARGET_LRA_P (defined to hook_bool_void_false) to every target that didn't yet override the hook. No functional change. Segher 2016-09-12 Segher Boessenkool * config/alpha/alpha.c (TARGET_LRA_P): New macro, defined to

[PATCH 2/3] Change the default of TARGET_LRA_P to true

Since all targets now define TARGET_LRA_P, this does not change behaviour for any existing target. Newly added ports will by default use LRA now. Segher 2016-09-12 Segher Boessenkool * targhooks.c (default_lra_p): Return true instead of false. ---

[PATCH 3/3] Delete TARGET_LRA_P from those targets that set it to "true"

A few targets aready always want LRA; those then do not need to override the default anymore. Segher 2016-09-12 Segher Boessenkool * config/aarch64/aarch64.c (TARGET_LRA_P): Delete macro. * config/arm/arm.c (TARGET_LRA_P): Delete macro. *

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On Mon, 12 Sep 2016, Martin Sebor wrote: > On 09/12/2016 04:08 PM, Joseph Myers wrote: > > On Sun, 11 Sep 2016, Martin Sebor wrote: > > > > > Attached is revision 8 of the patch (hopefully) adjusted as > > > requested above, and with a simple test with of the multiline > > > > The ChangeLog

[committed] Simplify edited_file::print_diff

Whilst working on support for fix-it hints containing newlines (e.g. "break;\n" for -Wfallthrough), I noticed that edited_file::print_diff could be simplified by breaking it up into subroutines. Successfully bootstrapped on x86_64-pc-linux-gnu. Committed to trunk as r240103. gcc/ChangeLog:

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On 09/12/2016 04:08 PM, Joseph Myers wrote: On Sun, 11 Sep 2016, Martin Sebor wrote: Attached is revision 8 of the patch (hopefully) adjusted as requested above, and with a simple test with of the multiline The ChangeLog appears not to have been updated (at least, it doesn't mention the

Re: [PATCH] Optimise the fpclassify builtin to perform integer operations when possible

On Mon, 12 Sep 2016, Tamar Christina wrote: > A limitation with this new approach is that the exponent > of the floating point has to fit in 31 bits and the floating > point has to have an IEEE like format and values for NaN and INF > (e.g. for NaN and INF all bits of the exp must be set). > >

Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

On Sun, 11 Sep 2016, Moritz Klammler wrote: > gmp='gmp-4.3.2.tar.bz2' > mpfr='mpfr-2.4.2.tar.bz2' > mpc='mpc-0.8.1.tar.gz' > isl='isl-0.15.tar.bz2' These are not the versions used in the current script (given which, presumably you need to check for any other changes to the script since you

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On Sun, 11 Sep 2016, Martin Sebor wrote: > Attached is revision 8 of the patch (hopefully) adjusted as > requested above, and with a simple test with of the multiline The ChangeLog appears not to have been updated (at least, it doesn't mention the changes to target.def). -- Joseph S. Myers

Re: [PATCH] Optimise the fpclassify builtin to perform integer operations when possible

On Mon, 12 Sep 2016, Tamar Christina wrote: > Hi All, > > This patch adds an optimized route to the fpclassify builtin > for floating point numbers which are similar to IEEE-754 in format. Similar changes may be useful for __builtin_isfinite, __builtin_isnan, __builtin_isinf,

Re: [TREE-SSA-CCP] Issue warning when folding condition

Hi Jeff, On 13/09/16 08:11, Jeff Law wrote: On 08/18/2016 08:09 PM, Kugan Vivekanandarajah wrote: The testcase pr33738.C for warning fails with early-vrp patch. The reason is, with early-vrp ccp2 is folding the comparison that used to be folded in simplify_stmt_for_jump_threading. Since

[PATCH 0/3] Default LRA to "on"

All primary platforms default to LRA now, not the old reload. It is too early to remove reload (and all ports still using reload ;-) ), this will take time, but as a first step this series makes LRA used by default. It should not change behaviour for any existing port, only for new ports. After

Re: [PATCH] Optimise the fpclassify builtin to perform integer operations when possible

Are you making endianness assumptions - specifically, does the reinterpretation as an integer require that WORDS_BIG_ENDIAN and FLOAT_WORDS_BIG_ENDIAN are the same? If so, I think that's OK (in that the only target where they aren't the same seems to be pdp11 which doesn't use IEEE formats),

Re: [TREE-SSA-CCP] Issue warning when folding condition

Hi Richard, On 19/08/16 18:00, Richard Biener wrote: On Fri, 19 Aug 2016, Kugan Vivekanandarajah wrote: On 19 August 2016 at 12:09, Kugan Vivekanandarajah wrote: The testcase pr33738.C for warning fails with early-vrp patch. The reason is, with early-vrp

Re: [PATCH] Indicate minimum in-tree MPFR version handled

On Fri, 12 Aug 2016, Bernd Edlinger wrote: > > + # MPFR v3.1.0 moved the sources into a src sub-directory. > > + if ! test -d ${srcdir}/mpfr/src; then > > +as_fn_error "Building GCC with MPFR in the source tree is only handled > > for MPFR 3.1.0+." "$LINENO" 5 > > + fi > > I think it is

[PATCH] optabs.c: Update inline documentation

Hi, I've noticed commit 147425 ("cond-optab merge target-independent bits"), , changed the semantics of `prepare_cmp_insn' function arguments, however did not fully accordingly update its documentation comment. Here's the missing

Re: [PATCH] Add -Wshadow-local and -Wshadow-compatible-local.

On 9/11/16, Manuel López-Ibáñez wrote: > On 11/09/16 14:02, Mark Wielaard wrote: >> -Wshadow-local which warns if a local variable shadows another local >> variable or parameter, >> >> -Wshadow-compatible-local which warns if a local variable shadows >> another

Re: [PATCH 0/9] RFC: selftests based on RTL dumps

In general, it's functionality that I would very much like to have (although maybe it's less useful these days now that the rtl side is fairly static). I think there's not much sense looking too deeply at the individual patches yet; we need to first figure out what we would really like this to

Re: [PATCH] Indicate minimum in-tree MPFR version handled

On Tue, 16 Aug 2016, Jeff Law wrote: > > 2016-08-12 Maciej W. Rozycki > > > > * configure.ac: Check for the minimum in-tree MPFR version > > handled. > > * configure: Regenerate. > > > > OK to apply? > OK. Applied now, thanks for your review and apologies for

Re: [PATCH v2][AArch64] Fix symbol offset limit

Wilco wrote:  > The original example is from GCC itself, the fixed_regs array is small but > due to > optimization we can end up with _regs + 0x. We could also check the bounds of each symbol if they exist, like the patch below. In aarch64_classify_symbol symbols are allowed

Re: RFA (libstdc++): PATCH to implement C++17 over-aligned new

Jason Merrill writes: > On Thu, Sep 8, 2016 at 7:06 AM, Jonathan Wakely wrote: >> On 08/09/16 09:10 +0200, Marc Glisse wrote: >>> >>> Do we want a generic fallback implementation (similar to >>> gcc/config/i386/gmm_malloc.h)? A windows version with

Re: [PATCH][AArch64 - v3] Simplify eh_return implementation

ping   Ramana Radhakrishnan wrote: > Can you please file a PR for this and add some testcases ?  This sounds like > a serious enough problem that needs to be looked at probably going back since > the dawn of time. I've created PR77455. Updated patch below: This patch simplifies the

Re: [v3 PATCH] Implement C++17 string searchers.

On 12/09/16 14:00 +0300, Ville Voutilainen wrote: On 12 September 2016 at 13:41, Jonathan Wakely wrote: + template +struct __is_std_equal_to : std::false_type { }; + + template<> +struct __is_std_equal_to : std::true_type { }; Is there a reason I

Re: [v3 PATCH] Implement C++17 string searchers.

On 12 September 2016 at 18:30, Jonathan Wakely wrote: > On 12 September 2016 at 12:00, Ville Voutilainen wrote: >> I didn't change any of those parts in the patch, I intentionally >> avoided such changes. > > OK. I wrote a more detailed reply that will have to wait until I

Re: [PATCH] optabs.c: Update inline documentation

On 09/12/2016 08:37 AM, Maciej W. Rozycki wrote: Hi, I've noticed commit 147425 ("cond-optab merge target-independent bits"), , changed the semantics of `prepare_cmp_insn' function arguments, however did not fully accordingly update its

Re: [v3 PATCH] Implement C++17 string searchers.

On 12 September 2016 at 18:49, Jonathan Wakely wrote: >>> Is there a reason I didn't use an alias template or variable template >>> here? >>> >>> template >>>using __is_std_equal_to = is_same; >>> >>> That avoids defining a new class template. >> >> >> I