Re: [Patch, Fortran] PR 78392: ICE in gfc_trans_auto_array_allocation, at fortran/trans-array.c:5979

double-ping! 2016-11-26 10:45 GMT+01:00 Janus Weil : > ping! > > > 2016-11-19 10:12 GMT+01:00 Janus Weil : >> Hi all, >> >>> I previously assumed that the test case for this PR would be legal, >>> but by now I think that's wrong. The test case should be

[Committed,fortran] Remove unneeded initialization

I've committed the following patch. It removes an unneeded initialization. A pointer is set to NULL, and then in the next line of code the pointer is set a memory address. 2016-12-02 Steven G. Kargl * expr.c (gfc_build_conversion): Remove unneeded

Re: [PATCH] S/390: Fix setmem-long test.

On Thu, Dec 01, 2016 at 03:47:22PM +0100, Dominik Vogt wrote: > gcc/testsuite/ChangeLog-setmem-long-test > > * gcc.target/s390/md/setmem_long-1.c: Fix test. Applied. Thanks! -Andreas-

C++ PATCH to stop inheriting copy constructors

In C++14 copy constructors were excluded from the inherited constructor set; Ville noticed that this was changed in the new inherited constructor rules, and lobbied for us to retain the old behavior in that case. This patch implements the proposed resolution. Tested x86_64-pc-linux-gnu, applied

Re: C++ PATCH to stop inheriting copy constructors

On 2 December 2016 at 16:00, Jason Merrill wrote: > In C++14 copy constructors were excluded from the inherited > constructor set; Ville noticed that this was changed in the new > inherited constructor rules, and lobbied for us to retain the old > behavior in that case. This

[Committed] S/390: Fix RTL sharing when generating reg note.

gcc/ChangeLog: 2016-12-02 Andreas Krebbel * config/s390/s390.c (s390_save_gprs_to_fprs): Fix RTL sharing problem. --- gcc/ChangeLog | 5 + gcc/config/s390/s390.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] avoid calling alloca(0)

On 12/01/16 19:39, Jeff Law wrote: > On 11/30/2016 09:09 PM, Martin Sebor wrote: >>> What I think this tells us is that we're not at a place where we're >>> clean. But we can incrementally get there. The warning is only >>> catching a fairly small subset of the cases AFAICT. That's not unusual

Re: [PATCH GCC]Simplify (cond (cmp (convert? x) c1) (op x c2) c3) -> (op (minmax x c1) c2)

On Fri, Dec 2, 2016 at 12:58 PM, Bin.Cheng wrote: > On Wed, Nov 30, 2016 at 3:10 PM, Richard Biener > wrote: >> On Fri, Nov 18, 2016 at 5:53 PM, Bin Cheng wrote: >>> Hi, >>> This is a rework of >>>

[hsa] Exclude parallel outlines from hsa_callable_functions_p

Hi, after the merge of nvidia OpenMP implementation, the normal parallel outline functions were also marked as "omp declare target" which lead to them being cloned and compiled to HSA which is not only unnecessary but often leads to a lot of useless HSA warning noise. The following patch deal

[PATCH, Fortran, v1] Fix deallocation of nested derived typed components

Hi all, attached patch fixes on ICE, when freeing a scalar allocatable component in a derived typed coarray. Furthermore does it fix freeing of nested derived typed allocatable components. A simple code explains the bug that is solved by the patch: type inner integer, allocatable :: i end

Re: [RFC][PATCH] Speed-up use-after-scope (re-writing to SSA)

On Thu, Dec 1, 2016 at 5:30 PM, Martin Liška wrote: > On 11/23/2016 03:13 PM, Jakub Jelinek wrote: >> On Wed, Nov 23, 2016 at 02:57:07PM +0100, Martin Liška wrote: >>> I started review process in libsanitizer: https://reviews.llvm.org/D26965 >>> And I have a question that was

[PATCH] formatting nit

Another formatting nit I noticed. Committed. nathan -- Nathan Sidwell 2016-12-02 Nathan Sidwell * diagnostic.c (diagnostic_report_diagnostic): Remove extraneous braces. Index: diagnostic.c === ---

Re: [PATCH] EVRP edge info refactoring and simple improvement

On Fri, 2 Dec 2016, Richard Biener wrote: > On Fri, 2 Dec 2016, Richard Biener wrote: > > > > > The following refactors range extraction from edges and makes EVRP > > able to merge such edge based ranges for the case of multiple > > predecessors. This allows it to catch anti-ranges from > >

Re: [PATCH] fix -fmax-errors & notes, take 2

On 12/02/2016 02:25 PM, Nathan Sidwell wrote: +/* Check if we've met the maximum error limit. */ Arguments should be documented. +void +diagnostic_check_max_errors (diagnostic_context *context, bool flush) +{ + if (!context->max_errors) +return; I prefer to spell that as != 0 since

Re: [PATCH] Unset used bit in simplify_replace_* on newly copied rtxs (PR target/78614)

On Fri, Dec 02, 2016 at 12:34:13AM +0100, Jakub Jelinek wrote: > On Thu, Dec 01, 2016 at 11:48:03PM +0100, Bernd Schmidt wrote: > > On 12/01/2016 11:43 PM, Jakub Jelinek wrote: > > > > > >so we'd need to slow shallow_copy_rtx down by adding switch (code) > > >in there or something similar. > > >

[PATCH] EVRP edge info refactoring and simple improvement

The following refactors range extraction from edges and makes EVRP able to merge such edge based ranges for the case of multiple predecessors. This allows it to catch anti-ranges from if (a < 4 || a > 8) if that is not re-written to a single test like when using gotos. I don't expect this to

[PATCH] fix -fmax-errors & notes, take 2

Hi, this respin of my notes patch from October (https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00706.html) addresses the fortran problems encountered. I introduced a new function and call it from the fortran error machinery at an appropriate point. ok? nathan -- Nathan Sidwell 2016-12-02

Re: [PATCH] EVRP edge info refactoring and simple improvement

On Fri, 2 Dec 2016, Richard Biener wrote: > > The following refactors range extraction from edges and makes EVRP > able to merge such edge based ranges for the case of multiple > predecessors. This allows it to catch anti-ranges from > if (a < 4 || a > 8) if that is not re-written to a single

Re: [PATCHv2 6/7, GCC, ARM, V8M] ARMv8-M Security Extension's cmse_nonsecure_call: use __gnu_cmse_nonsecure_call

On 23/11/16 11:53, Andre Vieira (lists) wrote: > On 11/11/16 16:19, Kyrill Tkachov wrote: >> And CC'ing Ramana and Richard this time... >> > > Hi, > > After some extra testing I found that the sibcall optimization was not > disabled for calls to function pointers with the cmse_nonsecure_call >

[Patch, Fortran, OOP] PR 43207: [OOP] invalid (pointer) assignment to and from abstract non-polymorphic expressions

Hi all, the attached patch fixes the PR in the subject line by introducing a new check to reject invalid code. It's a slight update of an old patch that I posted in the PR quite some time ago, using somewhat tighter checking to avoid side effects on the testsuite. Regtests cleanly on

Re: [PATCHv2 6/7, GCC, ARM, V8M] ARMv8-M Security Extension's cmse_nonsecure_call: use __gnu_cmse_nonsecure_call

Hi Andre, On 02/12/16 13:36, Andre Vieira (lists) wrote: On 23/11/16 11:53, Andre Vieira (lists) wrote: On 11/11/16 16:19, Kyrill Tkachov wrote: And CC'ing Ramana and Richard this time... Hi, After some extra testing I found that the sibcall optimization was not disabled for calls to

Re: [PATCH] warn on overflow in calls to allocation functions (bugs 77531 and 78284)

On 11/19/2016 05:55 PM, Martin Sebor wrote: The attached update is an attempt to incorporate the feedback I received last week during the discussion of the prerequisite patch to avoid calling alloca(0)​. The important changes are: 1) Add attribute returns_nonnull to __builtin_alloca. This

Re: [PATCH 1/2 v3] PR77822

On Fri, Nov 25, 2016 at 09:29:46AM +0100, Dominik Vogt wrote: > gcc/ChangeLog > > PR target/77822 > * rtl.h (EXTRACT_ARGS_IN_RANGE): New. Applied. Thanks! -Andreas-

Re: [PATCH] correct handling of non-constant width and precision (pr 78521)

Hi Martin, > PR 78521 notes that the gimple-ssa-sprintf pass doesn't do the right > thing (i.e., the -Wformat-length and -fprintf-return-value options > behave incorrectly) when a conversion specification includes a width > or precision with a non-constant value. The code treats such cases > as

Re: [PATCH] have __builtin_object_size handle POINTER_PLUS with non-const offset (pr 77608)

On Thu, Dec 1, 2016 at 6:58 PM, Martin Sebor wrote: >> Sure - but then you maybe instead want to check for op being in >> range [0, max-of-signed-type-of-op] instead? So similar to >> expr_not_equal_to add a expr_in_range helper? >> >> Your function returns true for sizetype

Re: [PATCH] S/390: Fix litpool-r3-1.c.

On Wed, Nov 23, 2016 at 12:27:30PM +0100, Dominik Vogt wrote: > gcc/ChangeLog-lp1 > > * gcc.target/s390/litpool-r3-1.c: Fix label number test. Applied. Thanks! -Andreas-

Re: [patch,testsuite,avr]: Filter-out -mmcu= from options for tests that set -mmcu=

On 01.12.2016 17:40, Mike Stump wrote: On Dec 1, 2016, at 3:54 AM, Georg-Johann Lay wrote: This patch moves the compile tests that have a hard coded -mmcu=MCU in their dg-options to a new folder. The exp driver filters out -mmcu= from the command line options that are

RE: [PATCH] PR fortran/77505 -- Treat negative character length as LEN=0

Thank you Steve. Thanks, Elizebeth -Original Message- From: Steve Kargl [mailto:s...@troutmask.apl.washington.edu] Sent: 02 December 2016 04:54 To: Punnoose, Elizebeth Cc: fort...@gcc.gnu.org; gcc-patches@gcc.gnu.org Subject: Re: [PATCH] PR fortran/77505 --

[PATCH, alpha]: Fix invalid RTX sharing

2016-12-02 Uros Bizjak * config/alpha/alpha.md (exception_receiver): Copy alpha_gp_ave_rtx return value. Bootstrapped and regression tested on alphaev68-linux-gnu, will commit soon. Uros. diff --git a/gcc/config/alpha/alpha.md b/gcc/config/alpha/alpha.md index

Re: [PR middle-end/78548] fix latent double free in tree-ssa-uninit.c

On 12/01/2016 07:32 AM, Richard Biener wrote: On Thu, Dec 1, 2016 at 12:03 PM, Aldy Hernandez wrote: This looks like a latent problem in the -Wmaybe-uninitialized code unrelated to my work. The problem here is a sequence of simplify_preds() followed by normalize_preds() that

[avr,committed]: Fix coding-style glitches in avr.c

Committed rectifications for bunch of coding rule nits as obvious. Johann * config/avr/avr.c: Fix coding rule glitches. Index: config/avr/avr.c === --- config/avr/avr.c (revision 243104) +++ config/avr/avr.c (working copy) @@

Re: [PATCH] remove invalid "tail +16c"

On 11/22/2016 11:22 PM, ma.ji...@zte.com.cn wrote: > Hi all, > In "config/acx.m4", there are still some "tail +16c" which are invalid > on POSIX systems. > In my opinion， all "tail +16c" should be changed to "tail -c +16" > directly, as most systems has accept the latter. > And, to skip

Re: [tree-tailcall] Check if function returns it's argument

On Thu, 1 Dec 2016, Jeff Law wrote: > On 12/01/2016 06:22 AM, Richard Biener wrote: > > > Well after removing DECL_BY_REFERENCE, verify_gimple still fails but > > > differently: > > > > > > tail-padding1.C:13:1: error: RESULT_DECL should be read only when > > > DECL_BY_REFERENCE is set > > > }

Re: [PATCH v3] Do not simplify "(and (reg) (const bit))" to if_then_else.

On Thu, Dec 01, 2016 at 04:30:08PM +0100, Dominik Vogt wrote: > gcc/ChangeLog > > * combine.c (combine_simplify_rtx): Suppress replacement of > "(and (reg) (const_int bit))" with "if_then_else". Applied. Thanks! -Andreas-

Re: [PATCH 2/2 v3] PR77822

On Fri, Nov 25, 2016 at 09:25:59AM +0100, Dominik Vogt wrote: > gcc/ChangeLogb > > PR target/77822 > * config/s390/s390.md ("extzv") > ("*extzv") > ("*extzvdi_lshiftrt") > ("*_ior_and_sr_ze") > ("*extract1bitdi") > ("*insv", "*insv_rnsbg_noshift") >

Re: [RFA] Handle target with no length attributes sanely in bb-reorder.c

On Thu, Dec 1, 2016 at 6:28 PM, Jeff Law wrote: > On 12/01/2016 05:04 AM, Segher Boessenkool wrote: >> >> On Thu, Dec 01, 2016 at 10:19:42AM +0100, Richard Biener wrote: > > Thinking about this again maybe targets w/o insn-length should simply > always use the

[PATCH] Even more minimal reimplementation of errors.c within read-md.c

On Thu, 2016-12-01 at 13:40 +0100, Bernd Schmidt wrote: > On 11/30/2016 09:24 PM, David Malcolm wrote: > > > gcc/ChangeLog: > > * read-md.c (have_error): New global, copied from errors.c. > > (fatal): New function, copied from errors.c. > > I would have expected the function to go into

Fix various arm failures with config-list.mk

ARM targets are failing to build due to an unused variable in arm_handle_cmse_nonsecure_call. Fixed in the obvious way. Verified all but arm-netbsdelf and arm-wrs-vxworks now build correctly. Jeff commit eb0d047665fc3067095d89f5592da1b2183fe72f Author: law

Re: [RFA] Handle target with no length attributes sanely in bb-reorder.c

On 12/02/2016 03:22 PM, Segher Boessenkool wrote: On Fri, Dec 02, 2016 at 09:47:00AM +0100, Richard Biener wrote: STC tries to make as large as possible consecutive "traces", mainly to help with instruction cache utilization and hit rate etc. It cannot do a very good job if it isn't allowed to

[committed] selftest.c: remove calls to strndup (PR bootstrap/78616)

As part of the fix for PR c/78498 I added selftests for xstrndup in r243030, and seeing the implementation of strndup in libiberty, I also made the selftests verify strndup. This turned out to be overzealous, as strndup is not necessarily available in every configuration when the selftests run.

Re: [PATCH] Turn on gnu-indirect-function by default on PowerPC servers

On Fri, Dec 02, 2016 at 04:09:22PM -0500, Michael Meissner wrote: > On Thu, Nov 24, 2016 at 01:07:04AM +, Joseph Myers wrote: > This patch enables --enable-gnu-indirect-function on all PowerPC linux > systems, > except for targetting Android or uclib. It is exactly the same code as we use >

Re: [PATCH] handle integer overflow/wrapping in printf directives (PR 78622)

Thanks for looking at this! I realize it's dense code and not easy to make sense out of. PR middle-end/78622 - [7 Regression] -Wformat-length/-fprintf-return-value incorrect with overflow/wrapping gcc/ChangeLog: PR middle-end/78622 * gimple-ssa-sprintf.c (min_bytes_remaining): Use

Re: [Patches] Add variant constexpr support for visit, comparisons and get

On Wed, Nov 30, 2016 at 8:27 AM, Jonathan Wakely wrote: > On 26/11/16 21:38 -0800, Tim Shen wrote: >> >> This 4-patch series contains the following in order: >> >> a.diff: Remove uses-allocator ctors. They are going away, and removing >> it reduces the maintenance burden from now on. > > > Yay!

[PATCH] simplify-rtx: Fix the last fix (PR78638)

I managed to get the last obvious fix wrong: mode is M1, GET_MODE (op) is M2. Checking this in as obvious fix (to the obvious fix). Let's hope it ends here. Tested on powerpc64-linux and powerpc64le-linux. Segher 2016-12-02 Segher Boessenkool *

[PATCH] fix integer overflow bugs in gimple-ssa-sprintf.c (PR 78608)

Bug 78608 - gimple-ssa-sprintf.c:570:17: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int' points out an integer overflow bug in the pass caught by ubsan. The bug was due to negating a number without checking for equality to INT_MIN. In addition, my recent

[PATCH] Handle andn and ~ in 32-bit stv pass (PR target/70322)

Hi! While the https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01087.html added *andndi3_doubleword, I don't understand how it can actually work. The problem is that this pattern is for combine, and needs combining of DImode NOT setter with DImode AND user. But there is no DImode pattern for

Re: [Patch 0/2 PR78561] Recalculate constant pool size before emitting it

On Thu, Dec 01, 2016 at 12:55:21PM -0500, David Edelsohn wrote: > > James Greenhalgh writes: > > > The patch set has been bootstrapped and tested on aarch64-none-linux-gnu and > > x86-64-none-linux-gnu without any issues. I've also cross-tested it for > > aarch64-none-elf and build-tested it

Re: [PATCH 8/9] Introduce class function_reader (v4)

On 12/01/2016 10:43 PM, David Malcolm wrote: + rtx_insn *jump_insn = get_insn_by_uid (1); + ASSERT_EQ (JUMP_INSN, GET_CODE (jump_insn)); + ASSERT_EQ (ret_rtx, JUMP_LABEL (jump_insn)); + // FIXME: ^^^ use ASSERT_RTX_PTR_EQ here ^^^ Why is this a fixme and not just done that way (several

[PATCH, Fortran, pr78505, v1] [F08] Coarray source allocation not synchronizing on oversubscribed cores

Hi all, attached patch adds a call to sync_all after an ALLOCATE allocating a coarray. This is to adhere to standard wanting: ..., execution of the segment (11.6.2) following the statement is delayed until all other active images in the current team have executed the same statement the same

Re: [PATCH] Handle andn and ~ in 32-bit stv pass (PR target/70322)

On Fri, Dec 2, 2016 at 3:21 PM, Jakub Jelinek wrote: > Hi! > > While the https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01087.html > added *andndi3_doubleword, I don't understand how it can actually work. > The problem is that this pattern is for combine, and needs combining > of

Re: [PATCH] Handle andn and ~ in 32-bit stv pass (PR target/70322)

On Fri, Dec 2, 2016 at 5:11 PM, Uros Bizjak wrote: > On Fri, Dec 2, 2016 at 3:21 PM, Jakub Jelinek wrote: >> Hi! >> >> While the https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01087.html >> added *andndi3_doubleword, I don't understand how it can actually

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

On Fri, Dec 02, 2016 at 04:47:19PM +0100, Janus Weil wrote: > Hi Steve, > > 2016-12-02 2:33 GMT+01:00 Steve Kargl : > > The attached patch fixes an ICE, a nearby whitespace issue, and > > removed the ATTRIBUTE_UNUSED tag. THe change has passed regression > >

Re: [PATCH] Handle andn and ~ in 32-bit stv pass (PR target/70322)

On Fri, Dec 02, 2016 at 05:12:20PM +0100, Uros Bizjak wrote: > >> This patch: > >> 1) adds one_cmpldi2 pattern for stv purposes (which splits into two > >>one_cmplsi2 after reload) > >> 2) teaches the 32-bit stv pass to handle NOT (as xor all-ones) > >> 3) renames the old *andndi3_doubleword

Re: [PR 70965] Schedule extra pass_rebuild_cgraph_edges

> Hi, > > On Fri, Nov 25, 2016 at 02:10:51PM +0100, Jan Hubicka wrote: > > > On Thu, Nov 24, 2016 at 5:44 PM, Martin Jambor wrote: > > > > > > > > ... > > > > > > > > 2016-11-24 Martin Jambor > > > > > > > > gcc/ > > > > * passes.def

Re: [PATCH] gcc: Fix sysroot relative paths for MinGW

On 10/08/2016 04:26 AM, Tadek Kijkowski wrote: Prevent paths relative to sysroot directory from being transformed to Windows form with MSYS prefix. Second attempt: Moved most changes to x-mingw32. Only thing added to Makefile.in are new variables to ease overriding in included file. Disabled

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 17:30 GMT+01:00 Steve Kargl : > On Fri, Dec 02, 2016 at 04:47:19PM +0100, Janus Weil wrote: >> Hi Steve, >> >> 2016-12-02 2:33 GMT+01:00 Steve Kargl : >> > The attached patch fixes an ICE, a nearby whitespace issue,

Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbers in GIMPLE.

Ping? Is there anything else I need to do for the patch or is it OK for trunk? Thanks, Tamar From: Tamar Christina Sent: Friday, November 25, 2016 12:18:52 PM To: Joseph Myers Cc: GCC Patches; Wilco Dijkstra; rguent...@suse.de; l...@redhat.com; Michael

[PATCH, GCC/testsuite/ARM] XFAIL optional_thumb-1 and optional_thumb-2 testcases

Hi, The logic to make -mthumb optional for Thumb-only targets was designed to only apply when no mode is specified either at compile time or when the toolchain was configured (using --with-mode). The dg-skip-if in the testcases optional_thumb-1 and optional_thumb-2 catch the former case but

Re: [build] Handle gas/gld --compress-debug-sections=type

>From my point of view this should be backported to the active branches. Building GCC 5 and GCC 6 with binutils >=2.26 now results in $ gcc -c -gz foo.c gcc: error: -gz is not supported in this configuration building these GCC version with binutils 2.25 recognizes this option. On 30.05.2016

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

On Wed, Nov 30, 2016 at 02:07:58PM +, Kyrill Tkachov wrote: > > On 29/11/16 20:29, Segher Boessenkool wrote: > >Hi James, Kyrill, > > > >On Tue, Nov 29, 2016 at 10:57:33AM +, James Greenhalgh wrote: > >>>+static sbitmap > >>>+aarch64_components_for_bb (basic_block bb) > >>>+{ > >>>+

Re: [PATCH] OpenACC executable directives

On 12/02/2016 06:37 AM, Cesar Philippidis wrote: > This patch teaches the C and C++ FEs to expect ACC ENTER/EXIT DATA, ACC > UPDATE and ACC WAIT executable directives to be used inside compound > statements. This is to prevent situations such as > > if (needs_wait) > #pragma acc wait > >

Re: [PATCH 1/9] print_rtx: implement support for reuse IDs (v2)

On 12/02/2016 02:37 AM, David Malcolm wrote: Here's the current status of the kit: "[PATCH 1/9] print_rtx: implement support for reuse IDs (v2)" https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01188.html Still needs review Whoops, I thought this was settled. Ok for the new version. Bernd

Re: [PR 70965] Schedule extra pass_rebuild_cgraph_edges

Hi, On Fri, Nov 25, 2016 at 02:10:51PM +0100, Jan Hubicka wrote: > > On Thu, Nov 24, 2016 at 5:44 PM, Martin Jambor wrote: > > > > > > ... > > > > > > 2016-11-24 Martin Jambor > > > > > > gcc/ > > > * passes.def (pass_build_ssa_passes): Add > > >

Re: [PATCH] correct handling of non-constant width and precision (pr 78521)

On 12/02/2016 01:31 AM, Rainer Orth wrote: Hi Martin, PR 78521 notes that the gimple-ssa-sprintf pass doesn't do the right thing (i.e., the -Wformat-length and -fprintf-return-value options behave incorrectly) when a conversion specification includes a width or precision with a non-constant

PR78634: ifcvt/i386 cost updates

With the i386 backend no longer double-counting the cost of a SET, the default implementation default_max_noce_ifcvt_seq_cost now provides too high a bound for if conversion, allowing very costly substitutions. The following patch fixes this by making an i386 variant of the hook, but first -

Re: [PATCH] Unset used bit in simplify_replace_* on newly copied rtxs (PR target/78614)

On Fri, Dec 02, 2016 at 03:51:52PM +0100, Bernd Schmidt wrote: > I like this a lot better. Of course now that it's spelled out it seems like > several of these (PC, CC0, RETURN, maybe SCRATCH) should never be passed to > shallow_copy_rtx and maybe a checking_assert to that effect might be in >

[C++ Patch] PR 78637 ("ICE on invalid C++ code (internal compiler error: in pop_namespace, at cp/name-lookup.c:3826)")

Hi, this regression is caused by my fix for c++/60385, where I changed push_namespace to early return (a bool) when pushdecl fails. In the present testcase, a different push_namespace call in cp_parser_namespace_definition, for nested namespace definitions, fails, thus returns early, and

[PATCH] OpenACC executable directives

This patch teaches the C and C++ FEs to expect ACC ENTER/EXIT DATA, ACC UPDATE and ACC WAIT executable directives to be used inside compound statements. This is to prevent situations such as if (needs_wait) #pragma acc wait // do something else here from generating unexpected code when

Re: [PATCH] OpenACC executable directives

On Fri, Dec 02, 2016 at 06:38:25AM -0800, Cesar Philippidis wrote: > 2016-12-02 Cesar Philippidis > James Norris > > gcc/c/ > * c-parser.c (c_parser_pragma): Error when PRAGMA_OACC_{ENTER_DATA, > EXIT_DATA,WAIT}

Re: [PATCH 8b/9] Add target-independent selftests of RTL function reader

Conceptually, the concept of "target-independent RTL" seems weird to me. But I guess you expect these to work because the backend never gets involved trying to recognize insns or addressing modes? I think a comment to that effect somewhere near the C code to load these tests would be good. I

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

Hi Steve, 2016-12-02 2:33 GMT+01:00 Steve Kargl : > The attached patch fixes an ICE, a nearby whitespace issue, and > removed the ATTRIBUTE_UNUSED tag. THe change has passed regression > testing on x86_64-*-freebsd. Ok to commit? huh, I don't really

Re: [PATCH] Unset used bit in simplify_replace_* on newly copied rtxs (PR target/78614)

On 12/02/2016 03:12 PM, Jakub Jelinek wrote: --- gcc/rtl.c.jj2016-10-31 13:28:12.0 +0100 +++ gcc/rtl.c 2016-12-02 11:01:12.557553040 +0100 @@ -318,10 +318,6 @@ copy_rtx (rtx orig) us to explicitly document why we are *not* copying a flag. */ copy = shallow_copy_rtx

[Patch, Fortran, OOP] PR 42188: F03:C612. The leftmost part-name shall be the name of a data object

Hi all, another simple fix for a rather old PR. This one adds a new check, in order to provide better error messages than just "Unclassifiable statement". Regtests cleanly on x86_64-linux-gnu. Ok for trunk? Cheers, Janus 2016-12-02 Janus Weil PR fortran/42188 *

Re: Change default level for -Wimplicit-fallthrough

On 11/03/2016 05:51 AM, Bernd Schmidt wrote: I'm concerned about the number of false positives for this warning, and judging by previous discussions, I'm not alone in this. This patch limits it to level 1 (any comment before the case label disables the warning) for cases where the user specified

Re: Avoid alloca(0) when temporarily propagating operands during threading

On Fri, Dec 02, 2016 at 11:02:33AM -0700, Jeff Law wrote: > It won't cause any problems in this and probably most instances, but leaving > the code in its prior state is simply wrong from a maintenance standpoint. > > I'd much rather have the code explicitly and safely handle the zero operands >

Re: [PATCH] Add AVX512 k-mask intrinsics

2016-11-11 22:14 GMT+03:00 Uros Bizjak : > On Fri, Nov 11, 2016 at 7:23 PM, Andrew Senkevich > wrote: >> 2016-11-11 20:56 GMT+03:00 Uros Bizjak : >>> On Fri, Nov 11, 2016 at 6:50 PM, Uros Bizjak wrote: On

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 18:13 GMT+01:00 Steve Kargl : >> >> > The attached patch fixes an ICE, a nearby whitespace issue, and >> >> > removed the ATTRIBUTE_UNUSED tag. THe change has passed regression >> >> > testing on x86_64-*-freebsd. Ok to commit? >> >> >> >> huh, I

Re: Avoid alloca(0) when temporarily propagating operands during threading

On 12/02/2016 11:11 AM, Jakub Jelinek wrote: On Fri, Dec 02, 2016 at 11:02:33AM -0700, Jeff Law wrote: It won't cause any problems in this and probably most instances, but leaving the code in its prior state is simply wrong from a maintenance standpoint. I'd much rather have the code

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

On Fri, Dec 02, 2016 at 06:00:48PM +0100, Janus Weil wrote: > 2016-12-02 17:30 GMT+01:00 Steve Kargl : > > On Fri, Dec 02, 2016 at 04:47:19PM +0100, Janus Weil wrote: > >> Hi Steve, > >> > >> 2016-12-02 2:33 GMT+01:00 Steve Kargl

Re: [PATCH] avoid calling alloca(0)

On 12/2/16, Bernd Edlinger wrote: > On 12/01/16 19:39, Jeff Law wrote: >> On 11/30/2016 09:09 PM, Martin Sebor wrote: What I think this tells us is that we're not at a place where we're clean. But we can incrementally get there. The warning is only

Re: Avoid alloca(0) when temporarily propagating operands during threading

On Thu, Dec 01, 2016 at 11:43:19PM -0700, Jeff Law wrote: > > Martin's alloca work flagged this code as problematical. Essentially if we > had a statement with no operands and the statement was not in the hash > table, then we could end up performing alloca (0), which is inadvisable. I still

Re: Avoid alloca(0) when temporarily propagating operands during threading

On 12/02/2016 10:58 AM, Jakub Jelinek wrote: On Thu, Dec 01, 2016 at 11:43:19PM -0700, Jeff Law wrote: Martin's alloca work flagged this code as problematical. Essentially if we had a statement with no operands and the statement was not in the hash table, then we could end up performing

[PATCH 8a/9] Introduce class function_reader (v7)

On Fri, 2016-12-02 at 15:41 +0100, Bernd Schmidt wrote: > On 12/02/2016 03:00 AM, David Malcolm wrote: > > Changed in v6: > > - split out dump-reading selftests into followup patches > > (target-independent, and target-specific) > > - removes unneeded headers from read-rtl-function.c > > -

Re: Avoid alloca(0) when temporarily propagating operands during threading

On Fri, Dec 02, 2016 at 11:13:29AM -0700, Jeff Law wrote: > >But -Wuninitialized also found tons of real-world bugs. Do we have a single > >real-world example where such a warning would actually be useful (as in, > >there would be an actual bug)? Otherwise we are adding workarounds for a >

Re: [PATCH] Add AVX512 k-mask intrinsics

On Fri, Dec 2, 2016 at 6:44 PM, Andrew Senkevich wrote: > 2016-11-11 22:14 GMT+03:00 Uros Bizjak : >> On Fri, Nov 11, 2016 at 7:23 PM, Andrew Senkevich >> wrote: >>> 2016-11-11 20:56 GMT+03:00 Uros Bizjak

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

2016-12-02 19:06 GMT+01:00 Janus Weil : > 2016-12-02 18:13 GMT+01:00 Steve Kargl : >>> >> > The attached patch fixes an ICE, a nearby whitespace issue, and >>> >> > removed the ATTRIBUTE_UNUSED tag. THe change has passed regression >>> >> >

Re: [PATCH] Turn on gnu-indirect-function by default on PowerPC servers

On Thu, Nov 24, 2016 at 01:07:04AM +, Joseph Myers wrote: > On Wed, 23 Nov 2016, Michael Meissner wrote: > > > Since some of the embedded hosts use powerpc-*-linux, I only set > > the > > default if the target is a 64-bit PowerPC system. I tested the compiler > > manually to verify that

Re: [PATCH] Fix tsubst_init error recovery (PR c++/78649)

OK. On Fri, Dec 2, 2016 at 3:41 PM, Jakub Jelinek wrote: > Hi! > > Trying to value initialize error_mark_node type ICEs, other spots avoid > calling build_value_init* if the type is error_mark_node. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > >

Re: [PATCH] enable -Wformat-length for dynamically allocated buffers (pr 78245)

On 11/29/2016 08:22 PM, Martin Sebor wrote: That said, I defer to you on how to proceed here. I'm prepared to do the work(*) but I do worry about jeopardizing the chances of this patch and the others making it into 7.0. So would it make sense to just init/fini the b_o_s framework in your pass

Re: [PATCH] Fix PR78306

On 11/30/2016 07:18 AM, Richard Biener wrote: so progess on the OMP front hides regressions elsewhere. The patch that started this thread does not have any effect on the conformance testsuite result. That makes it even more obvious that it is a) unmaintained, b) probably not used widely as

[PATCH] Fix tsubst_init error recovery (PR c++/78649)

Hi! Trying to value initialize error_mark_node type ICEs, other spots avoid calling build_value_init* if the type is error_mark_node. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-12-02 Jakub Jelinek PR c++/78649 * pt.c

Re: [PATCH] handle integer overflow/wrapping in printf directives (PR 78622)

On 12/01/2016 07:31 PM, Martin Sebor wrote: On 12/01/2016 02:15 AM, Jakub Jelinek wrote: On Thu, Dec 01, 2016 at 08:26:47AM +0100, Jakub Jelinek wrote: Isn't this too simplistic? I mean, if you have say dirtype of signed char and argmin say 4096 + 32 and argmax say 4096 + 64, (signed char)

Re: [PATCH] enable -Wformat-length for dynamically allocated buffers (pr 78245)

On 11/29/2016 08:22 PM, Martin Sebor wrote: That said, I defer to you on how to proceed here. I'm prepared to do the work(*) but I do worry about jeopardizing the chances of this patch and the others making it into 7.0. So would it make sense to just init/fini the b_o_s framework in your pass

Re: PR78599

On 3 December 2016 at 00:25, Martin Jambor wrote: > Hi, > > On Thu, Dec 01, 2016 at 01:43:16PM +0100, Richard Biener wrote: >> On Thu, Dec 1, 2016 at 11:07 AM, Prathamesh Kulkarni >> wrote: >> > Hi, >> > As mentioned in PR, the issue seems to be

[PATCH] Add ASSERT_RTX_PTR_EQ

On Fri, 2016-12-02 at 16:28 +0100, Bernd Schmidt wrote: > On 12/01/2016 10:43 PM, David Malcolm wrote: > > > > + rtx_insn *jump_insn = get_insn_by_uid (1); > > > > + ASSERT_EQ (JUMP_INSN, GET_CODE (jump_insn)); > > > > + ASSERT_EQ (ret_rtx, JUMP_LABEL (jump_insn)); > > > > + // FIXME: ^^^ use

Re: [PATCH 8a/9] Introduce class function_reader (v6)

On 12/02/2016 03:00 AM, David Malcolm wrote: Changed in v6: - split out dump-reading selftests into followup patches (target-independent, and target-specific) - removes unneeded headers from read-rtl-function.c - numerous other cleanups identified in review Ok, starting to look very close to

Re: [PATCH] Handle andn and ~ in 32-bit stv pass (PR target/70322)

On Fri, Dec 2, 2016 at 5:30 PM, Jakub Jelinek wrote: > On Fri, Dec 02, 2016 at 05:12:20PM +0100, Uros Bizjak wrote: >> >> This patch: >> >> 1) adds one_cmpldi2 pattern for stv purposes (which splits into two >> >>one_cmplsi2 after reload) >> >> 2) teaches the 32-bit stv pass

Re: PR78599

Hi, On Thu, Dec 01, 2016 at 01:43:16PM +0100, Richard Biener wrote: > On Thu, Dec 1, 2016 at 11:07 AM, Prathamesh Kulkarni > wrote: > > Hi, > > As mentioned in PR, the issue seems to be that in > > propagate_bits_accross_jump_functions(), > > ipa_get_type()

Re: [PATCH] PR fortran/78618 -- RANK() should not ICE

On Fri, Dec 02, 2016 at 07:39:33PM +0100, Janus Weil wrote: > > Testing went well. Committed as r243201. > Thanks for reviewing my patch, and more importantly thanks for your patch. -- Steve

Re: PR78634: ifcvt/i386 cost updates

On Fri, Dec 02, 2016 at 05:00:05PM +0100, Bernd Schmidt wrote: > With the i386 backend no longer double-counting the cost of a SET, > the default implementation default_max_noce_ifcvt_seq_cost now > provides too high a bound for if conversion, allowing very costly > substitutions. > > The

  1   2   >