Re: [PATCH improve early strlen range folding (PR 83671)

2018-01-10 Thread Martin Sebor
On 01/10/2018 06:30 PM, H.J. Lu wrote: On Sat, Jan 6, 2018 at 2:04 PM, Martin Sebor wrote: Bug 83671 - Fix for false positive reported by -Wstringop-overflow does not work at -O1, points out that the string length range optimization implemented as a solution for bug 83373

Re: std::vector default default and move constructors

2018-01-10 Thread Marc Glisse
On Thu, 11 Jan 2018, Marc Glisse wrote: On Thu, 11 Jan 2018, François Dumont wrote: - void _M_swap_data(_Vector_impl& __x) _GLIBCXX_NOEXCEPT + void + _M_swap_data(_Vector_impl_data& __x) _GLIBCXX_NOEXCEPT { std::swap(_M_start, __x._M_start);

Re: PR83648

2018-01-10 Thread Prathamesh Kulkarni
On 11 January 2018 at 10:34, Prathamesh Kulkarni wrote: > On 11 January 2018 at 04:50, Jeff Law wrote: >> On 01/09/2018 05:57 AM, Prathamesh Kulkarni wrote: >>> >>> As Jakub pointed out for the case: >>> void *f() >>> { >>> return

Re: PR83648

2018-01-10 Thread Prathamesh Kulkarni
On 11 January 2018 at 04:50, Jeff Law wrote: > On 01/09/2018 05:57 AM, Prathamesh Kulkarni wrote: >> >> As Jakub pointed out for the case: >> void *f() >> { >> return __builtin_malloc (0); >> } >> >> The malloc propagation would set f() to malloc. >> However AFAIU, malloc(0)

Re: PR83648

2018-01-10 Thread Marc Glisse
On Tue, 9 Jan 2018, Prathamesh Kulkarni wrote: As Jakub pointed out for the case: void *f() { return __builtin_malloc (0); } The malloc propagation would set f() to malloc. However AFAIU, malloc(0) returns NULL (?) and the function shouldn't be marked as malloc ? Why not? Even for

Re: std::vector default default and move constructors

2018-01-10 Thread Marc Glisse
On Thu, 11 Jan 2018, François Dumont wrote: - void _M_swap_data(_Vector_impl& __x) _GLIBCXX_NOEXCEPT + void + _M_swap_data(_Vector_impl_data& __x) _GLIBCXX_NOEXCEPT { std::swap(_M_start, __x._M_start); std::swap(_M_finish, __x._M_finish);

Re: [PATCH improve early strlen range folding (PR 83671)

2018-01-10 Thread H.J. Lu
On Sat, Jan 6, 2018 at 2:04 PM, Martin Sebor wrote: > Bug 83671 - Fix for false positive reported by -Wstringop-overflow > does not work at -O1, points out that the string length range > optimization implemented as a solution for bug 83373 doesn't help > at -O1. The root cause

Re: std::vector default default and move constructors

2018-01-10 Thread François Dumont
Hi     Here is an updated patch.     Tested under Linux x86_64.     Ok to commit ? François On 21/08/2017 21:15, François Dumont wrote: Following feedback on std::list patch this one had the same problem of unused code being deleted. So here is a new version. Ok to commit ? François On

libgo patch committed: Fix handling of DW_FORM_strp for 64-bit DWARF

2018-01-10 Thread Ian Lance Taylor
This libgo patch fixes the handling of DW_FORM_strp when using 64-bit DWARF. This is an early backport of https://golang.org/cl/84379, which will be in Go 1.11. Backporting now for AIX support in gccgo. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index:

Re: [PATCH, rs6000] generate loop code for memcmp inline expansion

2018-01-10 Thread Szabolcs Nagy
On 08/01/18 19:37, Aaron Sawdey wrote: > On Tue, 2017-12-12 at 10:13 -0600, Segher Boessenkool wrote: >> > Please fix those trivialities, and it's okay for trunk (after the >> > rtlanal patch is approved too). Thanks! > Here's the final version of this, which is committed as 256351. > > >

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Ian Lance Taylor
On Sun, Dec 17, 2017 at 4:38 AM, John Paul Adrian Glaubitz wrote: > > This is the second version of my patch to add support for SuperH > in libgo. The changes over my first patch in [1] are: > > * account for little- and big-endian targets > * account for sh3- and

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread John Paul Adrian Glaubitz
On 01/10/2018 03:25 PM, Ian Lance Taylor wrote: Thanks. I finally took a look at this. I don't know much about SH, but I don't think we want to add each SH variant as a separate GOARCH value. As you can see from the list you modified in ibgo/go/go/build/syslist.go, the difference between

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 6:00 AM, Uros Bizjak wrote: > On Wed, Jan 10, 2018 at 2:37 PM, Ian Lance Taylor wrote: >> On Wed, Jan 10, 2018 at 5:35 AM, Ian Lance Taylor wrote: >>> On Tue, Jan 9, 2018 at 11:34 PM, Uros Bizjak

[PATCH] Fix PR82425

2018-01-10 Thread Richard Biener
Tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-01-10 Richard Biener PR debug/82425 * gcc.dg/guality/inline-params-2.c: Un-XFAIL for slim LTO. Index: gcc/testsuite/gcc.dg/guality/inline-params-2.c

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread John Paul Adrian Glaubitz
On 01/10/2018 03:40 PM, Ian Lance Taylor wrote: The main purpose of a GOARCH value is to specify build targets, which are the +build lines seen in files like libgo/go/internal/syscall/unix/getrandom_linux_mipsx.go. They also appear in file names. It seems to me unlikely that it will ever be

[PATCH] Fix PR82770

2018-01-10 Thread Richard Biener
Applied. Richard. 2018-01-10 Richard Biener PR testsuite/78768 * gcc.dg/pr78768.c: Un-XFAIL. Index: gcc/testsuite/gcc.dg/pr78768.c === --- gcc/testsuite/gcc.dg/pr78768.c (revision

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 6:30 AM, Oleg Endo wrote: > On Wed, 2018-01-10 at 06:25 -0800, Ian Lance Taylor wrote: >> >> Thanks. I finally took a look at this. I don't know much about SH, >> but I don't think we want to add each SH variant as a separate GOARCH >> value. As

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread John Paul Adrian Glaubitz
On 01/10/2018 03:51 PM, Ian Lance Taylor wrote: I suppose I shouldn't have said calling convention, as that cuts too finely. There are similar issues with MIPS and even x86 has softfloat variants. Those options are selectable via command line options in GCC, and in the gc toolchain they are

Re: [C++ Patch] PR 81055 ("[6/7/8 Regression] ICE with invalid initializer for array new")

2018-01-10 Thread Jason Merrill
OK. On Thu, Dec 21, 2017 at 2:21 PM, Paolo Carlini wrote: > Hi, > > On 21/12/2017 17:04, Jason Merrill wrote: >> >> On Wed, Dec 20, 2017 at 10:37 AM, Paolo Carlini >> wrote: >>> >>> in this error recovery regression, after a sensible error

Re: [PATCH][arm][1/3] Add -march=armv8.4-a option

2018-01-10 Thread Kyrill Tkachov
Hi Christophe, On 10/01/18 10:50, Christophe Lyon wrote: Hi Kyrill, On 8 January 2018 at 18:55, Kyrill Tkachov wrote: [resending due to mailer problems...] Hi all, This patch adds support for the Armv8.4-A architecture [1] in the arm backend. This is done

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Oleg Endo
On Wed, 2018-01-10 at 06:25 -0800, Ian Lance Taylor wrote: >  > Thanks.  I finally took a look at this.  I don't know much about SH, > but I don't think we want to add each SH variant as a separate GOARCH > value.  As you can see from the list you modified in > ibgo/go/go/build/syslist.go, the

Re: [Patch][ARM] Add -mbranch-cost option, and update a few tests

2018-01-10 Thread Jakub Jelinek
On Mon, Oct 23, 2017 at 02:30:24PM +0200, Christophe Lyon wrote: > After Jakub's suggestion in PR82120 and PR81184, the attached patch > adds the -mbranch-cost option to the ARM target. My understanding > is that it's intended to be used internally for testing and does not > require user-facing

[wwwdocs,avr] Mention PR83738 in release notes

2018-01-10 Thread Georg-Johann Lay
This patch adds a bit more the the avr section of the v8 release notes. Ok? Johann Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v retrieving revision 1.25 diff -r1.25 changes.html 240a241,246 > >

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 3:44 AM, Rainer Orth wrote: > > thanks. Testing has now concluded as well. x86 results are good (no > regressions except for cmd/internal/buildid which fails on Linux, too), > as are 64-bit sparc results. The cmd/internal/buildid test does

Re: [PATCH][RFC] Radically simplify emission of balanced tree for switch statements.

2018-01-10 Thread Martin Liška
On 01/10/2018 02:13 PM, Richard Biener wrote: > On Tue, Jan 9, 2018 at 7:29 PM, Jeff Law wrote: >> On 01/09/2018 07:43 AM, Martin Liška wrote: >>> On 09/20/2017 05:00 PM, Jeff Law wrote: On 09/20/2017 01:24 AM, Martin Liška wrote: > > Hello. > > Thank

Re: [gofrontend-dev] Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 6:34 AM, Ian Lance Taylor wrote: > > Thanks. I think https://golang.org/cl/87137 will fix it. Committed as follows. Ian Index: gcc/go/gofrontend/MERGE === --- gcc/go/gofrontend/MERGE

Re: [C++ Patch] PR 78344 ("ICE on invalid c++ code (tree check: expected tree_list, have error_mark in cp_check_const_attributes, at cp/decl2.c:1347")

2018-01-10 Thread Jason Merrill
On Fri, Dec 22, 2017 at 7:34 PM, Paolo Carlini wrote: > in this error recovery issue cp_check_const_attributes and more generally > cplus_decl_attributes have lots of troubles handling the error_mark_node > returned by cp_parser_std_attribute_spec_seq, as called by >

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 6:30 AM, John Paul Adrian Glaubitz wrote: > On 01/10/2018 03:25 PM, Ian Lance Taylor wrote: >> >> Thanks. I finally took a look at this. I don't know much about SH, >> but I don't think we want to add each SH variant as a separate GOARCH >>

[PATCH] rs6000: Wrap diff of immediates in const (PR83629)

2018-01-10 Thread Segher Boessenkool
In various of our 32-bit load_toc patterns we take the difference of two immediates (labels) as a term to something bigger; but this isn't canonical RTL, it needs to be wrapped in CONST. This fixes it. Tested on powerpc64-linux {-m32,-m64}. Committing. Segher 2018-01-10 Segher Boessenkool

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 5:42 AM, Ian Lance Taylor wrote: > > Whoops, there's a bug on big-endian 32-bit systems. I'm testing > https://golang.org/cl/87135. Committed as follows. Ian Index: gcc/go/gofrontend/MERGE

Re: [Patch][ARM] Add -mbranch-cost option, and update a few tests

2018-01-10 Thread Christophe Lyon
On 10 January 2018 at 15:44, Jakub Jelinek wrote: > On Mon, Oct 23, 2017 at 02:30:24PM +0200, Christophe Lyon wrote: >> After Jakub's suggestion in PR82120 and PR81184, the attached patch >> adds the -mbranch-cost option to the ARM target. My understanding >> is that it's

Re: C++ PATCH to stop folding constants to their values in convert_like_real

2018-01-10 Thread Jakub Jelinek
On Fri, Jun 09, 2017 at 03:46:41PM -0700, Jason Merrill wrote: > Something that was missed previously in the delayed folding work: > there's no good reason to be pulling values out of constants in > convert_like_real. Well, it breaks nontype10.C on 32-bit targets. Or, let's use a modified version

Re: [PATCH, rs6000] generate loop code for memcmp inline expansion

2018-01-10 Thread Aaron Sawdey
I'll check the runtime of that --- I added some test cases to memcmp- 1.c and probably it is now taking too long. I will revise it so it's no longer than it was before. Aaron On Wed, 2018-01-10 at 14:25 +, Szabolcs Nagy wrote: > On 08/01/18 19:37, Aaron Sawdey wrote: > > On Tue,

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 7:05 AM, John Paul Adrian Glaubitz wrote: > On 01/10/2018 03:51 PM, Ian Lance Taylor wrote: >> >> I suppose I shouldn't have said calling convention, as that cuts too >> finely. There are similar issues with MIPS and even x86 has softfloat >>

[PATCH] reduce runtime of gcc.dg/memcmp-1.c test

2018-01-10 Thread Aaron Sawdey
This brings it back not quite to where it was but a lot more reasonable than what I put into 256351. 2018-01-10 Aaron Sawdey * gcc.dg/memcmp-1.c: Reduce runtime to something reasonable. OK for trunk? Thanks, Aaron -- Aaron Sawdey, Ph.D.

Re: [PR/middle-end 81897] make tree-ssa-uninit.c handle longer sequences

2018-01-10 Thread Aldy Hernandez
>> @@ -671,11 +668,9 @@ convert_control_dep_chain_into_preds (vec >> *dep_chains, >> e = one_cd_chain[j]; >> guard_bb = e->src; >> gsi = gsi_last_bb (guard_bb); >> + /* Ignore empty BBs as they're basically forwarder blocks. */ >> if (gsi_end_p (gsi)) >> -

Re: [PATCH] Fix PR81968

2018-01-10 Thread Richard Biener
On January 10, 2018 6:28:57 PM GMT+01:00, Jeff Law wrote: >On 01/10/2018 03:05 AM, Richard Biener wrote: >> >> This joint work rewrites LTO debug section copying to not leave >> discarded sections around as SHT_NULL but to really discard them >> and deal with the fallout

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 7:43 AM, Rainer Orth wrote: > Hi Ian, > >> On Wed, Jan 10, 2018 at 3:44 AM, Rainer Orth >> wrote: >>> >>> thanks. Testing has now concluded as well. x86 results are good (no >>> regressions except for

PR81703 and Martin's fix for PR83501

2018-01-10 Thread Prathamesh Kulkarni
Hi, I have attached patch for PR81703 rebased on Martin's fix for PR83501 posted here since both had considerable overlaps: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00180.html The patch passes bootstrap+test on x86_64-unknown-linux-gnu and cross-tested on aarch64-*-*. Currently it fails to

Re: [PR 81616] Deferring FMA transformations in tight loops

2018-01-10 Thread Martin Jambor
Hello, I would really like to ping the FMA transformation prevention patch that I sent here in December, which, after incorporating a suggestion from Richi, re-base and re-testing, I re-post below. I really think that it should make into gcc 8 in some form, because the performance wins are

Re: [PATCH] Fix PR81968

2018-01-10 Thread Jeff Law
On 01/10/2018 03:05 AM, Richard Biener wrote: > > This joint work rewrites LTO debug section copying to not leave > discarded sections around as SHT_NULL but to really discard them > and deal with the fallout (remapping all remaining section references). > This is to avoid diagnostics from the

PR83775

2018-01-10 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR83775. Validation in progress. OK to commit if passes ? Thanks, Prathamesh 2018-01-11 Prathamesh Kulkarni PR target/83775 * config/arm/arm.c (arm_declare_function_name): Set arch_to_print if

Re: [PATCH] reduce runtime of gcc.dg/memcmp-1.c test

2018-01-10 Thread Jeff Law
On 01/10/2018 10:46 AM, Aaron Sawdey wrote: > This brings it back not quite to where it was but a lot more reasonable > than what I put into 256351. > > 2018-01-10 Aaron Sawdey > > * gcc.dg/memcmp-1.c: Reduce runtime to something reasonable. > > OK for

Re: [wwwdocs,avr] Mention PR83738 in release notes

2018-01-10 Thread Jeff Law
On 01/10/2018 07:48 AM, Georg-Johann Lay wrote: > This patch adds a bit more the the avr section of the v8 release notes. > > Ok? OK. jeff

Re: [PATCH][AArch64] Use LDP/STP in shrinkwrapping

2018-01-10 Thread Segher Boessenkool
On Tue, Jan 09, 2018 at 09:13:23PM -0800, Andrew Pinski wrote: > On Tue, Jan 9, 2018 at 6:54 AM, Segher Boessenkool > wrote: > > On Tue, Jan 09, 2018 at 12:23:42PM +, Wilco Dijkstra wrote: > >> Segher Boessenkool wrote: > >> > On Mon, Jan 08, 2018 at 0:25:47PM

Re: [PATCH] libgo: add missing prototypes (PR 82922)

2018-01-10 Thread Ian Lance Taylor
On Thu, Jan 4, 2018 at 6:53 PM, Martin Sebor wrote: > > PR 82922 asks to enable -Wstrict-prototypes. The attached > patch handles the errors in an x86_64 bootstrap. With it, > GCC bootstraps successfully with --enable-languages=all,jit, > but there are many FAILs in the test

Re: C++ PATCH to fix bogus warning with a non-type argument (PR c++/82541)

2018-01-10 Thread Jason Merrill
OK. On Tue, Jan 2, 2018 at 9:51 AM, Marek Polacek wrote: > This PR complains about a bogus -Wduplicated-branches warning with a non-type > template argument. That can be easily fixed with a new sentinel. I also > noticed a missing tf_warning warning check, so I added it for

Re: [PATCH][arm][1/3] Add -march=armv8.4-a option

2018-01-10 Thread Christophe Lyon
Hi Kyrill, On 8 January 2018 at 18:55, Kyrill Tkachov wrote: > [resending due to mailer problems...] > > Hi all, > > This patch adds support for the Armv8.4-A architecture [1] > in the arm backend. This is done through the new > -march=armv8.4-a option. > > With

[PATCH] Fix PR83765

2018-01-10 Thread Richard Biener
The following fixes LTO bootstrap with Ada enabled which currently fails in the attribute duplicate sanity checking I added last year. The reason is we end up with a BLOCK_NONLOCALIZED_VARS function decl inlined somewhere (thus has received a self-origin from dwarf2out) and referenced in a

Re: [PATCH] PR 84740 Wrong string length type in bounds check

2018-01-10 Thread Jakub Jelinek
On Wed, Jan 10, 2018 at 01:18:46PM +0200, Janne Blomqvist wrote: Thanks for fixing this PR. > @@ -1562,7 +1562,8 @@ gfc_trans_array_ctor_element (stmtblock_t * pblock, > tree desc, > if (first_len) > { > gfc_add_modify (>pre, first_len_val, > -

Re: [PATCH] PR 84740 Wrong string length type in bounds check

2018-01-10 Thread Janne Blomqvist
On Wed, Jan 10, 2018 at 1:21 PM, Jakub Jelinek wrote: > On Wed, Jan 10, 2018 at 01:18:46PM +0200, Janne Blomqvist wrote: > > Thanks for fixing this PR. > >> @@ -1562,7 +1562,8 @@ gfc_trans_array_ctor_element (stmtblock_t * pblock, >> tree desc, >> if (first_len) >>

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-10 Thread H.J. Lu
On Wed, Jan 10, 2018 at 2:18 AM, Eric Botcazou wrote: >> It's really just a couple of new primitives to emit a jump as a call and >> one to slam in a new return address. Given those I think you can do the >> entire implementation as RTL at expansion time and you've got a

[PATCH] PR 84740 Wrong string length type in bounds check

2018-01-10 Thread Janne Blomqvist
Need to convert the RHS to the type of the LHS when assigning. Regtested on x86_64-pc-linux-gnu, committed as obvious. gcc/fortran/ChangeLog: 2018-01-10 Janne Blomqvist PR fortran/84740 * trans-array.c (gfc_trans_array_ctor_element): Convert RHS to the

Re: [PATCH] Fix PR81968

2018-01-10 Thread Rainer Orth
Hi Richard, > This joint work rewrites LTO debug section copying to not leave > discarded sections around as SHT_NULL but to really discard them > and deal with the fallout (remapping all remaining section references). > This is to avoid diagnostics from the Solaris linker which doesn't > like

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Rainer Orth
Hi Ian, >> the patch broke Solaris bootstrap: >> >> mv: cannot stat 'os/signal/internal/pty.s-gox.tmp': No such file or directory >> make[4]: *** [Makefile:3348: os/signal/internal/pty.s-gox] Error 1 >> make[4]: *** Waiting for unfinished jobs >> >> Fixed trivially as follows, which allowed

[PATCH] __VA_OPT__ fixes (PR preprocessor/83063, PR preprocessor/83708)

2018-01-10 Thread Jakub Jelinek
Hi! In libcpp, we have quite a lot of state on the token flags, some related to the stuff that comes before the token (e.g. PREV_FALLTHROUGH, PREV_WHITE and STRINGIFY_ARG), others related to the stuff that comes after the token (e.g. PASTE_LEFT, SP_DIGRAPH, SP_PREV_WHITE). Unfortunately, with the

[PATCH] Fix PR81968

2018-01-10 Thread Richard Biener
This joint work rewrites LTO debug section copying to not leave discarded sections around as SHT_NULL but to really discard them and deal with the fallout (remapping all remaining section references). This is to avoid diagnostics from the Solaris linker which doesn't like those. LTO bootstrapped

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-10 Thread Eric Botcazou
> It's really just a couple of new primitives to emit a jump as a call and > one to slam in a new return address. Given those I think you can do the > entire implementation as RTL at expansion time and you've got a damn > good shot at protecting most architectures from these kinds of attacks. I

Re: [PATCH PR82096] Fix ICE in int_mode_for_mode, at stor-layout.c:403 with arm-linux-gnueabi

2018-01-10 Thread Sudakshina Das
Hi Jeff On 09/01/18 23:43, Jeff Law wrote: On 01/05/2018 12:25 PM, Sudakshina Das wrote: Hi Jeff On 05/01/18 18:44, Jeff Law wrote: On 01/04/2018 08:35 AM, Sudakshina Das wrote: Hi The bug reported a particular test di-longlong64-sync-1.c failing when run on arm-linux-gnueabi with options

RE: [PATCH] Fix various x86 avx512{bitalg,vpopcntdq,vbmi2} issues (PR target/83488)

2018-01-10 Thread Koval, Julia
Hi, What do you think about changing these types to UHI_FTYPE_V16QI_V16QI_UHI and so on? In docs it is (KL, VL) = (16,128), (32,256), (64, 512) - so looks like this is where the error was from the start. Here is the patch. Thanks, Julia > -Original Message- > From: Koval, Julia >

Avoid ICE in PR83575

2018-01-10 Thread Jan Hubicka
Hi, this is the secodn half of fix for PR83575 which avoids ICE in the quite rare scenarios bb-reorder produces fixable partition but we can't fix it because bb order is already fixed :) This is done by skipping verification during this transition and enforcing this missed optimization check only

libgo patch committed: Add SH support

2018-01-10 Thread Ian Lance Taylor
This libgo patch by John Paul Adrian Glaubitz adds SH support to libgo. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu, which I admit doesn't prove much. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === ---

Re: [PATCH, rs6000] Fix PR83399, ICE During LRA with 2-op rtl pattern for lvx instruction

2018-01-10 Thread Segher Boessenkool
On Tue, Jan 09, 2018 at 12:22:38PM -0600, Peter Bergner wrote: > PR83399 shows a problem where we emit an altivec load using a builtin > that forces us to use a specific altivec load pattern. The generated > rtl pattern has a use of sfp (frame pointer) and during LRA, we eliminate > it's use to

Re: [1/4] [AArch64] SVE backend support

2018-01-10 Thread Richard Sandiford
Thanks for the review! James Greenhalgh writes: > On Fri, Jan 05, 2018 at 11:41:25AM +, Richard Sandiford wrote: >> Here's the patch updated to apply on top of the v8.4 and >> __builtin_load_no_speculate support. It also handles the new >> vec_perm_indices and

[PATCH], Add checks for -mlong-double-128 in PowerPC ibm/float128 code

2018-01-10 Thread Michael Meissner
As I add support for making -mabi=ieeelongdouble default, I noticed some issues in building libstdc++ with the default for the code that supports the -mlong-double-64 option. These tests add checks for -mlong-double-128 before considering whether TFmode/TCmode are IEEE or IBM extended double. I

Re: [PATCH, rs6000] Fix PR83399, ICE During LRA with 2-op rtl pattern for lvx instruction

2018-01-10 Thread Segher Boessenkool
Hi, On Wed, Jan 10, 2018 at 01:55:34PM -0600, Peter Bergner wrote: > >> @@ -570,7 +570,7 @@ (define_split > >> ;; The post-reload split requires that we re-permute the source > >> ;; register in case it is still live. > >> (define_split > >> - [(set (match_operand:VSX_D 0 "memory_operand" "")

Re: [PR 81616] Deferring FMA transformations in tight loops

2018-01-10 Thread Jeff Law
On 01/10/2018 11:46 AM, Martin Jambor wrote: > Hello, > > I would really like to ping the FMA transformation prevention patch that > I sent here in December, which, after incorporating a suggestion from > Richi, re-base and re-testing, I re-post below. I really think that it > should make into

Re: Fix folding of Inf/NaN comparisons for -ftrapping-math (PR tree-optimization/64811)

2018-01-10 Thread Bernhard Reutner-Fischer
Joseph, On Sat, Jan 06, 2018 at 08:45:33AM +0100, Richard Biener wrote: > On January 5, 2018 10:13:34 PM GMT+01:00, Joseph Myers > wrote: > >unrelated. OK to commit? > > OK. > > Richard. > >Index: gcc/match.pd >

libgo patch committed: Handle _st_timespec for AIX stat

2018-01-10 Thread Ian Lance Taylor
The AIX stat function apparently uses an _st_timespec type. This libgo patch by Tony Reix handles that correctly. Bootstrapped on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === ---

Re: [PATCH, rs6000] Fix PR83399, ICE During LRA with 2-op rtl pattern for lvx instruction

2018-01-10 Thread Peter Bergner
On 1/10/18 1:44 PM, Segher Boessenkool wrote: > On Tue, Jan 09, 2018 at 12:22:38PM -0600, Peter Bergner wrote: >> * config/rs6000/rs6000.c (print_operand): Use >> VECTOR_MEM_ALTIVEC_OR_VSX_P. > > (print_operand) <'y'>: ... Will fix. >> * config/rs6000/vsx.md

RE: [PATCH 5/5][AArch64] fp16fml support

2018-01-10 Thread Michael Collison
Okay will put on my to-do list for post GCC 8. -Original Message- From: James Greenhalgh [mailto:james.greenha...@arm.com] Sent: Wednesday, January 10, 2018 12:21 PM To: Michael Collison Cc: Richard Sandiford ; GCC Patches

Re: [PATCH] MicroBlaze use default ident output generation

2018-01-10 Thread Jeff Law
On 01/09/2018 01:26 AM, Nathan Rossi wrote: > On 18 November 2017 at 22:13, Nathan Rossi wrote: >> On 18 November 2017 at 04:25, Jeff Law wrote: >>> On 11/15/2017 11:58 PM, Nathan Rossi wrote: Remove the MicroBlaze specific TARGET_ASM_OUTPUT_IDENT

Re: [1/4] [AArch64] SVE backend support

2018-01-10 Thread James Greenhalgh
On Fri, Jan 05, 2018 at 11:41:25AM +, Richard Sandiford wrote: > Here's the patch updated to apply on top of the v8.4 and > __builtin_load_no_speculate support. It also handles the new > vec_perm_indices and CONST_VECTOR encoding and uses VNx... names > for the SVE modes. > > Richard

Re: PR83775

2018-01-10 Thread Martin Sebor
On 01/10/2018 12:01 PM, Prathamesh Kulkarni wrote: Hi, The attached patch tries to fix PR83775. Validation in progress. OK to commit if passes ? FWIW, the patch makes sense to me as it simplifies things for me when debugging using a cross-compiler. I reported the same ICE in bug 83775 and it

[committed] Preserving locations for variable-uses and constants (PR c++/43486)

2018-01-10 Thread David Malcolm
All of the various parts of this kit have now been approved; I've committed it to trunk as r256448. (The initial version of the kit was posted 2017-10-20, and the followup on 2017-11-10, both in stage 1; the final patch approval was 2018-01-09, towards the end of stage 3). Successfully

Re: Fix folding of Inf/NaN comparisons for -ftrapping-math (PR tree-optimization/64811)

2018-01-10 Thread Joseph Myers
On Wed, 10 Jan 2018, Bernhard Reutner-Fischer wrote: > > >+ /* x <= +Inf is the same as x == x, i.e. !isnan(x), but this loses > > >+ an "invalid" exception. */ > > >+ (if (!flag_trapping_math) > > >+ (eq @0 @0 > > >+ /* x == +Inf and x >= +Inf are always equal to x > DBL_MAX,

[PATCH] suppress -Wstringop-overflow when no-warning is set (PR 83508)

2018-01-10 Thread Martin Sebor
To avoid issuing duplicate warnings for the same function call in the source code the -Wrestrict warning code makes sure the no-warning bit is propagated between trees and GIMPLE and tested before issuing a warning. But the warning also detects some of the same problems as -Wstringop-overflow,

Re: Fix folding of Inf/NaN comparisons for -ftrapping-math (PR tree-optimization/64811)

2018-01-10 Thread Bernhard Reutner-Fischer
On Wed, Jan 10, 2018 at 08:17:08PM +, Joseph Myers wrote: > On Wed, 10 Jan 2018, Bernhard Reutner-Fischer wrote: > > > > >+/* x <= +Inf is the same as x == x, i.e. !isnan(x), but this > > > >loses > > > >+ an "invalid" exception. */ > > > >+(if

Re: [PATCH 5/5][AArch64] fp16fml support

2018-01-10 Thread James Greenhalgh
On Tue, Jan 09, 2018 at 06:28:09PM +, Michael Collison wrote: > Patch updated per Richard's comments. Ok for trunk? This patch adds a lot of code, much of which looks like it ought to be possible to common up using the iterators. I'm going to OK it as is, as I'd like to see this make GCC 8,

Re: [PATCH improve early strlen range folding (PR 83671)

2018-01-10 Thread Jeff Law
On 01/06/2018 03:04 PM, Martin Sebor wrote: > Bug 83671 - Fix for false positive reported by -Wstringop-overflow > does not work at -O1, points out that the string length range > optimization implemented as a solution for bug 83373 doesn't help > at -O1.  The root cause is that the fix was added 

Re: [C++ Patch] PR 78344 ("ICE on invalid c++ code (tree check: expected tree_list, have error_mark in cp_check_const_attributes, at cp/decl2.c:1347")

2018-01-10 Thread Paolo Carlini
Hi, On 10/01/2018 17:58, Jason Merrill wrote: On Wed, Jan 10, 2018 at 11:33 AM, Paolo Carlini wrote: Hi, On 10/01/2018 16:32, Jason Merrill wrote: On Fri, Dec 22, 2017 at 7:34 PM, Paolo Carlini wrote: in this error recovery issue

Re: [PATCH, rs6000] Change x86 intrinsic compat headers to use #error

2018-01-10 Thread Segher Boessenkool
On Tue, Jan 09, 2018 at 04:09:25PM -0600, Peter Bergner wrote: > The following patch changes the x86 intrinsic compat headers to use #error > instead of #warning. We do this for two reasons. Firstly, we want the user > to really be sure they want/need to use the x86 intrinsic compat support >

Re: [PATCH, rs6000] Change x86 intrinsic compat headers to use #error

2018-01-10 Thread Peter Bergner
On 1/10/18 2:14 PM, Segher Boessenkool wrote: > On Tue, Jan 09, 2018 at 04:09:25PM -0600, Peter Bergner wrote: >> The following patch changes the x86 intrinsic compat headers to use #error >> instead of #warning. We do this for two reasons. Firstly, we want the user >> to really be sure they

[PATCH] i386: Align stack frame if argument is passed on stack

2018-01-10 Thread H.J. Lu
When a function call is removed, it may become a leaf function. But if argument may be passed on stack, we need to align the stack frame when there is no tail call. Tested on Linux/i686 and Linux/x86-64. OK for trunk? H.J. --- gcc/ PR target/83330 * config/i386/i386.c

Re: [PATCH][arm][1/3] Add -march=armv8.4-a option

2018-01-10 Thread Christophe Lyon
On 10 January 2018 at 12:05, Kyrill Tkachov wrote: > Hi Christophe, > > > On 10/01/18 10:50, Christophe Lyon wrote: >> >> Hi Kyrill, >> >> >> On 8 January 2018 at 18:55, Kyrill Tkachov >> wrote: >>> >>> [resending due to mailer

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 3:44 AM, Rainer Orth wrote: > >>> the patch broke Solaris bootstrap: >>> >>> mv: cannot stat 'os/signal/internal/pty.s-gox.tmp': No such file or >>> directory >>> make[4]: *** [Makefile:3348: os/signal/internal/pty.s-gox] Error 1 >>>

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-10 Thread H.J. Lu
On Wed, Jan 10, 2018 at 5:14 AM, Jakub Jelinek wrote: > On Wed, Jan 10, 2018 at 02:08:48PM +0100, Richard Biener wrote: >> On Wed, Jan 10, 2018 at 11:18 AM, Eric Botcazou >> wrote: >> >> It's really just a couple of new primitives to emit a jump as a

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-10 Thread Richard Biener
On Wed, Jan 10, 2018 at 11:18 AM, Eric Botcazou wrote: >> It's really just a couple of new primitives to emit a jump as a call and >> one to slam in a new return address. Given those I think you can do the >> entire implementation as RTL at expansion time and you've got a

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 5:35 AM, Ian Lance Taylor wrote: > On Tue, Jan 9, 2018 at 11:34 PM, Uros Bizjak wrote: >>> This patch updates libgo to the Go1.10beta1 release. The final Go >>> 1.10 release is expected around February 1, so it's not clear how the >>>

Re: [PATCH][AArch64] Improve aarch64_legitimate_constant_p

2018-01-10 Thread Jakub Jelinek
On Mon, Nov 06, 2017 at 01:50:07PM +, Wilco Dijkstra wrote: > Richard Sandiford wrote: > > > > Yeah, I'd hit this too.  I think it's a latent bug that just > > happened to be exposed by Wilco's patch: although the *movti_aarch64 > > predicate disallows const_wide_int, the constraints allow it

Re: Don't use permutes for single-element accesses (PR83753)

2018-01-10 Thread Richard Biener
On Tue, Jan 9, 2018 at 10:59 PM, Richard Sandiford wrote: > After cunrolling the inner loop, the remaining loop in the testcase > has a single 32-bit access and a group of 64-bit accesses. We first > try to vectorise at 128 bits (VF 4), but decide not to for cost

Re: Add support for in-order addition reduction using SVE FADDA

2018-01-10 Thread Richard Biener
On Tue, Jan 9, 2018 at 4:36 PM, Richard Sandiford wrote: > Ping Ok. Richard. > Richard Sandiford writes: >> Richard Biener writes: >>> On Mon, Nov 20, 2017 at 1:54 PM, Richard Sandiford >>>

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Ian Lance Taylor
On Tue, Jan 9, 2018 at 11:34 PM, Uros Bizjak wrote: >> This patch updates libgo to the Go1.10beta1 release. The final Go >> 1.10 release is expected around February 1, so it's not clear how the >> release timing is going to work with GCC 8. In any case this updates >> GCC to

Re: [PATCH] PR 78534, 83704 Large character lengths

2018-01-10 Thread Dominique d'Humières
Hi Janne, With this patch, bootstrap fails with ../../work/gcc/fortran/array.c: In function 'bool gfc_resolve_character_array_constructor(gfc_expr*)': ../../work/gcc/fortran/array.c:2062:36: error: unknown conversion type character 'l' in format [-Werror=format=] current_length,

Re: Go patch committed: Update to Go1.10beta1

2018-01-10 Thread Uros Bizjak
On Wed, Jan 10, 2018 at 2:37 PM, Ian Lance Taylor wrote: > On Wed, Jan 10, 2018 at 5:35 AM, Ian Lance Taylor wrote: >> On Tue, Jan 9, 2018 at 11:34 PM, Uros Bizjak wrote: This patch updates libgo to the Go1.10beta1 release. The final Go

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-10 Thread Jakub Jelinek
On Wed, Jan 10, 2018 at 02:08:48PM +0100, Richard Biener wrote: > On Wed, Jan 10, 2018 at 11:18 AM, Eric Botcazou wrote: > >> It's really just a couple of new primitives to emit a jump as a call and > >> one to slam in a new return address. Given those I think you can do

Re: [PATCH][RFC] Radically simplify emission of balanced tree for switch statements.

2018-01-10 Thread Richard Biener
On Tue, Jan 9, 2018 at 7:29 PM, Jeff Law wrote: > On 01/09/2018 07:43 AM, Martin Liška wrote: >> On 09/20/2017 05:00 PM, Jeff Law wrote: >>> On 09/20/2017 01:24 AM, Martin Liška wrote: >>> Hello. Thank you Jeff for very verbose explanation what's happening.

libgo patch committed: Remove old exp packages

2018-01-10 Thread Ian Lance Taylor
This libgo patch removes the exp/proxy and exp/terminal packages. The exp/proxy package was removed from the master library in https://golang.org/cl/6461056 (August, 2012). The exp/terminal package was removed from the master library in https://golang.org/cl/5970044 (March, 2012). I'm not sure

Re: [C++ Patch] PR 78344 ("ICE on invalid c++ code (tree check: expected tree_list, have error_mark in cp_check_const_attributes, at cp/decl2.c:1347")

2018-01-10 Thread Paolo Carlini
Hi, On 10/01/2018 16:32, Jason Merrill wrote: On Fri, Dec 22, 2017 at 7:34 PM, Paolo Carlini wrote: in this error recovery issue cp_check_const_attributes and more generally cplus_decl_attributes have lots of troubles handling the error_mark_node returned by

Re: [C++ PATCH] Fix some -Wused-but-set-variable regressions (PR c++/82728, PR c++/82799, PR c++/83690)

2018-01-10 Thread Jakub Jelinek
On Wed, Jan 10, 2018 at 11:52:16AM -0500, Jason Merrill wrote: > On Fri, Jan 5, 2018 at 5:14 PM, Jakub Jelinek wrote: > > Jason's recent change removed a mark_rvalue_use call from constant_value_1, > > which unfortunately regressed quite a few cases where > >

  1   2   >