Re: [Arm] GCC crash in cprop_hardreg when targeting v8-A Thumb

2018-02-05 Thread Kyrill Tkachov
Hi Michael, On 04/02/18 02:52, Michael Collison wrote: This patches fixes a bug affecting two patterns in arm/thumb2.md where the split condition was insufficient and allowed illegal rtl to be generated. The split condition for patterns "*thumb2_mov_negscc "and "*thumb_mov_notscc " allowed

[committed][AArch64] Remove SVE XFAILs

2018-02-05 Thread Richard Sandiford
These tests started passing after r257293, which had the side-effect of renumbering the SSA names and leaving the COND_EXPRs in their natural order. This does show a deeper underlying issue that code generation is too sensitive to internal things like SSA_NAME versions, but it no longer affects

Re: [PATCH] PowerPC PR target/84154, fix floating point to small integer conversion regression

2018-02-05 Thread Michael Meissner
On Mon, Feb 05, 2018 at 05:57:25AM -0600, Segher Boessenkool wrote: > On Thu, Feb 01, 2018 at 02:31:17PM -0500, Michael Meissner wrote: > > This patch fixes the optimization regression that occurred on GCC 7 where > > conversions from the various floating point types to small integers would at > >

[PATCH] Cherry-pick libsanitizer pointer-pair tristate option.

2018-02-05 Thread Martin Liška
Hi. This is upstream backport of libsanitizer which makes detect-invalid-pointer-pair a tristate option. Patch is preapproved by Jakub. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Martin gcc/ChangeLog: 2018-02-05 Martin Liska *

Re: [PATCH] PowerPC PR target/84154, fix floating point to small integer conversion regression

2018-02-05 Thread Segher Boessenkool
On Thu, Feb 01, 2018 at 02:31:17PM -0500, Michael Meissner wrote: > This patch fixes the optimization regression that occurred on GCC 7 where > conversions from the various floating point types to small integers would at > times generate a store and a load. [ snip big explanation; thanks for

[patch][i386] Adding pconfig, wbnoinvd and wbinvd intrinsics

2018-02-05 Thread Makhotina, Olga
Hi, This patch adds new intrinsics: pconfig, wbnoinvd and wbinvd. 05.02.2018 Olga Makhotina  gcc/ * common/config/i386/i386-common.c (OPTION_MASK_ISA_PCONFIG_SET, OPTION_MASK_ISA_PCONFIG_UNSET, OPTION_MASK_ISA_WBNOINVD_SET,

[PATCH][OBVIOUS] Fix GCOV documentation (PR gcov-profile/84137).

2018-02-05 Thread Martin Liška
Hello. Very simple patch fixes documentation. I'm going to install it to all active branches. Martin gcc/ChangeLog: 2018-02-05 Martin Liska PR gcov-profile/84137 * doc/gcov.texi: Fix typo in documentation. --- gcc/doc/gcov.texi | 2 +- 1 file changed, 1

[PATCH][GCC][ARM] Silence ARM_ARCH redefinition warning and keep better track of architecturs already emitted.

2018-02-05 Thread Tamar Christina
Hi All, This patch silences the warnings that were emitted when certain ACLE macros were being redefined when using the new target pragma or attribute to change architecture level. It also keeps better track of which arch directives have already been emitted. This allows special cases that

Re: [patch, libfortran] Use flexible array members for array descriptor

2018-02-05 Thread Janne Blomqvist
On Sun, Feb 4, 2018 at 9:49 PM, Thomas Koenig wrote: > Hello world, > > in the attached patch, I have used flexible array members for > using the different descriptor types (following Richi's advice). > This does not change the binary ABI, but the library code > maches what

Re: [PATCH] Fix PR83008

2018-02-05 Thread Christophe Lyon
On 31 January 2018 at 16:01, Richard Biener wrote: > On Wed, 31 Jan 2018, Christophe Lyon wrote: > > > On 30 January 2018 at 11:47, Jakub Jelinek wrote: > > > On Tue, Jan 30, 2018 at 11:07:50AM +0100, Richard Biener wrote: > > >> > > >> I have been asked to

Do not lose track of resolution info due to tree merging

2018-02-05 Thread Jan Hubicka
Hi, in the testcase of PR81004 we produce wrong code (reference to optimized out comdat symbol) due to strange sequence of events that is initiated by fact that after streaming in a comdat group we sed one of resolution infos to LDPR_UNKNOWN. This is because of tree merging with earlier unit that

Re: [PATCH] PowerPC PR target/84154, fix floating point to small integer conversion regression

2018-02-05 Thread Segher Boessenkool
On Mon, Feb 05, 2018 at 07:54:58AM -0500, Michael Meissner wrote: > On Mon, Feb 05, 2018 at 05:57:25AM -0600, Segher Boessenkool wrote: > > On Thu, Feb 01, 2018 at 02:31:17PM -0500, Michael Meissner wrote: > > > This patch fixes the optimization regression that occurred on GCC 7 where > > >

Re: C++ PATCH to fix rejects-valid with constexpr ctor in C++17 (PR c++/83692)

2018-02-05 Thread Marek Polacek
On Fri, Feb 02, 2018 at 02:11:27PM -0500, Jason Merrill wrote: > On Thu, Jan 25, 2018 at 4:16 PM, Marek Polacek wrote: > > This is a similar problem to 83116: we'd cached a constexpr call, but after > > a > > store the result had become invalid, yet we used the wrong result

Re: [PATCH][i386] Fix ix86_loop_unroll_adjust

2018-02-05 Thread Jan Hubicka
Dne 2018-02-05 09:53, Richard Biener napsal: The following fixes an oversight(?) in ix86_loop_unroll_adjust which will happily bump unrolling to unreasonable amounts for bdverN. Bootstrap / regtest running on x86_64-unknown-linux-gnu, ok? OK, thanks! Honza

RFA: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-05 Thread Nick Clifton
Hi H.J. Attached is a potential patch for PR 84145: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84145 The problem was that the code to check that the --mibt and/or -mshstk options have been correctly enabled for control flow protection did not take into account that the wrong option

Go patch committed: Avoid negative zero in float constants

2018-02-05 Thread Ian Lance Taylor
This patch to the Go frontend checks for negative numbers with very small magnitudes that will round to negative zero, and forces them to positive zero instead. This implements the spec clarification in https://golang.org/cl/14727. The test is in https://golang.org/cl/91895. This fixes

Please accept this commit for the trunk

2018-02-05 Thread Douglas Mencken
I’m about “ [PATCH 2/4] [Darwin,PPC] Remove uses of LR in restore_world ” https://gcc.gnu.org/bugzilla/attachment.cgi?id=42304 look at bug #84113 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84113 for more info “ One important question ’s yet: Why this patch has been ignored despite it’s been

RFA: Sanitize deprecation messages (PR 84195)

2018-02-05 Thread Nick Clifton
Hi Martin, Hi Dodji, Hi David, PR 84195 makes the point that deprecation messages do not follow the formatting guidelines set out by the -fmessage-length option, and that they could even contain unwanted control characters: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84195 Below is

Re: Extend aligned_membuf<> usage

2018-02-05 Thread Jonathan Wakely
On 01/02/18 22:48 +0100, François Dumont wrote: Hi     As we just bump version namespace it might be interesting to do the following change now. What do you think ? I'd rather not make the code harder to read in all those places just for an optional mode that nobody uses. Wouldn't it make

[PATCH][i386] Fix ix86_loop_unroll_adjust

2018-02-05 Thread Richard Biener
The following fixes an oversight(?) in ix86_loop_unroll_adjust which will happily bump unrolling to unreasonable amounts for bdverN. Bootstrap / regtest running on x86_64-unknown-linux-gnu, ok? Thanks, Richard. 2018-02-05 Richard Biener * config/i386/i386.c

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-05 Thread Martin Sebor
On 02/05/2018 04:44 PM, Joseph Myers wrote: On Sun, 4 Feb 2018, Martin Sebor wrote: We've talked about (2) in the past (bug 71463) but this seems like an opportunity to revisit it and (hopefully) make a change to treat these the same as all other function attributes rather than type

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-05 Thread Joseph Myers
On Mon, 5 Feb 2018, Martin Sebor wrote: > On 02/05/2018 04:44 PM, Joseph Myers wrote: > > On Sun, 4 Feb 2018, Martin Sebor wrote: > > > > > We've talked about (2) in the past (bug 71463) but this seems > > > like an opportunity to revisit it and (hopefully) make a change > > > to treat these the

[PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-05 Thread Peter Bergner
PR83926 shows a problem in expanding the _builtin_vsx_{div,udiv,mul}_2di builtins in 32-bit mode. The problem is that the splitters for the patterns explicitly call gen_{div,udiv,mul}di3 patterns, even in 32-bit mode and those patterns assume the associated 64-bit HW instructions exist when they

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-05 Thread Joseph Myers
On Sun, 4 Feb 2018, Martin Sebor wrote: > We've talked about (2) in the past (bug 71463) but this seems > like an opportunity to revisit it and (hopefully) make a change > to treat these the same as all other function attributes rather > than type attributes. Besides fixing the wrong code bugs

Re: Do not lose track of resolution info due to tree merging

2018-02-05 Thread Richard Biener
On February 5, 2018 3:49:25 PM GMT+01:00, Jan Hubicka wrote: >Hi, >in the testcase of PR81004 we produce wrong code (reference to >optimized out >comdat symbol) due to strange sequence of events that is initiated by >fact >that after streaming in a comdat group we sed one of

Re: Go patch committed: Avoid negative zero in float constants

2018-02-05 Thread Rainer Orth
Hi Ian, > This patch to the Go frontend checks for negative numbers with very > small magnitudes that will round to negative zero, and forces them to > positive zero instead. This implements the spec clarification in > https://golang.org/cl/14727. The test is in > https://golang.org/cl/91895.

[testsuite] Make lto.exp work with Tcl 8.4

2018-02-05 Thread Richard Sandiford
"dict" was added in Tcl 8.5, but until a couple of weeks ago the testsuite has worked with 8.4. This patch uses arrays instead, like we do for the caching in target-supports.exp. It is a bit uglier than using dicts was, but hopefully not too bad... Tested on aarch64-linux-gnu and

[PATCH, rs6000] Deprecate -mno-speculate-indirect-jumps

2018-02-05 Thread Bill Schmidt
Hi, It's been determined that we won't recommend use of the recently added undocumented option -mno-speculate-indirect-jumps. This patch provides a warning indicating that the option is deprecated. We will leave the code in place for potential emergency use (not expected), and plan to remove it

Re: [PATCH, rs6000] Fix PR56010 and PR83743, -mcpu=native use wrong names

2018-02-05 Thread Peter Bergner
On 2/1/18 1:25 PM, Peter Bergner wrote: > On 2/1/18 8:50 AM, Segher Boessenkool wrote: >> I think we also want this for 7 (after a bit of burn in). I wouldn't >> bother with 6 though (the problem has existed since 4.7). > > Ok, committed. I'll wait a few days before committing the FSF 7 back

[PING #2] [PATCH] make -Wrestrict for strcat more meaningful (PR 83698)

2018-02-05 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01488.html As I mentioned, this doesn't solve a regression per se but rather implements what I consider an important usability improvement to the -Wrestrict warnings. Printing offsets that are the most meaningful makes debugging the problems

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-05 Thread David Edelsohn
Peter, Why can't you place the tests into the final condition of the pattern so that the pattern fails and the normal GCC fallback machinery is used instead of manually implementing the fallback emulation? The GPR iterator only defines DI for TARGET_POWERPC64, so how does GCC get into the muldi3

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-05 Thread Peter Bergner
On 2/5/18 7:32 PM, David Edelsohn wrote: > Peter, > > Why can't you place the tests into the final condition of the pattern > so that the pattern fails and the normal GCC fallback machinery is > used instead of manually implementing the fallback emulation? You mean something like the following

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-05 Thread Martin Sebor
On 02/05/2018 05:55 PM, Joseph Myers wrote: On Mon, 5 Feb 2018, Martin Sebor wrote: On 02/05/2018 04:44 PM, Joseph Myers wrote: On Sun, 4 Feb 2018, Martin Sebor wrote: We've talked about (2) in the past (bug 71463) but this seems like an opportunity to revisit it and (hopefully) make a

Re: [PATCH, rs6000] Fix PR83926, ICE using __builtin_vsx_{div,udiv,mul}_2di builtins

2018-02-05 Thread David Edelsohn
On Mon, Feb 5, 2018 at 9:43 PM, Peter Bergner wrote: > On 2/5/18 7:32 PM, David Edelsohn wrote: >> Peter, >> >> Why can't you place the tests into the final condition of the pattern >> so that the pattern fails and the normal GCC fallback machinery is >> used instead of

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-05 Thread Jason Merrill
On 02/04/2018 07:07 PM, Martin Sebor wrote: To resolve the underlying root cause of the P1 bug c++/83503 - bogus -Wattributes for const and pure on function template specialization, that we discussed last week, I've taken a stab at making the change to avoid applying primary template's

New Swedish PO file for 'gcc' (version 8.1-b20180128)

2018-02-05 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Swedish team of translators. The file is available at: http://translationproject.org/latest/gcc/sv.po (This file, 'gcc-8.1-b20180128.sv.po',

Re: [PATCH] PowerPC PR target/84154, fix floating point to small integer conversion regression

2018-02-05 Thread Michael Meissner
On Mon, Feb 05, 2018 at 08:01:32AM -0600, Segher Boessenkool wrote: > On Mon, Feb 05, 2018 at 07:54:58AM -0500, Michael Meissner wrote: > > On Mon, Feb 05, 2018 at 05:57:25AM -0600, Segher Boessenkool wrote: > > > On Thu, Feb 01, 2018 at 02:31:17PM -0500, Michael Meissner wrote: > > > > This patch

[PATCH] PR libgcc/59714 complex division is surprising on aarch64

2018-02-05 Thread vladimir . mezentsev
From: Vladimir Mezentsev Tested on aarch64-linux-gnu, x86_64-pc-linux-gnu and sparc64-unknown-linux-gnu. No regression. New tests now passed. There is a performance degradation for complex double type: failed cases |time old new

Re: [testsuite] Make lto.exp work with Tcl 8.4

2018-02-05 Thread Mike Stump
On Feb 5, 2018, at 9:54 AM, Richard Sandiford wrote: > > "dict" was added in Tcl 8.5, but until a couple of weeks ago the > testsuite has worked with 8.4. > > This patch uses arrays instead, like we do for the caching in > target-supports.exp. It is a bit uglier

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-05 Thread Martin Sebor
On 02/05/2018 10:07 AM, Nick Clifton wrote: Hi Martin, Hi Dodji, Hi David, PR 84195 makes the point that deprecation messages do not follow the formatting guidelines set out by the -fmessage-length option, and that they could even contain unwanted control characters:

Re: Go patch committed: Avoid negative zero in float constants

2018-02-05 Thread Ian Lance Taylor
On Mon, Feb 5, 2018 at 10:47 AM, Rainer Orth wrote: > >> This patch to the Go frontend checks for negative numbers with very >> small magnitudes that will round to negative zero, and forces them to >> positive zero instead. This implements the spec clarification in

Re: Go patch committed: Avoid negative zero in float constants

2018-02-05 Thread Rainer Orth
Hi Ian, >> unfortunately, this broke bootstrap with mpfr 2.4.2, which is still the >> minimum version documented in install.texi: > > Bother. Thanks for the note. I've rolled back the patch, as follows. thanks. I'm right now experimenting to bootstrap with the current versions. As I'd

Re: [patch, libfortran] Use flexible array members for array descriptor

2018-02-05 Thread Thomas Koenig
Am 05.02.2018 um 13:09 schrieb Janne Blomqvist: On Sun, Feb 4, 2018 at 9:49 PM, Thomas Koenig wrote: Hello world, in the attached patch, I have used flexible array members for using the different descriptor types (following Richi's advice). This does not change the

Re: C++ PATCH to fix rejects-valid with constexpr ctor in C++17 (PR c++/83692)

2018-02-05 Thread Jason Merrill
On Mon, Feb 5, 2018 at 8:37 AM, Marek Polacek wrote: > On Fri, Feb 02, 2018 at 02:11:27PM -0500, Jason Merrill wrote: >> On Thu, Jan 25, 2018 at 4:16 PM, Marek Polacek wrote: >> > This is a similar problem to 83116: we'd cached a constexpr call, but >> >

Re: [PATCH][PR c++/82888] smarter code for default initialization of scalar arrays

2018-02-05 Thread Jason Merrill
On Thu, Dec 21, 2017 at 1:51 PM, Jason Merrill wrote: > On Wed, Nov 29, 2017 at 4:30 PM, Jason Merrill wrote: >> On Fri, Nov 17, 2017 at 11:04 PM, Nathan Froyd wrote: >>> On Fri, Nov 17, 2017 at 8:50 AM, Jason Merrill