Re: [PATCH] [Microblaze]: PIC Data Text Relative

2018-02-27 Thread Andrew Sadek
Thanks Micheal for your response. I shall re-submit patches separately after re-running the whole GCC Test suite and re-checking code conventions. For sending to gdb-patches, it was a conflict from my side as actually I thought it is also for binutils. On Tue, Feb 27, 2018 at 2:07 AM, Michael

Re: [v3 PATCH] Implement the missing bits of LWG 2769

2018-02-27 Thread Ville Voutilainen
On 26 February 2018 at 22:52, Jonathan Wakely wrote: > On 25/02/18 23:22 +0200, Ville Voutilainen wrote: >> >> Tested partially on Linux-x64, will test with the full suite on >> Linux-PPC64. >> Ok for trunk and the gcc-7 branch? This is theoretically a breaking change > This

[PATCH] Fix debug for -mcall-ms2sysv-xlogues stubs fallout (PR target/83917)

2018-02-27 Thread Jakub Jelinek
On Mon, Feb 26, 2018 at 08:05:56PM -0600, Daniel Santos wrote: > >>> --- libgcc/config/i386/cygwin.S.jj2018-01-03 10:42:56.309763515 > >>> +0100 > >>> +++ libgcc/config/i386/cygwin.S 2018-02-22 15:30:34.597925496 +0100 > >>> @@ -23,31 +23,13 @@ > >>> * .

[arm-embedded] Allow -mcpu=cortex-m33+nodsp

2018-02-27 Thread Thomas Preudhomme
Hi, we decided to apply the following patch to ARM/embedded-7-branch to support -mcpu=cortex-m33+nodsp. DSP instructions are optional for Arm Cortex-M33, yet its -mcpu option does not allow +nodsp. Users are thus left with using -march=armv8-m.main -mtune=cortex-m33. This patch creates a new cpu

RE: [PATCH] RL78 one_cmplhi2 improvement

2018-02-27 Thread Sebastian Perta
HI DJ, > One thing to try is to use (subreg:QI in a define_expand, so that > there's a one_cmplhi2 pattern that expands to two QImode insns that > operate on HImode input/outputs via SUBREGs. Thank you for the suggestion! After several attempts the following is the only successful one, however

[PATCH] Fix gcc.target/i386/pr84309.c testcase (PR target/84575)

2018-02-27 Thread Jakub Jelinek

Re: [PATCH] PR preprocessor/84517 allow double-underscore macros after string literals

2018-02-27 Thread Jonathan Wakely
On 27 February 2018 at 16:59, Jonathan Wakely wrote: > On 27 February 2018 at 16:49, Tim Song wrote: >> On Tue, Feb 27, 2018 at 9:41 AM, Jonathan Wakely >> wrote: >>> Since the fix for PR c++/80955 any suffix on a string

Re: [PATCH] PR preprocessor/84517 allow double-underscore macros after string literals

2018-02-27 Thread Tim Song
On Tue, Feb 27, 2018 at 9:41 AM, Jonathan Wakely wrote: > Since the fix for PR c++/80955 any suffix on a string literal that > begins with an underscore is assumed to be a user-defined literal > suffix, not a macro. This assumption is invalid for a suffix beginning > with

Re: [PATCH] Fix gcc.target/i386/pr84309.c testcase (PR target/84575)

2018-02-27 Thread H.J. Lu
On Tue, Feb 27, 2018 at 1:01 AM, Jakub Jelinek wrote: > NOPATCH. -- H.J.

C++ PATCH for c++/84489, dependent default template argument

2018-02-27 Thread Jason Merrill
The logic in type_unification_real for handling template parms that depend on earlier template parms is a bit complicated. It already recognizes when the type of the parm depends on something not available yet, and it dealt with the case where substituting partial args left some template parm

[PATCH] Fix PR c++/71546 - lambda capture fails with "was not declared in this scope"

2018-02-27 Thread Håkon Sandsmark
Hi GCC developers, I have attached a proposed patch for fixing PR c++/71546 - lambda capture fails with "was not declared in this scope". The patch clears the parser scope after each lambda capture in cp_parser_lambda_introducer in parser.c. This is based on the following observations: Comment

Re: [PATCH] PR preprocessor/84517 allow double-underscore macros after string literals

2018-02-27 Thread Jonathan Wakely
On 27 February 2018 at 16:49, Tim Song wrote: > On Tue, Feb 27, 2018 at 9:41 AM, Jonathan Wakely > wrote: >> Since the fix for PR c++/80955 any suffix on a string literal that >> begins with an underscore is assumed to be a user-defined literal >>

Re: [PATCH] Fix PR c++/71546 - lambda capture fails with "was not declared in this scope"

2018-02-27 Thread Paolo Carlini
Hi, I only have a simple comment about the testcase: On 27/02/2018 17:42, Håkon Sandsmark wrote: +++ gcc/testsuite/g++.dg/cpp1y/pr71546.C @@ -0,0 +1,11 @@ +// PR c++/71546 +// { dg-do compile { target c++14 } } +// { dg-options "" } + +#include + +int main() +{ + int x1; + [e =

Re: [C++] [PR84231] overload on cond_expr in template

2018-02-27 Thread Alexandre Oliva
On Feb 15, 2018, Jason Merrill wrote: > On Thu, Feb 8, 2018 at 9:09 PM, Alexandre Oliva wrote: >> + /* If it was supposed to be an rvalue but it's not, adjust >> +one of the operands so that any overload resolution >> +taking

Re: [PATCH] RL78 one_cmplhi2 improvement

2018-02-27 Thread DJ Delorie
"Sebastian Perta" writes: > Is this similar to what you had in mind? Yes. Did it affect code size in any of the larger tests? I was hoping that it wouldn't force too much into 8-bit registers and cause more moves to be needed elsewhere. (and even if it didn't, I

Re: [C++] [PR84231] overload on cond_expr in template

2018-02-27 Thread Jason Merrill
On Tue, Feb 27, 2018 at 1:05 PM, Alexandre Oliva wrote: > On Feb 15, 2018, Jason Merrill wrote: > >> On Thu, Feb 8, 2018 at 9:09 PM, Alexandre Oliva wrote: >>> + /* If it was supposed to be an rvalue but it's not, adjust >>> +

[PATCH] x86: Force __x86_indirect_thunk_reg for function call via GOT

2018-02-27 Thread H.J. Lu
For x86 targets, when -fno-plt is used, external functions are called via GOT slot, in 64-bit mode: [bnd] call/jmp *foo@GOTPCREL(%rip) and in 32-bit mode: [bnd] call/jmp *foo@GOT[(%reg)] With -mindirect-branch=, they are converted to, in 64-bit mode: pushq

Re: [PATCH] PR preprocessor/84517 allow double-underscore macros after string literals

2018-02-27 Thread Jason Merrill
OK. On Tue, Feb 27, 2018 at 9:41 AM, Jonathan Wakely wrote: > Since the fix for PR c++/80955 any suffix on a string literal that > begins with an underscore is assumed to be a user-defined literal > suffix, not a macro. This assumption is invalid for a suffix beginning >

Re: [patch] better explain $target.h vs $target-protos.h in internals manual

2018-02-27 Thread Richard Sandiford
Sandra Loosemore writes: > Following up on discussion in gcc@, how does this documentation patch look? > > https://gcc.gnu.org/ml/gcc/2018-02/msg00139.html Looks good to me FWIW. Richard

Re: [PATCH] Fix PR c++/71546 - lambda capture fails with "was not declared in this scope"

2018-02-27 Thread Paolo Carlini
.. or even: namespace n { struct make_shared { }; } int main() {   int x1;   [e = n::make_shared (), x1]() {}; } I.e., I don't think the fact that std::make_shared is a template plays a specific role here. Paolo.

Re: [PATCH] Fix PR c++/71546 - lambda capture fails with "was not declared in this scope"

2018-02-27 Thread Håkon Sandsmark
Hi, Thanks for the feedback. I chose to take the example from the bug report verbatim as the test case. However, I agree it makes sense to have the simplest possible test case that reproduces the issue. Here is an updated patch. 2018-02-27 Håkon Sandsmark PR

Re: [PATCH] Fix PR c++/71546 - lambda capture fails with "was not declared in this scope"

2018-02-27 Thread Jason Merrill
On 02/27/2018 01:51 PM, Håkon Sandsmark wrote: Thanks for the feedback. I chose to take the example from the bug report verbatim as the test case. However, I agree it makes sense to have the simplest possible test case that reproduces the issue. Here is an updated patch. Thanks! + /*

Re: [PATCH] Fix PR c++/71546 - lambda capture fails with "was not declared in this scope"

2018-02-27 Thread Jason Merrill
On 02/27/2018 03:29 PM, Jason Merrill wrote: On 02/27/2018 01:51 PM, Håkon Sandsmark wrote: Thanks for the feedback. I chose to take the example from the bug report verbatim as the test case. However, I agree it makes sense to have the simplest possible test case that reproduces the issue.

[Patch, fortran] PR83901 - [8 Regression] ICE in fold_convert_loc, at fold-const.c:2402

2018-02-27 Thread Paul Richard Thomas
Hi All, I will commit this patch as obvious tomorrow night unless there are objections in the meantime. Bootstraps and regtests on FC27/x86_64 - OK? Paul 2018-02-27 Paul Thomas PR fortran/83901 * trans-stmt.c (trans_associate_var): Make sure that the se expression is a

[PR c++/84426] ICE after conflicting member decl

2018-02-27 Thread Nathan Sidwell
The crash was happening because add_method wasn't telling it's caller something went wrong. We then ended up with a vfunc and a regular field on the TYPE_MEMBERS list, but only the field in the CLASSTYPE_MEMBER_VEC. So we knew there was a virtual func, but couldn't find it. Fixed by having

Re: [PATCH][AArch64] PR84114: Avoid reassociating FMA

2018-02-27 Thread Aaron Sawdey
On Tue, 2018-02-27 at 14:21 +, Wilco Dijkstra wrote: > Richard Biener > > > It happens that on some targets doing two FMAs in parallel and one > > non-FMA operation merging them is faster than chaining three > > FMAs... > > Like I mentioned in the PR, long chains

C++ PATCH to fix static init with () in a template (PR c++/84582)

2018-02-27 Thread Marek Polacek
My recent change introducing cxx_constant_init caused this code template class A { static const long b = 0; static const unsigned c = (b); }; to be rejected. The reason is that force_paren_expr turns "b" into "*(const long int &) ", where the former is not value-dependent but the latter is

Re: [PATCH] Fix PR c++/71546 - lambda capture fails with "was not declared in this scope"

2018-02-27 Thread Håkon Sandsmark
2018-02-27 22:02 GMT+01:00 Jason Merrill : > On 02/27/2018 03:29 PM, Jason Merrill wrote: >> >> On 02/27/2018 01:51 PM, Håkon Sandsmark wrote: >>> >>> Thanks for the feedback. I chose to take the example from the bug >>> report verbatim as the test case. >>> >>> However, I agree

Re: C++ PATCH to fix static init with () in a template (PR c++/84582)

2018-02-27 Thread Jason Merrill
On 02/27/2018 02:13 PM, Marek Polacek wrote: My recent change introducing cxx_constant_init caused this code template class A { static const long b = 0; static const unsigned c = (b); }; to be rejected. The reason is that force_paren_expr turns "b" into "*(const long int &) ", where

[Patch, fortran] PR84538 - [8 Regression] Array of derived type elements incorrectly accessed in function

2018-02-27 Thread Paul Richard Thomas
Hi All, The attached fixes this PR by dint of the change in class.c. The changes to trans-array.c are largely cosmetic but the move of the call to 'build_class_array_ref' ensures that all class array references go by this route. Boostrapped and regtested on FC27/x86_64 - OK to commit? Regards

[PATCH] Fix aarch64_simd_reg_or_zero predicate (PR fortran/84565)

2018-02-27 Thread Jakub Jelinek
Hi! The following testcase ICEs, because the aarch64_cmeqdf instruction starting with r256612 no longer accepts CONST0_RTX (E_DFmode) as valid argument, but the expander generates it anyway. The bug has been introduced during the addition of aarch64_simd_imm_zero and

[C++ PATCH] Fix ICE in cxx_eval_vec_init_1 (PR c++/84558)

2018-02-27 Thread Jakub Jelinek
Hi! The PR70001 optimization in cxx_eval_vec_init_1 uses initializer_constant_valid_p (eltinit, TREE_TYPE (eltinit)) which doesn't work if eltinit is NULL. This can happen if *non_constant_p is true, but ctx->quiet is true as well (for *non_constant_p && !ctx->quiet we break the cycle early). No

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

2018-02-27 Thread Richard Sandiford
Martin Sebor writes: > + /* Convert the poly_int64 offset to to offset_int. The offset > + should be constant but be prepared for it not to be just in > + case. */ This comment seems redundant and could easily get out of date once ACLE support is added. > +

Re: [Aarch64] Fix conditional branches with target far away.

2018-02-27 Thread Ramana Radhakrishnan
On Wed, Feb 14, 2018 at 8:30 AM, Sameera Deshpande wrote: > Hi! > > Please find attached the patch to fix bug in branches with offsets over 1MiB. > There has been an attempt to fix this issue in commit > 050af05b9761f1979f11c151519e7244d5becd7c > > However, the

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-27 Thread Jan Hubicka
> On Mon, Feb 26, 2018 at 8:54 AM, Jan Hubicka wrote: > >> On Mon, Feb 26, 2018 at 7:47 AM, Jan Hubicka wrote: > >> > Hi, > >> > my main concern about the patch is that we now have > >> > -mindirect-branch=thunk-extern > >> > which is intended to work well and is

[PATCH] Fix PR84512

2018-02-27 Thread Richard Biener
With Honzas change to make the x86 backend consider the actual operation for costing vector stmts it becomes apparent that vect_compute_single_scalar_iteration_cost uses the old-style target cost hook which doesn't get enough information to distinguish different operations. This means instead

[PATCH] Make groups more generic (PR gcov-profile/84548).

2018-02-27 Thread Martin Liška
Hi. Considering following C++ code snippet: struct A { static int foo () { return 1; }; static int bar () { int x; return 2; } }; we should consider functions foo and bar as 2 within a single group. Even though these functions are not 'clones', they still overlap and it's proper to group

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-27 Thread H.J. Lu
On Mon, Feb 26, 2018 at 8:54 AM, Jan Hubicka wrote: >> On Mon, Feb 26, 2018 at 7:47 AM, Jan Hubicka wrote: >> > Hi, >> > my main concern about the patch is that we now have >> > -mindirect-branch=thunk-extern >> > which is intended to work well and is used by

Re: [PATCH] Make groups more generic (PR gcov-profile/84548).

2018-02-27 Thread Nathan Sidwell
On 02/27/2018 07:45 AM, Martin Liška wrote: Hi. Considering following C++ code snippet: gcc/ChangeLog: 2018-02-26 Martin Liska PR gcov-profile/84548 * gcov.c (process_file): Allow partial overlap and consider it also as group functions.

Re: [PATCH][AArch64] PR84114: Avoid reassociating FMA

2018-02-27 Thread Richard Biener
On Mon, Feb 26, 2018 at 11:25 PM, James Greenhalgh wrote: > On Thu, Feb 22, 2018 at 11:38:03AM +, Wilco Dijkstra wrote: >> As discussed in the PR, the reassociation phase runs before FMAs are formed >> and so can significantly reduce FMA opportunities. Although

Re: [PATCH v6] aarch64: Add split-stack support

2018-02-27 Thread Adhemerval Zanella
Ping (with Szabolcs remarks fixed). On 07/02/2018 16:07, Adhemerval Zanella wrote: > Changes from previous version: > > - Changed the wait to call __morestack to use use a branch with link > instead of a simple branch. This allows use a call instruction and > avoid possible issues

Re: [v3 PATCH] Implement the missing bits of LWG 2769

2018-02-27 Thread Jonathan Wakely
On 27/02/18 10:13 +0200, Ville Voutilainen wrote: On 26 February 2018 at 22:52, Jonathan Wakely wrote: On 25/02/18 23:22 +0200, Ville Voutilainen wrote: Tested partially on Linux-x64, will test with the full suite on Linux-PPC64. Ok for trunk and the gcc-7 branch? This is

Re: [Aarch64] Fix conditional branches with target far away.

2018-02-27 Thread Sameera Deshpande
On 14 February 2018 at 14:00, Sameera Deshpande wrote: > Hi! > > Please find attached the patch to fix bug in branches with offsets over 1MiB. > There has been an attempt to fix this issue in commit > 050af05b9761f1979f11c151519e7244d5becd7c > > However, the

Re: [PATCH,PTX] Add support for CUDA 9

2018-02-27 Thread Thomas Schwinge
Hi! Given that several users have run into this, is this (trunk r256891) OK to commit to open release branches, too? On Fri, 19 Jan 2018 09:42:08 +0100, Tom de Vries wrote: > On 01/19/2018 01:59 AM, Cesar Philippidis wrote: > > Here's the updated patch with the changes

Re: [PATCH] Make groups more generic (PR gcov-profile/84548).

2018-02-27 Thread Martin Liška
On 02/27/2018 02:01 PM, Nathan Sidwell wrote: > On 02/27/2018 07:45 AM, Martin Liška wrote: >> Hi. >> >> Considering following C++ code snippet: > >> gcc/ChangeLog: >> >> 2018-02-26  Martin Liska  >> >> PR gcov-profile/84548 >> * gcov.c (process_file): Allow partial

Re: [PATCH,PTX] Add support for CUDA 9

2018-02-27 Thread Richard Biener
On Tue, 27 Feb 2018, Thomas Schwinge wrote: > Hi! > > Given that several users have run into this, is this (trunk r256891) OK > to commit to open release branches, too. Sure. > On Fri, 19 Jan 2018 09:42:08 +0100, Tom de Vries > wrote: > > On 01/19/2018 01:59 AM, Cesar

Re: [PATCH][AArch64] PR84114: Avoid reassociating FMA

2018-02-27 Thread Wilco Dijkstra
Richard Biener > It happens that on some targets doing two FMAs in parallel and one > non-FMA operation merging them is faster than chaining three FMAs... Like I mentioned in the PR, long chains should be broken, but for that we need a new parameter to state how

[PATCH, arm-embedded] Multilib mapping for Armv8-R

2018-02-27 Thread Thomas Preudhomme
Hi, We have decided to apply the following patch to the ARM/embedded-7-branch to provide better multilib for Armv8-R targets. Due to there being no multilib mapping for Armv8-R, default multilib built for -march=armv4t with softfloat floating-point arithmetic is being used. This patch maps it

Re: [PATCH] Fix aarch64_simd_reg_or_zero predicate (PR fortran/84565)

2018-02-27 Thread Richard Sandiford
Jakub Jelinek writes: > Hi! > > The following testcase ICEs, because the aarch64_cmeqdf instruction > starting with r256612 no longer accepts CONST0_RTX (E_DFmode) as > valid argument, but the expander generates it anyway. > > The bug has been introduced during the addition of

[PATCH] PR preprocessor/84517 allow double-underscore macros after string literals

2018-02-27 Thread Jonathan Wakely
Since the fix for PR c++/80955 any suffix on a string literal that begins with an underscore is assumed to be a user-defined literal suffix, not a macro. This assumption is invalid for a suffix beginning with two underscores, because such names are reserved and can't be used for UDLs anyway.

[PATCH] Fix PR84466

2018-02-27 Thread Richard Biener
The following fixes PR84466. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-02-27 Richard Biener PR tree-optimization/84466 * graphite-scop-detection.c (scop_detection::stmt_simple_for_scop_p): Adjust last change to

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-27 Thread Jason Merrill
On 02/26/2018 11:19 PM, Martin Sebor wrote: While reviewing other related bugs I noticed 83502.  This patch doesn't fix the first test case in the bug (attribute noinline vs always_inline).  Somehow those are still copied from the primary to the specialization and can cause conflicts. Hmm,

Re: [C++] [PR84231] overload on cond_expr in template

2018-02-27 Thread Alexandre Oliva
On Feb 27, 2018, Jason Merrill wrote: > Perhaps it would be easier to add the REFERENCE_TYPE in > build_conditional_expr_1, adjusting result_type based on > processing_template_decl and is_lvalue. It is, indeed! Here's the patch, regstrapped on i686- and x86_64-linux-gnu.

[PATCH, rs6000] (v2) Update altivec-7 testcase(s).

2018-02-27 Thread Will Schmidt
Hi, V2 update to incorporate suggested changes. Move the vsx related content from the altivec-7-be test into a new vsx-7-be test. Split out the VSX specific bits into a vsx-7.h header file, and include that when appropriate. (v2 updates). Adjust target stanza to allow 32bit targets to run

gcc testsuite changes for new linker messages

2018-02-27 Thread Alan Modra
GNU ld error messages have changed to comply with the GNU coding standards. The two fixes in this patch look to be the only required changes in the GCC testsuite. I've written the prune_gcc_output patch the way I have to try to capture the fact that the lower case "in function" is correct for a

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-27 Thread David Edelsohn
Martin, This patch broke bootstrap. diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 42fd872..9c2e5e6 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -24,6 +24,7 @@ along with GCC; see the file COPYING3. If not see all methods must be provided in header files; can't use a source file that

[PATCH] Fix pt.c bootstrap breakage

2018-02-27 Thread David Edelsohn
The recent change to pt.c broke bootstrap by including C++ header file directly and including it first. This patch changes to the necessary method which includes the header file via system.h. Okay? Thanks, David * pt.c: Don't include string. Define INCLUDE_STRING before system.h. Index: pt.c

libgo patch committed: Update to final Go 1.10 release

2018-02-27 Thread Ian Lance Taylor
This patch to libgo updates it to the final Go 1.10 release. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === --- gcc/go/gofrontend/MERGE (revision 257954)

Re: [PATCH/testsuite] avoid test failures with -fpic

2018-02-27 Thread Jeff Law
On 02/26/2018 04:47 PM, Martin Sebor wrote: > Compiling a number of tests with -fpic results in failures > because the tests make use of non-inline, extern helper > functions defined within, and these helpers must be assumed > to have been superimposed elsewhere. > > For example: >

libgo patch committed: Update AIX memory allocation

2018-02-27 Thread Ian Lance Taylor
This patch by Tony Reix updates the AIX memory allocation in libgo for new versions of AIX. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === ---

Re: [PING] [PATCH] consider successor blocks when avoiding -Wstringop-truncation (PR 84468)

2018-02-27 Thread Jeff Law
On 02/26/2018 05:47 PM, Martin Sebor wrote: > On 02/26/2018 12:13 PM, Jeff Law wrote: >> On 02/24/2018 05:11 PM, Martin Sebor wrote: >>> Attached is an updated patch with a fix for a bad assumption >>> exposed by building the linux kernel. >>> >>> On 02/19/2018 07:50 PM, Martin Sebor wrote:

Re: [PATCH PR other/77609] Let the assembler choose ELF section types for miscellaneous named sections

2018-02-27 Thread Roland McGrath via gcc-patches
On Mon, Feb 26, 2018 at 8:11 PM, Ian Lance Taylor wrote: > You are recreating the conditions used in > default_elf_asm_named_section, so I think you ought to have comments > referring back and forth between them. > > This is OK with the two additional comments. Thanks for the

Re: [PR81611] improve auto-inc

2018-02-27 Thread Jeff Law
On 02/27/2018 04:18 PM, Alexandre Oliva wrote: > On Feb 14, 2018, Jeff Law wrote: > >>> + regno = REGNO (inc_insn.reg0); >>> + int luid = DF_INSN_LUID (mem_insn.insn); >>> + mem_insn.insn = get_next_ref (regno, bb, reg_next_use);

Re: [PATCH PR other/77609] Let the assembler choose ELF section types for miscellaneous named sections

2018-02-27 Thread Ian Lance Taylor via gcc-patches
On Tue, Feb 27, 2018 at 6:01 PM, Roland McGrath wrote: > On Mon, Feb 26, 2018 at 8:11 PM, Ian Lance Taylor wrote: >> You are recreating the conditions used in >> default_elf_asm_named_section, so I think you ought to have comments >> referring back and forth

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-27 Thread Martin Sebor
On 02/27/2018 04:44 PM, Jakub Jelinek wrote: On Mon, Feb 26, 2018 at 09:19:56PM -0700, Martin Sebor wrote: + /* Put together a list of the black listed attributes that the primary + template is declared with that the specialization is not, in case + it's not apparent from the most

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)

2018-02-27 Thread Martin Sebor
On 02/22/2018 02:15 PM, Joseph Myers wrote: On Thu, 22 Feb 2018, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00858.html This is just a tweak to fix a translation bug introduced by one of my warnings (calling warning() where warning_n() is more appropriate), and to

Re: [PATCH] Fix gcc.target/i386/pr84309.c testcase (PR target/84575)

2018-02-27 Thread Jakub Jelinek
On Tue, Feb 27, 2018 at 08:53:15AM -0800, H.J. Lu wrote: > On Tue, Feb 27, 2018 at 1:01 AM, Jakub Jelinek wrote: > > > > NOPATCH. Oops, sorry, here it is: 2018-02-27 Jakub Jelinek PR target/84575 * gcc.target/i386/pr84309.c: Add -mno-avx2

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-27 Thread Jakub Jelinek
On Mon, Feb 26, 2018 at 09:19:56PM -0700, Martin Sebor wrote: > + /* Put together a list of the black listed attributes that the primary > + template is declared with that the specialization is not, in case > + it's not apparent from the most recent declaration of the primary. */ > +

Re: [PATCH] Fix debug for -mcall-ms2sysv-xlogues stubs fallout (PR target/83917)

2018-02-27 Thread Jakub Jelinek
On Tue, Feb 27, 2018 at 09:29:36AM +0100, Jakub Jelinek wrote: > So here is a new (I've committed the previous patch since then), only lightly > tested (only on x86_64-linux and don't have too old binutils around), patch: > > 2018-02-27 Jakub Jelinek > > PR debug/83917

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-27 Thread Alexandre Oliva
On Feb 21, 2018, Alexandre Oliva wrote: > On Feb 15, 2018, Szabolcs Nagy wrote: >> i see assembler slow downs with these location view patches >> i opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84408 > [LVU] reset view at function entry, omit

Re: [PATCH] Fix debug for -mcall-ms2sysv-xlogues stubs fallout (PR target/83917)

2018-02-27 Thread Jeff Law
On 02/27/2018 01:29 AM, Jakub Jelinek wrote: > On Mon, Feb 26, 2018 at 08:05:56PM -0600, Daniel Santos wrote: > --- libgcc/config/i386/cygwin.S.jj2018-01-03 10:42:56.309763515 > +0100 > +++ libgcc/config/i386/cygwin.S 2018-02-22 15:30:34.597925496 +0100 > @@ -23,31

Re: gcc testsuite changes for new linker messages

2018-02-27 Thread Jeff Law
On 02/27/2018 03:15 PM, Alan Modra wrote: > GNU ld error messages have changed to comply with the GNU coding > standards. The two fixes in this patch look to be the only required > changes in the GCC testsuite. I've written the prune_gcc_output patch > the way I have to try to capture the fact

[PATCH] [RFC] rs6000: -mreadonly-in-sdata (PR82411)

2018-02-27 Thread Segher Boessenkool
This adds a new option -mreadonly-in-sdata (on by default) that controls whether readonly data can be put in sdata. (For EABI this does nothing, readonly data is put in sdata2 as usual). Kees, could you try this out with your use case? Add the flag -mno-readonly-in-sdata in your build scripts.

Re: [PR81611] improve auto-inc

2018-02-27 Thread Alexandre Oliva
On Feb 14, 2018, Jeff Law wrote: >> + regno = REGNO (inc_insn.reg0); >> + int luid = DF_INSN_LUID (mem_insn.insn); >> + mem_insn.insn = get_next_ref (regno, bb, reg_next_use); > So I think a comment is warranted right as we

[PATCH] Fix ms_struct/-mms-bitfields structure layout (PR target/52991)

2018-02-27 Thread Jakub Jelinek
Hi! The following patch fixes the reported ms_struct/-mms-bitfields structure layout issues from PR52991. There are multiple issues, two of them introduced by the https://gcc.gnu.org/ml/gcc-patches/2006-04/msg01064.html -mms-bitfields revamp from Eric and follow-up fix r114552, the rest has been

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-27 Thread Martin Sebor
On 02/27/2018 04:21 PM, David Edelsohn wrote: Martin, This patch broke bootstrap. diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 42fd872..9c2e5e6 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -24,6 +24,7 @@ along with GCC; see the file COPYING3. If not see all methods must be provided in

[RFA][PATCH][PR middle-end/61118] Improve tree CFG accuracy for setjmp/longjmp

2018-02-27 Thread Jeff Law
Richi, you worked on 57147 which touches on the issues here. Your thoughts would be greatly appreciated. So 61118 is one of several bugs related to the clobbered-by-longjmp warning. In 61118 is we are unable to coalesce all the objects in the key partitions. To remove the relevant PHIs we