As of r266080, calls to dump_print* that aren't guarded by
if (dump_enabled_p ())
lead to an assertion failure.
This patch fixes a few calls that weren't guarded, avoiding a
call to find_loop_location for the no-dumping case.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
On 14/09/2018 16:37, Richard Sandiford wrote:
diff --git a/gcc/combine.c b/gcc/combine.c
index a2649b6..cbf9dae 100644
--- a/gcc/combine.c
+++ b/gcc/combine.c
@@ -8621,7 +8621,13 @@ gen_lowpart_or_truncate (machine_mode mode, rtx x)
{
/* Bit-cast X into an integer mode. */
As of r266186, auto_diagnostic_group is now user-visible
(via -fdiagnostics-format=json), so update the diagnostic
guidelines accordingly.
Committed to trunk as r266187.
gcc/ChangeLog:
* doc/ux.texi (Group logically-related diagnostics): Move
discussion of auto_diagnostic_group
On Thu, 15 Nov 2018, Michael Matz wrote:
> I disagree that there's something to fix. My mental model for local reg
> vars has always been that such vars are actually an alias for that
> register, not comparable to normal automatic variables (so, much like
> global reg vars, except that they
On Thu, Nov 15, 2018 at 02:39:14PM +0100, Paolo Carlini wrote:
> Hi,
>
> this one should be straightforward. Tested x86_64-linux.
>
> Thanks, Paolo.
>
> /
>
> /cp
> 2018-11-15 Paolo Carlini
>
> * constexpr.c (ensure_literal_type_for_constexpr_object): Use
>
On Thu, Nov 15, 2018 at 10:56:15AM -0500, Marek Polacek wrote:
> + if (current_class_type)
> + inject_this_parameter (current_class_type, TYPE_UNQUALIFIED);
>
> I think you can remove the if here.
Actually you probably need it after all.
Marek
With one of my last changes we regressed here so this goes all the
way cleaning up things so we only have a single flag to
vectorizable_condition whetehr we are called from reduction context.
In theory the !multiple-types restriction could be easily lifted now
(just remove the check).
Hi,
On 15/11/18 15:34, Marek Polacek wrote:
How about using location_of instead of DECL_SOURCE_LOCATION?
Well, we know that VAR_P is true of that DECL tree node, thus I don't
see how location_of would be better. Certainly is more complex.
Paolo.
> On Nov 14, 2018, at 5:19 PM, Jozef Lawrynowicz
> wrote:
>
> On Wed, 14 Nov 2018 11:30:39 -0500
> Paul Koning wrote:
>
>>> On Nov 14, 2018, at 10:44 AM, Jozef Lawrynowicz
>>> wrote:
>>>
>>> Patch 1 tweaks dg directives in tests specifically for msp430. Many of
>>> these are extensions
Hi,
On Wed, 14 Nov 2018, Alexander Monakov wrote:
> On Wed, 14 Nov 2018, Segher Boessenkool wrote:
> > Yeah, using local register vars to access global registers only works
> > by accident. It does work currently though, and people apparently use
> > it, so we shouldn't break it :-/
>
> In the
Hi,
this one should be straightforward. Tested x86_64-linux.
Thanks, Paolo.
/
/cp
2018-11-15 Paolo Carlini
* constexpr.c (ensure_literal_type_for_constexpr_object): Use
DECL_SOURCE_LOCATION in error_at calls.
/testsuite
2018-11-15 Paolo Carlini
On Thu, Nov 15, 2018 at 02:26:24PM +0530, Umesh Kalappa wrote:
> Thank you Marek for the inputs .
> >>In the future, if using diff, please also use the -p option.
> We are using svn diif and other comments are addressed .
Thanks, but it doesn't seem like the -p option was used.
> please let us
Hi,
On Thu, 15 Nov 2018, Richard Biener wrote:
> > Okay, probably. Then consider the same patch with sprinkling casts to
> > long for all these arguments (the actual numbers will fit that type in
> > reality). I could of course also use PRIu64 but that makes my eyes
> > bleed.
>
> Hmm.
Changed in v2:
* added test coverage
* improved docs
* pass orig_diag_kind to the finalizer callback
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Committed to trunk as r266186.
Blurb from v1:
This patch implements a -fdiagnostics-format=json option which
converts the
On Thu, Nov 15, 2018 at 2:31 PM Michael Matz wrote:
>
> Hi,
>
> On Thu, 15 Nov 2018, Richard Biener wrote:
>
> > > Okay, probably. Then consider the same patch with sprinkling casts to
> > > long for all these arguments (the actual numbers will fit that type in
> > > reality). I could of course
Hi,
GNU_USER_DYNAMIC_LINKER is defined in linux.h, it will expand to
GLIBC_DYNAMIC_LINKER when configured with glibc
> 在 2018年11月15日，下午6:30，Richard Biener 写道：
>
> On Thu, Nov 15, 2018 at 7:02 AM 瞿仙淼 wrote:
>>
>> Hi,
>>I have submitted a patch to update dynamic linker'name
This patch implements dr2336, a fix to dr1658
dr1658 made virtual bases of abstract classes ignored for synthesize
cdtors -- there are no complete objects of such type, so the vbases will
never be cdtored by such cdtors.
Except when virtual dtors are in play, such a dtor could override a
OK.
On Thu, Nov 15, 2018 at 8:39 AM Paolo Carlini wrote:
>
> Hi,
>
> this one should be straightforward. Tested x86_64-linux.
>
> Thanks, Paolo.
>
> /
>
Hi,
This patch factors out new function read_string in dwarf.c.
Bootstrapped and reg-tested on x86_64.
OK for trunk (or, for stage1)?
Thanks,
- Tom
[libbacktrace] Factor out read_string
2018-11-15 Tom de Vries
* dwarf.c (read_string): Factor out of ...
(read_attribute,
On 11/15/18, Martin Sebor wrote:
> On 11/14/2018 02:12 PM, David Malcolm wrote:
>> On Mon, 2018-11-12 at 13:37 -0700, Martin Sebor wrote:
>>> On 11/11/2018 07:43 PM, David Malcolm wrote:
We often emit more than one diagnostic at the same source location.
For example, the C++ frontend
On Thu, 15 Nov 2018 09:48:05 -0500
Paul Koning wrote:
> > On Nov 14, 2018, at 5:19 PM, Jozef Lawrynowicz
> > wrote:
> >
> >
> > I'd be curious if the line I added the xfail to in c-c++-common/pr57371-2.c
> > also fails for pdp11.
> >
> > The conversion to float might be getting optimized out
On 11/14/2018 02:12 PM, David Malcolm wrote:
On Mon, 2018-11-12 at 13:37 -0700, Martin Sebor wrote:
On 11/11/2018 07:43 PM, David Malcolm wrote:
We often emit more than one diagnostic at the same source location.
For example, the C++ frontend can emit many diagnostics at
the same source
On 11/14/2018 02:47 AM, Jakub Jelinek wrote:
On Tue, Nov 13, 2018 at 09:11:41PM -0700, Martin Sebor wrote:
--- gcc/c-family/c-warn.c (revision 266086)
+++ gcc/c-family/c-warn.c (working copy)
@@ -2609,3 +2609,39 @@ warn_for_multistatement_macros (location_t body_lo
inform
We weren't noticing that 'expr.operator T()' is dependent if T is
dependent. Therefore we looked up 'operator T' at template definition
time and went down hill from there.
86246 and 87989 had different failure modes (one iced, one generated
wrong code), so adding both.
booted & tested on
On 11/15/2018 02:39 AM, Matthew Malcomson wrote:
On 02/11/18 09:54, Christophe Lyon wrote:
Hi,
I've noticed failure on targets using newlib (aarch64-elf and arm-eabi):
FAIL: gcc.c-torture/execute/printf-2.c
FAIL: gcc.c-torture/execute/user-printf.c
my gcc.log contains:
On 14 November 2018 12:35:27 CET, Jakub Jelinek wrote:
>> --- a/gcc/config/gnu-user.h
>> +++ b/gcc/config/gnu-user.h
>> @@ -170,3 +170,6 @@ see the files COPYING3 and COPYING.RUNTIME
>respectively. If not, see
>>LD_STATIC_OPTION " --whole-archive -llsan --no-whole-archive " \
>>
On 11/15/18 4:02 AM, Richard Biener wrote:
> On Wed, Nov 14, 2018 at 5:43 PM Aaron Sawdey wrote:
>>
>> This patch generalizes some the functions added earlier to do vsx expansion
>> of strncmp
>> so that the can also generate the code needed for memcmp. I reorganized
>> expand_block_compare() a
On Thu, Nov 15, 2018 at 08:40:13PM +0100, Bernhard Reutner-Fischer wrote:
> On 14 November 2018 12:35:27 CET, Jakub Jelinek wrote:
>
> >> --- a/gcc/config/gnu-user.h
> >> +++ b/gcc/config/gnu-user.h
> >> @@ -170,3 +170,6 @@ see the files COPYING3 and COPYING.RUNTIME
> >respectively. If not, see
Andi Kleen writes:
Ping!^2
> Andi Kleen writes:
>
> Ping!
>
>> From: Andi Kleen
>>
>> When instrumenting programs using __fentry__ it is often useful
>> to instrument the function return too. Traditionally this
>> has been done by patching the return address on the stack
>> frame on entry.
On 11/15/2018 03:10 AM, Richard Biener wrote:
On Wed, Nov 14, 2018 at 7:08 PM Jeff Law wrote:
On 11/6/18 4:56 PM, Martin Sebor wrote:
In response to Joseph's comment I've removed the interaction
with -Wpedantic from the updated patch.
In addition, to help detect bugs like the one in the
On 11/14/2018 02:39 AM, Alexander Monakov wrote:
On Tue, 13 Nov 2018, Martin Sebor wrote:
In PR 88000 the reporter expects to be able to use an explicit
register local variable in a context where it isn't supported
i.e., for something other than an input or output of an asm
statement: namely
I've checked in this patch for PR 25759, another minor documentation
improvement.
-Sandra
2018-11-15 Sandra Loosemore
PR c++/25759
gcc/
* doc/extend.texi (Common Type Attributes): Make it explicit
that attribute "packed" can apply to C++ classes.
Index: gcc/doc/extend.texi
On Tue, 2018-11-13 at 16:34 -0500, Jason Merrill wrote:
> On Mon, Nov 12, 2018 at 4:32 PM Martin Sebor
> wrote:
> > On 11/11/2018 02:02 PM, David Malcolm wrote:
> > > On Sun, 2018-11-11 at 11:01 -0700, Martin Sebor wrote:
> > > > On 11/10/2018 12:01 AM, Eric Gallager wrote:
> > > > > On 11/9/18,
On 11/12/18, Martin Sebor wrote:
> On 11/11/2018 04:33 PM, David Malcolm wrote:
>> When gcc can't find a header file, it's a hard error that stops the
>> build,
>> typically requiring the user to mess around with compile flags,
>> Makefiles,
>> dependencies, and so forth.
>>
>> Often the exact
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01818.html
Please let me know if there is something I need to change here
to make the fix acceptable or if I should stop trying.
On 10/31/2018 10:33 AM, Martin Sebor wrote:
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01818.html
On
Hi,
I have submitted a patch to update linux-unwind for kernel
Index: libgcc/ChangeLog
===
--- libgcc/ChangeLog(revision 266199)
+++ libgcc/ChangeLog(working copy)
@@ -1,5 +1,11 @@
2018-11-15 Xianmiao Qu
+
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01934.html
Do I need to change something in this patch to make it acceptable
or should I assume we will leave this bug in GCC unfixed?
On 10/31/2018 10:35 AM, Martin Sebor wrote:
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01934.html
From: Andi Kleen
Add a new pass to automatically instrument changes to variables
with the new PTWRITE instruction on x86. PTWRITE writes a 4 or 8 byte
field into an Processor Trace log, which allows low over head
logging of information. Essentially it's a hardware accelerated
printf.
This
From: Andi Kleen
So far they are mostly i386 target specific. Later they could
be moved up to architecture specific if some other architecture
adds vartracing.
gcc/testsuite/:
2018-11-15 Andi Kleen
* g++.dg/vartrace-3.C: New test.
* g++.dg/vartrace-ret.C: New test.
First patch is x86 specific for Uros, the rest is
the updated generic middle end implementation.
Support automatic data tracing using the PTWRITE instruction
on Intel CPUs.
This is an updated version addressing (nearly) all the
excellent review comments. It ended up being large scale changes
in
From: Andi Kleen
The earlier PTWRITE builtin definition was unnecessarily restrictive,
only allowing register input to PTWRITE. The instruction actually
supports memory operands too, so allow that too.
gcc/:
2018-11-15 Andi Kleen
* config/i386/i386.md: Allow memory operands to
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01473.html
(Still looking for an approval.)
On 11/09/2018 04:43 PM, Martin Sebor wrote:
On 11/09/2018 12:59 PM, Jeff Law wrote:
On 10/31/18 10:27 AM, Martin Sebor wrote:
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01473.html
With
On 11/12/2018 01:48 AM, Martin Liška wrote:
make check-gcc on x86_64 shows no new failures.
(A related PR washttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=86957 where we
added diagnostics for the NO PROFILE case.)
Hi.
Thanks for the patch. I'm not a maintainer, but the idea of the patch
Thank you Marek,Appreciate your valuable feedback on the patch .
Attached the latest ,please do let us know your thoughts.
~Umesh
On Thu, Nov 15, 2018 at 9:26 PM Marek Polacek wrote:
>
> On Thu, Nov 15, 2018 at 02:26:24PM +0530, Umesh Kalappa wrote:
> > Thank you Marek for the inputs .
> >
On Fri, Nov 16, 2018 at 4:57 AM Andi Kleen wrote:
>
> From: Andi Kleen
>
> The earlier PTWRITE builtin definition was unnecessarily restrictive,
> only allowing register input to PTWRITE. The instruction actually
> supports memory operands too, so allow that too.
>
> gcc/:
>
> 2018-11-15 Andi
The following side-steps a possible issue with the
evolution_function_is_affine_multivariate_p predicate by guarding
the call to analyze_subscript_affine_affine in analyze_miv_subscript
in the same way as the call from analyze_siv_subscript.
Bootstrapped and tested on x86_64-unknown-linux-gnu,
On Wed, 14 Nov 2018, Andrew Pinski wrote:
> On Fri, May 13, 2016 at 3:51 AM Richard Biener wrote:
> >
> >
> > The following patch adds BIT_FIELD_INSERT, an operation to
> > facilitate doing bitfield inserts on registers (as opposed
> > to currently where we'd have a BIT_FIELD_REF store).
> >
> >
On 11/14/18 6:54 PM, Qing Zhao wrote:
> Hi,
>
>
>> On Nov 14, 2018, at 9:03 AM, Martin Liška wrote:
>>
>>> Yes, you are right. I added this into my patch.
>>>
>>> I am attaching the new patch here.
>>
>> Hello.
>>
>> Please use
>> git diff HEAD~ > /tmp/patch &&
On Nov 14 2018, Jozef Lawrynowicz wrote:
> The timeout as set in the dejagnu configuration for msp430
> ([dejagnu.git]/baseboards/msp430-sim.exp) is 30, which is rarely
> hit.
I don't think it makes sense for a board file to set a smaller timeout
than the default.
Andreas.
--
Andreas Schwab,
Hi All,
The attached patch (pr85667.patch) fixes the subjected issue .
we tested on x86_64(linux and windows both) and no regress found .
ok to commit ?
Thank you
~Umesh
pr85667.patch
Description: Binary data
On Thu, 15 Nov 2018, Richard Biener wrote:
> On Wed, 14 Nov 2018, Andrew Pinski wrote:
>
> > On Fri, May 13, 2016 at 3:51 AM Richard Biener wrote:
> > >
> > >
> > > The following patch adds BIT_FIELD_INSERT, an operation to
> > > facilitate doing bitfield inserts on registers (as opposed
> > >
On Thu, 15 Nov 2018, Jakub Jelinek wrote:
> Hi!
>
> On the following testcase, we have a call (not marked noreturn), which can
> throw, followed immediately by __builtin_unreachable (), so it effectively
> is noreturn in this particular call site (i.e. if it returns, it is UB).
> In RTL this is
Thank you Marek for the inputs .
>>In the future, if using diff, please also use the -p option.
We are using svn diif and other comments are addressed .
please let us know your take on the revised attached patch .
Thank you
~Umesh
On Thu, Nov 15, 2018 at 12:23 AM Marek Polacek wrote:
>
> On
On 02/11/18 09:54, Christophe Lyon wrote:
> Hi,
>
> I've noticed failure on targets using newlib (aarch64-elf and arm-eabi):
> FAIL: gcc.c-torture/execute/printf-2.c
> FAIL: gcc.c-torture/execute/user-printf.c
>
> my gcc.log contains:
> gcc.c-torture/execute/user-printf.c -O0 execution test
On 14/11/2018 22:30, Jeff Law wrote:
There's a particular case that has historically been problematical.
If you have this kind of sequence in the epilogue
restore register using FP
move fp->sp (deallocates frame)
return
Under certain circumstances the scheduler can
On Wed, Nov 14, 2018 at 5:43 PM Aaron Sawdey wrote:
>
> This patch generalizes some the functions added earlier to do vsx expansion
> of strncmp
> so that the can also generate the code needed for memcmp. I reorganized
> expand_block_compare() a little to be able to make use of this there. The
On Wed, Nov 14, 2018 at 7:08 PM Jeff Law wrote:
>
> On 11/6/18 4:56 PM, Martin Sebor wrote:
> > In response to Joseph's comment I've removed the interaction
> > with -Wpedantic from the updated patch.
> >
> > In addition, to help detect bugs like the one in the test case
> > for pr87886, I have
Edited the subjected for the proper PR no.
~Umesh
On Thu, Nov 15, 2018 at 2:32 PM Umesh Kalappa wrote:
>
> Hi All,
>
> The attached patch (pr85667.patch) fixes the subjected issue .
> we tested on x86_64(linux and windows both) and no regress found .
>
> ok to commit ?
>
> Thank you
> ~Umesh
On Thu, Nov 15, 2018 at 7:02 AM 瞿仙淼 wrote:
>
> Hi,
> I have submitted a patch to update dynamic linker'name
>
>
> Index: gcc/ChangeLog
> ===
> --- gcc/ChangeLog (revision 266171)
> +++ gcc/ChangeLog (working copy)
On Thu, Nov 15, 2018 at 10:02 AM Umesh Kalappa wrote:
>
> Hi All,
>
> The attached patch (pr85667.patch) fixes the subjected issue .
> we tested on x86_64(linux and windows both) and no regress found .
>
> ok to commit ?
I wonder if you can turn the testcase into a dg-run one, making the
The following fixes PR88030.
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied.
Richard.
2018-11-15 Richard Biener
PR tree-optimization/88030
* tree-complex.c (need_eh_cleanup): New global.
(update_complex_assignment): Mark blocks that need EH update.
On Thu, 15 Nov 2018 at 10:39, Matthew Malcomson
wrote:
>
> On 02/11/18 09:54, Christophe Lyon wrote:
> > Hi,
> >
> > I've noticed failure on targets using newlib (aarch64-elf and arm-eabi):
> > FAIL: gcc.c-torture/execute/printf-2.c
> > FAIL: gcc.c-torture/execute/user-printf.c
> >
> > my gcc.log
The following makes sure we preserve a 'const' attribute that
was in effect on an indirect call even after turning it into
a direct call of a non-const (pure for the testcase) function.
This mimics how we handle nothrow/noreturn.
By unioning ECF_ flags from fntype and decl we get the best
of
On Wed, Nov 14, 2018 at 6:24 PM Michael Matz wrote:
>
> Hi,
>
> On Wed, 14 Nov 2018, Alexander Monakov wrote:
>
> > On Wed, 14 Nov 2018, Michael Matz wrote:
> >
> > > Hi,
> > >
> > > it's not c++98 conforming and I get 1 million warnings when compiling.
> > > Initially I had also casts to long at
On 11/13/18 8:42 PM, Jason Merrill wrote:
> On Tue, Nov 13, 2018 at 9:20 AM Martin Liška wrote:
>>
>> On 11/13/18 5:43 AM, Jason Merrill wrote:
>>> [[likely]] and [[unlikely]] are equivalent to the GNU hot/cold attributes,
>>> except that they can be applied to arbitrary statements as well as
> This may ultimately be too simplistic. There are targets where some
> constants are OK, but others may not be. By checking the predicate
> like this I think you can cause over-aggressive if-conversion if the
> target allows a range of integers in the expander's operand predicate,
> but allows
> This looks pretty reasonable. ISTM it ought to be able to go forward if
> it's tested independently.
The test suite already passes, any other tests you have in mind? To be
honest I suppose noce_convert_multiple_sets will currently never
successfully return (due to the costing problems I
Tested on Linux-PPC64. Ok for trunk? Backports?
2018-11-15 Ville Voutilainen
PR libstdc++/87855
Also implement P0602R4 (variant and optional
should propagate copy/move triviality) for std::optional.
* include/std/optional (_Optional_payload): Change
the main constraints to
On Thu, 15 Nov 2018 10:36:57 +0100
Andreas Schwab wrote:
> On Nov 14 2018, Jozef Lawrynowicz wrote:
>
> > The timeout as set in the dejagnu configuration for msp430
> > ([dejagnu.git]/baseboards/msp430-sim.exp) is 30, which is rarely
> > hit.
>
> I don't think it makes sense for a board
> > A warning seems appropriate. You think the front end is the right
> > place for that?
>
> Probably yes. Note that middle-end can optimize about dead branches and so
> that
> theoretically one can end up with a branching where e.g. both branches are
> [[likely]].
> I wouldn't bother users
On Wed, Nov 14, 2018 at 4:21 PM Joern Wolfgang Rennecke
wrote:
>
>
> On 14/11/18 09:53, Richard Biener wrote:
> >> WIDEN_MULT_PLUS is special on our target in that it creates double-sized
> >> vectors.
> > Are there really double-size vectors or does the target simply produce
> > the output in
On Wed, Nov 14, 2018 at 4:47 PM Tamar Christina wrote:
>
> Hi Richard,
>
> > > Ok for trunk?
> >
> > +;; The complex mla operations always need to expand to two instructions.
> > +;; The first operation does half the computation and the second does
> > +the ;; remainder. Because of this, expand
Hi Segher,
> On Wed, Nov 14, 2018 at 12:37:05PM +, Wilco Dijkstra wrote:
>> +/* { dg-final { scan-assembler-not { dup } } } */
>> +/* { dg-final { scan-assembler-not { fmov } } } */
>
> { dup } is the same as " dup " , that is, with spaces and all.
> I don't think you want that (there
On Thu, Nov 15, 2018 at 1:42 PM Richard Biener
wrote:
>
> On Wed, Nov 14, 2018 at 4:47 PM Tamar Christina
> wrote:
> >
> > Hi Richard,
> >
> > > > Ok for trunk?
> > >
> > > +;; The complex mla operations always need to expand to two instructions.
> > > +;; The first operation does half the
On Wed, 14 Nov 2018, Tamar Christina wrote:
> Hi Richard,
>
> Thanks for the feedback, I've replied inline below.
> I'll wait for your answers before making changes.
I have commented on the other mail so will leave out redunant parts
here.
> > -Original Message-
> > From: Richard
This patch cleans up walk_field_subobs, synthesized_method_base_walk &
synthesized_method_walk. They use a mixture of old-style
partially-overlapping booleans /and/ new style special_function_kind
enumeration. synthesized_method_walk was determining the booleans from
sfk and then passing the
76 matches
Mail list logo
