[committed][nvptx, libgomp] Fix assert (!s->map->active) in map_fini

2019-01-23 Thread Tom de Vries
Hi, There are currently two situations where this assert triggers: ... libgomp/plugin/plugin-nvptx.c: map_fini: Assertion `!s->map->active' failed. ... First, in abort-1.c, a parallel region triggering an abort: ... int main (void) { #pragma acc parallel abort (); return 0; } ... The

Re: [patch, fortran] Move some array packing to front end

2019-01-23 Thread Richard Biener
On Tue, Jan 22, 2019 at 9:59 PM Thomas Koenig wrote: > > Hello world, > > the attached patch moves the packing / unpacking of arrays to the front > end when optimizing, but not for size. > > Rationale: internal_pack and internal_unpack are opaque to the compiler. > This can lead to a lot of

[committed][nvptx, libgomp] Fix map_push

2019-01-23 Thread Tom de Vries
Hi, The map field of a struct ptx_stream is a FIFO. The FIFO is implemented as a single linked list, with pop-from-the-front semantics. The function map_pop pops an element, either by: - deallocating the element, if there is more than one element - or marking the element inactive, if there's

Re: [PATCH] Fix gimple-loop-interchange ICE (PR tree-optimization/88964)

2019-01-23 Thread Richard Biener
On Tue, 22 Jan 2019, Jakub Jelinek wrote: > Hi! > > SCEV can analyze not just integral/pointer IVs, but (scalar) float ones as > well. Calling build_int_cst on such types results in ICE, build_zero_cst > works. Though the loop invariant PHI IVs, if we represent them as using > +0.0 step,

[committed][nvptx, libgomp] Fix cuMemAlloc with size zero

2019-01-23 Thread Tom de Vries
Hi, Consider test-case: ... int main (void) { #pragma acc parallel async ; #pragma acc parallel async ; #pragma acc wait return 0; } ... This fails with: ... libgomp: cuMemAlloc error: invalid argument Segmentation fault (core dumped) ... The cuMemAlloc error is due to the fact that

Re: UNSPEC related notes and libbacktrace

2019-01-23 Thread Martin Liška
On 1/22/19 10:50 AM, Gerald Pfeifer wrote: > I've been seeing the following in my testsuite runs which I didn't > get a month or so ago. Are these due to your changes, Jakub, or > some changes around libbacktrace? I can confirm that and I've just created a PR for it:

Re: [patch, fortran] Move some array packing to front end

2019-01-23 Thread Dominique d'Humières
Hi Thomas, With your patch I see FAIL: gfortran.dg/internal_pack_4.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions execution test with -m32. gfc /opt/gcc/work/gcc/testsuite/gfortran.dg/internal_pack_4.f90 -O3 -funroll-loops -ftracer -m32 is enough to

Re: [PATCH] sched-ebb.c: avoid moving table jumps (PR rtl-optimization/88423)

2019-01-23 Thread Alexander Monakov
On Wed, 23 Jan 2019, Alexander Monakov wrote: > That said, I'm really concerned that on this testcase we should not be moving > the tablejump *at all*: we are moving it up past a 'use ax' insn (the use is > for the function's return value). So after the move the use is in an > unreachable >

Re: [PATCH] PR c++/87893 - constexpr ctor ICE on ARM.

2019-01-23 Thread Jason Merrill
On 1/23/19 9:26 AM, Ramana Radhakrishnan wrote: On Wed, Jan 23, 2019 at 1:54 PM Jason Merrill wrote: Since in r265788 I made cxx_eval_outermost_constant_expr more insistent that the returned value have the right type, it became more important that initialized_type be correct. These two PRs

Re: C++ PATCH for c++/88757 - qualified name treated wrongly as type

2019-01-23 Thread Jason Merrill
On 1/23/19 11:05 AM, Marek Polacek wrote: Since C++20 P0634R3 we sometimes treat certain qualified-ids as types, so that the user doesn't have to type 'typename'. But this was broken for this case: template T::type N::v(T::value); which, if T::value is a type, is a function template

Re: [PATCH 2/2] PR libstdc++/86756 Move rest of std::filesystem to libstdc++.so

2019-01-23 Thread Christophe Lyon
On Wed, 23 Jan 2019 at 16:28, Jonathan Wakely wrote: > > On 09/01/19 13:53 +0100, Christophe Lyon wrote: > >On Wed, 9 Jan 2019 at 11:11, Jonathan Wakely wrote: > >> > >> On 09/01/19 10:09 +, Jonathan Wakely wrote: > >> >On 08/01/19 11:13 +0100, Christophe Lyon wrote: > >> >>On Mon, 7 Jan

[PATCH] aarch64: fix use-after-free in -march=native (PR driver/89014)

2019-01-23 Thread David Malcolm
Running: $ valgrind ./xgcc -B. -c test.c -march=native on aarch64 shows a use-after-free in host_detect_local_cpu due to the std::string result of aarch64_get_extension_string_for_isa_flags only living until immediately after a c_str call. This leads to corrupt "-march=" values being passed to

Re: [PATCH] aarch64: fix use-after-free in -march=native (PR driver/89014)

2019-01-23 Thread Richard Earnshaw (lists)
On 23/01/2019 17:12, David Malcolm wrote: > Running: > $ valgrind ./xgcc -B. -c test.c -march=native > on aarch64 shows a use-after-free in host_detect_local_cpu due > to the std::string result of aarch64_get_extension_string_for_isa_flags > only living until immediately after a c_str call. > >

Re: [PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

2019-01-23 Thread Jakub Jelinek
On Thu, Jan 10, 2019 at 04:57:47PM +, Kyrill Tkachov wrote: > --- a/gcc/config/aarch64/driver-aarch64.c > +++ b/gcc/config/aarch64/driver-aarch64.c > @@ -253,6 +253,12 @@ host_detect_local_cpu (int argc, const char **argv) > char *p = NULL; > char *feat_string >

[Patch] PR target/85711 - Fix ICE on aarch64

2019-01-23 Thread Steve Ellcey
The test gcc.dg/torture/pr84682-2.c has been failing for some time on aarch64. Bin Cheng submitted a patch for this some time ago, the original patch was: https://gcc.gnu.org/ml/gcc-patches/2018-03/msg00784.html But Richard Sandiford thought it should be fixed in recog.c instead of just in

Re: [Patch] PR target/85711 - Fix ICE on aarch64

2019-01-23 Thread Richard Sandiford
Steve Ellcey writes: > The test gcc.dg/torture/pr84682-2.c has been failing for some time on > aarch64. Bin Cheng submitted a patch for this some time ago, the > original patch was: > > https://gcc.gnu.org/ml/gcc-patches/2018-03/msg00784.html > > But Richard Sandiford thought it should be fixed

Re: [PATCH 2/2] PR libstdc++/86756 Move rest of std::filesystem to libstdc++.so

2019-01-23 Thread Jonathan Wakely
On 09/01/19 13:53 +0100, Christophe Lyon wrote: On Wed, 9 Jan 2019 at 11:11, Jonathan Wakely wrote: On 09/01/19 10:09 +, Jonathan Wakely wrote: >On 08/01/19 11:13 +0100, Christophe Lyon wrote: >>On Mon, 7 Jan 2019 at 15:14, Christophe Lyon wrote: >>> >>>On Mon, 7 Jan 2019 at 13:39,

C++ PATCH for c++/88757 - qualified name treated wrongly as type

2019-01-23 Thread Marek Polacek
Since C++20 P0634R3 we sometimes treat certain qualified-ids as types, so that the user doesn't have to type 'typename'. But this was broken for this case: template T::type N::v(T::value); which, if T::value is a type, is a function template declaration. But if T::value is a value, it's a

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-23 Thread Jakub Jelinek
On Tue, Jan 22, 2019 at 02:10:38PM +, Bernd Edlinger wrote: > --- gcc/c-family/c-warn.c (revision 268119) > +++ gcc/c-family/c-warn.c (working copy) > @@ -2796,6 +2796,10 @@ check_address_or_pointer_of_packed_membe > if (context) > break; > } > + if

Re: [EXT] Re: [Patch 2/4][Aarch64] v2: Implement Aarch64 SIMD ABI

2019-01-23 Thread Steve Ellcey
On Wed, 2019-01-23 at 12:50 +, Tamar Christina wrote: > Hi Steve, > > > > > Hi Steve, > > > > No we are using aarch64_be-*-* but this is the only one that popped > > up as a > > failure which is why I didn't change the others. > > But now I'm wondering why... I'll check the log file

Re: [PATCH, rs6000] Port cleanup patch, use rtl.h convenience macros, etc.

2019-01-23 Thread Segher Boessenkool
Hi! On Tue, Dec 04, 2018 at 10:12:51AM -0600, Peter Bergner wrote: > We talked about replacing rs6000'c regno_or_subregno() with the generic > reg_or_subregno() function from jump.c. I agree the geberic version is > better because it has an assert that ensures we have a REG. There were > also a

[PATCH, i386] Fix PR 88998, bad codegen with mmx instructions

2019-01-23 Thread Uros Bizjak
Attached patch adds SSE alternatives to sse2_cvtpi2pd, sse2_cvtpd2pi and sse2_cvttpd2pi to avoid MMX registers when e.g. _mm_cvtepi32_pd intrinsics is used. Without the patch, the testcase compiles to (-O2 -mavx): _Z7prepareii: vmovd %edi, %xmm1 vpinsrd $1, %esi, %xmm1, %xmm0

[testsuite, rfa] Add gthreads dependency to some failing libstdc++ tests

2019-01-23 Thread Sandra Loosemore
I ran libstdc++ tests on nios2-elf target. I observed several new tests failing with error: 'mutex' in namespace 'std' does not name a type The definition of class mutex in include/bits/std_mutex.h is guarded with "#ifdef _GLIBCXX_HAS_GTHREADS" so I assume these tests are not supposed to

Re: [PATCH, i386] Fix PR 88998, bad codegen with mmx instructions

2019-01-23 Thread H.J. Lu
On Wed, Jan 23, 2019 at 11:22 AM Uros Bizjak wrote: > > Attached patch adds SSE alternatives to sse2_cvtpi2pd, sse2_cvtpd2pi > and sse2_cvttpd2pi to avoid MMX registers when e.g. _mm_cvtepi32_pd > intrinsics is used. Without the patch, the testcase compiles to (-O2 > -mavx): > > _Z7prepareii: >

Re: [PATCH] sched-ebb.c: avoid moving table jumps (PR rtl-optimization/88423)

2019-01-23 Thread Segher Boessenkool
On Wed, Jan 23, 2019 at 04:52:24PM +0300, Alexander Monakov wrote: > On Wed, 23 Jan 2019, Andrey Belevantsev wrote: > > For that, I'm not sure. Your patch will leave the tablejump unscheduled at > > all, i.e. any fields like INSN_TICK would be unfilled and thus the later > > passes like bundling

[Patch, fortran] PR88929 - ICE on building MPICH 3.2 with GCC 9 with ISO_Fortran_binding

2019-01-23 Thread Paul Richard Thomas
The attached patch allows MPICH 3.2 to build correctly and to test successfully. Two problems were addressed: (i) The original implementation of ISO_Fortran_binding did not take account of the possibility that assumed rank/assumed type arrays could be passed as dummy arguments. This necessitated

Re: C++ PATCH for c++/78244 - narrowing conversion in template not detected, part 2

2019-01-23 Thread Marek Polacek
On Wed, Jan 23, 2019 at 09:00:36AM -0500, Jason Merrill wrote: > I was talking about digest_init, not reshape_init. digest_init calls > convert_for_initialization. /facepalm So yes, digest_init calls convert_for_initialization which will end up calling perform_implicit_conversion_flags which

Re: [PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-01-23 Thread Segher Boessenkool
Hi Martin, On Wed, Jan 23, 2019 at 10:29:40AM +0100, Martin Liška wrote: > diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c > index 172bdf585d0..5dd316efb63 100644 > --- a/gcc/cfgrtl.c > +++ b/gcc/cfgrtl.c > @@ -4396,6 +4396,25 @@ cfg_layout_redirect_edge_and_branch (edge e, > basic_block dest) >

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-23 Thread Bernd Edlinger
On 1/23/19 4:22 PM, Jakub Jelinek wrote: > On Tue, Jan 22, 2019 at 02:10:38PM +, Bernd Edlinger wrote: >> --- gcc/c-family/c-warn.c(revision 268119) >> +++ gcc/c-family/c-warn.c(working copy) >> @@ -2796,6 +2796,10 @@ check_address_or_pointer_of_packed_membe >>if (context) >>

Re: [patch, fortran] Move some array packing to front end

2019-01-23 Thread Thomas Koenig
Hi Dominique, FAIL: gfortran.dg/internal_pack_4.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions execution test with -m32. gfc /opt/gcc/work/gcc/testsuite/gfortran.dg/internal_pack_4.f90 -O3 -funroll-loops -ftracer -m32 is enough to trigger the

Re: [PATCH, i386] Fix PR 88998, bad codegen with mmx instructions

2019-01-23 Thread Uros Bizjak
On Wed, Jan 23, 2019 at 8:52 PM H.J. Lu wrote: > > On Wed, Jan 23, 2019 at 11:22 AM Uros Bizjak wrote: > > > > Attached patch adds SSE alternatives to sse2_cvtpi2pd, sse2_cvtpd2pi > > and sse2_cvttpd2pi to avoid MMX registers when e.g. _mm_cvtepi32_pd > > intrinsics is used. Without the patch,

Re: [PATCH] libgcc2.c: Correct DI/TI -> SF/DF conversions

2019-01-23 Thread H.J. Lu
On Wed, Jan 23, 2019 at 12:50 PM Joseph Myers wrote: > > On Wed, 23 Jan 2019, H.J. Lu wrote: > > > + fesetround (FE_DOWNWARD); > > + float fs = s128; > > + if (fs != -0x1p+127) > > +abort (); > > + double ds = s128; > > + if (ds != -0x1p+127) > > +abort (); > > This definitely needs

Re: [patch, fortran] Move some array packing to front end

2019-01-23 Thread Thomas Koenig
Hi, for the record, the attached version of the patch regtests cleanly and also passes the test that Dominique pointed out. I will defer this until stage 1 reopens. Regards Thomas Index: fortran/expr.c === ---

Re: C++ PATCH for c++/78244 - narrowing conversion in template not detected, part 2

2019-01-23 Thread Jason Merrill
On Wed, Jan 23, 2019 at 12:57 PM Marek Polacek wrote: > > On Wed, Jan 23, 2019 at 09:00:36AM -0500, Jason Merrill wrote: > > I was talking about digest_init, not reshape_init. digest_init calls > > convert_for_initialization. > > /facepalm > > So yes, digest_init calls convert_for_initialization

Re: [PATCH] libgcc2.c: Correct DI/TI -> SF/DF conversions

2019-01-23 Thread Joseph Myers
On Wed, 23 Jan 2019, H.J. Lu wrote: > + fesetround (FE_DOWNWARD); > + float fs = s128; > + if (fs != -0x1p+127) > +abort (); > + double ds = s128; > + if (ds != -0x1p+127) > +abort (); This definitely needs #ifdef FE_DOWNWARD; even just limited to glibc configurations, there are

Re: [PATCH, i386] Fix PR 88998, bad codegen with mmx instructions

2019-01-23 Thread H.J. Lu
On Wed, Jan 23, 2019 at 12:27 PM Uros Bizjak wrote: > > On Wed, Jan 23, 2019 at 8:52 PM H.J. Lu wrote: > > > > On Wed, Jan 23, 2019 at 11:22 AM Uros Bizjak wrote: > > > > > > Attached patch adds SSE alternatives to sse2_cvtpi2pd, sse2_cvtpd2pi > > > and sse2_cvttpd2pi to avoid MMX registers

Re: [EXT] Re: [Patch] PR target/85711 - Fix ICE on aarch64

2019-01-23 Thread Steve Ellcey
On Wed, 2019-01-23 at 16:54 +, Richard Sandiford wrote: > > IMO we shouldn't remove the assert. See: > > https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01969.html > > and the thread leading up to it. > > Thanks, > Richard OK, I hadn't seen that thread. I didn't see any patch submitted

Re: [EXT] Re: [Patch] PR target/85711 - Fix ICE on aarch64

2019-01-23 Thread Richard Sandiford
Steve Ellcey writes: > On Wed, 2019-01-23 at 16:54 +, Richard Sandiford wrote: >> >> IMO we shouldn't remove the assert. See: >> >> https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01969.html >> >> and the thread leading up to it. >> >> Thanks, >> Richard > > OK, I hadn't seen that

Re: [Patch, fortran] PR88929 - ICE on building MPICH 3.2 with GCC 9 with ISO_Fortran_binding

2019-01-23 Thread Steve Kargl
On Wed, Jan 23, 2019 at 07:43:48PM +, Paul Richard Thomas wrote: > > Bootstrapped and regtested on FC28/x86_64 - OK for trunk? > Yes with minor fixes. > Index: gcc/fortran/trans-array.c > === > *** gcc/fortran/trans-array.c

Re: Fortran vector math header

2019-01-23 Thread Steve Ellcey
On Tue, 2019-01-22 at 13:18 +0100, Richard Biener wrote: > > Yeah, I would even suggest to use a target hook multilib_ABI_active_p > (const char *) > for this ... (where the hook should diagnose unknown multilib specifiers). > > Richard. I wonder if we even need to pass a string to the target

Re: [PATCH] Update URLs in libsanitizer/README.gcc [PR Bug sanitizer/89010]

2019-01-23 Thread Jonny Grant
On 23/01/2019 13:19, Jakub Jelinek wrote: On Wed, Jan 23, 2019 at 11:30:29AM +, Jonny Grant wrote: Not a member of this list, please include my email address in any replies. 2019-01-23 Jonny Grant PR 89010 PR sanitizer/89010 is what should be used. *

[committed] Bump BASE-VER for stage4

2019-01-23 Thread Jakub Jelinek
Hi! We forgot to bump BASE-VER when we've entered stage4, doing it now: 2019-01-23 Jakub Jelinek * BASE-VER: Bump to 9.0.1. --- gcc/BASE-VER(revision 268183) +++ gcc/BASE-VER(revision 268184) @@ -1 +1 @@ -9.0.0 +9.0.1 Jakub

Re: [PATCH] sched-ebb.c: avoid moving table jumps (PR rtl-optimization/88423)

2019-01-23 Thread Alexander Monakov
On Wed, 23 Jan 2019, Andrey Belevantsev wrote: > For that, I'm not sure. Your patch will leave the tablejump unscheduled at > all, i.e. any fields like INSN_TICK would be unfilled and thus the later > passes like bundling on ia64 will not work. Maybe we can just stop > tablejumps from moving

[PATCH] PR c++/87893 - constexpr ctor ICE on ARM.

2019-01-23 Thread Jason Merrill
Since in r265788 I made cxx_eval_outermost_constant_expr more insistent that the returned value have the right type, it became more important that initialized_type be correct. These two PRs were cases of it giving the wrong answer. On ARM, a constructor returns a pointer to the object, but

Re: [C++ PATCH] Change similarly also loop genericization (PR c/44715)

2019-01-23 Thread Jason Merrill
On 1/22/19 5:25 PM, Jakub Jelinek wrote: Hi! This patch adjusts genericize_cp_loop similarly to the PR88984 change in genericize_switch_stmt, so that the following testcase now behaves the same in both C and C++, plus adds the testcase and documentation. Bootstrapped/regtested on

Re: [C++ PATCH] Fix switch genericization ICE (PR c++/88984)

2019-01-23 Thread Jason Merrill
On 1/22/19 5:25 PM, Jakub Jelinek wrote: Hi! The following testcase ICEs, because we assert that if during parsing we haven't found any break; stmts in SWITCH_STMT_BODY, the switch statement break label will not be used. It is used in this case though, because while during parsing we expect

Re: C++ PATCH for c++/78244 - narrowing conversion in template not detected, part 2

2019-01-23 Thread Jason Merrill
On 1/22/19 4:10 PM, Marek Polacek wrote: On Mon, Jan 21, 2019 at 03:14:53PM -0500, Jason Merrill wrote: On 1/18/19 9:12 AM, Marek Polacek wrote: On Thu, Jan 17, 2019 at 04:17:29PM -0500, Jason Merrill wrote: On 1/17/19 2:09 PM, Marek Polacek wrote: This patch ought to fix the rest of 78244,

[PATCH] Fix reassoc leaving * 0 in the IL.

2019-01-23 Thread Richard Biener
$subject - on trunk the PR is hidden because those do not appear for other reasons. Still stray * 0 are prone to causing failures thus the following. On the branches this hides the SLSR bug. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk sofar. Richard. 2019-01-23

[PATCH] Remove a barrier when EDGE_CROSSING is remoed (PR lto/88858).

2019-01-23 Thread Martin Liška
Hi. The PR is about a verification error where we have a FALLTHRU edge that contains barrier instruction. The instruction is created during bbpart pass in add_labels_and_missing_jumps (emit_barrier_after_bb). At that time, the basic blocks live in a different partition (hot,cold). Later then the

Re: Mitigation for PR target/88469 on arm-based systems bootstrapping with gcc-6/7/8

2019-01-23 Thread Richard Earnshaw (lists)
On 22/01/2019 15:46, Jakub Jelinek wrote: > On Tue, Jan 22, 2019 at 02:43:38PM +, Richard Earnshaw (lists) wrote: >> PR target/88469 >> * profile-count.h (profile_count): Add dummy file with 64-bit alignment >> on arm-based systems using gcc-6/7/8. >> > >> diff --git

[patch] Fix segfault during inlining of thunk

2019-01-23 Thread Eric Botcazou
Hi, this is a regression present in Ada on the mainline since we switched to using the internal support for thunks: expand_thunk segfaults during inlining when trying to access the DECL_RESULT of the special alias built to make the call from the thunk local, if the DECL_RESULT of the thunk is

[PATCH] Fix broken filename for .gcda files starting with '..' (PR gcov-profile/88994).

2019-01-23 Thread Martin Liška
Hi. The patch fixes path creation for situations when a filename.gcda starts with e.g. '..'. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. I'll install the patch in few days. Thanks, Martin gcc/ChangeLog: 2019-01-23 Martin Liska PR gcov-profile/88994

[PATCH] rs6000: Add support for the vec_sbox_be, vec_cipher_be etc. builtins.

2019-01-23 Thread luoxhu
From: Xiong Hu Luo The 5 new builtins vec_sbox_be, vec_cipher_be, vec_cipherlast_be, vec_ncipher_be and vec_ncipherlast_be only support vector unsigned char type parameters. Add new instruction crypto_vsbox_ and crypto__ to handle them accordingly, where the new mode CR_vqdi can be expanded to

[PATCH][wwwdocs][Arm][AArch64] Update changes with new features and flags.

2019-01-23 Thread Tamar Christina
Hi All, This patch adds the documentation for Stack clash protection and Armv8.3-a support to changes.html for GCC 9. I have validated the html using the W3C validator. Ok for cvs? Thanks, Tamar -- Index: htdocs/gcc-9/changes.html

Re: [PATCH,GDC] Add netbsd support to GDC

2019-01-23 Thread coypu
(Oops, added the wrong email out of habit to the first reply :-)) On Tue, Jan 22, 2019 at 08:37:25PM +0100, Iain Buclaw wrote: > > diff --git a/gcc/d/d-builtins.cc b/gcc/d/d-builtins.cc > > index b0a315a3ed9..ca105c7635d 100644 > > --- a/gcc/d/d-builtins.cc > > +++ b/gcc/d/d-builtins.cc > > @@

Re: [patch] Fix segfault during inlining of thunk

2019-01-23 Thread Richard Biener
On Wed, Jan 23, 2019 at 10:48 AM Eric Botcazou wrote: > > Hi, > > this is a regression present in Ada on the mainline since we switched to using > the internal support for thunks: expand_thunk segfaults during inlining when > trying to access the DECL_RESULT of the special alias built to make the

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-01-23 Thread Sam Tebbs
On 14/01/2019 10:43, Kyrill Tkachov wrote: > > On 08/01/19 11:38, Sam Tebbs wrote: >> >> On 1/7/19 6:28 PM, James Greenhalgh wrote: >> > On Fri, Dec 21, 2018 at 09:00:10AM -0600, Sam Tebbs wrote: >> >> On 11/9/18 11:04 AM, Sam Tebbs wrote: >> > >> > >> > >> >> Attached is an improved patch with

[PATCH] libgcc2.c: Correct DI/TI -> SF/DF conversions

2019-01-23 Thread H.J. Lu
FSTYPE FUNC (DWtype u) in libgcc2.c, which converts DI/TI to SF/DF, has /* No leading bits means u == minimum. */ if (count == 0) return -(Wtype_MAXp1_F * (Wtype_MAXp1_F / 2)); in the third case (where actually count == 0 only means the high part is minimum). It should be: /* No

RE: [EXT] Re: [Patch 2/4][Aarch64] v2: Implement Aarch64 SIMD ABI

2019-01-23 Thread Tamar Christina
Hi Steve, > > Hi Steve, > > No we are using aarch64_be-*-* but this is the only one that popped up as a > failure which is why I didn't change the others. > But now I'm wondering why... I'll check the log file manually tomorrow to be > sure. I've checked and the reason this didn't show up is

[PATCH] Handle timeout warnings in dg-extract-results

2019-01-23 Thread Christophe Lyon
Hi, dg-extract-results currently moves lines like WARNING: program timed out at the end of each .exp section when it generates .sum files. This is because it sorts its output based on the 2nd field, which is normally the testname as in: FAIL: gcc.c-torture/execute/20020129-1.c -O2 -flto

Re: [PATCH] Update URLs in libsanitizer/README.gcc [PR Bug sanitizer/89010]

2019-01-23 Thread Jakub Jelinek
On Wed, Jan 23, 2019 at 11:30:29AM +, Jonny Grant wrote: > Not a member of this list, please include my email address in any replies. > > > 2019-01-23 Jonny Grant > > PR 89010 PR sanitizer/89010 is what should be used. > * libsanitizer/README.gcc: Update to current

[PATCH] Update URLs in libsanitizer/README.gcc [PR Bug sanitizer/89010]

2019-01-23 Thread Jonny Grant
Not a member of this list, please include my email address in any replies. 2019-01-23 Jonny Grant PR 89010 * libsanitizer/README.gcc: Update to current https URLs Index: trunk/libsanitizer/README.gcc === ---

Re: [PATCH] sched-ebb.c: avoid moving table jumps (PR rtl-optimization/88423)

2019-01-23 Thread Andrey Belevantsev
Hi David, On 18.01.2019 19:58, David Malcolm wrote: > On Fri, 2019-01-18 at 12:32 -0500, David Malcolm wrote: > > [CCing Abel] > >> PR rtl-optimization/88423 reports an ICE within sched-ebb.c's >> begin_move_insn, failing the assertion at line 175, where there's >> no fall-through edge: >> >>

[PATCH] Update assertion in sched-ebb.c to cope with table jumps

2019-01-23 Thread David Malcolm
On Wed, 2019-01-23 at 16:52 +0300, Alexander Monakov wrote: > On Wed, 23 Jan 2019, Andrey Belevantsev wrote: > > > For that, I'm not sure. Your patch will leave the tablejump > > unscheduled at > > all, i.e. any fields like INSN_TICK would be unfilled and thus the > > later > > passes like

Re: [PATCH] PR c++/87893 - constexpr ctor ICE on ARM.

2019-01-23 Thread Ramana Radhakrishnan
On Wed, Jan 23, 2019 at 1:54 PM Jason Merrill wrote: > > Since in r265788 I made cxx_eval_outermost_constant_expr more insistent that > the returned value have the right type, it became more important that > initialized_type be correct. These two PRs were cases of it giving the wrong > answer.

Re: [EXT] Re: Fortran vector math header

2019-01-23 Thread Steve Ellcey
On Wed, 2019-01-23 at 23:53 +0100, Jakub Jelinek wrote: > External Email > > --- > --- > On Wed, Jan 23, 2019 at 09:56:21PM +, Steve Ellcey wrote: > > I wonder if we even need to pass a string to the target > > hook. Instead > >

PING [PATCH] tighten up -Wbuiltin-declaration-mismatch (PR 86125, 88886, 86308)

2019-01-23 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-01/msg00969.html This patch fixes a couple of P2 regressions. It was first submitted last summer and mostly reviewed by Jeff but then slipped through the cracks. Can someone pick it up in Jeff's absence? On 1/16/19 5:41 PM, Martin Sebor wrote: On

RE: [PATCH] Implement P0966 std::string::reserve should not shrink

2019-01-23 Thread Andrew Luo
Here's an updated diff. Still a work in progress, ran the tests for strings/capacity in both modes, passing now. I am running all the tests in both modes as well, but will take a while to get results. In the meanwhile I thought I'd send this out... Also, that code works on all released

Re: [PATCH] Fix an ICE when compiling Go with LTO (PR go/89019)

2019-01-23 Thread Ian Lance Taylor
On Wed, Jan 23, 2019 at 5:18 PM Nikhil Benesch wrote: > > 2018-01-23 Nikhil Benesch > > PR go/89019 > * go-gcc.cc (Gcc_backend::placeholder_struct_type): Mark > placeholder structs as requiring structural equality. > (Gcc_backend::set_placeholder_pointer_type):

Re: Fortran vector math header

2019-01-23 Thread Jakub Jelinek
On Wed, Jan 23, 2019 at 09:56:21PM +, Steve Ellcey wrote: > I wonder if we even need to pass a string to the target hook. Instead > of: > > !GCC$ builtin (cos) attributes simd (notinbranch) if('x86_64-linux-gnu') > > We just have: > > !GCC$ builtin (cos) attributes simd (notinbranch)

[PATCH] Fix an ICE when compiling Go with LTO (PR go/89019)

2019-01-23 Thread Nikhil Benesch
This patch fixes an ICE I reported earlier today as PR go/89019, which occurs when compiling sufficiently complicated Go code with link-time optimization (i.e., -flto) enabled. Both of these simple test programs are sufficient to trigger the ICE: $ cat crash1.go package main type

[PATCH 1/2] fix tab alignment issue.

2019-01-23 Thread luoxhu
From: Xiong Hu Luo commited in r268228. --- ChangeLog 2019-01-24 Xiong Hu Luo * ChangeLog: replace space with tab. * MAINTAINERS: delete 1 tab to keep alignment. --- ChangeLog | 4 ++-- MAINTAINERS | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff

Re: PING [PATCH] tighten up -Wbuiltin-declaration-mismatch (PR 86125, 88886, 86308)

2019-01-23 Thread Joseph Myers
On Wed, 23 Jan 2019, Martin Sebor wrote: > Ping: https://gcc.gnu.org/ml/gcc-patches/2019-01/msg00969.html This patch is OK. -- Joseph S. Myers jos...@codesourcery.com

[PATCH 2/2] fix comments typo.

2019-01-23 Thread luoxhu
From: Xiong Hu Luo commited in 268229. --- gcc/ChangeLog 2019-01-24 Xiong Hu Luo * tree-ssa-dom.c (test_for_singularity): fix a comment typo. * vr-values.c (find_case_label_ranges): fix a comment typo. --- gcc/tree-ssa-dom.c | 2 +- gcc/vr-values.c| 2 +- 2 files

Re: [C++ PATCH] [PR87770] test partial specializations for type dependence

2019-01-23 Thread Alexandre Oliva
On Jan 21, 2019, Jason Merrill wrote: > "does this have its own template arguments, not just the ones from its > enclosing class?" > Perhaps compare the number of levels of template arguments of the > function to that of its enclosing context? Is this the logic you had in mind? Or can we

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-23 Thread Bernd Edlinger
On 1/23/19 4:22 PM, Jakub Jelinek wrote: > On Tue, Jan 22, 2019 at 02:10:38PM +, Bernd Edlinger wrote: >> --- gcc/c-family/c-warn.c(revision 268119) >> +++ gcc/c-family/c-warn.c(working copy) >> @@ -2796,6 +2796,10 @@ check_address_or_pointer_of_packed_membe >>if (context) >>

Re: [PATCH] Refine -Waddress-of-packed-member once more

2019-01-23 Thread Jakub Jelinek
On Thu, Jan 24, 2019 at 06:39:22AM +, Bernd Edlinger wrote: > --- gcc/c-family/c-warn.c (revision 268195) > +++ gcc/c-family/c-warn.c (working copy) > @@ -2725,14 +2725,18 @@ static tree > check_address_or_pointer_of_packed_member (tree type, tree rhs) > { >bool rvalue = true; >

libgo patch committed: Install SIGURG handler in c-archive mode

2019-01-23 Thread Ian Lance Taylor
This patch by Cherry Zhang changes the libgo runtime to install a SIGURG handler in c-archive mode. The precise stack scan uses SIGURG to trigger a stack scan, so we need to have Go signal handler installed for SIGURG. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to

Re: [Patch, fortran] PR88929 - ICE on building MPICH 3.2 with GCC 9 with ISO_Fortran_binding

2019-01-23 Thread Paul Richard Thomas
Hi Steve, Fixed in revision 268231. This was a copy/paste/modify with the type built in. Have corrected both. > > tree > > + gfc_conv_descriptor_elem_len (tree desc) > > + { > > + tree tmp; > > + tree dtype; > > + > > + dtype = gfc_conv_descriptor_dtype (desc); > > + tmp =