Re: [PATCH v2] Use edge->indirect_unknown_callee in cgraph_edge::make_direct (PR ipa/89330).

2019-08-08 Thread Martin Liška
On 8/8/19 12:08 AM, Jeff Law wrote: > Would this possibly be the cause of this error building the kernel: Probably yes. You see the same as H.J.: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91334 Can you please create a pre-processed source with and command line options? And please tell me how

Re: [PATCH] Fix file descriptor existence of MinGW.

2019-08-08 Thread Martin Liška
On 8/7/19 4:35 PM, Ian Lance Taylor wrote: > On Wed, Aug 7, 2019 at 5:09 AM Martin Liška wrote: >> >> There's one enhanced version where I added HAVE_FCNTL_H. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > I think a better name than

[committed] Support map + use_device_{addr,ptr} clauses for the same var on the same construct

2019-08-08 Thread Jakub Jelinek
Hi! OpenMP 5.0 also newly says: "If one or more of the use_device_ptr or use_device_addr clauses and one or more map clauses are present on the same construct, the address conversions of use_device_addr and use_device_ptr clauses will occur as if performed after all variables are mapped

Re: Start implementing -frounding-math

2019-08-08 Thread Marc Glisse
On Wed, 7 Aug 2019, Joseph Myers wrote: On Sat, 22 Jun 2019, Marc Glisse wrote: as discussed in the PR, this seems like a simple enough approach to handle FENV functionality safely, while keeping it possible to implement optimizations in the future. Could you give a high-level description

[testsuite] use rand instead of random

2019-08-08 Thread Alexandre Oliva
rand is in ISO C, whereas random is only in POSIX, so it makes sense to use the more portable function everywhere instead of falling back from one to the other on systems that miss the less portable one. Tested on x86_64-linux-gnu, native and cross to ppc. Ok to install? for

Re: [PATCH 9/9] Remove alias set comparison.

2019-08-08 Thread Martin Liška
On 8/7/19 5:20 PM, Martin Sebor wrote: > On 6/11/19 1:36 AM, Martin Liska wrote: >> >> gcc/ChangeLog: >> >> 2019-07-24  Martin Liska  >> >> * ipa-icf-gimple.c (func_checker::compatible_types_p): >> Do not compare alias sets.  It's handled by operand_equal_p. >> >> gcc/testsuite/ChangeLog:

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Mark Eggleston
On 07/08/2019 19:56, Steve Kargl wrote: On Wed, Aug 07, 2019 at 09:09:49AM -0700, Steve Kargl wrote: On Wed, Aug 07, 2019 at 01:58:17PM +0100, Mark Eggleston wrote: DATA statements for logical and character variable compile but do not work: program test   character(4) :: c   data c /

Re: [PATCH] Handle new operators with no arguments in DCE.

2019-08-08 Thread Martin Liška
On 8/7/19 4:12 PM, Richard Biener wrote: > On Wed, Aug 7, 2019 at 2:04 PM Martin Liška wrote: >> >> On 8/7/19 12:51 PM, Jakub Jelinek wrote: >>> On Wed, Aug 07, 2019 at 12:44:28PM +0200, Martin Liška wrote: On 8/7/19 11:51 AM, Richard Biener wrote: > I think the simplest way to achieve

Re: [PATCH] Restrict LOOP_ALIGN to loop headers only.

2019-08-08 Thread Martin Liška
On 7/11/19 11:42 AM, Richard Biener wrote: > On Wed, Jul 10, 2019 at 5:52 PM Richard Biener > wrote: >> >> On July 10, 2019 2:11:17 PM GMT+02:00, Michael Matz wrote: >>> Hi, >>> >>> On Tue, 9 Jul 2019, Richard Biener wrote: >>> > The basic block index is not a DFS index, so no, that's not a

Re: [PATCH 3/9] ifcvt: Only created temporaries as needed.

2019-08-08 Thread Robin Dapp
Hi Richard, > Is the separate need_temps scan required for correctness? It looked > like we could test: > > if (reg_overlap_mentioned_p (dest, cond)) > ... > > on-the-fly during the main noce_convert_multiple_sets loop. right, I didn't re-check it but after changes during interal

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Mark Eggleston
On 07/08/2019 17:09, Steve Kargl wrote: On Wed, Aug 07, 2019 at 01:58:17PM +0100, Mark Eggleston wrote: BOZ problems in the following areas * use of logical and character variables with BOZ constants * comparisons with BOZ constants * DATA statements Comparing 9.1 and trunk: The

Re: [PATCH 5/9] ifcvt: Allow constants operands in noce_convert_multiple_sets.

2019-08-08 Thread Robin Dapp
> It seems like this is making noce_convert_multiple_sets overlap > a lot with cond_move_process_if_block (although that uses CONSTANT_P > instead of CONST_INT_P). How do they fit together after this patch, > i.e. which cases is each one meant to handle that the other doesn't? IMHO all of icvt

[RFC] Some questions on aarch64 feature about IDC and DIC

2019-08-08 Thread Shaokun Zhang
Hi aarch64 maintainers, Question 1: In __aarch64_sync_cache_range function, if CTR_EL0.IDC = 0b1, Shall the dc cvau and the dsb ish will be removed or only dc cvau will be removed? - for (; address < (const char *) end; address += dcache_lsize) -asm volatile ("dc\tcvau, %0" -

Re: [C++ Patch] More grokdeclarator locations fixes

2019-08-08 Thread Jason Merrill
On 8/8/19 5:41 AM, Paolo Carlini wrote: Hi, these are all more or less straightforward, exploit the existing infrastructure. Nits: the first change also removes an 'a' in the wording because all the other error messages - a few - mentioning class or namespace don't have it; the fixes using

Re: [PATCH] Implement -fopt-info support for IPA ICF.

2019-08-08 Thread Jeff Law
On 8/8/19 7:04 AM, Martin Liška wrote: > Hi. > > As requested by Richi, I'm suggesting to use new dump_printf > optimization info infrastructure. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > >

Re: C++ PATCH for c++/87519 - bogus warning with -Wsign-conversion

2019-08-08 Thread Jason Merrill
On 8/8/19 10:50 AM, Marek Polacek wrote: This PR complains about bogus -Wsign-conversion warning even with an explicit cast, which the documentation says should suppress the warning. Pretty similar to c++/86190 which I fixed here . The

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Steve Kargl
On Thu, Aug 08, 2019 at 10:11:39AM +0100, Mark Eggleston wrote: > > >> Comparisons with BOZ constants was allowed using 9.1 with > >> -Wconversion-extra: > >> > >>     5 | if (i4 .eq. z'1000') then > >>   |    1 > >> Warning: Conversion from INTEGER(4) to INTEGER(16) at

Re: [C] Fix bogus nested enum error message

2019-08-08 Thread Jeff Law
On 8/5/19 3:00 AM, Richard Sandiford wrote: > For: > > enum a { A }; > enum a { B }; > > we emit a bogus error about nested definitions before the real error: > > foo.c:2:6: error: nested redefinition of ‘enum a’ > 2 | enum a { B }; > | ^ > foo.c:2:6: error: redeclaration

Re: Use predicates for RTL objects

2019-08-08 Thread Arvind Sankar
On Thu, Aug 08, 2019 at 10:42:06AM -0600, Jeff Law wrote: > On 8/5/19 12:29 PM, Segher Boessenkool wrote: > > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > >> On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > >>> First: do you have a copyright assignment?

Re: [PATCH] enable gcc.dg/struct-ret-1.c on all targets

2019-08-08 Thread Jeff Law
On 8/7/19 5:15 PM, Martin Sebor wrote: > This test is reported as UNSUPPORTED when it runs on x86_64 > and I expect everywhere else except hppa-*-*.  There's nothing > PA-RISC specific in it that I can see and it runs successfully, > so I'm thinking I'll enable it everywhere just to get rid of >

Re: [testsuite] use rand instead of random

2019-08-08 Thread Jeff Law
On 8/8/19 12:30 AM, Alexandre Oliva wrote: > rand is in ISO C, whereas random is only in POSIX, so it makes sense > to use the more portable function everywhere instead of falling back > from one to the other on systems that miss the less portable one. > > Tested on x86_64-linux-gnu, native and

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

2019-08-08 Thread Jeff Law
On 8/5/19 6:32 AM, Uros Bizjak wrote: > On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: >> >> On Sun, 4 Aug 2019, Uros Bizjak wrote: >> >>> On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: On Thu, 1 Aug 2019, Uros Bizjak wrote: > On Thu, Aug 1, 2019 at 11:28 AM

Re: [PATCH 5/9] Come up with an abstraction.

2019-08-08 Thread Michael Matz
Hi, On Mon, 10 Jun 2019, Martin Liska wrote: > 2019-07-24 Martin Liska > > * fold-const.c (operand_equal_p): Rename to ... > (operand_compare::operand_equal_p): ... this. > (add_expr): Rename to ... > (operand_compare::hash_operand): ... this. >

Re: [PATCH] issue a correct fix-it hint for bad argument in GCC diagnostics (PR 80619)

2019-08-08 Thread Jeff Law
On 8/5/19 11:51 AM, Martin Sebor wrote: > When the argument to a directive with a length modifier like %lu > in a call to a GCC diagnostic function such as warning()) is not > of the right integer type, GCC suggests to replace the length > modifier in the directive with 'w'.  For instance: > >  

[PATCH 0/3] [og9] Initial OpenACC fixes for AMD GCN

2019-08-08 Thread Julian Brown
Hi, This patch series provides basic support for OpenACC on AMD GCN, using a single worker (per-gang) only. This is enough to improve test results significantly over the previous state on the og9 branch, but bugs still remain. Further commentary attached to individual patches. Tested with

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Steve Kargl
On Thu, Aug 08, 2019 at 09:31:37AM +0100, Mark Eggleston wrote: > > On 07/08/2019 19:56, Steve Kargl wrote: > > On Wed, Aug 07, 2019 at 09:09:49AM -0700, Steve Kargl wrote: > >> On Wed, Aug 07, 2019 at 01:58:17PM +0100, Mark Eggleston wrote: > >>> DATA statements for logical and character

Re: C++ PATCH for c++/91264 - detect modifying const objects in constexpr

2019-08-08 Thread Jason Merrill
On 8/6/19 3:20 PM, Marek Polacek wrote: On Mon, Aug 05, 2019 at 03:54:19PM -0400, Jason Merrill wrote: On 7/31/19 3:26 PM, Marek Polacek wrote: One of the features of constexpr is that it doesn't allow UB; and such UB must be detected at compile-time. So running your code in a context that

[PATCH 3/3] [og9] Use a single worker for OpenACC on AMD GCN

2019-08-08 Thread Julian Brown
This patch sets the number of workers (per-gang) to 1 for AMD GCN, as a stop-gap measure until the middle-end transformations to enable multiple workers have been applied. Julian ChangeLog gcc/ * config/gcn/gcn.c (gcn_goacc_validate_dims): Ensure flag_worker_partitioning

[PATCH 2/3] [og9] Fix configury for AMD GCN testing

2019-08-08 Thread Julian Brown
This patch updates the configury for AMD GCN for version of the patch "Forward -foffload=[...] from the driver (compile-time) to libgomp (run-time)" currently applied to the og9 branch. This is necessary for OpenACC testing on AMD GCN to work properly, at least in our test environment. Julian

Re: Use predicates for RTL objects

2019-08-08 Thread Jakub Jelinek
On Thu, Aug 08, 2019 at 10:42:06AM -0600, Jeff Law wrote: > -/* Predicate yielding true iff X is an rtx for a double-int. */ > +/* Predicate yielding true iff X is an rtx for a floating point > constant. */ > #define CONST_DOUBLE_AS_FLOAT_P(X) \ > (GET_CODE (X) ==

[PATCH 1/3] [og9] Add missing exec_params libgomp plugin entry points

2019-08-08 Thread Julian Brown
This patch adds two missing (dummy) entry points to the GCN libgomp plugin. These are not used at present, because we have not enabled the function parameter flattening transformation that uses these entry points on GCN. Julian ChangeLog libgomp/ * plugin/plugin-gcn.c

C++ PATCH to add test for c++/79520

2019-08-08 Thread Marek Polacek
Fixed by r255788. Tested on x86_64-linux, applying to trunk. 2019-08-08 Marek Polacek PR c++/79520 * g++.dg/cpp1y/constexpr-79520.C: New test. --- /dev/null +++ gcc/testsuite/g++.dg/cpp1y/constexpr-79520.C @@ -0,0 +1,11 @@ +// PR c++/79520 +// { dg-do compile { target c++14

C++ PATCH for c++/87519 - bogus warning with -Wsign-conversion

2019-08-08 Thread Marek Polacek
This PR complains about bogus -Wsign-conversion warning even with an explicit cast, which the documentation says should suppress the warning. Pretty similar to c++/86190 which I fixed here . The problem only happens when using a typedef,

Re: Use predicates for RTL objects

2019-08-08 Thread Jeff Law
On 8/5/19 12:29 PM, Segher Boessenkool wrote: > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: >> On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: >>> First: do you have a copyright assignment? See >>> https://gcc.gnu.org/contribute.html >>> for instructions.

Re: C++ PATCH for c++/91346 - Implement C++2a P1668R1, allow unevaluated asm in constexpr

2019-08-08 Thread Jason Merrill
On 8/7/19 4:44 PM, Marek Polacek wrote: On Wed, Aug 07, 2019 at 10:37:04PM +0200, Jakub Jelinek wrote: On Wed, Aug 07, 2019 at 04:30:29PM -0400, Marek Polacek wrote: +/* Complain about an attempt to evaluate inline assembly. */ + +static void +inline_asm_in_constexpr_error (location_t loc) +{

Re: [C++ Patch] Improve start_function and grokmethod locations

2019-08-08 Thread Jason Merrill
On 8/6/19 8:28 AM, Paolo Carlini wrote: apparently this is now easy to do, likely because a while ago I made sure that we consistently have meaningful locations for TYPE_DECLs too. (I went through grokdeclarator and confirmed that when the third argument is FUNCDEF or MEMFUNCDEF it cannot

Re: [PATCH][GCC][AARCH64] Add effective-target check to b key execution tests

2019-08-08 Thread Jeff Law
On 8/7/19 9:57 AM, Sam Tebbs wrote: > Hi all, > > This patch adds an effective target check to the pointer authentication B key > execution tests. These were failing with an assembler error when run with a > non-recent version of binutils, and this change will instead make them > unsupported

Re: [Committed] PR fortran/54072 -- More fun with BOZ

2019-08-08 Thread Steve Kargl
On Thu, Aug 08, 2019 at 09:23:11AM -0700, Steve Kargl wrote: > On Thu, Aug 08, 2019 at 10:11:39AM +0100, Mark Eggleston wrote: > > > > >> Comparisons with BOZ constants was allowed using 9.1 with > > >> -Wconversion-extra: > > >> > > >>     5 | if (i4 .eq. z'1000') then > > >>   | 

Re: [PATCH] Sync MIPS support from libffi master repository

2019-08-08 Thread Jeff Law
On 8/5/19 2:33 PM, Aurelien Jarno wrote: > This updates the libffi MIPS support up to commit 746dbe3a6a79, with the > exception of commit bd72848c7af9 which prefixes the ALIGN macro with > FFI_ for all ports. > > These patches, with the exception of the softfloat one, have been used > on the

Re: [PATCH] Add --with-static-standard-libraries to the top level

2019-08-08 Thread Jeff Law
On 8/5/19 12:02 PM, Tom Tromey wrote: > gdb should normally not be linked with -static-libstdc++. Currently > this has not caused problems, but it's incompatible with catching an > exception thrown from a shared library -- and a subsequent patch > changes gdb to do just this. > > This patch adds

Re: C++ PATCH for c++/91264 - detect modifying const objects in constexpr

2019-08-08 Thread Marek Polacek
On Thu, Aug 08, 2019 at 11:06:17AM -0400, Jason Merrill wrote: > On 8/6/19 3:20 PM, Marek Polacek wrote: > > On Mon, Aug 05, 2019 at 03:54:19PM -0400, Jason Merrill wrote: > > > On 7/31/19 3:26 PM, Marek Polacek wrote: > > > > One of the features of constexpr is that it doesn't allow UB; and such

Re: [PATCH] [MIPS] Add missing const qualifier in MSA ld intrinsic documentation

2019-08-08 Thread Jeff Law
On 7/26/19 3:12 AM, Mihailo Stojanovic wrote: > From: Mihailo Stojanovic > > The documentation is not reflecting the fact that the first argument of > MSA ld intrinsics is a const void pointer. > > gcc/ > > * doc/extend.texi: Add const qualifier to ld intrinsics. THanks. Installed. jeff

[PATCH 2/2] rs6000: Rename DFP iterator and attr to DDTD and q

2019-08-08 Thread Segher Boessenkool
This is more in line with the other iterators we have, and a bit easier to read and write. Tested on powerpc64-linux {-m32,-m64}; committing to trunk. Segher 2019-08-08 Segher Boessenkool * config/rs6000/dfp.md (D64_D128): Rename to ... (DDTD): ... this, throughout.

[PATCH 1/2] rs6000: Use iterators in more DFP patterns

2019-08-08 Thread Segher Boessenkool
I noticed some patterns in dfp.md could use the D64_D128 iterator but don't yet. This converts all remaining simple cases. Tested on powerpc64-linux {-m32,-m64}; committing to trunk. Segher 2019-08-08 Segher Boessenkool * config/rs6000/dfp.md (D64_D128): Move earlier in the file.

Re: [PATCH] Sync MIPS support from libffi master repository

2019-08-08 Thread Jeff Law
On 8/8/19 2:56 PM, Aurelien Jarno wrote: > On 2019-08-08 14:41, Jeff Law wrote: >> On 8/5/19 2:33 PM, Aurelien Jarno wrote: >>> This updates the libffi MIPS support up to commit 746dbe3a6a79, with the >>> exception of commit bd72848c7af9 which prefixes the ALIGN macro with >>> FFI_ for all ports.

Re: [PATCH] i386: Roundeven expansion for SSE4.1+

2019-08-08 Thread Jeff Law
On 7/27/19 3:04 AM, Uros Bizjak wrote: > On Wed, Jul 24, 2019 at 12:43 PM Tejas Joshi wrote: >> >> Hi. >> This is a patch that Uros suggested for roundeven expansion, here. >> Thanks for the heads up. >> >> I have rerun the testsuite on

Re: [PATCH] Sync MIPS support from libffi master repository

2019-08-08 Thread Jeff Law
On 8/8/19 4:18 PM, Aurelien Jarno wrote: > > It is used by libgo, but it seems to be the last user. Ah, yes, I should have remembered libgo. And it links via ../../blahblah. Thanks for digging into it. So, yea, we need it. So I think the best path forward is to just resync everything to the

Re: [PATCH] Sync MIPS support from libffi master repository

2019-08-08 Thread Aurelien Jarno
On 2019-08-08 14:41, Jeff Law wrote: > On 8/5/19 2:33 PM, Aurelien Jarno wrote: > > This updates the libffi MIPS support up to commit 746dbe3a6a79, with the > > exception of commit bd72848c7af9 which prefixes the ALIGN macro with > > FFI_ for all ports. > > > > These patches, with the exception

Re: [PATCH] Provide proper error message for -flto=abcd.

2019-08-08 Thread Jeff Law
On 7/29/19 7:36 AM, Martin Liška wrote: > Hi. > > The patch is about proper error message for situations where > user give a wrong argument to -flto option. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > >

Re: [PATCH v2] Use edge->indirect_unknown_callee in cgraph_edge::make_direct (PR ipa/89330).

2019-08-08 Thread Jeff Law
On 8/8/19 1:41 AM, Martin Liška wrote: > On 8/8/19 12:08 AM, Jeff Law wrote: >> Would this possibly be the cause of this error building the kernel: > > Probably yes. You see the same as H.J.: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91334 > > Can you please create a pre-processed source

Re: [PATCH 2/9] ifcvt: Use enum instead of transform_name string.

2019-08-08 Thread Jeff Law
On 8/6/19 2:42 PM, Richard Sandiford wrote: > Robin Dapp writes: >> This patch introduces an enum for ifcvt's various noce transformations. >> As the transformation might be queried by the backend, I find it nicer >> to allow checking for a proper type instead of a string comparison. > > TBH I

Re: [Patch, ira] Invalid assert in reload1.c::finish_spills?

2019-08-08 Thread Jeff Law
On 8/7/19 8:15 AM, Vladimir Makarov wrote: > On 8/7/19 7:36 AM, senthilkumar.selva...@microchip.com wrote: >> Hi, >> >>    gcc/testsuite/c-c++-common/pr60101.c fails with an ICE for the >>    avr target, because of a gcc_assert firing at reload1.c:4233 >> >>    The assert (in the patch below)

Re: [PATCH] Sync MIPS support from libffi master repository

2019-08-08 Thread Aurelien Jarno
On 2019-08-08 15:00, Jeff Law wrote: > On 8/8/19 2:56 PM, Aurelien Jarno wrote: > > On 2019-08-08 14:41, Jeff Law wrote: > >> On 8/5/19 2:33 PM, Aurelien Jarno wrote: > >>> This updates the libffi MIPS support up to commit 746dbe3a6a79, with the > >>> exception of commit bd72848c7af9 which

Re: [PATCH 7/9] IPA ICF: remove dead code

2019-08-08 Thread Jeff Law
On 7/24/19 6:24 AM, Martin Liska wrote: > > gcc/ChangeLog: > > 2019-07-24 Martin Liska > > * ipa-icf-gimple.c (func_checker::compare_ssa_name): Call > compare_operand. > (func_checker::compare_memory_operand): Remove. > (func_checker::compare_cst_or_decl): Remove. >

Re: [PATCH 9/9] Remove alias set comparison.

2019-08-08 Thread Jeff Law
On 6/11/19 1:36 AM, Martin Liska wrote: > > gcc/ChangeLog: > > 2019-07-24 Martin Liska > > * ipa-icf-gimple.c (func_checker::compatible_types_p): > Do not compare alias sets. It's handled by operand_equal_p. > > gcc/testsuite/ChangeLog: > > 2019-07-24 Martin Liska > >

Re: [PATCH 9/9] Remove alias set comparison.

2019-08-08 Thread Martin Sebor
On 8/8/19 2:14 AM, Martin Liška wrote: On 8/7/19 5:20 PM, Martin Sebor wrote: On 6/11/19 1:36 AM, Martin Liska wrote: gcc/ChangeLog: 2019-07-24  Martin Liska  * ipa-icf-gimple.c (func_checker::compatible_types_p): Do not compare alias sets.  It's handled by operand_equal_p.

Re: Run the combine part of combine_and_move_insns even if -fsched-pressure

2019-08-08 Thread Jeff Law
On 8/7/19 12:16 PM, Richard Sandiford wrote: > The main IRA routine includes the code: > > /* Don't move insns if live range shrinkage or register > pressure-sensitive scheduling were done because it will not > improve allocation but likely worsen insn scheduling. */ > if (optimize

Re: Use predicates for RTL objects

2019-08-08 Thread Segher Boessenkool
On Thu, Aug 08, 2019 at 10:42:06AM -0600, Jeff Law wrote: > On 8/5/19 12:29 PM, Segher Boessenkool wrote: > > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > >> On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > >>> First: do you have a copyright assignment?

Re: [PATCH] fix and improve strlen conditional handling of merged stores (PR 91183, 91294, 91315)

2019-08-08 Thread Jeff Law
On 7/31/19 6:36 PM, Martin Sebor wrote: > More extensive testing of the last week's strlen patch for > PR91183 on various non-mainstream targets and with better tests > has exposed a few gaps and a couple of bugs.  The attached patch > addresses all in one change.  I considered splitting it up but

[PATCH] rs6000: Add ordered compares (PR58684)

2019-08-08 Thread Segher Boessenkool
This adds ordered compares to most unordered compares, in rs6000. It does not handle the XL_COMPAT double-double compares yet (that is the pattern with 16 operands). It also does not handle the vector compare instructions; those only exist as unordered, for the equality comparisons, or as

[PATCH,Fortran] -- Tidy up the BOZ rewrite

2019-08-08 Thread Steve Kargl
The attach patch has been regression tested on x86_64-*-freebsd. It does a number of things. 1) It tightens the adherence to F2018 Fortran standard. For example, this program and execute with gfortran 9 and older. program foo integer i data i/z'40490adf'/ ! Explicit

Re: Start implementing -frounding-math

2019-08-08 Thread Joseph Myers
On Mon, 24 Jun 2019, Marc Glisse wrote: > > OK, fair enough. I just hoped that global > > > > double x = 1.0/3.0; > > > > do not become runtime initializers with -frounding-math ... > > Ah, I wasn't thinking of globals. Ignoring the new pragma fenv_round, which I > guess could affect this

C++ PATCH for c++/90473 - wrong code with nullptr in default argument

2019-08-08 Thread Marek Polacek
This is a wrong-code bug where we are throwing away the function call in the default argument here: void fn1 (void* p = (f(), nullptr)) { } and thus dropping the possible side-effects of that call to the floor. That happens because check_default_argument returns nullptr_node when it sees a

Re: Start implementing -frounding-math

2019-08-08 Thread Joseph Myers
On Thu, 8 Aug 2019, Marc Glisse wrote: > > FENV_ROUND (and FENV_DEC_ROUND) shouldn't be that hard, given the > > On the glibc side I expect it to be a lot of work, it seems to require a > correctly rounded version of all math functions... No, it doesn't. 18661-4 reserves cr* names for

[PATCH] Implement -fopt-info support for IPA ICF.

2019-08-08 Thread Martin Liška
Hi. As requested by Richi, I'm suggesting to use new dump_printf optimization info infrastructure. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-08-08 Martin Liska * ipa-icf.c (sem_function::merge):

[MSP430][PATCH 2/2] Read MCU data from external file

2019-08-08 Thread Jozef Lawrynowicz
This patch extends the MCU data handling so that MCU data can be provided in an external file (devices.csv). This means the compiler doesn't have to be updated and rebuilt to support new devices when they are released. TI distribute devices.csv with other support files (header files, linker

[MSP430][PATCH 1/2] Consolidate handling of hard-coded MCU data

2019-08-08 Thread Jozef Lawrynowicz
This patch improves the handling of MCU data by consolidating multiple copies of hard-coded MCU data into a single location, and adds a new function to be used as a single entry point for the extraction of MCU data for the selected MCU. This ensures the data is only extracted once per invocation

Re: [PATCH] Port value profiling to -fopt-info infrastructure.

2019-08-08 Thread Jeff Law
On 8/8/19 7:04 AM, Martin Liška wrote: > Hi. > > As requested by Richi, I'm suggesting to use new dump_printf > optimization info infrastructure. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > >

Re: [PATCH 4/9] Strengthen alias_ptr_types_compatible_p in LTO mode.

2019-08-08 Thread Martin Liška
On 8/7/19 1:57 PM, Richard Biener wrote: > On Tue, Aug 6, 2019 at 5:43 PM Martin Liska wrote: > > This warrants a comment like > > /* This function originally abstracts from simply comparing > get_deref_alias_set > so that we are sure this still computes the same result after LTO > type

[PATCH] P0325R4 to_array from LFTS with updates

2019-08-08 Thread Jonathan Wakely
As an extension to what the standard requires, this also adds conditional noexcept-specifiers to the std::to_array functions. P0325R4 to_array from LFTS with updates * include/experimental/array (to_array): Qualify call to __to_array. * include/std/array

Re: Start implementing -frounding-math

2019-08-08 Thread Marc Glisse
On Thu, 8 Aug 2019, Joseph Myers wrote: On Thu, 8 Aug 2019, Marc Glisse wrote: FENV_ROUND (and FENV_DEC_ROUND) shouldn't be that hard, given the On the glibc side I expect it to be a lot of work, it seems to require a correctly rounded version of all math functions... No, it doesn't.

[PATCH] [MIPS] Fix handling of MSA SUBREG moves on big-endian targets

2019-08-08 Thread Mihailo Stojanovic
From: Mihailo Stojanovic Hi everybody, This fixes the MSA implementation on big-endian targets which is essentially broken for things like SUBREG handling and calling convention for vector types. It borrows heavily from [1] as Aarch64 has the same problem with SVE vectors. Conceptually,

[PATCH] builtin fadd variants implementation

2019-08-08 Thread Tejas Joshi
Hi. This patch includes fadd variants implementation for folding. The patch bootstraps and survives regression tests on x86_64-linux-gnu. Thanks, Tejas gcc/ChangeLog: 2019-08-08 Tejas Joshi * builtin-types.def: New function type variable arguments. * builtins.def: New function

[PATCHv4] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

2019-08-08 Thread Bernd Edlinger
On 8/2/19 9:01 PM, Bernd Edlinger wrote: > On 8/2/19 3:11 PM, Richard Biener wrote: >> On Tue, 30 Jul 2019, Bernd Edlinger wrote: >> >>> >>> I have no test coverage for the movmisalign optab though, so I >>> rely on your code review for that part. >> >> It looks OK. I tried to make it trigger on

[C++ Patch] More grokdeclarator locations fixes

2019-08-08 Thread Paolo Carlini
Hi, these are all more or less straightforward, exploit the existing infrastructure. Nits: the first change also removes an 'a' in the wording because all the other error messages - a few - mentioning class or namespace don't have it; the fixes using EXPR_LOCATION also change %qD to %qE

[MSP430][PATCH 0/2] Improve and extend MCU data handling

2019-08-08 Thread Jozef Lawrynowicz
Each different MSP430 MCU has two properties that affect code generation, the CPU ISA and the hardware multiply support. These can be manually specified with the -mcpu= and -mhwmult= options, respectively. The existing -mmcu= option takes an MCU name as an argument and uses the CPU ISA and

[PATCH] Port value profiling to -fopt-info infrastructure.

2019-08-08 Thread Martin Liška
Hi. As requested by Richi, I'm suggesting to use new dump_printf optimization info infrastructure. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-08-08 Martin Liska * value-prof.c

Re: [testsuite] use rand instead of random

2019-08-08 Thread Segher Boessenkool
On Thu, Aug 08, 2019 at 03:30:55AM -0300, Alexandre Oliva wrote: > rand is in ISO C, whereas random is only in POSIX, so it makes sense > to use the more portable function everywhere instead of falling back > from one to the other on systems that miss the less portable one. > > Tested on

Re: [PATCH] Restrict LOOP_ALIGN to loop headers only.

2019-08-08 Thread Michael Matz
Hi, On Thu, 8 Aug 2019, Martin Liška wrote: > > So docs have > > > > @defmac JUMP_ALIGN (@var{label}) > > The alignment (log base 2) to put in front of @var{label}, which is > > a common destination of jumps and has no fallthru incoming edge. So, per docu: JUMP_ALIGN implies !fallthru ... > >