Re: Fix MIPS call-clobbered-*.c tests

2019-10-02 Thread Jeff Law
On 10/2/19 5:47 AM, Richard Sandiford wrote: > Jeff pointed out that gcc.target/mips/call-clobbered-4.c started > failing after the function-abi series. This is because IRA used > to treat partly call-clobbered registers as hard conflicts and > so wouldn't consider them for -fcaller-saves. Now

Re: [PR47785] COLLECT_AS_OPTIONS

2019-10-02 Thread Richard Biener
On Wed, Oct 2, 2019 at 10:39 AM Kugan Vivekanandarajah wrote: > > Hi, > > As mentioned in the PR, attached patch adds COLLECT_AS_OPTIONS for > passing assembler options specified with -Wa, to the link-time driver. > > The proposed solution only works for uniform -Wa options across all > TUs. As

Re: [patch] range-ops contribution

2019-10-02 Thread Richard Biener
On Tue, Oct 1, 2019 at 8:07 PM Jeff Law wrote: > > On 10/1/19 11:11 AM, Aldy Hernandez wrote: > > Hi folks. > > > > Here is my official submission of the range-ops part of the ranger to > > mainline. > > > > I realize that I could have split this patch up into 2-3 separate ones, > > but I don't

Re: [C++ PATCH] PR c++/91369 - Implement P0784R7: constexpr new

2019-10-02 Thread Jakub Jelinek
Hi! Thanks for the review, let me start with the unrelated bugfixes then and deal with the rest later. On Tue, Oct 01, 2019 at 05:56:00PM -0400, Jason Merrill wrote: > > @@ -3905,7 +4033,7 @@ cxx_eval_store_expression (const constex > > bool no_zero_init = true; > > releasing_vec ctors;

Re: [patch] range-ops contribution

2019-10-02 Thread Aldy Hernandez
On 10/2/19 8:19 AM, Andrew MacLeod wrote: On 10/2/19 6:52 AM, Richard Biener wrote: + +/* Return the inverse of a range.  */ + +void +value_range_base::invert () +{ +  if (undefined_p ()) +    return; +  if (varying_p ()) +    set_undefined (); +  else if (m_kind == VR_RANGE) +    m_kind =

[OG9] Comitted backport of: [Patch][Fortran] Vastly improve error message during parsing – simple patch for OpenMP/OpenACC directives

2019-10-02 Thread Tobias Burnus
Simply committing that patch to the GCC's git OG9 branch as 32568a014c678e09a251dd3c5f64618779f036f5 Tobias

Re: [patch] range-ops contribution

2019-10-02 Thread Andrew MacLeod
On 10/2/19 6:52 AM, Richard Biener wrote: + +/* Return the inverse of a range. */ + +void +value_range_base::invert () +{ + if (undefined_p ()) +return; + if (varying_p ()) +set_undefined (); + else if (m_kind == VR_RANGE) +m_kind = VR_ANTI_RANGE; + else if (m_kind ==

Fix another -Wodr ICE

2019-10-02 Thread Jan Hubicka
Hi, this patch finally makes cactusBSSN working. The logic which was supposed to get anonymous namespace type first (if it exists) was wrong as was caught by a subsetquent assert. Bootstrapped/regtested x86_64-linux, comitted. Honza Index: ChangeLog

Re: -O2 inliner returning 1/n: reduce EARLY_INLINING_INSNS for O1 and O2

2019-10-02 Thread Jan Hubicka
> On Tue, Oct 01, 2019 at 07:04:53PM +0200, Jan Hubicka wrote: > > * gcc.dg/tree-ssa/ssa-thread-12.c: Mark compure_idf inline. > > > --- testsuite/gcc.dg/tree-ssa/ssa-thread-12.c (revision 276272) > > +++ testsuite/gcc.dg/tree-ssa/ssa-thread-12.c (working copy) > > @@ -56,7 +56,7

[PATCH] Split out stmt transform from vectorizable_reduction

2019-10-02 Thread Richard Biener
I've done only "trivial" pruning of unnecessary code to reduce the chance of functional changes. Cleanup will happen as followup. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-10-02 Richard Biener * tree-vectorizer.h (vect_transform_reduction):

Fix MIPS call-clobbered-*.c tests

2019-10-02 Thread Richard Sandiford
Jeff pointed out that gcc.target/mips/call-clobbered-4.c started failing after the function-abi series. This is because IRA used to treat partly call-clobbered registers as hard conflicts and so wouldn't consider them for -fcaller-saves. Now that we treat call clobbers the same way regardless of

Re: [01/32] Add function_abi.{h,cc}

2019-10-02 Thread Richard Sandiford
Bernd Edlinger writes: > Hi, > > I am currently trying to implement -Wshadow=local, and > this patch triggers a build-failure with -Wshadow=local > since i is a parameter that is the regno. > But it is also used as loop variable, > so I think this introduces probably a bug: > >> @@ -728,7 +731,11

Re: -O2 inliner returning 1/n: reduce EARLY_INLINING_INSNS for O1 and O2

2019-10-02 Thread Jakub Jelinek
On Tue, Oct 01, 2019 at 07:04:53PM +0200, Jan Hubicka wrote: > * gcc.dg/tree-ssa/ssa-thread-12.c: Mark compure_idf inline. > --- testsuite/gcc.dg/tree-ssa/ssa-thread-12.c (revision 276272) > +++ testsuite/gcc.dg/tree-ssa/ssa-thread-12.c (working copy) > @@ -56,7 +56,7 @@ bmp_iter_and_compl

Re: [PATCH] Fix PR91606

2019-10-02 Thread Nathan Sidwell
On 10/2/19 6:07 AM, Richard Biener wrote: A middle-end change exposed that the C++ FE handling of pointer-to-member aggregates in cxx_get_alias_set isn't effective. The following patch makes it so by design by marking the structure members as not being aliased (there can be no pointers like

Re: [PATCH] Add some hash_map_safe_* functions like vec_safe_*.

2019-10-02 Thread Richard Biener
On Tue, Oct 1, 2019 at 8:50 PM Jason Merrill wrote: > > On 10/1/19 3:34 AM, Richard Biener wrote: > > On Mon, Sep 30, 2019 at 8:33 PM Jason Merrill wrote: > >> > >> My comments accidentally got lost. > >> > >> Several places in the front-end (and elsewhere) use the same lazy > >> allocation

[Patch][Fortran] Vastly improve error message during parsing – simple patch for OpenMP/OpenACC directives

2019-10-02 Thread Tobias Burnus
Simple patch – large effect. Currently, gfortran prints for any parsing issue in !$omp (-fopenmp) and likewise for !$acc (-fopenacc) just:     8 | !$omp target data  map(to:a) is_device_ptr(a)   |  1 Error: Unclassifiable OpenMP directive at (1) This patch adds a new error message –

[Patch, Fortran, OpenMP] Support OpenMP 5.0's use_device_addr

2019-10-02 Thread Tobias Burnus
This patch adds the first OpenMP 5 feature to gfortran – which is trivial as it justs adds some parsing, the heavy lifting is already done in the middle end. (Minus bugs.) Additionally, I add a check for "is_device_ptr" – which is explicitly is specified in the OpenMP 4.5/5.0 spec. (i.e.

Re: [SVE] PR91532

2019-10-02 Thread Richard Biener
On Tue, 1 Oct 2019, Jeff Law wrote: > On 10/1/19 12:40 AM, Richard Biener wrote: > > On Mon, 30 Sep 2019, Prathamesh Kulkarni wrote: > > > >> On Wed, 25 Sep 2019 at 23:44, Richard Biener wrote: > >>> > >>> On Wed, 25 Sep 2019, Prathamesh Kulkarni wrote: > >>> > On Fri, 20 Sep 2019 at

Re: [PATCH, Fortran] Optionally suppress no-automatic overwrites recursive warning - for approval

2019-10-02 Thread Mark Eggleston
On 28/09/2019 17:50, Steve Kargl wrote: On Thu, Sep 26, 2019 at 09:45:28AM +0100, Mark Eggleston wrote: Original thread starts here https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01185.html OK to commit? I'm not a big fan of option proliferation. If you don't want to see warns just use -w.

[PATCH] Split out PHI transform from vectorizable_reduction

2019-10-02 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-10-02 Richard Biener * tree-vectorizer.h (stmt_vec_info_type::cycle_phi_info_type): New. (vect_transform_cycle_phi): Declare. * tree-vect-stmts.c (vect_transform_stmt): Call

Re: [Patch][omp-low.c,fortran] Simple fix for optional argument handling with OpenMP's use_device_ptr

2019-10-02 Thread Jakub Jelinek
On Tue, Oct 01, 2019 at 04:19:11PM +0200, Tobias Burnus wrote: > OK for the trunk? Ok, with a small formatting nit below. > --- a/gcc/fortran/trans-openmp.c > +++ b/gcc/fortran/trans-openmp.c > @@ -47,6 +47,15 @@ along with GCC; see the file COPYING3. If not see > > int ompws_flags; > >

[PATCH] Fix PR91606

2019-10-02 Thread Richard Biener
A middle-end change exposed that the C++ FE handling of pointer-to-member aggregates in cxx_get_alias_set isn't effective. The following patch makes it so by design by marking the structure members as not being aliased (there can be no pointers like __pfn or __delta) thus making them behave

[PATCH] Fix build with GCC 4.3

2019-10-02 Thread Richard Biener
Which complains libcpp/internal.h:129: error: comma at end of enumerator list Committed as obvious. Richard. Index: libcpp/internal.h === --- libcpp/internal.h (revision 276439) +++ libcpp/internal.h (working copy) @@ -126,7

Re: [patch, libgomp] testsuite remove alloca header

2019-10-02 Thread Thomas Schwinge
Hi! On 2019-09-30T15:22:52+0200, Jakub Jelinek wrote: > On Mon, Sep 30, 2019 at 03:16:00PM +0200, Andreas Tobler wrote: >> here on FreeBSD we lack the alloca.h header so two test cases fail to >> compile. >> >> Do the same as I did six years ago for another test case: 'Remove alloca.h >> and

Re: [SVE] PR91532

2019-10-02 Thread Richard Biener
On Wed, 2 Oct 2019, Prathamesh Kulkarni wrote: > On Wed, 2 Oct 2019 at 01:08, Jeff Law wrote: > > > > On 10/1/19 12:40 AM, Richard Biener wrote: > > > On Mon, 30 Sep 2019, Prathamesh Kulkarni wrote: > > > > > >> On Wed, 25 Sep 2019 at 23:44, Richard Biener wrote: > > >>> > > >>> On Wed, 25 Sep

Re: [Patch][Fortran] Vastly improve error message during parsing – simple patch for OpenMP/OpenACC directives

2019-10-02 Thread Jakub Jelinek
Hi! Nice! On Wed, Oct 02, 2019 at 11:24:46AM +0200, Tobias Burnus wrote: > gcc/fortran/ > * openmp.c (gfc_match_omp_clauses): Show a clause-parsing > error if none was rised before. > * parse.c (matcha, matcho): If error occurred after > OpenMP/OpenACC directive

Re: [Patch, Fortran, OpenMP] Support OpenMP 5.0's use_device_addr

2019-10-02 Thread Jakub Jelinek
On Wed, Oct 02, 2019 at 11:59:46AM +0200, Tobias Burnus wrote: > This patch adds the first OpenMP 5 feature to gfortran – which is trivial as > it justs adds some parsing, the heavy lifting is already done in the middle > end. (Minus bugs.) > > Additionally, I add a check for "is_device_ptr" –

[PR47785] COLLECT_AS_OPTIONS

2019-10-02 Thread Kugan Vivekanandarajah
Hi, As mentioned in the PR, attached patch adds COLLECT_AS_OPTIONS for passing assembler options specified with -Wa, to the link-time driver. The proposed solution only works for uniform -Wa options across all TUs. As mentioned by Richard Biener, supporting non-uniform -Wa flags would require

Re: [RFC][Fortran,patch] %C error diagnostic location

2019-10-02 Thread Tobias Burnus
Hi all, I looked at error messages – and I like it. – Please review. There is actually a "fallout": One testsuite case actually checks for the row location – I didn't even know that one can do it that way. That's fixed by the attached patch (I also included the original patch). OK for the

[PATCH] Allow vectorization of __builtin_bswap16 (PR tree-optimization/91940)

2019-10-02 Thread Jakub Jelinek
On Wed, Nov 09, 2016 at 09:14:55AM +0100, Richard Biener wrote: > The following implements vectorization of bswap via VEC_PERM_EXPR > on the corresponding QImode vector. > > ARM already has backend handling via the builtin_vectorized_call > hook and thus there were already testcases available.

Re: [PATCH] Allow vectorization of __builtin_bswap16 (PR tree-optimization/91940)

2019-10-02 Thread Richard Biener
On Wed, 2 Oct 2019, Jakub Jelinek wrote: > On Wed, Nov 09, 2016 at 09:14:55AM +0100, Richard Biener wrote: > > The following implements vectorization of bswap via VEC_PERM_EXPR > > on the corresponding QImode vector. > > > > ARM already has backend handling via the builtin_vectorized_call > >

Re: [patch] Extend GIMPLE store merging to throwing stores

2019-10-02 Thread Eric Botcazou
> that works for me - the patch is OK with that change. Thanks. In the end, I went for your solution and the helper is called unsplit_eh_edges, which is even more explicit than unsplit_all_eh. * tree-eh.h (unsplit_eh_edges): Declare. * tree-eh.c

Re: [patch] range-ops contribution

2019-10-02 Thread Andrew MacLeod
On 10/2/19 9:36 AM, Richard Sandiford wrote: Andrew MacLeod writes: On 10/2/19 6:52 AM, Richard Biener wrote: + +/* Return the inverse of a range. */ + +void +value_range_base::invert () +{ + if (undefined_p ()) +return; + if (varying_p ()) +set_undefined (); + else if (m_kind ==

Re: [IRA] Handle fully-tied destinations in a similar way to earlyclobbers

2019-10-02 Thread Vladimir Makarov
On 2019-09-30 10:40 a.m., Richard Sandiford wrote: IRA's make_early_clobber_and_input_conflicts checks for cases in which an output operand is likely to be an earlyclobber and an input operand is unlikely to be tieable with it. If so, the allocno for the output conflicts with the allocno for

[PR testsuite/91842] Skip gcc.dg/ipa/ipa-sra-19.c on power

2019-10-02 Thread Martin Jambor
Hi, I seem to remember I minimized gcc.dg/ipa/ipa-sra-19.c on power but perhaps I am wrong because the testcase fails there with a power-specific error: gcc.dg/ipa/ipa-sra-19.c:19:3: error: AltiVec argument passed to unprototyped function I am going to simply skip it there with the following

-O2 inline retuning 2/n: enable -finline-functions for O2

2019-10-02 Thread Jan Hubicka
Hi, this patch enables -finline-functions at -O2 and trottles it down by means of new parameters --param max-inline-insns-auto-O2 (set to 15 instead 30) --param max-inline-insns-single-O2 (set to 30 instead 200) --param inline-min-speedup-O2 (set to 30 instead 15) Overall effect of both

[PATCH] Remove greedy wildcards from libstdc++ linker script

2019-10-02 Thread Jonathan Wakely
The only symbols matched by std::e[a-q]* and std::e[s-z]* that are supposed to be in the GLIBCXX_3.4 version are std::exception::* and std::endl and std::ends. The latter two already have explicit patterns matching them, so we just need to match std::exception::*. This change ensures that any

Re: [PATCH] Automatics in equivalence statements

2019-10-02 Thread Mark Eggleston
Thanks, as you point out all the test needs to do is verify that that a variable with an AUTOMATIC attribute can be used in an EQUIVALENCE and and that the items in the EQUIVALENCE are on the stack by using in a recursive routine. I've created a patch to replace the existing test cases and

Re: [PATCH, Fortran] Fix Automatics in equivalence test cases was Re: Automatics in Equivalences failures

2019-10-02 Thread Steve Kargl
On Wed, Oct 02, 2019 at 02:36:55PM +0100, Mark Eggleston wrote: > Please find attached a patch to replace the test cases for "Automatic in > equivalence". > > ChangeLog: > >     Mark Eggleston > >     * gfortran.dg/auto_in_equiv_1.f90: Deleted. >     * gfortran.dg/auto_in_equiv_2.f90:

Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-02 Thread Aaron Sawdey
On 10/1/19 4:45 PM, Jeff Law wrote: > On 9/27/19 12:23 PM, Aaron Sawdey wrote: >> This is the third piece of my effort to improve inline expansion of memmove. >> The >> first two parts I posted back in June fixed the names of the optab entries >> involved so that optab cpymem is used for memcpy()

Re: [PATCH] Disable tests that aren't valid in parallel mode

2019-10-02 Thread Jonathan Wakely
On 01/10/19 21:59 +0100, Jonathan Wakely wrote: Tested x86_64-linux (normal and parallel modes), committed to trunk. commit b11c8f480fe1cd5696ec1a8f0db481c5f45429b8 Author: Jonathan Wakely Date: Tue Oct 1 20:31:51 2019 +0100 Disable tests that aren't valid in parallel mode Tests

[PATCH, Fortran] Fix Automatics in equivalence test cases was Re: Automatics in Equivalences failures

2019-10-02 Thread Mark Eggleston
Please find attached a patch to replace the test cases for "Automatic in equivalence". ChangeLog:     Mark Eggleston     * gfortran.dg/auto_in_equiv_1.f90: Deleted.     * gfortran.dg/auto_in_equiv_2.f90: Deleted.     * gfortran.dg/auto_in_equiv_3.f90: Deleted.     *

Re: [patch] range-ops contribution

2019-10-02 Thread Richard Sandiford
Andrew MacLeod writes: > On 10/2/19 6:52 AM, Richard Biener wrote: >> + +/* Return the inverse of a range. */ + +void +value_range_base::invert () +{ + if (undefined_p ()) +return; + if (varying_p ()) +set_undefined (); + else if

Re: [PATCH, Fortran] Fix Automatics in equivalence test cases was Re: Automatics in Equivalences failures

2019-10-02 Thread Jakub Jelinek
On Wed, Oct 02, 2019 at 02:36:55PM +0100, Mark Eggleston wrote: > ChangeLog: > >     Mark Eggleston > >     * gfortran.dg/auto_in_equiv_1.f90: Deleted. >     * gfortran.dg/auto_in_equiv_2.f90: Deleted. >     * gfortran.dg/auto_in_equiv_3.f90: Deleted. >     *

Silecne bogus -Wmaybe-uninitialized warning

2019-10-02 Thread Jan Hubicka
Hi, this patch silences -Wmaybe-uninitialized warning when GCC is built with -finline-functions (which I am working to make part of -O2). Bootstrapped/regtested x86_64-linux, comitted as obvious. Honza * module.c (load_commons): Initialize flags to 0 to silecne

Re: [C++ PATCH] PR c++/91369 - Implement P0784R7: constexpr new

2019-10-02 Thread Jason Merrill
On 10/2/19 7:36 AM, Jakub Jelinek wrote: Hi! Thanks for the review, let me start with the unrelated bugfixes then and deal with the rest later. On Tue, Oct 01, 2019 at 05:56:00PM -0400, Jason Merrill wrote: @@ -3905,7 +4033,7 @@ cxx_eval_store_expression (const constex bool no_zero_init

Re: [PATCH] Builtin fadd variants folding implementation

2019-10-02 Thread Martin Jambor
Hi Joseph, could you please have a look at this latest version of the patch introducing fadd et al.? There already is a pre-approved folllow-up somewhere expanding it on power but we need to get this in first. Thanks, Martin On Wed, Sep 11 2019, Tejas Joshi wrote: > Hi. > This patch includes

Re: Ping: question on Multiple level macro expansion

2019-10-02 Thread Joseph Myers
This is not a bug (except in icc, since you said icc accepts the code). gcc-help would have been a better mailing list for this sort of question. -- Joseph S. Myers jos...@codesourcery.com

Re: [RFC][Fortran,patch] %C error diagnostic location

2019-10-02 Thread Steve Kargl
On Wed, Oct 02, 2019 at 11:26:17AM +0200, Tobias Burnus wrote: > Hi all, > > I looked at error messages – and I like it. – Please review. > > There is actually a "fallout": One testsuite case actually checks for > the row location – I didn't even know that one can do it that way. > > That's

Re: [PATCH] Simplify sinh (x) / cosh (x)

2019-10-02 Thread Rafael Tsuha
Hi Jeff, I've just checked and the proposed optimization is under -funsafe-math-optimizations and canonicalize_math_p(): `(if (flag_unsafe_math_optimizations && canonicalize_math_p ())` I'm sorry, but I don't quite understand what you mean with 'using those expanders in an unexpected way',

Ping ---A bug with -fprofile-dir? Profile directory concatenated with object file path

2019-10-02 Thread Qing Zhao
Ping on: https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01554.html Anyway, I filed an gcc bug on this issue as: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91971 If you think that

Ping: question on Multiple level macro expansion

2019-10-02 Thread Qing Zhao
Hi, This is a ping on: https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01628.html Anyway, I filed a gcc bug on this issue: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91973 If you

Re: [PR testsuite/91842] Skip gcc.dg/ipa/ipa-sra-19.c on power

2019-10-02 Thread Rainer Orth
Hi Martin, > I seem to remember I minimized gcc.dg/ipa/ipa-sra-19.c on power but > perhaps I am wrong because the testcase fails there with a > power-specific error: > > gcc.dg/ipa/ipa-sra-19.c:19:3: error: AltiVec argument passed to > unprototyped function > > I am going to simply skip it there

Re: [C++ Patch] More cp_expr_loc_or_input_loc and DECL_SOURCE_LOCATION uses

2019-10-02 Thread Jason Merrill
On 9/30/19 8:24 AM, Paolo Carlini wrote: Hi, a few more in init.c and name-lookup.c, respectively. Tested x86_64-linux, as usual. Thanks, Paolo. /// OK.

Re: [RFH][libgcc] fp-bit bit ordering (PR 78804)

2019-10-02 Thread Oleg Endo
On Tue, 2019-10-01 at 14:21 -0600, Jeff Law wrote: > > So the ask is to just test this on some LE targets? I can do that :-) > > I'll throw it in. Analysis will be slightly more difficult than > usual > as we've got some fallout from Richard S's work, but it's certainly > do-able. Thanks a

Re: [RFH][libgcc] fp-bit bit ordering (PR 78804)

2019-10-02 Thread Jeff Law
On 10/2/19 10:51 AM, Oleg Endo wrote: > On Tue, 2019-10-01 at 14:21 -0600, Jeff Law wrote: >> >> So the ask is to just test this on some LE targets? I can do that :-) >> >> I'll throw it in. Analysis will be slightly more difficult than >> usual >> as we've got some fallout from Richard S's

Re: [patch] range-ops contribution

2019-10-02 Thread Jeff Law
On 10/2/19 6:56 AM, Aldy Hernandez wrote: >>> diff --git a/gcc/range.cc b/gcc/range.cc >>> new file mode 100644 >>> index 000..5e4d90436f2 >>> --- /dev/null >>> +++ b/gcc/range.cc >> [ ... ] >>> + >>> +value_range_base >>> +range_intersect (const value_range_base , const value_range_base

Re: [patch, libgomp] testsuite remove alloca header

2019-10-02 Thread Andreas Tobler
On 02.10.19 12:19, Thomas Schwinge wrote: Hi! On 2019-09-30T15:22:52+0200, Jakub Jelinek wrote: On Mon, Sep 30, 2019 at 03:16:00PM +0200, Andreas Tobler wrote: here on FreeBSD we lack the alloca.h header so two test cases fail to compile. Do the same as I did six years ago for another test

[C++ PATCH] Improve C++ fold caching efficiency.

2019-10-02 Thread Jason Merrill
While looking at concepts caching I noticed that we were clearing the caches unnecessarily for non-constant initialization, which shouldn't affect folding. Tested x86_64-pc-linux-gnu, applying to trunk. * typeck2.c (store_init_value): Only clear_cv_and_fold_caches if the value is

libgo patch committed: mark go-context.S as no-exec-stack, split-stack

2019-10-02 Thread Ian Lance Taylor
This libgo patch marks go-context.S as no-executable-stack and split-stack supported. The .note.GNU-stack section tells the linker that this object does not require an executable stack. The .note.GNU-split-stack section tells the linker that functions in this object can be called directly by

Re: [PATCH], V4, patch #4.1: Enable prefixed/pc-rel addressing (revised)

2019-10-02 Thread Michael Meissner
On Tue, Oct 01, 2019 at 06:56:01PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Mon, Sep 30, 2019 at 10:12:54AM -0400, Michael Meissner wrote: > > I needed > > to add a second memory constraint ('eM') that prevents using a prefixed > > address. > > Do we need both em and eM? Do we ever

Re: [PATCH] Add some hash_map_safe_* functions like vec_safe_*.

2019-10-02 Thread Jason Merrill
On 10/2/19 4:28 AM, Richard Biener wrote: On Tue, Oct 1, 2019 at 8:50 PM Jason Merrill wrote: On 10/1/19 3:34 AM, Richard Biener wrote: On Mon, Sep 30, 2019 at 8:33 PM Jason Merrill wrote: My comments accidentally got lost. Several places in the front-end (and elsewhere) use the same

Re: [PATCH 4/4] Modifications to the testsuite

2019-10-02 Thread Andreas Schwab
FAIL: gcc.dg/ipa/ipa-sra-19.c (test for excess errors) Excess errors: /daten/gcc/gcc-20191001/gcc/testsuite/gcc.dg/ipa/ipa-sra-19.c:19:3: error: AltiVec argument passed to unprototyped function /daten/gcc/gcc-20191001/gcc/testsuite/gcc.dg/ipa/ipa-sra-19.c:17:12: warning: GCC vector returned by

Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-02 Thread Jakub Jelinek
On Wed, Oct 02, 2019 at 09:21:23AM -0500, Aaron Sawdey wrote: > >> 2019-09-27 Aaron Sawdey > >> > >>* builtins.c (expand_builtin_memory_copy_args): Add might_overlap parm. > >>(expand_builtin_memcpy): Use might_overlap parm. > >>(expand_builtin_mempcpy_args): Use might_overlap parm.

Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove()

2019-10-02 Thread Aaron Sawdey
On 10/2/19 5:35 PM, Jakub Jelinek wrote: > On Wed, Oct 02, 2019 at 09:21:23AM -0500, Aaron Sawdey wrote: 2019-09-27 Aaron Sawdey * builtins.c (expand_builtin_memory_copy_args): Add might_overlap parm. (expand_builtin_memcpy): Use might_overlap parm.

Re: [PATCH 4/4] Modifications to the testsuite

2019-10-02 Thread Segher Boessenkool
On Wed, Oct 02, 2019 at 09:29:22PM +0200, Andreas Schwab wrote: > FAIL: gcc.dg/ipa/ipa-sra-19.c (test for excess errors) > Excess errors: > /daten/gcc/gcc-20191001/gcc/testsuite/gcc.dg/ipa/ipa-sra-19.c:19:3: error: > AltiVec argument passed to unprototyped function >

Fix ALL_REGS thinko in initialisation of function_used_regs

2019-10-02 Thread Richard Sandiford
My change to the -fipa-ra bookkeeping used ALL_REGS as the supposedly safe default assumption, but ALL_REGS isn't literally all registers, just a close approximation. This caused a bootstrap failure on arm-linux-gnu, where the condition code register isn't in ALL_REGS and so was being masked out

Re: [PATCH] Builtin fadd variants folding implementation

2019-10-02 Thread Joseph Myers
On Wed, 11 Sep 2019, Tejas Joshi wrote: > diff --git a/gcc/builtins.def b/gcc/builtins.def > index 8bb7027aac7..2df616c477e 100644 > --- a/gcc/builtins.def > +++ b/gcc/builtins.def > @@ -355,6 +355,9 @@ DEF_EXT_LIB_FLOATN_NX_BUILTINS (BUILT_IN_FABS, "fabs", > FABS_TYPE, ATTR_CONST_NOT >

Re: [PATCH], V4, patch #4.1: Enable prefixed/pc-rel addressing (revised)

2019-10-02 Thread Segher Boessenkool
On Wed, Oct 02, 2019 at 03:04:35PM -0400, Michael Meissner wrote: > On Tue, Oct 01, 2019 at 06:56:01PM -0500, Segher Boessenkool wrote: > > On Mon, Sep 30, 2019 at 10:12:54AM -0400, Michael Meissner wrote: > > > I needed > > > to add a second memory constraint ('eM') that prevents using a prefixed

Re: Fix ALL_REGS thinko in initialisation of function_used_regs

2019-10-02 Thread Segher Boessenkool
On Wed, Oct 02, 2019 at 10:22:22PM +0100, Richard Sandiford wrote: > My change to the -fipa-ra bookkeeping used ALL_REGS as the supposedly > safe default assumption, but ALL_REGS isn't literally all registers, > just a close approximation. > > This caused a bootstrap failure on arm-linux-gnu,

[PATCH] mention referenced object in more -Wstringop-overflow instances

2019-10-02 Thread Martin Sebor
The attached patch adds an optional argument to compute_builtin_object_size to let it return the DECL of the object whose size it's called to compute. This lets -Wstringop-overflow point to the object in more instances of the warning than it does now (but by no means all of them -- more work is

Re: [SVE] PR86753

2019-10-02 Thread Prathamesh Kulkarni
On Wed, 25 Sep 2019 at 09:17, Prathamesh Kulkarni wrote: > > On Mon, 16 Sep 2019 at 08:54, Prathamesh Kulkarni > wrote: > > > > On Mon, 9 Sep 2019 at 09:36, Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 9 Sep 2019 at 16:45, Richard Sandiford > > > wrote: > > > > > > > > Prathamesh

Define WIDTH macros for C2x

2019-10-02 Thread Joseph Myers
As part of the integration of TS 18661-1 into C2x, many features became unconditional features not depending on any feature test macro being defined. This patch updates the conditionals on the *_WIDTH macros in limits.h and stdint.h accordingly so that they are defined for C2x. The macro

Re: [PATCH target/86811] Mark VAX as not needing speculation barriers

2019-10-02 Thread Maciej W. Rozycki
On Fri, 20 Sep 2019, Jeff Law wrote: > > According to Bob Supnik (who is a very authoritative source on VAX), > > > >> Funny you should ask. The short answer is no. No VAX ever did > >> speculative or out of order execution. > > > > As such, marking VAX as not needing speculation barriers. > >

Re: [PATCH][RFC] Add new ipa-reorder pass

2019-10-02 Thread Fangrui Song
On 2019-09-24, Martin Liška wrote: On 9/19/19 10:33 AM, Martin Liška wrote: - One needs modified binutils and I that would probably require a configure detection. The only way which I see is based on ld --version. I'm planning to make the binutils submission soon. The patch submission

Re: [PATCH target/86811] Mark VAX as not needing speculation barriers

2019-10-02 Thread Jeff Law
On 10/2/19 8:12 PM, Maciej W. Rozycki wrote: > On Fri, 20 Sep 2019, Jeff Law wrote: > >>> According to Bob Supnik (who is a very authoritative source on VAX), >>> Funny you should ask. The short answer is no. No VAX ever did speculative or out of order execution. >>> >>> As such,