Implement ggc_trim

2019-10-11 Thread Jan Hubicka
Hi, this patch adds ggc_trim that releases free pages used by GGC memory to system. This is useful to reduce memory footprint of WPA streaming: WPA streaming ought to not use any more GGC memory (patches in testing for that) and trimming the memory makes it available to fork used by stream out

Re: C++ PATCH to merge concepts-cxx2a branch

2019-10-11 Thread Christophe Lyon
On Thu, 10 Oct 2019 at 23:38, Jason Merrill wrote: > On Thu, Oct 10, 2019 at 3:55 PM Christophe Lyon < > christophe.l...@linaro.org> wrote: > >> On Thu, 10 Oct 2019 at 01:44, Romain Geissler >> wrote: >> >>> Le mer. 9 oct. 2019 à 19:20, Jason Merrill a écrit : >>> > >>> > Andrew has done a lot

[PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-11 Thread Jakub Jelinek
On Thu, Oct 10, 2019 at 05:38:21PM -0400, Jason Merrill wrote: > > FAIL: g++.dg/cpp2a/constexpr-dtor3.C -std=c++2a (test for excess errors) > > Excess errors: > > /gcc/testsuite/g++.dg/cpp2a/constexpr-dtor3.C:152:12: in 'constexpr' > > expansion of '(& w13)->W7::~W7()' > > > > This also seems

[Ada] Emit debug info for named numbers

2019-10-11 Thread Eric Botcazou
You can declare named numbers in Ada with the syntax: Pi : constant := 3.14159 and the compiler automatically resolves the underlying type. But it wouldn't emit debug info for the declaration although DW_TAG_constant is a perfect fit. Tested on x86_64-suse-linux, applied on the mainline.

[Ada] Fix ICE on instantiation on unconstrained array with predicate

2019-10-11 Thread Eric Botcazou
This fixes an ICE on the instantiation of a generic package taking an unconstrained array type declared with a predicate as generic actual parameter. Tested on x86_64-suse-linux, applied on the mainline. 2019-10-11 Eric Botcazou * gcc-interface/decl.c (Gigi_Equivalent_Type) : New

[Ada] Fix incorrect annotation for -gnatR

2019-10-11 Thread Eric Botcazou
This fixes a thinko in an earlier match of mine for the annotation of integer constants in expressions: we really need to test the sign of the value when deciding to build a NEGATE_EXPR. Tested on x86_64-suse-linux, applied on all active branches. 2019-10-11 Eric Botcazou *

Avid ggc_alloc and push_cfun during LTO streaming

2019-10-11 Thread Jan Hubicka
Hi, this patch prevents tree creation druing WPA stream out (to avoid touching pages and triggering COW). It fixes the following - gimple streamer produces MEM_REF wrappings for global decls. This is to preserve the type of access and is not necessary for WPA->LTRANS streaming when decls

Re: [PATCH, v2] Extend subst to simplify CONST_INT inside SIGN_EXTEND.

2019-10-11 Thread Segher Boessenkool
Hi! On Thu, Oct 10, 2019 at 03:16:36PM -0700, Jim Wilson wrote: > This addresses PR 91860 which has four testcases triggering internal errors. > The problem here is that in combine when handling debug insns, we are trying > to substitute > (sign_extend:DI (const_int 8160 [0x1fe0])) > as the value

Re: [PATCH v4 7/7] S/390: Test signaling FP comparison instructions

2019-10-11 Thread Ilya Leoshkevich
> Am 07.10.2019 um 18:27 schrieb Andreas Krebbel : > > On 01.10.19 15:27, wrote: >> gcc/testsuite/ChangeLog: >> >> 2019-08-09 Ilya Leoshkevich >> >> PR target/77918 >> * gcc.target/s390/s390.exp: Enable Fortran tests. >> * gcc.target/s390/zvector/autovec-double-quiet-eq.c:

Re: [PATCH v4 6/7] S/390: Use signaling FP comparison instructions

2019-10-11 Thread Ilya Leoshkevich
> Am 07.10.2019 um 18:19 schrieb Andreas Krebbel : > > On 01.10.19 15:27, Ilya Leoshkevich wrote: >> dg-torture.exp=inf-compare-1.c is failing, because (qNaN > +Inf) >> comparison is compiled to CDB instruction, which does not signal an >> invalid operation exception. KDB should have been used

[Ada] Accept size for record with oversized component clause

2019-10-11 Thread Eric Botcazou
This makes the compiler accept again an exact size clause for a record type that contains both a component subject to a representation clause that gives it a size greater than its nominal size and another component that is aliased. Tested on x86_64-suse-linux, applied on the mainline.

Re: Implement ggc_trim

2019-10-11 Thread Richard Biener
On October 11, 2019 9:03:53 AM GMT+02:00, Jan Hubicka wrote: >Hi, >this patch adds ggc_trim that releases free pages used by GGC memory >to system. This is useful to reduce memory footprint of WPA streaming: >WPA streaming ought to not use any more GGC memory (patches in testing >for that) and

[Ada] Assorted gigi tweaks

2019-10-11 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on the mainline. 2019-10-11 Eric Botcazou * gcc-interface/decl.c (elaborate_reference_1): Specifically deal with pointer displacement. * gcc-interface/decl.c (components_to_record): Use proper name. *

Re: [PATCH][ARM] Tweak HONOR_REG_ALLOC_ORDER

2019-10-11 Thread Wilco Dijkstra
Hi Ramana, > My only question would be whether it's more suitable to use > optimize_function_for_size_p(cfun) instead as IIRC that gives us a > chance with lto rather than the global optimize_size. Yes that is even better and that defaults to optimize_size if cfun isn't set. I've committed this:

Re: [PATCH] PR fortran/92018 -- BOZ the gift that keeps giving

2019-10-11 Thread Janne Blomqvist
On Wed, Oct 9, 2019 at 2:14 AM Steve Kargl wrote: > > Tested on x86_64-*-freebsd. OK to commit? > > A BOZ literal constant can be an actual argument in a > very limited number of intrinsic subprograms. For those > intrinsics subprograms, the BOZ literal constant is converted > either during

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Marek Polacek
On Fri, Oct 11, 2019 at 05:14:33PM +0200, Paolo Carlini wrote: > Hi, > > On 11/10/19 15:37, Marek Polacek wrote: > > > > > Index: cp/decl.c > > > === > > > --- cp/decl.c (revision 276845) > > > +++ cp/decl.c (working copy) >

Re: [PATCH] add __has_builtin (PR 66970)

2019-10-11 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2019-10/msg00062.html On 10/1/19 11:16 AM, Martin Sebor wrote: Attached is an implementation of the __has_builtin special preprocessor operator/macro analogous to __has_attribute and (hopefully) compatible with the synonymous Clang feature (I couldn't

Support _Decimal* keywords for C2x

2019-10-11 Thread Joseph Myers
ISO C2x adds decimal floating point as an optional standard feature. This patch accordingly makes GCC accept the _Decimal* keywords in strict C2x mode, using pedwarn_c11 to get a warning for -Wc11-c2x-compat. (Constants, where the pedwarn is in libcpp, will be dealt with separately.) The

Re: [PATCH][AArch64] Fix symbol offset limit

2019-10-11 Thread Wilco Dijkstra
Hi Richard, > If global_char really is a char then isn't that UB? No why? We can do all kinds of arithmetic based on pointers, either using pointer types or converted to uintptr_t. Note that the optimizer actually creates these expressions, for example arr[N-x] can be evaluated as ([0] + N) -

Re: [PATCH][ARM] Tweak HONOR_REG_ALLOC_ORDER

2019-10-11 Thread Ramana Radhakrishnan
On Fri, Oct 11, 2019 at 3:52 PM Wilco Dijkstra wrote: > > Hi Ramana, > > > My only question would be whether it's more suitable to use > > optimize_function_for_size_p(cfun) instead as IIRC that gives us a > > chance with lto rather than the global optimize_size. > > Yes that is even better and

Re: [PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-11 Thread Jason Merrill
On 10/11/19 4:20 AM, Jakub Jelinek wrote: On Thu, Oct 10, 2019 at 05:38:21PM -0400, Jason Merrill wrote: FAIL: g++.dg/cpp2a/constexpr-dtor3.C -std=c++2a (test for excess errors) Excess errors: /gcc/testsuite/g++.dg/cpp2a/constexpr-dtor3.C:152:12: in 'constexpr' expansion of '(&

Re: [PATCH] V5, #6 of 15: Make vector load/store instruction length correct with prefixed addresses

2019-10-11 Thread Segher Boessenkool
Hi! On Wed, Oct 09, 2019 at 04:26:20PM -0400, Michael Meissner wrote: > --- gcc/config/rs6000/vsx.md (revision 276713) > +++ gcc/config/rs6000/vsx.md (working copy) > @@ -1149,10 +1149,14 @@ (define_insn "vsx_mov_64bit" > "vecstore, vecload, vecsimple, mffgpr,mftgpr,

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Jason Merrill
On 10/11/19 6:58 AM, Paolo Carlini wrote: Hi, another straightforward DECL_SOURCE_LOCATION (TYPE_MAIN_DECL consistent with the one I used in build_anon_union_vars. Tested x86_64-linux. Thanks, Paolo. / OK. Jason

Support decimal floating-point constants in C2x

2019-10-11 Thread Joseph Myers
ISO C2x adds decimal floating point as an optional standard feature. This patch accordingly makes GCC accept DFP constants (DF, DD, DL, df, dd, dl suffixes) in strict C2X mode, with a pedwarn-if-pedantic for older standards and a warning with -Wc11-c2x-compat even in C2x mode (which in turn

[C++ PATCH] Preserve the location of explicitly defaulted functions.

2019-10-11 Thread Jason Merrill
While working on operator<=> I noticed that a diagnostic referring to an explicitly defaulted function was using the location of the class, rather than the location of the declaration. We change DECL_SOURCE_LOCATION of implicitly declared functions to indicate where they were first needed, but I

Attendees of IOT Solutions World Congress 2019

2019-10-11 Thread Nadia Dach
Greeting, I was wondering if you be interested in acquiring the list of visitors who are going to attend the show IOT Solutions World Congress on BARCELONA - 29-31 OCTOBER 2019 Total visitors' counts: 16,000 Each record in the list contains: Company name, contact name, job titles, phone number,

C++ PATCH to add test for c++/92070

2019-10-11 Thread Marek Polacek
Also fixed by r276906. Tested on x86_64-linux, applying to trunk. 2019-10-11 Marek Polacek PR c++/92070 - bogus error with -fchecking=2. * g++.dg/expr/cond17.C: New test. diff --git gcc/testsuite/g++.dg/expr/cond17.C gcc/testsuite/g++.dg/expr/cond17.C new file mode 100644

Re: [PATCH][ARM] Switch to default sched pressure algorithm

2019-10-11 Thread Wilco Dijkstra
Hi, > the defaults for v7-a are still to use the > Cortex-A8 scheduler I missed that part, but that's a serious bug btw - Cortex-A8 is 15 years old now so way beyond obsolete. Even Cortex-A53 is ancient now, but it has an accurate scheduler that performs surprisingly well on both in-order

Re: [PATCH] V5, #5 of 15: Support -fstack-protect and large stack frames

2019-10-11 Thread Segher Boessenkool
On Wed, Oct 09, 2019 at 04:22:06PM -0400, Michael Meissner wrote: > This patch allows -fstack-protect to work with large stack frames. I don't understand; please explain. What I see is a workaround for not properly handling prefixed addresses in the stack protect code (by forcing the addresses

Re: [PATCH] V5, #3 of 15: Deal with prefixed instructions in rs6000_insn_cost

2019-10-11 Thread Segher Boessenkool
Hi! On Wed, Oct 09, 2019 at 04:03:16PM -0400, Michael Meissner wrote: > The basic problem is if there is no explicit cost predicate, rs6000_insn_cost > uses the instruction size to figure out how many instructions are present, and > make the cost a fact on that. Since prefixed instructions are

Meet Visitors of IOT Solutions World Congress 2019

2019-10-11 Thread Darby Howe
Greeting, I was wondering if you be interested in acquiring the list of visitors who are going to attend the show IOT Solutions World Congress on BARCELONA - 29-31 OCTOBER 2019 Total visitors' counts: 16,000 Each record in the list contains: Company name, contact name, job titles, phone number,

C++ PATCH for c++/92062 - ODR-use ignored for static member of class template

2019-10-11 Thread Marek Polacek
has_value_dependent_address wasn't stripping location wrappers so it gave the wrong answer for "" in the static_assert. That led us to thinking that the expression isn't instantiation-dependent, and we skipped static initialization of A<0>::x. This patch adds stripping so that

Re: Type representation in CTF and DWARF

2019-10-11 Thread Indu Bhagat
On 10/11/2019 04:23 AM, Richard Biener wrote: Thanks for your pointers. CTF does not encode location information. So, I used early exit in the add_src_coords_attributes to avoid generation of location info (file, line, column). To answer Richard's question, CTF does have type debug info for

Re: [PATCH][ARM] Enable arm_legitimize_address for Thumb-2

2019-10-11 Thread Ramana Radhakrishnan
On Fri, Oct 11, 2019 at 5:17 PM Wilco Dijkstra wrote: > > Hi Ramana, > > >On Mon, Sep 9, 2019 at 6:03 PM Wilco Dijkstra wrote: > >> > >> Currently arm_legitimize_address doesn't handle Thumb-2 at all, resulting > >> in > >> inefficient code. Since Thumb-2 supports similar address offsets use

[C++ Patch] Remove most uses of in_system_header_at

2019-10-11 Thread Paolo Carlini
Hi, as promised, this removes most uses of the predicate. I left alone the two occurrences in decl.c which guard permerrors, not warnings, and two more in parser.c which should be a (minor) optimization (particularly that in cp_parser_cast_expression). Tested x86_64-linux. Thanks, Paolo.

Re: [C++ Patch] Remove most uses of in_system_header_at

2019-10-11 Thread Jakub Jelinek
On Fri, Oct 11, 2019 at 11:48:27PM +0200, Paolo Carlini wrote: > --- decl.c(revision 276903) > +++ decl.c(working copy) > @@ -9328,7 +9328,6 @@ grokfndecl (tree ctype, > } > /* 17.6.3.3.5 */ > if (suffix[0] != '_' > - && !in_system_header_at (location)

Re: [PATCH] PR fortran/89943 -- Duplicate BIND(c) allowed (?)

2019-10-11 Thread Steve Kargl
PING. On Fri, Oct 04, 2019 at 03:26:53PM -0700, Steve Kargl wrote: > The attached patch allows the declaration of a BIND(C) > module function or module subroutine to appear in a > submodule (see testcases). Regression test was clean. > OK to commit? > > Before a rubber stamped 'OK'. I do NOT

Re: C++ PATCH for c++/92049 - extra error with -fchecking=2

2019-10-11 Thread Jason Merrill
On 10/10/19 8:08 PM, Marek Polacek wrote: The concepts merge brought this bit @@ -26326,9 +26559,9 @@ build_non_dependent_expr (tree expr) unexpected recursive instantiations. */ && !parsing_nsdmi () /* Don't do this during concept expansion either and for - the

Re: [PATCH] V5, #4 of 15: Update predicates

2019-10-11 Thread Segher Boessenkool
On Wed, Oct 09, 2019 at 04:07:50PM -0400, Michael Meissner wrote: > It also adds two new predicates that disallow prefixed memory that will used > in > patches #5 and #7. Then you should have really introduced them in *those* patches. > 2019-10-08 Michael Meissner > > *

Re: [PATCH] PR fortran/91943 -- More BOZ fallout

2019-10-11 Thread Janne Blomqvist
On Tue, Oct 1, 2019 at 1:23 AM Steve Kargl wrote: > > A BOZ cannot be an actual argument in a subroutine or function > reference except those intrinsic function listed in the Fortran > standard. The attach patch checks for invalid BOZ. Built and > tested on x86_64-*-freebsd. OK to commit? > >

[PATCH] PR libstdc++/92059 fix several bugs in tr2::dynamic_bitset

2019-10-11 Thread Jonathan Wakely
PR libstdc++/92059 * include/tr2/dynamic_bitset (__dynamic_bitset_base): Define all special member functions as defaulted. Add noexcept to most members. (__dynamic_bitset_base(size_t, unsigned long long, const _Alloc&)): Mask off unwanted bits in the __val

Re: [PATCH] Fix PR c++/92024

2019-10-11 Thread Jason Merrill
On 10/10/19 2:06 PM, Bernd Edlinger wrote: On 10/10/19 7:49 PM, Jason Merrill wrote: On 10/10/19 10:42 AM, Bernd Edlinger wrote: Hi, this fixes a crash when -Wshadow=compatible-local is enabled in the testcase g++.dg/parse/crash68.C Why does that flag cause this crash?

Re: [PATCH] Fix PR c++/92024

2019-10-11 Thread Bernd Edlinger
On 10/11/19 6:31 PM, Jason Merrill wrote: > On 10/10/19 2:06 PM, Bernd Edlinger wrote: >> On 10/10/19 7:49 PM, Jason Merrill wrote: >>> On 10/10/19 10:42 AM, Bernd Edlinger wrote: Hi, this fixes a crash when -Wshadow=compatible-local is enabled in the testcase

[committed] Relax store_bit_field call in store_expr

2019-10-11 Thread Richard Sandiford
store_bit_field already takes a poly_uint64 size, so we can relax the INTVAL to rtx_to_poly_int64. This is tested by the SVE ACLE patches. Tested on aarch64-linux-gnu and x86_64-linux-gnu, applied as obvious. Richard 2019-10-11 Richard Sandiford gcc/ * expr.c (store_expr): Use

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Paolo Carlini
Hi, On 11/10/19 15:37, Marek Polacek wrote: Index: cp/decl.c === --- cp/decl.c (revision 276845) +++ cp/decl.c (working copy) @@ -4992,7 +4992,8 @@ check_tag_decl (cp_decl_specifier_seq *declspecs, if (TREE_CODE

Re: Fix unchecked use of tree_to_uhwi in tree-ssa-strlen.c

2019-10-11 Thread Martin Sebor
On 10/11/19 8:47 AM, Richard Sandiford wrote: r273783 introduced an unchecked use of tree_to_uhwi. This is tested by the SVE ACLE patches, but could potentially trigger in non-SVE cases too. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? I wasn't able to come up with a C

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Paolo Carlini
Hi again... On 11/10/19 17:30, Paolo Carlini wrote: Oh nice, I wasn't aware of that, to be honest, probably we should audit the front-end for more such redundant uses. ... and I can confirm that we have *many*. If we agree that removing all of them is the way to go I can do that in a follow

Re: [PATCH] bring -Warray-bounds closer to -Wstringop-overflow (PR91647, 91463, 91679)

2019-10-11 Thread Martin Sebor
On 9/10/19 4:35 PM, Jeff Law wrote: On 9/6/19 1:27 PM, Martin Sebor wrote: Recent enhancements to -Wstringop-overflow improved the warning to the point that it detects a superset of the problems -Warray- bounds is intended detect in character accesses.  Because both warnings detect overlapping 

[PATCH] S/390: Run %a0:DI splitters only after reload

2019-10-11 Thread Ilya Leoshkevich
Bootstrapped and regtested on s390x-redhat-linux. gcc/ChangeLog: 2019-10-10 Ilya Leoshkevich * config/s390/s390.md: Run %a0:DI splitters only after reload. gcc/testsuite/ChangeLog: 2019-10-10 Ilya Leoshkevich * gcc.target/s390/load-thread-pointer-once.c: New test. ---

Fix unchecked use of tree_to_uhwi in tree-ssa-strlen.c

2019-10-11 Thread Richard Sandiford
r273783 introduced an unchecked use of tree_to_uhwi. This is tested by the SVE ACLE patches, but could potentially trigger in non-SVE cases too. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Richard 2019-10-11 Richard Sandiford gcc/ * tree-ssa-strlen.c

[PATCH][GCC][ARM] Arm generates out of range conditional branches in Thumb2 (PR91816)

2019-10-11 Thread Stam Markianos-Wright
Hi all, This is a patch for an issue where the compiler was generating a conditional branch in Thumb2, which was too far for b{cond} to handle. This was originally reported at binutils: https://sourceware.org/bugzilla/show_bug.cgi?id=24991 And then raised for GCC:

Re: [PATCH] PR fortran/91714 -- Mangled type-spec

2019-10-11 Thread Janne Blomqvist
On Sat, Sep 28, 2019 at 10:16 PM Steve Kargl wrote: > > The attached patch issues errors for a few mangled type-specs. > It has been regression tested on x86_64-*-freebsd. OK to commit? > > 2019-09-28 Steven G. Kargl > > PR fortran/91714 > * decl.c (gfc_match_decl_type_spec):

Re: [PATCH][ARM] Enable arm_legitimize_address for Thumb-2

2019-10-11 Thread Wilco Dijkstra
Hi Ramana, >On Mon, Sep 9, 2019 at 6:03 PM Wilco Dijkstra wrote: >> >> Currently arm_legitimize_address doesn't handle Thumb-2 at all, resulting in >> inefficient code. Since Thumb-2 supports similar address offsets use the Arm >> legitimization code for Thumb-2 to get significant codesize and

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Marek Polacek
On Fri, Oct 11, 2019 at 05:54:43PM +0200, Paolo Carlini wrote: > Hi, > > On 11/10/19 17:52, Jakub Jelinek wrote: > > On Fri, Oct 11, 2019 at 05:34:16PM +0200, Paolo Carlini wrote: > > > Hi again... > > > > > > On 11/10/19 17:30, Paolo Carlini wrote: > > > > Oh nice, I wasn't aware of that, to be

Add a constant_range_value_p function (PR 92033)

2019-10-11 Thread Richard Sandiford
The range-tracking code has a pretty hard-coded assumption that is_gimple_min_invariant is equivalent to "INTEGER_CST or invariant ADDR_EXPR". It seems better to add a predicate specifically for that rather than contiually fight cases in which it can't handle other invariants. Tested on

[PATCH] Use __is_same_as for std::is_same and std::is_same_v

2019-10-11 Thread Jonathan Wakely
By using the built-in we don't need to match a partial specialization for std::is_same and don't need to instantiate std::is_same at all for uses of std::is_same_v. * include/std/type_traits (is_same): Replace partial specialization by using __is_same_as built-in in primary

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Paolo Carlini
Hi, On 11/10/19 17:52, Jakub Jelinek wrote: On Fri, Oct 11, 2019 at 05:34:16PM +0200, Paolo Carlini wrote: Hi again... On 11/10/19 17:30, Paolo Carlini wrote: Oh nice, I wasn't aware of that, to be honest, probably we should audit the front-end for more such redundant uses. ... and I can

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Paolo Carlini
Hi, On 11/10/19 17:23, Marek Polacek wrote: I mean the latter; pedwarn will check for diagnostic_report_warnings_p so the pedwarn will not trigger in a system header unless -Wsystem-headers even without that check. Oh nice, I wasn't aware of that, to be honest, probably we should audit the

[PATCH] Avoid warnings in

2019-10-11 Thread Jonathan Wakely
* include/bits/charconv.h (__to_chars_len): Avoid -Wsign-compare warnings. Tested x86_64-linux. Committed to trunk. commit 0839fa95cf5775f0022b35cda01bb0d6c27ca08a Author: Jonathan Wakely Date: Fri Oct 11 16:10:24 2019 +0100 Avoid warnings in *

[SLP] SLP vectorization: vectorize vector constructors

2019-10-11 Thread Joel Hutton
Hi Richard, Thanks for your help, I've reworked my SLP RFC based on your feedback. > I think a better place for the loop searching for CONSTRUCTORs is > vect_slp_analyze_bb_1 where I'd put it before the check you remove, > and I'd simply append found CONSTRUCTORs to the grouped_stores > array

Re: [PATCH] PR fortran/91943 -- More BOZ fallout

2019-10-11 Thread Steve Kargl
On Fri, Oct 11, 2019 at 05:55:45PM +0300, Janne Blomqvist wrote: > On Tue, Oct 1, 2019 at 1:23 AM Steve Kargl > wrote: > > > > A BOZ cannot be an actual argument in a subroutine or function > > reference except those intrinsic function listed in the Fortran > > standard. The attach patch checks

Re: [PATCH] PR fortran/91714 -- Mangled type-spec

2019-10-11 Thread Steve Kargl
On Fri, Oct 11, 2019 at 05:57:04PM +0300, Janne Blomqvist wrote: > On Sat, Sep 28, 2019 at 10:16 PM Steve Kargl > wrote: > > > > The attached patch issues errors for a few mangled type-specs. > > It has been regression tested on x86_64-*-freebsd. OK to commit? > > > > 2019-09-28 Steven G. Kargl

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Jakub Jelinek
On Fri, Oct 11, 2019 at 05:34:16PM +0200, Paolo Carlini wrote: > Hi again... > > On 11/10/19 17:30, Paolo Carlini wrote: > > Oh nice, I wasn't aware of that, to be honest, probably we should audit > > the front-end for more such redundant uses. > > ... and I can confirm that we have *many*. If

Re: [C++ Patch] Remove RROTATE_EXPR and LROTATE_EXPR handling

2019-10-11 Thread Paolo Carlini
Hi, On 11/10/19 18:25, Jason Merrill wrote: On 10/10/19 2:33 PM, Paolo Carlini wrote: Hi, On 10/10/19 19:57, Jason Merrill wrote: On 10/10/19 1:53 PM, Jakub Jelinek wrote: On Thu, Oct 10, 2019 at 06:12:02PM +0200, Paolo Carlini wrote: while working on cp_build_binary_op I noticed that the

New Finnish PO file for 'gcc' (version 9.1.0)

2019-10-11 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Finnish team of translators. The file is available at: https://translationproject.org/latest/gcc/fi.po (This file, 'gcc-9.1.0.fi.po', has

Re: [PATCH][ARM] Switch to default sched pressure algorithm

2019-10-11 Thread Wilco Dijkstra
Hi Ramana, > Can you see what happens with the Cortex-A8 or Cortex-A9 schedulers to > spread the range across some v7-a CPUs as well ? While they aren't that > popular today I > would suggest you look at them because the defaults for v7-a are still to use > the > Cortex-A8 scheduler and the

Re: [Darwin, machopic 4/n, committed] Arrange to indirect IVARs when needed.

2019-10-11 Thread Mike Stump
On Oct 10, 2019, at 12:25 PM, Iain Sandoe wrote: > > Objective C V2 (m64) IVAR offset refs from Apple GCC-4.x have an indirection > for m64 code on PPC (which is the only 64b user for Mach-O PIC). Apple GCC > 4.x places the indirections in the .data section, however this seems to have > been

Add expr_callee_abi

2019-10-11 Thread Richard Sandiford
This turned out to be useful for the SVE PCS support, and is a natural tree-level analogue of insn_callee_abi. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Richard 2019-10-11 Richard Sandiford gcc/ * function-abi.h (expr_callee_abi): Declare. *

Re: Ping: [C][C++] Avoid exposing internal details in aka types

2019-10-11 Thread Marek Polacek
On Fri, Oct 11, 2019 at 03:14:09PM +0100, Richard Sandiford wrote: > Marek Polacek writes: > > On Thu, Oct 10, 2019 at 08:00:53PM +0100, Richard Sandiford wrote: > >> Ping > >> > >> Richard Sandiford writes: > >> > The current aka diagnostics can sometimes leak internal details that > >> > seem

Re: [PATCH] PR fortran/92019 -- BOZ cannot be an array index

2019-10-11 Thread Janne Blomqvist
On Wed, Oct 9, 2019 at 11:26 PM Steve Kargl wrote: > > The attach patch fixes an ICE caused by the use of a bOZ as > an array index. Tested on x86_64-*-freebsd. OK to commit? > > 2019-10-09 Steven G. Kargl > > PR fortran/92019 > * array.c (match_subscript): BOZ cannot be an

[PATCH] Implement header for C++20

2019-10-11 Thread Jonathan Wakely
There are currently no tests for [concepts.compare], but they will be added ASAP. * include/Makefile.am: Add new header. * include/Makefile.in: Regenerate. * include/precompiled/stdc++.h: Include . * include/std/concepts: New header for C++20. *

Re: [C++ Patch] Remove RROTATE_EXPR and LROTATE_EXPR handling

2019-10-11 Thread Jason Merrill
On 10/10/19 2:33 PM, Paolo Carlini wrote: Hi, On 10/10/19 19:57, Jason Merrill wrote: On 10/10/19 1:53 PM, Jakub Jelinek wrote: On Thu, Oct 10, 2019 at 06:12:02PM +0200, Paolo Carlini wrote: while working on cp_build_binary_op I noticed that the testsuite wasn't exercising the warnings in

Go patch commited: Mangle dots in pkgpath

2019-10-11 Thread Ian Lance Taylor
The Go frontend needs to mangle dots to avoid problems with -fgo-pkgpath=a.0. That will confuse the name mangling, which assumes that names entering the mangling cannot contain arbitrary dot characters. We don't need to mangle other characters; go_encode_id will handle them. This patch fixes

Re: [PATCH][ARM] Switch to default sched pressure algorithm

2019-10-11 Thread Ramana Radhakrishnan
On Fri, Oct 11, 2019 at 10:42 PM Wilco Dijkstra wrote: > > Hi, > > > the defaults for v7-a are still to use the > > Cortex-A8 scheduler > > I missed that part, but that's a serious bug btw - Cortex-A8 is 15 years old > now so > way beyond obsolete. Even Cortex-A53 is ancient now, but it has an

[PATCH] PR fortran/90297 -- Remove code with no functional effect

2019-10-11 Thread Steve Kargl
The patch is fairly self-explanatory. OK to commit? 2019-10-11 Steven G. Kargl PR fortran/90297 * resolve.c (resolve_typebound_function): Remove code with no functional effect. -- Steve Index: gcc/fortran/resolve.c

[PATCH] PR fortran/91513 -- Fix poorly worded error message

2019-10-11 Thread Steve Kargl
In PR fortran/91513, Damian Rouson points out that the Fortran does contain the words "impure variable". Damian and I spent an afternoon together a few weeks ago where I gave Damian a world wind view of how I see gcc/fortran and go about debugging problems. Damian and I both have full schedules,

Re: [PATCH] PR fortran/91513 -- Fix poorly worded error message

2019-10-11 Thread Steve Kargl
On Fri, Oct 11, 2019 at 09:56:15PM -0700, Steve Kargl wrote: > In PR fortran/91513, Damian Rouson points out that the Fortran > does contain the words "impure variable". Geez. That is a messed up sentence. In PR fortran/91513, Damian Rouson points out that the Fortran *standard* does *not*

[PATCH] rs6000: -flto forgets 'no-vsx' function attributes (PR target/70010)

2019-10-11 Thread Jiufu Guo
Hi, As expected in the PR, when a function is marked with no-vsx, we would assume user has good reason to disable VSX code generation for the function. To avoid VSX code generation, this function should not be inlined into VSX function. In previous implementation, function with non-vsx is

Re: [PATCH][ARM] Switch to default sched pressure algorithm

2019-10-11 Thread Ramana Radhakrishnan
On Fri, Oct 11, 2019 at 6:19 PM Wilco Dijkstra wrote: > > Hi Ramana, > > > Can you see what happens with the Cortex-A8 or Cortex-A9 schedulers to > > spread the range across some v7-a CPUs as well ? While they aren't that > > popular today I > > would suggest you look at them because the

Re: [PATCH] Fix PR92046

2019-10-11 Thread Rainer Orth
Hi Christophe, > On Thu, 10 Oct 2019 at 16:01, Richard Biener wrote: > >> >> The following fixes a few param adjustments that are made based on >> per-function adjustable flags by moving the adjustments to their >> users. Semantics change in some minor ways but that's allowed >> for --params.

Re: [SH][committed] Fix PR 88630

2019-10-11 Thread Oleg Endo
On Fri, 2019-10-11 at 00:36 +0900, Oleg Endo wrote: > Hi, > > When we did the refactoring of SH's FPSCR handling back in GCC 5, we > missed one thing regarding ST-40, it seems. > > The attached patch fixes the issue as confirmed on the real > hardware. > Also tested on sh-sim with > make -k

Re: [RFH][libgcc] fp-bit bit ordering (PR 78804)

2019-10-11 Thread Oleg Endo
Hi Bernd, On Sun, 2019-09-29 at 08:49 +, Bernd Edlinger wrote: > > But I cannot tell if the bitfield access generates > more efficient code or identical code than the > original variant when no ms bitfields are used. > That needs closer inspection of the generated > assembler code, a simple

Re: [PATCH] Fix PR92046

2019-10-11 Thread Christophe Lyon
On Thu, 10 Oct 2019 at 16:01, Richard Biener wrote: > > The following fixes a few param adjustments that are made based on > per-function adjustable flags by moving the adjustments to their > users. Semantics change in some minor ways but that's allowed > for --params. > > Bootstrapped and

Re: [RFH][libgcc] fp-bit bit ordering (PR 78804)

2019-10-11 Thread Oleg Endo
On Thu, 2019-10-03 at 19:34 -0600, Jeff Law wrote: > > So probably the most interesting target for this test is v850-elf as > it's got a reasonably well functioning simulator, hard and soft FP > targets, little endian, and I'm familiar with its current set of > failures. > > I can confirm that

[patch,Fortran] PR 92050 - fix ICE with -fcheck=all

2019-10-11 Thread Tobias Burnus
Checking produces extra code (unsurprisingly); this code needs to end up in the program… Bootstrapped on x86-64_gnu-linux. OK for the trunk? Tobias diff --git a/gcc/fortran/trans-expr.c b/gcc/fortran/trans-expr.c index 965ab7786a1..65238ff623d 100644 --- a/gcc/fortran/trans-expr.c +++

[C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Paolo Carlini
Hi, another straightforward DECL_SOURCE_LOCATION (TYPE_MAIN_DECL consistent with the one I used in build_anon_union_vars. Tested x86_64-linux. Thanks, Paolo. / /cp 2019-10-11 Paolo Carlini * decl.c (check_tag_decl): Use DECL_SOURCE_LOCATION. /testsuite

Re: [PATCH][AArch64] Set SLOW_BYTE_ACCESS

2019-10-11 Thread Richard Biener
On Thu, Oct 10, 2019 at 8:06 PM Richard Sandiford wrote: > > Wilco Dijkstra writes: > > ping > > > > Contrary to all documentation, SLOW_BYTE_ACCESS simply means accessing > > bitfields by their declared type, which results in better codegeneration on > > practically > > any target. > > The

Re: Type representation in CTF and DWARF

2019-10-11 Thread Jakub Jelinek
On Fri, Oct 11, 2019 at 01:23:12PM +0200, Richard Biener wrote: > > (coreutils-0.22) > > .debug_info(D1) | .debug_abbrev(D2) | .debug_str(D4) | .ctf > > (uncompressed) | ratio (.ctf/(D1+D2+0.5*D4)) > > ls 30616 |1136 |21098 | 26240 > > |

Re: [patch,Fortran] PR 92050 - fix ICE with -fcheck=all

2019-10-11 Thread Steve Kargl
On Fri, Oct 11, 2019 at 12:17:49PM +0200, Tobias Burnus wrote: > Checking produces extra code (unsurprisingly); this code needs to end up > in the program… > > Bootstrapped on x86-64_gnu-linux. OK for the trunk? > OK. -- Steve

Re: [C++ Patch] One more DECL_SOURCE_LOCATION

2019-10-11 Thread Marek Polacek
On Fri, Oct 11, 2019 at 12:58:41PM +0200, Paolo Carlini wrote: > Hi, > > another straightforward DECL_SOURCE_LOCATION (TYPE_MAIN_DECL consistent with > the one I used in build_anon_union_vars. Tested x86_64-linux. > > Thanks, Paolo. > > / > /cp > 2019-10-11 Paolo Carlini

Re: Ping: [C][C++] Avoid exposing internal details in aka types

2019-10-11 Thread Richard Sandiford
Richard Sandiford writes: > Marek Polacek writes: >> On Thu, Oct 10, 2019 at 08:00:53PM +0100, Richard Sandiford wrote: >>> Ping >>> >>> Richard Sandiford writes: >>> > The current aka diagnostics can sometimes leak internal details that >>> > seem more likely to be distracting than useful.

Re: [PATCH] Fix parser to recognize operator?:

2019-10-11 Thread Marek Polacek
On Fri, Oct 11, 2019 at 04:06:43PM +0200, Matthias Kretz wrote: > This is a minor bugfix for improved error reporting. Overloading ?: is just > as > disallowed as it is without this change. Thanks. Can you provide a testcase that shows why this change makes sense? That testcase then should be

Re: Remove splay tree form ipa-reference.c

2019-10-11 Thread Richard Biener
On Thu, Oct 10, 2019 at 9:25 PM Jan Hubicka wrote: > > Hi, > ipa-reference uses splay tree to map DECL_UIDs to trees. On other > places we use hash-maps which are more sutiable. A simple hash-table/jhash-set does it as well if the UID is the same as DECL_UID. You can use the tree_decl_hash

Re: Avid ggc_alloc and push_cfun during LTO streaming

2019-10-11 Thread Richard Biener
On Fri, Oct 11, 2019 at 11:03 AM Jan Hubicka wrote: > > Hi, > this patch prevents tree creation druing WPA stream out (to avoid > touching pages and triggering COW). It fixes the following > - gimple streamer produces MEM_REF wrappings for global decls. >This is to preserve the type of

Re: [PR47785] COLLECT_AS_OPTIONS

2019-10-11 Thread Richard Biener
On Fri, Oct 11, 2019 at 6:15 AM Kugan Vivekanandarajah wrote: > > Hi Richard, > Thanks for the review. > > On Wed, 2 Oct 2019 at 20:41, Richard Biener > wrote: > > > > On Wed, Oct 2, 2019 at 10:39 AM Kugan Vivekanandarajah > > wrote: > > > > > > Hi, > > > > > > As mentioned in the PR, attached

Re: [PATCH] Fix PR92046

2019-10-11 Thread Richard Biener
On Fri, 11 Oct 2019, Rainer Orth wrote: > Hi Christophe, > > > On Thu, 10 Oct 2019 at 16:01, Richard Biener wrote: > > > >> > >> The following fixes a few param adjustments that are made based on > >> per-function adjustable flags by moving the adjustments to their > >> users. Semantics change

Re: [PATCH 1/2][GCC][RFC][middle-end]: Add SLP pattern matcher.

2019-10-11 Thread Richard Biener
On Tue, 8 Oct 2019, Tamar Christina wrote: > Hi Richi, > > Thanks for the review, I've added some comments inline. > > The 10/07/2019 12:15, Richard Biener wrote: > > On Tue, 1 Oct 2019, Tamar Christina wrote: > > > > > Hi All, > > > > > > This adds a framework to allow pattern matchers to be

[PATCH] [MIPS] Replace insert with insve for floating-point values

2019-10-11 Thread Mihailo Stojanovic
Currently, when a function argument of type double gets loaded into a vector register on a 32-bit target, it is firstly reloaded into two general purpose registers, and then loaded into a vector register using two insert.w instructions. This patch swaps the two insert.w instructions with one

Re: Ping: [C][C++] Avoid exposing internal details in aka types

2019-10-11 Thread Richard Sandiford
Marek Polacek writes: > On Thu, Oct 10, 2019 at 08:00:53PM +0100, Richard Sandiford wrote: >> Ping >> >> Richard Sandiford writes: >> > The current aka diagnostics can sometimes leak internal details that >> > seem more likely to be distracting than useful. E.g. on aarch64: >> > >> > void f

Re: Correctly release ipa-reference summarries

2019-10-11 Thread Richard Biener
On Thu, Oct 10, 2019 at 9:21 PM Jan Hubicka wrote: > > Hi, > this patch fixes code removing summaries in ipa-reference. As a memory > leak it may make sense to backport this to release branches. Please do so. Richard. > Honza > > * ipa-reference.c (propagate): Fix releasing of IPA

  1   2   >