Re: Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Jeff Law
On Tue, 2020-01-14 at 23:33 +, Joseph Myers wrote: > My preference is still what I said in > ;: either > eliminate C alloca from libiberty, or don't build it with any compiler > defining __GNUC__. I'd be surprised if there are host

Re: [PR47785] COLLECT_AS_OPTIONS

2020-01-14 Thread Prathamesh Kulkarni
On Wed, 8 Jan 2020 at 15:50, Prathamesh Kulkarni wrote: > > On Tue, 5 Nov 2019 at 17:38, Richard Biener > wrote: > > > > On Tue, Nov 5, 2019 at 12:17 AM Kugan Vivekanandarajah > > wrote: > > > > > > Hi, > > > Thanks for the review. > > > > > > On Tue, 5 Nov 2019 at 03:57, H.J. Lu wrote: > > >

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-14 Thread Kyrill Tkachov
On 1/14/20 1:50 PM, Christophe Lyon wrote: On Mon, 13 Jan 2020 at 14:49, Kyrill Tkachov wrote: Hi Christophe, On 12/17/19 3:31 PM, Kyrill Tkachov wrote: On 12/17/19 2:33 PM, Christophe Lyon wrote: On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov wrote: Hi Christophe, On 11/18/19 9:00 AM,

[PATCH] Document how to track whether you have a good build.

2020-01-14 Thread Eric S. Raymond
Document what I was told on #gcc --- gcc/doc/install.texi | 8 1 file changed, 8 insertions(+) diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index 643f3bb311f..12a6db1666a 100644 --- a/gcc/doc/install.texi +++ b/gcc/doc/install.texi @@ -3039,6 +3039,14 @@ current time the

Re: [wwwdocs] Recommend reviewing local changes before pushing them

2020-01-14 Thread Richard Biener
On Tue, Jan 14, 2020 at 3:28 PM Jonathan Wakely wrote: > > On 14/01/20 15:08 +0100, Richard Biener wrote: > >On Tue, Jan 14, 2020 at 2:37 PM Jonathan Wakely wrote: > >> > >> I really think people should be reviewing what they're about to push > >> before doing it. > >> > >> OK for wwwdocs? > > >

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-14 Thread Christophe Lyon
On Mon, 13 Jan 2020 at 14:49, Kyrill Tkachov wrote: > > Hi Christophe, > > On 12/17/19 3:31 PM, Kyrill Tkachov wrote: > > > > On 12/17/19 2:33 PM, Christophe Lyon wrote: > >> On Tue, 17 Dec 2019 at 11:34, Kyrill Tkachov > >> wrote: > >>> Hi Christophe, > >>> > >>> On 11/18/19 9:00 AM, Christophe

Re: [wwwdocs] Recommend reviewing local changes before pushing them

2020-01-14 Thread Jonathan Wakely
On 14/01/20 15:08 +0100, Richard Biener wrote: On Tue, Jan 14, 2020 at 2:37 PM Jonathan Wakely wrote: I really think people should be reviewing what they're about to push before doing it. OK for wwwdocs? So I figure that first doing the git push with -n -v and then reviewing the pushed

Re: [wwwdocs] Recommend reviewing local changes before pushing them

2020-01-14 Thread Jonathan Wakely
On 14/01/20 13:39 +, Richard Earnshaw wrote: On 14/01/2020 13:37, Jonathan Wakely wrote: I really think people should be reviewing what they're about to push before doing it. OK for wwwdocs? I'd recommend git push origin HEAD: rather than just 'git push' Otherwise, OK. Here's a

[patch] contrib: Don't add push rules for personal and vendor spaces.

2020-01-14 Thread Richard Earnshaw (lists)
Originally, it seemed like a good idea to add automatic 'push' rules to the git configuration, so that personal- and vendor-space commits would automatically push to the right place. Unfortunately, this changes git's behaviour and with these settings "git push" will try to push all branches in a

Re: [wwwdocs] Recommend reviewing local changes before pushing them

2020-01-14 Thread Andreas Schwab
On Jan 14 2020, Jonathan Wakely wrote: > You can also just do "git log" and check which commits are more recent > than the one shown as the upstream: > > $ git log > commit 9e502f6deae9f821bd7079aad5f98a4f3bae15cf (HEAD -> master) > Author: Jonathan Wakely > Date: Tue Jan 14 13:34:02 2020

Re: [wwwdocs] Recommend reviewing local changes before pushing them

2020-01-14 Thread Jonathan Wakely
On 14/01/20 16:00 +0100, Andreas Schwab wrote: On Jan 14 2020, Jonathan Wakely wrote: You can also just do "git log" and check which commits are more recent than the one shown as the upstream: $ git log commit 9e502f6deae9f821bd7079aad5f98a4f3bae15cf (HEAD -> master) Author: Jonathan Wakely

Re: [wwwdocs] Fix indentation of .ssh/config snippet

2020-01-14 Thread Richard Earnshaw
On 14/01/2020 13:18, Jonathan Wakely wrote: > OK for wwwdocs? > > OK.

Re: [wwwdocs] Recommend reviewing local changes before pushing them

2020-01-14 Thread Richard Biener
On Tue, Jan 14, 2020 at 2:37 PM Jonathan Wakely wrote: > > I really think people should be reviewing what they're about to push > before doing it. > > OK for wwwdocs? So I figure that first doing the git push with -n -v and then reviewing the pushed changes (cut the revision range) with git show

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

2020-01-14 Thread Christophe Lyon
On Tue, 14 Jan 2020 at 14:54, Kyrill Tkachov wrote: > > > On 1/14/20 1:50 PM, Christophe Lyon wrote: > > On Mon, 13 Jan 2020 at 14:49, Kyrill Tkachov > > wrote: > >> Hi Christophe, > >> > >> On 12/17/19 3:31 PM, Kyrill Tkachov wrote: > >>> On 12/17/19 2:33 PM, Christophe Lyon wrote: > On

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

2020-01-14 Thread Kamil Rytarowski
On 10.01.2020 17:11, Jonathan Wakely wrote: > On 07/01/20 12:44 -0800, Jason Thorpe wrote: >> >>> On Jan 7, 2020, at 7:43 AM, Jonathan Wakely wrote: >>> >>> For Jason and Krister's benefit, that last comment was referring to >>> an earlier suggestion to not try to support old NetBSD releases, see

Re: [PATCH 1/2] hash-table.h: support non-zero empty values in empty_slow (v2)

2020-01-14 Thread David Malcolm
On Tue, 2020-01-14 at 11:02 +0100, Jakub Jelinek wrote: > On Mon, Jan 13, 2020 at 11:51:53PM -0500, David Malcolm wrote: > > > * cfg.s correctly has a call to memset (even with no > > > optimization) > > > for > > > hash_table::empty_slow > > I have intestigated unpatched cc1plus and in the

[C++ PATCH] PR c++/92009 - ICE with punning of typeid.

2020-01-14 Thread Jason Merrill
There were two issues in this PR: 1) We were crashing in is_really_empty_class because we say that the internal RTTI types are classes, but never gave them TYPE_BINFO. 2) We were allowing the cast to a different pointer type because STRIP_NOPS in cxx_fold_indirect_ref ignored REINTERPRET_CAST_P.

[avr,applied]: Remove a no more existing file from contrib/gcc_update::files_and_dependencies.

2020-01-14 Thread Georg-Johann Lay
Hi, gcc/config/avr/t-multilib does no more exist, hence removed from the files to touch. Applied addendum to PR92055 (which removed that file) as obvious. Johann The mentioned auto-generated file is no more part of the GCC sources, it's auto-generated in $(builddir) during

[PATCH, i386]: Fix PR93254, -msse generates sse2 instructions

2020-01-14 Thread Uros Bizjak
2020-01-14 Uroš Bizjak PR target/93254 * config/i386/i386.md (*movsf_internal): Require SSE2 ISA for alternatives 9 and 10. Patch was bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline, will be backported to gcc-9 branch. Uros. diff --git

[PATCH] Fix dejagnu pruning of constexpr context messages.

2020-01-14 Thread Jason Merrill
I wonder why nobody fixed this until now; it's been two years since the diagnostic context output was changed. Tested x86_64-pc-linux-gnu, applying to trunk. * lib/prune.exp (prune_gcc_output): Adjust constexpr pattern. --- gcc/testsuite/lib/prune.exp | 2 +- 1 file changed, 1

[C++ PATCH] PR c++/92594 - ICE with inherited trivial default ctor.

2020-01-14 Thread Jason Merrill
Here we were getting confused about whether or not pod_tuple has a trivial default constructor. bar inherits the trivial e default constructor; the effect of calling that inherited constructor is equivalent to calling a defaulted default constructor in bar, so let's treat it as such. Tested

Re: [PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

2020-01-14 Thread Jason Thorpe
> On Jan 14, 2020, at 8:49 AM, Kamil Rytarowski wrote: > > On 10.01.2020 17:11, Jonathan Wakely wrote: >> On 07/01/20 12:44 -0800, Jason Thorpe wrote: >>> On Jan 7, 2020, at 7:43 AM, Jonathan Wakely wrote: For Jason and Krister's benefit, that last comment was referring to

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-14 Thread David Malcolm
On Mon, 2020-01-13 at 11:23 +0800, luoxhu wrote: > On 2020/1/10 19:08, Jan Hubicka wrote: > > OK. You will need to do the obvious updates for Martin's patch > > which turned some member functions into static functions. > > > > Honza > > Thanks a lot! Rebased & updated, will commit below patch

[PR90916] ICE in retrieve specialization

2020-01-14 Thread Nathan Sidwell
This fixes an ICE caused by a cleanup of get_class_binding. Previously its type_or_fn parm defaulted to -1, which had some funky behaviour I convinced myself was irrelevant to C++ source. Here we're peeking behind the curtain of a class under construction, and previously the -1 behaviour

[C++ PATCH] PR c++/92590 - wrong handling of inherited default ctor.

2020-01-14 Thread Jason Merrill
I thought my earlier fix for 91930 was an obvious bug fix, but apparently an inherited constructor does not count as user-declared. So this patch reverts that change and the other follow-on patches, and fixes 91930 differently, by not letting the inherited default constructor hide the

Re: [PATCH PR92926]Fix wrong code caused by ctor node translation unit wide sharing

2020-01-14 Thread Jeff Law
On Thu, 2020-01-09 at 14:20 +0800, Bin.Cheng wrote: > On Fri, Dec 20, 2019 at 3:10 PM Richard Biener > wrote: > > On December 20, 2019 2:13:47 AM GMT+01:00, "Bin.Cheng" > > wrote: > > > On Fri, Dec 13, 2019 at 11:26 AM bin.cheng > > > wrote: > > > > Hi, > > > > > > > > As reported in PR92926,

Re: [PR90916] ICE in retrieve specialization

2020-01-14 Thread Nathan Sidwell
On 1/14/20 3:29 PM, Nathan Sidwell wrote: On 1/14/20 3:13 PM, Jason Merrill wrote: On 1/14/20 2:14 PM, Nathan Sidwell wrote: +  if (tree ti = (TREE_CODE (fn) == TYPE_DECL && !TYPE_DECL_ALIAS_P (fn) + ? TYPE_TEMPLATE_INFO (TREE_TYPE (fn)) + : DECL_TEMPLATE_INFO

RE: [PATCH] Add Optimization for various IPA parameters.

2020-01-14 Thread Tamar Christina
Hi Xiong, > > It seems the parameters no longer do anything. i.e. -flto --param ipa-cp- > eval-threshold=1 --param ipa-cp-unit-growth=80 doesn't have any effect > anymore. > > Strange that you don't need -fno-inline to achieve the 30% performance > boost, I found that some specialized nodes are

Re: [PATCH] libiberty, include: add bsearch_r

2020-01-14 Thread Jeff Law
On Fri, 2020-01-10 at 15:55 +, Nick Alcock wrote: > libctf wants a bsearch that takes a void * arg pointer to avoid a > nonportable use of __thread. > > bsearch_r is required, not optional, at this point because as far as I > can see this obvious-sounding function is not implemented by

Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Jeff Law
GCC's ability to inline/clone self-recursive calls compromises the find_stack_direction test in libiberty's configure. The test essentially takes the address of a local in an outer and inner context then compares their addresses to determine the direction of stack growth. Inlining causes the

Re: [PATCH] gdbinit.in: make shorthands accept an explicit argument

2020-01-14 Thread Jeff Law
On Sat, 2020-01-04 at 16:35 +0300, Alexander Monakov wrote: > Hi, > > I'm posting an updated patch for GCC gdbinit originally proposed by > Konstantin. > The patch amends debugging shorthands such as 'pr' to accept an explicit > argument, in addition to taking an implicit argument from $ as

Re: [PATCH] Fix wrong-code x86 issue with avx512{f,vl} fma (PR target/93009)

2020-01-14 Thread Jeff Law
On Sat, 2019-12-21 at 00:34 +0100, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, the following testcase is miscompiled with avx512vl. > The reason is that the fma *_bcst_1 define_insns have two alternatives: > "=v,v" "0,v" "v,0" "m,m" and use the same > vfmadd213* %3, %2, %0 > pattern.

Analyzer committed to master (was Re: Analyzer status)

2020-01-14 Thread David Malcolm
On Tue, 2020-01-14 at 08:55 +0100, Richard Biener wrote: > On Mon, 13 Jan 2020, David Malcolm wrote: > > > I posted the initial version of the analyzer patch kit on 2019-11- > > 15, > > shortly before the close of stage 1. > > > > Jeff reviewed (most of) the latest version of the kit on Friday,

Re: [PATCH] libstdc++/91223 Improve unordered containers == operator

2020-01-14 Thread François Dumont
On 1/13/20 10:53 PM, Jonathan Wakely wrote: On 13/01/20 22:41 +0100, François Dumont wrote: For the multi-keys we could still avoid redundant comparisons when _Equal is just doing == on the key type. On unordered_multiset we could just avoids the call to is_permuation and on the

Re: [PATCH] Fix symver attribute with LTO

2020-01-14 Thread Jan Hubicka
> On Wed, 2019-12-18 at 10:26 +0100, Jan Hubicka wrote: > > Hi, > > sorry I forgot to include cgraph and varpool changes in the patch. > > > > Index: varpool.c > > === > > --- varpool.c (revision 279467) > > +++ varpool.c

Re: [PATCH 1/3] Refactor copying decl section names

2020-01-14 Thread Jeff Law
On Tue, 2019-11-12 at 22:28 -0800, Strager Neds wrote: > Sometimes, we need to copy a section name from one decl or symtab node > to another. Currently, this is done by getting the source's section > name and setting the destination's section name. For example: > > set_decl_section_name

Re: [PR90916] ICE in retrieve specialization

2020-01-14 Thread Nathan Sidwell
On 1/14/20 3:13 PM, Jason Merrill wrote: On 1/14/20 2:14 PM, Nathan Sidwell wrote: +  if (tree ti = (TREE_CODE (fn) == TYPE_DECL && !TYPE_DECL_ALIAS_P (fn) + ? TYPE_TEMPLATE_INFO (TREE_TYPE (fn)) + : DECL_TEMPLATE_INFO (fn))) Is there a reason not to use

Re: [PATCH] Fix a bug that propagation in recursive function uses wrong aggregate lattice (PR ipa/93084)

2020-01-14 Thread Jeff Law
On Tue, 2020-01-07 at 14:18 +0100, Martin Jambor wrote: > Hi, > > On Fri, Jan 03 2020, Feng Xue OS wrote: > > When checking a self-recursively generated value for aggregate jump > > function, wrong aggregate lattice was used, which will cause infinite > > constant propagation. This patch is

Re: [PATCH] Remove redundant builtins for avx512f scalar instructions.

2020-01-14 Thread Jeff Law
On Tue, 2019-12-24 at 13:31 +0800, Hongyu Wang wrote: > Hi: > For avx512f scalar instructions, current builtin function like > __builtin_ia32_*{sd,ss}_round can be replaced by > __builtin_ia32_*{sd,ss}_mask_round with mask parameter set to -1. This > patch did the replacement and remove the

Re: [PR90916] ICE in retrieve specialization

2020-01-14 Thread Jason Merrill
On 1/14/20 2:14 PM, Nathan Sidwell wrote: + if (tree ti = (TREE_CODE (fn) == TYPE_DECL && !TYPE_DECL_ALIAS_P (fn) +? TYPE_TEMPLATE_INFO (TREE_TYPE (fn)) +: DECL_TEMPLATE_INFO (fn))) Is there a reason not to use get_template_info? Jason

Re: [PATCH] Fix symver attribute with LTO

2020-01-14 Thread Jeff Law
On Wed, 2019-12-18 at 10:26 +0100, Jan Hubicka wrote: > Hi, > sorry I forgot to include cgraph and varpool changes in the patch. > > Index: varpool.c > === > --- varpool.c (revision 279467) > +++ varpool.c (working copy) > @@ -539,8

Re: [PR90916] ICE in retrieve specialization

2020-01-14 Thread Marek Polacek
On Tue, Jan 14, 2020 at 04:10:07PM -0500, Nathan Sidwell wrote: > On 1/14/20 3:29 PM, Nathan Sidwell wrote: > > On 1/14/20 3:13 PM, Jason Merrill wrote: > > > On 1/14/20 2:14 PM, Nathan Sidwell wrote: > > > > +  if (tree ti = (TREE_CODE (fn) == TYPE_DECL && > > > > !TYPE_DECL_ALIAS_P (fn) > >

Re: Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Jakub Jelinek
On Tue, Jan 14, 2020 at 03:02:01PM -0700, Jeff Law wrote: > Bootstrapped and regression tested on x86_64. Verified STACK_DIRECTION > is correct via hand inspection. > > OK for the trunk? Wouldn't that fail due to warnings if compiled e.g. by gcc that doesn't support noclone attribute? Can't we

[wwwdocs] Link to git.html instead of svn.html and use a neutral link text.

2020-01-14 Thread Gerald Pfeifer
...for all our (past) release pages. Pushed. Gerald - Log - commit d248ad22e9e02664ac4567a24af7a83c6f12aad7 Author: Gerald Pfeifer Date: Tue Jan 14 23:40:48 2020 +0100 Link to git.html instead of svn.html and use a neutral

Re: Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Jeff Law
On Tue, 2020-01-14 at 23:21 +0100, Andreas Schwab wrote: > On Jan 14 2020, Jeff Law wrote: > > > diff --git a/libiberty/aclocal.m4 b/libiberty/aclocal.m4 > > index bf8a907100f..381ed3b27e3 100644 > > --- a/libiberty/aclocal.m4 > > +++ b/libiberty/aclocal.m4 > > @@ -147,7 +147,7 @@ if test

Re: Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Joseph Myers
My preference is still what I said in : either eliminate C alloca from libiberty, or don't build it with any compiler defining __GNUC__. I'd be surprised if there are host compilers that build libiberty, have the relevant optimizations

Remove warning at top of git web pages

2020-01-14 Thread Joseph Myers
Although the documentation is still a work in progress, with various forms of git usage (e.g. contrib/gcc-git-customization.sh) not yet documented and development branches not yet listed on git.html as they are on svn.html, the warning about the conversion still being in progress is no longer

Re: [PATCH] PR 92846: [ARC] generate signaling FDCMPF for hard float comparisons

2020-01-14 Thread Vineet Gupta
On 12/9/19 11:02 AM, Vineet Gupta wrote: > ARC gcc generates FDCMP instructions which raises Invalid operation for > signaling NaN only. This causes glibc iseqsig() primitives to fail (in > the current ongoing glibc port to ARC) > > So split up the hard float compares into two categories and for

[PATCH] tree-optimization: Fix tree dse of strncpy PR93249

2020-01-14 Thread Jakub Jelinek
Hi! As the testcase shows, tail trimming of strncpy in tree-ssa-dse.c is fine, we just copy or clear fewer bytes in the destination, but unlike memcpy/memset etc., head trimming is problematic in certain cases. If we can prove that there are no zero bytes among initial head_trim bytes, it is ok

[PATCH] tree-optimization: Fix tree dse of __*_chk PR93262

2020-01-14 Thread Jakub Jelinek
Hi! The following testcase shows that GCC trunk mishandles DSE of __*_chk calls. Tail trimming of the calls is fine, we want to just decrease the third argument and keep the first two and last arguments unmodified. But for head trimming, we currently increment the two by head_trim and decrease

Re: [PATCH] tree-optimization: Fix tree dse of strncpy PR93249

2020-01-14 Thread Jeff Law
On Wed, 2020-01-15 at 00:53 +0100, Jakub Jelinek wrote: > Hi! > > As the testcase shows, tail trimming of strncpy in tree-ssa-dse.c is fine, > we just copy or clear fewer bytes in the destination, but unlike > memcpy/memset etc., head trimming is problematic in certain cases. > If we can prove

Re: Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Andreas Schwab
On Jan 14 2020, Jeff Law wrote: > diff --git a/libiberty/aclocal.m4 b/libiberty/aclocal.m4 > index bf8a907100f..381ed3b27e3 100644 > --- a/libiberty/aclocal.m4 > +++ b/libiberty/aclocal.m4 > @@ -147,7 +147,7 @@ if test $ac_cv_os_cray = yes; then > fi > > AC_CACHE_CHECK(stack direction for C

[wwwdocs] Remove link to the Git mirror entry in our Wiki from navigation bar.

2020-01-14 Thread Gerald Pfeifer
Pushed. Gerald - Log - commit 3af4155933a9d3b8506b56c16865879b098ab4cf Author: Gerald Pfeifer Date: Tue Jan 14 23:52:28 2020 +0100 Remove link to the Git mirror entry in our Wiki from navigation bar. diff --git

Re: Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Jeff Law
On Tue, 2020-01-14 at 23:09 +0100, Jakub Jelinek wrote: > On Tue, Jan 14, 2020 at 03:02:01PM -0700, Jeff Law wrote: > > Bootstrapped and regression tested on x86_64. Verified STACK_DIRECTION > > is correct via hand inspection. > > > > OK for the trunk? > > Wouldn't that fail due to warnings if

Correct git config command syntax

2020-01-14 Thread Joseph Myers
There is no --set option, git config sets variables without such an option. Committed. diff --git a/htdocs/gitwrite.html b/htdocs/gitwrite.html index 85a0da2d..f420fe22 100644 --- a/htdocs/gitwrite.html +++ b/htdocs/gitwrite.html @@ -78,7 +78,7 @@ git clone

Re: Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Jeff Law
On Tue, 2020-01-14 at 23:33 +, Joseph Myers wrote: > My preference is still what I said in > ;: either > eliminate C alloca from libiberty, or don't build it with any compiler > defining __GNUC__. I'd be surprised if there are host

Say more about conflict messages on git pull

2020-01-14 Thread Joseph Myers
Give an example of the message you get for such a conflict, and discuss options for keeping local changes when pulling. Committed. diff --git a/htdocs/git.html b/htdocs/git.html index 70cc7b73..725bd81c 100644 --- a/htdocs/git.html +++ b/htdocs/git.html @@ -95,13 +95,30 @@ is: Autoconf, Bison,

Ping: [PATCH] Ensure colorization doesn't corrupt multibyte sequences in diagnostics

2020-01-14 Thread Lewis Hyatt
Hello- I thought I might ping this short patch please, just in case it may make sense to include in GCC 10 along with the other UTF-8-related fixes to diagnostics. Thanks! https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00915.html -Lewis On Thu, Dec 12, 2019 at 6:21 PM Lewis Hyatt wrote: > >

Re: [PATCH] PR 92846: [ARC] generate signaling FDCMPF for hard float comparisons

2020-01-14 Thread Vineet Gupta
On 1/14/20 3:49 PM, Vineet Gupta wrote: > On 12/9/19 11:02 AM, Vineet Gupta wrote: >> ARC gcc generates FDCMP instructions which raises Invalid operation for >> signaling NaN only. This causes glibc iseqsig() primitives to fail (in >> the current ongoing glibc port to ARC) >> >> So split up the

Re: [PATCH] tree-optimization: Fix tree dse of __*_chk PR93262

2020-01-14 Thread Jeff Law
On Wed, 2020-01-15 at 01:02 +0100, Jakub Jelinek wrote: > Hi! > > The following testcase shows that GCC trunk mishandles DSE of __*_chk > calls. Tail trimming of the calls is fine, we want to just decrease the > third argument and keep the first two and last arguments unmodified. > But for head

Re: [PATCH] contrib: git descr/undescr aliases

2020-01-14 Thread Joseph Myers
On Tue, 14 Jan 2020, Roman Zhuykov wrote: > PS. We at ISPRAS see that for ~28 hours (11 Jan 2020, 18:00 UTC - 12 Jan 2020, > 22:00 UTC) our servers haven't received any gcc mailing list letters, but they > are available at https://gcc.gnu.org/ml/ archives (totally 6 mails on gcc@ and > 16 on

[committed] Remove bogus initial lines from test.

2020-01-14 Thread Jakub Jelinek
Hi! I've noticed FAIL: g++.dg/lto/odr-8 cp_lto_odr-8_1.o assemble, -O0 -flto -flto-partition=none -fuse-linker-plugin FAIL: g++.dg/lto/odr-8 cp_lto_odr-8_1.o assemble, -O2 -flto -flto-partition=none -fuse-linker-plugin -fno-fat-lto-objects FAIL: g++.dg/lto/odr-8 cp_lto_odr-8_1.o assemble, -O0

[PATCH] contrib: git descr/undescr aliases fix for older git

2020-01-14 Thread Jakub Jelinek
On Tue, Jan 14, 2020 at 10:12:09AM +0100, Jakub Jelinek wrote: > Note, for the scripts running on sourceware I also had to remove those tags/ > part, but thought it is because of running against the bare repo. > We could change those into ^\\(tags/\\)\\?basepoints/gcc- etc. (and adjust > the \\1.

Give example of error message when pushing to a branch with other changes

2020-01-14 Thread Joseph Myers
Giving explicit example of git messages seems helpful for novice users to understand when they are in a particular situation for which instructions are given. Committed. diff --git a/htdocs/gitwrite.html b/htdocs/gitwrite.html index f420fe22..e55cfa92 100644 --- a/htdocs/gitwrite.html +++

Re: [PATCH] [ARC] Use hardware support for double-precision compare instructions.

2020-01-14 Thread Vineet Gupta
On 12/9/19 1:52 AM, Claudiu Zissulescu wrote: > Although the FDCMP (the double precision floating point compare instruction) > is added to the compiler, it is not properly used via cstoredi pattern. Fix > it. > > OK to apply? > Claudidu > > -xx-xx Claudiu Zissulescu > > *

Re: [PATCH] Remove redundant builtins for avx512f scalar instructions.

2020-01-14 Thread Hongyu Wang
For sure. Jeff Law 于2020年1月15日周三 上午4:48写道: > > On Tue, 2019-12-24 at 13:31 +0800, Hongyu Wang wrote: > > Hi: > > For avx512f scalar instructions, current builtin function like > > __builtin_ia32_*{sd,ss}_round can be replaced by > > __builtin_ia32_*{sd,ss}_mask_round with mask parameter set to

Various patches from the analyzer branch pushed to master

2020-01-14 Thread David Malcolm
These have been in the dmalcolm/analyzer branch for a while. I've pushed them to master, as the given commits. (successfully bootstrapped & regrtested on x86_64-pc-linux-gnu) "analyzer: better logging for dedupe_winners::add" https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01235.html

Re: [PATCH] Do not set -fomit-frame-pointer if TARGET_OMIT_LEAF_FRAME_POINTER_P.

2020-01-14 Thread Jeff Law
On Fri, 2020-01-03 at 12:23 +0100, Martin Liška wrote: > Hi. > > I'm not fully sure about the change, but -momit-leaf-frame-pointer > probably should not globally omit frame pointers? > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks,

[committed] invoke.texi: update -fdiagnostics-show-cwe for analyzer

2020-01-14 Thread David Malcolm
Committed to master under the "obvious" rule (ab7c7b46c35ed1be68d4c020a2f20ee96f68b64b) gcc/ChangeLog: * doc/invoke.texi (-fdiagnostics-show-cwe): Add note that some of the analyzer options provide CWE identifiers. --- gcc/doc/invoke.texi | 3 ++- 1 file changed, 2 insertions(+),

Fix setting of DECL_CONTEXT in pushdecl (PR c/93072)

2020-01-14 Thread Joseph Myers
Bug 93072 is a case where the C front end (a) wrongly interprets an inline declaration at block scope as indicating that DECL_CONTEXT should be set for an inline function and (b) this results in an ICE. This is a regression resulting from a previous fix of mine for other bugs involving such

Re: [PATCH PR92926]Fix wrong code caused by ctor node translation unit wide sharing

2020-01-14 Thread Bin.Cheng
On Wed, Jan 15, 2020 at 5:04 AM Jeff Law wrote: > > On Thu, 2020-01-09 at 14:20 +0800, Bin.Cheng wrote: > > On Fri, Dec 20, 2019 at 3:10 PM Richard Biener > > wrote: > > > On December 20, 2019 2:13:47 AM GMT+01:00, "Bin.Cheng" > > > wrote: > > > > On Fri, Dec 13, 2019 at 11:26 AM bin.cheng > >

[PATCH 2/2] Optimize alias subset recording

2020-01-14 Thread Richard Biener
When an alias-set is an already existing subset there is no need to re-record its children as childs of the parent. I noticed this when doing 1/2 as trivial opportunity to squeeze back some performance for the non-caching recursion I added. The whole thing is still quadratic in the depth of the

Re: [PATCH 1/2] hash-table.h: support non-zero empty values in empty_slow (v2)

2020-01-14 Thread Jakub Jelinek
On Mon, Jan 13, 2020 at 11:51:53PM -0500, David Malcolm wrote: > > * cfg.s correctly has a call to memset (even with no optimization) > > for > > hash_table::empty_slow I have intestigated unpatched cc1plus and in the (usually inlined) alloc_entries I see in all the places the xcalloc or

Re: [PATCH] Fix typo and avoid possible memory leak

2020-01-14 Thread Kewen.Lin
on 2020/1/13 下午6:46, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi, >> >> Function average_num_loop_insns forgets to free loop body in early return. >> Besides, overflow comparison checks 100 (e6) but the return value is >> 10 (e5), I guess it's unexpected, a typo? >> >>

Re: [PATCH] contrib: git descr/undescr aliases

2020-01-14 Thread Roman Zhuykov
13.01.2020 14:37, Jakub Jelinek wrote: The following patch adds the descr/undescr aliases (for converting to monotonically increasing revision numbers and back) there next to svn-rev. Both have been changed to use basepoints/gcc-* tags instead of branchpoints/gcc-*, the first one now supports

Re: [PATCH] contrib: git descr/undescr aliases

2020-01-14 Thread Jakub Jelinek
On Tue, Jan 14, 2020 at 12:04:04PM +0300, Roman Zhuykov wrote: > It was a bit confusing to see "git descr" here in posted patch and "git > gcc-descr" actually committed. That was an IRC request from Richard Earnshaw. > Moreover "git gcc-descr" doesn't work for me with old git: > > ~$ git

[PATCH 1/2] PR middle-end/93246 - missing alias subsets

2020-01-14 Thread Richard Biener
Starting with the introduction of TYPE_TYPELESS_STORAGE the situation of having a alias-set zero aggregate field became more common which prevents recording alias-sets of fields of said aggregate as subset of the outer aggregate. component_uses_parent_alias_set_from in the past fended off some of

Re: [PATCH GCC11]Improve uninitialized warning with value range info

2020-01-14 Thread Richard Biener
On Mon, Jan 13, 2020 at 3:15 AM bin.cheng wrote: > > -- > Sender:Richard Biener > Sent At:2020 Jan. 9 (Thu.) 20:01 > Recipient:Bin.Cheng > Cc:bin.cheng ; GCC Patches > > Subject:Re: [PATCH GCC11]Improve uninitialized warning with

Re: [PATCH] Do not set -fomit-frame-pointer if TARGET_OMIT_LEAF_FRAME_POINTER_P.

2020-01-14 Thread Martin Liška
On 1/14/20 12:18 PM, Jan Hubicka wrote: PING^1 On 1/3/20 12:23 PM, Martin Liška wrote: Hi. I'm not fully sure about the change, but -momit-leaf-frame-pointer probably should not globally omit frame pointers? Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be

Re: [PATCH 3/4] Also propagate SRA accesses from LHS to RHS (PR 92706)

2020-01-14 Thread Richard Biener
On Mon, 13 Jan 2020, Martin Jambor wrote: > Hi, > > sorry for taking so long to reply... > > On Wed, Dec 18 2019, Richard Biener wrote: > > On December 17, 2019 1:43:15 PM GMT+01:00, Martin Jambor > > wrote: > >>Hi, > >> > >>the previous patch unfortunately does not fix the first testcase in

[wwwdocs] Reduce references (textual and links) to SVN in older news.

2020-01-14 Thread Gerald Pfeifer
Pushed. Gerald - Log - commit 7d8a79bc2a6409c7adb30c70b884dd6f5934d999 Author: Gerald Pfeifer Date: Tue Jan 14 12:01:19 2020 +0100 Reduce references (textual and links) to SVN in older news. diff --git a/htdocs/news.html

[patch,avr,applied]: Simplify asm macro skip.

2020-01-14 Thread Georg-Johann Lay
Applied the following trivial and obvious patch to the avr back. Johann libgcc/ * config/avr/lib1funcs.S (skip): Simplify. diff --git a/libgcc/config/avr/lib1funcs.S b/libgcc/config/avr/lib1funcs.S index 8ebdc01c88c..2ffa2090b25 100644 --- a/libgcc/config/avr/lib1funcs.S +++

Re: [PATCH] Do not set -fomit-frame-pointer if TARGET_OMIT_LEAF_FRAME_POINTER_P.

2020-01-14 Thread Martin Liška
PING^1 On 1/3/20 12:23 PM, Martin Liška wrote: Hi. I'm not fully sure about the change, but -momit-leaf-frame-pointer probably should not globally omit frame pointers? Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog:

Re: [PATCH] Clean up references to Subversion in documentation sources.

2020-01-14 Thread Gerald Pfeifer
On Mon, 13 Jan 2020, Jonathan Wakely wrote: > Here's what I've committed to releases/gcc-9, I'll do something > similar for gcc-8. Cool, thank you. That was a good catch, even without the conversion to GIT; I'll see that I'll contribute to the conversion on the wwwdocs side over the coming

Re: [PATCH] Do not set -fomit-frame-pointer if TARGET_OMIT_LEAF_FRAME_POINTER_P.

2020-01-14 Thread Jan Hubicka
> PING^1 > > On 1/3/20 12:23 PM, Martin Liška wrote: > > Hi. > > > > I'm not fully sure about the change, but -momit-leaf-frame-pointer > > probably should not globally omit frame pointers? > > > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > > > Ready to be

Re: [PATCH 2/2] Optimize alias subset recording

2020-01-14 Thread Richard Biener
On Tue, 14 Jan 2020, Richard Biener wrote: > When an alias-set is an already existing subset there is no need > to re-record its children as childs of the parent. > > I noticed this when doing 1/2 as trivial opportunity to squeeze > back some performance for the non-caching recursion I added.

Re: [PATCH 2/2] Optimize alias subset recording

2020-01-14 Thread Richard Biener
On Tue, 14 Jan 2020, Richard Biener wrote: > On Tue, 14 Jan 2020, Richard Biener wrote: > > > When an alias-set is an already existing subset there is no need > > to re-record its children as childs of the parent. > > > > I noticed this when doing 1/2 as trivial opportunity to squeeze > > back

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-14 Thread Martin Liška
On 1/13/20 4:23 AM, luoxhu wrote: Thanks a lot! Rebased & updated, will commit below patch shortly when git push is ready. Hello. I'm pretty sure the patch contains failure of the following tests: FAIL: gcc.dg/tree-prof/crossmodule-indir-call-topn-1.c scan-pgo-wpa-ipa-dump

[wwwdocs] Fix indentation of .ssh/config snippet

2020-01-14 Thread Jonathan Wakely
OK for wwwdocs? commit a449e14116456cf66ea15d4aca203a50b55f6e20 Author: Jonathan Wakely Date: Tue Jan 14 13:16:12 2020 + Fix indentation of .ssh/config snippet diff --git a/htdocs/gitwrite.html b/htdocs/gitwrite.html index 12606201..85a0da2d 100644 --- a/htdocs/gitwrite.html +++

Re: [PING^4][PATCH 0/4] Fix library testsuite compilation for build sysroot

2020-01-14 Thread Chung-Lin Tang
On 2020/1/6 11:25 PM, Maciej W. Rozycki wrote: Overall if libgomp-test-support.exp is considered appropriate for standalone testing, then I think two solutions are possible here: 1. An option is added to libgomp's $CC such that the compiler is able to make builds involving the offload

[wwwdocs] Recommend reviewing local changes before pushing them

2020-01-14 Thread Jonathan Wakely
I really think people should be reviewing what they're about to push before doing it. OK for wwwdocs? commit 2c54cb9e98fe67096b62718d8dbd3b2ca485ff89 Author: Jonathan Wakely Date: Tue Jan 14 13:34:02 2020 + Recommend reviewing local changes before pushing them diff --git

Re: [wwwdocs] Recommend reviewing local changes before pushing them

2020-01-14 Thread Richard Earnshaw
On 14/01/2020 13:37, Jonathan Wakely wrote: > I really think people should be reviewing what they're about to push > before doing it. > > OK for wwwdocs? > I'd recommend git push origin HEAD: rather than just 'git push' Otherwise, OK. R.