[Ada] Fix wrong assignment to mutable Out parameter of task entry

2020-05-25 Thread Eric Botcazou
Under very specific circumstances the compiler can generate a wrong assignment to a mutable record object which contains an array component, because it does not correctly handle the update of the discriminant. Tested on x86-64/Linux, applied on the mainline. 2020-05-25 Eric Botcazou

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Richard Biener
On May 25, 2020 8:12:12 AM GMT+02:00, Uros Bizjak wrote: >On Mon, May 25, 2020 at 7:53 AM Hongtao Liu wrote: > >> > We have to introduce a new expander, that will have conforming mode >of >> > output operand (V2SF) and will produce RTX that will match >> > *floatv2div2sf2. A paradoxical output

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread kamlesh kumar via Gcc-patches
> OTOH, you don't need to name Tuple at all... It should not *have* a > constructor, since you declared it as class... But you can just use > std::tuple here? I thought of using std::tuple but it requires c++11 support. I am not sure we always build gcc with c++11? > > >

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Uros Bizjak via Gcc-patches
On Mon, May 25, 2020 at 7:53 AM Hongtao Liu wrote: > > We have to introduce a new expander, that will have conforming mode of > > output operand (V2SF) and will produce RTX that will match > > *floatv2div2sf2. A paradoxical output subreg from > > V2SFmode V4SFmode is needed, generated by

[Ada] Change description of fat pointertype with -fgnat-encodings=minimal

2020-05-25 Thread Eric Botcazou
This makes a step back in the representation of fat pointer types in the debug info with -fgnat-encodings=minimal so as to avoid hiding the data indirection and making it easier for GDB to synthetize the construct. Tested on x86-64/Linux, applied on the mainline. 2020-05-25 Eric Botcazou

Re: ChangeLog files - server and client scripts

2020-05-25 Thread Martin Liška
On 5/23/20 12:14 AM, Ian Lance Taylor wrote: Sure, I can wait. Thanks for looking at it. Hello. Thank you for patience. There's a patch that fixes that, I'm going to install it. Martin >From 76e18b91250f265a37d85063860fb38aa8f6aac3 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 25

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Hongtao Liu via Gcc-patches
On Mon, May 25, 2020 at 1:55 AM Uros Bizjak wrote: > > On Sun, May 24, 2020 at 9:26 AM Hongtao Liu wrote: > > > > On Sat, May 23, 2020 at 6:11 PM Uros Bizjak wrote: > > > > > > On Sat, May 23, 2020 at 9:25 AM Hongtao Liu wrote: > > > > > > > > Hi: > > > > This patch fix non-conforming

[Ada] Fix missing back-annotation for derived types

2020-05-25 Thread Eric Botcazou
Gigi fails to back-annotate the Present_Expr field of variants present in a type derived from a discriminated untagged record type, which is for example visible in the output -gnatRj. Tested on x86-64/Linux, applied on the mainline. 2020-05-25 Eric Botcazou * gcc-interface/decl.c

Re: ChangeLog files - server and client scripts

2020-05-25 Thread Martin Liška
On 5/21/20 5:14 PM, Rainer Orth wrote: * In changelog_location, you allow only (among others) "a/b/c/" and "\ta/b/c/". Please also accept the "a/b/c:" and "\ta/b/c:" forms here: especially the second seems quite common. Ok, I believe these formats are supported as well. Feel free to

Re: [patch] Fix internal error on store to FP component at -O2

2020-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 25, 2020 at 12:33 PM Eric Botcazou wrote: > > Hi, > > the attached Ada testcase triggers a GIMPLE verification failure at -O2 or > above because the GIMPLE store merging pass generates a NOP_EXPR between a FP > type and an integral type. This happens when the bit-field insertion path

Re: Do not stream redudnant stuff

2020-05-25 Thread Richard Biener
On Mon, 25 May 2020, Jan Hubicka wrote: > Hi, > as discussed on IRC this adds knob to disable stuff we stream "just for fun" > (or to make it easier to debug streamer desychnonization). > > Te size of .o files in gcc subdirectory is reduced form 506MB to 492MB > > Bootstrapped/regtested

Re: V3 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386

2020-05-25 Thread Martin Liška
Hello. I really welcome the unification patch and I have some comments (ideas): 1) +static inline int +has_cpu_feature (struct __processor_model *cpu_model, + unsigned int *cpu_features2, + enum processor_features f) +{ + unsigned int i; + if (f < 32) +return

[PATCH] tree-optimization/95295 - fix wrong-code with SM

2020-05-25 Thread Richard Biener
We failed to compare the rematerialized store values when merging paths after walking PHIs. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2020-05-25 Richard Biener PR tree-optimization/95295 * tree-ssa-loop-im.c (sm_seq_valid_bb): Compare remat

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Hongtao Liu via Gcc-patches
On Mon, May 25, 2020 at 7:36 PM Richard Biener wrote: > > On Mon, 25 May 2020, Uros Bizjak wrote: > > > On Mon, May 25, 2020 at 8:27 AM Richard Biener wrote: > > > > > > On May 25, 2020 8:12:12 AM GMT+02:00, Uros Bizjak > > > wrote: > > > >On Mon, May 25, 2020 at 7:53 AM Hongtao Liu wrote: >

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Uros Bizjak via Gcc-patches
On Mon, May 25, 2020 at 8:27 AM Richard Biener wrote: > > On May 25, 2020 8:12:12 AM GMT+02:00, Uros Bizjak wrote: > >On Mon, May 25, 2020 at 7:53 AM Hongtao Liu wrote: > > > >> > We have to introduce a new expander, that will have conforming mode > >of > >> > output operand (V2SF) and will

[PATCH] tree-optimization/95308 - really avoid forward propagating of

2020-05-25 Thread Richard Biener
This fixes a hole that still allowed forwarding of TARGET_MEM_REF addresses. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2020-05-25 Richard Biener PR tree-optimization/95308 * tree-ssa-forwprop.c (pass_forwprop::execute): Generalize test

Re: [patch] Fix internal error on store to FP component at -O2

2020-05-25 Thread Eric Botcazou
> Hmm, MAX_BITSIZE_MODE_ANY_INT looks a bit arbitrary since on > x86 it (IIRC) includes things like OImode. Maybe MOVE_MAX or > MAX_FIXED_MODE_SIZE are better suited here? You're right, MAX_FIXED_MODE_SIZE is better, I'm going to change it. > The IL correctness fix looks OK to me but it smells

[PATCH] Fix nonconforming memory_operand for vpmov instructions which has memory operand narrow than 128 bits [avx512f]

2020-05-25 Thread Hongtao Liu via Gcc-patches
According to Intel SDM, VPMOVQB xmm1/m16 {k1}{z}, xmm2 has 16-bit memory_operand instead of 128-bit one which exists in current implementation. Also for other vpmov instructions which have memory_operand narrower than 128bits. Bootstrap is ok, regression test for i386/x86-64 backend is ok.

[Ada] Fix incorrect handling of Component_Size

2020-05-25 Thread Eric Botcazou
The compiler can mishandle a Component_Size clause on an array type specifying a size multiple of the storage unit, when this size is not a multiple of the alignment of the component type. Tested on x86-64/Linux, applied on the mainline. 2020-05-25 Eric Botcazou *

[patch] Fix internal error on store to FP component at -O2

2020-05-25 Thread Eric Botcazou
Hi, the attached Ada testcase triggers a GIMPLE verification failure at -O2 or above because the GIMPLE store merging pass generates a NOP_EXPR between a FP type and an integral type. This happens when the bit-field insertion path is taken for a FP field, which can happen in Ada for

Re: [PATCH] Implement no_stack_protect attribute.

2020-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 25, 2020 at 11:27 AM Martin Liška wrote: > > On 5/22/20 12:51 PM, Richard Biener wrote: > > On Thu, May 21, 2020 at 12:09 PM Martin Liška wrote: > >> > >> On 5/18/20 1:49 PM, Richard Biener wrote: > >>> On Mon, May 18, 2020 at 1:10 PM Jakub Jelinek via Gcc-patches > >>> wrote: >

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 25, 2020 at 1:10 PM guojiufu wrote: > > Currently option -funroll-loops controls both GIMPLE unroler and > RTL unroller. It is not able to control GIMPLE cunroller and > RTL unroller independently. This patch introducing different flags > to control them seperately, and this also

Re: [patch] Fix internal error on store to FP component at -O2

2020-05-25 Thread Eric Botcazou
> Hmm, MAX_BITSIZE_MODE_ANY_INT looks a bit arbitrary since on > x86 it (IIRC) includes things like OImode. Maybe MOVE_MAX or > MAX_FIXED_MODE_SIZE are better suited here? I forgot to mention that I picked MAX_BITSIZE_MODE_ANY_INT because of: bool invalid = (base_addr == NULL_TREE

Do not stream redudnant stuff

2020-05-25 Thread Jan Hubicka
Hi, as discussed on IRC this adds knob to disable stuff we stream "just for fun" (or to make it easier to debug streamer desychnonization). Te size of .o files in gcc subdirectory is reduced form 506MB to 492MB Bootstrapped/regtested x86_64-linux, OK? gcc/ChangeLog: 2020-05-25 Jan Hubicka

[PATCH] tree-optimization/95284 - amend previous store commoning fix

2020-05-25 Thread Richard Biener
Generalize check for clobbers. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2020-05-25 Richard Biener PR tree-optimization/95284 * tree-ssa-sink.c (sink_common_stores_to_bb): Amend previous fix. * g++.dg/torture/pr95284.C: New

Re: testsuite: clarify scan-dump file globbing behavior

2020-05-25 Thread Frederik Harwath
Frederik Harwath writes: Hi Rainer, hi Mike, ping: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545803.html Best regards, Frederik > Hi Thomas, > > Thomas Schwinge writes: > >> I can't formally approve testsuite patches, but did a review anyway: > > Thanks for the review! > >> On

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Uros Bizjak via Gcc-patches
On Mon, May 25, 2020 at 1:56 PM Hongtao Liu wrote: > > On Mon, May 25, 2020 at 7:36 PM Richard Biener wrote: > > > > On Mon, 25 May 2020, Uros Bizjak wrote: > > > > > On Mon, May 25, 2020 at 8:27 AM Richard Biener wrote: > > > > > > > > On May 25, 2020 8:12:12 AM GMT+02:00, Uros Bizjak > > >

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Hongtao Liu via Gcc-patches
On Mon, May 25, 2020 at 8:00 PM Uros Bizjak wrote: > > On Mon, May 25, 2020 at 1:56 PM Hongtao Liu wrote: > > > > On Mon, May 25, 2020 at 7:36 PM Richard Biener wrote: > > > > > > On Mon, 25 May 2020, Uros Bizjak wrote: > > > > > > > On Mon, May 25, 2020 at 8:27 AM Richard Biener > > > >

[Ada] Fix internal error on problematic renaming

2020-05-25 Thread Eric Botcazou
This is an internal renaming generated for a generalized loop iteration made on a tagged record type with predicate, and gigi cannot use the most efficient way of implementing renamings because the renamed object is an expression with a non-empty Actions list. Tested on x86-64/Linux, applied

[PATCH] tree-optimization/95297 - handle scalar shift arg for SLP invariant vectype

2020-05-25 Thread Richard Biener
This skips invariant vector type setting for a scalar shift argument. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2020-05-25 Richard Biener PR tree-optimization/95297 * tree-vect-stmts.c (vectorizable_shift): For scalar_shift_arg skip

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Richard Biener
On Mon, 25 May 2020, Uros Bizjak wrote: > On Mon, May 25, 2020 at 8:27 AM Richard Biener wrote: > > > > On May 25, 2020 8:12:12 AM GMT+02:00, Uros Bizjak wrote: > > >On Mon, May 25, 2020 at 7:53 AM Hongtao Liu wrote: > > > > > >> > We have to introduce a new expander, that will have conforming

Re: New mklog script

2020-05-25 Thread Martin Liška
On 5/22/20 6:43 PM, Martin Sebor wrote: On 5/21/20 2:16 AM, Martin Liška wrote: Hello Martin. Can you please compare the current mklog.py. Is there anything you miss compared to your current script? Nope, it matches the format I get with my script and even works better and runs faster.  Very

Re: New mklog script

2020-05-25 Thread Martin Liška
On 5/22/20 11:01 PM, Jason Merrill wrote: On Thu, May 21, 2020 at 6:03 PM Jason Merrill wrote: On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote: On 5/15/20 3:22 PM, Marek Polacek wrote: On Fri, May 15, 2020 at 03:12:27PM +0200, Martin Liška wrote: On 5/15/20 2:42 PM, Marek Polacek

Re: [PATCH v3] Add -fuse-ld= to specify an arbitrary executable as the linker

2020-05-25 Thread Martin Liška
On 5/22/20 6:42 AM, Fangrui Song wrote: but I can't fix this one because joining two lines will break the 80-column  rule. What about this: diff --git a/gcc/collect2.c b/gcc/collect2.c index cc57a20e08b..e5b54b080f7 100644 --- a/gcc/collect2.c +++ b/gcc/collect2.c @@ -1138,8 +1138,8 @@ main

Re: [PATCH] Let numeric_limits::is_iec559 reflect -ffast-math

2020-05-25 Thread Matthias Kretz
On Freitag, 22. Mai 2020 18:39:42 CEST Jonathan Wakely wrote: > On 22/05/20 09:49 +0200, Matthias Kretz wrote: > >On Donnerstag, 21. Mai 2020 17:46:01 CEST Marc Glisse wrote: > >> On Thu, 21 May 2020, Jonathan Wakely wrote: > >> > On 27/04/20 17:09 +0200, Matthias Kretz wrote: > >> >> From:

Re: [PATCH] Fix non-conforming expander [PR target/95211, PR target/95256]

2020-05-25 Thread Uros Bizjak via Gcc-patches
On Mon, May 25, 2020 at 8:13 AM Hongtao Liu wrote: > (define_insn "sse_storehps" > [(set (match_operand:V2SF 0 "nonimmediate_operand" "=m,v,v") > (vec_select:V2SF > (match_operand:V4SF 1 "nonimmediate_operand" "v,v,o") > (parallel [(const_int 2) (const_int 3)])))] >

Re: [Ada] Fix small issues with -fgnat-encodings=minimal

2020-05-25 Thread Eric Botcazou
> This is the mode where the GNAT compiler does not use special encodings in > the debug info to describe some Ada constructs, for example packed array > types. This fixes a small fallout of the patch. Tested on x86-64/Linux, applied on the mainline. 2020-05-25 Eric Botcazou *

Re: [PATCH] Implement no_stack_protect attribute.

2020-05-25 Thread Martin Liška
On 5/22/20 12:51 PM, Richard Biener wrote: On Thu, May 21, 2020 at 12:09 PM Martin Liška wrote: On 5/18/20 1:49 PM, Richard Biener wrote: On Mon, May 18, 2020 at 1:10 PM Jakub Jelinek via Gcc-patches wrote: On Mon, May 18, 2020 at 01:03:40PM +0200, Jakub Jelinek wrote: The optimize

[WIP] Fold 'NON_LVALUE_EXPR' some more (was: C++ 'NON_LVALUE_EXPR' in OMP array section handling)

2020-05-25 Thread Thomas Schwinge
Hi! Anyone have any input here, especially whether something like the WIP patch attached to generally "Fold 'NON_LVALUE_EXPR' some more" is preferable over local 'STRIP_NOPS'? On 2020-03-26T20:53:19+0100, I wrote: > On 2020-03-26T09:09:01-0600, Sandra Loosemore wrote: >> On 3/26/20 8:27 AM,

[PATCH 2/2] rs6000: Turn on -frtl-unroll-loops instead -funroll-loops at -O2

2020-05-25 Thread guojiufu via Gcc-patches
Previously, turning -funroll-loops on at -O2, which also turn on GIMPLE cunroll fully. While cunroll unrolls some complex loops. This patch turn on -frtl-unroll-loops at -O2 only, and continue to use previous tuned rs6000 heurisitics for small loops. While this patch does not turn on GIMPLE

[PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread guojiufu via Gcc-patches
Currently option -funroll-loops controls both GIMPLE unroler and RTL unroller. It is not able to control GIMPLE cunroller and RTL unroller independently. This patch introducing different flags to control them seperately, and this also provide more freedom to tune one of them without affecting

[PATCH] tree-optimization/95271 - fix bswap vectorization invariant SLP type

2020-05-25 Thread Richard Biener
This properly updates invariant SLP nodes vector types for bswap vectorization. Bootstrapped / tested on x86_64-unknown-linux-gnu, applied. 2020-05-25 Richard Biener PR tree-optimization/95271 * tree-vect-stmts.c (vectorizable_bswap): Update invariant SLP children

Re: [patch] Fix internal error on store to FP component at -O2

2020-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 25, 2020 at 2:14 PM Eric Botcazou wrote: > > > Hmm, MAX_BITSIZE_MODE_ANY_INT looks a bit arbitrary since on > > x86 it (IIRC) includes things like OImode. Maybe MOVE_MAX or > > MAX_FIXED_MODE_SIZE are better suited here? > > I forgot to mention that I picked MAX_BITSIZE_MODE_ANY_INT

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-25 Thread Richard Biener via Gcc-patches
On Fri, May 22, 2020 at 6:54 PM Segher Boessenkool wrote: > > On Fri, May 22, 2020 at 01:22:10PM +0200, Richard Biener wrote: > > On Wed, May 20, 2020 at 10:37 PM Segher Boessenkool > > wrote: > > > > > > On Wed, May 20, 2020 at 12:30:30PM +0200, Richard Biener wrote: > > > > I think this is the

Re: [PATCH] Implement no_stack_protect attribute.

2020-05-25 Thread Martin Liška
On 5/21/20 4:53 PM, Martin Sebor wrote: On 5/21/20 5:28 AM, Martin Liška wrote: On 5/18/20 10:37 PM, Martin Sebor wrote: I know there are some somewhat complex cases the attribute exclusion mechanism isn't general enough to handle but this seems simple enough that it should work.  Unless I'm 

Re: [PATCH] Fix nonconforming memory_operand for vpmov instructions which has memory operand narrow than 128 bits [avx512f]

2020-05-25 Thread Uros Bizjak via Gcc-patches
On Mon, May 25, 2020 at 2:21 PM Hongtao Liu wrote: > > According to Intel SDM, VPMOVQB xmm1/m16 {k1}{z}, xmm2 has 16-bit > memory_operand instead of 128-bit one which exists in current > implementation. Also for other vpmov instructions which have > memory_operand narrower than 128bits. > >

Re: zstd not found if installed in non-system prefix

2020-05-25 Thread Matthias Klose
On 5/20/20 9:32 PM, Michael Kuhn wrote: > Hi, > > when specifying a non-system prefix with --with-zstd, the build fails > because the header and library cannot be found (see > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95005). > > The attached patch fixes the problem and is what we use in

BRIG FE testsuite: Fix dump scan patterns in packed.hsail test

2020-05-25 Thread Martin Jambor
Hi, Starting with r11-165-eb72dc663e9 which converted DECL_GIMPLE_REG_P to DECL_NOT_GIMPLE_REG_P we have failing BRIG testcase: -PASS: packed.hsail.brig scan-tree-dump gimple "_[0-9]+ = q2 \\+ q3;" -PASS: packed.hsail.brig scan-tree-dump gimple "= VEC_PERM_EXPR ;" +FAIL: packed.hsail.brig

[PATCH] tree-optimization/95309 - fix invariant SLP node costing

2020-05-25 Thread Richard Biener
This makes sure to compute SLP_TREE_NUMBER_OF_VEC_STMTS during SLP analysis even for invariant / external nodes so costing properly knows what to cost. Bootstrapped and tested on x86_64-unknown-linux-gnu. This might also fix a few other cost issues reported. 2020-05-25 Richard Biener

[PATCH] Add debug (slp_tree) and dump infrastructure for this

2020-05-25 Thread Richard Biener
This adds an alternate debug_dump_context similar to the one for selftests but for interactive debugging routines. This allows to share code between user-visible dumping via the dump_* API and those debugging routines. The primary driver was SLP node dumping which wasn't accessible from inside a

[Ada] Change pragma Compile_Time_Error to force compile-time evaluation

2020-05-25 Thread Pierre-Marie de Rodat
Issue an error now when the expression in pragma Compile_Time_Error cannot be evaluated at compile time. This allows static analyzers like GNATprove to rely on such expressions always being False. Tested on x86_64-pc-linux-gnu, committed on trunk 2020-05-25 Yannick Moy gcc/ada/ *

[Ada] Spurious accessibility error on return aggregate in GNATprove mode

2020-05-25 Thread Pierre-Marie de Rodat
This patch fixes an issue whereby valid actuals within return aggregates could trigger spurious accessibility errors in GNATprove mode. Tested on x86_64-pc-linux-gnu, committed on trunk 2020-05-25 Justin Squirek gcc/ada/ * sem_ch6.adb (Check_Return_Obj_Accessibility): Use original

[Ada] Fix spurious error on checking of null Abstract_State

2020-05-25 Thread Pierre-Marie de Rodat
A declaration of an object inside a declare block of elaboration code should not count as hidden state of the package. Nor should declarations inside a task or an entry. Now fixed. Tested on x86_64-pc-linux-gnu, committed on trunk 2020-05-25 Yannick Moy gcc/ada/ * sem_util.adb

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Segher Boessenkool
On Mon, May 25, 2020 at 07:58:09PM +0200, Richard Biener wrote: > You folks made ppc specific hacks instead of a better design. Those now stand > in the way as well. But sure, simply do not expose the flag to the users, use > Var(flag_rtl_unroll_loops). My other points still stand. > > Feel

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Martin Liška
On 5/25/20 10:08 PM, Jason Merrill wrote: Like so: I like the patch, thanks! The last question I have: Do we want to make installation of the hook optional in gcc-git-customization.sh? Martin

Re: [Patch][OpenMP] Fix mapping of artificial variables (PR94874)

2020-05-25 Thread Tobias Burnus
On 5/12/20 1:02 PM, Jakub Jelinek wrote: I think we want a new hook, the clear cases (mostly DECL_ARTIFICIAL ones, if it is really something compiler created and not something under user's control) … Attached is one version, which is somewhat minimalist; I did not check what happens with

Re: New mklog script

2020-05-25 Thread Jason Merrill via Gcc-patches
On Mon, May 25, 2020 at 5:23 AM Martin Liška wrote: > > On 5/22/20 11:01 PM, Jason Merrill wrote: > > On Thu, May 21, 2020 at 6:03 PM Jason Merrill wrote: > >> > >> On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote: > >>> > >>> On 5/15/20 3:22 PM, Marek Polacek wrote: > On Fri, May 15,

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Jason Merrill via Gcc-patches
On Mon, May 25, 2020 at 3:50 PM Jason Merrill wrote: > On Mon, May 25, 2020 at 2:14 PM Martin Liška wrote: > > > > On 5/23/20 11:39 PM, Jason Merrill via Gcc-patches wrote: > > > This patch introduces a prepare-commit-msg hook that appends a ChangeLog > > > skeleton to a commit message that

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread Segher Boessenkool
On Mon, May 25, 2020 at 12:46:02PM +0530, kamlesh kumar wrote: > > OTOH, you don't need to name Tuple at all... It should not *have* a > > constructor, since you declared it as class... But you can just use > > std::tuple here? > > I thought of using std::tuple but it requires c++11 support. >

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread Richard Biener
On May 25, 2020 6:31:29 PM GMT+02:00, Segher Boessenkool wrote: >On Mon, May 25, 2020 at 12:46:02PM +0530, kamlesh kumar wrote: >> > OTOH, you don't need to name Tuple at all... It should not *have* >a >> > constructor, since you declared it as class... But you can just >use >> > std::tuple

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread Iain Sandoe via Gcc-patches
Jakub Jelinek via Gcc-patches wrote: On Mon, May 25, 2020 at 06:37:57PM +0200, Richard Biener wrote: I thought of using std::tuple but it requires c++11 support. I am not sure we always build gcc with c++11? https://gcc.gnu.org/install/prerequisites.html We do for GCC 11 :-) Since we pay

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Segher Boessenkool
On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: > On Mon, May 25, 2020 at 1:10 PM guojiufu wrote: > Since a new flag is not needed to fix the regression please avoid > adding -fcomplete-unroll-loops. > > For -frtl-unroll-loops you should be able to use Erm. That *is* a new

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Jason Merrill via Gcc-patches
I'll integrate your changes with mine. On Mon, May 25, 2020 at 2:14 PM Martin Liška wrote: > > On 5/23/20 11:39 PM, Jason Merrill via Gcc-patches wrote: > > This patch introduces a prepare-commit-msg hook that appends a ChangeLog > > skeleton to a commit message that doesn't already have one,

New Swedish PO file for 'gcc' (version 10.1.0)

2020-05-25 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Swedish team of translators. The file is available at: https://translationproject.org/latest/gcc/sv.po (This file, 'gcc-10.1.0.sv.po', has

Re: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-05-25 Thread Segher Boessenkool
On Mon, May 25, 2020 at 02:59:30AM +, Yangfei (Felix) wrote: > > It creates better code on all targets :-) A quite small improvement, but > > not > > entirely trivial. > > Thanks for the effort. It's great to hear that :- ) Yes :-) > > > > p.s. Please use a correct mime type?

V4 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386

2020-05-25 Thread H.J. Lu via Gcc-patches
On Mon, May 25, 2020 at 2:52 AM Martin Liška wrote: > > Hello. > > I really welcome the unification patch and I have some comments (ideas): > > 1) > > > +static inline int > > +has_cpu_feature (struct __processor_model *cpu_model, > > + unsigned int *cpu_features2, > > +

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-25 Thread Segher Boessenkool
On Mon, May 25, 2020 at 02:39:54PM +0200, Richard Biener wrote: > On Fri, May 22, 2020 at 6:54 PM Segher Boessenkool > wrote: > > > The split above allows the "bug" to be fixed (even on the branch) > > > without introducing even more target specialities. > > > > So does any split. Or I don't see

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Martin Liška
On 5/23/20 11:39 PM, Jason Merrill via Gcc-patches wrote: This patch introduces a prepare-commit-msg hook that appends a ChangeLog skeleton to a commit message that doesn't already have one, and a 'git amend-mklog' command to amend and append a new ChangeLog skeleton (to be edited together with

Re: [PATCH] Port libgccjit to Windows.

2020-05-25 Thread Nicolas Bértolo via Gcc-patches
Hi Dave, Thanks for your feedback. > Do you have copyright assignment paperwork on file? > https://gcc.gnu.org/contribute.html#legal My paperwork is done. > The autotools are not my strongest suit. > In a previous life I was a Windows developer, but I think it's been > about 18 years since

Re: [PATCH 2/2] Provide diagnostic hints for missing C++ cinttypes string constants.

2020-05-25 Thread Jason Merrill via Gcc-patches
On 5/23/20 8:30 PM, Mark Wielaard wrote: When reporting an error in cp_parser and we notice a string literal followed by an unknown name check whether there is a known standard header containing a string macro with the same name, then add a hint to the error message to include that header.

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-05-25 Thread Jakub Jelinek via Gcc-patches
On Mon, May 25, 2020 at 06:37:57PM +0200, Richard Biener wrote: > >> I thought of using std::tuple but it requires c++11 support. > >> I am not sure we always build gcc with c++11? > > > >https://gcc.gnu.org/install/prerequisites.html > > > >We do for GCC 11 :-) Since we pay the price for

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Richard Biener via Gcc-patches
On May 25, 2020 7:40:00 PM GMT+02:00, Segher Boessenkool wrote: >On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: >> On Mon, May 25, 2020 at 1:10 PM guojiufu >wrote: >> Since a new flag is not needed to fix the regression please avoid >> adding -fcomplete-unroll-loops. >> >> For

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread David Edelsohn via Gcc-patches
On Mon, May 25, 2020 at 1:58 PM Richard Biener wrote: > > On May 25, 2020 7:40:00 PM GMT+02:00, Segher Boessenkool > wrote: > >On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: > >> On Mon, May 25, 2020 at 1:10 PM guojiufu > >wrote: > >> Since a new flag is not needed to fix the

[PATCH] PR fortran/95089 - ICE in gfc_get_derived_type, at fortran/trans-types.c:2843

2020-05-25 Thread Harald Anlauf
Another rather obvious case of a buffer too small to hold a name-mangled symbol, this time with coarrays enabled. OK for master? Thanks, Harald PR fortran/95089 - ICE in gfc_get_derived_type, at fortran/trans-types.c:2843 For long module name, derive type and component name, the

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-25 Thread Jason Merrill via Gcc-patches
On 5/25/20 4:15 PM, Martin Liška wrote: On 5/25/20 10:08 PM, Jason Merrill wrote: Like so: I like the patch, thanks! The last question I have: Do we want to make installation of the hook optional in gcc-git-customization.sh? Sure: >From 04429ee04769e15842093f154e8c7887f75d9476 Mon Sep 17

[IMPORTANT] ChangeLog related changes

2020-05-25 Thread Jakub Jelinek via Gcc-patches
Hi! I've turned the strict mode of Martin Liška's hook changes, which means that from now on no commits to the trunk or release branches should be changing any ChangeLog files together with the other files, ChangeLog entry should be solely in the commit message. The DATESTAMP bumping script will

Re: ChangeLog files - server and client scripts

2020-05-25 Thread Ian Lance Taylor via Gcc-patches
On Mon, May 25, 2020 at 12:48 AM Martin Liška wrote: > > On 5/23/20 12:14 AM, Ian Lance Taylor wrote: > > Sure, I can wait. Thanks for looking at it. > > Hello. > > Thank you for patience. There's a patch that fixes that, > I'm going to install it. Thanks. I was able to push my change to

libgo patch committed: update x/sys/cpu after gccgo support added

2020-05-25 Thread Ian Lance Taylor via Gcc-patches
This libgo patch updates the x/sys/cpu directory with better support for gccgo on AIX. Bootstrapped and ran Go tests on x86_64-pc-linux-gnu. Committed to master. Ian e479602af14fc5e76c9040846b2f5e85e126a472 diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index

Re: [PATCH 1/2] Seperate -funroll-loops for GIMPLE unroller and RTL unroller

2020-05-25 Thread Jiufu Guo via Gcc-patches
David Edelsohn writes: > On Mon, May 25, 2020 at 1:58 PM Richard Biener > wrote: >> >> On May 25, 2020 7:40:00 PM GMT+02:00, Segher Boessenkool >> wrote: >> >On Mon, May 25, 2020 at 02:14:02PM +0200, Richard Biener wrote: >> >> On Mon, May 25, 2020 at 1:10 PM guojiufu >> >wrote: >> >> Since

Re: ChangeLog files - server and client scripts

2020-05-25 Thread Alexandre Oliva
On May 25, 2020, Martin Liška wrote: > On 5/21/20 5:14 PM, Rainer Orth wrote: >> * In changelog_location, you allow only (among others) "a/b/c/" and >> "\ta/b/c/". Please also accept the "a/b/c:" and "\ta/b/c:" forms >> here: especially the second seems quite common. > Ok, I believe these

[PATCH 5/7] vect: Support vector load/store with length in vectorizer

2020-05-25 Thread Kewen.Lin via Gcc-patches
gcc/ChangeLog 2020-MM-DD Kewen Lin * doc/invoke.texi (vect-with-length-scope): Document new option. * params.opt (vect-with-length-scope): New. * tree-vect-loop-manip.c (vect_set_loop_lens_directly): New function. (vect_set_loop_condition_len): Likewise.

[PATCH 4/7] hook/rs6000: Add vectorize length mode for vector with length

2020-05-25 Thread Kewen.Lin via Gcc-patches
gcc/ChangeLog: 2020-MM-DD Kewen Lin * config/rs6000/rs6000.c (TARGET_VECTORIZE_LENGTH_MODE): New macro. * doc/tm.texi: Regenerate. * doc/tm.texi.in: New hook. * target.def: Likewise. --- gcc/config/rs6000/rs6000.c | 3 +++ gcc/doc/tm.texi| 6

Re: [IMPORTANT] ChangeLog related changes

2020-05-25 Thread Hongtao Liu via Gcc-patches
On Tue, May 26, 2020 at 6:49 AM Jakub Jelinek via Gcc-patches wrote: > > Hi! > > I've turned the strict mode of Martin Liška's hook changes, > which means that from now on no commits to the trunk or release branches > should be changing any ChangeLog files together with the other files, >

[PATCH 3/7] vect: Factor out codes for niters smaller than vf check

2020-05-25 Thread Kewen.Lin via Gcc-patches
gcc/ChangeLog: 2020-MM-DD Kewen Lin * tree-vect-loop.c (known_niters_smaller_than_vf): New function, factored out from ... (vect_analyze_loop_costing): ... here. --- gcc/tree-vect-loop.c | 31 ++- 1 file changed, 22 insertions(+), 9

[PATCH 2/7] rs6000: lenload/lenstore optab support

2020-05-25 Thread Kewen.Lin via Gcc-patches
gcc/ChangeLog: 2020-MM-DD Kewen Lin * config/rs6000/vsx.md (lenloaddi): New define_expand. (lenstoredi): Likewise. --- gcc/config/rs6000/vsx.md | 30 ++ 1 file changed, 30 insertions(+) diff --git a/gcc/config/rs6000/vsx.md

[PATCH 6/7] ivopts: Add handlings for vector with length IFNs

2020-05-25 Thread Kewen.Lin via Gcc-patches
gcc/ChangeLog 2020-MM-DD Kewen Lin * tree-ssa-loop-ivopts.c (get_mem_type_for_internal_fn): Handle IFN_LEN_LOAD and IFN_LEN_STORE. (get_alias_ptr_type_for_ptr_address): Likewise. --- gcc/tree-ssa-loop-ivopts.c | 4 1 file changed, 4 insertions(+) diff --git

RE: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-05-25 Thread Yangfei (Felix)
Hi, > -Original Message- > From: Segher Boessenkool [mailto:seg...@kernel.crashing.org] > Sent: Tuesday, May 26, 2020 12:27 AM > To: Yangfei (Felix) > Cc: gcc-patches@gcc.gnu.org; Zhanghaijian (A) > Subject: Re: [PATCH PR94026] combine missed opportunity to simplify > comparisons with

Re: collect2.exe errors not pruned

2020-05-25 Thread Alexandre Oliva
On May 19, 2020, Joseph Myers wrote: > On Tue, 19 May 2020, Alexandre Oliva wrote: >> > I don't think the error should mention .exe, but I also don't think the >> > error should mention collect2 (see what I said in >> > , the existence

[PATCH 0/7] Support vector load/store with length

2020-05-25 Thread Kewen.Lin via Gcc-patches
Hi all, This patch set adds support for vector load/store with length, Power ISA 3.0 brings instructions lxvl/stxvl to perform vector load/store with length, it's good to be exploited for those cases we don't have enough stuffs to fill in the whole vector like epilogues. This support mainly

[PATCH 1/7] ifn/optabs: Support vector load/store with length

2020-05-25 Thread Kewen.Lin via Gcc-patches
gcc/ChangeLog: 2020-MM-DD Kewen Lin * doc/md.texi (lenload@var{m}@var{n}): Document. (lenstore@var{m}@var{n}): Likewise. * internal-fn.c (len_load_direct): New macro. (len_store_direct): Likewise. (expand_len_load_optab_fn): Likewise.