[PATCH] Reapply all revisions mentioned in LOCAL_PATCHES.

2020-06-02 Thread Martin Liška
(cherry picked from commit 21bb1625bd4f183984223ce31bd03ba47ed62f27) --- libsanitizer/asan/asan_globals.cpp| 19 --- libsanitizer/asan/asan_interceptors.h | 7 ++- libsanitizer/asan/asan_mapping.h | 2 +- .../sanitizer_linux_libcdep.cpp

[PATCH] Update link to LOCAL_PATCHES.

2020-06-02 Thread Martin Liška
libsanitizer/ChangeLog: * LOCAL_PATCHES: Update hash of local patches. --- libsanitizer/LOCAL_PATCHES | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsanitizer/LOCAL_PATCHES b/libsanitizer/LOCAL_PATCHES index 7732de3d436..f0c99a3b7ea 100644 ---

Re: [PATCH] contrib: Improve comments and error text

2020-06-02 Thread Martin Liška
On 6/1/20 7:30 PM, Jonathan Wakely wrote: * gcc-changelog/git_commit.py (GitCommit.check_mentioned_files): Improve error text. OK for master? Yes, I've just pushed the patch with your authorship. Martin

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Martin Liška
On 6/1/20 7:24 PM, Jonathan Wakely wrote: On Mon, 25 May 2020 at 23:50, Jakub Jelinek via Gcc wrote: Hi! I've turned the strict mode of Martin Liška's hook changes, which means that from now on no commits to the trunk or release branches should be changing any ChangeLog files together with

[committed] d: Fix segfault in build_frontend_type on alpha-*-*

2020-06-02 Thread Iain Buclaw via Gcc-patches
Hi, The va_list type for Alpha includes a nameless dummy field for alignment purposes. To transpose this into D, a field named "__pad%d" is inserted into the struct definition. It was also noticed that in the D front-end AST copy of the backend type, all offsets for fields generated by

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

2020-06-02 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi Richard, > > Thanks for the comments! > > on 2020/6/2 上午1:59, Richard Sandiford wrote: >> Could you go into more detail about this choice of cost calculation? >> It looks like we first calculate per-group flags, which are true only if >> the unrolled offsets are valid for

PING: RE: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero

2020-06-02 Thread Yangfei (Felix)
Gentle ping ... > -Original Message- > From: Yangfei (Felix) > Sent: Wednesday, May 27, 2020 11:52 AM > To: 'Segher Boessenkool' > Cc: gcc-patches@gcc.gnu.org; Zhanghaijian (A) > Subject: RE: [PATCH PR94026] combine missed opportunity to simplify > comparisons with zero > > Hi, > > >

Re: [PATCH] favor bcrypt over wincrypt for the random generator on Windows

2020-06-02 Thread Steve Lhomme
Actually I found a but in the patch. The BCryptGenRandom() doesn't return a BOOL like CryptGenRandom so the success needs to be checked differently. I'm sending an updated patch with the wincrypt name change as well. On 2020-06-01 18:30, Richard Sandiford wrote: Steve Lhomme writes: Hello,

[PATCH v2] favor bcrypt over CryptoAPI for the random generator on Windows

2020-06-02 Thread Steve Lhomme
BCrypt is more modern and supported in Universal Apps. CryptoAPI is not and CryptGenRandom is deprecated: https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptgenrandom BCrypt is available since Vista

[PATCH PR95459] aarch64: ICE in aarch64_short_vector_p, at config/aarch64/aarch64.c:16803

2020-06-02 Thread Yangfei (Felix)
Hi, Please review this trivial patch fixing an ICE in aarch64_short_vector_p. Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95459 In aarch64_short_vector_p, we are simply checking whether a type (and a mode) is a 64/128-bit short vector or not. This should not be affected

Re: [stage1][PATCH] Make TOPN counter dynamically allocated.

2020-06-02 Thread Jan Hubicka
> > 2020-04-03 Martin Liska > > * coverage.c (get_coverage_counts): Skip sanity check for TOP N counters > as they have variable number of counters. > * gcov-dump.c (main): Add new option -r. > (print_usage): Likewise. > (tag_counters): All new raw format. >

Re: [PATCH] Fix unrecognised -mcpu target: armv7-a on arm-wrs-vxworks7 (PR95420)

2020-06-02 Thread Iain Buclaw via Gcc-patches
On 01/06/2020 19:00, Olivier Hainque wrote: > Hello Iain, > >> On 01 Jun 2020, at 00:40, Iain Buclaw wrote: >> >> Hi, >> >> In the removal of arm-wrs-vxworks, the default cpu was updated from arm8 >> to armv7-a, but this is not recognized as a valid -mcpu target. There >> is however

Re: [PATCH] Add pattern for pointer-diff on addresses with same base/offset (PR 94234)

2020-06-02 Thread Richard Biener via Gcc-patches
On Mon, Jun 1, 2020 at 10:37 AM Feng Xue OS via Gcc-patches wrote: > > This patch is meant to add match rules to simplify patterns as: > > o. (pointer + offset_a) - (pointer + offset_b) -> (ptrdiff_t) (offset_a - > offset_b) > o. (pointer_a + offset) - (pointer_b + offset) -> (pointer_a

[PATCH] contrib: Add gdc.test to list of ignored prefixes

2020-06-02 Thread Iain Buclaw via Gcc-patches
The files in this subdirectory are part of the D2 test suite maintained in the upstream DMD code repository. OK? contrib/ChangeLog: * gcc-changelog/git_commit.py (ignored_prefixes): Add gcc/testsuite/gdc.test/. --- contrib/gcc-changelog/git_commit.py | 1 + 1 file changed, 1

Re: [patch] Make memory copy functions scalar storage order barriers

2020-06-02 Thread Richard Biener via Gcc-patches
On Mon, Jun 1, 2020 at 11:09 AM Eric Botcazou wrote: > > Hi, > > this addresses the issue raised by Andrew a few weeks ago about the usage of > memory copy functions to toggle the scalar storage order. Recall that you > cannot (the compiler errors out) take the address of a scalar which is

Re: [PATCH] Fix unrecognised -mcpu target: armv7-a on arm-wrs-vxworks7 (PR95420)

2020-06-02 Thread Olivier Hainque
Hello Iain, > On 02 Jun 2020, at 10:39, Iain Buclaw wrote: > > Done (both master and releases/gcc-10). Great, thanks!

[Ada] Reuse Is_Package_Or_Generic_Package where possible

2020-06-02 Thread Pierre-Marie de Rodat
Replace a low-level Ekind_In with a high-level Is_Package_Or_Generic_Package wrapper where possible. Arguably the wrapper was introduced to make the code easier to read, so let's use it; semantics is unaffected. Modified expressions were detected with: $ grep "Ekind_In " *|grep E_Package|grep

[Ada] Use Standard.Natural on bit references to packed arrays

2020-06-02 Thread Pierre-Marie de Rodat
This changes the type set on bit references made to packed arrays: instead of Universal_Integer, it is set to Standard.Natural. The reason is that Universal_Integer must be a type as large as the largest supported integer type and, therefore, can be much larger than what is really needed here.

[Ada] ICE during unnesting when nested subprograms have address taken

2020-06-02 Thread Pierre-Marie de Rodat
When doing subprogram unnesting for GNAT-LLVM (or CCG), the compiler can crash when it tries to access an unreachable enclosing subprogram that contains nested subprograms that are marked reachable due to having Access or Unchecked_Access applied to them. This is fixed by ensuring that the

[Ada] Remove degenerate Treat_Fixed_As_Integer mechanism

2020-06-02 Thread Pierre-Marie de Rodat
The Treat_Fixed_As_Integer mechanism has been degenerate for quite some time and the flag is only set on divide nodes at this point. We can use the same trick as in the multiply case to get rid of it altogether, with the positive by-product that the compiler will stop doing divisions of small

[Ada] Statement SCO code for degenerate subprograms

2020-06-02 Thread Pierre-Marie de Rodat
Use statement SCO code 'X' to specifically identify the statement SCOs for degenerate subprogram bodies (null procedures and expression functions). This allows coverage analysis tools to apply specific processing for these cases if necessary, and ensures consistency with SCOs generated through

[Ada] Accept objects from nested packages in Initializes contract

2020-06-02 Thread Pierre-Marie de Rodat
Objects and abstract states declared in nested packages should be allowed to appear in the Initializes contract of the enclosing package. Tested on x86_64-pc-linux-gnu, committed on trunk 2020-06-02 Piotr Trojanek gcc/ada/ * sem_prag.adb (Collect_States_And_Objects): Call itself on

[Ada] Compiler crash processing controlled type primitive

2020-06-02 Thread Pierre-Marie de Rodat
The compiler crashes processing the body of dispatching primitive that is a function whose controlling type is a tagged private type and its full view is a derivation of a controlled type. Tested on x86_64-pc-linux-gnu, committed on trunk 2020-06-02 Javier Miranda gcc/ada/ *

[Ada] Get rid of more references to Universal_Integer in expanded code

2020-06-02 Thread Pierre-Marie de Rodat
This further tweaks the expanded code generated by the front-end, so as to avoid having references to Universal_Integer reaching the code generator, either directly or indirectly through attributes returning Universal_Integer. The reason is that Universal_Integer must be a type as large as the

[Ada] Remove ASIS_Mode

2020-06-02 Thread Pierre-Marie de Rodat
In order to simplify the long term maintenance of the GNAT frontend, support for generating trees for ASIS is removed from trunk. ASIS is being phased out at this stage in favor of Libadalang. Tested on x86_64-pc-linux-gnu, committed on trunk 2020-06-02 Arnaud Charlet gcc/ada/ *

[Ada] Get rid of more references to Universal_Integer in expanded code

2020-06-02 Thread Pierre-Marie de Rodat
This further tweaks the expanded code generated by the front-end, so as to avoid having references to Universal_Integer reaching the code generator, either directly or indirectly through attributes returning Universal_Integer. There is also a minor tweak to the a-sequio.adb unit of the runtime to

[Ada] Fix bogus error for clause on derived type with variant part

2020-06-02 Thread Pierre-Marie de Rodat
This prevents the compiler from giving a bogus error message on the representation clause specified for a discriminated record type that is derived from an untagged discriminated record type with a variant part, when the representation clause gives overlapping positions to components in different

[Ada] Fix small oversight in latest change for Replace_Discriminants

2020-06-02 Thread Pierre-Marie de Rodat
This prevents the compiler from giving a bogus error on a discriminated record type derived from an untagged discriminated record type with a variant part, when the subtype of the discriminant of the former is more constrained than that of the latter and the variant part contains a discrete choice

[Ada] Use Standard.Natural on indices in support routines for Ada.Tags

2020-06-02 Thread Pierre-Marie de Rodat
This changes the type set on indices and ranges that are made of integer literals in the support routines for Ada.Tags generated during expansion: instead of Universal_Integer, it is set to Standard.Natural, which is the index type used in a-tags.ads. The reason is that Universal_Integer must be

[Ada] Do not set the bounds of integer types to be universal

2020-06-02 Thread Pierre-Marie de Rodat
This changes the type set on the bounds of signed integer types declared by the programmer: instead of Universal_Integer, it is set to the anonymous base type created by the declaration. The reason is that Universal_Integer must be a type as large as the largest supported integer type and,

[Ada] Unnesting bugs with array renamings generated for quantified expr

2020-06-02 Thread Pierre-Marie de Rodat
A quantified expression for an array object within a postcondition (and presumably in other contexts) results in the creation of a renaming of the array object (such as the formal parameter of the enclosing postcondition procedure), and when the array's corresponding subtype has nonstatic bounds

[Ada] Fix minor discrepancy in Expand_N_Attribute_Reference

2020-06-02 Thread Pierre-Marie de Rodat
This fixes a minor discrepancy in Expand_N_Attribute_Reference, which still thinks that the Alignment primitive operation for tagged types is a function call returning Integer, while it's a selected component returning Natural these days. No functional changes. Tested on x86_64-pc-linux-gnu,

[Ada] Remove dead code for detecting hidden package state

2020-06-02 Thread Pierre-Marie de Rodat
When climbing the chain of scopes (using Sinfo.Scope) we always process unique entities, e.g. an E_Procedure even for entities that syntactically reside in E_Subprogram_Body; same for tasks, entries and packages. There is no need to expect E_Package_Body, because it never occurs. The removed dead

[PATCH 5/7 v3] vect: Support vector load/store with length in vectorizer

2020-06-02 Thread Kewen.Lin via Gcc-patches
Hi Richard, on 2020/5/29 下午4:32, Richard Sandiford wrote: > "Kewen.Lin" writes: >> on 2020/5/27 下午6:02, Richard Sandiford wrote: >>> "Kewen.Lin" writes: Hi Richard, Snip ... >> >> Thanks a lot for your detailed explanation! This proposal looks good >> based on the current

[PATCH] Do not copy NULL string with memcpy.

2020-06-02 Thread Martin Liška
The problem happens when we generate temp file for .res file. Tested locally with the problematic options. Ready for master? Thanks, Martin gcc/ChangeLog: PR driver/95456 * gcc.c (do_spec_1): Append to tempfile only when input_basename != NULL. --- gcc/gcc.c | 2 +- 1

Re: [PATCH] contrib: Add gdc.test to list of ignored prefixes

2020-06-02 Thread Martin Liška
OK? Yes.

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2020-06-02 Thread Martin Liška
PING^2 On 5/15/20 11:58 AM, Martin Liška wrote: We're in stage1: PING^1 On 4/3/20 8:15 PM, Egeyar Bagcioglu wrote: On 3/18/20 10:05 AM, Martin Liška wrote: On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: Hi Martin, I like the patch. It definitely serves our purposes at Oracle and provides

[PATCH] contrib: Make prepare-commit-msg hook safe for older branches

2020-06-02 Thread Jonathan Wakely via Gcc-patches
If a user installs this script as .git/hooks/prepare-commit-msg and then works on an old branch which doesn't have the mklog.py script, trying to commit will fail with an error like: environment: /.../gcc/contrib/mklog.py: No such file or directory This makes it exit cleanly so it's possible to

Re: [PATCH] contrib: Make prepare-commit-msg hook safe for older branches

2020-06-02 Thread Martin Liška
On 6/2/20 11:16 AM, Jonathan Wakely wrote: OK for master? I like the patch. Martin

[PATCH] contrib: Improve error text for overlong ChangeLog lines

2020-06-02 Thread Jonathan Wakely via Gcc-patches
This error is wrong, the line is what exceeds LINE_LIMIT characters, the limit doesn't exceed itself. contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit.parse_changelog): Fix * grammar. OK for master? commit ba4ddb1023844202f84a32275e451f9c7a0bb7b7 Author: Jonathan

Re: [PATCH] contrib: Improve error text for overlong ChangeLog lines

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On 02/06/20 10:22 +0100, Jonathan Wakely wrote: This error is wrong, the line is what exceeds LINE_LIMIT characters, the limit doesn't exceed itself. contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit.parse_changelog): Fix * grammar. OK for master? commit

Re: openmp: Add basic library allocator support

2020-06-02 Thread Sebastian Huber
Hello, On 19/05/2020 10:24, Jakub Jelinek via Gcc-patches wrote: + gomp_mutex_lock (_data->lock); + if (__builtin_add_overflow (allocator_data->used_pool_size, new_size, + _pool_size) + || used_pool_size > allocator_data->pool_size) + { +

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Martin Liška
On 6/2/20 3:56 PM, Jonathan Wakely wrote: On Tue, 2 Jun 2020 at 14:16, Martin Liška wrote: On 6/2/20 1:48 PM, Martin Liška wrote: I tend to this approach. Let me prepare a patch candidate for it. There's a patch for it. Can you please Jonathan take a look? Looks great, thanks! +

Re: [PATCH] contrib: Improve error text for overlong ChangeLog lines

2020-06-02 Thread Martin Liška
On 6/2/20 11:22 AM, Jonathan Wakely wrote: OK for master? You're right. Please install it. Martin

Re: [PATCH] contrib: Improve error text for overlong ChangeLog lines

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On 02/06/20 11:37 +0200, Martin Liška wrote: On 6/2/20 11:23 AM, Jonathan Wakely wrote: On 02/06/20 10:22 +0100, Jonathan Wakely wrote: This error is wrong, the line is what exceeds LINE_LIMIT characters, the limit doesn't exceed itself. contrib/ChangeLog: * gcc-changelog/git_commit.py

Re: [PATCH] contrib: Improve error text for overlong ChangeLog lines

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On 02/06/20 11:18 +0100, Jonathan Wakely wrote: On 02/06/20 11:37 +0200, Martin Liška wrote: On 6/2/20 11:23 AM, Jonathan Wakely wrote: On 02/06/20 10:22 +0100, Jonathan Wakely wrote: This error is wrong, the line is what exceeds LINE_LIMIT characters, the limit doesn't exceed itself.

Re: [PATCH] rs6000: Use REAL_TYPE to copy when block move array in structure[PR65421]

2020-06-02 Thread Richard Biener via Gcc-patches
On Tue, Jun 2, 2020 at 11:43 AM Xionghu Luo via Gcc-patches wrote: > > Double array in structure as function arguments or return value is accessed > by BLKmode, they are stored to stack and load from stack with redundant > conversion from DF->DI->DF. This patch checks the homogeneous type and >

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On Tue, 2 Jun 2020 at 11:56, Gerald Pfeifer wrote: > > On Mon, 1 Jun 2020, Jonathan Wakely via Gcc-patches wrote: > > The libstdc++ manual is written in Docbook XML, but we commit both the > > XML and generated HTML pages to Git. Sometimes a small XML file can > > result in dozens of mechanical

Re: [PATCH 1/2] Introduce flag_cunroll_grow_size for cunroll

2020-06-02 Thread Richard Biener via Gcc-patches
On Tue, Jun 2, 2020 at 4:10 AM Jiufu Guo wrote: > > Jiufu Guo writes: > > Hi, > > I updated the patch just a little accordinlgy. Thanks! > > diff --git a/gcc/common.opt b/gcc/common.opt > index 4464049fc1f..570e2aa53c8 100644 > --- a/gcc/common.opt > +++ b/gcc/common.opt > @@ -2856,6 +2856,10

Re: [PATCH 5/7 v3] vect: Support vector load/store with length in vectorizer

2020-06-02 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi Richard, > > on 2020/5/29 下午4:32, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>> on 2020/5/27 下午6:02, Richard Sandiford wrote: "Kewen.Lin" writes: > Hi Richard, > > > Snip ... > >>> >>> Thanks a lot for your detailed explanation! This proposal looks

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-06-02 Thread Richard Biener
On Tue, 2 Jun 2020, Alexandre Oliva wrote: > On May 27, 2020, Alexandre Oliva wrote: > > > - The prepending of -Wl, to file names in ldflags et al was done in a > > way that introduced empty arguments when consecutive blanks appeared > > in these board configuration knobs. Skip the empty

Re: [patch 0/5] ipa-initcall-cp

2020-06-02 Thread Richard Biener via Gcc-patches
On Fri, May 29, 2020 at 8:44 PM Erick Ochoa wrote: > > Hello everyone, > > I wanted to highlight this ticket on bugzilla [0]. It is a missed > optimization that I worked on. It involves propagating constants across > function calls at link-time. I am relatively new to GCC and this would > be my

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On Tue, 2 Jun 2020 at 14:56, Jonathan Wakely wrote: > > On Tue, 2 Jun 2020 at 14:16, Martin Liška wrote: > > > > On 6/2/20 1:48 PM, Martin Liška wrote: > > > I tend to this approach. Let me prepare a patch candidate for it. > > > > There's a patch for it. Can you please Jonathan take a look? > >

Simplify streaming of tree references

2020-06-02 Thread Jan Hubicka
Hi, this patch makes tree referneces to be stream by one integer rather then by pair of tag and index. This makes function streams about 3% smaller and reduces number of ulebs we stream (that still shows high in profiles). lto-bootstrapped/regtested x86_64-linux, comitted. Honza *

Re: [stage1][PATCH] Lower VEC_COND_EXPR into internal functions.

2020-06-02 Thread Martin Liška
On 6/2/20 1:09 PM, Richard Biener wrote: So please be constructive. Like, provide a testcase that ICEs with the FAILs replaced by gcc_unreachable (). Martin, may I suggest to do this replacement and bootstrap/test? I think it would be nice to have testsuite coverage for the FAILs, and maybe

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On Tue, 2 Jun 2020 at 14:16, Martin Liška wrote: > > On 6/2/20 1:48 PM, Martin Liška wrote: > > I tend to this approach. Let me prepare a patch candidate for it. > > There's a patch for it. Can you please Jonathan take a look? Looks great, thanks! +if name not in

[GCC][PATCH][ARM]: Correct the grouping of operands in MVE vector scatter store intrinsics (PR94735).

2020-06-02 Thread Srinath Parvathaneni
Hello, The operands in RTL patterns of MVE vector scatter store intrinsics are wrongly grouped, because of which few vector loads and stores instructions are wrongly getting optimized out with -O2. A new predicate "mve_scatter_memory" is defined in this patch, this predicate returns TRUE on

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Martin Liška
On 6/2/20 4:14 PM, Jonathan Wakely wrote: On Tue, 2 Jun 2020 at 14:56, Jonathan Wakely wrote: On Tue, 2 Jun 2020 at 14:16, Martin Liška wrote: On 6/2/20 1:48 PM, Martin Liška wrote: I tend to this approach. Let me prepare a patch candidate for it. There's a patch for it. Can you please

[PATCH] recog: Use parameter packs for operator()

2020-06-02 Thread Richard Sandiford
This patch uses parameter packs to define insn_gen_fn::operator(). I guess in some ways it's C++-ification for its own sake, but it does make things simpler and removes the current artificial limit of 16 arguments. Note that the call is still strongly typed: all arguments have to have implicit

Re: Broken build

2020-06-02 Thread Hans-Peter Nilsson via Gcc-patches
> From: Alexandre Oliva > Date: Tue, 2 Jun 2020 13:29:03 +0200 > Hello, Anthony, H-P, > > On May 27, 2020, Anthony Green wrote: > > > Hans-Peter Nilsson via Gcc-patches writes: > >> And here's an improper bug report. > >> > >> One of the commits between cfdff3eeb90..5c8344e7289 caused every

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-06-02 Thread François Dumont via Gcc-patches
Hi Any feedback regarding this patch ? François On 26/05/20 1:45 pm, François Dumont wrote: On 24/05/20 3:43 pm, François Dumont wrote: Now tested in C++98 mode, there was indeed a small problem. I even wonder if I shouldn't have extend the std::copy overload to any call with deque

[COMMITTED] amdgcn: Remove -mlocal-symbol-id option

2020-06-02 Thread Andrew Stubbs
This patch removes the vestiges of the GCN-specific -mlocal-symbol-id option. Previously, this was part of a horrible workaround for a bug in the Radeon Open Compute ELF loader. The bug has been fixed a while now, and the name mangling has not been present in the compiler for a while, so the

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-06-02 Thread Alexandre Oliva
On May 27, 2020, Alexandre Oliva wrote: > - The prepending of -Wl, to file names in ldflags et al was done in a > way that introduced empty arguments when consecutive blanks appeared > in these board configuration knobs. Skip the empty strings between > consecutive blanks to avoid this problem.

Re: [PATCH 5/5] Adds ipa-initcall-cp pass.

2020-06-02 Thread Richard Biener via Gcc-patches
On Fri, May 29, 2020 at 8:52 PM Erick Ochoa wrote: > > > > This pass is a variant of constant propagation where global > primitive constants with a single write are propagated to multiple > read statements. Just a few small comments while skimming through the code > ChangeLog: > > 2020-05-20

Re: [PATCH] S/390: Emit vector alignment hints for z13

2020-06-02 Thread Stefan Schulze Frielinghaus via Gcc-patches
On Fri, May 29, 2020 at 01:57:30PM +0200, Andreas Krebbel wrote: > On 28.05.20 20:24, Stefan Schulze Frielinghaus wrote: > > Vector alignment hints are fully supported since z14. On z13 alignment > > hints have no effect, however, instructions with alignment hints are > > still legal. Thus, emit

RE: [PATCH] extend cselim to check non-trapping for more references (PR tree-optimizaton/89430)

2020-06-02 Thread Richard Biener
On Fri, 29 May 2020, Hao Liu OS wrote: > Hi Richard, > > Thanks for your comments. It's a good idea to simplify the code and remove > get_inner_reference. I've updated the patch accordingly. I also simplified > the code to ignore other loads, which can not help to check if a store can be >

Re: Broken build

2020-06-02 Thread Alexandre Oliva
Hello, Anthony, H-P, On May 27, 2020, Anthony Green wrote: > Hans-Peter Nilsson via Gcc-patches writes: >> And here's an improper bug report. >> >> One of the commits between cfdff3eeb90..5c8344e7289 caused every >> single *linked* test to fail for cris-elf, like: > I can confirm that the

[PATCH][OBVIOUS] libgcov: replace malloc and calloc.

2020-06-02 Thread Martin Liška
The calloc was in the original tested version of the patch and I made accidental last minute change. Installed to master as obvious. libgcc/ChangeLog: * libgcov.h (gcov_topn_add_value): Use xcalloc instead of xmalloc. --- libgcc/libgcov.h | 2 +- 1 file changed, 1

Re: openmp: Add basic library allocator support

2020-06-02 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 02, 2020 at 11:26:37AM +0200, Sebastian Huber wrote: > with this patch I get the following error for target arm-rtems6: > > ../../../gnu-mirror-gcc-86b14bb/libgomp/allocator.c: In function 'omp_free': > ../../../gnu-mirror-gcc-86b14bb/libgomp/allocator.c:351:42: error: 'struct >

Re: [PATCH PR95254] aarch64: gcc generate inefficient code with fixed sve vector length

2020-06-02 Thread Richard Sandiford
"Yangfei (Felix)" writes: > Hi, > >> -Original Message- >> From: Richard Sandiford [mailto:richard.sandif...@arm.com] >> Sent: Monday, June 1, 2020 4:47 PM >> To: Yangfei (Felix) >> Cc: gcc-patches@gcc.gnu.org; Uros Bizjak ; Jakub >> Jelinek ; Hongtao Liu ; H.J. Lu >> >> Subject: Re:

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Martin Liška
On 6/2/20 1:22 PM, Jonathan Wakely via Gcc-patches wrote: On Tue, 2 Jun 2020 at 12:09, Jonathan Wakely wrote: On Tue, 2 Jun 2020 at 12:05, Jonathan Wakely wrote: On Tue, 2 Jun 2020 at 11:56, Gerald Pfeifer wrote: On Mon, 1 Jun 2020, Jonathan Wakely via Gcc-patches wrote: The libstdc++

Re: [PATCH 2/4] ipa-sra: Introduce a mini-DCE to tree-inline.c (PR 93385)

2020-06-02 Thread Richard Biener
On Thu, 28 May 2020, Martin Jambor wrote: > PR 93385 reveals that if the user explicitely disables DCE, IPA-SRA > can leave behind statements which are useless because their results > are eventually not used but can have problematic side effects, > especially since their inputs are now bogus that

Re: [PATCH 2/5] Add function tree_code_in_cst.

2020-06-02 Thread Richard Biener via Gcc-patches
On Sat, May 30, 2020 at 12:18 AM Jan Hubicka wrote: > > > > > --- > > gcc/tree.h | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/gcc/tree.h b/gcc/tree.h > > index bd0c51b2a18..86a4542f58b 100644 > > --- a/gcc/tree.h > > +++ b/gcc/tree.h > > @@ -6156,6 +6156,17 @@

Re: [PATCH 2/5] Add function tree_code_in_cst.

2020-06-02 Thread Erick Ochoa
On 02/06/2020 14:29, Richard Biener wrote: On Sat, May 30, 2020 at 12:18 AM Jan Hubicka wrote: --- gcc/tree.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/gcc/tree.h b/gcc/tree.h index bd0c51b2a18..86a4542f58b 100644 --- a/gcc/tree.h +++ b/gcc/tree.h @@ -6156,6

[PATCH] rs6000: Use REAL_TYPE to copy when block move array in structure[PR65421]

2020-06-02 Thread Xionghu Luo via Gcc-patches
Double array in structure as function arguments or return value is accessed by BLKmode, they are stored to stack and load from stack with redundant conversion from DF->DI->DF. This patch checks the homogeneous type and use the actual element type to do block move to by pass the conversions.

Re: [PATCH] Optimize and+or+sub into xor+not (PR94882)

2020-06-02 Thread Richard Biener via Gcc-patches
On Fri, May 29, 2020 at 5:56 AM Naveen Hurugalawadi via Gcc-patches wrote: > > Hi, > > Please find attached the patch that addresses PR94882. > > Bootstrapped and regression tested on x86_64-pc-linux-gnu. Is the pattern correct for saturating arithmetic? Some related patterns test

Re: [PATCH, FORTRAN] matchexp.c: Fix possible false positive of uninitialized variable usage e

2020-06-02 Thread Stefan Schulze Frielinghaus via Gcc-patches
Ping On Tue, May 19, 2020 at 08:33:24AM +0200, Stefan Schulze Frielinghaus via Gcc-patches wrote: > While bootstrapping GCC on S/390 the following warning is raised: > > gcc/fortran/matchexp.c: In function 'match match_level_5(gfc_expr**)': > gcc/fortran/matchexp.c:401:18: error: 'e' may be

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On Tue, 2 Jun 2020 at 07:44, Martin Liška wrote: > > On 6/1/20 7:24 PM, Jonathan Wakely wrote: > > On Mon, 25 May 2020 at 23:50, Jakub Jelinek via Gcc > > wrote: > >> > >> Hi! > >> > >> I've turned the strict mode of Martin Liška's hook changes, > >> which means that from now on no commits to

Fix PR middle-end/95395

2020-06-02 Thread Eric Botcazou
The usual stupid confusion between bits and bytes... The tree-pretty-print.c hunk is unrelated and has been approved by Richard elsewhere. Tested on SPARC64/Linux, applied on the mainline as obvious. 2020-06-02 Eric Botcazou PR middle-end/95395 * optabs.c (expand_unop): Fix

Re: [PATCH 1/4] ipa-sra: Do not remove statements necessary because of non-call EH (PR 95113)

2020-06-02 Thread Richard Biener
On Thu, 28 May 2020, Martin Jambor wrote: > PR 95113 revealed that when reasoning about which parameters are dead, > IPA-SRA does not perform the same check related to non-call exceptions > as tree DCE. It most certainly should and so this patch moves the > condition used in tree-ssa-dce.c into

Re: [stage1][PATCH] Make TOPN counter dynamically allocated.

2020-06-02 Thread Martin Liška
On 6/2/20 10:27 AM, Jan Hubicka wrote: The patch looks good (and is OK for mainline). I am bit concerned about two things. Hello. Thank you for the review! 1) I think we should add support to pre-allocate memory pool so we hide the problem with instrumenting malloc (I think with big

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Gerald Pfeifer
On Mon, 1 Jun 2020, Jonathan Wakely via Gcc-patches wrote: > The libstdc++ manual is written in Docbook XML, but we commit both the > XML and generated HTML pages to Git. Sometimes a small XML file can > result in dozens of mechanical changes to the generated HTML files, > which we record in the

[committed] d: Set up input_location before lowering Dsymbol AST

2020-06-02 Thread Iain Buclaw via Gcc-patches
Hi, Like a similarly named function in the visitor class for statements, this ensures that the current input_location is set to the correct source file location of the decl. It is likely that there are a number of cases where declarations have ended up with no location without this.

Re: [stage1][PATCH] Lower VEC_COND_EXPR into internal functions.

2020-06-02 Thread Richard Biener via Gcc-patches
On Sat, May 30, 2020 at 3:08 PM Segher Boessenkool wrote: > > Hi! > > On Sat, May 30, 2020 at 08:15:55AM +0100, Richard Sandiford wrote: > > Segher Boessenkool writes: > > >> Sure. But the point is that FAILing isn't “explicitly allowed” for > > >> vcond*. > > >> In fact it's the opposite. > >

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On Tue, 2 Jun 2020 at 12:05, Jonathan Wakely wrote: > > On Tue, 2 Jun 2020 at 11:56, Gerald Pfeifer wrote: > > > > On Mon, 1 Jun 2020, Jonathan Wakely via Gcc-patches wrote: > > > The libstdc++ manual is written in Docbook XML, but we commit both the > > > XML and generated HTML pages to Git.

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On Tue, 2 Jun 2020 at 12:09, Jonathan Wakely wrote: > > On Tue, 2 Jun 2020 at 12:05, Jonathan Wakely wrote: > > > > On Tue, 2 Jun 2020 at 11:56, Gerald Pfeifer wrote: > > > > > > On Mon, 1 Jun 2020, Jonathan Wakely via Gcc-patches wrote: > > > > The libstdc++ manual is written in Docbook XML,

Re: [PATCH 0/4] IVOPTs consider step cost for different forms when unrolling

2020-06-02 Thread Richard Biener
On Thu, 28 May 2020, Kewen.Lin wrote: > Hi, > > This is one repost and you can refer to the original series > via https://gcc.gnu.org/pipermail/gcc-patches/2020-January/538360.html. > > As we discussed in the thread > https://gcc.gnu.org/ml/gcc-patches/2020-01/msg00196.html > Original:

Re: [IMPORTANT] ChangeLog related changes

2020-06-02 Thread Martin Liška
On 6/2/20 1:48 PM, Martin Liška wrote: I tend to this approach. Let me prepare a patch candidate for it. There's a patch for it. Can you please Jonathan take a look? Thanks, Martin >From 4d2cf31b6deb03c9ddc8062b9a45d2511e4a58bb Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 2 Jun

Re: [PATCH] contrib: Improve error text for overlong ChangeLog lines

2020-06-02 Thread Martin Liška
On 6/2/20 11:23 AM, Jonathan Wakely wrote: On 02/06/20 10:22 +0100, Jonathan Wakely wrote: This error is wrong, the line is what exceeds LINE_LIMIT characters, the limit doesn't exceed itself. contrib/ChangeLog: * gcc-changelog/git_commit.py (GitCommit.parse_changelog): Fix * grammar.

[committed] libstdc++: Make debug containers prefer copy ctor to base ctor (PR 90102)

2020-06-02 Thread Jonathan Wakely via Gcc-patches
When given a type which can convert to any container-like type, the C(const C&) copy constructor and C(const C::_Base&) converting constructor are ambiguous. This change replaces the converting constructor's parameter with a reference_wrapper-like type so that calling that constructor requires an

[FYI] [Ada] remove last traces of -auxbase

2020-06-02 Thread Alexandre Oliva
Remove occurrences of auxbase that remained in comments. Regstrapped on x86_64-linux-gnu. Pre-approved by Arno. for gcc/ada/ChangeLog * lib.ads (Compilation_Switches): Remove -auxbase from comments. * switch.ads (Is_Internal_GCC_Switch): Likewise. --- ada/lib.ads

[PATCH] FAT library support for libatomic, libgfortran, libgomp, libstdc++

2020-06-02 Thread David Edelsohn via Gcc-patches
[I'll start by repeating what I wrote about a similar libgcc change to provide background and context.] When AIX added 64 bit support, it implemented what Apple MacOS Darwin calls "FAT" libraries for its equivalent functionality -- both 32 bit and 64 bit objects (or shared objects) are co-located

[PATCH][GCC 9] aarch64: Add initial support for -mcpu=zeus

2020-06-02 Thread Kyrylo Tkachov
Hi all, This patch adds support for the Arm Zeus CPU. Bootstrapped and tested on aarch64-none-linux-gnu. Committing to the GCC 9 branch. Thanks, Kyrill 2020-06-02 Kyrylo Tkachov * config/aarch64/aarch64-cores.def (zeus): Define. * config/aarch64/aarch64-tune.md: Regenerate.

Re: [PATCH 5/7 v3] vect: Support vector load/store with length in vectorizer

2020-06-02 Thread Segher Boessenkool
On Tue, Jun 02, 2020 at 12:50:25PM +0100, Richard Sandiford wrote: > This might not be the best time to bring this up :-) but it seems > odd to be asking the target for the induction variable type here. > I got the impression that the hook was returning DImode, whereas > the PowerPC instructions

Re: [PATCH PR95459] aarch64: ICE in aarch64_short_vector_p, at config/aarch64/aarch64.c:16803

2020-06-02 Thread Richard Sandiford
"Yangfei (Felix)" writes: > Hi, > > Please review this trivial patch fixing an ICE in aarch64_short_vector_p. > Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95459 > > In aarch64_short_vector_p, we are simply checking whether a type (and a > mode) > is a 64/128-bit short

Re: [PATCH] Port libgccjit to Windows.

2020-06-02 Thread JonY via Gcc-patches
On 5/28/20 8:46 PM, David Malcolm via Gcc-patches wrote: > On Thu, 2020-05-28 at 16:51 -0300, Nicolas Bértolo wrote: >>> I'm going to have to trust your Windows expertise here; the tempdir >>> code looks convoluted to me, but perhaps that's the only way to do >> it. >>> (Microsoft's docs for

[PATCH] aarch64: Add initial support for -mcpu=zeus

2020-06-02 Thread Kyrylo Tkachov
Hi all, This patch adds support for the Arm Zeus CPU. Bootstrapped and tested on aarch64-none-linux-gnu. Committing to trunk (and to the GCC 10 branch). Thanks, Kyrill gcc/ 2020-06-02 Kyrylo Tkachov * config/aarch64/aarch64-cores.def (zeus): Define. *

[PATCH] RISC-V: Make __divdi3 handle div by zero same as hardware.

2020-06-02 Thread Jim Wilson
The ISA manual specifies that divide by zero always returns -1 as the result. We were failing to do that when the dividend was negative. Tested with cross toolchain builds for riscv32-elf and riscv64-linux. There were no regressions. Committed. Jim libgcc/ * config/riscv/div.S

[pushed] c++: *this capture in const member fn [PR95193].

2020-06-02 Thread Jason Merrill via Gcc-patches
Here, the capture proxy for *this is const, but its DECL_VALUE_EXPR is not. Don't ICE on this; it's a reasonable difference, since in C++ an rvalue of scalar type does not have cv-qualifiers. Tested x86_64-pc-linux-gnu, applying to trunk. gcc/cp/ChangeLog: PR c++/95193 * pt.c

[PATCH][GCC 8] aarch64: Add initial support for -mcpu=zeus

2020-06-02 Thread Kyrylo Tkachov
Hi all, This patch adds support for the Arm Zeus CPU. Bootstrapped and tested on aarch64-none-linux-gnu. Committing to the GCC 8 branch. Thanks, Kyrill gcc/ 2020-06-02 Kyrylo Tkachov * config/aarch64/aarch64-cores.def (zeus): Define. * config/aarch64/aarch64-tune.md:

  1   2   >