[PATCH v6] Add condition coverage profiling

2023-10-21 Thread Jørgen Kvalsvik
This patch adds support in gcc+gcov for modified condition/decision coverage (MC/DC) with the -fprofile-conditions flag. MC/DC is a type of test/code coverage and it is particularly important in the avation and automotive industries for safety-critical applications. MC/DC it is required for or

Re: [PATCH 01/22] Add condition coverage profiling

2023-10-21 Thread Jørgen Kvalsvik
On 05/10/2023 22:39, Jørgen Kvalsvik wrote: On 05/10/2023 21:59, Jan Hubicka wrote: Like Wahlen et al this implementation records coverage in fixed-size bitsets which gcov knows how to interpret. This is very fast, but introduces a limit on the number of terms in a single boolean expression,

Re: [PATCH] libstdc++: Ensure active union member is correctly set

2023-10-21 Thread Jonathan Wakely
On Fri, 29 Sept 2023 at 17:46, Jonathan Wakely wrote: > > On Fri, 29 Sept 2023 at 17:29, Nathaniel Shead > wrote: > > > > On Fri, Sep 29, 2023 at 04:06:33PM +0100, Jonathan Wakely wrote: > > > On Fri, 29 Sept 2023 at 10:32, Jonathan Wakely wrote: > > > > > Thanks for the comments, here's an

Re: Remove stale Autoconf checks for Perl

2023-10-21 Thread Alexandre Oliva
On May 16, 2023, Thomas Schwinge wrote: > OK to push the attached "Remove stale Autoconf checks for Perl"? LGTM, thanks, -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation

Re: [PATCH 2/5] LoongArch: Use explicit relocs for GOT access when -mexplicit-relocs=auto and LTO during a final link with linker plugin

2023-10-21 Thread chenglulu
/* snip */ +/* If -mexplicit-relocs=auto, we use machine operations with reloc hints + for cases where the linker is unable to relax so we can schedule the + machine operations, otherwise use an assembler pseudo-op so the + assembler will generate R_LARCH_RELAX. */ + +bool

[PATCH] [PR111520] set hardcmp eh probs (was: rename make_eh_edges to make_eh_edge)

2023-10-21 Thread Alexandre Oliva
On Oct 20, 2023, Richard Biener wrote: >> * tree-eh.h (make_eh_edges): Rename to... >> (make_eh_edge): ... this. >> * tree-eh.cc: Likewise. Adjust all callers. Once the above goes in (it depends on the strub monster patch), the following one should apply as well. Regstrapped on

Re: [PATCH 2/5] LoongArch: Use explicit relocs for GOT access when -mexplicit-relocs=auto and LTO during a final link with linker plugin

2023-10-21 Thread Xi Ruoyao
On Sat, 2023-10-21 at 15:32 +0800, chenglulu wrote: > > +  /* If we are performing LTO for a final link, and we have the linker > > + plugin so we know the resolution of the symbols, then all GOT > > + references are binding to external symbols or preemptable symbols. > > + So the

Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

2023-10-21 Thread Ajit Agarwal
Hello Vineet: Thanks for your time and valuable comments. On 21/10/23 5:26 am, Vineet Gupta wrote: > On 10/19/23 23:50, Ajit Agarwal wrote: >> Hello All: >> >> This version 9 of the patch uses abi interfaces to remove zero and sign >> extension elimination. >> Bootstrapped and regtested on

[PATCH v10 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

2023-10-21 Thread Ajit Agarwal
Hello Vineet and Jeff: This version 10 of the patch uses abi interfaces to remove zero and sign extension elimination. Bootstrapped and regtested on powerpc-linux-gnu. In this version (version 9) of the patch following review comments are incorporated. a) Removal of hard code zero_extend and

Re: [PATCH v2] libstdc++: testsuite: Enhance codecvt_unicode with tests for length()

2023-10-21 Thread Jonathan Wakely
On Wed, 18 Oct 2023 at 11:52, Dimitrij Mijoski wrote: > > We can test codecvt::length() with the same data that we test > codecvt::in(). For each call of in() we add another call to length(). > Some additional small cosmentic changes are applied. Pushed to master, thanks! > >

Re: [PATCH v2] libstdc++: Workaround for LLVM-61763 in ranges

2023-10-21 Thread Jonathan Wakely
On Mon, 16 Oct 2023 at 04:56, Benjamin Acker Brock wrote: > > > I don't think this patch counts as legally significant, but if you > > contribute again in future you should be aware of > > https://gcc.gnu.org/contribute.html#legal and either complete the copyright > > assignment paperwork, or

[PING 2] [C PATCH] Synthesize nonnull attribute for parameters declared with static

2023-10-21 Thread Martin Uecker
> > C programmers increasingly use static to indicate that > pointer parameters are non-null. Clang can exploit this > for warnings and optimizations. GCC has some warnings > but not all warnings it has for nonnull. Below is a > patch to add a nonnull attribute automatically for such  >

[committed] libstdc++: Fix formatting of filesystem directory iterators

2023-10-21 Thread Jonathan Wakely
Tested x86_64-linux. Pushed to trunk. -- >8 -- Fix indentation. libstdc++-v3/ChangeLog: * include/bits/fs_dir.h (operator==(default_sentinel_t)): Fix indentation. --- libstdc++-v3/include/bits/fs_dir.h | 16 1 file changed, 8 insertions(+), 8 deletions(-)

Re: [PATCH v2] libstdc++: Workaround for LLVM-61763 in ranges

2023-10-21 Thread Jonathan Wakely
On Sat, 21 Oct 2023 at 12:16, Jonathan Wakely wrote: > > On Mon, 16 Oct 2023 at 04:56, Benjamin Acker Brock wrote: > > > > > I don't think this patch counts as legally significant, but if you > > > contribute again in future you should be aware of > > >

[PATCH] convert_to_complex vs invalid_conversion [PR111903]

2023-10-21 Thread Andrew Pinski
convert_to_complex when creating a COMPLEX_EXPR does not currently check if either the real or imag parts was not error_mark_node. This later on confuses the gimpilfier when there was a SAVE_EXPR wrapped around that COMPLEX_EXPR. The simple fix is after calling convert inside convert_to_complex_1,

[RFC PATCH] RISC-V: Initial RV64E and LP64E support

2023-10-21 Thread Tsukasa OI
From: Tsukasa OI Along with RV32E, RV64E is ratified. Though ILP32E and LP64E ABIs are still draft, it's worth supporting it. This commit should not be merged until two proposals below are going to proceed. LP64E proposal (including suggested changes):

Re: [PATCH] RISC-V: 'Zfa' extension is now ratified

2023-10-21 Thread Jeff Law
On 10/20/23 23:32, Tsukasa OI wrote: From: Tsukasa OI Since this extension is ratified, it now has the version number 1.0. Reference: gcc/ChangeLog: * common/config/riscv/riscv-common.cc (riscv_ext_version_table):

Re: [PATCH] RISC-V: Prohibit combination of 'E' and 'H'

2023-10-21 Thread Jeff Law
On 10/20/23 23:32, Tsukasa OI wrote: From: Tsukasa OI According to the ratified privileged specification (version 20211203), it says: The hypervisor extension depends on an "I" base integer ISA with 32 x registers (RV32I or RV64I), not RV32E, which has only 16 x registers. Also in the

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-21 Thread Jeff Law
On 10/8/23 16:14, Iain Sandoe wrote: + Jeff On 8 Oct 2023, at 14:07, Nathanael Nerode wrote: I hope a global maintainer can step up. I've been on hiatus from GCC work for some years, and this was never my part of the build system anyway -- and I don't use Darwin -- so I'm not qualified

Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

2023-10-21 Thread rep . dot . nop
On 21 October 2023 01:56:16 CEST, Vineet Gupta wrote: >On 10/19/23 23:50, Ajit Agarwal wrote: >> Hello All: >> >> This version 9 of the patch uses abi interfaces to remove zero and sign >> extension elimination. >> Bootstrapped and regtested on powerpc-linux-gnu. >> >> In this version (version

Re: [PATCH] move the (a-b) CMP 0 ? (a-b) : (b-a) optimization from fold_cond_expr_with_comparison to match

2023-10-21 Thread Andrew Pinski
On Thu, Oct 19, 2023 at 10:13 PM Andrew Pinski wrote: > > On Mon, Jul 12, 2021 at 4:47 AM Richard Biener via Gcc-patches > wrote: > > > > On Sun, Jul 11, 2021 at 4:12 AM apinski--- via Gcc-patches > > wrote: > > > > > > From: Andrew Pinski > > > > > > This patch moves the (a-b) CMP 0 ? (a-b) :

[PATCHv2] move the (a-b) CMP 0 ? (a-b) : (b-a) optimization from fold_cond_expr_with_comparison to match

2023-10-21 Thread Andrew Pinski
From: Andrew Pinski This patch moves the `(a-b) CMP 0 ? (a-b) : (b-a)` optimization from fold_cond_expr_with_comparison to match. Bootstrapped and tested on x86_64-linux-gnu. Changes in: v2: Removes `(a == b) ? 0 : (b - a)` handling since it was handled via r14-3606-g3d86e7f4a8ae

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-21 Thread Iain Sandoe
Hi Jeff, > On 21 Oct 2023, at 19:05, Jeff Law wrote: > On 10/8/23 16:14, Iain Sandoe wrote: >> + Jeff >>> On 8 Oct 2023, at 14:07, Nathanael Nerode wrote: >>> >>> I hope a global maintainer can step up. I've been on hiatus from GCC work >>> for some years, and this was never my part of the

Re: [PATCH] RISC-V: Prohibit combination of 'E' and 'H'

2023-10-21 Thread Tsukasa OI
On 2023/10/22 3:04, Jeff Law wrote: > > > On 10/20/23 23:32, Tsukasa OI wrote: >> From: Tsukasa OI >> >> According to the ratified privileged specification (version 20211203), >> it says: >> >>> The hypervisor extension depends on an "I" base integer ISA with 32 x >>> registers (RV32I or