[PATCH v3 06/12] Exclude i386 functionality from aarch64 build

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Thu, 11 Apr 2024 13:38:59 +0200 Subject: [PATCH v3 06/12] Exclude i386 functionality from aarch64 build This patch defines TARGET_AARCH64_MS_ABI in config.gcc and uses it to exclude i386 functionality from aarch64 build and adjust MinGW headers for AArch64 MS ABI.

Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for Linux

2024-04-11 Thread Jonathan Wakely
On Thu, 11 Apr 2024 at 15:13, Jonathan Wakely wrote: > > On Thu, 11 Apr 2024 at 15:12, Andreas Schwab wrote: > > > > On Apr 11 2024, Jakub Jelinek wrote: > > > > > --- libstdc++-v3/config/abi/post/m68k-linux-gnu/baseline_symbols.txt.jj > > > 2023-05-04 09:42:43.277271065 +0200 > > > +++

[PING] Re: [PATCH 1/2] ivopts: Revert computation of address cost complexity.

2024-04-11 Thread Aleksandar Rakic
PING: I remind you that the patch for the computation of complexity for unsupported addressing modes ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109429 ) has been sent: https://gcc.gnu.org/pipermail/gcc-patches/2024-March/647966.html

Re: [PATCH v8 3/5] Use the .ACCESS_WITH_SIZE in builtin object size.

2024-04-11 Thread Qing Zhao
Sid, Thanks a lot for your review! > On Apr 10, 2024, at 17:45, Siddhesh Poyarekar wrote: > > On 2024-03-29 12:07, Qing Zhao wrote: >> gcc/ChangeLog: >> * tree-object-size.cc (access_with_size_object_size): New function. >> (call_object_size): Call the new function. >>

[PATCH v3 00/12] Add aarch64-w64-mingw32 target

2024-04-11 Thread Evgeny Karpov
Hello, Thank you for reviewing v2! v3 addresses all comments on v2. v3 Changes: - Exclude the aarch64_calling_abi declaration from the patch series. - Refactor x18 adjustment for MS ABI. - Remove unnecessary headers. - Add an extra comment to explain empty definitions. - Use gcc_unreachable for

Re: Combine patch ping

2024-04-11 Thread Segher Boessenkool
On Wed, Apr 10, 2024 at 08:32:39PM +0200, Uros Bizjak wrote: > On Wed, Apr 10, 2024 at 7:56 PM Segher Boessenkool > wrote: > > This is never okay. You cannot commit a patch without approval, *ever*. This is the biggest issue, to start with. It is fundamental. > > That patch is also obvious --

[PATCH v3 11/12] aarch64: Add aarch64-w64-mingw32 target to libatomic

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Fri, 1 Mar 2024 02:23:45 +0100 Subject: [PATCH v3 11/12] aarch64: Add aarch64-w64-mingw32 target to libatomic libatomic/ChangeLog: * configure.tgt: Add aarch64-w64-mingw32 target. --- libatomic/configure.tgt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 10/12] aarch64: Build and add objects for Cygwin and MinGW for AArch64

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Tue, 20 Feb 2024 13:55:51 +0100 Subject: [PATCH v3 10/12] aarch64: Build and add objects for Cygwin and MinGW for AArch64 gcc/ChangeLog: * config.gcc: Build and add objects for Cygwin and MinGW. Add Cygwin and MinGW options to the target. ---

Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for i386-linux-gnu

2024-04-11 Thread Jonathan Wakely
On Thu, 11 Apr 2024 at 15:07, Jakub Jelinek wrote: > > On Thu, Apr 11, 2024 at 02:59:05PM +0100, Jonathan Wakely wrote: > > I think we also want the same change for i386. > > > > -- >8 -- > > > > libstdc++-v3/ChangeLog: > > > > * config/abi/post/i386-linux-gnu/baseline_symbols.txt: > >

[pushed] modula2: add modula-2 language section to languages supported by GCC

2024-04-11 Thread Gaius Mulley
Pushed to trunk as r14-9915-g0dc39dee836761f1bc993d760f4ed5f3d127897a This patch introduces a small modula-2 language section to the Language Standards Supported by GCC node. gcc/ChangeLog: * doc/standards.texi (Language Standards Supported by GCC): Add Modula-2 language

[committed 5/5 v2] aarch64: Remove FMV features whose names may change

2024-04-11 Thread Andrew Carlotti
Some architecture features have been combined under a single command line flag, but have been assigned multiple FMV feature names with the command line flag name enabling only a subset of these features in the FMV specification. I've proposed reallocating names in the FMV specification to match

Re: [PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Jakub Jelinek
On Thu, Apr 11, 2024 at 04:35:52PM +0200, Andreas Schwab wrote: > +FUNC:_ZNKSt12__shared_ptrINSt10filesystem28recursive_directory_iterator10_Dir_stackELN9__gnu_cxx12_Lock_policyE1EEcvbEv@@GLIBCXX_3.4.31 >

Re: [PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Jonathan Wakely
On Thu, 11 Apr 2024 at 15:36, Andreas Schwab wrote: > > On Apr 11 2024, Jakub Jelinek wrote: > > > --- libstdc++-v3/config/abi/post/riscv64-linux-gnu/baseline_symbols.txt.jj > > 2024-04-11 15:55:49.982325397 +0200 > > +++ libstdc++-v3/config/abi/post/riscv64-linux-gnu/baseline_symbols.txt

[PATCH] contrib/check-params-in-docs.py: Ignore gcn-preferred-vectorization-factor

2024-04-11 Thread Martin Jambor
Hi, contrib/check-params-in-docs.py is a script that checks that all options reported with ./gcc/xgcc -Bgcc --help=param are in gcc/doc/invoke.texi and vice versa. gcn-preferred-vectorization-factor is in the manual but normally not reported by --help, probably because I do not have gcn offload

[PATCH] libstdc++: Export std::__basic_file::native_handle as GLIBCXX_3.4.33 [PR114692]

2024-04-11 Thread Jonathan Wakely
I plan to push this shortly, to fix the P1 ABI regression that Jakub reported earlier today. This will trigger 'make check-abi' failures for CI testers, because the baseline_sybols.txt wasn't regenerated for gcc 13.2.0 and so there are two symbols present in GLIBCXX_3.4.32 which are not in the

[PATCH v3 04/12] Reuse MinGW from i386 for AArch64

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Fri, 1 Mar 2024 02:41:50 +0100 Subject: [PATCH v3 04/12] Reuse MinGW from i386 for AArch64 This patch creates a new config/mingw directory to share MinGW related definitions, and moves there the corresponding existing files from config/i386. gcc/ChangeLog: *

[PATCH v3 03/12] aarch64: Add aarch64-w64-mingw32 COFF

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Thu, 11 Apr 2024 14:46:07 +0200 Subject: [PATCH v3 03/12] aarch64: Add aarch64-w64-mingw32 COFF Define ASM specific for COFF format on AArch64. gcc/ChangeLog: * config.gcc: Add COFF format support definitions. * config/aarch64/aarch64-coff.h: New file.

[PATCH] libstdc++: Regenerate baseline_symbols.txt files for i386-linux-gnu

2024-04-11 Thread Jonathan Wakely
I think we also want the same change for i386. -- >8 -- libstdc++-v3/ChangeLog: * config/abi/post/i386-linux-gnu/baseline_symbols.txt: Regenerate. --- .../config/abi/post/i386-linux-gnu/baseline_symbols.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for Linux

2024-04-11 Thread Jonathan Wakely
On Thu, 11 Apr 2024 at 15:12, Andreas Schwab wrote: > > On Apr 11 2024, Jakub Jelinek wrote: > > > --- libstdc++-v3/config/abi/post/m68k-linux-gnu/baseline_symbols.txt.jj > > 2023-05-04 09:42:43.277271065 +0200 > > +++ libstdc++-v3/config/abi/post/m68k-linux-gnu/baseline_symbols.txt > >

[pushed] modula2: add modula-2 language section to languages supported by GCC

2024-04-11 Thread Gaius Mulley
Pushed to trunk as r14-9915-g0dc39dee836761f1bc993d760f4ed5f3d127897a This patch introduces a small modula-2 language section to the Language Standards Supported by GCC node. gcc/ChangeLog: * doc/standards.texi (Language Standards Supported by GCC): Add Modula-2 language

[committed 0/5 v2] aarch64: FMV feature list fixes

2024-04-11 Thread Andrew Carlotti
This includes the following changes from v1: 1/5: Add missing testcase update. (I misread my test diffs, but Linaro precommit picked this up as well.) 2/5: Address review comments and add a testcase. 5/5: Remove "memtag", "ssbs" and "ls64" instead of renaming them. Bootstrapped and regression

Re: [PATCH, OpenACC 2.7] Connect readonly modifier to points-to analysis

2024-04-11 Thread Thomas Schwinge
Hi Chung-Lin, Richard! >From me just a few mechanical pieces, see below. Richard, are you able to again comment on Chung-Lin's general strategy, as I'm not at all familiar with those parts of the code? On 2024-04-03T19:50:55+0800, Chung-Lin Tang wrote: > On 2023/10/30 8:46 PM, Richard Biener

Re: [PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Jonathan Wakely
On Thu, 11 Apr 2024 at 15:46, Andreas Schwab wrote: > > On Apr 11 2024, Jakub Jelinek wrote: > > > On Thu, Apr 11, 2024 at 04:35:52PM +0200, Andreas Schwab wrote: > >>

Re: Combine patch ping

2024-04-11 Thread Richard Biener
> Am 11.04.2024 um 16:03 schrieb Segher Boessenkool > : > > On Wed, Apr 10, 2024 at 08:32:39PM +0200, Uros Bizjak wrote: >>> On Wed, Apr 10, 2024 at 7:56 PM Segher Boessenkool >>> wrote: >>> This is never okay. You cannot commit a patch without approval, *ever*. > > This is the biggest

[PATCH v3 01/12] Introduce aarch64-w64-mingw32 target

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Fri, 1 Mar 2024 01:40:53 +0100 Subject: [PATCH v3 01/12] Introduce aarch64-w64-mingw32 target Add the initial aarch64-w64-mingw32 target for gcc. This is the first commit in a sequence of patch series to add new aarch64-w64-mingw32 target. Coauthors: Zac Walker , Mark

[committed 1/5 v2] aarch64: Reorder FMV feature priorities

2024-04-11 Thread Andrew Carlotti
Some higher priority FMV features were dependent subsets of lower priority features. Fix this, using the new priorities specified in https://github.com/ARM-software/acle/pull/279. gcc/ChangeLog: * config/aarch64/aarch64-option-extensions.def: Reorder FMV entries.

[committed 2/5 v2] aarch64: Fix FMV array iteration bounds

2024-04-11 Thread Andrew Carlotti
There was an assumption in some places that the aarch64_fmv_feature_data array contained FEAT_MAX elements. While this assumption held up till now, it is safer and more flexible to use the array size directly. Also fix the lower bound in compare_feature_masks to use ">=0" instead of ">0", and

Re: [PATCH v8 4/5] Use the .ACCESS_WITH_SIZE in bound sanitizer.

2024-04-11 Thread Qing Zhao
Sid, Thanks a lot for the review. > On Apr 10, 2024, at 17:46, Siddhesh Poyarekar wrote: > > On 2024-03-29 12:07, Qing Zhao wrote: >> gcc/c-family/ChangeLog: >> * c-ubsan.cc (get_bound_from_access_with_size): New function. >> (ubsan_instrument_bounds): Handle call to

[PATCH] libstdc++: Regenerate baseline_symbols.txt files for Linux

2024-04-11 Thread Jakub Jelinek
Hi! The following patch regenerates the ABI files for 13 branch (I've only changed the Linux files which were updated in r13-7289, all but m68k, riscv64 and powerpc64 are from actual Fedora 39 gcc builds, the rest hand edited). We've added one symbol very early in the 13.2 cycle, but then added 2

[PATCH v3 07/12] aarch64: Add Cygwin and MinGW environments for AArch64

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Thu, 11 Apr 2024 13:41:51 +0200 Subject: [PATCH v3 07/12] aarch64: Add Cygwin and MinGW environments for AArch64 Define Cygwin and MinGW environment such as types, SEH definitions, shared libraries, etc. gcc/ChangeLog: * config.gcc: Add Cygwin and MinGW

Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for Linux

2024-04-11 Thread Andreas Schwab
On Apr 11 2024, Jakub Jelinek wrote: > --- libstdc++-v3/config/abi/post/m68k-linux-gnu/baseline_symbols.txt.jj > 2023-05-04 09:42:43.277271065 +0200 > +++ libstdc++-v3/config/abi/post/m68k-linux-gnu/baseline_symbols.txt > 2024-04-11 15:44:07.113985138 +0200 > @@ -3214,6 +3214,7 @@

Re: [PATCH V4 1/3] aarch64: Place target independent and dependent changed code in one file

2024-04-11 Thread Alex Coplan
On 10/04/2024 23:48, Ajit Agarwal wrote: > Hello Alex: > > On 10/04/24 7:52 pm, Alex Coplan wrote: > > Hi Ajit, > > > > On 10/04/2024 15:31, Ajit Agarwal wrote: > >> Hello Alex: > >> > >> On 10/04/24 1:42 pm, Alex Coplan wrote: > >>> Hi Ajit, > >>> > >>> On 09/04/2024 20:59, Ajit Agarwal wrote:

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-04-11 Thread Richard Sandiford
Evgeny Karpov writes: > Wednesday, April 10, 2024 8:40 PM > Richard Sandiford wrote: > >> Thanks for the updates and sorry again for the slow review. >> I've replied to some of the patches in the series but otherwise it looks >> good to >> me. >> >> If you agree with the suggested changes then

Re: [PATCH 2/3] bpf: remove huge memory waste with string allocation.

2024-04-11 Thread Cupertino Miranda
Hi David, Thanks for the review. Will apply the changes. Nice catch and optimization with the vlen size. Cupertino David Faust writes: > Hi Cupertino, > > On 4/11/24 04:11, Cupertino Miranda wrote: >> Code was allocating way too much space for the string. > > A little bit more description

[PATCH] aarch64: Preserve mem info on change of base for ldp/stp [PR114674]

2024-04-11 Thread Alex Coplan
Hi, The ldp/stp fusion pass can change the base of an access so that the two accesses end up using a common base register. So far we have been using adjust_address_nv to do this, but this means that we don't preserve other properties of the mem we're replacing. It seems better to use

Re: [PATCH v8 1/5] Provide counted_by attribute to flexible array member field (PR108896)

2024-04-11 Thread Qing Zhao
> On Apr 10, 2024, at 17:56, Joseph Myers wrote: > > On Wed, 10 Apr 2024, Qing Zhao wrote: > >> Okay, the above is very clear, thanks a lot for the explanation. >> So, basically, for “counted-by” attribute: >> **The following is good: >> struct f { >> int b; >> int c; >> int a[]

Re: [PATCH v8 2/5] Convert references with "counted_by" attributes to/from .ACCESS_WITH_SIZE.

2024-04-11 Thread Qing Zhao
Sid and Richard, The C FE changes in this patch has been approved by Joseph. Could you please review the Middle-end change? thanks. Qing > On Apr 10, 2024, at 14:36, Joseph Myers wrote: > > On Fri, 29 Mar 2024, Qing Zhao wrote: > >> +/* For a SUBDATUM field of a structure or union DATUM,

[PATCH v3 05/12] Rename section and encoding functions from i386 which will be used in aarch64

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Tue, 20 Feb 2024 17:22:31 +0100 Subject: [PATCH v3 05/12] Rename section and encoding functions from i386 which will be used in aarch64 gcc/ChangeLog: * config/i386/cygming.h (SUBTARGET_ENCODE_SECTION_INFO): Rename functions in mingw folder which will be

Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for Linux

2024-04-11 Thread Jonathan Wakely
On Thu, 11 Apr 2024 at 14:52, Jakub Jelinek wrote: > > Hi! > > The following patch regenerates the ABI files for 13 branch (I've only changed > the Linux files which were updated in r13-7289, all but m68k, riscv64 and > powerpc64 are from actual Fedora 39 gcc builds, the rest hand edited). >

[PATCH v3 12/12] Add aarch64-w64-mingw32 target to libgcc

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Mon, 12 Feb 2024 15:22:47 +0100 Subject: [PATCH v3 12/12] Add aarch64-w64-mingw32 target to libgcc Reuse MinGW definitions from i386 for libgcc. Move reused files to libgcc/config/mingw folder. libgcc/ChangeLog: * config.host: Add aarch64-w64-mingw32 target.

[PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-04-11 Thread Evgeny Karpov
Wednesday, April 10, 2024 8:40 PM Richard Sandiford wrote: > Thanks for the updates and sorry again for the slow review. > I've replied to some of the patches in the series but otherwise it looks good > to > me. > > If you agree with the suggested changes then the series is OK for stage 1, >

Re: [PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Andreas Schwab
On Apr 11 2024, Jakub Jelinek wrote: > On Thu, Apr 11, 2024 at 04:35:52PM +0200, Andreas Schwab wrote: >> +FUNC:_ZNKSt12__shared_ptrINSt10filesystem28recursive_directory_iterator10_Dir_stackELN9__gnu_cxx12_Lock_policyE1EEcvbEv@@GLIBCXX_3.4.31 >>

[PATCH v3 09/12] Rename "x86 Windows Options" to "Cygwin and MinGW Options"

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Thu, 11 Apr 2024 13:43:23 +0200 Subject: [PATCH v3 09/12] Rename "x86 Windows Options" to "Cygwin and MinGW Options" Rename "x86 Windows Options" to "Cygwin and MinGW Options". It will be used also for AArch64. gcc/ChangeLog: * config/i386/mingw-w64.opt.urls:

[committed 4/5] aarch64: Remove unsupported FMV features

2024-04-11 Thread Andrew Carlotti
It currently isn't possible to support function multiversioning features properly in GCC without also enabling the extension in the command line options (with the exception of features such as "rpres" that do not require assembler support). We therefore remove unsupported features from GCC's list

[committed 3/5] aarch64: Fix typo and make rdma/rdm alias for FMV

2024-04-11 Thread Andrew Carlotti
gcc/ChangeLog: * config/aarch64/aarch64-option-extensions.def: Fix "rmd"->"rdm", and add FMV to "rdma". * config/aarch64/aarch64.cc (FEAT_RDMA): Define as FEAT_RDM. diff --git a/gcc/config/aarch64/aarch64-option-extensions.def

Re: [PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Andreas Schwab
On Apr 11 2024, Jakub Jelinek wrote: > --- libstdc++-v3/config/abi/post/riscv64-linux-gnu/baseline_symbols.txt.jj > 2024-04-11 15:55:49.982325397 +0200 > +++ libstdc++-v3/config/abi/post/riscv64-linux-gnu/baseline_symbols.txt > 2024-04-11 16:10:05.206559463 +0200 > @@ -497,6 +497,7 @@

Re: [PATCH 2/3] bpf: remove huge memory waste with string allocation.

2024-04-11 Thread David Faust
Hi Cupertino, On 4/11/24 04:11, Cupertino Miranda wrote: > Code was allocating way too much space for the string. A little bit more description would not hurt. Perhaps you could say something like: "The BPF backend was allocating an unnecessarily large string when constructing CO-RE relocations

Re: [PATCH] libstdc++: Compile std::allocator instantiations as C++20

2024-04-11 Thread Ville Voutilainen
On Thu, 11 Apr 2024 at 20:22, Jonathan Wakely wrote: > > I'm considering this late patch for gcc-14 to workaround an issue > discovered by a recent Clang change. > > I'm not yet sure if Clang is right to require these symbols. It's not > really clear, because always_inline isn't part of the

Re: [PATCH v8 5/5] Add the 6th argument to .ACCESS_WITH_SIZE

2024-04-11 Thread Qing Zhao
Sid, Thanks a lot for your review. Richard, Could you please comment on this patch? Is the middle-end part Okay for stage 1? Thanks. Qing On Apr 10, 2024, at 17:48, Siddhesh Poyarekar wrote: On 2024-03-29 12:07, Qing Zhao wrote: to carry the TYPE of the flexible array. Such information is

Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for i386-linux-gnu

2024-04-11 Thread Jakub Jelinek
On Thu, Apr 11, 2024 at 02:59:05PM +0100, Jonathan Wakely wrote: > I think we also want the same change for i386. > > -- >8 -- > > libstdc++-v3/ChangeLog: > > * config/abi/post/i386-linux-gnu/baseline_symbols.txt: > Regenerate. Not sure about that, the file is missing all the

[PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Jakub Jelinek
Hi! While the previous patch was regeneration from 13.2 release (with hand edits for arches I don't have libraries for but which are still well maintained), thius one is regeneration from the trunk (this time for hand edits everywhere for the PR114692

Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for Linux

2024-04-11 Thread Jakub Jelinek
On Thu, Apr 11, 2024 at 03:16:02PM +0100, Jonathan Wakely wrote: > > That symbol should not be in this symver, see > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114692 and > > https://gcc.gnu.org/pipermail/gcc-patches/2024-April/649260.html > > Jakub's patch is just adding the symbols from

Re: [PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Jonathan Wakely
On Thu, 11 Apr 2024 at 15:18, Jakub Jelinek wrote: > > Hi! > > While the previous patch was regeneration from 13.2 release (with hand > edits for arches I don't have libraries for but which are still well > maintained), thius one is regeneration from the trunk (this time for > hand edits

[PATCH] Update GCC 14.1 library versions in docs

2024-04-11 Thread Jakub Jelinek
Hi! When we are already touching this topic, here is a patch like r13-5126 which documents the upcoming release symbol versions in the documentation. Ok for trunk? 2024-04-11 Jakub Jelinek * doc/xml/manual/abi.xml: Add latest library versions. * doc/html/manual/abi.html:

Re: [PATCH] Update GCC 14.1 library versions in docs

2024-04-11 Thread Jonathan Wakely
On Thu, 11 Apr 2024 at 15:50, Jakub Jelinek wrote: > > Hi! > > When we are already touching this topic, here is a patch like r13-5126 > which documents the upcoming release symbol versions in the documentation. > > Ok for trunk? OK, thanks. > > 2024-04-11 Jakub Jelinek > > *

[PATCH] aarch64: Fix _BitInt testcases

2024-04-11 Thread Andre Vieira (lists)
This patch fixes some testisms introduced by: commit 5aa3fec38cc6f52285168b161bab1a869d864b44 Author: Andre Vieira Date: Wed Apr 10 16:29:46 2024 +0100 aarch64: Add support for _BitInt The testcases were relying on an unnecessary sign-extend that is no longer generated. The tested

Re: [PATCH] aarch64: Fix _BitInt testcases

2024-04-11 Thread Richard Sandiford
"Andre Vieira (lists)" writes: > This patch fixes some testisms introduced by: > > commit 5aa3fec38cc6f52285168b161bab1a869d864b44 > Author: Andre Vieira > Date: Wed Apr 10 16:29:46 2024 +0100 > > aarch64: Add support for _BitInt > > The testcases were relying on an unnecessary

[PATCH] libstdc++: Compile std::allocator instantiations as C++20

2024-04-11 Thread Jonathan Wakely
I'm considering this late patch for gcc-14 to workaround an issue discovered by a recent Clang change. I'm not yet sure if Clang is right to require these symbols. It's not really clear, because always_inline isn't part of the standard so it's not clear how it should interact with explicit

Re: [PATCH v8 1/5] Provide counted_by attribute to flexible array member field (PR108896)

2024-04-11 Thread Qing Zhao
> On Apr 11, 2024, at 02:02, Martin Uecker wrote: > > Am Mittwoch, dem 10.04.2024 um 19:35 + schrieb Qing Zhao: >> >>> On Apr 10, 2024, at 15:05, Martin Uecker wrote: >>> >>> Am Mittwoch, dem 10.04.2024 um 20:25 +0200 schrieb Martin Uecker: Am Mittwoch, dem 10.04.2024 um 17:35

Re: [PATCH] aarch64: Preserve mem info on change of base for ldp/stp [PR114674]

2024-04-11 Thread Richard Sandiford
Alex Coplan writes: > Hi, > > The ldp/stp fusion pass can change the base of an access so that the two > accesses end up using a common base register. So far we have been using > adjust_address_nv to do this, but this means that we don't preserve > other properties of the mem we're replacing.

[PATCH v3 02/12] aarch64: Mark x18 register as a fixed register for MS ABI

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Thu, 11 Apr 2024 13:30:27 +0200 Subject: [PATCH v3 02/12] aarch64: Mark x18 register as a fixed register for MS ABI Define the MS ABI for aarch64-w64-mingw32. Adjust FIXED_REGISTERS, CALL_REALLY_USED_REGISTERS and STATIC_CHAIN_REGNUM for AArch64 MS ABI. The X18 register

[PATCH v3 08/12] aarch64: Add SEH to machine_function

2024-04-11 Thread Evgeny Karpov
From: Zac Walker Date: Tue, 20 Feb 2024 18:10:08 +0100 Subject: [PATCH v3 08/12] aarch64: Add SEH to machine_function SEH is not enabled in aarch64-w64-mingw32 target yet. However, it is needed to be declared in machine_function for reusing winnt.cc. gcc/ChangeLog: *

[PATCH, OpenACC 2.7, v3] Adjust acc_map_data/acc_unmap_data interaction with reference counters

2024-04-11 Thread Chung-Lin Tang
Hi Thomas, On 2024/3/15 7:24 PM, Thomas Schwinge wrote: > Hi Chung-Lin! > > I realized: please add "PR libgomp/92840" to the Git commit log, as your > changes are directly a continuation of my earlier changes. Okay, I'll remember to do that. ... > - if (n->refcount !=

[r14-9912 Regression] FAIL: gcc.dg/guality/pr54693-2.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects -DPREVENT_OPTIMIZATION line 21 z == 30 - 3 * i on Linux/x86_64

2024-04-11 Thread haochen.jiang
On Linux/x86_64, c7e8a8d814229fd6fc4c16c2452f15dddc613479 is the first bad commit commit c7e8a8d814229fd6fc4c16c2452f15dddc613479 Author: Richard Biener Date: Thu Apr 11 11:08:07 2024 +0200 tree-optimization/109596 - wrong debug stmt move by copyheader caused FAIL:

Re: [PATCH] libstdc++: Compile std::allocator instantiations as C++20

2024-04-11 Thread Iain Sandoe
> On 11 Apr 2024, at 18:33, Ville Voutilainen > wrote: > > On Thu, 11 Apr 2024 at 20:22, Jonathan Wakely wrote: >> >> I'm considering this late patch for gcc-14 to workaround an issue >> discovered by a recent Clang change. >> >> I'm not yet sure if Clang is right to require these

[PATCH] btf: fix a possibly misleading asm debug comment

2024-04-11 Thread David Faust
This patch fixes a small error that could occur in the debug comment when emitting a type reference with btf_asm_type_ref. While working on a previous patch, I noticed the following in the asm output for the test btf-bitfields-4.c: ... .long 0x39# MEMBER 'c' idx=3

Re: [PATCH v2] btf: emit non-representable bitfield as void

2024-04-11 Thread Indu Bhagat
On 4/11/24 14:01, David Faust wrote: [Changes from v1: use btf_dmd_representable_bitfield_p in btf_asm_sou_member, instead of a slightly incorrect equivalent check.] This patch fixes an issue with mangled BTF that could occur when a struct type contains a bitfield member which cannot be

[wwwdocs] Update cxx-dr-status page

2024-04-11 Thread Marek Polacek
A big update. I posted a script to generate new entries and check the existing separately. W3 validated. Pushed. commit 9e32f911b70a8c2303b9b60679ce337896ccffdd Author: Marek Polacek Date: Thu Apr 11 21:18:23 2024 -0400 cxx-dr-status: Update from C++ Core Language Issue TOC, Revision

[PATCH] rs6000: Add OPTION_MASK_POWER8 [PR101865]

2024-04-11 Thread Peter Bergner
FYI: This patch is an update to Will Schmidt's patches to fix PR101865: https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601825.html https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601823.html ...taking into consideration patch reviews received than. I also found a few more

New Swedish PO file for 'gcc' (version 14.1-b20240218)

2024-04-11 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Swedish team of translators. The file is available at: https://translationproject.org/latest/gcc/sv.po (This file,

Re: [PATCH] btf: emit non-representable bitfield as void

2024-04-11 Thread Indu Bhagat
On 4/11/24 11:53, David Faust wrote: This patch fixes an issue with mangled BTF that could occur when a struct type contains a bitfield member which cannot be represented in BTF. It is undefined what should happen in such cases, but we can at least do something reasonable. Commit

[PATCH] contrib: add cxx-dr-table.sh

2024-04-11 Thread Marek Polacek
Ok for trunk? -- >8 -- I use this script to keep up-to-date. I thought it might be good to have it in contrib/, so I've polished it a little bit. contrib/ChangeLog: * cxx-dr-table.sh: New file. --- contrib/cxx-dr-table.sh | 108

Re: [PATCH] btf: fix a possibly misleading asm debug comment

2024-04-11 Thread Indu Bhagat
On 4/11/24 14:02, David Faust wrote: This patch fixes a small error that could occur in the debug comment when emitting a type reference with btf_asm_type_ref. While working on a previous patch, I noticed the following in the asm output for the test btf-bitfields-4.c: ... .long

RE: [PATCH] match: Fix `!a?b:c` and `a?~t:t` patterns for signed 1 bit types [PR114666]

2024-04-11 Thread Andrew Pinski (QUIC)
> -Original Message- > From: Richard Biener > Sent: Thursday, April 11, 2024 2:31 AM > To: Andrew Pinski (QUIC) > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] match: Fix `!a?b:c` and `a?~t:t` patterns for signed 1 > bit > types [PR114666] > > On Thu, Apr 11, 2024 at 10:43 AM

[PATCH v2] btf: emit non-representable bitfield as void

2024-04-11 Thread David Faust
[Changes from v1: use btf_dmd_representable_bitfield_p in btf_asm_sou_member, instead of a slightly incorrect equivalent check.] This patch fixes an issue with mangled BTF that could occur when a struct type contains a bitfield member which cannot be represented in BTF. It is undefined what

[PATCH 0/3] c++/modules: Fix some small issues with exported using-decls

2024-04-11 Thread Nathaniel Shead
This patch series fixes a few issues with exported using-declarations that have come up recently. I was hoping to fix PR114683 and PR114685 as well, but the issues there look to be much more involved and I'm not yet sure how to handle them. They're ultimately caused by using-declarations just

[PATCH] btf: emit non-representable bitfield as void

2024-04-11 Thread David Faust
This patch fixes an issue with mangled BTF that could occur when a struct type contains a bitfield member which cannot be represented in BTF. It is undefined what should happen in such cases, but we can at least do something reasonable. Commit 936dd627cd9 "btf: do not skip members of data

Re: [PATCH] btf: emit non-representable bitfield as void

2024-04-11 Thread David Faust
On 4/11/24 13:40, Indu Bhagat wrote: > On 4/11/24 11:53, David Faust wrote: >> This patch fixes an issue with mangled BTF that could occur when >> a struct type contains a bitfield member which cannot be represented >> in BTF. It is undefined what should happen in such cases, but we can >> at

Re: [PATCH v1] RISC-V: Bugfix ICE for the vector return arg in mode switch

2024-04-11 Thread Edwin Lu
On 4/11/2024 5:45 AM, Li, Pan2 wrote: Thanks for reporting this. Just take a look from my test log that 930623-1.c is all pass. Thus I bet this difference comes from the build option --with-arch=rv32imac but my test script take rv64gcv. I've built the git revision f3fdcf4a37a with

[PATCH 2/3] c++/modules: Propagate using decls from partitions

2024-04-11 Thread Nathaniel Shead
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? -- >8 -- The modules code currently neglects to set OVL_USING_P on the dependency created for a using-decl, which causes it not to remember that the OVL_EXPORT_P flag had been set on it when emitted from the primary interface unit.

[PATCH 1/3] c++/modules: Only emit exported GMF usings [PR114600]

2024-04-11 Thread Nathaniel Shead
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? -- >8 -- A typo in r14-6978 made us emit too many things. This ensures that we don't emit using-declarations from the GMF that we don't need to. PR c++/114600 gcc/cp/ChangeLog: * module.cc

Re: [PATCH] contrib/check-params-in-docs.py: Ignore gcn-preferred-vectorization-factor

2024-04-11 Thread Thomas Schwinge
Hi! On 2024-04-11T19:52:51+0200, Martin Jambor wrote: > contrib/check-params-in-docs.py is a script that checks that all > options reported with ./gcc/xgcc -Bgcc --help=param are in > gcc/doc/invoke.texi and vice versa. Eh, first time I'm hearing about this one! (a) Shouldn't this be running

Re: Combine patch ping

2024-04-11 Thread Uros Bizjak
On Thu, Apr 11, 2024 at 4:02 PM Segher Boessenkool wrote: > > On Wed, Apr 10, 2024 at 08:32:39PM +0200, Uros Bizjak wrote: > > On Wed, Apr 10, 2024 at 7:56 PM Segher Boessenkool > > wrote: > > > This is never okay. You cannot commit a patch without approval, *ever*. > > This is the biggest

[PATCH 3/3] c++/modules: Propagate hidden flag on decls from partitions

2024-04-11 Thread Nathaniel Shead
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? -- >8 -- While working on some other fixes I noticed that the partition handling code used the wrong flag to propagate OVL_HIDDEN_P on exported bindings from partitions. This patch fixes that, and renames the flag to be clearer.

[PATCH 1/1] RISC-V: Add Zfbfmin extension to the -march= option

2024-04-11 Thread Xiao Zeng
This patch would like to add new sub extension (aka Zfbfmin) to the -march= option. It introduces a new data type BF16. 1 The Zfbfmin extension depend on 'F', and the FLH, FSH, FMV.X.H, and FMV.H.X instructions as defined in the Zfh extension. 2 The Zfhmin extension includes the following

[PATCH] Value range: Add range op for __builtin_isfinite

2024-04-11 Thread HAO CHEN GUI
Hi, The former patch adds isfinite optab for __builtin_isfinite. https://gcc.gnu.org/pipermail/gcc-patches/2024-April/649339.html Thus the builtin might not be folded at front end. The range op for isfinite is needed for value range analysis. This patch adds them. Bootstrapped and tested

[PATCH v2] match: Fix `!a?b:c` and `a?~t:t` patterns for signed 1 bit types [PR114666]

2024-04-11 Thread Andrew Pinski
The problem is `!a?b:c` pattern will create a COND_EXPR with an 1bit signed integer which breaks patterns like `a?~t:t`. This rejects when we have a signed operand for both patterns. Note for GCC 15, I am going to look at the canonicalization of `a?~t:t` where t was a constant since I think

RE: [PATCH v1] RISC-V: Bugfix ICE for the vector return arg in mode switch

2024-04-11 Thread Li, Pan2
Thanks Edwin, should be one silly mistake, will fix it ASAP. Pan -Original Message- From: Edwin Lu Sent: Friday, April 12, 2024 5:20 AM To: Li, Pan2 ; Bernd Edlinger ; Kito Cheng ; juzhe.zh...@rivai.ai Cc: gcc-patches Subject: Re: [PATCH v1] RISC-V: Bugfix ICE for the vector return

[PATCH] Optab: add isfinite_optab for __builtin_isfinite

2024-04-11 Thread HAO CHEN GUI
Hi, This patch adds an optab for __builtin_isfinite. The finite check can be implemented on rs6000 by a single instruction. It needs an optab to be expanded to the certain sequence of instructions. The subsequent patches will implement the expand on rs6000. Bootstrapped and tested on x86

Re: [PATCH] rs6000: Add OPTION_MASK_POWER8 [PR101865]

2024-04-11 Thread Kewen.Lin
Hi, on 2024/4/12 06:15, Peter Bergner wrote: > FYI: This patch is an update to Will Schmidt's patches to fix PR101865: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601825.html > https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601823.html > > ...taking into

Re: [PATCH] rs6000: Add OPTION_MASK_POWER8 [PR101865]

2024-04-11 Thread Peter Bergner
On 4/11/24 10:31 PM, Kewen.Lin wrote: >> The passed bootstrap and regtest on powerpc64le-linux. Ok for trunk? > > Thanks for fixing this. I guess it should go well on powerpc64-linux too, > but since it's very late stage4 now, could you also test this on BE machine? Will do, after making the

Re: Combine patch ping

2024-04-11 Thread Richard Biener
On Wed, 10 Apr 2024, Uros Bizjak wrote: > On Wed, Apr 10, 2024 at 7:56 PM Segher Boessenkool > wrote: > > > > On Sun, Apr 07, 2024 at 08:31:38AM +0200, Uros Bizjak wrote: > > > If there are no further comments, I plan to commit the referred patch > > > to the mainline on Wednesday. The latest

Re: [PATCH v8 1/5] Provide counted_by attribute to flexible array member field (PR108896)

2024-04-11 Thread Martin Uecker
Am Mittwoch, dem 10.04.2024 um 19:35 + schrieb Qing Zhao: > > > On Apr 10, 2024, at 15:05, Martin Uecker wrote: > > > > Am Mittwoch, dem 10.04.2024 um 20:25 +0200 schrieb Martin Uecker: > > > Am Mittwoch, dem 10.04.2024 um 17:35 + schrieb Joseph Myers: > > > > On Fri, 29 Mar 2024, Qing

[PATCH] s390: testsuite: Fix loop-interchange-16.c

2024-04-11 Thread Stefan Schulze Frielinghaus
Revert parameter max-completely-peel-times to 16, otherwise, the innermost loop is removed and we are left with no loop interchange which this test is all about. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/loop-interchange-16.c: Revert parameter max-completely-peel-times for s390.

Re: [PATCH] s390: testsuite: Fix loop-interchange-16.c

2024-04-11 Thread Richard Biener
On Thu, Apr 11, 2024 at 9:02 AM Stefan Schulze Frielinghaus wrote: > > Revert parameter max-completely-peel-times to 16, otherwise, the > innermost loop is removed and we are left with no loop interchange which > this test is all about. > > gcc/testsuite/ChangeLog: > > *

[PATCH] testsuite: Fix loop-interchange-16.c

2024-04-11 Thread Stefan Schulze Frielinghaus
Yes, that works, too. Will commit. Thanks, Stefan -- Prevent loop unrolling of the innermost loop because otherwise we are left with no loop interchange for targets like s390 which have a more aggressive loop unrolling strategy. gcc/testsuite/ChangeLog: *

[PATCH] middle-end/114681 - condition coverage and inlining

2024-04-11 Thread Richard Biener
When inlining a gcond it can map to multiple stmts, esp. with non-call EH. The following makes sure to pick up the remapped condition when dealing with condition coverage. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR middle-end/114681 * tree-inline.cc

[PATCH] invoke.texi: Clarify -march=lujiazui

2024-04-11 Thread Jakub Jelinek
Hi! Yesterday I was searching which exact CPUs are affected by the PR114576 wrong-code issue and went from the PTA_* bitmasks in GCC, so arrived at the goldmont, goldmont-plus, tremont and lujiazui CPUs (as -march= cases which do enable -maes and don't enable -mavx). But when double-checking that

[PATCH] tree-optimization/109596 - wrong debug stmt move by copyheader

2024-04-11 Thread Richard Biener
The following fixes an omission in r14-162-gcda246f8b421ba causing wrong-debug and a bunch of guality regressions. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/109596 * tree-ssa-loop-ch.cc (ch_base::copy_headers): Propagate debug stmts

Re: [PATCH] wwwdocs: gcc-14: Add RISC-V changes

2024-04-11 Thread Kito Cheng
Committed with fixes, thanks :) On Thu, Apr 11, 2024 at 12:18 AM Palmer Dabbelt wrote: > On Wed, 10 Apr 2024 00:58:00 PDT (-0700), kito.ch...@sifive.com wrote: > > --- > > htdocs/gcc-14/changes.html | 155 - > > 1 file changed, 154 insertions(+), 1

  1   2   >