[PATCH] return edge in make_eh_edges

2023-10-19 Thread Alexandre Oliva
basic_block); extern bool operation_could_trap_helper_p (enum tree_code, bool, bool, bool, -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversit

Re: [RFC][debug] Add -fadd-debug-nops

2018-07-16 Thread Alexandre Oliva
This hides actual problems, that we'd like to fix eventually by adjusting the compiler, not the testcases. That said, thank you for the attention you've given to the guality testsuite recently. It's appreciated. -- Alexandre Oliva, freedom fighter https://FSFLA.org/blogs/lxo

[PATCH] Introduce instance discriminators

2018-07-17 Thread Alexandre Oliva
ug info. From: Alexandre Oliva , Olivier Hainque for gcc/testsuite/ChangeLog * gnat.dg/dinst.adb: New. * gnat.dg/dinst_pkg.ads, gnat.dg/dinst_pkg.adb: New. --- gcc/Makefile.in |1 + gcc/ada/gcc-interface/trans.c | 10 ++

Re: [PATCH] Introduce instance discriminators

2018-07-19 Thread Alexandre Oliva
On Jul 18, 2018, Richard Biener wrote: > On Wed, Jul 18, 2018 at 8:53 AM Alexandre Oliva wrote: >> Instance discriminators are not compatible with LTO, in that the >> instance mapping is not preserved in LTO dumps. There are no plans to >> preserve discriminators in them.

Re: [PATCH] Introduce instance discriminators

2018-07-24 Thread Alexandre Oliva
ed the instance or BB discriminator numbers that went into the non-LTO object files. Ok to install the first two patches? (the third is just for reference) Introduce instance discriminators From: Alexandre Oliva With -gnateS, the Ada compiler sets itself up to output discriminators for differen

Re: [RFC 1/3, debug] Add fdebug-nops

2018-07-24 Thread Alexandre Oliva
d those only at the very end if -g is not enabled. The downside is that it would likely slow -Og down significantly, but who uses it without -g anyway? -- Alexandre Oliva, freedom fighter https://FSFLA.org/blogs/lxo Be the change, be Free! FSF Latin America board member GNU Toolchain

Re: [RFC 2/3, debug] Add fkeep-vars-live

2018-07-24 Thread Alexandre Oliva
t optimized out in ranges between the end of a live range and a subsequent assignment. -- Alexandre Oliva, freedom fighter https://FSFLA.org/blogs/lxo Be the change, be Free! FSF Latin America board member GNU Toolchain EngineerFree Software Evangelist

Re: [PATCH][GCC][front-end][build-machinery][opt-framework] Allow setting of stack-clash via configure options. [Patch (4/6)]

2018-07-24 Thread Alexandre Oliva
other unit that might be reasonably assumed to express stack sizes. I'm afraid I don't know the best way to accomplish that in a few words. > +stk_clash_default=12 This seems to be left-over from an earlier patch, as it is now unused AFAICT. Thanks, -- Alexandre Oliva, freedom fig

Re: [PATCH][GCC][front-end][build-machinery][opt-framework] Allow setting of stack-clash via configure options. [Patch (4/6)]

2018-07-26 Thread Alexandre Oliva
assuming it's in a subsequent patch, I guess this one is fine, but I'm not sure I'm entitled to approve it. -- Alexandre Oliva, freedom fighter https://FSFLA.org/blogs/lxo Be the change, be Free! FSF Latin America board member GNU Toolchain EngineerFree Software Evangelist

Re: [RFC 2/3, debug] Add fkeep-vars-live

2018-07-26 Thread Alexandre Oliva
On Jul 25, 2018, Jakub Jelinek wrote: > On Tue, Jul 24, 2018 at 04:11:11PM -0300, Alexandre Oliva wrote: >> On Jul 24, 2018, Tom de Vries wrote: >> >> > This patch adds fake uses of user variables at the point where they go out >> > of >> > scope, to

Re: [RFC 1/3, debug] Add fdebug-nops

2018-07-26 Thread Alexandre Oliva
from emitting them if there aren't any binds between neighbor SFNs, but I like it better your way: it's even more like SFN support in the debugger :-) -- Alexandre Oliva, freedom fighter https://FSFLA.org/blogs/lxo Be the change, be Free! FSF Latin America board member GNU

Re: [PATCH] Introduce instance discriminators

2018-07-30 Thread Alexandre Oliva
On Jul 24, 2018, Alexandre Oliva wrote: > Ok to install the first two patches? (the third is just for reference) Ping? https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01419.html > Introduce instance discriminators > From: Alexandre Oliva > With -gnateS, the Ada compiler sets

[PATCH] testsuite: check for and use -mno-strict-align where needed

2023-10-19 Thread Alexandre Oliva
On Mar 10, 2021, Alexandre Oliva wrote: > ppc configurations that have -mstrict-align enabled by default fail > gcc.dg/strlenopt-80.c, because some memcpy calls don't get turned into > MEM_REFs, which defeats the tested-for strlen optimization. I've combined this patch with

Re: [PATCH] return edge in make_eh_edges

2023-10-19 Thread Alexandre Oliva
On Oct 19, 2023, Richard Biener wrote: > OK. Maybe time to do s/make_eh_edges/make_eh_edge/ though. Thanks, will do, ideally on top of the already-tested refreshed patches that I'm going to post shortly. -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/

Re: Enable top-level recursive 'autoreconf'

2023-10-19 Thread Alexandre Oliva
tes over the list (untested): dnl Handle a list of optional subdirs. dnl After AC_OUTPUT, affects autoreconf runs, but not configure runs. AC_DEFUN([AC_CONFIG_SUBDIRS_OPT], [ m4_foreach_w([dir], [$1], [ if test -d "$srcdir/dir"; then AC_CONFIG_SUBDIRS(dir) fi ]) ]) Thanks,

[PATCH v4] Introduce hardbool attribute for C

2023-10-19 Thread Alexandre Oliva
amp;v); +} + +void check_vtrue (hbool v) +{ + check_ptrue (&v); +} + +int main () { + check_pfalse (&var); + var = !(int)(hbool)(_Bool)var; + check_ptrue (&var); + var = (zbool)var; + check_ptrue (&var); + + check_ptrue (&x.a[0]); + check_pfalse (&x.a[1]); + check_vtrue (x.x); +

[PATCH] rename make_eh_edges to make_eh_edge (was: return edge in make_eh_edges)

2023-10-19 Thread Alexandre Oliva
@@ copy_edges_for_bb (basic_block bb, profile_count num, profile_count den, } else if (can_throw) { - make_eh_edges (copy_stmt); + make_eh_edge (copy_stmt); update_probs = true; } -- Alexandre Oliva, happy hackerhttps://F

Re: [PATCH v3] Control flow redundancy hardening

2023-10-20 Thread Alexandre Oliva
torture/harden-cfr-throw-nocleanup.C: New. * g++.dg/torture/harden-cfr-throw-returning.C: New. * g++.dg/torture/harden-cfr-throw.C: New. * gcc.dg/torture/harden-cfr-noret-no-nothrow.c: New. * gcc.dg/torture/harden-cfr-tail-ub.c: New. * gnat.dg/hardcfr.a

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-10-20 Thread Alexandre Oliva
no specific knowledge of darwin, but I expect darwin maintainers understand and approve of the bits that are going into build machinery files. Apologies for the delay. -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist G

Re: [PATCH RESEND] libatomic: drop redundant all-multi command

2023-10-20 Thread Alexandre Oliva
On Aug 1, 2023, Jan Beulich via Gcc-patches wrote: > * Makefile.am (all-multi): Drop commands. > * Makefile.in: Update accordingly. LGTM, thanks, -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Ac

Re: Remove stale Autoconf checks for Perl

2023-10-20 Thread Alexandre Oliva
On May 16, 2023, Thomas Schwinge wrote: > OK to push the attached "Remove stale Autoconf checks for Perl"? LGTM, thanks, -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer D

[PATCH] [PR111520] set hardcmp eh probs (was: rename make_eh_edges to make_eh_edge)

2023-10-21 Thread Alexandre Oliva
+ ~S (); +}; + +float f; + +void +foo () +{ + S a = 0; + S b = f; +} -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive

Re: [PATCH] Ignore case of header line in dg-extract-results.py

2023-10-25 Thread Alexandre Oliva
On Oct 24, 2023, Paul Iannetta wrote: > * dg-extract-results.py: Make the test_run regex case > insensitive. It looks reasonable to me, but I'm not sure this is a change I'm entitled to approve. Thanks! -- Alexandre Oliva, happy hackerhttps://FSF

Re: [PATCH v4] Introduce strub: machine-independent stack scrubbing

2023-10-25 Thread Alexandre Oliva
Ping? https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633675.html I'm combining the gcc/ipa-strub.cc bits from https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633526.html -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Act

Re: [PATCH] rename make_eh_edges to make_eh_edge

2023-10-25 Thread Alexandre Oliva
cfg.cc: ... here, ... * tree-inline.cc: ... and here. The ipa-strub.cc is now part of the strub patch. -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key f

hardcfr: support checking at abnormal edges [PR111943]

2023-10-26 Thread Alexandre Oliva
00644 --- a/gcc/gimple-harden-control-flow.cc +++ b/gcc/gimple-harden-control-flow.cc @@ -1,5 +1,5 @@ /* Control flow redundancy hardening. - Copyright (C) 2022 Free Software Foundation, Inc. + Copyright (C) 2022-2023 Free Software Foundation, Inc. Contributed by Alexandre Oliva . This fi

Re: hardcfr: support checking at abnormal edges [PR111943]

2023-10-31 Thread Alexandre Oliva
[adding list] On Oct 27, 2023, rep.dot@gmail.com wrote: > + from E and FALES from other preds, split the whole block, add a > s/FALES/FALSE/ Thanks, I've just installed the patch including the typo fix. -- Alexandre Oliva, happy hackerhttps://FSFLA.or

follow SSA defs for asan base

2021-01-21 Thread Alexandre Oliva
tions "-fsanitize=address" } */ + +int f(int i) { + auto int h() { +int r; +int *p; + +{ + int x[3]; + + auto int g() { + return x[i]; + } + + p = &r; + *p = g(); +} + +return *p; + } + + return h(); +} -- Alexandre Oliva,

skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
/dev/null +++ b/gcc/testsuite/gnat.dg/asan1_pkg.ads @@ -0,0 +1,9 @@ +package Asan1_Pkg is + subtype E is Integer; + type T is array (1..32) of E; + + function N return T; + function C (P : T) return E; + + V : constant E := C (N); +end Asan1_Pkg; -- Alexandre Oliva, happy hacker

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
les. Since this didn't happen, I figured the new condition would not be hit except for the failing case. But I was wrong. The bootstrap with the added assert has just failed, as early as stage2 libiberty. Looking into it... -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
On Jan 21, 2021, Alexandre Oliva wrote: > But I was wrong. The bootstrap with the added assert has just failed, > as early as stage2 libiberty. Looking into it... Uhh, I take that back. I just goofed in the assert, inverting the condition. Long day... With the correct condition, it

Re: skip asan-poisoning of discarded vars

2021-01-21 Thread Alexandre Oliva
On Jan 21, 2021, Alexandre Oliva wrote: > On Jan 21, 2021, Alexandre Oliva wrote: >> But I was wrong. The bootstrap with the added assert has just failed, >> as early as stage2 libiberty. Looking into it... > Uhh, I take that back. I just goofed in the assert, inverti

Re: follow SSA defs for asan base

2021-01-26 Thread Alexandre Oliva
nd one of my changes introduced a tab that misaligned stuff. Tabify, untabify, or leave it inconsistent as in the tested patch below? regard the address of auto vars and consts as invariant From: Alexandre Oliva Ada makes extensive use of nested functions, which turn all automatic variables of the e

Re: follow SSA defs for asan base

2021-01-27 Thread Alexandre Oliva
r. I've regstrapped it on x86_64-linux-gnu, and also bootstrapped it with asan and ubsan. Ok to install? restore current_function_decl after re-gimplifying nested ADDR_EXPRs From: Alexandre Oliva Ada makes extensive use of nested functions, which turn all automatic variables of the encl

[RFC] test builtin ratio for loop distribution

2021-01-27 Thread Alexandre Oliva
if (maybe_normalize_partition (loop, partition)) + any_changes_p = true; +if (any_changes_p) + finalize_partitions (loop, &partitions, &alias_ddrs); + } /* If there is a reduction in all partitions make sure the last one is not classified for builtin code gener

[RFC] mask out mult expr ctz bits from nonzero bits

2021-01-27 Thread Alexandre Oliva
cision) << bits; + ret &= mask; +} - return ri->get_nonzero_bits (); + return ret; } /* Return TRUE is OP, an SSA_NAME has a range of values [0..1], false -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: [RFC] test builtin ratio for loop distribution

2021-01-27 Thread Alexandre Oliva
not that it's either 4, 8 or 12. Coming up with an efficient inline expansion becomes a bit of a challenge without that extra knowledge. (*) at least before my related patch for get_nonzero_bits https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564344.html -- Alexandre Oliva, happy hacker

Re: [RFC] test builtin ratio for loop distribution

2021-02-02 Thread Alexandre Oliva
s mainly to check that I understood what you had in mind before I spend further time polishing it. test builtin ratio for loop distribution From: Alexandre Oliva The ldist pass turns even very short loops into memset calls. E.g., the TFmode emulation calls end with a loop of up to 3 iterations,

Re: [RFC] test builtin ratio for loop distribution

2021-02-03 Thread Alexandre Oliva
is broken, the regstrap test did not even build libstdc++-v3 successfully. I'm not sure whether to pursue it further, or to reimplement it in the expander. Suggestions are welcome. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: [RFC] test builtin ratio for loop distribution

2021-02-04 Thread Alexandre Oliva
ue. It can be recovered without much difficulty in the cases I've looked at, but it could be lost in others. > So I'd say go for improving RTL expansion. 'k, thanks -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: use -mfpu=auto for arm/simd/vmmla_1.c (was: use -mfpu=neon for arm/simd/vmmla_1.c)

2021-02-05 Thread Alexandre Oliva
On Jan 13, 2021, Alexandre Oliva wrote: > On Jan 5, 2021, Alexandre Oliva wrote: >> So this patch adds -mfpu=auto to the test, overriding any implicit >> flags with the fpu implied by the arch. >> * gcc.target/arm/simd/vmmla_1.c: Pass -mfpu=auto. > Ping? > https:

Re: use -mfpu=neon for arm/simd/vmmla_1.c

2021-02-10 Thread Alexandre Oliva
On Feb 9, 2021, Kyrylo Tkachov wrote: > Ok. Aren't there more tests that have this problem? Thanks. This was the only test that exhibited this problem. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer

Re: [RFC] test builtin ratio for loop distribution

2021-02-11 Thread Alexandre Oliva
On Feb 4, 2021, Jim Wilson wrote: > FYI we have a bug report for this for a coremark regression which sounds > like the same problem. > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94092 Indeed, thanks! -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free

Re: [RFC] test builtin ratio for loop distribution

2021-02-11 Thread Alexandre Oliva
On Feb 4, 2021, Alexandre Oliva wrote: > On Feb 4, 2021, Richard Biener wrote: >>> > b) if expansion would use BY_PIECES then expand to an unrolled loop >>> >>> Why would that be better than keeping the constant-length memset call, >>> that wo

Re: [RFC] test builtin ratio for loop distribution

2021-02-11 Thread Alexandre Oliva
On Feb 11, 2021, Alexandre Oliva wrote: > How does this look? > for gcc/ChangeLog > PR tree-optimization/94092 > * builtins.c (try_store_by_multiple_pieces): New. > (expand_builtin_memset_args): Use it. If target_char_cast > fails, proceed as fo

Re: [RFC] test builtin ratio for loop distribution

2021-02-15 Thread Alexandre Oliva
CP also performs copy propagation an obvious candidate would be > to replace the last pass_copy_prop with pass_ccp (with a comment noting > to compute up-to-date nonzero bits info). I'll look into these possibilities. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: [RFC] test builtin ratio for loop distribution

2021-02-16 Thread Alexandre Oliva
On Feb 16, 2021, Alexandre Oliva wrote: >> So I wonder whether we should instead re-run CCP after loop opts which >> computes nonzero bits as well instead of the above "hack". That works. It takes care of both the dest alignment and the len ctz. Explicitly masking out t

[PR94092] Re: [RFC] test builtin ratio for loop distribution

2021-02-19 Thread Alexandre Oliva
+Clean them up. Instead of just copy_prop, we use ccp to +compute alignment and nonzero bits. */ + NEXT_PASS (pass_ccp, true /* nonzero_p */); NEXT_PASS (pass_warn_restrict); NEXT_PASS (pass_dse); NEXT_PASS (pass_cd_dce, true /* update_address_taken_p */); -- Al

add rv64im{,c,fc} multilibs

2021-02-23 Thread Alexandre Oliva
\ march=rv64imafdc/mabi=lp64d MULTILIB_REUSE = march.rv32i/mabi.ilp32=march.rv32ic/mabi.ilp32 \ -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: add rv64im{,c,fc} multilibs

2021-02-23 Thread Alexandre Oliva
ctation that the defaults are to remain unchanged for now, and I will thus proceed under this assumption. Thanks for the prompt response! -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: add rv64im{,c,fc} multilibs

2021-02-24 Thread Alexandre Oliva
offering the patch just in case, that's all. > People that want a different set can define their own, and we have > made it easy for people to define their own sets of multilibs as Kito > pointed out. *nod*, thanks, -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/

[FYI] Add missing dg-require-effective-target fpic directives to powerpc tests

2021-02-26 Thread Alexandre Oliva
1,6 +1,7 @@ /* { dg-do compile } */ /* { dg-require-effective-target fpic } */ /* { dg-options "-mdejagnu-cpu=power8 -O3 -fstack-protector-strong -fpic" } */ +/* { dg-require-effective-target fpic } */ char *b; int c, d, e, f; -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: [FYI] Add missing dg-require-effective-target fpic directives to powerpc tests

2021-02-26 Thread Alexandre Oliva
*/ /* { dg-options "-mdejagnu-cpu=power8 -O3 -fstack-protector-strong -fpic" } */ -/* { dg-require-effective-target fpic } */ char *b; int c, d, e, f; -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

add -mpowerpc-gpopt to options for sqrt insn on PowerPC

2021-02-26 Thread Alexandre Oliva
} return $flags } -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

add powerpc_vsx_ok requirement to undef-bool tests

2021-02-26 Thread Alexandre Oliva
we require strict ANSI. Subsequent use of bool needs stdbool.h. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: add -mpowerpc-gpopt to options for sqrt insn on PowerPC

2021-03-02 Thread Alexandre Oliva
On Feb 26, 2021, Segher Boessenkool wrote: > On Fri, Feb 26, 2021 at 12:31:16PM -0500, David Edelsohn wrote: >> On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva wrote: >> > >> > This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2 >> > tests.

Re: [PATCH] gcc.misc-tests/outputs.exp: assert unique test-names

2021-03-03 Thread Alexandre Oliva
at each running test has a unique > name. LGTM, thanks! -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: [PATCH] outputs.exp: skip @file -save-temps if target has -L or -I

2021-03-03 Thread Alexandre Oliva
o ISTM that would be a pointless effort. So we're good. Thanks! -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: add -mpowerpc-gpopt to options for sqrt insn on PowerPC

2021-03-03 Thread Alexandre Oliva
eature-option-adding call is always followed by a feature-available-check call. Thanks, -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: add -mpowerpc-gpopt to options for sqrt insn on PowerPC

2021-03-03 Thread Alexandre Oliva
On Mar 2, 2021, Segher Boessenkool wrote: > This is PR99352 now. Thanks. I've filed PR99371 for the add_options_for_sqrt_insn incompleteness, and PR99372 for the gimplefe-28.c ICE. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU T

Re: add -mpowerpc-gpopt to options for sqrt insn on PowerPC

2021-03-03 Thread Alexandre Oliva
On Mar 3, 2021, Segher Boessenkool wrote: > On Wed, Mar 03, 2021 at 04:45:23PM -0300, Alexandre Oliva wrote: >> On Mar 2, 2021, Segher Boessenkool wrote: >> >> > This is PR99352 now. >> >> Thanks. I've filed PR99371 for the add_options_for_sqrt_in

Re: add powerpc_vsx_ok requirement to undef-bool tests

2021-03-08 Thread Alexandre Oliva
>> * g++.dg/ext/undef-bool-1.C: Add dg-require-effective-target >> powerpc_vsx_ok directive. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Re: retain debug stmt order when moving to successors

2021-08-17 Thread Alexandre Oliva
On Jul 28, 2021, Richard Biener wrote: > OK. Thanks, I've finally put this in. Sorry about the delay. > On Wed, Jul 28, 2021 at 10:12 AM Alexandre Oliva wrote: >> * tree-inline.c (maybe_move_debug_stmts_to_successors): Don't >> reverse debug stmts. -- A

Re: don't access cfun in dump_function_to_file

2021-08-17 Thread Alexandre Oliva
On Jul 28, 2021, Richard Biener wrote: > OK. Thanks, I've finally put this in as well. >> * tree-cfg.c (dump_function_to_file): Use fun, not cfun. -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist

Re: move unreachable user labels to entry point

2021-08-17 Thread Alexandre Oliva
revious block, if it satisfies the requirement. I found it made the logic simpler, slightly more efficient, and more predictable, but I'm not attached to the change. Since Jakub objected to it, let's leave it alone. -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blog

Re: ipa-modref: merge flags when adding escape

2021-08-17 Thread Alexandre Oliva
On Aug 11, 2021, Jan Hubicka wrote: > This is improved patch Thanks for the proper fix! -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care dee

fix latent bootstrap-debug issue (modref, tree-inline, tree jump-threading)

2021-08-20 Thread Alexandre Oliva
/* For buitins that are likely expanded to nothing or inlined do not account operand costs. */ -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because m

Re: fix latent bootstrap-debug issue (modref, tree-inline, tree jump-threading)

2021-08-27 Thread Alexandre Oliva
&& (!summary_lto || !summary_lto->useful_p (ecf_flags, false which means that, if the first stmt of a block doesn't add useful information to the summary, we give up. Was this really the intent? -- Alexandre Oliva, happy hackerhttps://FSFL

Re: [PATCH 2/4, revised patch applied] PowerPC: Rename functions for min, max, cmove

2020-09-15 Thread Alexandre Oliva
I'm testing this patch. I'll check it in when I'm done. use E_*mode instead of just *mode From: Alexandre Oliva g++ 4.8.5 rejected cases with SFmode and DFmode, presumably due to some bug in the constexpr implementation. for gcc/ChangeLog * config/rs6000/rs6000.c (

[PATCH] assorted improvements for fold_truth_andor_1

2020-09-25 Thread Alexandre Oliva
This patch introduces various improvements to the logic that merges field compares. Before the patch, we could merge: (a.x1 EQNE b.x1) ANDOR (a.y1 EQNE b.y1) into something like: (((type *)&a)[Na] & MASK) EQNE (((type *)&b)[Nb] & MASK) if both of A's fields live within the same alignme

Re: [PATCH] assorted improvements for fold_truth_andor_1

2020-09-29 Thread Alexandre Oliva
On Sep 28, 2020, Richard Biener wrote: > On Fri, Sep 25, 2020 at 3:39 PM Alexandre Oliva wrote: >> This patch introduces various improvements to the logic that merges >> field compares. > Sorry for throwing a wrench in here but doing this kind of transform > duri

Re: [PATCH] assorted improvements for fold_truth_andor_1

2020-09-29 Thread Alexandre Oliva
On Sep 29, 2020, Richard Biener wrote: > On Tue, Sep 29, 2020 at 9:23 AM Alexandre Oliva wrote: >> On Sep 28, 2020, Richard Biener wrote: > ifcombine should stop using fold*, yeah Wow, that's quite a lot of work for no expected improvement in codegen. I don't expect

Re: [PATCH] assorted improvements for fold_truth_andor_1

2020-09-29 Thread Alexandre Oliva
On Sep 29, 2020, Alexandre Oliva wrote: > Yeah, ifcombine's bb_no_side_effects_p gives up on any gimple_vuse in > the inner block. that won't do when the whole point is to merge loads > from memory. > That seems excessive. Since we rule out any memory-changing side &

Re: [PATCH] assorted improvements for fold_truth_andor_1

2020-10-02 Thread Alexandre Oliva
Here's what I got so far, passing regstrap except for field-merge-1.c, that relies on combining non-adjacent compares, which I haven't implemented yet. I had to retain some parts of fold_truth_andor_1 to avoid regressions in gcc.c-torture/execute/ieee/compare-fp-3.c and gcc.dg/pr81228.c. gcc.targe

make sincos take type from intrinsic formal, not from result assignment

2020-10-05 Thread Alexandre Oliva
N_CEXPI); if (!fndecl) return false; stmt = gimple_build_call (fndecl, 1, name); -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer

Re: make sincos take type from intrinsic formal, not from result assignment

2020-10-06 Thread Alexandre Oliva
On Oct 6, 2020, Richard Biener wrote: > On October 6, 2020 3:15:02 AM GMT+02:00, Alexandre Oliva > wrote: >> >> This is a first step towards enabling the sincos optimization in Ada. >> >> The issue this patch solves is that sincos takes the type to be looked &

Re: make sincos take type from intrinsic formal, not from result assignment

2020-10-06 Thread Alexandre Oliva
s (assuming long double and double have the same precision), and then sincos will get it right. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer

Re: make sincos take type from intrinsic formal, not from result assignment

2020-10-07 Thread Alexandre Oliva
rinsic in sincos pass From: Alexandre Oliva This is a first step towards enabling the sincos optimization in Ada. The issue this patch solves is that sincos takes the type to be looked up with mathfn_built_in from variables or temporaries passed as arguments to SIN and COS intrinsics. In Ada,

Re: make sincos take type from intrinsic formal, not from result assignment

2020-10-08 Thread Alexandre Oliva
ate GIMPLE predicate here. Thanks, fixed, regstrapped. Here's what I'm installing. take type from intrinsic in sincos pass From: Alexandre Oliva This is a first step towards enabling the sincos optimization in Ada. The issue this patch solves is that sincos takes the type to be looked up

import elementary functions as intrinsics

2020-10-11 Thread Alexandre Oliva
quot;asin"); + pragma Import (Intrinsic, Asin, "asin"); pragma Pure_Function (Asin); function Atan (X : Double) return Double; - pragma Import (C, Atan, "atan"); + pragma Import (Intrinsic, Atan, "atan"); pragma Pure_Function (Atan); function Sinh (X : Double) return Double; - pragma Import (C, Sinh, "sinh"); + pragma Import (Intrinsic, Sinh, "sinh"); pragma Pure_Function (Sinh); function Cosh (X : Double) return Double; - pragma Import (C, Cosh, "cosh"); + pragma Import (Intrinsic, Cosh, "cosh"); pragma Pure_Function (Cosh); function Tanh (X : Double) return Double; - pragma Import (C, Tanh, "tanh"); + pragma Import (Intrinsic, Tanh, "tanh"); pragma Pure_Function (Tanh); function Pow (X, Y : Double) return Double; - pragma Import (C, Pow, "pow"); + pragma Import (Intrinsic, Pow, "pow"); pragma Pure_Function (Pow); end Ada.Numerics.Aux; -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer

[FYI] fix cgraph comment

2019-10-25 Thread Alexandre Oliva
raph_local_info *local_info (tree decl); - /* Return local info for the compiled function. */ + /* Return RTL info for the compiled function. */ static struct cgraph_rtl_info *rtl_info (const_tree); /* Return the cgraph node that has ASMNAME for its DECL_ASSEMBLER_NAME. -- Alexandre Oliva, freed

introduce -fcallgraph-info option

2019-10-25 Thread Alexandre Oliva
the file format, because existing tools such as gnatstack consume the current format. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog >From Eric Botcazou , Alexandre Oliva > * common.opt (-fcallgraph-info[=]): New option. * doc/invoke.texi (Deb

Re: introduce -fcallgraph-info option

2019-10-26 Thread Alexandre Oliva
ge: { sourcename: "add" targetname: "__addvsi3" } those between user symbols carry location info as well: edge: { sourcename: "p__s" targetname: "p.adb:p__v" label: "p.adb:46:5" } So I'm afraid I don't see anything that could be usefully

Re: introduce -fcallgraph-info option

2019-10-27 Thread Alexandre Oliva
On Oct 26, 2019, Alexandre Oliva wrote: > E.g., the reason we gather expanded calls rather than just use > cgraph_edges is that the latter would dump several "calls" that are > builtins expanded internally by the compiler, and would NOT dump other > ops that are expan

Re: introduce -fcallgraph-info option

2019-10-30 Thread Alexandre Oliva
fixed the common.opt changes, and I'll submit momentarily a patch for help.exp to extend it to cover --help=common output as well. -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo Be the change, be Free!FSF VP & FSF Latin America board member GNU Toolcha

Re: introduce -fcallgraph-info option

2019-10-30 Thread Alexandre Oliva
"optimizers" "param" "target" "warnings" } { - + "common" "optimizers" "param" "target" "warnings" } { check_for_options c "--help=$cls" "" "^ +-.*\[^:.\]$" "

Re: introduce -fcallgraph-info option

2019-10-30 Thread Alexandre Oliva
tstack, that's a tool to compute max stack depth and perform other call graph analyzes. I don't think of it as a debugging tool. https://www.adacore.com/gnatpro/toolsuite/gnatstack http://docs.adacore.com/live/wave/gnatstack/html/gnatstack_ug/index.html -- Alexandre Oliva, freedom

Re: introduce -fcallgraph-info option

2019-11-02 Thread Alexandre Oliva
info and -fcallgraph-info=da dynamic allocation info. for gcc/ChangeLog >From Eric Botcazou , Alexandre Oliva > * common.opt (-fcallgraph-info[=]): New option. * doc/invoke.texi (Developer options): Document it. * opts.c (common_handle_option): Handle it.

[FYI] pass --enable-obsolete to build configure

2019-11-02 Thread Alexandre Oliva
;} \ + ${enable_option_checking+--enable-option-checking="$enable_option_checking"} \ + --target=$target_alias --host=$build_alias \ + --build=$build_alias || exit # retaining $tempdir # We just finished tests for the build machine, so r

Re: [FYI] pass --enable-obsolete to build configure

2019-11-04 Thread Alexandre Oliva
"} \ + --target=$target_alias --host=$build_alias \ + --build=$build_alias || exit # retaining $tempdir # We just finished tests for the build machine, so rename # the file auto-build.h in the gcc directory. @@ -1868,8 +1872,10 @@ else cd ..

Re: introduce -fcallgraph-info option

2019-11-06 Thread Alexandre Oliva
at the Tree level and RTL doesn't usually fiddle with calls, it's final in almost all cases. Moreover, the nodes can be decorated with additional info: -fcallgraph-info=su adds stack usage info and -fcallgraph-info=da dynamic allocation info. for gcc/ChangeLog >From Eric Botc

Re: introduce -fcallgraph-info option

2019-11-06 Thread Alexandre Oliva
-fltrans to implicitly adjust aux_base_name with the directory passed to -dumpdir, if any, or . otherwise Any preferences? -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo Free Software Evangelist Stallman was right, but he's left :( GNU Toolchain Engineer

Re: introduce -fcallgraph-info option

2019-11-07 Thread Alexandre Oliva
convention. -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo Free Software Evangelist Stallman was right, but he's left :( GNU Toolchain EngineerFSMatrix: It was he who freed the first of us FSF & FSFLA board memberThe Savior shall return (true);

Re: introduce -fcallgraph-info option

2019-11-07 Thread Alexandre Oliva
think that objection doesn't apply. As a Free Software activist, however, I am a little concerned about the claim about obfuscated source code. I haven't been able to find any substantiation of that in your message. I think that would be OT for this list, so would you please send m

Re: introduce -fcallgraph-info option

2019-11-07 Thread Alexandre Oliva
dumpbase for -fltrans compilations. The other alternatives amounted to exposing auxdir or auxbase in the driver interface, so that lto-wrapper could specify them explicitly. -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo Free Software Evangelist Stallman was right

Re: introduce -fcallgraph-info option

2019-11-07 Thread Alexandre Oliva
-fdump-rtl-expand -> /tmp/temp().ltrans0.ltrans.o a.out.ltrans0.su + a.out.ltrans0.#r.expand + a.out I'm a little hesitant, this amounts to quite significant behavior changes. Do these seem acceptable and desirable nevertheless? -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blog

introduce overridable clear_cache emitter

2020-11-10 Thread Alexandre Oliva
xWorks specific entry point. LIB2FUNCS_EXCLUDE += _clear_cache -LIB2ADD += $(srcdir)/config/vxcache.c # This ensures that the correct target headers are used; some VxWorks # system headers have names that collide with GCC's internal (host) diff --git a/libgcc/config/vxcache.c b/libg

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-01-09 Thread Alexandre Oliva
5e29c44643 currently in aoliva/testme in the git repo is the latest I tested; I pushed other minor cleanups over that one, but other changes I might make and push later today might be more disruptive in terms of test results. -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo F

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-01-16 Thread Alexandre Oliva
On Jan 16, 2020, Alexandre Oliva wrote: > On Jan 9, 2020, Alexandre Oliva wrote: >> On Jan 9, 2020, Richard Biener wrote: >>> Did I miss the actual (non-documentation) patch? >> No, I didn't post it. It's kind of big, and only yesterday did I get

tolerate padding in mbstate_t

2020-01-21 Thread Alexandre Oliva
p;state[0], &state[1], sizeof(state_type)) == 0 ); } int main() -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo Free Software Evangelist Stallman was right, but he's left :( GNU Toolchain EngineerFSMatrix: It was he who freed the first of us

  1   2   3   4   5   6   7   8   9   10   >