libgo patch committed: add benchmark input files

2014-06-24 Thread Ian Lance Taylor
This patch from Peter Collingbourne adds some benchmark input files that were missing from the gofrontend repository. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. The patch adds binary files. The size of the patch is too large to attach, and the files

libgo patch committed: Build targets for benchmarks

2014-07-01 Thread Ian Lance Taylor
This patch from Peter Collingbourne makes it easier to run the libgo benchmarks using make bench in the libgo build directory. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 7650eafca8af libgo/Makefile.am --- a/libgo/Makefile.am Tue Jun 24

libgo patch committed: Don't explicitly free tiny blocks

2014-07-02 Thread Ian Lance Taylor
This patch fixes libgo to not explicitly free tiny blocks when deleting an entry from a map. The memory allocator now has a special case for tiny objects (less than 16 bytes), and they can not be explicitly freed, only garbage collected. This is PR go/61620. Bootstrapped and ran Go testsuite on

Re: [PATCH, libbacktrace]: fix pointer from integer without a cast

2014-07-05 Thread Ian Lance Taylor
On Thu, Jul 3, 2014 at 2:34 AM, Duncan Mac-Vicar P. dmacvi...@suse.de wrote: the following patch fixes some post-build-checks from our distro build system, better to upstream it: [ 4077s] E: rust 64bit-portability-issue

Go patch committed: Fix C-style comment parsing

2014-07-08 Thread Ian Lance Taylor
PR 61746 and gofrontend issue 35 point out a bug in C-style comment parsing in the Go frontend. The sequence /*/ was interpreted as a complete C-style comment. This patch fixes the bug. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Ian

Go patch commtited: Convert array start index before bounds check

2014-07-08 Thread Ian Lance Taylor
This patch from Chris Manghane fixes an ICE-on-invalid in the gccgo frontend, reported as PR 61308. The fix is to convert an array start index to int before doing a bounds check on the type. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r

libgo patch committed: Drop reflectFlags

2014-07-10 Thread Ian Lance Taylor
The Go library reflect package used to have a notion of reflectFlags that were used to indicate an invalid interface value. That has not been used for a while. This patch drops testing for it from the libgo runtime. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to

libgo patch committed: Rename iface.goc to go-iface.goc

2014-07-10 Thread Ian Lance Taylor
A new version of the master Go library has a new file runtime/iface.goc. It is not the same as the existing libgo file runtime/iface.goc. This patch renames the libgo file to go-iface.goc to avoid any future confusion. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to

libgo patch committed: Update to revision 19185

2014-07-11 Thread Ian Lance Taylor
This patch to libgo merges in master revision 19185. This revision renamed and edited several files in the runtime directory. The files were changed from .c to .goc; .goc is a file that uses Go function declaration syntax with C function bodies. It's a convenient way to write Go-callable

Go patch committed: Check for mismatch between results and uses

2014-07-18 Thread Ian Lance Taylor
The Go frontend had a bug in that it would not give an error for a, b := F() when F returned more than two results. This patch fixes the bug. I've proposed a test case for the master testsuite in http://codereview.appspot.com/111360045 . Bootstrapped and ran Go testsuite on

libgo patch committed: Update version number

2014-07-19 Thread Ian Lance Taylor
I committed this patch to update the libgo version number, to go with the earlier update of libgo to Go 1.3. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r d2e722ccd25b libgo/configure.ac --- a/libgo/configure.ac Sat Jul 19 01:26:37 2014 -0700

libgo patch committed: Use libffi closures

2014-07-19 Thread Ian Lance Taylor
This patch finally adds support to libgo to use libffi closures to implement reflect.MakeFunc. This should let reflect.MakeFunc work for any processor, or, at least, any processor that supports libffi closures. On x86 and x86_64 the code will continue to use the special purpose code I wrote

Recreate gccgo branch from trunk

2014-07-19 Thread Ian Lance Taylor
I deleted the gccgo branch, which had been tracking gcc-4_9-branch, and recreate it by doing a cp from trunk revision 212853. Ian

libgo patch committed: Mark varargs function no_split_stack for Clang

2014-07-20 Thread Ian Lance Taylor
This patch from Peter Collingbourne marks the varargs function runtime_sprintf as no_split_stack when using Clang. Apparently Clang does not support split-stack for varargs function. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r ca381cdd378c

libgo patch committed: Add missing import

2014-07-20 Thread Ian Lance Taylor
This patch from Peter Collingbourne adds a missing import to a libgo test. The Go frontend should have detected this error. The patch for that is forthcoming (http://codereview.appspot.com/116960043) and I am adding a test case to the testsuite (http://codereview.appspot.com/11843).

Go patch committed: Don't merge dot-import names

2014-07-20 Thread Ian Lance Taylor
This patch to the Go frontend fixes it so that a name included because of a dot import (import . package) is not merged with the same name defined in an earlier file. Without this patch, the Go compiler would incorrectly accept code that used a name defined by a dot import in a later file. I've

Go testsuite patch committed: compiledir fix

2014-07-20 Thread Ian Lance Taylor
This patch to the Go testsuite driver adds support for having multiple files in a single package for a compiledir test. Ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-07-20 Ian Lance Taylor i...@google.com * go.test/go-test.exp (go-gc-tests): Support

libgo patch committed: Remove unused variable

2014-07-20 Thread Ian Lance Taylor
This patch from Peter Collingbourne removes an unused variable from libgo. The variable is set but never used, and gccgo was not giving an error about such cases. I will shortly commit a gccgo patch to detect this case. This patch bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.

Go patch committed: Error for vars that are set but not used

2014-07-20 Thread Ian Lance Taylor
This patch improves the Go frontend to give an error for any variables that are set but not used. This matches the behaviour of the gc Go compiler. This Go language spec does not require this, but it is permitted as an implementation restriction, and it seems like a good idea to make the

Re: [PATCH, go]: Restore bootstrap

2014-07-24 Thread Ian Lance Taylor
On Thu, Jul 24, 2014 at 12:21 PM, Martin Liška mli...@suse.cz wrote: On 07/24/2014 07:57 PM, Uros Bizjak wrote: Hello! 2014-07-24 Uros Bizjak ubiz...@gmail.com * go/go-gcc.cc (Gcc_backend::global_variable_set_init): Rename symtab_get_node to symtab_node::get. Tested on

libgo patch committed: Use ppc64le for little-endian 64-bit PowerPC architecture

2014-11-21 Thread Ian Lance Taylor
This patch by Lynn A. Boger changes libgo to use ppc64le for little-endian 64-bit PowerPC. Bootstrapped and ran testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 96de84075614 libgo/configure.ac --- a/libgo/configure.acTue Nov 18 09:28:24 2014 -0800 +++

Re: [PATCH] Set goarch to ppc64le where needed for gccgo testing

2014-11-21 Thread Ian Lance Taylor
On Wed, Nov 19, 2014 at 12:55 PM, Lynn A. Boger labo...@linux.vnet.ibm.com wrote: Updated patch: Thanks. Committed. Ian On 11/19/2014 09:01 AM, Lynn A. Boger wrote: Hi, This change goes along with the change to the GOARCH setting in gccgo for ppc64le which will be done in gofrontend.

Re: [PATCH] Check for strtol, strtoul, strtoll and strtoull declarations

2014-11-22 Thread Ian Lance Taylor
Jakub Jelinek ja...@redhat.com writes: On Sat, Nov 22, 2014 at 09:40:58AM -0500, John David Anglin wrote: libiberty ChangeLog: 2014-11-22 John David Anglin dang...@gcc.gnu.org PR other/63694 * configure.ac: Check for strtol, strtoul, strtoll and strtoull declarations.

Go patch committed: Don't deref named pointer type for method

2014-11-24 Thread Ian Lance Taylor
This patch by Chris Manghane fixes the Go compiler to not dereference a named pointer type when looking up a method. Before this patch that could happen if the pointer type pointed to a struct with an inherited method. This is http://golang.org/issue/9018. Bootstrapped and ran testsuite on

libgo patch committed: Use -Qunused-arguments with asm tests

2014-09-29 Thread Ian Lance Taylor
This patch to the libgo configure script changes it to use -Qunused-arguments when running the assembler tests. Apparently clang by default complains when arguments to the driver are unused, as in -I arguments when invoked on a .s file. Passing -Qunused-arguments disables these warnings, and

libffi patch RFA: Pass -Qunused-arguments for asm files

2014-09-29 Thread Ian Lance Taylor
arguments, such as -I options when compiling a .s file. This somewhat annoying behaviour works poorly with configure scripts. The -Qunused-arguments option disables it. Bootstrapped and ran libffi and libgo tests on x86_64-unknown-linux-gnu. OK for mainline? Ian 2014-09-29 Ian Lance Taylor i

Re: [libgo, arm64] Future of reflection

2014-10-01 Thread Ian Lance Taylor
On Wed, Oct 1, 2014 at 2:14 PM, Richard Henderson r...@redhat.com wrote: I've been looking at reflection, and support for non-x86 targets. In mainline, there's some support for using libffi, but I wasn't completely confident that things are working correctly. It doesn't help that the

Go patch committed: Fix symbol name adjustments to match go tool

2014-10-02 Thread Ian Lance Taylor
In the go tool, when converting the pkgpath argument to use for a symbol name, everything except alphanumeric characters is converted to an underscore character. This is PR 61880. This patch from Alexander Shopov changes the Go frontend to match, so that the symbol names generated by the cgo

Re: Go patch committed: Fix symbol name adjustments to match go tool

2014-10-02 Thread Ian Lance Taylor
On Thu, Oct 2, 2014 at 10:56 AM, Ian Lance Taylor i...@google.com wrote: In the go tool, when converting the pkgpath argument to use for a symbol name, everything except alphanumeric characters is converted to an underscore character. This is PR 61880. This patch from Alexander Shopov

libgo patch committed: Check CPU_COUNT, not glibc version

2014-10-02 Thread Ian Lance Taylor
This patch to libgo, based on one from Bryan Hundven, fixes libgo's use of CPU_COUNT to check whether CPU_COUNT is defined, rather than checking the glibc version. This works with other libraries, like uclibc. This is issue 38 in the gofrontend issue tracker. Bootstrapped and ran Go testsuite

Go patch committed: Don't confuse fields and promoted methods

2014-10-03 Thread Ian Lance Taylor
This patch from Tim Shen fixes a bug in the Go frontend in which a promoted method could be used even if there was a field of the same name. This fixes http://golang.org/issue/4365 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r c9d064a071c9

libgo patch committed: Fix reflection of variadic methods

2014-10-03 Thread Ian Lance Taylor
This patch from Michael Hudson-Doyle fixes PR 61877 which is about using reflection to get a variadic method value. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 9a2ca32c libgo/go/reflect/all_test.go --- a/libgo/go/reflect/all_test.go Fri

Re: [gofrontend-dev] [PATCH 3/9] Gccgo port to s390[x] -- part I

2014-10-03 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:51 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: The current Gccgo cannot handle 64 bit symbol tables on s390[x]. The attached patch fixes that. gcc/go/ChangeLog 2014-09-05 Dominik Vogt v...@linux.vnet.ibm.com * gofrontend/import-archive.cc

Re: [gofrontend-dev] [PATCH 4/9] Gccgo port to s390[x] -- part I

2014-10-03 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:53 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: This patch fixes the compiler flags in libgo/mksysinfo.sh. In one place, some compiler flags were missing that are consistently used elswhere, resulting in an error message. ChangeLog 2014-09-05 Dominik Vogt

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-03 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:56 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: This optional cleanup patch fixes some sloppy programming in the x86 libgo/go/debug/elf library that had given me a very hard time to debug and fix when porting the code to s390[x]. See commit comment for details.

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-06 Thread Ian Lance Taylor
On Mon, Oct 6, 2014 at 12:42 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: On s390[x] the symbol value of a section symbol is definitely not zero. Is true even in an object file? I agree that in an executable a section symbol will have a non-zero value, but that case doesn't arise since an

libgo patch committed: Fix recover.go test for large args, FFI

2014-10-08 Thread Ian Lance Taylor
This patch to libgo fixes PR 60406, in which a problem arises when passing a large argument to a deferred function. The current code generates a thunk that looks like this: if (__go_set_defer_retaddr (L)) goto L; deferred_function(args); L: Then the deferred_function calls

Re: [gofrontend-dev] [PATCH 2/9] Gccgo port to s390[x] -- part I

2014-10-09 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:49 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: A test case added to golang for the previous patch. gcc/testsuite/ChangeLog 2014-09-05 Dominik Vogt v...@linux.vnet.ibm.com * go.test/test/recover.go (test1): Test recover() from deferred recursive

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-09 Thread Ian Lance Taylor
On Tue, Oct 7, 2014 at 3:45 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: The only points in that patch are that on one hand - as far as I know - the Abi does not guarantee that section symbols are either zero or not relocated, even if that may be the case in reality. And on the other hand,

Merge from trunk to gccgo branch

2014-10-09 Thread Ian Lance Taylor
I merged trunk revision 216040 to the gccgo branch. Ian

Go patch committed: Accept for range v

2014-10-09 Thread Ian Lance Taylor
The Go language was tweaked slightly to permit the variable to be omitted in a range clause, so that one can write for range v instead of having to write for _ = range v. This patch from Chris Manghane implements this in gccgo. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.

Re: libffi patch RFA: Pass -Qunused-arguments for asm files

2014-10-10 Thread Ian Lance Taylor
Ping. Adding Paolo as a build machinery maintainer. Thanks. Ian On Mon, Sep 29, 2014 at 5:12 PM, Ian Lance Taylor i...@google.com wrote: Similar to a recent patch to libgo, this patch to the libffi configure script checks whether the compiler support -Qunused-arguments. If it does

Re: [PATCH 00/13] Go closures, libffi, and the static chain

2014-10-10 Thread Ian Lance Taylor
On Fri, Oct 10, 2014 at 1:42 PM, Richard Henderson r...@redhat.com wrote: So instead I thought about how I'd add some support for Go directly into libffi. After all, we've got some custom code in libffi for Java, why couldn't Go have the same treatment? The stickler, as far as I could see,

Re: [PATCH 03/13] HACK! Allow the static chain to be set from C

2014-10-10 Thread Ian Lance Taylor
On Fri, Oct 10, 2014 at 1:42 PM, Richard Henderson r...@redhat.com wrote: This is awful syntax, and therefore contains no documentation. But we'll need to be able to set the static chain on a few calls within the Go runtime, so we need to expose this by some means. It currently looks like

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Ian Lance Taylor
On Tue, Oct 14, 2014 at 7:12 AM, Joel Brobecker brobec...@adacore.com wrote: libiberty/ChangeLog 2014-08-05 Iain Buclaw ibuc...@gdcproject.org * Makefile.in (CFILES): Add d-demangle.c. (REQUIRED_OFILES): Add d-demangle.o. * cplus-dem.c (libiberty_demanglers): Add

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Ian Lance Taylor
On Tue, Oct 14, 2014 at 10:07 AM, Joel Brobecker brobec...@adacore.com wrote: libiberty/ChangeLog: * d-demangle.c: Replace strtold with strtod in global comment. (strtold): Remove declaration. (strtod): New declaration. (dlang_parse_real): Declare value as

Re: gccgo testcase: binary testdata for libgo/go/debug/elf/file_test.go

2014-10-15 Thread Ian Lance Taylor
On Wed, Oct 15, 2014 at 1:41 PM, Lynn A. Boger labo...@linux.vnet.ibm.com wrote: I'm working on a patch submission for gccgo to add the R_PPC64 relocation definitions to libgo/go/debug/elf/elf.go. Along with this submission I was going to update the testcase file_test.go from the same

Go patch committed: Accept trailing comma after receiver

2014-10-16 Thread Ian Lance Taylor
The Go language spec was clarified to treat a function's receiver as any other parameter list, except that it must contain exactly one parameter. The only effect of this is that a receiver may have a trailing comma after it, as in func (r,) M() and also that it may have extra unnecessary

Go patch committed: Functions that call defer_retaddr not inlinable

2014-10-16 Thread Ian Lance Taylor
It does not work to split functions that call __go_set_defer_retaddr, because those functions are designed to work as a single unit. They always look like this: if (__go_set_defer_retaddr (L)) goto L; real_function (real_args); L: The function __go_set_defer_retaddr always returns

Go patch committed: Report init cycles in method values

2014-10-16 Thread Ian Lance Taylor
This patch from Chris Manghane fixes the Go frontend to correctly report initialization cycles involving method values. He added a test case for this in the master gc testsuite, which will be copied into the gccgo testsuite in due course. This is http://golang.org/issue/7961 . Bootstrapped and

Go patch committed: Don't crash on blank interface

2014-10-16 Thread Ian Lance Taylor
This patch from Chris Manghane fixes a compiler crash when using a blank interface type. This is http://golang.org/issue/8079 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r f0e1f402d71c go/parse.cc --- a/go/parse.cc Thu Oct 16 11:56:29 2014

Go testsuite patch committed: fix test

2014-10-16 Thread Ian Lance Taylor
I forgot to commit this testsuite patch that corresponds to the recent patch for receiver parameters (https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01591.html). Now committed to mainline. Ian Index: test/fixedbugs/bug299.go === ---

Go patch committed: method names must be non-blank

2014-10-16 Thread Ian Lance Taylor
The Go language spec was clarified to say that method names must be non-blank. This patch by Chris Manghane implements this restriction in the Go frontend. This requires a couple of testsuite changes, already in the master testsuite and included in this patch. This fixes

Re: [gofrontend-dev] [PATCH 6/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:58 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: Eases the rediculously tight minimum stack size for goprocesses on 64 bit systems. ChangeLog 2014-09-05 Dominik Vogt v...@linux.vnet.ibm.com * libgo/runtime/proc.c (runtime_newosproc): Set the thread stack

Re: [gofrontend-dev] [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:02 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: This patch extends the -fdump-go-spec option to handle bitfields and unions and fixes handlinx of zero length arrays. All of this is necessary for s390[x] since the system headers use these features. Please check

Re: [gofrontend-dev] [PATCH 8/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:04 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: This is an optional extension of the -fgo-dump-spec option to handle copmplex data types. It is not necessary for s390[x] but was easy to write on top of the previous patch. gcc/ChangeLog 2014-09-05 Dominik Vogt

Re: [gofrontend-dev] [PATCH 9/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:06 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: Quote shell variables that may contain whitespace in the configure file. I cannot remember exactly whether I actually ran into a problem, but the patch won't hurt anyway. ChangeLog 2014-09-05 Dominik Vogt

Re: [gofrontend-dev] [PATCH 0/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:44 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: The following series' of patches introduce s390[x] support for Gccgo. For practical reasons they will be submitted in separate parts. This is the first part of the submissions with architecture independent bug fixes

Re: [PATCHv4][Kasan] Allow to override Asan shadow offset from command line

2014-10-17 Thread Ian Lance Taylor
Jakub Jelinek ja...@redhat.com writes: Not sure if there aren't extra steps to make strtoull prototype available in system.h, libiberty.h etc. for systems that don't have strtoull in their headers. See the #if defined(HAVE_DECL_XXX) !HAVE_DECL_XXX lines in include/libiberty.h. Although

Go patch committed: Don't allow dup names in a tuple assignment

2014-10-17 Thread Ian Lance Taylor
The Go frontend was incorrectly accepting duplicate variable names in a tuple assignment, as in a, a := 0, 0. This is http://golang.org/issue/8436. This patch from Chris Manghane corrects this error. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian

Re: [PATCH] Handle short reads and EINTR in lto-plugin/simple-object

2014-03-26 Thread Ian Lance Taylor
On Wed, Mar 26, 2014 at 8:38 AM, Richard Biener rguent...@suse.de wrote: - got = read (descriptor, buffer, size); - if (got 0) + do { - *errmsg = read; - *err = errno; - return 0; + got = read (descriptor, buffer, size); + if (got 0 + errno !=

Go patch committed: Avoid reading bogus field

2014-03-27 Thread Ian Lance Taylor
PR 59545 points out that there is a case where the Go frontend reads an invalid value from a class field. This happens because of an incorrect static_cast. This patch fixes the problem to only use the static_cast when it is valid. Bootstrapped and ran Go tests on x86_64-unknown-linux-gnu.

Re: [PATCH] Handle short reads and EINTR in lto-plugin/simple-object

2014-03-28 Thread Ian Lance Taylor
On Fri, Mar 28, 2014 at 6:30 AM, Richard Biener rguent...@suse.de wrote: 2014-03-26 Richard Biener rguent...@suse.de libiberty/ * simple-object.c (simple_object_internal_read): Handle EINTR and short reads. lto-plugin/ * lto-plugin.c

Re: [PATCH] Handle short writes / EINTR in simple_object_internal_write

2014-03-31 Thread Ian Lance Taylor
On Mon, Mar 31, 2014 at 3:14 AM, Richard Biener rguent...@suse.de wrote: 2014-03-31 Richard Biener rguent...@suse.de libiberty/ * simple-object.c (simple_object_internal_write): Handle EINTR and short writes. This is OK. Thanks. Ian

Re: Hurd port for gcc go PATCH 0-3 (9)

2014-04-11 Thread Ian Lance Taylor
On Fri, Apr 11, 2014 at 5:47 AM, Svante Signell svante.sign...@gmail.com wrote: Attached are patches to enable gccgo to build properly on Debian GNU/Hurd on gcc-4.9 (4.9-20140406). Thanks. Will review after 4.9 has branched. Note: Creating the Makefile.in is hard (unnecessary) work since

Re: Hurd port for gcc go PATCH 0-3 (9)

2014-04-12 Thread Ian Lance Taylor
On Sat, Apr 12, 2014 at 7:04 AM, Svante Signell svante.sign...@gmail.com wrote: (cd src/libgo;automake-1.11) aclocal.m4:16: warning: this file was generated for autoconf 2.64. You have another version of autoconf. It may work, but is not guaranteed to. To rebuild any of the GCC

Re: Remove obsolete Solaris 9 support

2014-04-16 Thread Ian Lance Taylor
On Wed, Apr 16, 2014 at 4:16 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: * Ian: I've removed Solaris 8 and 9 support from libgo. I'm uncertain if you want this or rather keep that support for the 4.[789] branches? I want it. I don't try to maintain exact copies of older GCC

Re: Remove obsolete Solaris 9 support

2014-04-16 Thread Ian Lance Taylor
On Wed, Apr 16, 2014 at 1:02 PM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Ian Lance Taylor i...@google.com writes: On Wed, Apr 16, 2014 at 4:16 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: * Ian: I've removed Solaris 8 and 9 support from libgo. I'm uncertain if you want

Go patch commited: Mark various expressions as immutable

2014-04-17 Thread Ian Lance Taylor
This patch from Chris Manghane marks various expression types as immutable: numerics, constants, type info, address of, type conversion when appropriate. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 194e0f47c9e5 go/expressions.cc ---

Go patch committed: Only convert function type when necessary

2014-04-17 Thread Ian Lance Taylor
This patch to the Go frontend fixes it to not convert the function type in a call when calling an interface method. The function type of an interface method is not correct, since it does not include the receiver, but the type of the method field is correct, and as such should not be converted.

Go patch committed: Use backend interface for constant expressions

2014-04-17 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface for global constants. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-04-17 Chris Manghane cm...@google.com * go-gcc.cc

libgo patch committed: Avoid unnecessary gccgo extension

2014-04-17 Thread Ian Lance Taylor
This patch from Peter Collingbourne avoids an unnecessary gccgo extension in libgo. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 801009f33610 libgo/go/syscall/libcall_posix.go --- a/libgo/go/syscall/libcall_posix.go Thu Apr 17 16:01:58 2014

libgo patch committed: Use delete rather than old map deletion syntax

2014-04-17 Thread Ian Lance Taylor
This patch from Peter Collingbourne changes libgo to use the builtin delete function rather than the old map deletion syntax. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 1e27a38c43ea libgo/go/syscall/syscall_unix.go ---

libgo patch committed: Avoid duplicate function declarations in syscall

2014-04-17 Thread Ian Lance Taylor
This patch from Peter Collingbourne avoids duplicate function declarations in the generated libcalls.go file when building the syscall package. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 5009262c3e56 libgo/go/syscall/mksyscall.awk ---

Go patch committed: Use backend interface for initialization function

2014-04-22 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface for the initialization function. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-04-22 Chris Manghane cm...@google.com * go-gcc.cc

libgo patch committed: Fix madvise on systems with page size != 4096

2014-04-24 Thread Ian Lance Taylor
This patch from Anton Blanchard fixes libgo to adjust to the system page size when calling madvise. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Ian diff -r 3a53301d24d7 libgo/runtime/mheap.c --- a/libgo/runtime/mheap.c Tue Apr 22

Re: [patch] Shorten Windows path

2014-04-25 Thread Ian Lance Taylor
...@arm.com] Sent: Tuesday, April 01, 2014 6:18 PM To: 'Ian Lance Taylor' Cc: gcc-patches Subject: RE: [patch] Shorten Windows path Ian, thanks for your comments. Please find answers and new version below: -Original Message- From: Ian Lance Taylor [mailto:i...@google.com] Sent

Re: [gofrontend-dev] libgo patch committed: Fix madvise on systems with page size != 4096

2014-04-27 Thread Ian Lance Taylor
On Sun, Apr 27, 2014 at 2:45 PM, Michael Hudson-Doyle michael.hud...@linaro.org wrote: 'Ian Lance Taylor i...@google.com' via gofrontend-dev gofrontend-...@googlegroups.com writes: This patch from Anton Blanchard fixes libgo to adjust to the system page size when calling madvise

Re: [PING] Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-04-29 Thread Ian Lance Taylor
On Tue, Apr 29, 2014 at 11:37 AM, John Marino gnu...@marino.st wrote: Does anyone have any issues with this set of patches to add support for the DragonFly targets? It's a blocker for other patches of mine that have a more general benefit, but this (relatively simple) one has to go in first.

Re: [PING] Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-04-29 Thread Ian Lance Taylor
On Tue, Apr 29, 2014 at 2:37 PM, John Marino gnu...@marino.st wrote: I don't understand the benefit of libgcc/enable-execute-stack-bsd.c. The code seems the same as the existing libgcc/enable-execute-stack-mprotect.c. All you are changing is omitting need_enable_exec_stack. If you just drop

Go patch committed: Avoid memory overrun for bogus file name

2014-04-29 Thread Ian Lance Taylor
Dominik Vogt pointed out a problem in the Go frontend: it could overwrite memory incorrectly if an archive contains a file whose name is only spaces. This patch fixes the problem. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Ian diff -r

Go patch committed: Use backend interface for built-in functions

2014-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface for built-in functions. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-04-30 Chris Manghane cm...@google.com * go-gcc.cc: #include langhooks.h.

Go patch committed: Remove GCC langhooks from Go frontend

2014-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane removes the GCC langhooks from the Go frontend. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-04-30 Chris Manghane cm...@google.com * go-lang.c (go_langhook_type_for_size): Do it here, rather than

Re: wide-int testing, go bits

2014-04-30 Thread Ian Lance Taylor
locations. s,.*/testsuite/,,g is approximately what it needs. Thanks. Fixed like so. Tested on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-04-30 Ian Lance Taylor i...@google.com * go.test/go-test.exp (go-gc-tests): For rundir, pass extra files in go_compile_args

libgo patch committed: Use $GOC for compiler characteristics

2014-04-30 Thread Ian Lance Taylor
This patch from Peter Collingbourne changes the libgo configury and make to test $GOC (the target gccgo) for compiler characteristics rather than $CC. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 703f1d4d9227 libgo/Makefile.am ---

Go patch committed: Use backend interface for error detection

2014-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface to detect whether any errors have been seen. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-04-30 Chris Manghane cm...@google.com * go-backend.c:

Go patch committed: Use backend interface for heap expressions

2014-05-01 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface for heap expressions. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 93286dc73be0 go/expressions.cc --- a/go/expressions.cc Wed Apr 30 21:18:08 2014 -0400 +++

Go patch committed: Use backend interface for bound method expressions

2014-05-05 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface for bound method expressions. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r e828f77c32b7 go/expressions.cc --- a/go/expressions.cc Thu May 01 15:18:08 2014

Go patch committed: Use backend interface for struct field offsets

2014-05-05 Thread Ian Lance Taylor
This patch by Chris Manghane changes the Go frontend to use the backend interface for struct field offsets. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r d87cfc273ffc go/expressions.cc --- a/go/expressions.cc Mon May 05 13:21:55 2014 -0400

Go patch committed: Use backend interface for set-and-use temps

2014-05-05 Thread Ian Lance Taylor
This patch by Chris Manghane changes the Go frontend to use the backend interface for set-and-use temporary variables. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 9ec9e72945e4 go/expressions.cc --- a/go/expressions.cc Mon May 05 13:54:25

Go patch committed: Use backend interface for sink expressions

2014-05-05 Thread Ian Lance Taylor
This patch by Chris Manghane changes the Go frontend to use the backend interface for sink expressions. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r e59376bb96c4 go/expressions.cc --- a/go/expressions.cc Mon May 05 14:49:01 2014 -0400 +++

Go patch committed: Use backend interface for type info expressions

2014-05-05 Thread Ian Lance Taylor
This patch by Chris Manghane changes the Go frontend to use the backend interface for type info expressions. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 1a6ec84147d3 go/expressions.cc --- a/go/expressions.cc Mon May 05 15:05:17 2014 -0400

Go patch committed: Handle recursive pointer types in indirection

2014-05-05 Thread Ian Lance Taylor
This patch by Chris Manghane change the Go frontend to move the handling of indirecting through recursive pointer types to the backend. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-05-05 Chris Manghane cm...@google.com * go-gcc.cc

Go patch committed: Use backend interface for slice construction

2014-05-05 Thread Ian Lance Taylor
This patch by Chris Manghane changes the Go frontend to use the backend interface for slice construction. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-05-05 Chris Manghane cm...@google.com * go-gcc.cc

Go patch committed: Use backend interface for array length

2014-05-05 Thread Ian Lance Taylor
This patch by Chris Manghane changes the Go frontend to use the backend interface for the length of an array. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r f4135c695c00 go/types.cc --- a/go/types.cc Mon May 05 20:10:20 2014 -0400 +++

Go patch committed: Fix bug in embedded method handling

2014-05-06 Thread Ian Lance Taylor
This patch to the Go frontend fixes a bug in the handling of methods of embedded fields. If the same type was embedded in a struct at different levels, only the first embedded instance was considered when building the set of all methods. If the second instance was at a higher level, its methods

Re: GCC's -fsplit-stack disturbing Mach's vm_allocate

2014-05-06 Thread Ian Lance Taylor
On Tue, May 6, 2014 at 4:06 AM, Svante Signell svante.sign...@gmail.com wrote: On Fri, 2014-05-02 at 12:52 +0200, Samuel Thibault wrote: Svante Signell, le Fri 02 May 2014 12:45:56 +0200, a écrit : On Fri, 2014-05-02 at 12:00 +0200, Samuel Thibault wrote: Samuel Thibault, le Fri 02 May 2014

Go patch committed: Store flags for division checks in Gogo object

2014-05-06 Thread Ian Lance Taylor
This patch by Chris Manghane stores the flags for division checks in the Gogo object, rather than referring directly to the GCC global variables. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2014-05-06 Chris Manghane cm...@google.com *

libgo patch committed: Define CLONE flags in syscall package

2014-05-07 Thread Ian Lance Taylor
Domink Vogt pointed out that the gccgo syscall package does not define the CLONE flags. This patch defines them. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Ian diff -r c8ae29f0c4c6 libgo/configure.ac --- a/libgo/configure.ac Tue May 06

libgo patch committed: Define more TIOC constants

2014-05-07 Thread Ian Lance Taylor
This patch to libgo defines more TIOC constants, constants that are non-trivial constants on GNU/Linux systems. Boostrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Ian diff -r bbf6c7c22954 libgo/mksysinfo.sh --- a/libgo/mksysinfo.sh Wed May 07

  1   2   3   4   5   6   7   8   9   10   >