[PATCH] [MSP430] PR78838: Do not add section name prefixes when section name is .lowtext

2017-02-16 Thread Jozef Lawrynowicz
rite access to the GCC SVN repository, so if this patch is satisfactory, I would appreciate if someone could commit it for me. Thanks. --- 2017-02-XX Jozef Lawrynowicz <joze...@somniumtech.com> gcc/ PR target/78838 * config/msp430/msp430.c (gen_prefix): Return NULL when section name is .lowtext

Trunk patches required for gcc-6-branch to build for msp430

2017-03-21 Thread Jozef Lawrynowicz
r244727 and r243310 from the gcc trunk are needed in the gcc-6-branch to build gcc for the msp430 target with C and C++ support. Would it be possible for these patches to be backported to the gcc-6-branch? The gcc-5-branch builds for msp430 with C and C++ support, so isn't this technically a

Re: Trunk patches required for gcc-6-branch to build for msp430

2017-03-31 Thread Jozef Lawrynowicz
ied. From b5aacd74cdd4209f28309d38d85cb0004cc93410 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@somniumtech.com> Date: Thu, 30 Mar 2017 15:46:26 + Subject: [PATCH 1/2] Backport r244727 2017-01-20 Joe Seymour <jo...@somniumtech.com> * acinclude.m4 (GLIBCXX_CHECK_SIZE_T_MANGLING): Support

Re: [PATCH] [MSP430] PR78838: Do not add section name prefixes when section name is .lowtext

2017-03-03 Thread Jozef Lawrynowicz
rite access to the GCC SVN repository, so if this patch is satisfactory, I would appreciate if someone could commit it for me. Thanks. --- 2017-02-XX Jozef Lawrynowicz <joze...@somniumtech.com> gcc/ PR target/78838 * config/msp430/msp430.c (gen_prefix): Return NULL when section name

[PATCH] [MSP430] [STAGE 1] Fix PR78849: ICE on initialization of global struct containing __int20 array

2017-04-24 Thread Jozef Lawrynowicz
The attached patch modifies the setting of TYPE_SIZE for __intN types to use GET_MODE_BITSIZE rather than the bitsize extracted from the N value. TYPE_SIZE for sizetype and bitsizetype are also modified to use GET_MODE_BITSIZE rather than the precision of the type. This fixes an issue for the

Re: [PATCH] [MSP430] [STAGE 1] Fix PR78849: ICE on initialization of global struct containing __int20 array

2017-04-24 Thread Jozef Lawrynowicz
On 24 April 2017 at 12:02, Jozef Lawrynowicz <joze...@somniumtech.com> wrote: > The patch passed bootstrap and regression testing with no regressions > on recent trunk (r247020) for x86_64-pc-linux-gnu. > The patch passed regression testing with "-mcpu=msp430x/-mlar

Re: ping [PATCH] [MSP430] Fix PR78849: ICE on initialization of global struct containing __int20 array

2017-08-01 Thread Jozef Lawrynowicz
On 01/08/2017 00:08, Joseph Myers wrote: On Wed, 26 Jul 2017, Jeff Law wrote: TYPE_SIZE, according to my understanding, should be a tree for the size of the expression in bits. The problem is for msp430 that size varies depending on where it's used. ie, in a register an object might have a

[PATCH 0/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-05-17 Thread Jozef Lawrynowicz
The MSP430 target supports an attribute "persistent" that can be set on variables to indicate that they should be placed in a special section ".persistent", which will not be re-initialized on reset. As reported in PR78818 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78818), GCC does not place

[PATCH 1/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-05-17 Thread Jozef Lawrynowicz
, I would appreciate if someone could commit it for me as I do not have write access. 2017-05-XX Jozef Lawrynowicz <joze...@somniumtech.com> gcc/ PR target/78818 * config/msp430/msp430.c (msp430_unique_section): Set section to .persistent if persistent attribute is set. gcc

[PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-05-17 Thread Jozef Lawrynowicz
Add warning to back end and add test. Patch is attached. If the patch is acceptable, I would appreciate if someone could commit it for me as I do not have write access. 2017-05-XX Jozef Lawrynowicz <joze...@somniumtech.com> gcc/ PR target/78818 * config/msp430/ms

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-05-18 Thread Jozef Lawrynowicz
On 18 May 2017 at 16:46, Martin Sebor wrote: > + if (!message && TREE_NAME_EQ (name, ATTR_PERSIST) && !TREE_STATIC (* > node) > + && !TREE_PUBLIC (* node) && !DECL_EXTERNAL (* node)) > +message = "%qE attribute has no effect on automatic variables"; > > In code like

[PATCH] [MSP430] PR78838: Do not add section name prefixes when section name is .lowtext

2017-05-18 Thread Jozef Lawrynowicz
A patch for this bug was originally posted here: https://gcc.gnu.org/ml/gcc-patches/2017-02/msg01054.html There were some issues with that patch which I've now fixed. The MSP430 target supports the automatic placement of functions and data in different memory regions when passing the

Re: [PING] [MSP430] Trunk patches required for gcc-6-branch to build for msp430

2017-05-26 Thread Jozef Lawrynowicz
On 26/05/2017 13:01, Jonathan Wakely wrote: On 22/05/17 17:16 +0100, Jozef Lawrynowicz wrote: Ping, original post: https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01560.html These are both libstdc++ patches and originally posted to the libstdc++ list, so you'll have more luck mailing that list

ping [PATCH] [MSP430] Fix PR78849: ICE on initialization of global struct containing __int20 array

2017-05-19 Thread Jozef Lawrynowicz
Original post: https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01030.html The attached patch fixes an issue for the msp430 target where the TYPE_SIZE of the __int20 type was set using the precision (20 bits) instead of the in-memory size (32 bits) of the type. This bug caused an ICE as reported in

Re: [PATCH] [MSP430] PR78838: Do not add section name prefixes when section name is .lowtext

2017-05-22 Thread Jozef Lawrynowicz
On 19/05/2017 04:13, Martin Sebor wrote: On 05/18/2017 10:14 AM, Jozef Lawrynowicz wrote: A patch for this bug was originally posted here: https://gcc.gnu.org/ml/gcc-patches/2017-02/msg01054.html There were some issues with that patch which I've now fixed. The MSP430 target supports

[PING] [MSP430] Trunk patches required for gcc-6-branch to build for msp430

2017-05-22 Thread Jozef Lawrynowicz
Ping, original post: https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01560.html --- For the msp430-elf target, the gcc-6-branch fails to build when configured to enable C++ support. The gcc-5-branch successfully builds with C++ support. Backporting r244727 and r243310 to the gcc-6-branch

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-08 Thread Jozef Lawrynowicz
nks, Jozef From 8a41a45f2f771ae540b16ec007ded499a9ed5244 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@somniumtech.com> Date: Mon, 5 Jun 2017 18:07:22 + Subject: [PATCH 1/3] MSP430: Check if a variable can have a section before checking for a section name 2017-06-XX J

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-13 Thread Jozef Lawrynowicz
On 13/06/2017 16:54, Nick Clifton wrote: Hi Jozef, Ok for trunk and gcc-7-branch? Approved - please apply (to both). Cheers Nick Sorry, didn't mention in that last post that I don't have write access, could someone please apply this for me. Thanks, Jozef

[PATCH] [MSP430] Read mcu data from file instead of hardcoded data

2017-08-24 Thread Jozef Lawrynowicz
ta instead. If the patch is acceptable, I would appreciate if someone could commit it for me, as I do not have write access. Thanks, Jozef From 4ea2f4393929b70eb6e56e1d761b584f65d39248 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@somniumtech.com> Date: Thu, 24 Aug 2017 13:44:11 +

[PATCH] [MSP430] [PR78554] Prevent SUBREG from referencing a SYMBOL_REF

2017-08-24 Thread Jozef Lawrynowicz
where the subword is a SYMBOL_REF. If the patch is acceptable, I would appreciate if someone could commit it for me, as I do not have write access. Thanks, Jozef From 72a419c1f470254f06c59c7824ae27818a18b555 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@somniumtech.com> Date: T

Re: ping [PATCH] [MSP430] Fix PR78849: ICE on initialization of global struct containing __int20 array

2017-08-24 Thread Jozef Lawrynowicz
On 22/08/2017 11:57, Jozef Lawrynowicz wrote: On 02/08/2017 17:45, Joseph Myers wrote: On Wed, 2 Aug 2017, Jeff Law wrote: I think Joseph's suggestion for looking at partial float handling may be useful, though ia64's RFmode may be more interesting as it's not a multiple of 8 in bitsize

[PATCH] [MSP430] [PR80993] Prevent lto removing interrupt handlers

2017-08-24 Thread Jozef Lawrynowicz
, Jozef From 44b14ffae0e8956f40cd5356a9f00f5d055709c7 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@somniumtech.com> Date: Thu, 24 Aug 2017 11:10:24 + Subject: [PATCH] MSP430: Prevent lto removing interrupt handlers 2017-08-XX Jozef Lawrynowicz <joze...@somniu

[PATCH] [MSP430] Pass -mcode/data-region to the linker and assembler

2017-08-24 Thread Jozef Lawrynowicz
commit it for me, as I do not have write access. Thanks, Jozef From a1313aeefa289cdf8c7c4b28b04648eed4708716 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@somniumtech.com> Date: Thu, 24 Aug 2017 16:39:29 + Subject: [PATCH] MSP430: Pass -mcode/data-region to the linker and ass

Re: ping [PATCH] [MSP430] Fix PR78849: ICE on initialization of global struct containing __int20 array

2017-08-22 Thread Jozef Lawrynowicz
On 02/08/2017 17:45, Joseph Myers wrote: On Wed, 2 Aug 2017, Jeff Law wrote: I think Joseph's suggestion for looking at partial float handling may be useful, though ia64's RFmode may be more interesting as it's not a multiple of 8 in bitsize. IF/KF modes on the ppc port have similar

[PATCH] MSP430: Don't warn if naked function does not return

2018-05-23 Thread Jozef Lawrynowicz
uld commit it for me, as I don't have write access. >From 6b7a22144d70bcccfeebc9fcefd724e8f05a6e09 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@mittosystems.com> Date: Wed, 23 May 2018 21:33:45 +0100 Subject: [PATCH] MSP430: Dont warn if naked function does not return 2018-05-23

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-06 Thread Jozef Lawrynowicz
On 04/06/18 18:52, DJ Delorie wrote: Jozef Lawrynowicz writes: For the currently released msp430i* devices, only digits follow the i, so no upper or lower case conversion is needed. Thinking of the future... do we expect any new devices with letters? Should we plan for them? Or better

Re: [PATCH] [MSP430] Allow interrupt handers to be static and fix __interrupt__ attribute causing an ICE

2018-06-06 Thread Jozef Lawrynowicz
On 29/05/18 23:55, DJ Delorie wrote: Jozef Lawrynowicz writes: If an argument is passed to the interrupt attribute, GCC will create a section for the interrupt vector when outputting the assembly. This, combined with the code to ensure the interrupt function doesn't get optimized out, ensures

Re: [PATCH] [MSP430] Fix PR39240 execution failure for msp430-elf

2018-05-31 Thread Jozef Lawrynowicz
On 31/05/18 00:28, Jeff Law wrote: It's not clear why having that subreg is causing incorrect code to be generated, but the subreg is clearly wrong since it's a qisi pattern not a hisi pattern. Based on that I've approved and installed the change. There's some further info in PR85941, but I

[PATCH] [MSP430] Allow interrupt handers to be static and fix __interrupt__ attribute causing an ICE

2018-05-27 Thread Jozef Lawrynowicz
access. >From 18d1980bb4061cee9d97f2b7737af2dfd9e52c34 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@mittosystems.com> Date: Sun, 27 May 2018 12:55:41 +0100 Subject: [PATCH] MSP430: Allow interrupt handlers to be static and fix the __interrupt__ attribute causing an ICE 2018-05-

Re: [PATCH] [MSP430] Allow interrupt handers to be static and fix __interrupt__ attribute causing an ICE

2018-05-29 Thread Jozef Lawrynowicz
On 29/05/18 19:45, DJ Delorie wrote: The reason I required interrupt handlers to be non-static is because the linker builds the interrupt handler table using weak references. If the handler is static, it won't be added to the table, and never called. So you'd need a test to ensure that the

[PATCH] [MSP430] Fix PR39240 execution failure for msp430-elf

2018-05-28 Thread Jozef Lawrynowicz
if someone would commit it for me, as I don't have write access. >From 4f96a05f4849e28064f5c202a55b753b59a106ef Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@mittosystems.com> Date: Sun, 27 May 2018 21:09:49 +0100 Subject: [PATCH] MSP430: Fix PR39240 execution failure for msp430-

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-04 Thread Jozef Lawrynowicz
On 04/06/18 18:52, DJ Delorie wrote: Jozef Lawrynowicz writes: For the currently released msp430i* devices, only digits follow the i, so no upper or lower case conversion is needed. Thinking of the future... do we expect any new devices with letters? Should we plan for them? Or better

[MAINTAINERS] Added myself to write after approval

2018-06-01 Thread Jozef Lawrynowicz
Added myself to write after approval list in MAINTAINERS. Index: ChangeLog === --- ChangeLog (revision 261081) +++ ChangeLog (revision 261082) @@ -1,3 +1,7 @@ +2018-06-01 Jozef Lawrynowicz + + * MAINTAINERS (write after

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-06 Thread Jozef Lawrynowicz
On 06/06/18 17:43, DJ Delorie wrote: Jozef Lawrynowicz writes: Word from TI is that the lowercase i is an exception, the rule is to have all uppercase letters. No further msp430i devices are planned so the rules for generating device names in this patch shouldn't need any future changes. So

[PATCH] Document usage of line number 0 in dg-{warning,error,message,bogus} directives

2018-06-06 Thread Jozef Lawrynowicz
rom d08160770abef420b6699f6bd2c30a055bd10350 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Wed, 6 Jun 2018 18:20:56 +0100 Subject: [PATCH] Document usage of line number 0 in dg-{warning,error,message,bogus} directives 2018-06-06 Jozef Lawrynowicz * gcc/doc/sourcebuild.texi: Document usage of line number 0 in ver

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-07 Thread Jozef Lawrynowicz
On 06/06/18 23:38, DJ Delorie wrote: That's fine too, I was thinking of checking mcu_name[i] against NUL. Any of those solutions would work :-) Thanks, installed on trunk.

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-06 Thread Jozef Lawrynowicz
On 06/06/18 21:38, DJ Delorie wrote: + snprintf (mcu_name, sizeof (mcu_name) - 1, "__%s__", target_mcu); + start_upper = 0; Can optimize this to 2 :-) Otherwise OK. Ah yes. Could also do: - for (i = start_upper; i < strlen (mcu_name); i++) + for (i = start_upper; i

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-06 Thread Jozef Lawrynowicz
On 06/06/18 22:02, DJ Delorie wrote: Jozef Lawrynowicz writes: - for (i = start_upper; i < strlen (mcu_name); i++) + for (i = start_upper; i < strlen (mcu_name) - 2; i++) Might be faster to test mcu_name[i] instead of calling strlen repeatedly too, but this only runs on

[PATCH] Update comment about the format of attribute name in attribute_spec handler

2018-05-28 Thread Jozef Lawrynowicz
the patch is acceptable, I would appreciate if someone would commit it for me, as I don't have write access. >From 386f8e6aadf5627fcba0955a8dbb6abcec69b1a5 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@mittosystems.com> Date: Mon, 28 May 2018 13:04:12 +0100 Subject: [PATCH] U

[PATCH] [MSP430] Fix -fleading-underscore having no effect

2018-05-28 Thread Jozef Lawrynowicz
commit it for me, as I don't have write access. >From 4b9fc3e0bf3e746c6be95c994f5ea4882dcd3e1d Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <joze...@mittosystems.com> Date: Wed, 23 May 2018 21:52:24 +0100 Subject: [PATCH] MSP430: Fix -fleading-underscore having no effect 2018-05-

[PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-04 Thread Jozef Lawrynowicz
rom: Jozef Lawrynowicz Date: Mon, 4 Jun 2018 12:04:54 +0100 Subject: [PATCH] MSP430: Fix device name symbol defined for msp430i* devices 2018-06-04 Jozef Lawrynowicz * gcc/config/msp430/msp430.c (msp430_mcu_name): Set the "i" in the symbol defined for msp430i* devices to be lowe

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

2018-06-04 Thread Jozef Lawrynowicz
On 04/06/18 18:26, DJ Delorie wrote: Jozef Lawrynowicz writes: + if (strncmp (target_mcu, "msp430i", 7) == 0) + snprintf (mcu_name, sizeof (mcu_name) - 1, "__MSP430i%s__", + target_mcu + 7); + else Do you need to TOUPPER the parts of tar

Re: [PATCH] [MSP430] Allow interrupt handers to be static and fix __interrupt__ attribute causing an ICE

2018-05-27 Thread Jozef Lawrynowicz
On 27/05/18 14:19, Jozef Lawrynowicz wrote: If the patch is acceptable, I would appreciate if someone would commit it for me, as I don't have write access. "msp430.md" in the ChangeLog entry should be "msp430.c".

[PATCH 0/4] [MSP430] Add methods to extract MCU data from file

2018-06-27 Thread Jozef Lawrynowicz
The following series of patches extends MCU device data handling for the msp430 target, allowing an external file to be read which describes the CPU ISA and hardware multiply supported for different MCUs. The current hard-coded solution means that new MCUs can only be supported by updating the

[PATCH 1/4] [MSP430] Consolidate hard-coded MCU data

2018-06-27 Thread Jozef Lawrynowicz
by the driver which places the corresponding mcpu value for the MCU on its command line. Ok for trunk? >From 751a5b4f32a91d697b56fa94ca8426fa6679c5fa Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 7 Jun 2018 14:44:10 +0100 Subject: [PATCH 1/4] MSP430 - Devices 1 - Handle device ta

[PATCH 2/4] [MSP430] Update hard-coded MCU data

2018-06-27 Thread Jozef Lawrynowicz
The second patch updates the hard-coded MCU data to the latest version. >From 7da6e1edcffc1fa1a93dde5e23c87f9653132768 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Mon, 25 Jun 2018 19:56:53 +0100 Subject: [PATCH 2/4] MSP430 - Devices 1.1 Update hard-coded MCU data 2018-06

[PATCH 3/4] [MSP430] Search for MCU data file on include paths

2018-06-27 Thread Jozef Lawrynowicz
. >From 7e24ade1d4d16d71dca3f4d7d3e66a784d2563fd Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Tue, 26 Jun 2018 12:21:09 +0100 Subject: [PATCH 3/4] MSP430 - Devices 2 - Add functionality to read device data from CSV file 2018-06-27 Jozef Lawrynowicz gcc/config/msp430/ * msp

[PATCH 4/4] [MSP430] Search for MCU data file using environment variable and in a toolchain subdirectory

2018-06-27 Thread Jozef Lawrynowicz
ces.csv is not found on an include path. If devices.csv is found using one of these methods, the directory containing devices.csv is also registered as an include path and linker library path. >From 43a9106e71a8b7545f894b4c1c495288b6144876 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Tu

[PATCH] [MSP430] PR79242: Implement Complex Partial Integers

2018-01-12 Thread Jozef Lawrynowicz
. A further bug prevents trunk from building for msp430-elf. If the attached patch is acceptable, I would appreciate if someone would commit it for me, as I do not have write access. From 31d8554ebb6afeb2d8f235cf3d3c262236aa5e32 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz <jozefl@gmail.

[wwwdocs] Fix contribute.html documentation on testing patches

2018-01-11 Thread Jozef Lawrynowicz
The instructions on https://gcc.gnu.org/contribute.html#testing for bootstrapping GCC are incorrect. The instructions say to run 'make bootstrap' from the top level GCC directory, but this results in the below error. $ make bootstrap make: *** No rule to make target 'bootstrap'. Stop. The

[PING] [PATCH] [MSP430] PR79242: Implement Complex Partial Integers

2018-02-08 Thread Jozef Lawrynowicz
Lawrynowicz <jozefl@gmail.com> Date: Fri, 12 Jan 2018 13:23:40 + Subject: [PATCH] Add support for Complex Partial Integers - CPSImode 2018-01-XX Jozef Lawrynowicz <jozefl@gmail.com> gcc/ PR target/79242 * machmode.def: Define a complex mode for PARTIAL_INT.

Re: [PING] [PATCH] [MSP430] PR79242: Implement Complex Partial Integers

2018-02-14 Thread Jozef Lawrynowicz
On 14/02/18 07:25, Jeff Law wrote: On 02/08/2018 09:54 AM, Jozef Lawrynowicz wrote: ping x1 Complex Partial Integers are unimplemented, resulting in an ICE when attempting to use them. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79242 This results in GCC7/8 for msp430-elf failing to build

[PATCH] Fix PR middle-end/86705

2018-07-29 Thread Jozef Lawrynowicz
? >From e655a518a06a848dc398504f28272750e1a2be9f Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Tue, 13 Mar 2018 11:25:56 + Subject: [PATCH] When aligning to POINTER_SIZE, round alignment to largest power of 2 that is <= POINTER_SIZE PR middle-end/86705 * gcc/cfgexpand.c (set_pa

[PATCH] [MSP430] Fix PR/86662

2018-07-27 Thread Jozef Lawrynowicz
:00 2001 From: Jozef Lawrynowicz Date: Tue, 24 Jul 2018 23:24:41 +0100 Subject: [PATCH][MSP430] Fix PR86662 2018-07-27 Jozef Lawrynowicz PR target/86662 * gcc/tree.c (build_common_tree_nodes): Initialize integer_types array with all enabled __intN types. * gcc/testsuite/gcc.target/msp

Re: [PATCH] Fix PR middle-end/86705

2018-07-31 Thread Jozef Lawrynowicz
On 30/07/18 14:29, Richard Biener wrote: On Sun, Jul 29, 2018 at 6:27 PM Jozef Lawrynowicz wrote: pr45678-2.c ICEs for msp430-elf with -mlarge, because an alignment of POINTER_SIZE is attempted. POINTER_SIZE with -mlarge is 20-bits, so further code in the middle-end that expects

ping [PATCH] Fix trunk failing to build for msp430-elf

2018-04-18 Thread Jozef Lawrynowicz
ping x1 Trunk doesn't build for msp430 due to an ICE whilst building libstdc++. The following patch proposed a while ago fixes the issue, but hasn't been applied: https://gcc.gnu.org/ml/gcc-patches/2017-08/msg01433.html I don't have write access, so if the patch is acceptable I would

[PATCH] Fix trunk failing to build for msp430-elf

2018-03-20 Thread Jozef Lawrynowicz
Trunk doesn't build for msp430 due to an ICE whilst building libstdc++. The following patch proposed a while ago fixes the issue, but hasn't been applied: https://gcc.gnu.org/ml/gcc-patches/2017-08/msg01433.html I don't have write access, so if the patch is acceptable I would appreciate if

[PATCH] [MSP430] Extend MSP430 data attribute handler

2018-10-18 Thread Jozef Lawrynowicz
for these attributes, and some other MSP430 attributes, which previously did not have tests. Ok for trunk? >From 5c56509cfa0f285549eceefb457dc59134d30d0e Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 18 Oct 2018 22:16:22 +0100 Subject: [PATCH] Extend MSP430 data attribute handling 2018-1

[PATCH] Fix PR87691: transparent_union attribute does not work with MODE_PARTIAL_INT

2018-10-23 Thread Jozef Lawrynowicz
-linux-gnu, and msp430-elf with -mlarge. For msp430-elf with -mlarge, the above DejaGNU tests are also fixed. Ok for trunk? >From cc1ccfcc0d8adf7b0e1ca95a47a8a8e7e12fc99c Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Mon, 22 Oct 2018 21:02:10 +0100 Subject: [PATCH] Allow union TYPE_M

[committed] Fix GIMPLE error in gcc.dg/tree-ssa/cunroll-13.c for 16-bit int

2018-11-01 Thread Jozef Lawrynowicz
f29 execute_todo ../../gcc/passes.c:1979 There is a missing cast when the integer literal "1" is used, which causes the above error. Committed the attached patch as "obvious". 2018-11-01 Jozef Lawrynowicz gcc/testsuite * gcc.dg/tree-ssa/cunroll-13.c: Add missing cas

ping x2 [PATCH 1/3] [MSP430] Consolidate hard-coded MCU data

2018-10-29 Thread Jozef Lawrynowicz
which places the corresponding mcpu value for the MCU on its command line. >From 58709e127d3bf13da6da58fca416946718c4c17c Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Mon, 29 Oct 2018 13:48:06 + Subject: [PATCH 1/3] MSP430 - Devices 1 - Handle device tasks in separate file 2018-10

ping x2 [PATCH 0/3] [MSP430] Add methods to extract MCU data from file

2018-10-29 Thread Jozef Lawrynowicz
The same as previous pings except I removed the patch which updates the hard-coded device data - I'll commit that later as "obvious". Ok for trunk? The following series of patches extends MCU device data handling for the msp430 target, allowing an external file to be read which describes the

ping x2 [PATCH 3/3] [MSP430] Search for MCU data file using environment variable and in a toolchain subdirectory

2018-10-29 Thread Jozef Lawrynowicz
d on an include path. If devices.csv is found using one of these methods, the directory containing devices.csv is also registered as an include path and linker library path. >From cc4dbcb83be19fd55e6dae28ea37a714109bec26 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Mon, 29 Oct 2018 13:52:39 +0

ping x2 [PATCH 2/3] [MSP430] Search for MCU data file on include paths

2018-10-29 Thread Jozef Lawrynowicz
ed. >From e85964a398a35a69513da07e4fcdaeed215ae79a Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Mon, 29 Oct 2018 13:51:24 + Subject: [PATCH 2/3] MSP430 - Devices 2 - Add functionality to read device data from CSV file 2018-10-29 Jozef Lawrynowicz gcc/config/msp430/ * msp430-devices.c (msp430_check_path_for_

[committed] Fix type of "num" argument to memcpy in gcc.c-torture/compile/pr65595.c

2018-11-07 Thread Jozef Lawrynowicz
The test uses "unsigned long" as the "num" argument to memcpy, but it should be size_t, and these types are not equivalent on all targets. Committed to trunk. >From 3ebbb8102bd9b984c6f1a1eaf0bca45fe4fd23e1 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Tue, 6

ping x3 [PATCH 0/3] [MSP430] Add methods to extract MCU data from file

2018-11-13 Thread Jozef Lawrynowicz
ping On 29/10/2018 14:22, Jozef Lawrynowicz wrote: The same as previous pings except I removed the patch which updates the hard-coded device data - I'll commit that later as "obvious". Ok for trunk? The following series of patches extends MCU device data handling for the msp

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-15 Thread Jozef Lawrynowicz
On Thu, 15 Nov 2018 09:48:05 -0500 Paul Koning wrote: > > On Nov 14, 2018, at 5:19 PM, Jozef Lawrynowicz > > wrote: > > > > > > I'd be curious if the line I added the xfail to in c-c++-common/pr57371-2.c > > also fails for pdp11. > > > > The co

[committed][MSP430] Fix classification of PC, CG1 and CG2 registers

2018-11-06 Thread Jozef Lawrynowicz
regtested the attached patch on trunk, and committed. >From 9e26066f2a0f979a6bea538d27524e03b81618f3 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Fri, 2 Nov 2018 20:59:10 + Subject: [PATCH] [MSP430] Fix register classification of PC, CG1 and CG2 2018-11-06 Jozef Lawrynowicz

[PATCH] Fix PR87927, implement TARGET_ASM_{,UN}ALIGNED_P{S,D,T}I_OP

2018-11-14 Thread Jozef Lawrynowicz
e for them. Successfully bootstrapped and regtested current trunk for x86_64-pc-linux-gnu and regtested msp430-elf with -mlarge. Ok for trunk? >From 48890bd01668f68bafbd94556c9754bf2406 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 8 Nov 2018 13:42:27 + Subject: [PATCH] Implemen

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
On Wed, 14 Nov 2018 11:30:39 -0500 Paul Koning wrote: > > On Nov 14, 2018, at 10:44 AM, Jozef Lawrynowicz > > wrote: > > > > Patch 1 tweaks dg directives in tests specifically for msp430. Many of > > these are extensions to existing target selectors in dg direct

[PATCH 0/7][MSP430][TESTSUITE] Fix GCC tests for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
The following series of patches fixes a number of test failures when running the GCC DejaGNU testsuite for msp430-elf. The raw output from contrib/compare_tests is a bit misleading for some tests, as lines have been added to the source code, changing line numbers for dg-warning/dg-error tests. I

[PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
Patch 1 tweaks dg directives in tests specifically for msp430. Many of these are extensions to existing target selectors in dg directives. From a730d945647923c5c10e8487ca3c2a24511abf3d Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 8 Nov 2018 18:55:57 + Subject: [PATCH 1/7

[PATCH 5/7][MSP430][TESTSUITE] Prune messages about ISO C not supporting __int20 from output of tests

2018-11-14 Thread Jozef Lawrynowicz
rom ed24754b1d97992400bb374916d87cce151f7e89 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Sat, 10 Nov 2018 15:47:21 + Subject: [PATCH 5/7] [TESTSUITE] Prune messages about ISO C not supporting __int20 from output of tests 2018-11-14 Jozef Lawrynowicz gcc/testsuite/ChangeLog: * gcc

[PATCH 7/7][MSP430][TESTSUITE] Fix tests for msp430-elf large memory model

2018-11-14 Thread Jozef Lawrynowicz
Patch 7 fixes tests for msp430-elf in the large memory model. >From 494465f13df814bf3daad5e330d2c7139f2db625 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Sat, 10 Nov 2018 16:08:44 + Subject: [PATCH 7/7] [TESTSUITE] Fix tests for msp430-elf large memory model 2018-11-14 Jo

[PATCH 3/7][MSP430][TESTSUITE] Dynamically check if size_t is large enough for tests containing large structs/arrays

2018-11-14 Thread Jozef Lawrynowicz
rom 23ab77f7e44e104595adb0b5cabd9caf93141ffd Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 8 Nov 2018 22:39:12 + Subject: [PATCH 3/7] [TESTSUITE] Dynamically check if size_t is large enough for tests containing large structs/arrays 2018-11-14 Jozef Lawrynowicz gcc/testsuite/ChangeLog: * gc

[PATCH 4/7][MSP430][TESTSUITE] Fix tests when int is 16-bit by default

2018-11-14 Thread Jozef Lawrynowicz
Patch 4 fixes tests when int is 16-bits by default. >From 62b273f73cd7a4db22b1161f450ae7267d185890 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 8 Nov 2018 23:09:38 + Subject: [PATCH 4/7] [TESTSUITE] Fix tests when int is 16-bit by default 2018-11-14 Jozef Lawrynow

[PATCH 2/7][MSP430][TESTSUITE] Add path to libssp to the linker search path when checking for -fstack-protector support

2018-11-14 Thread Jozef Lawrynowicz
Patch 2 fixes issues finding libssp when linking tests or checking for fstack_protector support. >From 6c6f34bae386a5f396e6f9630514fc7080c2f940 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Sun, 11 Nov 2018 14:30:32 + Subject: [PATCH 2/7] [TESTSUITE] Add path to lib

[PATCH 6/7][MSP430][TESTSUITE] Fix tests requiring float printf support when GCC was configured with --enable-newlib-nano-formatted-io

2018-11-14 Thread Jozef Lawrynowicz
ol. >From 15a04e0139ec40196ddb79f1125635029dccae68 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Sat, 10 Nov 2018 16:02:25 + Subject: [PATCH 6/7] [TESTSUITE] Fix tests requiring float printf support when GCC was configured with --enable-newlib-nano-formatted-io 2018-11-14 Jozef Lawrynowicz gcc/testsuite/Chang

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-15 Thread Jozef Lawrynowicz
On Thu, 15 Nov 2018 10:36:57 +0100 Andreas Schwab wrote: > On Nov 14 2018, Jozef Lawrynowicz wrote: > > > The timeout as set in the dejagnu configuration for msp430 > > ([dejagnu.git]/baseboards/msp430-sim.exp) is 30, which is rarely > > hit. > > I don't th

[committed][testsuite][MSP430][3/4] Extend regex in tests expecting "nop" to accept "NOP"

2018-11-08 Thread Jozef Lawrynowicz
Patch 3 extends the regex in some tests which scan the assembler output for "nop". On MSP430, the nop instruction is an uppercase "NOP". >From 6ad3780262543c5237e939ac14ac6294a2adc77b Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Tue, 6 Nov 2018 12:59:58 +0

[committed][testsuite][MSP430][4/4] Fix calculation of USHRT_MAX in tests

2018-11-08 Thread Jozef Lawrynowicz
rom: Jozef Lawrynowicz Date: Tue, 6 Nov 2018 12:50:01 + Subject: [PATCH 4/4] [TESTSUITE] size of short == size of int 2018-11-08 Jozef Lawrynowicz gcc/testsuite/ChangeLog: * gcc.dg/attr-alloc_size-10.c: Fix calculation of USHRT_MAX to prevent integer overflow when sizeof(short) == siz

[committed][MSP430][0/4] "Obvious" fixes to GCC tests for msp430-elf

2018-11-08 Thread Jozef Lawrynowicz
I've committed some "obvious" changes to GCC tests that fix failures when running the GCC testsuite for msp430-elf. Patch 1 adds a couple of new regexp strings to gcc-dg-prune to catch messages emitted by GNU ld, when the size of an output section is too large for a memory region, or the memory

[committed][testsuite][MSP430][2/4] Skip tests requiring -fdelete-null-pointer-checks for targets which don't support this flag

2018-11-08 Thread Jozef Lawrynowicz
Patch 2 skips tests expecting NULL pointer checks to be deleted with the -fdelete-null-pointer-checks flag, for targets which ignore this flag. >From 55b405a4d2c694ffdbcbd6808e139d88cb2d2447 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Tue, 6 Nov 2018 12:59:33 + Subject: [PATC

[committed][MSP430][1/4] Add regexp for memory region overflow to gcc-dg-pune

2018-11-08 Thread Jozef Lawrynowicz
Patch 1 adds a couple of new regexp strings to gcc-dg-prune to catch messages emitted by GNU ld, when the size of an output section is too large for a memory region, or the memory region overflows. >From af810d86c47092e56590f5c13d0633c490f53c9d Mon Sep 17 00:00:00 2001 From: Jozef Lawrynow

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
On 14/11/2018 18:50, Paul Koning wrote: On Nov 14, 2018, at 1:00 PM, Jozef Lawrynowicz wrote: On 14/11/2018 16:54, Andreas Schwab wrote: On Nov 14 2018, Jozef Lawrynowicz wrote: diff --git a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c b/gcc/testsuite/c-c++-common

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
On 14/11/2018 16:54, Andreas Schwab wrote: On Nov 14 2018, Jozef Lawrynowicz wrote: diff --git a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c b/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c index 6b1c427..71d24ce 100644 --- a/gcc/testsuite/c-c++-common

ping [PATCH 0/4] [MSP430] Add methods to extract MCU data from file

2018-09-24 Thread Jozef Lawrynowicz
ping for these patches [PATCH 1/4] [MSP430] Consolidate hard-coded MCU data https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01673.html [PATCH 2/4] [MSP430] Update hard-coded MCU data https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01674.html [PATCH 3/4] [MSP430] Search for MCU data file on include

[ping][PATCH][MSP430][TESTSUITE] Fix tests for msp430-elf large memory model

2018-12-31 Thread Jozef Lawrynowicz
:00 2001 From: Jozef Lawrynowicz Date: Sat, 10 Nov 2018 16:08:44 + Subject: [PATCH] [TESTSUITE] Fix tests for msp430-elf large memory model 2018-11-21 Jozef Lawrynowicz gcc/ChangeLog: * doc/sourcebuild.texi: Document check_effective_target_msp430_large_mem. gcc/testsuite/Change

[ping][PATCH][TESTSUITE] Fix ISO C errors in tests when __PTRDIFF_TYPE__ and __SIZE_TYPE__ are not ISO C compatible

2018-12-31 Thread Jozef Lawrynowicz
though __int20 is the underlying type. It is only when the builtin macros for these types are used does the error occur. Successfully regtested x86_64-pc-linux-gnu and msp430-elf/-mlarge. Ok for trunk? >From b940f79fa7c2a76fdda75dae7baf2bd48c72e9fa Mon Sep 17 00:00:00 2001 From: Jozef Lawrynow

[PATCH] Check requested alignment in SET_{DECL,TYPE}_ALIGN is pow2_or_zerop before aligning on targets with partial int modes

2018-12-30 Thread Jozef Lawrynowicz
this have to wait for GCC10 Stage 1? >From b44723988dfb0bb9e8c647dd86aeba762ebdf84d Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Tue, 18 Dec 2018 11:14:35 + Subject: [PATCH] Check requested alignment in SET_{DECL,TYPE}_ALIGN is pow2_or_zerop before aligning on targets with partial

[committed][MSP430] Warn that the critical function attribute has no effect on interrupt functions

2018-12-29 Thread Jozef Lawrynowicz
to trunk. >From 18eb3191fee5f7cc8288cfd88a0b76259b8b547c Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Sat, 29 Dec 2018 16:27:49 + Subject: [PATCH] [MSP430] Warn that the critical function attribute has no effect on interrupt functions 2018-12-29 Jozef Lawrynowicz gcc

Re: [PATCH] Check requested alignment in SET_{DECL,TYPE}_ALIGN is pow2_or_zerop before aligning on targets with partial int modes

2019-01-16 Thread Jozef Lawrynowicz
On Fri, 11 Jan 2019 13:00:22 -0700 Jeff Law wrote: > On 12/30/18 4:51 AM, Jozef Lawrynowicz wrote: > > > > The attached patch adds an assertion that SET_{DECL,TYPE}_ALIGN is called > > with > > a value which is a power of 2, or 0, for targets which support a partia

Re: [PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

2018-12-18 Thread Jozef Lawrynowicz
On Tue, 18 Dec 2018 03:08:51 -0600 Segher Boessenkool wrote: > Hi! > > On Fri, Dec 14, 2018 at 03:22:13PM +0000, Jozef Lawrynowicz wrote: > > 2018-12-14 Jozef Lawrynowicz > > > > gcc/ChangeLog: > > * combine.c (update_rsp_from_reg_equal

[committed][MSP430] Define TARGET_VTABLE_ENTRY_ALIGN

2018-12-18 Thread Jozef Lawrynowicz
is always 16 for MSP430, the attached patch (committed to trunk) sets TARGET_VTABLE_ENTRY_ALIGN to 16 for MSP430. This fixes the above ICE. Index: gcc/ChangeLog === --- gcc/ChangeLog (revision 267228) +++ gcc/ChangeLog (revision 267229

[PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

2018-12-12 Thread Jozef Lawrynowicz
0 2001 From: Jozef Lawrynowicz Date: Tue, 27 Nov 2018 19:03:53 + Subject: [PATCH] Use last_set_nonzero_bits for a REG when REG mode is MODE_PARTIAL_INT 2018-12-12 Jozef Lawrynowicz gcc/ChangeLog: * combine.c (reg_nonzero_bits_for_combine): Use last_set_nonzero_bits for a reg if the current mod

Re: [PATCH] [MSP430] Fix gcc.dg/pr85180.c and gcc.dg/pr87985.c timeouts for msp430-elf -mlarge

2018-12-14 Thread Jozef Lawrynowicz
parity with how last_set_nonzero_bits are set in record_value_for_reg. I've regtested the attached patch for msp430-elf, currently bootstrapping and testing on x86_64-pc-linux-gnu. Is this ok for trunk if bootstrap and regtest for x86_64-pc-linux-gnu is successful? Jozef 2018-12-14 Jozef Lawrynow

Re: [PATCH 5/7][MSP430][TESTSUITE] Prune messages about ISO C not supporting __int20 from output of tests

2018-11-28 Thread Jozef Lawrynowicz
On Tue, 27 Nov 2018 10:49:56 -0800 Mike Stump wrote: > On Nov 26, 2018, at 3:07 PM, Jozef Lawrynowicz > wrote: > > > > It appears you can actually add __extension__ everywhere (that I tried), > > except > > for the argument types in the declaration

[PATCH 7/7][v2][MSP430][TESTSUITE] Fix tests for msp430-elf large memory model

2018-11-21 Thread Jozef Lawrynowicz
On Wed, 14 Nov 2018 15:41:00 + Jozef Lawrynowicz wrote: > Patch 7 fixes tests for msp430-elf in the large memory model. Added missing documentation for new check_effective target procs in attached patch. >From 4cfb2ecd0e0580f69790fadd68b77e8a82992ef4 Mon Sep 17 00:00:00 2001 From:

[PATCH 6/7][v2][MSP430][TESTSUITE] Fix tests requiring float printf support when GCC was configured with --enable-newlib-nano-formatted-io

2018-11-21 Thread Jozef Lawrynowicz
On Wed, 14 Nov 2018 15:41:00 + Jozef Lawrynowicz wrote: > Patch 6 fixes tests expecting printf float support for targets which have been > configured with "newlib-nano-formatted-io". When newlib is configured in this > way, float printf is enabled at build time by regist

[PATCH 3/7][v2][MSP430][TESTSUITE] Dynamically check if size_t is large enough for tests containing large structs/arrays

2018-11-21 Thread Jozef Lawrynowicz
On Wed, 14 Nov 2018 15:41:00 + Jozef Lawrynowicz wrote: > Patch 3 sets up require-effective-target directives for tests which > require the compilation of large arrays. > Targets which have 16-bit or 20-bit size_t fail to compile tests with large > arrays designed to test 32-b

  1   2   >