[PATCH] Fix PR58250

2013-08-30 Thread Markus Trippelsdorf
optimizing for size. Please apply if the patch looks OK. Thanks. 2013-08-30 Markus Trippelsdorf * config/i386/i386.c (ix86_option_override_internal): Only prefetch loop_arrays during profile_use when not optimizing for size. diff --git a/gcc/config/i386/i386.c b/gcc

Re: Simplify jump threading slightly

2013-09-10 Thread Markus Trippelsdorf
On 2013.09.05 at 14:30 -0600, Jeff Law wrote: > > Bootstrapped and regression tested on x86_64-unknown-linux-gnu. > Installed onto the trunk. This patch caused http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58373 -- Markus

Re: Context sensitive type inheritance graph walking

2013-09-25 Thread Markus Trippelsdorf
On 2013.09.25 at 12:20 +0200, Jan Hubicka wrote: > this is updated version of > http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00936.html > > Bootstrapped/regtested x86_64-linux. The patch is tested by ipa-devirt9 > testcase. I have extra four, but I would like to first fix the case where the > d

Re: RFC: LRA for x86/x86-64 [0/9]

2012-09-28 Thread Markus Trippelsdorf
On 2012.09.28 at 11:21 -0400, Vladimir Makarov wrote: > On 12-09-28 4:21 AM, Steven Bosscher wrote: > > On Fri, Sep 28, 2012 at 12:56 AM, Vladimir Makarov > > wrote: > >>Any comments and proposals are appreciated. Even if GCC community > >> decides that it is too late to submit it to gcc4.8,

Re: Fix twolf -funroll-loops -O3 miscompilation (a semi-latent web.c bug)

2012-10-12 Thread Markus Trippelsdorf
On 2012.10.12 at 21:43 +0200, Jan Hubicka wrote: > I finally tracked down twolf misoptimization triggered by my loop-unroll.c > changes. It has turned out to be semi-latent wrong code issue in webizer. > What happens is: > > 1) gcse.c drop REG_EQUAL note on the induction variable > 2) loop optimi

C++ (RFC) PATCH fix for PR55076 and PR53921

2012-10-27 Thread Markus Trippelsdorf
The problem here is that we end up with an INDIRECT_REF TREE_CODE with a null TREE_TYPE in lvalue_kind. Is this possible at that point, or does it point to a deeper underlying problem? Bootstraped and tested on x86_64-pc-linux-gnu. 2012-10-27 Markus Trippelsdorf PR c++/50089

[PATCH] Fix part of PR58712

2013-10-15 Thread Markus Trippelsdorf
->indirect_unknown_callee may be uninitialized in cgraph_add_edge_to_call_site_hash. Fixed by initializing it earlier. LTO bootstrapped and tested on x86_64-unknown-linux-gnu. Please apply, if this looks reasonable. Thanks. 2013-10-15 Markus Trippelsdorf PR ipa/58712 * cgrap

Re: [PATCH] Fix part of PR58712

2013-10-18 Thread Markus Trippelsdorf
On 2013.10.15 at 12:49 +0200, Richard Biener wrote: > On Tue, Oct 15, 2013 at 12:31 PM, Markus Trippelsdorf > wrote: > > Valgrind complains: > > ==27870== Conditional jump or move depends on uninitialised value(s) > > ==27870==at 0x557CDC: cgraph_create_edge_1(c

Re: [PATCH] Fix part of PR58712

2013-10-21 Thread Markus Trippelsdorf
LTO bootstrapped and tested on x86_64-unknown-linux-gnu. I would be grateful if one of you guys could apply it. Thanks. 2013-10-21 Markus Trippelsdorf PR ipa/58712 * cgraph.c (cgraph_create_edge_1): Add indirect_unknown_callee as argument

Re: [PATCH] Fix part of PR58712

2013-10-24 Thread Markus Trippelsdorf
On 2013.10.21 at 09:33 +0200, Markus Trippelsdorf wrote: Ping. I do not have write access... > > LTO bootstrapped and tested on x86_64-unknown-linux-gnu. > > I would be grateful if one of you guys could apply it. > Thanks. > > 2013-10-21 Markus Trippelsdorf >

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

2016-01-28 Thread Markus Trippelsdorf
On 2016.01.20 at 18:38 +0100, Gerald Pfeifer wrote: > On Wed, 20 Jan 2016, Jakub Jelinek wrote: > >> Content-Security-Policy: default-src 'self' http: https: > >> > >> So either we get the configuration of the web server changed, or > >> indeed we need to touch all those existing pages. > > At l

Re: C++ PATCH for c++/10200 (DR 141, template name lookup after ->)

2016-02-10 Thread Markus Trippelsdorf
On 2016.02.10 at 10:30 -0500, Jason Merrill wrote: > After . or ->, when we see a name followed by < we look for a template name, > first in the scope of the object expression and then in the enclosing scope. > DR 141 clarified that when we look in the enclosing scope, we only consider > class temp

Re: [PR66726] Fixe regression caused by Factor conversion out of COND_EXPR

2016-02-11 Thread Markus Trippelsdorf
On 2016.02.08 at 09:49 -0700, Jeff Law wrote: > On 01/18/2016 08:52 PM, Kugan wrote: > > > >2016-01-19 Kugan Vivekanandarajah > > > > PR middle-end/66726 > > * tree-ssa-reassoc.c (optimize_range_tests): Handle tcc_compare stmt > > whose result is used in PHI. > > (maybe_optimize_

Re: C++ PATCH for c++/69753 (DR141 broke member template lookup)

2016-02-16 Thread Markus Trippelsdorf
On 2016.02.15 at 16:13 -0500, Jason Merrill wrote: > When we stopped finding function templates with unqualified lookup due to > the DR141 fix, that exposed bugs in our lookup within the object expression > scope; an object-expression of the current instantiation does not make the > expression depe

Re: [PATCH][CilkPlus] Fix PR69363

2016-02-17 Thread Markus Trippelsdorf
On 2016.02.17 at 18:29 +0300, Ilya Verbin wrote: > On Wed, Feb 17, 2016 at 16:28:34 +0100, Marek Polacek wrote: > > On Wed, Feb 17, 2016 at 04:14:22PM +0100, Jakub Jelinek wrote: > > > On Wed, Feb 17, 2016 at 04:11:44PM +0100, Marek Polacek wrote: > > > > On Wed, Feb 17, 2016 at 06:08:14PM +0300, I

[PATCH commited] Properly initialize variable in tree-chkp.c

2016-02-21 Thread Markus Trippelsdorf
I've committed the following patch as obvious: * tree-chkp.c (chkp_mark_invalid_bounds_walker): Initialize variable. diff --git a/gcc/tree-chkp.c b/gcc/tree-chkp.c index d3119c642f33..3fba12c2ae46 100644 --- a/gcc/tree-chkp.c +++ b/gcc/tree-chkp.c @@ -895,7 +895,7 @@ chkp_mark_inv

Re: [wwwdocs] Describe behavior of -flifetime-dse in class constructors

2016-02-25 Thread Markus Trippelsdorf
On 2016.02.25 at 11:01 +0100, Martin Liška wrote: > On 02/17/2016 04:01 PM, Martin Liška wrote: > > On 02/17/2016 03:23 PM, Jakub Jelinek wrote: > >> "has been" looks weird. I'd say that the C++ compiler is now more > >> aggressive... > >> > I've been thinking if the suggested patch makes sense an

Re: [wwwdocs] Describe behavior of -flifetime-dse in class constructors

2016-02-25 Thread Markus Trippelsdorf
On 2016.02.25 at 11:07 +0100, Markus Trippelsdorf wrote: > On 2016.02.25 at 11:01 +0100, Martin Liška wrote: > > On 02/17/2016 04:01 PM, Martin Liška wrote: > > > On 02/17/2016 03:23 PM, Jakub Jelinek wrote: > > >> "has been" looks weird. I

Re: [PATCH] Reuse the saved_scope structures allocated by push_to_top_level

2016-03-03 Thread Markus Trippelsdorf
On 2016.03.03 at 09:16 -0500, Patrick Palka wrote: > push_to_top_level gets called fairly frequently in template-heavy code > that performs a lot of instantiations, and we currently "leak" a lot of > GC memory when compiling such code since [push|pop]_to_top_level() do > not bother reusing or even

[Patch Ping] Add slim-lto support to gcc's build machinery

2013-11-27 Thread Markus Trippelsdorf
On 2013.11.20 at 15:43 +0100, Markus Trippelsdorf wrote: > On 2013.11.20 at 14:41 +0100, Paolo Bonzini wrote: > > Note that you need to regenerate all users of libtool.m4. Please post a > > patch _with_ the regeneration so that whoever applies it won't screw up. Ping. Can

Re: [RFC] Old school parallelization of WPA streaming

2013-12-13 Thread Markus Trippelsdorf
On 2013.12.06 at 10:43 +0100, Richard Biener wrote: > On Fri, 6 Dec 2013, Jan Hubicka wrote: > > > > On Thu, 21 Nov 2013, Jan Hubicka wrote: > > > > > > > > > > > > > Why do you need an additional -fparallelism? Wouldn't > > > > > -fwpa=... be a better match, matching -flto=...? As we already

[patch] MAINTAINERS (Write After Approval): Add myself.

2013-12-16 Thread Markus Trippelsdorf
Comitted. 2013-12-16 Markus Trippelsdorf * MAINTAINERS (Write After Approval): Add myself. diff --git a/MAINTAINERS b/MAINTAINERS index a3255aff5d64..410f96cb323c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -545,6 +545,7 @@ Kresten Krab Thorup k

Re: [RFC, PATCH] Disable -fprofile-use related optimizations if corresponding .gcda file not found.

2015-10-07 Thread Markus Trippelsdorf
On 2015.10.07 at 19:11 +0300, Maxim Ostapenko wrote: > when testing OpenSSL performance, I found out that sometimes PGO-built > binaries can actually introduce performance regressions. We could > identify affected object files and disable PGO for them by simply > removing corresponding .gcda fil

[PATCH] Fix PR68087

2015-10-26 Thread Markus Trippelsdorf
Hi, the patch below fixes PR68087, an ICE caused by referring to a negative constexpr array element. Bootstrapped and tested on ppc64le. OK for trunk? gcc-5 also needs a slightly different fix. I'll post that as a follow-up, once this one gets approved. PR c++/68087 * constexpr.

Re: [PATCH] Fix PR68087

2015-10-26 Thread Markus Trippelsdorf
On 2015.10.26 at 13:26 +0100, Richard Biener wrote: > On Mon, Oct 26, 2015 at 12:32 PM, Markus Trippelsdorf > wrote: > > diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c > > index ebca411b3eb4..0828a90b0e75 100644 > > --- a/gcc/cp/constexpr.c > > +++ b/gcc

Re: [patch] New backend header reduction

2015-10-31 Thread Markus Trippelsdorf
On 2015.10.31 at 07:56 +0100, Andreas Schwab wrote: > ../../gcc/ggc-common.c: In function 'void init_ggc_heuristics()': > ../../gcc/ggc-common.c:822: error: 'GGC_MIN_EXPAND' was not declared in this > scope > ../../gcc/ggc-common.c:822: error: 'set_default_param_value' was not declared > in this

Re: [patch] New backend header reduction

2015-10-31 Thread Markus Trippelsdorf
On 2015.10.31 at 08:33 +0100, Markus Trippelsdorf wrote: > On 2015.10.31 at 07:56 +0100, Andreas Schwab wrote: > > ../../gcc/ggc-common.c: In function 'void init_ggc_heuristics()': > > ../../gcc/ggc-common.c:822: error: 'GGC_MIN_EXPAND' was not declared i

Re: ping [aPATCH] Fix c++/67337 (segfault in mangle.c)

2015-11-16 Thread Markus Trippelsdorf
On 2015.08.31 at 11:31 +0200, Markus Trippelsdorf wrote: > On 2015.08.24 at 13:44 +0200, Markus Trippelsdorf wrote: another ping. > ping > > > decl_mangling_context() in mangle.c returns a NULL_TREE in case of > > template type parameters. write_template_prefix()

Re: [PATCH] Add clang-format config to contrib folder

2015-11-18 Thread Markus Trippelsdorf
On 2015.11.18 at 15:10 +0100, Martin Liška wrote: > Hello. > > Following patch adds a clang-format config file that should respect the GNU > coding standards. > As the file is not part of build process, I hope the patch can be applied > even though > we've just skipped to stage3? The patch adds

Re: [PATCH] Add clang-format config to contrib folder

2015-11-18 Thread Markus Trippelsdorf
On 2015.11.18 at 15:37 +0100, Markus Trippelsdorf wrote: > On 2015.11.18 at 15:10 +0100, Martin Liška wrote: > > Hello. > > > > Following patch adds a clang-format config file that should respect the GNU > > coding standards. > > As the file is not part of build

Re: [PATCH,RFC] Introduce RUN_UNDER_VALGRIND in test-suite

2015-11-19 Thread Markus Trippelsdorf
On 2015.11.19 at 15:38 +0100, Martin Liška wrote: > > In last two weeks I've removed couple of memory leaks, mainly tight to > middle-end. Currently, a user of the GCC compiler can pass > '--enable-checking=valgrind' configure option that will run all > commands within valgrind environment, but a

Re: [C++ Patch] PR 68087

2015-11-25 Thread Markus Trippelsdorf
/ > /cp > 2015-11-25 Markus Trippelsdorf > Paolo Carlini > > PR c++/68087 > * constexpr.c (cxx_eval_array_reference): Use tree_fits_shwi_p before > tree_to_shwi to avoid ICEs. > > /testsuite > 2015-11-25 Markus Trippelsdorf >

[PATCH committed] PR other/61321 - demangler crash on casts in template parameters

2015-11-27 Thread Markus Trippelsdorf
I've committed the patch from Pedro Alves for PR61321. It was approved by Jason over a year ago and the dups kept piling up. PR other/61321 - demangler crash on casts in template parameters The fix for bug 59195: [C++ demangler handles conversion operator incorrectly] h

Re: [PATCH][contrib] Update download_prerequisites to ISL 0.15.

2015-12-07 Thread Markus Trippelsdorf
On 2015.12.07 at 11:52 +, Alan Lawrence wrote: > Since r229889, we now have tests that pass only with ISL 0.15. Although ISL > 0.15 > is not a requirement, it seems we should make it easy to build the compiler > that > way. This is already fixed by r231329. -- Markus

Re: [DOC, PATCH] Mention --enable-valgrind-annotations in install.texi

2015-12-09 Thread Markus Trippelsdorf
On 2015.12.09 at 10:33 +0100, Martin Liška wrote: > On 12/09/2015 12:47 AM, Gerald Pfeifer wrote: > > On Tue, 8 Dec 2015, Martin Liška wrote: > >> I would like to add a missing configure option. > > > > +Specify that the compiler should interact with valgrind runtime, where > > +selected invalid m

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-09 Thread Markus Trippelsdorf
On 2015.12.09 at 10:53 -0800, H.J. Lu wrote: > > Empty C++ class is a corner case which isn't covered in psABI nor C++ ABI. > There is no mention of "empty record" in GCC documentation. But there are > plenty of "empty class" in gcc/cp. This change affects all targets. C++ ABI > should specify

Re: [v3 PATCH] PR libstdc++/68139

2015-12-10 Thread Markus Trippelsdorf
On 2015.12.11 at 09:50 +0200, Ville Voutilainen wrote: > On 11 December 2015 at 08:55, Marc Glisse wrote: > > On Fri, 11 Dec 2015, Ville Voutilainen wrote: > > > >> Tested on Linux-PPC64. > >> > >> 2015-12-11 Ville Voutilainen > >> > >>PR libstdc++/68139 > >> > >>/libstdc++-v3 > >>*

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-06 Thread Markus Trippelsdorf
On 2017.06.05 at 22:39 +0200, Nicolas Koenig wrote: > With all the style fixes committed as r248877. 171_swim fails now. I didn't bisect, but I suspect your revision. -- Markus

Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbers in GIMPLE.

2017-06-08 Thread Markus Trippelsdorf
On 2017.01.19 at 18:20 +, Joseph Myers wrote: > On Thu, 19 Jan 2017, Tamar Christina wrote: > > > Hi Joseph, > > > > I made the requested changes and did a quick pass over the rest > > of the fp cases. > > I've no further comments, but watch out for any related test failures > being reporte

Re: [PATCH] Speed-up indirect-call instrumentation

2017-06-09 Thread Markus Trippelsdorf
On 2017.06.09 at 14:17 +0200, Martin Liška wrote: > Hello. > > I discussed with Honza possibility to speed-up instrumentation that we do for > indirect call target tracking. By direct emission of: > > if (__gcov_indirect_call_callee != NULL) >__gcov_indirect_call_profiler_v2 (profile

Re: Fix IPA profile updates in inlining and ipa-split

2017-11-18 Thread Markus Trippelsdorf
On 2017.11.18 at 00:39 +0100, Jan Hubicka wrote: > Hi, > this patch fixes remaining IPA profile updating issues I am aware of. With > this change there is 1 profile mismatch after inlining for tramp3d -Ofast > and 112 of them in .optimized dump which is about 10 times less than before. > I did not

Re: RFA (hash-map): PATCH to support GTY((cache)) with hash_map

2017-11-25 Thread Markus Trippelsdorf
On 2017.11.14 at 13:32 +0100, Richard Biener wrote: > On Fri, Sep 15, 2017 at 11:45 PM, Jason Merrill wrote: > > The hash_map interface is a lot more convenient than that of > > hash_table for cases where it makes sense, but there hasn't been a way > > to get the ggc_cache_remove behavior with a h

[PATCH] Fix UB in hash-map.h

2017-11-26 Thread Markus Trippelsdorf
bootstrap-ubsan shows: gcc/hash-map.h:277:19: runtime error: member access within null pointer of type 'struct hash_map' Fix the issue by returning early. bootstrap-ubsan on X86_64 and ppc64le. Tested on ppc64le. OK for trunk? gcc/ * hash-map.h (gt_cleare_cache): Avoid UB. diff --git

[PATCH] Fix PR82488 - signed integer overflow in expr.c

2017-11-26 Thread Markus Trippelsdorf
bootstrap-ubsan shows: gcc/expr.c:4103:17: runtime error: signed integer overflow: 0 - -9223372036854775808 cannot be represented in type 'long int' Fix by handling the saw_unknown case earlier. bootstrap-ubsan on X86_64 and ppc64le. Tested on ppc64le. OK for trunk? PR rtl-optimizatio

[PATCH][i386] Fix PR83358 - increase divide/mod latencies a bit

2017-12-12 Thread Markus Trippelsdorf
As the testcase shows, trunk currently generates horrible code for divisions used in tight loops. This happens because the algorithm expanding div/mod doesn't take parallelism into account and this makes the cost model unrealistic. Fix the issue by increasing the estimated latencies a bit. Tested

[PATCH][i386] Correct imul (r64) latency for modern Intel CPUs

2017-12-17 Thread Markus Trippelsdorf
Since Nehalem the 64bit multiplication latency is three cycles, not four. So update the costs to reflect reality. Tested on X86_64. OK for trunk? Thanks. * x86-tune-costs.h (skylake_cost, core_cost): Decrease r64 multiply latencies. * gcc.target/i386/wmul-3.c: New test.

Re: [PATCH][i386] Correct imul (r64) latency for modern Intel CPUs

2017-12-17 Thread Markus Trippelsdorf
On 2017.12.17 at 12:26 +0100, Jan Hubicka wrote: > > Since Nehalem the 64bit multiplication latency is three cycles, not > > four. So update the costs to reflect reality. > > I looked into the imul latencies and was a bit confused, decided to look > into it later and forgot. > > Agner Fog's table

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-07 Thread Markus Trippelsdorf
On 2018.01.07 at 21:07 -0700, Sandra Loosemore wrote: > On 01/07/2018 03:58 PM, H.J. Lu wrote: > > This set of patches for GCC 8 mitigates variant #2 of the speculative > > execution > > vulnerabilities on x86 processors identified by CVE-2017-5715, aka Spectre. > > They > > convert indirect bra

Re: [PATCH] Fix failure building LLVM with location wrapper nodes (PR c++/83799)

2018-01-12 Thread Markus Trippelsdorf
On 2018.01.11 at 18:21 -0500, David Malcolm wrote: > diff --git a/gcc/testsuite/g++.dg/wrappers/pr83799.C > b/gcc/testsuite/g++.dg/wrappers/pr83799.C > new file mode 100644 > index 000..f93c0ae > --- /dev/null > +++ b/gcc/testsuite/g++.dg/wrappers/pr83799.C > @@ -0,0 +1,18 @@ > +class DataLayo

Re: [PATCH] Fix failure building LLVM with location wrapper nodes (PR c++/83799)

2018-01-12 Thread Markus Trippelsdorf
On 2018.01.12 at 09:07 +0100, Markus Trippelsdorf wrote: > On 2018.01.11 at 18:21 -0500, David Malcolm wrote: > > diff --git a/gcc/testsuite/g++.dg/wrappers/pr83799.C > > b/gcc/testsuite/g++.dg/wrappers/pr83799.C > > new file mode 100644 > > index 000..f93c0ae >

Re: [PATCH 1/5] x86: Add -mindirect-branch=

2018-01-14 Thread Markus Trippelsdorf
On 2018.01.14 at 11:46 +0100, Jan Hubicka wrote: > > gcc/ > > > > * config/i386/i386-opts.h (indirect_branch): New. > > * config/i386/i386-protos.h (ix86_output_indirect_jmp): Likewise. > > * config/i386/i386.c (ix86_using_red_zone): Disallow red-zone > > with local indirect jump wh

Re: [PATCH] Implement -fsanitize=null + new sanopt pass

2013-11-12 Thread Markus Trippelsdorf
On 2013.11.13 at 00:13 +0100, Marek Polacek wrote: > 2) bootstrap-ubsan almost passes, but the bootstrap fails when building >all-fixincludes. The problem here is that libiberty.a is built >with -fsanitize=undefined, but fixincludes, when linking, >don't link libubsan in. My attemps t

Re: Enale -fno-fat-lto-objects by default

2013-11-18 Thread Markus Trippelsdorf
On 2013.11.18 at 19:04 +0100, Jan Hubicka wrote: > Hi, > this patch switches the default for fat-lto-objects as was documented for a > while. > -ffat-lto-objects doubles compilation time and often makes users to not > notice that > LTO was not used at all (because they forgot to use gcc-ar/gcc-nm

Re: Enale -fno-fat-lto-objects by default

2013-11-19 Thread Markus Trippelsdorf
On 2013.11.19 at 09:44 +0100, Paolo Bonzini wrote: > Il 18/11/2013 20:09, Jan Hubicka ha scritto: > >>> > > this patch switches the default for fat-lto-objects as was documented > >>> > > for a while. > >>> > > -ffat-lto-objects doubles compilation time and often makes users to > >>> > > not noti

Re: Enale -fno-fat-lto-objects by default

2013-11-19 Thread Markus Trippelsdorf
On 2013.11.19 at 11:54 +0100, Paolo Bonzini wrote: > Il 19/11/2013 11:05, Markus Trippelsdorf ha scritto: > > On 2013.11.19 at 09:44 +0100, Paolo Bonzini wrote: > >> Il 18/11/2013 20:09, Jan Hubicka ha scritto: > >>>>>>> this patch switches the def

Re: Enale -fno-fat-lto-objects by default

2013-11-19 Thread Markus Trippelsdorf
On 2013.11.19 at 11:21 +0100, Jan Hubicka wrote: > > On 2013.11.19 at 09:44 +0100, Paolo Bonzini wrote: > > > Il 18/11/2013 20:09, Jan Hubicka ha scritto: > > > >>> > > this patch switches the default for fat-lto-objects as was > > > >>> > > documented for a while. > > > >>> > > -ffat-lto-objects

Add slim-lto support to gcc's build machinery

2013-11-19 Thread Markus Trippelsdorf
strap-lto.mk could be dropped.) LTO-Bootstrapped on x86_64-linux (with default -fuse-linker-plugin). The patch was already approved by Paolo Bonzini. Please apply, because I don't have access. Thanks. 2013-11-20 Markus Trippelsdorf * libtool.m4 : Handle slim-lto objects. *

[Patchv2] Add slim-lto support to gcc's build machinery

2013-11-20 Thread Markus Trippelsdorf
On 2013.11.20 at 14:41 +0100, Paolo Bonzini wrote: > Il 20/11/2013 08:23, Markus Trippelsdorf ha scritto: > > Hi, > > > > now that slim-lto objects are enabled by default, it would be nice to > > use them when building gcc with bootstrap-lto. The following patch >

[PATCH] Fix r216010 fallout

2014-10-09 Thread Markus Trippelsdorf
This fixes fallout from r216010, which causes Firefox build failures. Just move the gcc_assert below the new if statement. Boostrapped and tested on powerpc64-unknown-linux-gnu. Ok for trunk? Thanks. 2014-10-09 Markus Trippelsdorf * pa-polymorphic-call.c (check_stmt_for_type_change

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-14 Thread Markus Trippelsdorf
On 2014.08.25 at 23:03 -0400, DJ Delorie wrote: > > > I'd like to see the updated version of the whole of patch 3 (tested > > to be actually independent of the other patches) for review, though > > I won't be reviewing the C++ parts. > > Here it is. Tested on x86_64. I include the msp430-modes.

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-15 Thread Markus Trippelsdorf
On 2014.10.14 at 17:10 -0400, DJ Delorie wrote: > > > ../../gcc/gcc/config/rs6000/rs6000-c.c:237:24: error: ‘RID_INT128’ was not > > declared in this scope > > Two options: > > 1. If you know the RS6000 will never have any __intN other than >__int128, just use RID_INT_N_0, although this is

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-15 Thread Markus Trippelsdorf
On 2014.10.15 at 17:00 -0400, DJ Delorie wrote: > > > If you could implement the second option, it would be appreciated. > > Could you please test this for me? It builds as a powerpc-elf > cross-compiler (at least the host half) but I don't have a power > machine here to test on. > > Index: rs6

[PATCH v2] Fix pr61848, linux kernel miscompile

2014-10-16 Thread Markus Trippelsdorf
Override existing olddecl section name. Set tls_model for all thread-local vars, not just OMP thread-private ones. Remove incorrect comment. 2014-10-16 Markus Trippelsdorf PR middle-end/61848 g++.dg/torture/pr61848.C: New testcase. gcc.c-torture/compile

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.20 at 14:21 -0700, Dehao Chen wrote: > >> +If @var{path} is specified, GCC looks at the @var{path} to find > >> +the profile feedback data files. > >> + > >> +In order to collect AutoFDO profile, you need to have: > >> + > >> +1. A linux system with linux perf support > >> +2. An Intel p

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.21 at 13:53 -0700, Dehao Chen wrote: > Everything will be the same on non-intel CPUs except for the perf command: > > perf record -e instructions -- your program. > > i.e. you need to drop "-b" and use instructions as event. > > Note that the current algorithm is tuned for accurate in

Re: [PATCH] AutoFDO patch for trunk

2014-10-21 Thread Markus Trippelsdorf
On 2014.10.21 at 15:31 -0700, Dehao Chen wrote: > Looks like the perf data type is incompatible with quipper (perf data > parser). Can you send me the perf.data file so that I can take a look. PERF_RECORD_MMAP2 (aka 10) was added in Linux 3.12 (commit 13d7a2410f). So your autofdo tool simply doesn

Re: PR lto/63603: Fix -fno-lto handling in driver (gcc/gcc.c)

2014-10-23 Thread Markus Trippelsdorf
On 2014.10.22 at 13:57 +0200, Tobias Burnus wrote: > I intent to commit the following patch this evening, which was > pre-proved for 4.9/trunk by Richard in the PR. > However, I still need to do the bootstrapping and regtesting. This breaks bootstrap-lto: ... configure: error: Link tests are not a

[PATCH] Fix bootstrap/PR63632

2014-10-23 Thread Markus Trippelsdorf
d and tested on powerpc64-unknown-linux-gnu. Preapproved by Jakub on IRC. Applied to trunk and 4.9 branch. 2014-10-24 Markus Trippelsdorf PR bootstrap/63632 * collect2.c (main): Filter out -fno-lto. PR bootstrap/63632 * g++.dg/torture/pr63632.C: New test. diff --git

[PATCH] Fix PR63649

2014-10-27 Thread Markus Trippelsdorf
When assigning symbols to sections in ipa-comdats.c we currently segfault when val is NULL. Fix by guarding against this case. Tested on powerpc64-unknown-linux-gnu. OK for trunk? 2014-10-27 Markus Trippelsdorf PR ipa/63649 * ipa-comdats.c (ipa_comdats): Guard against NULL

Re: [patch] c++/58051 Implement Core 1579

2014-07-01 Thread Markus Trippelsdorf
On 2014.06.26 at 14:06 +0100, Jonathan Wakely wrote: > DR1579 relaxes [class.copy]/32 so that expressions in return > statements can be looked up as rvalues even when they aren't the same > type as the function return type. > > Implementing that seems as simple as removing the restriction on the >

Re: ODR merging and implicit typedefs

2015-05-19 Thread Markus Trippelsdorf
On 2015.05.19 at 19:33 +0200, Jan Hubicka wrote: > > Jason, > I just noticed that there are bogus ODR violation warnings during > LTO-bootstrap > (that breaks -Werror builds). It was caused by my work-around for > type_in_anonymous_namespace > for the issue discussed in: > https://gcc.gnu.org/m

[PATCH] Fix PR65911

2015-04-28 Thread Markus Trippelsdorf
During the removal of "#if ARGS_GROW_DOWNWARD" in r222508, Trevor forgot to add parentheses around a ternary operator. Tested on powerpc64-unknown-linux-gnu. Preapproved by Jakub and Richard on bugzilla. Commited to trunk. 2015-04-28 Markus Trippelsdorf PR o

Re: C++ PATCH for c++/50800 (ICE with may_alias and templates)

2015-04-29 Thread Markus Trippelsdorf
On 2015.04.28 at 10:42 -0400, Jason Merrill wrote: > On 04/23/2015 01:45 PM, H.J. Lu wrote: > > On Thu, Apr 23, 2015 at 8:52 AM, Jason Merrill wrote: > >> We try to strip attributes that aren't reflected in mangling from template > >> arguments, but were failing to do that in this case. Fixed by

Re: [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)

2015-05-08 Thread Markus Trippelsdorf
On 2015.05.08 at 09:38 -0700, Steve Ellcey wrote: > > This patch has broken the glibc build. I am not sure if the problem is > a bug in your patch or a bug in the code used by glibc. Here is a > cutdown test case from glibc (timezone/scheck.c). This code compiled > before your patch but now it

Re: PATCHes to help with C++11 bootstrap

2015-05-09 Thread Markus Trippelsdorf
On 2015.05.08 at 23:30 -0500, Jason Merrill wrote: > One C++11 compatibility issue that turns up a lot in the GCC sources is > that in C++98, > > #define BAR "bar" > const char *p = "foo"BAR; > > is well-formed, giving p the value "foobar". But in C++11 this is a > user-defined literal with th

Re: PATCHes to help with C++11 bootstrap

2015-05-11 Thread Markus Trippelsdorf
This broke bootstrap on ppc64. Fix committed as obvious. 2015-05-11 Markus Trippelsdorf PR bootstrap/66105 * config/rs6000/option-defaults.h: Add space between string literal and macro name. diff --git a/gcc/config/rs6000/option-defaults.h b/gcc/config/rs6000/o

Re: C PATCH for -Wshift-negative-value (PR c/66066)

2015-05-11 Thread Markus Trippelsdorf
On 2015.05.11 at 17:54 +0200, Marek Polacek wrote: > On Mon, May 11, 2015 at 05:09:26PM +0200, Manuel López-Ibáñez wrote: > > On 11/05/15 16:21, Marek Polacek wrote: > > >The -Wshift-negative-value patch caused grief since it breaks building > > >some programs. The following patch should alleviate

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Markus Trippelsdorf
On 2014.11.13 at 15:11 +0100, mliska wrote: Just two remarks: > +template > +class GTY((user)) cgraph_summary > +{ > +public: > + /* Default construction takes SYMTAB as an argument. */ > + cgraph_summary (symbol_table *symtab, bool ggc = false): m_ggc (ggc), > +m_insertion_enabled (true

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Markus Trippelsdorf
On 2014.11.14 at 01:19 -0500, Trevor Saunders wrote: > On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: > > On 2014.11.13 at 15:11 +0100, mliska wrote: > > > > > + /* Destructor. */ > > > + virtual ~cgraph_summary

Re: Drop target_option_node reconstruction logic.

2014-11-14 Thread Markus Trippelsdorf
On 2014.11.14 at 20:13 +0100, Jan Hubicka wrote: > this patch kills lto's code to rebuilt DECL_FUNCTION_SPECIFIC_TARGET from > target > attributes. This code was never complete and it should be no-op now when we > save > tehe target nodes. > It also makes free_land_data_in_decl to actually anota

[PATCH] Add testcase for PR 63894

2014-11-17 Thread Markus Trippelsdorf
PR 63894 was fixed by r217634, so I'm just adding the testcase. Tested on powerpc64-unknown-linux-gnu. Commited. 2014-11-17 Markus Trippelsdorf PR ipa/63894 * g++.dg/ipa/pr63894.C: New test. diff --git a/gcc/testsuite/g++.dg/ipa/pr63894.C b/gcc/testsuite/g++.dg/ipa/pr63894.C new

Re: [patch] New std::string implementation

2014-11-17 Thread Markus Trippelsdorf
On 2014.11.14 at 15:43 +, Jonathan Wakely wrote: > Tested on x86_64-linux and powerpc64-linux, also with > --disable-libstdcxx11-abi to verify all the incompatible changes can > be disabled if needed. On ppc64 I get: FAIL: libstdc++-abi/abi_check FAIL: 27_io/basic_ios/copyfmt/char/1.cc execut

Re: [BUILDROBOT] Build breakage in builtin.c (was: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls)

2014-11-17 Thread Markus Trippelsdorf
On 2014.11.17 at 15:52 +0100, Jan-Benedict Glaw wrote: > On Thu, 2014-11-06 15:24:59 +0300, Ilya Enkovich > wrote: > > Hi, > > > > This patch adds support of instrumented builtin calls in expand. > > Calls are mostly expanded as calls. But some of them reuse existing > > string function calls e

[PATCH] rs6000: Fix signed integer overflows

2014-11-19 Thread Markus Trippelsdorf
n unsigned type to negate this value to itself config/rs6000/predicates.md:955:12: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'; cast to an unsigned type to negate this value to itself The fix was tested on powerpc64-unknown-linux-gnu. OK for trunk

Re: [PATCH] rs6000: Fix signed integer overflows

2014-11-19 Thread Markus Trippelsdorf
On 2014.11.19 at 11:20 -0500, David Edelsohn wrote: > On Wed, Nov 19, 2014 at 10:24 AM, Markus Trippelsdorf > wrote: > > bootstrap-ubsan on gcc112 shows a couple of signed integer overflows: > > > The fix was tested on powerpc64-unknown-linux-gnu. > > OK f

[PATCH] PR63426 Fix various signed integer overflows

2014-11-20 Thread Markus Trippelsdorf
Running the testsuite after bootstrap-ubsan on gcc112 shows several issues. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63426 for the full list. This patch fixes several of them. Tested on powerpc64-unknown-linux-gnu. OK for trunk? Thanks. 2014-11-20 Markus Trippelsdorf

[PATCH] rs6000: Follow up for signed integer overflow fix

2014-11-20 Thread Markus Trippelsdorf
On 2014.11.20 at 08:59 -0500, David Edelsohn wrote: > On Thu, Nov 20, 2014 at 8:27 AM, Markus Trippelsdorf > wrote: > > Running the testsuite after bootstrap-ubsan on gcc112 shows several issues. > > See > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63426 for the full

Re: [PATCH] rs6000: Follow up for signed integer overflow fix

2014-11-20 Thread Markus Trippelsdorf
On 2014.11.20 at 19:44 +0100, Jakub Jelinek wrote: > On Thu, Nov 20, 2014 at 07:41:43PM +0100, Markus Trippelsdorf wrote: > > 2014-11-20 Markus Trippelsdorf > > > > * config/rs6000/rs6000.c (includes_rldic_lshift_p): Cast 0 to unsigned. > > (includes

Re: [PATCH]Add myself to MAINTAINERS

2014-11-21 Thread Markus Trippelsdorf
On 2014.11.21 at 11:42 +, Richard Earnshaw wrote: > On 21/11/14 11:16, Renlin Li wrote: > > Hi, > > > > This patch is to add myself into section of > > MAINTAINERS file. > > > > Is it Okay to commit? > > OK There is no need to ask for permission in this case: http://gcc.gnu.org/svnwrite.h

Re: [PATCH] IPA ICF: memory leak fix

2014-11-22 Thread Markus Trippelsdorf
On 2014.11.22 at 09:05 +0100, Martin Liška wrote: > Hello. > > Following patch removes memory leak that was introduced by very first IPA ICF > patch. > I would like to thank David for hunting the leak. > > Patch an bootstrap on x86_86-linux-pc and no regression is introduced. I gave the patch a

Re: [PATCH] IPA ICF: memory leak fix

2014-11-22 Thread Markus Trippelsdorf
On 2014.11.22 at 16:04 +0100, Martin Liška wrote: > On 11/22/2014 10:09 AM, Markus Trippelsdorf wrote: > > On 2014.11.22 at 09:05 +0100, Martin Liška wrote: > >> > >> Following patch removes memory leak that was introduced by very first IPA > >> ICF patch.

Re: [PATCH] IPA ICF: memory leak fix

2014-11-23 Thread Markus Trippelsdorf
On 2014.11.22 at 17:46 +0100, Markus Trippelsdorf wrote: > On 2014.11.22 at 16:04 +0100, Martin Liška wrote: > > On 11/22/2014 10:09 AM, Markus Trippelsdorf wrote: > > > On 2014.11.22 at 09:05 +0100, Martin Liška wrote: > > >> > > >> Following patch remov

[PATCH] Fix PR64059

2014-11-24 Thread Markus Trippelsdorf
This fixes PR64059 where a call to get_dynamic_type wasn't guarded by flag_devirtualize. Tested on powerpc64-unknown-linux-gnu. Preapproved by Honza on bugzilla. Commited to trunk. PR ipa/64059 * ipa-prop.c (ipa_analyze_call_uses): Don't call get_dynamic_type when devirtua

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-25 Thread Markus Trippelsdorf
On 2014.11.24 at 22:05 +, Sebastian Pop wrote: > I got my scripts installed on the gcc-farm. I first used an x86_64 gcc75 and > valgrind was crashing not recognizing how to decode an instruction. Then I > moved to gcc112 a powerpc64-linux where I got this data from stage2 cc1plus > compiling

Re: ipa-icf::merge TLC

2015-02-25 Thread Markus Trippelsdorf
On 2015.02.25 at 09:38 +0100, Jan Hubicka wrote: > this patch reorganize sem_function::merge and sem_variable::merge. > I read the code in detail and found several issues that are fixed in the > following patch. I gave your patch a quick spin. It breaks Chromium. Its protocol buffer compiler gets

Re: ipa-icf::merge TLC

2015-02-25 Thread Markus Trippelsdorf
On 2015.02.25 at 19:32 +0100, Martin Liška wrote: > On 02/25/2015 06:15 PM, Jan Hubicka wrote: > >> On 2015.02.25 at 09:38 +0100, Jan Hubicka wrote: > >>> this patch reorganize sem_function::merge and sem_variable::merge. > >>> I read the code in detail and found several issues that are fixed in th

Re: [PATCH, libsanitizer] Enable for PowerPC little endian

2015-02-27 Thread Markus Trippelsdorf
On 2015.02.27 at 07:47 -0600, Peter Bergner wrote: > > Ok, since the results met your criteria for inclusion, I committed the > change as revision 221060. Thanks. Are there any plans to fix: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63927 ? -- Markus

[PATCH] Fix PR65261

2015-03-02 Thread Markus Trippelsdorf
to forced-alignment on POWER8. So just silence the ubsan errors. Tested with bootstrap-ubsan on ppc64le. OK for trunk? Thanks. 2015-03-02 Markus Trippelsdorf PR target/65261 * lex.c (init_vectorized_lexer): Silence ubsan errors. diff --git a/libcpp/lex.c b/libcpp/lex.c ind

Re: [PATCH] Fix PR65261

2015-03-02 Thread Markus Trippelsdorf
On 2015.03.02 at 18:53 +0100, Marek Polacek wrote: > On Mon, Mar 02, 2015 at 06:22:49PM +0100, Markus Trippelsdorf wrote: > > --- a/libcpp/lex.c > > +++ b/libcpp/lex.c > > @@ -519,6 +519,7 @@ init_vectorized_lexer (void) > > and VSX unaligned loads (when VSX is ava

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-09 Thread Markus Trippelsdorf
On 2015.03.09 at 14:00 -0400, David Edelsohn wrote: > On Thu, Mar 5, 2015 at 6:14 PM, Alan Modra wrote: > > This arranges to build a powerpc64le-linux compiler without -m32 > > support by default. Bootstrapped and regression tested on Ubuntu > > powerpc64le-linux without --disable-multilib, and o

  1   2   3   4   >