Re: build_function_call and TREE_ADDRESSABLE

2011-03-04 Thread Richard Guenther
On Fri, Mar 4, 2011 at 5:58 AM, Alan Modra amo...@gmail.com wrote: Warn off anyone trying to do as I did, and the bit about inlines is no longer relevant.  OK to apply?        * tree.h (TREE_ADDRESSABLE): Note that direct calls set the        flag on FUNCTION_DECLs. Index: gcc/tree.h

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Richard Guenther
On Fri, Mar 4, 2011 at 4:10 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Mar 04, 2011 at 04:00:06PM +0100, Richard Guenther wrote: But then location lists for those variables depend on the function context and cannot be shared for different callers.  Am I missing something? Sure

Re: avoid useless if-before-free tests

2011-03-09 Thread Richard Guenther
On Tue, Mar 8, 2011 at 5:34 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/05/11 07:05, Jim Meyering wrote: Hello, Someone asked me about this yesterday, and since I've been carrying this patch series for over a year -- it's not high priority --

Re: fix for pr47837

2011-03-09 Thread Richard Guenther
On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/08/11 11:55, Diego Novillo wrote: On 03/08/2011 12:54 PM, Xinliang David Li wrote: Please review the attached patch, it does some simplification of the complicated logical or

[PATCH][4.7][RFC] Fix store-sinking, make returns have a VUSE

2011-03-09 Thread Richard Guenther
originally worked on this (IIRC it was during stage3 of 4.5). So, this is just a heads-up in case you have any issues with having more virtual operands. If the patch happens to bootstrap and test ok I plan to commit this somewhen during stage1. Richard. 2011-03-09 Richard Guenther rguent

[PATCH][4.7] Fix the issue in PR13954

2011-03-09 Thread Richard Guenther
with the returns-have-VOPs prerequesite. Bootstrapped and tested on x86_64-unknown-linux-gnu. Richard. 2011-03-09 Richard Guenther rguent...@suse.de PR tree-optimization/13954 * tree-ssa-sccvn.c (vn_reference_lookup_3): Look through memcpy and friends. * g++.dg/tree-ssa

Re: fix for pr47837

2011-03-09 Thread Richard Guenther
On Wed, Mar 9, 2011 at 6:34 PM, Xinliang David Li davi...@google.com wrote: On Wed, Mar 9, 2011 at 8:29 AM, Richard Guenther richard.guent...@gmail.com wrote: On Wed, Mar 9, 2011 at 5:24 PM, Xinliang David Li davi...@google.com wrote: On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law l...@redhat.com

Re: 4.5 backport request...

2011-03-10 Thread Richard Guenther
On Wed, Mar 9, 2011 at 11:05 PM, DJ Delorie d...@redhat.com wrote: May I backport this change to 4.5 ?  rx-elf can use this for a performance boost (a separate 4.5 target patch would be needed for that) This doesn't look like a regression fix. The changelog doesn't tell if it is mere

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-10 Thread Richard Guenther
\ -%{flto|flto=*:%fcompare-debug*} \ +%(linker) \ +LINK_PLUGIN_SPEC \ +%{flto|flto=*:%fcompare-debug*} \ %{flto} %{flto=*} %l LINK_PIE_SPEC \ %X %{o*} %{e*} %{N} %{n} %{r}\ %{s} %{t} %{u*} %{z} %{Z} %{!nostdlib:%{!nostartfiles:%S}}\ -- Richard Guenther rguent

Re: [PATCH, testsuite]: Fix PR target/48055; FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c compilation, -O2 -flto

2011-03-10 Thread Richard Guenther
On Thu, Mar 10, 2011 at 1:19 PM, Uros Bizjak ubiz...@gmail.com wrote: Hello! Using binutils-2.21, a couple of gcc.c-torture/execute/builtins/__-chk.c testcases fail on alphaev68-pc-linux-gnu (-lto) with: /usr/lib/gcc/alpha-unknown-linux-gnu/4.4.5/../../../../alpha-unknown-linux-gnu/bin/ld:

Re: [PATCH, testsuite]: Fix PR target/48055; FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c compilation, -O2 -flto

2011-03-10 Thread Richard Guenther
On Thu, Mar 10, 2011 at 3:44 PM, Uros Bizjak ubiz...@gmail.com wrote: On Thu, Mar 10, 2011 at 1:30 PM, Richard Guenther richard.guent...@gmail.com wrote: Using binutils-2.21, a couple of gcc.c-torture/execute/builtins/__-chk.c testcases fail on alphaev68-pc-linux-gnu (-lto) with: /usr/lib

Re: RFA (layout): PATCH for c++/48029 (ICE-on-valid with templates and arrays)

2011-03-10 Thread Richard Guenther
On Thu, Mar 10, 2011 at 3:56 PM, Jason Merrill ja...@redhat.com wrote: On 03/10/2011 04:56 AM, Richard Guenther wrote: Ugh.  Why do we call layout_type on arrays with incomplete element type at all? layout_type has been called from the language-independent build_array_type since the dawn

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-10 Thread Richard Guenther
On Thu, 10 Mar 2011, Rainer Orth wrote: Richard Guenther rguent...@suse.de writes: If I read this patch correctly then 1) it doesn't change the condition under which lto-plugin/ is built (good) Right. 2) it makes -fuse-linker-plugin the default for and only for known

Re: [PATCH, 4.6] Do not create new cgraph noes in the verifier

2011-03-11 Thread Richard Guenther
@@ verify_cgraph_node (struct cgraph_node * error_found = true; } - if (!cgraph_node (node-decl)) + if (!cgraph_get_node (node-decl)) { error (node not found in cgraph_hash); error_found = true; -- Richard Guenther rguent...@suse.de Novell / SUSE Labs SUSE LINUX

Re: [PATCH][C] Fix PR47939

2011-03-11 Thread Richard Guenther
On Thu, 10 Mar 2011, Joseph S. Myers wrote: On Wed, 2 Mar 2011, Richard Guenther wrote: 2011-03-02 Richard Guenther rguent...@suse.de PR c/47939 * c-decl.c (grokdeclarator): Drop to the main variant only for array types. Drop flag_gen_aux_info check. I can't

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-11 Thread Richard Guenther
On Thu, 10 Mar 2011, Rainer Orth wrote: Richard Guenther rguent...@suse.de writes: Can we to fix 46944 change the dejagnu require-linker-plugin to check if a linker plugin is used by default and not add -fuse-linker-plugin? That might be involved since it requires parsing gcc -Wl

Re: [PATCH 01/18] add typed_tree structure

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd froy...@codesourcery.com wrote: The first step in removing TREE_CHAIN (and even TREE_TYPE) from a select few nodes is to create separate substructures for trees-with-type and trees-with-chain.  Since trees-with-type but no chain are expected to be

Re: [PATCH 05/18] remove TREE_CHAIN from CONSTRUCTOR nodes

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd froy...@codesourcery.com wrote: A straightforward conversion. Ok for 4.7. Thanks, Richard. -Nathan gcc/        * tree.h (struct tree_constructor): Include typed_tree instead of        tree_common.        * tree.c

Re: [PATCH 03/18] remove TREE_CHAIN from *_CST nodes

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd froy...@codesourcery.com wrote: *_CST nodes don't need TREE_CHAIN.  Make them include typed_tree instead, mark them as such in initialize_tree_contains_struct, and don't print out their TREE_CHAIN. Ok for 4.7 if it bootstraps and tests for all

Re: [PATCH 06/18] define CASE_CHAIN accessor for CASE_LABEL_EXPR

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd froy...@codesourcery.com wrote: This patch begins a subseries of patches aimed at removing TREE_CHAIN from expression trees.  tree-cfg.c uses TREE_CHAIN for some analysis steps on CASE_LABEL_EXPRs.  I looked at this for a while, thinking it'd be

Re: [PATCH 12/18] make CASE_LABEL_EXPR not abuse TREE_CHAIN

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd froy...@codesourcery.com wrote: Move CASE_CHAIN into a local operand for CASE_LABEL_EXPR.  Nothing to see here. I wonder if there isn't a better way to do this ... like always requiring operand 2 of SWITCH_EXPRs. Richard. -Nathan gcc/        *

Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd froy...@codesourcery.com wrote: Now that we have a structure where not every node might include TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said accessors that the argument is properly typed.  This requires a number of changes:

Re: [PATCH, 4.7] Have all inlining destinations analyzed

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 10:58 AM, Martin Jambor mjam...@suse.cz wrote: Hi, after I simply moved id-dst_node-analyzed check from expand_call_inline to optimize_inline_calls I tried asserting it there instead.  When running testsuite I found out this works for everything but mudflap which adds

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-11 Thread Richard Guenther
On Fri, 11 Mar 2011, Rainer Orth wrote: Richard Guenther rguent...@suse.de writes: Still doesn't work for me if compiling and linking manually with GNU ld 2.21 on Solaris 11/x86: no .res file is being created, although liblto_plugin.so is used. Work as in, it detects if -fuse-linker

Re: fix for pr47837

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 8:50 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/11 09:24, Xinliang David Li wrote: On Wed, Mar 9, 2011 at 6:03 AM, Jeff Law l...@redhat.com wrote: On 03/09/11 02:45, Richard Guenther wrote: On Tue, Mar 8, 2011 at 11:04

Re: [PATCH] Fix PR47127: call cloog_state_malloc and cloog_state_free only once.

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 10:38 PM, Sebastian Pop seb...@gmail.com wrote: Hi, we currently call cloog_state_malloc and cloog_state_free too many times.  In CLooG-Parma, these functions contain the init and fini functions of PPL, and so calling these in the middle of graphite would finalize all

Re: fix for pr47837

2011-03-14 Thread Richard Guenther
wrote: On 03/09/11 02:45, Richard Guenther wrote: On Tue, Mar 8, 2011 at 11:04 PM, Jeff Law l...@redhat.com wrote: True.  I've been repeatedly thinking of building some on-the-side CFG with value-numbered predicates to also catch the CFG vs. scalar-code predicate combinations we have

[PATCH] Fix PR48031

2011-03-15 Thread Richard Guenther
is out). Tested on m68k by Mikael. Richard. 2011-03-15 Richard Guenther rguent...@suse.de PR middle-end/48031 * fold-const.c (fold_indirect_ref_1): Do not create new variable-sized or variable-indexed array accesses when in gimple form. Index: gcc/fold-const.c

[PATCH] Fix PR41490

2011-03-15 Thread Richard Guenther
This fixes store-sinking (finally, broken since alias-improvements merge). To work reliably this adds an unconditional VUSE to all return statements. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-15 Richard Guenther rguent...@suse.de PR

[PATCH] Fix part of PR48037

2011-03-15 Thread Richard Guenther
to trunk. Richard. 2011-03-15 Richard Guenther rguent...@suse.de PR tree-optimization/48037 * tree-ssa.c (maybe_rewrite_mem_ref_base): Rewrite vector selects into BIT_FIELD_REFs. (non_rewritable_mem_ref_base): Check if a MEM_REF is a vector select

Re: [PATCH] Fix part of PR48037

2011-03-16 Thread Richard Guenther
On Tue, 15 Mar 2011, Andrew Pinski wrote: On Tue, Mar 15, 2011 at 5:19 AM, Richard Guenther rguent...@suse.de wrote: This avoids spilling SSE registers to memory just because we access vector components in a C array way.  The trick is to simply rewrite those accesses to proper vector

Re: [PATCH] Fix fallout of my fold_binary EQ/NE patch (PR middle-end/48136)

2011-03-16 Thread Richard Guenther
On Tue, Mar 15, 2011 at 8:41 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! The addition of STRIP_NOPS for EQ_EXPR/NE_EXPR revealed a bunch of cases which rely on arg0 and arg1 having the same type.  Only the last hunk fixes the testcase, the rest is what I saw and it was possible the types

Re: [PATCH][4.5] Fix backport of PR 47862 to 4.5 branch

2011-03-16 Thread Richard Guenther
On Tue, Mar 15, 2011 at 9:07 PM, Pat Haugen pthau...@linux.vnet.ibm.com wrote: The following changes are already present on trunk as part of the fix for PR44364. Not having them on 4.5 caused problems with the subject fix when trying to spill FP regs with a stack 32K. Bootstrap/regtest 4.5

Re: Minor VRP jump threading improvement

2011-03-16 Thread Richard Guenther
On Tue, Mar 15, 2011 at 10:37 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I noticed that VRP was missing many obvious jump threading opportunities; investigation showed that it wasn't threading through conditionals with pointer types, just those with

[PATCH] Prepare for constant folder canonicalizations

2011-03-16 Thread Richard Guenther
This prepares things to share constant folding between passes (CCP, FRE and VRP). It simplifies maybe_fold_reference making sure to first canonicalize MEM_REFs and then call other folders. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-16 Richard

Re: [PATCH] Fix RTL DSE compile time hog (PR rtl-optimization/48141)

2011-03-16 Thread Richard Guenther
On Wed, Mar 16, 2011 at 12:52 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Mar 16, 2011 at 09:46:20AM +0100, Paolo Bonzini wrote: On 03/16/2011 12:12 AM, Kenneth Zadeck wrote: so how much time does this save? I agree that this is a useful simplification, but it seems unlikely to be

[PATCH] Fix PR48146

2011-03-16 Thread Richard Guenther
, applied to trunk. Richard. 2011-03-16 Richard Guenther rguent...@suse.de PR tree-optimization/48146 * tree-ssa-sink.c (sink_code_in_bb): Manually update virtual operands avoiding the need for renaming. * gcc.dg/torture/pr48146.c: New testcase. Index: gcc/tree

Re: [PATCH] renable lto on darwin9

2011-03-16 Thread Richard Guenther
On Wed, 16 Mar 2011, Jack Howarth wrote: The assembler bug in Xcode 3.2.6/4.0 only impacts darwin10, so lto can be renabled for darwin9 (for which it has been well tested on the regress server). Re-enabling lto for *-apple-darwin9 on darwin allows us to continue to monitor the status of

[PATCH] Fix parts of PR48149

2011-03-16 Thread Richard Guenther
. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-16 Richard Guenther rguent...@suse.de PR tree-optimization/48149 * fold-const.c (fold_binary_loc): Fold COMPLEX_EXPR REALPART_EXPR x, IMAGPART_EXPR x. * gcc.dg/fold-complex-1.c

Re: [patch] Enhance conditional store sinking

2011-03-17 Thread Richard Guenther
On Wed, Mar 16, 2011 at 12:47 PM, Ira Rosen ira.ro...@linaro.org wrote: On 16 March 2011 12:29, Richard Guenther richard.guent...@gmail.com wrote: On Wed, Mar 16, 2011 at 7:49 AM, Ira Rosen ira.ro...@linaro.org wrote: Hi, This patch adds a support of conditional store sinking for cases

[PATCH] Fix PR48134

2011-03-17 Thread Richard Guenther
This fixes PR48134, when propagating into debug-stmts we should fold them, like we do elsewhere. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-17 Richard Guenther rguent...@suse.de PR middle-end/48134 * tree-ssa.c

Re: [patch] Enhance conditional store sinking

2011-03-17 Thread Richard Guenther
On Thu, Mar 17, 2011 at 3:53 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/17/11 08:48, Richard Guenther wrote: The gimple_uids are not initialized here, you need to make sure to call renumber_gimple_stmt_uids () before starting.  Note that phiopt

[PATCH][RFC] Unify constant folding

2011-03-17 Thread Richard Guenther
worth the few extra copies. Tried re-bootstrapping and testing the following variant, but bootstrap is currently broken. Thanks, Richard. 2011-03-17 Richard Guenther rguent...@suse.de PR tree-optimization/46562 * tree.c (build_invariant_address): New function. * tree.h

Re: PATCH: PR target/48171: Missing Save on -mavx and -mfma

2011-03-18 Thread Richard Guenther
On Thu, Mar 17, 2011 at 7:42 PM, Uros Bizjak ubiz...@gmail.com wrote: On Thu, Mar 17, 2011 at 6:51 PM, H.J. Lu hongjiu...@intel.com wrote: All i386 ISA options, except for -mavx and -mfma, have Save.  This patch fixes it.  OK for trunk and 4.6? 2011-03-17  H.J. Lu  hongjiu...@intel.com    

Re: [PATCH] Fix hppa-* --enable-checking=release bootstrap (PR bootstrap/48161)

2011-03-18 Thread Richard Guenther
On Thu, Mar 17, 2011 at 11:38 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Mar 17, 2011 at 09:07:43PM +0100, Jakub Jelinek wrote: The following fixes the testcase in cross to hppa-* as well. I'll bootstrap/regtest it momentarily, ok if it passes? Now bootstrapped/regtested on

Re: [PATCH][C] Fix PR47939

2011-03-18 Thread Richard Guenther
On Fri, 11 Mar 2011, Joseph S. Myers wrote: On Fri, 11 Mar 2011, Richard Guenther wrote: Indeed. I tried to let the array case alone (because it's so complicated) but failed to do so. Appearantly if (declarator-kind == cdk_array TYPE_QUALS (element_type)) type

[PATCH] Document --with-plugin-ld

2011-03-18 Thread Richard Guenther
This documents --with-plugin-ld and removes the --enable-gold documentation (which is bogus now). Does this look ok? Thanks, Richard. 2011-03-18 Richard Guenther rguent...@suse.de * doc/install.texi (--enable-gold): Remove. (--with-plugin-ld): Document. * doc

[PATCH][RFC] Add gimple_fold

2011-03-18 Thread Richard Guenther
(revision 0) --- gcc/gimple-fold.h (revision 0) *** *** 0 --- 1,39 + /* Gimple folding definitions. + +Copyright 2011 Free Software Foundation, Inc. +Contributed by Richard Guenther rguent...@suse.de + + This file is part of GCC. + + GCC is free software; you can

Re: [testsuite] Skip gcc.dg/torture/20090618-1.c on IRIX (PR middle-end/47405)

2011-03-18 Thread Richard Guenther
-if { *-*-* } { -O0 } { } } */ +/* { dg-skip-if PR middle-end/47405 { mips-sgi-irix* } } */ extern void abort (void); -- Richard Guenther rguent...@suse.de Novell / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex

Re: [PATCH] Document --with-plugin-ld

2011-03-18 Thread Richard Guenther
On Fri, 18 Mar 2011, Rainer Orth wrote: Richard Guenther rguent...@suse.de writes: --- 1666,1676 Enable support for link-time optimization (LTO). This is enabled by default, and may be disabled using @option{--disable-lto}. ! @item --with-plugin-ld=@var{pathname

Re: [PATCH] Document --with-plugin-ld

2011-03-20 Thread Richard Guenther
On Sat, Mar 19, 2011 at 7:06 PM, Gerald Pfeifer ger...@pfeifer.com wrote: On Fri, 18 Mar 2011, Richard Guenther wrote: ! @item --with-plugin-ld=@var{pathname} ! Enable an alternate linker to be used at link-time optimization (LTO) ! link time when @option{-fuse-linker-plugin} is enabled. I

Re: [patch] Fix PR48183, NEON ICE in emit-rtl.c:immed_double_const() under -g

2011-03-20 Thread Richard Guenther
On Sun, Mar 20, 2011 at 12:01 PM, Chung-Lin Tang clt...@codesourcery.com wrote: Hi, PR48183 is a case where ARM NEON instrinsics, under -O -g, produce debug insns that tries to expand OImode (32-byte integer) zero constants, much too large to represent as two HOST_WIDE_INTs; as the internals

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-21 Thread Richard Guenther
On Mon, 21 Mar 2011, Rainer Orth wrote: Richard Guenther rguent...@suse.de writes: On Fri, 18 Mar 2011, Rainer Orth wrote: Richard Guenther richard.guent...@gmail.com writes: It seemed to have disabled linker-plugin support for old binutils with --with-plugin-ld=/usr/local/bin

Re: [doc] Improve Perl requirements documentation (PR bootstrap/48135)

2011-03-21 Thread Richard Guenther
for the GCC source code. -- Richard Guenther rguent...@suse.de Novell / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex

Re: [patch] Couple of tweaks to the gimplifier

2011-03-21 Thread Richard Guenther
On Mon, Mar 21, 2011 at 12:19 PM, Eric Botcazou ebotca...@adacore.com wrote: Hi, the attached patch makes a couple of tweaks to the gimplifier in order to help Ada, but I think that they are of general usefulness:  1) Set TREE_THIS_NOTRAP on the INDIRECT_REF built for VLA decls.  This is    

Re: [build] Honor --disable-symvers (PR bootstrap/48135)

2011-03-21 Thread Richard Guenther
On Mon, 21 Mar 2011, Rainer Orth wrote: Richard Guenther richard.guent...@gmail.com writes: Ok for 4.7, RMs should decide about 4.6.1. Applied, thanks.  It would be nice to get into 4.6 (even 4.6.1) since otherwise install.texi which claims --disable-symvers as a workaround lies

[PATCH] Fix PR48210

2011-03-21 Thread Richard Guenther
Pretty obvious, require at least 1 partition. Richard. 2011-03-31 Richard Guenther rguent...@suse.de PR lto/48210 * params.def (lto-partitions): Require at least 1 partition. Index: gcc/params.def === --- gcc

[PATCH] Weaken PR47661

2011-03-21 Thread Richard Guenther
Richard Guenther rguent...@suse.de PR middle-end/47661 * gimple.c (is_gimple_condexpr): Use tree_could_throw_p. Index: gcc/gimple.c === --- gcc/gimple.c(revision 171142) +++ gcc/gimple.c(working copy

Re: [PATCH] Fix PR48210

2011-03-21 Thread Richard Guenther
On Mon, 21 Mar 2011, Joseph S. Myers wrote: On Mon, 21 Mar 2011, Rainer Orth wrote: Richard Guenther rguent...@suse.de writes: Index: gcc/params.def === --- gcc/params.def(revision 171229) +++ gcc

Re: [PATCH] Fix PR48210

2011-03-21 Thread Richard Guenther
On Mon, 21 Mar 2011, Rainer Orth wrote: Richard Guenther rguent...@suse.de writes: DEFPARAM (MIN_PARTITION_SIZE, lto-min-partition, - Size of minimal paritition for WHOPR (in estimated instructions), + Minimal size of a paritition for LTO (in estimated instructions

[PATCH] More ternary RHS, less single

2011-03-21 Thread Richard Guenther
, testing in progress. I plan to commit this tomorrow if there are no complaints. Richard. 2011-03-21 Richard Guenther rguent...@suse.de * gimple.c (gimple_rhs_class_table): POLYNOMIAL_CHREC is not a valid RHS. Make DOT_PROD_EXPR and REALIGN_LOAD_EXPR ternary. * tree-cfg.c

Re: [patch] Couple of tweaks to the gimplifier

2011-03-22 Thread Richard Guenther
On Mon, Mar 21, 2011 at 6:48 PM, Eric Botcazou ebotca...@adacore.com wrote:  1) Set TREE_THIS_NOTRAP on the INDIRECT_REF built for VLA decls.  This is correct since stack memory isn't considered as trapping in the IL. This is ok. Thanks.  2) Improve gimplification of complex conditions

[PATCH] Fix PR48228

2011-03-22 Thread Richard Guenther
Boostrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-22 Richard Guenther rguent...@suse.de PR tree-optimization/48228 * tree-vrp.c (vrp_visit_phi_node): Do not stop propagating for single-arg PHIs. * gcc.dg/Wstrict-overflow

Re: Fix some LTO -fPIC testcases

2011-03-22 Thread Richard Guenther
On Tue, Mar 22, 2011 at 4:17 PM, Bernd Schmidt ber...@codesourcery.com wrote: On targets where -fpic/-fPIC produce an error, we currently fail a large number of LTO testcases. These should be using the appropriate dg-require-effective-target so that they don't get run. Ok? Ok. Thanks,

Re: [doc patch] fix PRs 48179, 48221 and 48234

2011-03-23 Thread Richard Guenther
On Tue, Mar 22, 2011 at 11:28 PM, Jonathan Wakely jwakely@gmail.com wrote: This fixes three bugs reported against the docs generated from the 4.6.0 RC. 48179 and 48234 are caused by a @section appearing in a different order compared to the order they apepar in the @menu, so the order of

[PATCH] Fixup stdarg handling with MEM_REF style pointer bumps

2011-03-23 Thread Richard Guenther
on x86_64-unknown-linux-gnu together with early FRE. Now re-bootstrapping and testing w/o that. I'm planning to commit this after that testing finished. Thanks, Richard. 2011-03-23 Richard Guenther rguent...@suse.de * tree-stdarg.c (va_list_counter_bump): Handle bumps via MEM_REF

[PATCH] Remove ipa-struct-reorg and ipa-type-escape

2011-03-23 Thread Richard Guenther
IPA struct reorg has been un-enableable on the 4.6 branch for half a year now. This completes this disabling by removing it and IPA type escape analysis which it is the only remaining user of. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2011-03-23 Richard Guenther

[PATCH] Add FRE pass to the early optimization pipeline

2011-03-23 Thread Richard Guenther
-reorg should be handled separately from this patch. Bootstrapped and tested on x86_64-unknown-linux-gnu (with the stdarg patch applied). Richard. 2011-02-23 Richard Guenther rguent...@suse.de * passes.c (init_optimization_passes): Add FRE pass after early SRA

Re: [PATCH] Remove ipa-struct-reorg and ipa-type-escape

2011-03-23 Thread Richard Guenther
On Wed, 23 Mar 2011, Richard Guenther wrote: IPA struct reorg has been un-enableable on the 4.6 branch for half a year now. This completes this disabling by removing it and IPA type escape analysis which it is the only remaining user of. Bootstrap and regtest running on x86_64-unknown

[PATCH] Fix PR48193 and dups

2011-03-23 Thread Richard Guenther
constraints on the region we outline, so you might want to provide a better fix? Thanks, Richard. 2011-03-23 Richard Guenther rguent...@suse.de PR tree-optimization/48193 * ipa-slit.c (split_function): Properly rename the reaching VDEF. Index: gcc/ipa-split.c

Re: [patch] Enhance conditional store sinking

2011-03-23 Thread Richard Guenther
On Tue, Mar 22, 2011 at 2:28 PM, Ira Rosen ira.ro...@linaro.org wrote: On 17 March 2011 16:48, Richard Guenther richard.guent...@gmail.com wrote: +  then_datarefs = VEC_alloc (data_reference_p, heap, 1); +  else_datarefs = VEC_alloc (data_reference_p, heap, 1); +  then_ddrs = VEC_alloc (ddr_p

Re: [lto] Minor cleanups, export some functions (issue4272068)

2011-03-24 Thread Richard Guenther
On Wed, Mar 23, 2011 at 10:24 PM, Diego Novillo dnovi...@google.com wrote: This patch has a few cleanups and exports 5 functions from the LTO streamer that we are using from PPH. - When calling output_string_with_length, every caller would first  write a 0 to indicate that the string is not

Re: [doc patch] obvious partial fix for other/48254

2011-03-24 Thread Richard Guenther
On Wed, Mar 23, 2011 at 11:03 PM, Jonathan Wakely jwakely@gmail.com wrote: Committed to 4.4 and 4.5 branches as obvious, will apply to 4.6 after 4.6.0 is released. The option's gone on the trunk so not relevant there. If you apply anything to 4.6 it should probably simply change the docs

Re: [patch] Enhance conditional store sinking

2011-03-24 Thread Richard Guenther
On Thu, Mar 24, 2011 at 11:03 AM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Mar 22, 2011 at 6:28 AM, Ira Rosen ira.ro...@linaro.org wrote: On 17 March 2011 16:48, Richard Guenther richard.guent...@gmail.com wrote: +  then_datarefs = VEC_alloc (data_reference_p, heap, 1); +  else_datarefs

Re: [patch] Enhance conditional store sinking

2011-03-24 Thread Richard Guenther
On Thu, Mar 24, 2011 at 1:39 PM, Richard Guenther richard.guent...@gmail.com wrote: On Thu, Mar 24, 2011 at 11:03 AM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Mar 22, 2011 at 6:28 AM, Ira Rosen ira.ro...@linaro.org wrote: On 17 March 2011 16:48, Richard Guenther richard.guent...@gmail.com

[PATCH] Fix PR48269

2011-03-24 Thread Richard Guenther
This removes a double-accounting for MEM_REF offsets. The code still looks somewhat fishy, but at least is consistent in what it does now ;) Bootstrapped and tested on x86_64-unknonw-linux-gnu, applied to trunk. Richard. 2011-03-24 Richard Guenther rguent...@suse.de PR middle-end

Re: [patch] Preserve source location in folder

2011-03-24 Thread Richard Guenther
On Thu, Mar 24, 2011 at 3:38 PM, Eric Botcazou ebotca...@adacore.com wrote: Hi, when fold_ternary_loc is attempting to make the tree prettier, e.g. by swapping the arguments of a COND_EXPR, it does:  tem = fold_truth_not_expr (loc, arg0); Now LOC is the location that will be put on the

Re: [testsuite] Mark gcc.dg/graphite/block-[3478].c as expensive (PR testsuite/48283)

2011-03-25 Thread Richard Guenther
-effective-target size32plus } */ +/* { dg-require-effective-target run_expensive_tests } PR testsuite/48283 */ #define DEBUG 0 #if DEBUG -- Richard Guenther rguent...@suse.de Novell / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex

[PATCH] Baby-step for cleaning up the gimple verifier(s)

2011-03-25 Thread Richard Guenther
that the core verifiers work on all forms of gimple, properly guarding/extending parts with IL properties is also on the list of things to do. So is dropping conditionalizing/separating type checking. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-25 Richard

Re: [testsuite] Fix gcc.dg/torture/pr47917.c on IRIX 6.5

2011-03-25 Thread Richard Guenther
On Fri, Mar 25, 2011 at 4:27 PM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: The new gcc.dg/torture/pr47917.c test currently fails the execution test on IRIX 6.5.  To get a C99-conformant snprintf, one needs to include stdio.h with _XOPEN_SOURCE defined as 500.  The following patch does

Re: [wwwdocs] Add Subversion revisions to the timeline

2011-03-26 Thread Richard Guenther
On Sat, Mar 26, 2011 at 11:01 AM, Florian Weimer f...@deneb.enyo.de wrote: Would something like this be useful? --- develop.html.~1.114.~       2011-03-26 10:44:52.0 +0100 +++ develop.html        2011-03-26 10:58:49.311173994 +0100 @@ -434,13 +434,13 @@        |                      

Re: [wwwdocs] Add Subversion revisions to the timeline

2011-03-26 Thread Richard Guenther
On Sat, Mar 26, 2011 at 6:29 PM, Michael Matz m...@suse.de wrote: Hi, On Sat, 26 Mar 2011, Richard Guenther wrote:   GCC 4.7 Stage 1 (starts 2011-03-14)      GCC 4.6.0 release (2011-03-25) -       | +       | r171512        |        v The idea is to include the copy-source

Re: Improve jump threading #1 of N

2011-03-26 Thread Richard Guenther
On Fri, Mar 25, 2011 at 5:30 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've been doing some research into improving certain aspects of our warnings, particularly removing false positives from the warnings which require dataflow information.  I think

Re: [patch] Fix bogus source locations with optimization

2011-03-28 Thread Richard Guenther
On Mon, Mar 28, 2011 at 11:00 AM, Eric Botcazou ebotca...@adacore.com wrote: Hi, when optimization is enabled, especially -O2 and above, you can have lines in the assembly file with really bogus source location info.  The scenario is as follows: an optimization pass at the Tree level

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-28 Thread Richard Guenther
On Mon, Mar 28, 2011 at 12:14 PM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Richard Guenther richard.guent...@gmail.com writes: I think if the plugin linker is different from the normal linker we should set HAVE_LTO_PLUGIN to 2. I think we should do the linker version checks which

Re: [patch] Fix bogus source locations with optimization

2011-03-28 Thread Richard Guenther
On Mon, Mar 28, 2011 at 1:08 PM, Eric Botcazou ebotca...@adacore.com wrote: This overloads UNKNOWN_LOCATION for both insn_locator and source_location, I don't think this is the best idea.  It'll eventually break when compiling with C++ anyway. Could you elaborate?  UNKNOWN_LOCATION isn't used

Re: [patch] plug mem leak in gcse

2011-03-28 Thread Richard Guenther
On Mon, Mar 28, 2011 at 3:29 PM, Steven Bosscher stevenb@gmail.com wrote: Hi, The bitmap reg_set_bitmap is allocated in alloc_gcse_mem, but it is never freed. The foul smell of a mem leak... Plugged thus. Bootstrappedtested on x86_64-unknown-linux-gnu. OK for trunk? Ok. Thanks,

Re: Use gen_int_mode in expand_builtin_memset_args

2011-03-28 Thread Richard Guenther
On Mon, Mar 28, 2011 at 5:47 PM, Richard Sandiford richard.sandif...@linaro.org wrote: This patch fixes a case where expand_builtin_memset_args was creating a zero- rather than sign-extended character-sized CONST_INT.  The problem showed up on s390, where a character was being passed as

Re: [patch] Fix PR48183, NEON ICE in emit-rtl.c:immed_double_const() under -g

2011-03-29 Thread Richard Guenther
On Thu, Mar 24, 2011 at 11:57 AM, Richard Sandiford richard.sandif...@linaro.org wrote: Chung-Lin Tang clt...@codesourcery.com writes: PR48183 is a case where ARM NEON instrinsics, under -O -g, produce debug insns that tries to expand OImode (32-byte integer) zero constants, much too large to

Re: [patch] Fix PR48183, NEON ICE in emit-rtl.c:immed_double_const() under -g

2011-03-29 Thread Richard Guenther
On Tue, Mar 29, 2011 at 1:52 PM, Richard Sandiford richard.sandif...@linaro.org wrote: Richard Guenther richard.guent...@gmail.com writes: On Thu, Mar 24, 2011 at 11:57 AM, Richard Sandiford richard.sandif...@linaro.org wrote: Chung-Lin Tang clt...@codesourcery.com writes: PR48183 is a case

Re: [PATCH] Another EQ/NE folder type fix (PR c/48305)

2011-03-30 Thread Richard Guenther
On Tue, Mar 29, 2011 at 5:53 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! I've left these 4 out because I thought they should be fine given that the other operands are equal.  But the testcase shows I was wrong. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for

Re: [cxx-mem-model] bitfield tests

2011-03-30 Thread Richard Guenther
On Tue, Mar 29, 2011 at 7:00 PM, Aldy Hernandez al...@redhat.com wrote: [Language lawyers, please correct me if I have mis-interpreted the upcoming standard in any way.] In the C++ memory model, contiguous bitfields comprise a single memory location, so it's fair game to bit twiddle them when

Re: [cxx-mem-model] bitfield tests

2011-03-30 Thread Richard Guenther
On Wed, Mar 30, 2011 at 4:11 PM, Aldy Hernandez al...@redhat.com wrote: The memory model is not implementable on strict-alignment targets that do not have a byte store operation.  But we previously said that ;) Yes.  I think we should issue an error when we have such a target and the user

Re: Move reg_equiv* arrays into a single VEC structure

2011-03-30 Thread Richard Guenther
On Wed, Mar 30, 2011 at 4:23 PM, Jeff Law l...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 As originally discussed here: http://gcc.gnu.org/ml/gcc-patches/2010-05/msg00987.html Changes since the original submission: Per Richi's suggestion I changed the patch to use a

[PATCH] Make renumber_gimple_stmt_uids and renumber_gimple_stmt_uids_in_bbs consistent

2011-03-30 Thread Richard Guenther
. 2011-03-30 Richard Guenther rguent...@suse.de * tree-dfa.c (renumber_gimple_stmt_uids): Also number PHIs. * lto-streamer-out.c (output_function): Do not use renumber_gimple_stmt_uids. * lto-streamer-in.c (input_function): Likewise. Index: gcc/tree-dfa.c

Re: [PATCH] Fix expansion issues on type changing MEM_REFs on LHS (PR middle-end/48335)

2011-03-31 Thread Richard Guenther
On Wed, Mar 30, 2011 at 6:05 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! MEM_REFs which can represent type punning on lhs don't force non-gimple types to be addressable.  This causes various problems in the expander, which wasn't prepared to handle that. This patch tries to fix what I've

Re: RFC: PATCH: Remove 26 element limit in vector

2011-03-31 Thread Richard Guenther
On Wed, Mar 30, 2011 at 8:09 PM, H.J. Lu hongjiu...@intel.com wrote: On Wed, Mar 30, 2011 at 08:02:38AM -0700, H.J. Lu wrote: Hi, Currently, we limit XVECEXP to 26 elements in machine description since we use letters 'a' to 'z' to encode them.  I don't see any reason why we can't go beyond

Re: Fix pass49-frag (mudflap support for varargs)

2011-03-31 Thread Richard Guenther
On Wed, Mar 30, 2011 at 11:17 PM, Michael Matz m...@suse.de wrote: Hi, for some reasons the FAIL of pass49-frag now annoyed me enough to look into it, where it didn't do so for the last 50 years it's failing (give or take a few).  mudflap has a mean to mark some expressions as not

Re: [patch][cprop.c] Clean up hash table building

2011-03-31 Thread Richard Guenther
On Thu, Mar 31, 2011 at 12:39 AM, Steven Bosscher stevenb@gmail.com wrote: Hi, This is the first cleanup for cprop.c. These cleanups are only possible now, thanks to splitting the CPROP code out from gcse.c The first change is to not treat unfolded conditions as constant in

Re: Random cleanups [4/4]: Streamlining streamer

2011-03-31 Thread Richard Guenther
On Thu, Mar 31, 2011 at 4:07 AM, Michael Matz m...@suse.de wrote: Hi, I fear I wasn't as thorough in also splitting this one into several patches, but the different cleanups are at least mostly in different files.  They are: * lto-lang remembers all builtin decls in a local list, to be

  1   2   3   4   5   6   7   8   9   10   >