Re: Move DECL_INIT_PRIORITY/FINI_PRIORITY to symbol table

2014-06-20 Thread Trevor Saunders
On Fri, Jun 20, 2014 at 08:41:22AM +0200, Jan Hubicka wrote: Hi, this patch moves init and fini priorities to symbol table instead of trees. They are already in on-side hashtables, but the hashtables are now maintaned by symbol table. This is needed for correctness with LTO. Currently tree

Re: [PATCH 5/5] add libcc1

2014-06-23 Thread Trevor Saunders
On Mon, Jun 23, 2014 at 01:09:41PM -0600, Jeff Law wrote: On 06/20/14 09:33, Tom Tromey wrote: Trevor == Trevor Saunders tsaund...@mozilla.com writes: Trevor I'm curious, what is the reason you choose not to write this in C++11 or Trevor later? Its distributed with gcc, so the only case

Re: [PATCH 3/3] add hash_map class

2014-06-24 Thread Trevor Saunders
On Tue, Jun 24, 2014 at 02:29:53PM +0200, Martin Liška wrote: On 06/20/2014 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This patch adds a hash_map class so we can consolidate the boiler plate around using hash_table as a map, it also allows

Re: [PATCH 3/3] add hash_map class

2014-06-24 Thread Trevor Saunders
On Tue, Jun 24, 2014 at 03:17:46PM +0200, Martin Liška wrote: On 06/24/2014 02:40 PM, Trevor Saunders wrote: On Tue, Jun 24, 2014 at 02:29:53PM +0200, Martin Liška wrote: On 06/20/2014 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This patch

Re: [PATCH 5/5] add libcc1

2014-06-24 Thread Trevor Saunders
On Tue, Jun 24, 2014 at 11:12:38AM -0600, Tom Tromey wrote: Trevor hrm, I know basically nothing about the upcoming changes, but I would Trevor have expected linking c++03 code against c++11 code would be fine Trevor especially when the interface doesn't involve any stl.

Re: [PATCH 3/3] add hash_map class

2014-06-24 Thread Trevor Saunders
On Tue, Jun 24, 2014 at 08:23:49PM +0200, Jan Hubicka wrote: On 06/20/2014 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This patch adds a hash_map class so we can consolidate the boiler plate around using hash_table as a map, it also

Re: bootstrap failure for cygwin, mingw targets due recent changes to hash_table

2014-06-24 Thread Trevor Saunders
On Tue, Jun 24, 2014 at 11:06:33PM +0200, Kai Tietz wrote: Hi Trevor, your recent commits have broken bootstrap for cygwin/mingw i386 targets with: should be fixed in r211962. Sorry I didn't realize the const qualification thing matter in other places, it didn't show up in core gcc so I

Re: [PATCH v2] PR bootstrap/61598

2014-06-25 Thread Trevor Saunders
On Wed, Jun 25, 2014 at 03:00:33PM -0600, Jeff Law wrote: On 06/25/14 10:05, tsaund...@mozilla.com wrote: From: tbsaunde tbsaunde@138bc75d-0d04-0410-961f-82ee72b054a4 Hi, Actually we can just store const tre_node * in the hash table, and actually remove a const cast. bootstrapped with

Re: [PATCH] remove broken and redundant diagnostic in i386_pe_section_type_flags

2014-06-27 Thread Trevor Saunders
On Fri, Jun 27, 2014 at 09:48:00AM +0200, Kai Tietz wrote: Hi Trev, 2014-06-27 1:55 GMT+02:00 tsaund...@mozilla.com: From: Trevor Saunders tsaund...@mozilla.com Hi, While fixing up the hash_table patch's bustedness here I noticed the code doesn't make any sense. What it inserts

Re: [PATCH 3/5] IPA ICF pass

2014-07-01 Thread Trevor Saunders
diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c new file mode 100644 index 000..8a13dca --- /dev/null +++ b/gcc/ipa-icf.c +/* Itializes internal structures according to given number of initialize + if (is_a_helpercgraph_node *::test (node)) shouldn't you just use is_acgraph_node*

Re: More informative ODR warnings

2014-07-02 Thread Trevor Saunders
On Wed, Jul 02, 2014 at 05:15:20PM +0200, Jan Hubicka wrote: Hi, this patch adds structural comparsion into ODR warnings, so we do not rely on types_compatible_p to checks if the individual variants of same name looks same. This allows us to give more precise reason for the mismatch and also

Re: More informative ODR warnings

2014-07-02 Thread Trevor Saunders
On Wed, Jul 02, 2014 at 09:28:03PM +0200, Jan Hubicka wrote: I can't find the code for the SampleFormat thing, but the rest of them look like ODR violations to me. I think it is some define renaming the field, I was also puzled by this one.

Re: Make declaration of wide_int_storage match its definition

2014-07-06 Thread Trevor Saunders
On Sat, Jul 05, 2014 at 09:29:31PM +0200, Jakub Jelinek wrote: On Sat, Jul 05, 2014 at 09:25:50PM +0200, Gerald Pfeifer wrote: On Sat, 5 Jul 2014, pins...@gmail.com wrote: This patch is fine but c++ allows class and struct be used interchangeable. If there is a compilers which does not

Re: [PATCH] remove useless unused attributes in i386 code

2014-07-07 Thread Trevor Saunders
On Mon, Jul 07, 2014 at 11:46:27AM +0200, Richard Biener wrote: On Mon, Jul 7, 2014 at 11:45 AM, Richard Biene richard.guent...@gmail.com wrote: On Thu, Jul 3, 2014 at 1:08 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, So apparently its

Re: [PATCH] remove useless unused attributes in i386 code

2014-07-07 Thread Trevor Saunders
On Mon, Jul 07, 2014 at 09:28:55PM +0200, Richard Biener wrote: On July 7, 2014 9:06:17 PM CEST, Trevor Saunders tsaund...@mozilla.com wrote: On Mon, Jul 07, 2014 at 11:46:27AM +0200, Richard Biener wrote: On Mon, Jul 7, 2014 at 11:45 AM, Richard Biene richard.guent...@gmail.com wrote

Re: [PATCH 1/4] Add an abstract incremental hash data type

2014-07-16 Thread Trevor Saunders
+++ b/gcc/inchash.h +class inchash +{ + hashval_t val; normal style would be explicit private: at the end. + public: + + /* Start incremential hashing, optionally with SEED. */ + void begin (hashval_t seed = 0) + { +val = seed; why isn't this the ctor? + /* Add unsigned

Re: [PATCH 1/4] Add an abstract incremental hash data type

2014-07-17 Thread Trevor Saunders
On Thu, Jul 17, 2014 at 06:36:31AM +0200, Andi Kleen wrote: On Wed, Jul 16, 2014 at 10:40:53PM -0400, Trevor Saunders wrote: + public: + + /* Start incremential hashing, optionally with SEED. */ + void begin (hashval_t seed = 0) + { +val = seed; why isn't

Re: [PATCH 2/2] allow running mklog as a filter

2014-07-21 Thread Trevor Saunders
On Mon, Jul 21, 2014 at 11:49:05AM +0400, Yury Gribov wrote: On 05/09/2014 07:09 PM, Diego Novillo wrote: I slightly prefer the semantics that gets me just the ChangeLog. The workflow I'm envisioning is: I've commited both patches in r212883 and r12884. Mklog now runs as a filter and

Re: [PATCH 1/4] Add an abstract incremental hash data type

2014-07-23 Thread Trevor Saunders
On Thu, Jul 24, 2014 at 02:00:24AM +0200, Oleg Endo wrote: On Wed, 2014-07-23 at 11:37 +0200, Richard Biener wrote: On Fri, Jul 18, 2014 at 3:08 AM, Trevor Saunders tsaund...@mozilla.com wrote: On Thu, Jul 17, 2014 at 06:36:31AM +0200, Andi Kleen wrote: On Wed, Jul 16, 2014 at 10:40

Re: [PATCH 2/2] allow running mklog as a filter

2014-07-28 Thread Trevor Saunders
On Mon, Jul 28, 2014 at 10:42:51AM +0400, Yury Gribov wrote: On 07/21/2014 12:55 PM, Trevor Saunders wrote: I'm not really sure which is the better UI, but I'd rather time be spent on better automatic change log generation. Yeah. Do you have some particular complaints btw? I haven't

Re: [PATCH 2/2] allow running mklog as a filter

2014-07-28 Thread Trevor Saunders
On Mon, Jul 28, 2014 at 06:29:22PM +0400, Yury Gribov wrote: On 07/28/2014 03:01 PM, Trevor Saunders wrote: Yeah. Do you have some particular complaints btw? I haven't actually used it in a while, but istr there's an issue where if you change the prototype of a function mklog makes an entry

Re: [PATCH] Making it easier to set breakpoints in gdb on pass-execute methods

2014-07-29 Thread Trevor Saunders
On Tue, Jul 29, 2014 at 04:44:29PM -0400, David Malcolm wrote: A complaint I heard at Cauldron with the C++ification of GCC passes is that it's become much more difficult to set breakpoints on the execute hooks of a pass, now that the passes are classes within anonymous namespaces. Well, its

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: On 2014.11.13 at 15:11 +0100, mliska wrote: Just two remarks: +template class T +class GTY((user)) cgraph_summary T * +{ +public: + /* Default construction takes SYMTAB as an argument. */ + cgraph_summary

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 11:23:31PM +0100, Markus Trippelsdorf wrote: On 2014.11.14 at 01:19 -0500, Trevor Saunders wrote: On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: On 2014.11.13 at 15:11 +0100, mliska wrote: + /* Destructor. */ + virtual

Re: [PATCH 1/5] add an alternative to if_marked using hash_table

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 05:27:13PM -0700, Jeff Law wrote: On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This adds a gty cache attribute that calls user code after marking and before sweeping allowing user code to mark more objects

Re: [PATCH 5/5] use vec in lto_tree_ref_table

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 05:52:51PM -0700, Jeff Law wrote: On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, gengtype fails to create valid user marking functions for this type, which is fixed by using vec here (which seems cleaner anyway

Re: [PATCH 4/5] remove param$N_is usage

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 05:49:47PM -0700, Jeff Law wrote: On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, The only user of this is splay_tree. We only have a couple splay trees in ggc memory, and it wasn't clear to me any of them were

Re: [PATCH 2/5] remove the remaining uses of if_marked

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 05:32:08PM -0700, Jeff Law wrote: On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, $subject. bootstrapped + regtested x86_64-unknown-linux-gnu, ok? Trev ada/ * gcc-interface/decl.c, gcc-interface

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-13 Thread Trevor Saunders
On Fri, Nov 14, 2014 at 12:40:23AM +0100, Jan Hubicka wrote: Hello, in general I like this addition - I was not aware that sreal has no support for negative values. This would be serious maintainance burden if sreals was used for profile updating - it is very easy to get negative

Re: [PATCH 4/4] Data structure is used for inline_summary struct.

2014-11-18 Thread Trevor Saunders
On Tue, Nov 18, 2014 at 07:59:26PM +0100, Jan Hubicka wrote: Hi, On Tue, Nov 18, 2014 at 04:39:00PM +0100, Jan Hubicka wrote: On Fri, Nov 14, 2014 at 08:59:10PM +0100, Jan Hubicka wrote: b) with GTY, we cannot call destructor Everything in symbol table is

Re: [PATCH 17/21] PR jit/63854: Fix leaking vec in jit

2014-11-19 Thread Trevor Saunders
On Wed, Nov 19, 2014 at 05:46:17AM -0500, David Malcolm wrote: This fixes various leaks of vec buffers seen via valgrind within jit (both recording and playback). Various vec within jit::recording are converted to auto_vec. Various playback::wrapper subclasses containing vec gain a

Re: [PATCH] pr63856 - test case

2014-11-23 Thread Trevor Saunders
Mon Sep 17 00:00:00 2001 From: Trevor Saunders tsaund...@mozilla.com Date: Sun, 23 Nov 2014 01:11:22 -0500 Subject: [PATCH] pr63856 - test case --- gcc/testsuite/gcc.dg/pr63856.c | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/pr63856.c diff --git

Re: [PATCH] pr61324 pr 63649 - fix crash in ipa_comdats

2014-11-25 Thread Trevor Saunders
On Tue, Nov 25, 2014 at 09:59:46PM +0100, Jan Hubicka wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, the interesting symbol in the test case for pr61324 is __GLOBAL__sub_I_s. It refers to nothing, and is called by nothing, however it is kept (I believe because of -fkeep

Re: [PATCH 04/08] PR jit/63854: Remove xstrdup from ipa/cgraph fprintf calls

2014-11-26 Thread Trevor Saunders
On Wed, Nov 26, 2014 at 09:49:52AM -0500, David Malcolm wrote: On Wed, 2014-11-26 at 09:13 +0100, Uros Bizjak wrote: Hello! cgraph*.c and ipa-*.c use xstrdup on strings when dumping them via fprintf, leaking all of the duplicated buffers. Is/was there a reason for doing this?

Re: [PATCH] pr61324 pr 63649 - fix crash in ipa_comdats

2014-11-27 Thread Trevor Saunders
On Tue, Nov 25, 2014 at 09:59:46PM +0100, Jan Hubicka wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, the interesting symbol in the test case for pr61324 is __GLOBAL__sub_I_s. It refers to nothing, and is called by nothing, however it is kept (I believe because of -fkeep

Re: [PATCH] Put all MAINTAINERS email addresses into ...

2014-09-26 Thread Trevor Saunders
On Fri, Sep 26, 2014 at 03:14:16PM +0200, Steven Bosscher wrote: On Fri, Sep 26, 2014 at 3:09 PM, Segher Boessenkool wrote: On Thu, Sep 25, 2014 at 11:10:00PM +0200, Jan-Benedict Glaw wrote: Resending this email. Seems some spam filter ate it due to the many email addresses... Will now

Re: [PATCH] move many gc hashtab to hash_table

2014-10-10 Thread Trevor Saunders
On Fri, Oct 10, 2014 at 02:26:00PM -0600, Jeff Law wrote: On 10/06/14 21:24, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This changes almost all of the ggc htab that don't use the if_marked option to be hash_tables. I added a for_user gty attribute so

Re: [PATCH] move many gc hashtab to hash_table

2014-10-13 Thread Trevor Saunders
On Mon, Oct 13, 2014 at 09:02:44AM -0700, H.J. Lu wrote: On Mon, Oct 13, 2014 at 8:33 AM, H.J. Lu hjl.to...@gmail.com wrote: On Fri, Oct 10, 2014 at 1:44 PM, Trevor Saunders tsaund...@mozilla.com wrote: On Fri, Oct 10, 2014 at 02:26:00PM -0600, Jeff Law wrote: On 10/06/14 21:24, tsaund

Re: [PATCH] support ggc hash_map and hash_set

2014-10-14 Thread Trevor Saunders
On Tue, Oct 14, 2014 at 04:05:25PM +0200, Richard Biener wrote: On Tue, Sep 2, 2014 at 3:56 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, There are still some issues to make this work really nicely, but this part is probably good enough its worth

Re: [PATCH][4/n] Merge from match-and-simplify, hook into fold-const.c

2014-10-16 Thread Trevor Saunders
On Thu, Oct 16, 2014 at 09:14:18PM +0200, Jakub Jelinek wrote: On Thu, Oct 16, 2014 at 06:58:25PM +, Sebastian Pop wrote: Richard Biener wrote: To give you an example how it looks like, the following code is generated for /* fold_negate_exprs convert - (~A) to A + 1. */

Re: [PATCH] remove score-* support

2014-10-16 Thread Trevor Saunders
On Thu, Oct 16, 2014 at 11:45:37PM +0200, Matthias Klose wrote: Am 03.10.2014 um 17:35 schrieb Jeff Law: On 10/03/14 08:50, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, It was obsoleted back in 2011, so we're good to remove it. bootstrapped

merged trunk into gimple-front-end

2014-04-02 Thread Trevor Saunders
Hi, I just merged trunk r209020 into the gimple-front-end branch, please tell me if you see anything busted ;) I successfully bootstrapped the merge including building the gimple front end and its few tests passed. Trev signature.asc Description: Digital signature

Re: [PATCH 1/6] remove properties stuff from register_dump_files_1

2014-04-17 Thread Trevor Saunders
On Thu, Apr 17, 2014 at 10:53:07AM +0200, Richard Biener wrote: On Thu, Apr 17, 2014 at 10:37 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, just removing some dead code. bootstrapped + regtested against r209414 on x86_64-unknown-linux-gnu, ok

Re: [PATCH 02/89] Introduce gimple_switch and use it in various places

2014-04-21 Thread Trevor Saunders
--- a/gcc/tree-loop-distribution.c +++ b/gcc/tree-loop-distribution.c @@ -687,8 +687,9 @@ generate_loops_for_partition (struct loop *loop, partition_t partition, } else if (gimple_code (stmt) == GIMPLE_SWITCH) { + gimple_switch

Re: [PATCH 22/89] Introduce gimple_goto

2014-04-22 Thread Trevor Saunders
On Mon, Apr 21, 2014 at 12:56:53PM -0400, David Malcolm wrote: gcc/ * coretypes.h (gimple_goto): New typedef. (const_gimple_goto): New typedef. * gimple.h (gimple_statement_goto): New subclass of gimple_statement_with_ops, adding the invariant that stmt-code

Re: [PATCH 26/89] Introduce gimple_eh_filter

2014-04-22 Thread Trevor Saunders
On Mon, Apr 21, 2014 at 12:56:57PM -0400, David Malcolm wrote: gcc/ * coretypes.h (gimple_eh_filter): New typedef. (const_gimple_eh_filter): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_eh_filter): New. (gimple_build_eh_filter): Return a

Re: [PATCH 71/89] Concretize gimple_cond_make_{false|true}

2014-04-22 Thread Trevor Saunders
diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp.c index 902b879..62ec9f5 100644 --- a/gcc/tree-vrp.c +++ b/gcc/tree-vrp.c @@ -9517,10 +9517,11 @@ fold_predicate_in (gimple_stmt_iterator *si) else { gcc_assert (gimple_code (stmt) == GIMPLE_COND); + gimple_cond

Re: [PATCH 00/89] Compile-time gimple-checking

2014-04-22 Thread Trevor Saunders
On Tue, Apr 22, 2014 at 09:05:43AM -0400, Andrew MacLeod wrote: On 04/22/2014 04:03 AM, Richard Sandiford wrote: First of all, thanks a lot for doing this. Maybe one day we'll have the same in rtl :-) But... David Malcolm dmalc...@redhat.com writes: In doing the checked downcasts I ran

Re: [PATCH 02/89] Introduce gimple_switch and use it in various places

2014-04-23 Thread Trevor Saunders
On Wed, Apr 23, 2014 at 01:32:24PM -0700, Richard Henderson wrote: On 04/23/2014 12:56 PM, Jeff Law wrote: On 04/22/14 15:38, Richard Henderson wrote: On 04/22/2014 10:13 AM, David Malcolm wrote: On Mon, 2014-04-21 at 18:45 -0400, Trevor Saunders wrote: --- a/gcc/tree-loop-distribution.c

Re: [GSoC] use obstack in parse_c_expr

2014-04-25 Thread Trevor Saunders
On Fri, Apr 25, 2014 at 05:09:57PM +0530, Prathamesh Kulkarni wrote: On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo dnovi...@google.com wrote: Please remember to send patches to gcc-patches. I'm wondering if you couldn't just use std::string here. No need to change one complicated

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Trevor Saunders
On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: Hi, Shall it a good idea to add new warning -Wsizeof-array-argument that warns when sizeof is applied on parameter declared as an array ? Seems reasonable enough. Similar to clang's -Wsizeof-array-argument:

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Trevor Saunders
On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders tsaund...@mozilla.com wrote: On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: Hi, Shall it a good idea to add new warning -Wsizeof-array-argument

Re: [PATCH 1/2] teach mklog to get name / email from git config when available

2014-04-29 Thread Trevor Saunders
On Tue, Apr 29, 2014 at 09:08:50AM +0400, Yury Gribov wrote: Hi Trevor, I think this looks rather useful. sounds great! +if (-d .git) { What about moving default name/addr (with finger, etc.) to else branch? Well, consider the case git doesn't know, that said I could do if (-d .git) {

Re: [PATCH 2/2] allow running mklog as a filter

2014-04-29 Thread Trevor Saunders
On Tue, Apr 29, 2014 at 09:18:39AM +0400, Yury Gribov wrote: +# XXX We should probably accept /dev/stdin or maybe magic autodetection of +# being supposed to get the patch from stdin. +# Can we just set $diff to '-' if @ARGV is empty? sgtm +# In any case if we got the diff on stdin then

Re: [PATCH 5/6] add finalizers to ggc

2014-04-29 Thread Trevor Saunders
On Tue, Apr 29, 2014 at 02:58:11PM +0200, Richard Biener wrote: On Tue, Apr 29, 2014 at 1:08 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This implements finalizers by keeping a list of registered finalizers and after every mark but before sweeping

Re: [PATCH 1/2] teach mklog to get name / email from git config when available

2014-04-29 Thread Trevor Saunders
On Tue, Apr 29, 2014 at 10:39:00AM -0500, seg...@kernel.crashing.org wrote: +# if this is a git tree then take name and email from the git configuration +if (-d .git) { + $gitname = `git config user.name`; + chomp($gitname); + if ($gitname) { + $name = $gitname; + } + +

Re: [PATCH 2/6] don't have gengtype autocreate allocation macros for variably sized types

2014-04-30 Thread Trevor Saunders
On Wed, Apr 30, 2014 at 11:18:18AM +0200, Richard Biener wrote: On Wed, Apr 30, 2014 at 11:04 AM, Laurynas Biveinis laurynas.bivei...@gmail.com wrote: ISTR we went to typed allocs as part of a transition which not fully materialised? Yes. I had plans to replace the call-based GC marker

Re: [PATCH 0/3] Compile-time gimple checking, without typedefs

2014-05-05 Thread Trevor Saunders
On Mon, May 05, 2014 at 01:44:06PM -0600, Jeff Law wrote: On 05/05/14 11:37, Richard Biener wrote: Well, I hope that Andrew doesn't do without a namespace (and I still don't believe in what he tries to achieve without laying proper ground-work throughout the compiler). With a namespace

Re: [SH, committed] add missing function* argument in sh_optimize_sett_clrt::execute

2014-05-05 Thread Trevor Saunders
On Sat, May 03, 2014 at 10:24:31PM +0200, Oleg Endo wrote: Hi, I've committed the attached patch as r210040, which reinstates the RTL pass. Trevor, could you please double check that you haven't missed any other cases in your pass refactoring patches? I have no clue how this happened, I

Re: RFC: Faster for_each_rtx-like iterators

2014-05-07 Thread Trevor Saunders
On Wed, May 07, 2014 at 09:52:49PM +0100, Richard Sandiford wrote: I noticed for_each_rtx showing up in profiles and thought I'd have a go at using worklist-based iterators instead. So far I have three: FOR_EACH_SUBRTX: iterates over const_rtx subrtxes of a const_rtx

Re: RFC: Faster for_each_rtx-like iterators

2014-05-08 Thread Trevor Saunders
On Thu, May 08, 2014 at 07:25:50AM +0100, Richard Sandiford wrote: Trevor Saunders tsaund...@mozilla.com writes: On Wed, May 07, 2014 at 09:52:49PM +0100, Richard Sandiford wrote: I noticed for_each_rtx showing up in profiles and thought I'd have a go at using worklist-based iterators

Re: [PATCH 0/2] Make option-lookup macros explicit

2014-05-09 Thread Trevor Saunders
On Fri, May 09, 2014 at 05:14:45PM -0400, David Malcolm wrote: GCC's code is full of references to options like: static bool gate_vrp (void) { return flag_tree_vrp != 0; } where flag_tree_vrp is actually an autogenerated macro to: global_options.x_flag_tree_vrp This

Re: [PATCH 4/5] add finalizers to ggc

2014-05-17 Thread Trevor Saunders
On Tue, May 13, 2014 at 11:41:46AM +0200, Richard Biener wrote: On Tue, May 13, 2014 at 8:41 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com This implements finalizers by keeping a list of registered finalizers and after every mark but before sweeping check

Re: RFA: speeding up dg-extract-results.sh

2014-05-24 Thread Trevor Saunders
On Sat, May 24, 2014 at 10:14:54AM -0700, Mike Stump wrote: On May 24, 2014, at 4:17 AM, Bernd Schmidt bernds_...@t-online.de wrote: On 02/13/2014 10:18 AM, Richard Sandiford wrote: contrib/ * dg-extract-results.py: New file. * dg-extract-results.sh: Use it if the environment seems

Re: [RFC] Add patch for debugging compiler ICEs

2014-05-27 Thread Trevor Saunders
On Mon, May 26, 2014 at 11:54:04AM +0400, Maxim Ostapenko wrote: Hi, A years ago there was a discussion ( https://gcc.gnu.org/ml/gcc-patches/2004-01/msg02437.html) about debugging compiler ICEs that resulted in a patch from Jakub, which dumps useful information into temporary file, but for

Re: [PATCH] Improve vecauto, N code generation

2014-02-12 Thread Trevor Saunders
On Wed, Feb 12, 2014 at 03:09:17PM +0100, Richard Biener wrote: The following aims to improve code generation for loops like those in tree-ssa-alias.c: auto_vectree, 16 component_refs1; auto_vectree, 16 component_refs2; /* Create the stack of handled components for REF1. */

Re: [PATCH] Improve vecauto, N code generation

2014-02-12 Thread Trevor Saunders
On Wed, Feb 12, 2014 at 04:28:14PM +0100, Richard Biener wrote: On Wed, Feb 12, 2014 at 4:21 PM, Trevor Saunders tsaund...@mozilla.com wrote: On Wed, Feb 12, 2014 at 03:09:17PM +0100, Richard Biener wrote: The following aims to improve code generation for loops like those in tree-ssa

cleaning up and c++ifying bitmaps

2014-02-18 Thread Trevor Saunders
Hi, I've been working on c++ifying bitmaps and while there make them a little faster. My current work is in the tbsaunde/bitmap git branch please look and give comments :) Some interesting differences -745 LOC averaged over 10 runs with a --enable-checking=release g++ on one ~334kloc .i

Re: [RFA jit 2/2] introduce scoped_timevar

2014-03-18 Thread Trevor Saunders
On Tue, Mar 18, 2014 at 08:57:44AM -0600, Tom Tromey wrote: This introduces a new scoped_timevar class. It pushes a given timevar in its constructor, and pops it in the destructor, giving a much simpler way to use timevars in the typical case where they can be scoped. thanks for doing this.

Re: [PATCH] support ggc hash_map and hash_set

2014-09-02 Thread Trevor Saunders
On Tue, Sep 02, 2014 at 10:36:27AM +0200, Richard Biener wrote: On Tue, Sep 2, 2014 at 3:56 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, There are still some issues to make this work really nicely, but this part is probably good enough its worth

[patch] remove picochip

2014-09-04 Thread Trevor Saunders
+ regtested x86_64-unknown-linux-gnu, and checked picochip-elf is nolonger a recognized target. ok? Trev contrib/ChangeLog: 2014-09-04 Trevor Saunders tsaund...@mozilla.com * compare-all-tests: Don't test picochip. * config-list.mk: Likewise. gcc/ChangeLog: 2014-09-04

Re: [PATCH 1/2] add staticly checked label_nuses accessors

2014-09-05 Thread Trevor Saunders
On Fri, Sep 05, 2014 at 10:43:45AM -0600, Jeff Law wrote: On 09/05/14 09:32, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, Doing this means we get to remove a fair chunk of runtime checking. bootstrapped + regtested on x86_64-unknown-linux-gnu

Re: [PATCH 1/2] add staticly checked label_nuses accessors

2014-09-05 Thread Trevor Saunders
On Fri, Sep 05, 2014 at 05:57:13PM -0400, David Malcolm wrote: On Fri, 2014-09-05 at 10:43 -0600, Jeff Law wrote: On 09/05/14 09:32, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, Doing this means we get to remove a fair chunk of runtime checking

Re: Vimrc config with GNU formatting

2014-09-06 Thread Trevor Saunders
On Sat, Sep 06, 2014 at 03:38:31PM +, Yury Gribov wrote: Segher Boessenkool segher at kernel.crashing.org writes: On Fri, Sep 05, 2014 at 07:10:02PM +0400, Yury Gribov wrote: Now I don't quite like the idea of plugin: Anything that will make this enabled automatically will meet a

Re: [PATCH] support ggc hash_map and hash_set

2014-09-09 Thread Trevor Saunders
: From: Trevor Saunders tsaund...@mozilla.com Hi, There are still some issues to make this work really nicely, but this part is probably good enough its worth reviewing. For one thing you can't use ggc hash_map or set in front ends with some types or gengtype will decide to put

Re: [PATCH 1/2] add staticly checked label_nuses accessors

2014-09-11 Thread Trevor Saunders
On Thu, Sep 11, 2014 at 02:55:43PM -0600, Jeff Law wrote: On 09/05/14 16:38, Trevor Saunders wrote: So, in this case it seems to me you basically have two options A. change the macro to an inline function, and fix up all the callers to pass the right type. Then rebase that into some sort

Re: [PATCH 2/2] add static typed insn_deleted_p

2014-09-11 Thread Trevor Saunders
On Thu, Sep 11, 2014 at 08:06:02PM -0400, David Malcolm wrote: On Thu, 2014-09-11 at 18:49 -0400, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This changes all callers of INSN_DELETED_P to use one of insn-deleted () insn-set_deleted () or insn

Re: [PATCHv3] Vimrc config with GNU formatting

2014-09-16 Thread Trevor Saunders
On Tue, Sep 16, 2014 at 08:38:58PM +0400, Yury Gribov wrote: Hi all, This is the third version of the patch. A list of changes since last version: * move config to contrib so that it's _not_ enabled by default (current score is 2/1 in favor of no Vim config by default) fwiw, I think

Re: [PATCH, PR63229] fix assert in hash_table pch routines

2014-09-23 Thread Trevor Saunders
On Fri, Sep 19, 2014 at 11:23:11AM +0100, Richard Sandiford wrote: tsaund...@mozilla.com writes: diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c048672..5b27aa8 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-09-12 Trevor Saunders tsaund...@mozilla.com

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

2013-09-04 Thread Trevor Saunders
On Wed, Sep 04, 2013 at 10:32:17AM +0200, Richard Biener wrote: On Wed, Sep 4, 2013 at 5:16 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com bootstrapped on x86_64-unknown-linux-gnu with same test results as unpatched r202185 ok? That looks like a not too

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

2013-09-18 Thread Trevor Saunders
On Wed, Sep 18, 2013 at 07:17:35PM +0200, Michael Matz wrote: I'd also like us to not use member privatization in our classes, but that's not in the patch, but if we could agree on that it would be nice. Member privatization is quite natural. What specifically do you not like about the

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

2013-09-19 Thread Trevor Saunders
On Thu, Sep 19, 2013 at 03:23:21PM +0200, Michael Matz wrote: I don't see anything in Trevor's work that requires jumping through hoops. Me neither, from that perspective it's okay. It's merely that I doubt the value of any syntactic privatization like it's implemented in C++, you can

Re: [PATCH] manage dom-walk_data initialization and finalization with constructors and destructors

2013-09-20 Thread Trevor Saunders
On Fri, Sep 20, 2013 at 10:13:27AM +0200, Richard Biener wrote: On Thu, Sep 19, 2013 at 8:11 PM, Richard Sandiford rdsandif...@googlemail.com wrote: Michael Matz m...@suse.de writes: What's the benefit of reading and writing such noisy lines? : *out_mode = mode_; mode_ =

ping [PATCH] rewrite stack vectors]

2013-10-23 Thread Trevor Saunders
Hi, ping ;) Trev - Forwarded message from tsaund...@mozilla.com - Date: Thu, 10 Oct 2013 14:07:22 -0400 From: tsaund...@mozilla.com To: dnovi...@google.com, gcc-patches@gcc.gnu.org Cc: Trevor Saunders tsaund...@mozilla.com Subject: [PATCH] rewrite stack vectors X-Mailer: git-send-email

Re: [PATCH] rewrite stack vectors

2013-10-25 Thread Trevor Saunders
On Fri, Oct 25, 2013 at 03:30:47PM -0400, Diego Novillo wrote: On 2013-10-10 14:07 , tsaund...@mozilla.com wrote: This makes the implementation of stack vectors simpler and easier to use. This

Re: [PATCH] use stack vectors more

2013-11-01 Thread Trevor Saunders
that rev yet). Trev Thanks. Diego. From 3e9b030811d3ff4f5605227171d33561ce59453e Mon Sep 17 00:00:00 2001 From: Trevor Saunders tsaund...@mozilla.com Date: Wed, 9 Oct 2013 14:19:29 -0400 Subject: [PATCH] use stack vectors more --- gcc/cp/semantics.c | 4 +--- gcc/function.c

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-11-01 Thread Trevor Saunders
It is a start, but it doesnt do the rest of the work that needs doing to really take advantage of it... which will be extensive. for instance, we should change: static inline void ! gimple_call_set_lhs (gimple gs, tree lhs) { - GIMPLE_CHECK (gs, GIMPLE_CALL);

Re: [PATCH 0/6] Conversion of gimple types to C++ inheritance (v3)

2013-11-06 Thread Trevor Saunders
On Wed, Nov 06, 2013 at 01:38:23PM -0700, Jeff Law wrote: On 11/05/13 16:23, Ian Lance Taylor wrote: On Tue, Nov 5, 2013 at 2:12 PM, Jeff Law l...@redhat.com wrote: I can't speak for Andrew, but my experience with this kind of object type casting in a large C++ project is that it's a red

Re: [PATCH] make has_gate and has_execute useless

2013-11-07 Thread Trevor Saunders
On Thu, Nov 07, 2013 at 10:30:16AM -0700, Jeff Law wrote: On 11/07/13 09:00, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This is the result of seeing what it would take to get rid of the has_gate and has_execute flags on pass_data. It turns out

Re: [PATCH] make has_gate and has_execute useless

2013-11-08 Thread Trevor Saunders
On Fri, Nov 08, 2013 at 10:37:00AM +0100, Richard Biener wrote: On Thu, Nov 7, 2013 at 5:00 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This is the result of seeing what it would take to get rid of the has_gate and has_execute flags

Re: [PATCH] make has_gate and has_execute useless

2013-11-10 Thread Trevor Saunders
On Fri, Nov 08, 2013 at 10:37:00AM +0100, Richard Biener wrote: On Thu, Nov 7, 2013 at 5:00 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This is the result of seeing what it would take to get rid of the has_gate and has_execute flags

Re: [PATCH] make has_gate and has_execute useless

2013-11-11 Thread Trevor Saunders
On Mon, Nov 11, 2013 at 12:58:36PM +0100, Richard Biener wrote: On Mon, Nov 11, 2013 at 1:39 AM, Trevor Saunders tsaund...@mozilla.com wrote: On Fri, Nov 08, 2013 at 10:37:00AM +0100, Richard Biener wrote: On Thu, Nov 7, 2013 at 5:00 PM, tsaund...@mozilla.com wrote: From: Trevor

Re: [RFC PATCH] add auto_bitmap

2013-11-14 Thread Trevor Saunders
On Thu, Nov 14, 2013 at 02:33:00PM -0700, Jeff Law wrote: On 11/14/13 14:14, Richard Biener wrote: I'm just pointed out that of all the stuff you changed, these were the only ones I saw where lifetimes were changed significantly. I still ask why we need a new type and cannot put this

Re: [RFC PATCH] add auto_bitmap

2013-11-15 Thread Trevor Saunders
On Fri, Nov 15, 2013 at 10:56:24AM +0100, Richard Biener wrote: On Thu, Nov 14, 2013 at 10:33 PM, Jeff Law l...@redhat.com wrote: On 11/14/13 14:14, Richard Biener wrote: I'm just pointed out that of all the stuff you changed, these were the only ones I saw where lifetimes were changed

Re: [PATCH] make has_gate and has_execute useless

2013-11-15 Thread Trevor Saunders
On Fri, Nov 15, 2013 at 12:54:05PM +0100, Richard Biener wrote: On Mon, Nov 11, 2013 at 5:13 PM, Trevor Saunders tsaund...@mozilla.com wrote: On Mon, Nov 11, 2013 at 12:58:36PM +0100, Richard Biener wrote: On Mon, Nov 11, 2013 at 1:39 AM, Trevor Saunders tsaund...@mozilla.com wrote

Re: [RFC PATCH] add auto_bitmap

2013-11-15 Thread Trevor Saunders
On Fri, Nov 15, 2013 at 12:11:07PM +0100, Richard Biener wrote: On Fri, Nov 15, 2013 at 11:37 AM, Trevor Saunders tsaund...@mozilla.com wrote: On Fri, Nov 15, 2013 at 10:56:24AM +0100, Richard Biener wrote: On Thu, Nov 14, 2013 at 10:33 PM, Jeff Law l...@redhat.com wrote: On 11/14/13 14

[PATCH] add auto_vec

2013-11-18 Thread Trevor Saunders
From: Trevor Saunders tsaund...@mozilla.com HI, This patch adds a class auto_vec which releases its internal storage in its destructor, but unlike stack_vec it has no built in storage so its reasonable to use it in objects on the heap. It then replaces a bunch of vectors on the stack

Re: [PATCH] add auto_vec

2013-11-18 Thread Trevor Saunders
On Mon, Nov 18, 2013 at 10:03:53PM +0100, Marc Glisse wrote: On Mon, 18 Nov 2013, Trevor Saunders wrote: This patch adds a class auto_vec which releases its internal storage in its destructor, but unlike stack_vec it has no built in storage so its reasonable to use it in objects on the heap

Re: [patch] Privatize gimplify_ctx structure.

2013-11-20 Thread Trevor Saunders
On Wed, Nov 20, 2013 at 03:18:07PM +0100, Richard Biener wrote: On Wed, Nov 20, 2013 at 3:16 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 20, 2013 at 03:12:34PM +0100, Richard Biener wrote: The limit looks reasonable, but you could have used a simple linked list (and never free).

Re: Factor unrelated declarations out of tree.h (1/2)

2013-11-20 Thread Trevor Saunders
On Wed, Nov 20, 2013 at 08:43:57AM -0500, Diego Novillo wrote: On Wed, Nov 20, 2013 at 6:44 AM, Eric Botcazou ebotca...@adacore.com wrote: Thanks. Committed as rev 205023. Nice work, but why did you antedate the entries in the various ChangeLog Oh, that's because of local commits and

  1   2   3   4   5   >