Re: Backported r185234 from trunk (r194264 from google/gcc-4_7). (issue 6904043)

2012-12-06 Thread shenhan
On 2012/12/07 00:29:39, asharif wrote: On 2012/12/06 22:02:16, Diego Novillo wrote: On Thu, Dec 6, 2012 at 4:51 PM, mailto:asha...@chromium.org wrote: I don't think the rule is to *only* update ChangeLog.google*. The rule is to update ChangeLog, but also update ChangeLog.google*.

[google/gcc-4_6] Added dejagnu base line for x86_64-cros-linux-gnu. (issue 5990044)

2012-04-05 Thread shenhan
Reviewers: asharif1, jingyu, Message: Hi Jing and Ahmad, This adds a new test base line for x86_64-cros-linux-gnu. Please take a look. Thanks, Han Description: The new test base line for x86_64-cros-linux-gnu. Please review this at http://codereview.appspot.com/5990044/ Affected files: A

[google/google-main] Fix regression - SUBTARGET_EXTRA_SPECS overridden by LINUX_GRTE_EXTRA_SPECS (issue 6016047)

2012-04-12 Thread shenhan
Reviewers: asharif1, jingyu, Diego Novillo, Message: Hi, the newest chrome gcc (from google-main) fails to linking anything, by looking into specs file, it seems that 'link_emulation' section is missing in specs. The problem I found is that SUBTARGET_EXTRA_SPECS, which is not empty for

Re: [google/gcc-4_6] Backport arm hardfp patch from trunk (issue 6206055)

2012-05-11 Thread shenhan
On 2012/05/11 18:48:40, carrot wrote: Please add ChangeLog and the trunk patch revision. Thanks. Trunk patch revision is 186859. ChangeLog entry added. Patch started. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 2f85855..588fa04 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@

Re: [google/gcc-4_6] Backport arm hardfp patch from trunk (issue 6206055)

2012-05-14 Thread shenhan
On 2012/05/11 22:15:37, carrot wrote: http://codereview.appspot.com/6206055/diff/4001/gcc/ChangeLog File gcc/ChangeLog (right): http://codereview.appspot.com/6206055/diff/4001/gcc/ChangeLog#newcode11 gcc/ChangeLog:11: It seems you also merged in another patch r187012, please mention it.

Re: [google/google-main] Fix regression - SUBTARGET_EXTRA_SPECS overridden by LINUX_GRTE_EXTRA_SPECS (issue 6016047)

2012-05-14 Thread shenhan
On 2012/04/12 21:14:29, shenhan wrote: Hi, the newest chrome gcc (from google-main) fails to linking anything, by looking into specs file, it seems that 'link_emulation' section is missing in specs. The problem I found is that SUBTARGET_EXTRA_SPECS, which is not empty for chromeos

[google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)

2012-05-15 Thread shenhan
Reviewers: asharif1, jingyu, Message: Hi Amhad and Jing, could you take a look at this CL at http://codereview.appspot.com/6210060/ Thanks, -Han Description: Ported r187569 from google/gcc-4_6 branch. 2012-05-11 Han Shen shen...@google.com Backport from mainline. 2012-05-01

Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)

2012-05-16 Thread shenhan
On 2012/05/16 17:27:59, asharif1 wrote: On 2012/05/16 01:02:26, shenhan wrote: Hi Amhad and Jing, could you take a look at this CL at http://codereview.appspot.com/6210060/ Thanks, -Han Shouldn't this have a corresponding ChangeLog entry and a ChangeLog.google-gcc-4_6 entry? Hi Ahmad

Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)

2012-05-16 Thread shenhan
On 2012/05/16 23:30:28, Diego Novillo wrote: On 12-05-16 19:22 , mailto:jin...@google.com wrote: In my opinion, gcc/ChangeLog is for upstream commits only. It is fine that you want to port upstream gcc/ChangeLog as well. Just remove your identities +2012-05-11 Han Shen

Re: [google]Backport to enable stack protector for Android targets (issue 6220051)

2012-05-18 Thread shenhan
On 2012/05/18 18:35:32, jingyu wrote: Backport from trunk r187586 http://gcc.gnu.org/ml/gcc-cvs/2012-05/msg00583.html Enable -fstack-protector support for Android targets. The patch only affects targets where __BIONIC__ is defined. Built Android arm toolchain. Would like to commit the

[PATCH] Add a new option -fstack-protector-strong (issue 6303078)

2012-06-14 Thread shenhan
Reviewers: , Message: Hi, this is to port the patch from google/main to trunk, which provides a new stack protection option - fstack-protector-strong. Previous review for google trunk is here - http://codereview.appspot.com/5461043 Status - it has been used in google/main for 2 quarters,

Re: [trunk] RFS: translate built-in include paths for sysroot (issue 5394041)

2011-11-15 Thread shenhan
On 2011/11/16 00:47:10, shenhan wrote: 2011-11-15 Han Shen mailto:shen...@google.com * gcc/Makefile.in: * gcc/configure: * gcc/cppdefault.c: diff --git a/gcc/Makefile.in b/gcc/Makefile.in index ae4f4da..0a05783 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in

Re: [trunk] RFS: translate built-in include paths for sysroot (issue 5394041)

2011-11-28 Thread shenhan
Hi, Joseph, get a chance to take a look? Thanks! -Han On 2011/11/19 00:10:20, shenhan wrote: Hi, Joseph, thanks! ChangeLog entries added to the issue description. ChangeLog * Makefile.in (GPLUSPLUS_INCLUDE_DIR_ADD_SYSROOT): add a macro definition to compile command

Re: [trunk] RFS: translate built-in include paths for sysroot (issue 5394041)

2011-12-05 Thread shenhan
Ping? http://codereview.appspot.com/5394041/