Re: [google][4.6] Bug fixes to function reordering linker plugin to handle local and comdat functions. (issue 5851044)

2012-03-20 Thread tmsriram
Uploaded new patch. On 2012/03/20 19:25:38, davidxl wrote: It would be nice to add some unit/regression test cases of some sort. Made the existing unit test case check the final layout. David http://codereview.appspot.com/5851044/diff/1/callgraph.c File callgraph.c (right):

Re: [google][4.6] Bug fixes to function reordering linker plugin to handle local and comdat functions. (issue 5851044)

2012-03-20 Thread tmsriram
On 2012/03/20 19:26:26, eraman wrote: http://codereview.appspot.com/5851044/diff/1/callgraph.c File callgraph.c (right): http://codereview.appspot.com/5851044/diff/1/callgraph.c#newcode513 callgraph.c:513: const int section_priority[] = {0, 3, 4, 2, 1}; Add a comment about section_priority

Re: [google][4.6] Bug fixes to function reordering linker plugin to handle local and comdat functions. (issue 5851044)

2012-03-21 Thread tmsriram
Committed to google/gcc-4_6 after validation. On 2012/03/21 05:07:33, davidxl wrote: ok for google branches after checkin validation. David http://codereview.appspot.com/5851044/

Re: [PATCH i386][google]With -mtune=core2, avoid generating the slow unaligned vector load/store (issue 5488054)

2011-12-13 Thread tmsriram
On 2011/12/14 00:04:10, davidxl wrote: http://codereview.appspot.com/5488054/diff/4002/tree-vect-stmts.c File tree-vect-stmts.c (right): http://codereview.appspot.com/5488054/diff/4002/tree-vect-stmts.c#newcode3712 tree-vect-stmts.c:3712: } The check can be put into a helper function.

Re: [4.6][google]Compiler Directed Function Multiversioning (issue 5477048)

2011-12-15 Thread tmsriram
Reviewers: davidxl, Message: I have uploaded a new patch. I did not split the patch into two because I felt the ifunc dispatch patch does nothing as a standalone. The framework now will do aggressive cloning and it will mark the clones specialized for core2 with -mtune=core2. I have already

Re: [google][4.6]Compiler Directed Multiversioning with new -mvarch option (issue 5490054)

2011-12-16 Thread tmsriram
I have uploaded a new patch set with all the mentioned changes made. If a function has the target attribute it will not be touched by the autoclone pass. Also fixed some test cases which were broken because the clone names used '_' instead of '.' for suffixing. On 2011/12/16 19:39:47, davidxl

Re: [google][4.6]Add new target builtin to check for amdfam15h processors (issue 5535046)

2012-01-11 Thread tmsriram
New patch uploaded with the changes. * i386.c (IX86_BUILTIN_CPU_IS_AMDFAM15H_BDVER1): New enum value. (IX86_BUILTIN_CPU_IS_AMDFAM15H_BDVER2): New enum value. (IX86_BUILTIN_CPU_IS_AMDFAM10H): Rename IX86_BUILTIN_CPU_IS_AMDFAM10.