Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-25 Thread Siddhesh Poyarekar
On Saturday 24 February 2018 03:28 AM, Martin Sebor wrote: > In my mind that would be a perfectly reasonable approach. > A variation on it might be to leave a new warning disabled > in the first release, then include it in -Wextra the next > release, and finally put it in -Wall. > > Unfortunately,

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Martin Sebor
On 02/23/2018 01:32 PM, Siddhesh Poyarekar wrote: On Saturday 24 February 2018 01:32 AM, Martin Sebor wrote: Casting the address of a function that takes one or more arguments to one that takes fewer is unsafe because when the pointer is used to call the function the extra arguments have indeter

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Siddhesh Poyarekar
On Saturday 24 February 2018 01:32 AM, Martin Sebor wrote: > Casting the address of a function that takes one or more arguments > to one that takes fewer is unsafe because when the pointer is used > to call the function the extra arguments have indeterminate values. > (This is also why void(*)(void

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Martin Sebor
On 02/23/2018 11:52 AM, Siddhesh Poyarekar wrote: On Saturday 24 February 2018 12:01 AM, Richard Biener wrote: I don't see how the function cast is valid. I've argued for void (*) () to/from void (*) (int), etc. In the past and that was shot down similarly. This looks like exactly the same thi

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Siddhesh Poyarekar
On Saturday 24 February 2018 12:01 AM, Richard Biener wrote: > I don't see how the function cast is valid. > > I've argued for void (*) () to/from void (*) (int), etc. In the past and that > was shot down similarly. This looks like exactly the same thing. That should not throw a warning becaus

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Richard Biener
On February 23, 2018 5:12:23 PM GMT+01:00, Siddhesh Poyarekar wrote: >On Friday 23 February 2018 09:20 PM, David Malcolm wrote: >> Do we have a PR open for this yet? >> >> I believe this is an example of where this bit (for the Python case): >> https://github.com/imageworks/OpenColorIO/pull/51

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread Siddhesh Poyarekar
On Friday 23 February 2018 09:20 PM, David Malcolm wrote: > Do we have a PR open for this yet? > > I believe this is an example of where this bit (for the Python case): > https://github.com/imageworks/OpenColorIO/pull/518 There is now: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84531 Siddhe

Re: [PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-23 Thread David Malcolm
On Fri, 2018-02-23 at 09:10 +0530, Siddhesh Poyarekar wrote: > Libraries like gtk/glib[1] and python[2] use functions with common > argument subsets to register callbacks. The working idea behind it > is > to have a flag in the structure (or some other pre-determined method) > that specifies how t

[PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-22 Thread Siddhesh Poyarekar
Libraries like gtk/glib[1] and python[2] use functions with common argument subsets to register callbacks. The working idea behind it is to have a flag in the structure (or some other pre-determined method) that specifies how the callback is cast and called. Fix this by not throwing a warning whe